Re: [PATCH] clk: Unlink clock if failed to prepare or enable

2020-05-05 Thread Stephen Boyd
Quoting Marc Zyngier (2020-05-05 07:09:53) > On failing to prepare or enable a clock, remove the core structure > from the list it has been inserted as it is about to be freed. > > This otherwise leads to random crashes when subsequent clocks get > registered, during which parsing of the clock

Re: [PATCH v6 1/2] dt-bindings: watchdog: Add ARM smc wdt for mt8173 watchdog

2020-05-05 Thread Rob Herring
On Tue, 5 May 2020 13:13:30 +1000, Evan Benn wrote: > This watchdog can be used on ARM systems with a Secure > Monitor firmware to forward watchdog operations to > firmware via a Secure Monitor Call. > > Signed-off-by: Evan Benn > > --- > > Changes in v6: > - Don't use dt default > > Changes

Re: [PATCH v6 1/7] dt-bindings: iio/adc: Convert ingenic-adc docs to YAML.

2020-05-05 Thread Rob Herring
On Sun, May 03, 2020 at 07:14:45PM +0200, Artur Rojek wrote: > Convert the textual documentation of Device Tree bindings for the > Ingenic JZ47xx SoCs ADC controller to YAML. > > The `interrupts` property is now explicitly listed and marked as > required. While missing from the previous textual

Re: [f2fs-dev] [PATCH] f2fs: get parent inode when recovering pino

2020-05-05 Thread Jaegeuk Kim
On 05/05, Eric Biggers wrote: > On Tue, May 05, 2020 at 11:49:32AM -0700, Jaegeuk Kim wrote: > > How about this? > > > > From 2a6b0e53e592854306062a2dc35db2d8f79062f2 Mon Sep 17 00:00:00 2001 > > From: Jaegeuk Kim > > Date: Tue, 5 May 2020 11:33:29 -0700 > > Subject: [PATCH] f2fs: find a living

[RFC] mm/gup.c: Updated return value of {get|pin}_user_pages_fast()

2020-05-05 Thread Souptick Joarder
Currently {get|pin}_user_pages_fast() have 3 return value 0, -errno and no of pinned pages. The only case where these two functions will return 0, is for nr_pages <= 0, which doesn't find a valid use case. But if at all any, then a -ERRNO will be returned instead of 0, which means

[PATCH 2/2] net: qed: Disable SRIOV functionality inside kdump kernel

2020-05-05 Thread Bhupesh Sharma
Since we have kdump kernel(s) running under severe memory constraint it makes sense to disable the qed SRIOV functionality when running the kdump kernel as kdump configurations on several distributions don't support SRIOV targets for saving the vmcore (see [1] for example). Currently the qed

[PATCH 1/2] net: qed*: Reduce RX and TX default ring count when running inside kdump kernel

2020-05-05 Thread Bhupesh Sharma
Normally kdump kernel(s) run under severe memory constraint with the basic idea being to save the crashdump vmcore reliably when the primary kernel panics/hangs. Currently the qed* ethernet driver ends up consuming a lot of memory in the kdump kernel, leading to kdump kernel panic when one tries

[PATCH 0/2] net: Optimize the qed* allocations inside kdump kernel

2020-05-05 Thread Bhupesh Sharma
Since kdump kernel(s) run under severe memory constraint with the basic idea being to save the crashdump vmcore reliably when the primary kernel panics/hangs, large memory allocations done by a network driver can cause the crashkernel to panic with OOM. The qed* drivers take up approximately

Re: [PATCH V6 3/4] backlight: qcom-wled: Add WLED5 bindings

2020-05-05 Thread Rob Herring
On Thu, 23 Apr 2020 21:03:36 +0530, Kiran Gunda wrote: > Add WLED5 specific bindings. > > Signed-off-by: Kiran Gunda > Signed-off-by: Subbaraman Narayanamurthy > Acked-by: Daniel Thompson > --- > .../bindings/leds/backlight/qcom-wled.yaml | 59 > -- > 1 file

Re: [PATCH V6 1/4] backlight: qcom-wled: convert the wled bindings to .yaml format

2020-05-05 Thread Rob Herring
On Thu, 23 Apr 2020 21:03:34 +0530, Kiran Gunda wrote: > Convert the qcom-wled bindings from .txt to .yaml format. > Also replace PM8941 to WLED3 and PMI8998 to WLED4. > > Signed-off-by: Kiran Gunda > Signed-off-by: Subbaraman Narayanamurthy > Acked-by: Daniel Thompson > --- >

Re: [PATCH] sysctl: fix unused function warning

2020-05-05 Thread Alexei Starovoitov
On Tue, May 5, 2020 at 11:25 AM Song Liu wrote: > > > > > On May 5, 2020, at 7:07 AM, Arnd Bergmann wrote: > > > > The newly added bpf_stats_handler function has the wrong #ifdef > > check around it, leading to an unused-function warning when > > CONFIG_SYSCTL is disabled: > > > >

Re: [f2fs-dev] [PATCH] f2fs: get parent inode when recovering pino

2020-05-05 Thread Eric Biggers
On Tue, May 05, 2020 at 11:49:32AM -0700, Jaegeuk Kim wrote: > How about this? > > From 2a6b0e53e592854306062a2dc35db2d8f79062f2 Mon Sep 17 00:00:00 2001 > From: Jaegeuk Kim > Date: Tue, 5 May 2020 11:33:29 -0700 > Subject: [PATCH] f2fs: find a living dentry when finding parent ino > > We need

Re: [PATCH net v2 0/2] Revert the 'socket_alloc' life cycle change

2020-05-05 Thread David Miller
From: David Miller Date: Tue, 05 May 2020 11:48:25 -0700 (PDT) > Series applied and queued up for -stable, thanks. Nevermind, this doesn't even compile. net/smc/af_smc.c: In function ‘smc_switch_to_fallback’: net/smc/af_smc.c:473:19: error: ‘smc->clcsock->wq’ is a pointer; did you mean to use

Re: [PATCH v4 14/18] static_call: Add static_cond_call()

2020-05-05 Thread Mathieu Desnoyers
- On May 5, 2020, at 2:48 PM, Linus Torvalds torva...@linux-foundation.org wrote: [...] > > Your initial reaction that "you can't compile away the read and the > test of NULL" was correct, I think. I suspect this pattern of "if (func != NULL) func(...)" could be semantically changed to just

[PATCH] efi/libstub/x86: Free EFI map buffer in allocate_e820()

2020-05-05 Thread Lenny Szubowicz
In allocate_e820(), free the EFI map buffer that has been returned by efi_get_memory_map(). The returned size of the EFI map buffer is used to allocate an adequately sized e820ext buffer, if it's needed. But the contents of that EFI map buffer is not used at all and the local pointer to it is gone

Re: [PATCH v7 5/6] dt-bindings: ARM: tegra: Add ASUS Google Nexus 7

2020-05-05 Thread Rob Herring
On Tue, 5 May 2020 05:25:16 +0300, Dmitry Osipenko wrote: > Add a binding for the Tegra30-based ASUS Google Nexus 7 tablet device. > > Signed-off-by: Dmitry Osipenko > --- > Documentation/devicetree/bindings/arm/tegra.yaml | 7 +++ > 1 file changed, 7 insertions(+) > Acked-by: Rob

Re: [PATCH v6 5/5] dt-bindings: arm: fsl: add different Protonic boards

2020-05-05 Thread Rob Herring
On Tue, 21 Apr 2020 14:40:57 +0200, Oleksij Rempel wrote: > Add Protonic PRTI6Q, WD2, RVT, VT7 boards. > > Signed-off-by: Oleksij Rempel > --- > Documentation/devicetree/bindings/arm/fsl.yaml | 4 > 1 file changed, 4 insertions(+) > Acked-by: Rob Herring

Re: splice() rcu_sched self-detected stall on CPU

2020-05-05 Thread Qian Cai
> On May 5, 2020, at 2:57 PM, Paul E. McKenney wrote: > > On Mon, May 04, 2020 at 03:11:09PM -0400, Qian Cai wrote: >> Running a syscall fuzzer inside a container on linux-next floods systems >> with soft lockups. It looks like stuck in this line at >> iov_iter_copy_from_user_atomic(),

Re: [PATCH RFC 6/6] KVM: x86: Switch KVM guest to using interrupts for page ready APF delivery

2020-05-05 Thread Vivek Goyal
On Wed, Apr 29, 2020 at 12:53:33PM +0200, Paolo Bonzini wrote: > On 29/04/20 11:36, Vitaly Kuznetsov wrote: > > + > > + if (__this_cpu_read(apf_reason.enabled)) { > > + reason = __this_cpu_read(apf_reason.reason); > > + if (reason == KVM_PV_REASON_PAGE_READY) { > > +

Re: [PATCH v7 4/6] dt-bindings: ARM: tegra: Add Acer Iconia Tab A500

2020-05-05 Thread Rob Herring
On Tue, 5 May 2020 05:25:15 +0300, Dmitry Osipenko wrote: > Add a binding for the Tegra20-based Acer Iconia Tab A500 tablet device. > > Signed-off-by: Dmitry Osipenko > --- > Documentation/devicetree/bindings/arm/tegra.yaml | 3 +++ > 1 file changed, 3 insertions(+) > Acked-by: Rob Herring

Re: [PATCH v7 3/6] dt-bindings: Add vendor prefix for Acer Inc.

2020-05-05 Thread Rob Herring
On Tue, 5 May 2020 05:25:14 +0300, Dmitry Osipenko wrote: > Acer is a hardware and electronics corporation, specializing in advanced > electronics technology. Acer's products include desktop PCs, laptop PCs, > tablets, servers, displays, storage devices, virtual reality devices, > smartphones and

Re: splice() rcu_sched self-detected stall on CPU

2020-05-05 Thread Paul E. McKenney
On Mon, May 04, 2020 at 03:11:09PM -0400, Qian Cai wrote: > Running a syscall fuzzer inside a container on linux-next floods systems with > soft lockups. It looks like stuck in this line at > iov_iter_copy_from_user_atomic(), Thoughts? > > iterate_all_kinds(i, bytes, v, >

Re: [PATCH v4 14/18] static_call: Add static_cond_call()

2020-05-05 Thread Linus Torvalds
On Tue, May 5, 2020 at 11:28 AM Nick Desaulniers wrote: > > Changing > void *func = READ_ONCE(name.func); \ > to > void *func = _ONCE(name.func); \ What? That makes no sense. Yes, void *func = foo; and void *func = are the same thing, _if_ "foo" is an actual function, because then

Re: Re: Re: Re: [PATCH net v2 0/2] Revert the 'socket_alloc' life cycle change

2020-05-05 Thread Paul E. McKenney
On Tue, May 05, 2020 at 08:34:02PM +0200, SeongJae Park wrote: > On Tue, 5 May 2020 11:17:07 -0700 "Paul E. McKenney" > wrote: > > > On Tue, May 05, 2020 at 07:56:05PM +0200, SeongJae Park wrote: > > > On Tue, 5 May 2020 10:30:36 -0700 "Paul E. McKenney" > > > wrote: > > > > > > > On Tue,

Re: [PATCH net-next] net: ethernet: ti: am65-cpts: fix build

2020-05-05 Thread Anders Roxell
On Tue, 5 May 2020 at 18:21, Grygorii Strashko wrote: > > It's possible to have build configuration which will force PTP_1588_CLOCK=m > and so TI_K3_AM65_CPTS=m while still have TI_K3_AM65_CPSW_NUSS=y. This will > cause build failures: > > aarch64-linux-gnu-ld:

Re: [f2fs-dev] [PATCH] f2fs: get parent inode when recovering pino

2020-05-05 Thread Jaegeuk Kim
On 05/05, Eric Biggers wrote: > On Tue, May 05, 2020 at 11:13:23AM -0700, Jaegeuk Kim wrote: > > On 05/05, Eric Biggers wrote: > > > On Tue, May 05, 2020 at 08:31:39AM -0700, Jaegeuk Kim wrote: > > > > We had to grab the inode before retrieving i_ino. > > > > > > > > Signed-off-by: Jaegeuk Kim >

Re: [PATCH net v2 0/2] Revert the 'socket_alloc' life cycle change

2020-05-05 Thread David Miller
From: SeongJae Park Date: Tue, 5 May 2020 10:10:33 +0200 > From: SeongJae Park > > The commit 6d7855c54e1e ("sockfs: switch to ->free_inode()") made the > deallocation of 'socket_alloc' to be done asynchronously using RCU, as > same to 'sock.wq'. And the following commit 333f7909a857

Re: Re: Re: [PATCH net v2 0/2] Revert the 'socket_alloc' life cycle change

2020-05-05 Thread Paul E. McKenney
On Tue, May 05, 2020 at 08:40:07PM +0200, SeongJae Park wrote: > On Tue, 5 May 2020 11:27:20 -0700 "Paul E. McKenney" > wrote: > > > On Tue, May 05, 2020 at 07:49:43PM +0200, SeongJae Park wrote: > > > On Tue, 5 May 2020 10:23:58 -0700 "Paul E. McKenney" > > > wrote: > > > > > > > On Tue,

[PATCH] x86/mm: Don't try to change poison pages to uncacheable in a guest

2020-05-05 Thread Tony Luck
An interesting thing happened when a guest Linux instance took a machine check. The VMM unmapped the bad page from guest physical space and passed the machine check to the guest. Linux took all the normal actions to offline the page from the process that was using it. But then guest Linux crashed

Re: [PATCH] drm/bridge: ti-sn65dsi86: Implement lane reordering + polarity

2020-05-05 Thread Doug Anderson
Hi On Mon, May 4, 2020 at 10:44 PM Stephen Boyd wrote: > > Quoting Douglas Anderson (2020-05-04 21:36:31) > > The ti-sn65dsi86 MIPI DSI to eDP bridge chip supports arbitrary > > remapping of eDP lanes and also polarity inversion. Both of these > > features have been described in the device tree

Re: [RFC][PATCH] kexec: Teach indirect pages how to live in high memory

2020-05-05 Thread Eric W. Biederman
Hari Bathini writes: > On 05/05/20 3:29 am, Eric W. Biederman wrote: >> >> Recently a patch was proposed to kimage_alloc_page to slightly alter >> the logic of how pages allocated with incompatible flags were >> detected. The logic was being altered because the semantics of the >> page

Re: [PATCH] ARM: dts: omap3: Migrate AES from hwmods to sysc-omap2

2020-05-05 Thread Tony Lindgren
* Adam Ford [200504 16:02]: > Various OMAP3 boards have two AES blocks, but only one is currently > available, because the hwmods are only configured for one. > > This patch migrates the hwmods for the AES engine to sysc-omap2 > which allows the second AES crypto engine to become available. > >

Re: [PATCH net-next] net: ethernet: ti: use true,false for bool variables in cpsw_new.c

2020-05-05 Thread David Miller
From: Jason Yan Date: Tue, 5 May 2020 15:46:23 +0800 > Fix the following coccicheck warning: > > drivers/net/ethernet/ti/cpsw_new.c:1924:2-17: WARNING: Assignment of > 0/1 to bool variable > drivers/net/ethernet/ti/cpsw_new.c:1231:1-16: WARNING: Assignment of > 0/1 to bool variable > >

Re: Re: Re: [PATCH net v2 0/2] Revert the 'socket_alloc' life cycle change

2020-05-05 Thread SeongJae Park
On Tue, 5 May 2020 11:27:20 -0700 "Paul E. McKenney" wrote: > On Tue, May 05, 2020 at 07:49:43PM +0200, SeongJae Park wrote: > > On Tue, 5 May 2020 10:23:58 -0700 "Paul E. McKenney" > > wrote: > > > > > On Tue, May 05, 2020 at 09:25:06AM -0700, Eric Dumazet wrote: > > > > > > > > > > > > On

Re: [PATCH net-next] net: atheros: remove conversion to bool in atl1c_start_mac()

2020-05-05 Thread David Miller
From: Jason Yan Date: Tue, 5 May 2020 15:45:46 +0800 > No need to convert '==' expression to bool. This fixes the following > coccicheck warning: > > drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1189:63-68: WARNING: > conversion to bool not needed here > > Signed-off-by: Jason Yan

Re: [PATCH net-next] net: agere: use true,false for bool variable

2020-05-05 Thread David Miller
From: Jason Yan Date: Tue, 5 May 2020 15:45:56 +0800 > Fix the following coccicheck warning: > > drivers/net/ethernet/agere/et131x.c:717:3-22: WARNING: Assignment of > 0/1 to bool variable > drivers/net/ethernet/agere/et131x.c:721:1-20: WARNING: Assignment of > 0/1 to bool variable > >

Re: [PATCH net-next] net: bnxt: Remove Comparison to bool in bnxt_ethtool.c

2020-05-05 Thread David Miller
From: Jason Yan Date: Tue, 5 May 2020 15:46:08 +0800 > Fix the following coccicheck warning: > > drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:1991:5-46: WARNING: > Comparison to bool > drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:1993:10-54: WARNING: > Comparison to bool >

Re: [PATCH net-next] net: qede: Use true for bool variable in qede_init_fp()

2020-05-05 Thread David Miller
From: Jason Yan Date: Tue, 5 May 2020 15:45:39 +0800 > Fix the following coccicheck warning: > > drivers/net/ethernet/qlogic/qede/qede_main.c:1717:5-19: WARNING: > Assignment of 0/1 to bool variable > > Signed-off-by: Jason Yan Applied.

Re: [PATCH net-next] qlcnic: use true,false for bool variable in qlcnic_sriov_common.c

2020-05-05 Thread David Miller
From: Jason Yan Date: Tue, 5 May 2020 15:43:49 +0800 > Fix the following coccicheck warning: > > drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c:1585:3-25: > WARNING: Assignment of 0/1 to bool variable > drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c:1588:3-25: > WARNING:

Re: [PATCH net-next] bnx2x: Remove Comparison to bool in bnx2x_dcb.c

2020-05-05 Thread David Miller
From: Jason Yan Date: Tue, 5 May 2020 15:44:00 +0800 > Fix the following coccicheck warning: > > drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c:1548:17-31: WARNING: > Comparison to bool > drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c:1148:16-24: WARNING: > Comparison to bool >

Re: [PATCH 3/3] vfio-pci: Invalidate mmaps and block MMIO access on disabled memory

2020-05-05 Thread Jason Gunthorpe
On Tue, May 05, 2020 at 11:12:27AM -0600, Alex Williamson wrote: > > As noted in the comment, the fault handler can simply do: > > mutex_lock(>vma_lock); > down_read(>memory_lock); > > This should be deadlock free now, so we can drop the retry handling That does look like the right direction,

Re: DRM interaction problems on Ingenic CI20 / jz4780 with dw-hdmi and ingenic-drm

2020-05-05 Thread Paul Boddie
On Monday 4. May 2020 03.05.22 Paul Cercueil wrote: > > > Le sam. 11 avril 2020 à 16:14, H. Nikolaus Schaller a > > écrit : > >> > >> So far we have identified two issues. > >> > >> The first is that HPD interrupts are not properly processed. > >> > >> drm_helper_hpd_irq_event() is called by

Re: Re: Re: Re: [PATCH net v2 0/2] Revert the 'socket_alloc' life cycle change

2020-05-05 Thread SeongJae Park
On Tue, 5 May 2020 11:17:07 -0700 "Paul E. McKenney" wrote: > On Tue, May 05, 2020 at 07:56:05PM +0200, SeongJae Park wrote: > > On Tue, 5 May 2020 10:30:36 -0700 "Paul E. McKenney" > > wrote: > > > > > On Tue, May 05, 2020 at 07:05:53PM +0200, SeongJae Park wrote: > > > > On Tue, 5 May 2020

Re: [PATCH RFC] rcu/tree: Refactor object allocation and try harder for array allocation

2020-05-05 Thread Uladzislau Rezki
> > b) Double argument(with rcu_head) > > This case we consider as it gets called from atomic context even though > > it can be not. Why we consider such case as atomic: we just assume that. > > The reason is to keep it simple, because it is not possible to detect > > whether > > a current

Re: [PATCH v12 4/4] perf tools: add support for libpfm4

2020-05-05 Thread Ian Rogers
On Thu, Apr 30, 2020 at 7:26 AM Ian Rogers wrote: > > On Thu, Apr 30, 2020 at 6:34 AM Arnaldo Carvalho de Melo > wrote: > > > > Em Wed, Apr 29, 2020 at 04:14:43PM -0700, Ian Rogers escreveu: > > > From: Stephane Eranian > > > > > > This patch links perf with the libpfm4 library if it is

[PATCH v2] kcsan: Add test suite

2020-05-05 Thread Marco Elver
This adds KCSAN test focusing on behaviour of the integrated runtime. Tests various race scenarios, and verifies the reports generated to console. Makes use of KUnit for test organization, and the Torture framework for test thread control. Signed-off-by: Marco Elver --- v2: * Add necessary

[PATCH v14 0/1] perf tools: add support for libpfm4

2020-05-05 Thread Ian Rogers
This patch links perf with the libpfm4 library if it is available and LIBPFM4 is passed to the build. The libpfm4 library contains hardware event tables for all processors supported by perf_events. It is a helper library that helps convert from a symbolic event name to the event encoding required

[PATCH v14 1/1] perf tools: add support for libpfm4

2020-05-05 Thread Ian Rogers
From: Stephane Eranian This patch links perf with the libpfm4 library if it is available and LIBPFM4 is passed to the build. The libpfm4 library contains hardware event tables for all processors supported by perf_events. It is a helper library that helps convert from a symbolic event name to the

Re: [PATCH v4 14/18] static_call: Add static_cond_call()

2020-05-05 Thread Nick Desaulniers
On Tue, May 5, 2020 at 11:13 AM Nick Desaulniers wrote: > > On Tue, May 5, 2020 at 2:36 AM Peter Zijlstra wrote: > > > > > > HJ, Nick, > > > > Any chance any of you can see a way to make your respective compilers > > not emit utter junk for this? > > > > On Mon, May 04, 2020 at 10:14:45PM +0200,

Re: Re: [PATCH net v2 0/2] Revert the 'socket_alloc' life cycle change

2020-05-05 Thread Paul E. McKenney
On Tue, May 05, 2020 at 07:49:43PM +0200, SeongJae Park wrote: > On Tue, 5 May 2020 10:23:58 -0700 "Paul E. McKenney" > wrote: > > > On Tue, May 05, 2020 at 09:25:06AM -0700, Eric Dumazet wrote: > > > > > > > > > On 5/5/20 9:13 AM, SeongJae Park wrote: > > > > On Tue, 5 May 2020 09:00:44

Re: [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY

2020-05-05 Thread Grygorii Strashko
On 22/04/2020 10:21, Oleksij Rempel wrote: Add support for following phy-modes: rgmii, rgmii-id, rgmii-txid, rgmii-rxid. This PHY has an internal RX delay of 1.2ns and no delay for TX. The pad skew registers allow to set the total TX delay to max 1.38ns and the total RX delay to max of

Re: [PATCH v2 12/15] ARM: omap2plus: Drop unneeded select of MIGHT_HAVE_CACHE_L2X0

2020-05-05 Thread Tony Lindgren
* Geert Uytterhoeven [200505 08:08]: > Support for TI AM43x SoCs depends on ARCH_MULTI_V7, which selects > ARCH_MULTI_V6_V7. > As the latter selects MIGHT_HAVE_CACHE_L2X0, there is no need for > SOC_AM43XX to select MIGHT_HAVE_CACHE_L2X0. > > Signed-off-by: Geert Uytterhoeven > Cc: Tony

Re: [PATCH] sysctl: fix unused function warning

2020-05-05 Thread Song Liu
> On May 5, 2020, at 7:07 AM, Arnd Bergmann wrote: > > The newly added bpf_stats_handler function has the wrong #ifdef > check around it, leading to an unused-function warning when > CONFIG_SYSCTL is disabled: > > kernel/sysctl.c:205:12: error: unused function 'bpf_stats_handler' >

Re: [PATCH] x86: bitops: fix build regression

2020-05-05 Thread Nick Desaulniers
On Tue, May 5, 2020 at 11:07 AM wrote: > > On May 5, 2020 10:44:22 AM PDT, Nick Desaulniers > wrote: > >From: Sedat Dilek > > > >It turns out that if your config tickles __builtin_constant_p via > >differences in choices to inline or not, this now produces invalid > >assembly: > > > >$ cat

Re: [PATCH net-next] net: sched: choke: Remove unused inline function choke_set_classid

2020-05-05 Thread Cong Wang
On Tue, May 5, 2020 at 1:49 AM YueHaibing wrote: > > There's no callers in-tree anymore since commit 5952fde10c35 ("net: > sched: choke: remove dead filter classify code") While you are at this, please also remove classid from struct choke_skb_cb. Thanks.

Re: [PATCH v3 2/5] bus: stm32: Introduce firewall controller helpers

2020-05-05 Thread Greg KH
On Tue, May 05, 2020 at 03:00:53PM +, Benjamin GAIGNARD wrote: > > > On 5/5/20 4:40 PM, Greg KH wrote: > > On Tue, May 05, 2020 at 09:33:05AM +0200, Benjamin Gaignard wrote: > >> The goal of these helpers are to offer an interface for the > >> hardware blocks controlling bus accesses rights.

Re: [f2fs-dev] [PATCH] f2fs: get parent inode when recovering pino

2020-05-05 Thread Jaegeuk Kim
On 05/05, Eric Biggers wrote: > On Tue, May 05, 2020 at 09:58:47AM -0700, Eric Biggers wrote: > > On Tue, May 05, 2020 at 08:31:39AM -0700, Jaegeuk Kim wrote: > > > We had to grab the inode before retrieving i_ino. > > > > > > Signed-off-by: Jaegeuk Kim > > > --- > > > fs/f2fs/file.c | 8

Re: [PATCH] mmc: rtsx: Add SD Express mode support for RTS5261

2020-05-05 Thread Ulf Hansson
On Tue, 28 Apr 2020 at 05:44, 冯锐 wrote: > > > > > On Mon, Apr 27, 2020 at 11:41 AM 冯锐 wrote: > > > > > > > > > > On Sun, Apr 26, 2020 at 09:25:46AM +0800, rui_f...@realsil.com.cn > > wrote: > > > > > From: Rui Feng > > > > > > > > > > RTS5261 support legacy SD mode and SD Express mode. > > > >

Re: [f2fs-dev] [PATCH] f2fs: get parent inode when recovering pino

2020-05-05 Thread Eric Biggers
On Tue, May 05, 2020 at 11:13:23AM -0700, Jaegeuk Kim wrote: > On 05/05, Eric Biggers wrote: > > On Tue, May 05, 2020 at 08:31:39AM -0700, Jaegeuk Kim wrote: > > > We had to grab the inode before retrieving i_ino. > > > > > > Signed-off-by: Jaegeuk Kim > > > --- > > > fs/f2fs/file.c | 8

Re: [PATCH] Input: edt-ft5x06: Use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs fops

2020-05-05 Thread Greg Kroah-Hartman
On Tue, May 05, 2020 at 09:03:24PM +0530, Aishwarya Ramakrishnan wrote: > It is more clear to use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs file > operation rather than DEFINE_SIMPLE_ATTRIBUTE. No it is not, why do you think so? The two defines do different things, that is why we have 2

Re: [PATCH RFC] rcu/tree: Refactor object allocation and try harder for array allocation

2020-05-05 Thread Johannes Weiner
On Thu, Apr 23, 2020 at 09:59:55PM +0200, Uladzislau Rezki wrote: > b) Double argument(with rcu_head) > This case we consider as it gets called from atomic context even though > it can be not. Why we consider such case as atomic: we just assume that. > The reason is to keep it simple, because it

Re: [PATCH 0/3] selftests: vdso: Add a selftest for vDSO getcpu()

2020-05-05 Thread shuah
On 5/5/20 11:47 AM, Mark Brown wrote: This series does a bit of a cleanup of the existing tests for the vDSO in kselftest and then adds a new test for getcpu(). Mark Brown (3): selftests: vdso: Rename vdso_test to vdso_test_gettimeofday selftests: vdso: Use a header file to prototype

Re: Re: Re: [PATCH net v2 0/2] Revert the 'socket_alloc' life cycle change

2020-05-05 Thread Paul E. McKenney
On Tue, May 05, 2020 at 07:56:05PM +0200, SeongJae Park wrote: > On Tue, 5 May 2020 10:30:36 -0700 "Paul E. McKenney" > wrote: > > > On Tue, May 05, 2020 at 07:05:53PM +0200, SeongJae Park wrote: > > > On Tue, 5 May 2020 09:37:42 -0700 Eric Dumazet > > > wrote: > > > > > > > > > > > > > >

Re: [PATCH v5 8/8] bus: mhi: core: Ensure non-zero session or sequence ID values are used

2020-05-05 Thread bbhatt
On 2020-05-05 08:57, Jeffrey Hugo wrote: On 5/4/2020 8:44 PM, Bhaumik Bhatt wrote: While writing any sequence or session identifiers, it is possible that the host could write a zero value, whereas only non-zero values should be supported writes to those registers. Ensure that the host does not

Re: [PATCH] sysctl: fix unused function warning

2020-05-05 Thread Luis Chamberlain
On Tue, May 05, 2020 at 04:07:12PM +0200, Arnd Bergmann wrote: > The newly added bpf_stats_handler function has the wrong #ifdef > check around it, leading to an unused-function warning when > CONFIG_SYSCTL is disabled: > > kernel/sysctl.c:205:12: error: unused function 'bpf_stats_handler' >

Re: [PATCH v4 14/18] static_call: Add static_cond_call()

2020-05-05 Thread Nick Desaulniers
On Tue, May 5, 2020 at 2:36 AM Peter Zijlstra wrote: > > > HJ, Nick, > > Any chance any of you can see a way to make your respective compilers > not emit utter junk for this? > > On Mon, May 04, 2020 at 10:14:45PM +0200, Peter Zijlstra wrote: > > > https://godbolt.org/z/SDRG2q Woah, a godbolt

Re: [patch V4 part 1 36/36] rcu: Make RCU IRQ enter/exit functions rely on in_nmi()

2020-05-05 Thread Paul E. McKenney
On Tue, May 05, 2020 at 03:16:38PM +0200, Thomas Gleixner wrote: > From: Paul E. McKenney > > The rcu_nmi_enter_common() and rcu_nmi_exit_common() functions take an > "irq" parameter that indicates whether these functions are invoked from > an irq handler (irq==true) or an NMI handler

Re: [f2fs-dev] [PATCH] f2fs: get parent inode when recovering pino

2020-05-05 Thread Jaegeuk Kim
On 05/05, Eric Biggers wrote: > On Tue, May 05, 2020 at 08:31:39AM -0700, Jaegeuk Kim wrote: > > We had to grab the inode before retrieving i_ino. > > > > Signed-off-by: Jaegeuk Kim > > --- > > fs/f2fs/file.c | 8 +++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git

Re: [PATCH 5.6 00/73] 5.6.11-rc1 review

2020-05-05 Thread Greg Kroah-Hartman
On Tue, May 05, 2020 at 07:57:55PM +0530, Naresh Kamboju wrote: > On Mon, 4 May 2020 at 23:36, Greg Kroah-Hartman > wrote: > > > > This is the start of the stable review cycle for the 5.6.11 release. > > There are 73 patches in this series, all will be posted as a response > > to this one. If

Re: [PATCH net v1] net: broadcom: fix a mistake about ioremap resource

2020-05-05 Thread David Miller
From: Dejin Zheng Date: Tue, 5 May 2020 10:03:29 +0800 > Commit d7a5502b0bb8b ("net: broadcom: convert to > devm_platform_ioremap_resource_byname()") will broke this driver. > idm_base and nicpm_base were optional, after this change, they are > mandatory. it will probe fails with -22 when the

Re: [PATCH 5.6 00/73] 5.6.11-rc1 review

2020-05-05 Thread Greg Kroah-Hartman
On Tue, May 05, 2020 at 08:45:59AM -0700, Guenter Roeck wrote: > On 5/4/20 10:57 AM, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.6.11 release. > > There are 73 patches in this series, all will be posted as a response > > to this one. If anyone has any

Re: Re: [PATCH net v2 0/2] Revert the 'socket_alloc' life cycle change

2020-05-05 Thread SeongJae Park
On Tue, 5 May 2020 10:28:50 -0700 "Paul E. McKenney" wrote: > On Tue, May 05, 2020 at 09:37:42AM -0700, Eric Dumazet wrote: > > > > > > On 5/5/20 9:31 AM, Eric Dumazet wrote: > > > > > > > > > On 5/5/20 9:25 AM, Eric Dumazet wrote: > > >> > > >> > > >> On 5/5/20 9:13 AM, SeongJae Park wrote:

Re: [PATCH] bpf: Tweak BPF jump table optimizations for objtool compatibility

2020-05-05 Thread Josh Poimboeuf
churn, > so how about we step back and debug it first? > Which version of gcc are you using and what .config? > I've tried: > Linux version 5.7.0-rc2 (gcc version 10.0.1 20200505 (prerelease) (GCC) > CONFIG_UNWINDER_ORC=y > # CONFIG_RETPOLINE is not set > > and objtool d

Re: [PATCH] media: usb: ttusb-dec: avoid buffer overflow in ttusb_dec_handle_irq() when DMA failures/attacks occur

2020-05-05 Thread Greg KH
On Tue, May 05, 2020 at 10:21:10PM +0800, Jia-Ju Bai wrote: > In ttusb_dec_init_usb(): > dec->irq_buffer = usb_alloc_coherent(...) Nice. > Thus, "dec->irq_buffer" is a DMA value, and it is assigned to "buffer" > in ttusb_dec_handle_irq(): > char *buffer = dec->irq_buffer; Nice. > When DMA

Re: [PATCH] sysctl: fix unused function warning

2020-05-05 Thread Martin KaFai Lau
On Tue, May 05, 2020 at 04:07:12PM +0200, Arnd Bergmann wrote: > The newly added bpf_stats_handler function has the wrong #ifdef > check around it, leading to an unused-function warning when > CONFIG_SYSCTL is disabled: > > kernel/sysctl.c:205:12: error: unused function 'bpf_stats_handler' >

Re: [PATCH] x86: bitops: fix build regression

2020-05-05 Thread hpa
On May 5, 2020 10:44:22 AM PDT, Nick Desaulniers wrote: >From: Sedat Dilek > >It turns out that if your config tickles __builtin_constant_p via >differences in choices to inline or not, this now produces invalid >assembly: > >$ cat foo.c >long a(long b, long c) { > asm("orb\t%1, %0" : "+q"(c):

Re: [PATCH] clocksource/drivers/timer-ti-dm: Do one override clock parent in prepare()

2020-05-05 Thread Tony Lindgren
* Tony Lindgren [200428 18:23]: > * Lokesh Vutla [200427 17:29]: > > omap_dm_timer_prepare() is setting up the parent 32KHz clock. This > > prepare() gets called by request_timer in the client's driver. Because of > > this, the timer clock parent that is set with assigned-clock-parent is being >

Re: [patch V4 part 1 25/36] rcu/tree: Mark the idle relevant functions noinstr

2020-05-05 Thread Paul E. McKenney
On Tue, May 05, 2020 at 03:16:27PM +0200, Thomas Gleixner wrote: > These functions are invoked from context tracking and other places in the > low level entry code. Move them into the .noinstr.text section to exclude > them from instrumentation. > > Mark the places which are safe to invoke

Re: [PATCH 06/11] net: ethernet: mtk-eth-mac: new driver

2020-05-05 Thread Jakub Kicinski
On Tue, 5 May 2020 16:02:26 +0200 Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > This adds the driver for the MediaTek Ethernet MAC used on the MT8* SoC > family. For now we only support full-duplex. > > Signed-off-by: Bartosz Golaszewski > +#define MTK_MAC_VERSION

Re: [PATCH v2 5/6] sched/deadline: Make DL capacity-aware

2020-05-05 Thread Dietmar Eggemann
On 04/05/2020 05:58, Pavan Kondeti wrote: > On Fri, May 01, 2020 at 06:12:07PM +0200, Dietmar Eggemann wrote: >> On 30/04/2020 15:10, Pavan Kondeti wrote: >>> On Mon, Apr 27, 2020 at 10:37:08AM +0200, Dietmar Eggemann wrote: From: Luca Abeni >> >> [...] >> @@ -1653,10 +1654,19 @@

Re: [PATCH 0/4] eliminate SECTOR related magic numbers and duplicated conversions

2020-05-05 Thread Matthew Wilcox
On Tue, May 05, 2020 at 06:32:36PM +0100, antlists wrote: > On 05/05/2020 12:55, Zhen Lei wrote: > > When I studied the code of mm/swap, I found "1 << (PAGE_SHIFT - 9)" appears > > many times. So I try to clean up it. > > > > 1. Replace "1 << (PAGE_SHIFT - 9)" or similar with SECTORS_PER_PAGE > >

Re: [PATCH] drm/bridge: ti-sn65dsi86: Implement lane reordering + polarity

2020-05-05 Thread Doug Anderson
Hi, On Tue, May 5, 2020 at 1:24 AM Laurent Pinchart wrote: > > Hi Douglas, > > Thank you for the patch. > > On Mon, May 04, 2020 at 09:36:31PM -0700, Douglas Anderson wrote: > > The ti-sn65dsi86 MIPI DSI to eDP bridge chip supports arbitrary > > remapping of eDP lanes and also polarity

Re: [PATCH v2 5/5] arm/arm64: smccc: Add ARCH_SOC_ID support

2020-05-05 Thread Sudeep Holla
On Tue, May 05, 2020 at 05:20:50PM +0100, Will Deacon wrote: > On Mon, May 04, 2020 at 10:29:05AM +0100, Sudeep Holla wrote: > > diff --git a/drivers/firmware/psci/soc_id.c b/drivers/firmware/psci/soc_id.c > > new file mode 100644 > > index ..b45f2d78e12e > > --- /dev/null > > +++

Re: [f2fs-dev] [PATCH] f2fs: get parent inode when recovering pino

2020-05-05 Thread Eric Biggers
On Tue, May 05, 2020 at 09:58:47AM -0700, Eric Biggers wrote: > On Tue, May 05, 2020 at 08:31:39AM -0700, Jaegeuk Kim wrote: > > We had to grab the inode before retrieving i_ino. > > > > Signed-off-by: Jaegeuk Kim > > --- > > fs/f2fs/file.c | 8 +++- > > 1 file changed, 7 insertions(+), 1

Re: Re: Re: [PATCH net v2 0/2] Revert the 'socket_alloc' life cycle change

2020-05-05 Thread SeongJae Park
On Tue, 5 May 2020 10:30:36 -0700 "Paul E. McKenney" wrote: > On Tue, May 05, 2020 at 07:05:53PM +0200, SeongJae Park wrote: > > On Tue, 5 May 2020 09:37:42 -0700 Eric Dumazet > > wrote: > > > > > > > > > > > On 5/5/20 9:31 AM, Eric Dumazet wrote: > > > > > > > > > > > > On 5/5/20 9:25

Re: [PATCH v2] block: Make request_queue.rpm_status an enum

2020-05-05 Thread Bart Van Assche
On 2020-05-05 07:03, Geert Uytterhoeven wrote: > request_queue.rpm_status is assigned values of the rpm_status enum only, > so reflect that in its type. > > Signed-off-by: Geert Uytterhoeven > Acked-by: Rafael J. Wysocki > --- > Perhaps this was done to avoid the need to #include ? > Let's see

Re: [patch V4 part 1 12/36] x86/kvm: Sanitize kvm_async_pf_task_wait()

2020-05-05 Thread Paul E. McKenney
On Tue, May 05, 2020 at 03:16:14PM +0200, Thomas Gleixner wrote: > From: Thomas Gleixner > > While working on the entry consolidation I stumbled over the KVM async page > fault handler and kvm_async_pf_task_wait() in particular. It took me a > while to realize that the randomly sprinkled around

Re: [RFC PATCH v1] ima: verify mprotect change is consistent with mmap policy

2020-05-05 Thread Lakshmi Ramasubramanian
On 5/5/20 10:30 AM, Mimi Zohar wrote: Files can be mmap'ed read/write and later changed to execute to circumvent IMA's mmap appraise policy rules. Due to locking issues (mmap semaphore would be taken prior to i_mutex), files can not be measured or appraised at this point. Eliminate this

Re: [PATCH] MAINTAINERS: Add missing header files to BLOCK LAYER section

2020-05-05 Thread Bart Van Assche
On 2020-05-05 07:07, Geert Uytterhoeven wrote: > The various header files are part of the Block Layer. > Add them to the corresponding section in the MAINTAINERS file, so > scripts/get_maintainer.pl will pick them up. > > Signed-off-by: Geert Uytterhoeven > --- > MAINTAINERS | 1 + > 1 file

[PATCH 2/3] selftests: vdso: Use a header file to prototype parse_vdso API

2020-05-05 Thread Mark Brown
Both vdso_test_gettimeofday and vdso_standalone_test_x86 use the library in parse_vdso.c but each separately declares the API it offers which is not ideal. Create a header file with prototypes of the functions and use it in both the library and the tests to ensure that the same prototypes are used

[PATCH 1/3] selftests: vdso: Rename vdso_test to vdso_test_gettimeofday

2020-05-05 Thread Mark Brown
Currently the vDSO kselftests have a test called vdso_test which tests the vDSO implementation of gettimeofday(). In preparation for adding tests for other vDSO functionality rename this test to reflect what's going on. Signed-off-by: Mark Brown --- tools/testing/selftests/vDSO/.gitignore

[PATCH 3/3] selftests: vdso: Add a selftest for vDSO getcpu()

2020-05-05 Thread Mark Brown
Provide a very basic selftest for getcpu() which similarly to our existing test for gettimeofday() looks up the function in the vDSO and prints the results it gets if the function exists and succeeds. Signed-off-by: Mark Brown --- tools/testing/selftests/vDSO/.gitignore | 1 +

[PATCH 0/3] selftests: vdso: Add a selftest for vDSO getcpu()

2020-05-05 Thread Mark Brown
This series does a bit of a cleanup of the existing tests for the vDSO in kselftest and then adds a new test for getcpu(). Mark Brown (3): selftests: vdso: Rename vdso_test to vdso_test_gettimeofday selftests: vdso: Use a header file to prototype parse_vdso API selftests: vdso: Add a

Re: Re: [PATCH net v2 0/2] Revert the 'socket_alloc' life cycle change

2020-05-05 Thread SeongJae Park
On Tue, 5 May 2020 10:23:58 -0700 "Paul E. McKenney" wrote: > On Tue, May 05, 2020 at 09:25:06AM -0700, Eric Dumazet wrote: > > > > > > On 5/5/20 9:13 AM, SeongJae Park wrote: > > > On Tue, 5 May 2020 09:00:44 -0700 Eric Dumazet > > > wrote: > > > > > >> On Tue, May 5, 2020 at 8:47 AM

Re: [PATCH v6 1/2] x86: fix bitops.h warning with a moved cast

2020-05-05 Thread Nick Desaulniers
On Tue, May 5, 2020 at 10:29 AM Nick Desaulniers wrote: > > On Tue, May 5, 2020 at 8:14 AM Andy Shevchenko > wrote: > > > > On Mon, May 04, 2020 at 06:14:43PM -0700, Jesse Brandeburg wrote: > > > On Mon, 4 May 2020 12:51:12 -0700 > > > Nick Desaulniers wrote: > > > > > > > Sorry for the very

Re: [PATCH 06/11] net: ethernet: mtk-eth-mac: new driver

2020-05-05 Thread Andrew Lunn
> +static struct net_device *mtk_mac_get_netdev(struct mtk_mac_priv *priv) > +{ > + char *ptr = (char *)priv; > + > + return (struct net_device *)(ptr - ALIGN(sizeof(struct net_device), > + NETDEV_ALIGN)); > +} Bit of an odd way to do it. It is

Re: [PATCH] net: broadcom: fix a mistake about ioremap resource

2020-05-05 Thread Jonathan Richardson
On Tue, May 5, 2020 at 12:20 AM Markus Elfring wrote: > > > Commit d7a5502b0bb8b ("net: broadcom: convert to > > devm_platform_ioremap_resource_byname()") will broke this driver. > > idm_base and nicpm_base were optional, after this change, they are > > mandatory. it will probe fails with -22

[PATCH] clone: only use lower 32 flag bits

2020-05-05 Thread Christian Brauner
Jan reported an issue where an interaction between sign-extending clone's flag argument on ppc64le and the new CLONE_INTO_CGROUP feature causes clone() to consistently fail with EBADF. The whole story is a little longer. The legacy clone() syscall is odd in a bunch of ways and here two things

Re: [RFC][PATCH] kexec: Teach indirect pages how to live in high memory

2020-05-05 Thread Hari Bathini
On 05/05/20 3:29 am, Eric W. Biederman wrote: > > Recently a patch was proposed to kimage_alloc_page to slightly alter > the logic of how pages allocated with incompatible flags were > detected. The logic was being altered because the semantics of the > page alloctor were changing yet again.

[PATCH] x86: bitops: fix build regression

2020-05-05 Thread Nick Desaulniers
From: Sedat Dilek It turns out that if your config tickles __builtin_constant_p via differences in choices to inline or not, this now produces invalid assembly: $ cat foo.c long a(long b, long c) { asm("orb\t%1, %0" : "+q"(c): "r"(b)); return c; } $ gcc foo.c foo.c: Assembler messages:

<    1   2   3   4   5   6   7   8   9   10   >