Re: [PATCH 2/4] KVM: SVM: Fixes setting V_IRQ while AVIC is still enabled

2020-05-06 Thread Paolo Bonzini
On 06/05/20 15:17, Suravee Suthikulpanit wrote: > */ > -void kvm_request_apicv_update(struct kvm *kvm, bool activate, ulong bit) > +void kvm_request_apicv_update(struct kvm *kvm, bool activate, ulong bit, > + struct kvm_vcpu *except) > { > unsigned long old, new,

Re: [patch V4 part 1 20/36] vmlinux.lds.h: Create section for protection against instrumentation

2020-05-06 Thread Peter Zijlstra
On Wed, May 06, 2020 at 09:08:31AM -0700, Sean Christopherson wrote: > On Tue, May 05, 2020 at 03:16:22PM +0200, Thomas Gleixner wrote: > > Provide also a set of markers: instr_begin()/end() > > > > These are used to mark code inside a noinstr function which calls > > into regular instrumentable

Re: [patch V4 part 1 05/36] x86/entry: Flip _TIF_SIGPENDING and _TIF_NOTIFY_RESUME handling

2020-05-06 Thread Borislav Petkov
On Tue, May 05, 2020 at 03:16:07PM +0200, Thomas Gleixner wrote: > Make sure task_work runs before any kind of userspace -- very much > including signals -- is invoked. > > Suggested-by: Andy Lutomirski > Signed-off-by: Peter Zijlstra (Intel) > Signed-off-by: Thomas Gleixner Does this need

Re: Proper use for linking foo.o_shipped after 69ea912fda74 ("kbuild: remove unneeded link_multi_deps")?

2020-05-06 Thread Masahiro Yamada
On Thu, May 7, 2020 at 1:03 AM Florian Fainelli wrote: > > > > On 5/6/2020 7:37 AM, Masahiro Yamada wrote: > > On Wed, May 6, 2020 at 1:45 PM Florian Fainelli > > wrote: > >> > >> Hi Masahiro, Michal, > >> > >> While updating our systems from 4.9 to 5.4, we noticed that one of the > >> kernel

[PATCH v2] doc: Fix some errors in ras.rst

2020-05-06 Thread Waiman Long
Make some miscellaneous fixes to the first paragraph of "ECC memory": - Change the incorrect "74 bits" to "72 bits". - Change "mentioned on" to "mentioned in". - Remove the extra "extra". - Rephrase some sentences as suggested by Matthew Wilcox. Signed-off-by: Waiman Long ---

Kmemleak infrastructure improvement for task_struct leaks and call_rcu()

2020-05-06 Thread Qian Cai
== task struck leaks == There are leaks from task struct from time to time where someone forgot to call put_task_struct() somewhere leading to leaks. For example, https://lore.kernel.org/lkml/c1ccbdac-a453-4ff2-908f-0b6e35622...@lca.pw/ It was such a pain to debug this kind of leaks at the

Re: [PATCH] doc: Fix some typo errors in ras.rst

2020-05-06 Thread Waiman Long
On 5/5/20 12:03 PM, Borislav Petkov wrote: On Tue, May 05, 2020 at 08:48:16AM -0700, Matthew Wilcox wrote: Usually a 64-bit system refers to the width of a pointer. Here, it's referring to the width of the memory system, which is rather confusing. How about "In the above example" instead of

Re: [PATCH] ASoC: mediatek: Fix error handling

2020-05-06 Thread Mark Brown
On Wed, 6 May 2020 22:30:09 +0800, Tang Bin wrote: > If the function platform_get_irq() failed, the negative value > returned will not be detected here. So fix error handling in > mt6797_afe_pcm_dev_probe(). And when get irq failed, the function > platform_get_irq() logs an error message, so

Re: [PATCH hmm v2 5/5] mm/hmm: remove the customizable pfn format from hmm_range_fault

2020-05-06 Thread Jason Gunthorpe
On Mon, May 04, 2020 at 06:30:00PM -0700, John Hubbard wrote: > On 2020-05-01 11:20, Jason Gunthorpe wrote: > > From: Jason Gunthorpe > > > > Presumably the intent here was that hmm_range_fault() could put the data > > into some HW specific format and thus avoid some work. However, nothing > >

Re: [PATCH v4 14/18] static_call: Add static_cond_call()

2020-05-06 Thread Peter Zijlstra
On Wed, May 06, 2020 at 10:01:12AM -0400, Mathieu Desnoyers wrote: > - On May 6, 2020, at 9:55 AM, Peter Zijlstra pet...@infradead.org wrote: > > > On Tue, May 05, 2020 at 04:27:44PM -0400, Mathieu Desnoyers wrote: > >> Actually, if the goal is to do code patching of the call, I wonder > >>

Re: [PATCH] doc: Fix some typo errors in ras.rst

2020-05-06 Thread Waiman Long
On 5/5/20 11:48 AM, Matthew Wilcox wrote: On Tue, May 05, 2020 at 11:10:49AM -0400, Waiman Long wrote: Fix typo errors. By reformatting it, you've successfully obscured what typos you've fixed. As a result I read the whole paragraph, and ... ECC memory -- -As mentioned on the

Re: [PATCH hmm v2 5/5] mm/hmm: remove the customizable pfn format from hmm_range_fault

2020-05-06 Thread Jason Gunthorpe
On Fri, May 01, 2020 at 05:53:26PM -0700, Ralph Campbell wrote: > > Acked-by: Felix Kuehling > > Tested-by: Ralph Campbell > > Signed-off-by: Jason Gunthorpe > > Signed-off-by: Christoph Hellwig > > Documentation/vm/hmm.rst| 26 ++-- > >

Re: [PATCH] perf-probe: Accept the instance number of kretprobe event

2020-05-06 Thread Arnaldo Carvalho de Melo
Em Wed, May 06, 2020 at 11:29:12PM +0900, Masami Hiramatsu escreveu: > Since the commit 6a13a0d7b4d1 ("ftrace/kprobe: Show the > maxactive number on kprobe_events") introduced to show the > instance number of kretprobe events, the length of the 1st > format of the kprobe event will not 1, but it

My Dear in the lord

2020-05-06 Thread Mrs. Mina A. Brunel
My Dear in the lord My name is Mrs. Mina A. Brunel I am a Norway Citizen who is living in Burkina Faso, I am married to Mr. Brunel Patrice, a politician who owns a small gold company in Burkina Faso; He died of Leprosy and Radesyge, in the year February 2010, During his lifetime he

Re: [PATCH v4 09/18] x86/static_call: Add out-of-line static call implementation

2020-05-06 Thread Peter Zijlstra
On Fri, May 01, 2020 at 10:28:58PM +0200, Peter Zijlstra wrote: > +#define ARCH_DEFINE_STATIC_CALL_TRAMP(name, func)\ > + asm(".pushsection .text, \"ax\" \n" \ > + ".align 4 \n" \ > +

Re: [PATCH v4 07/18] static_call: Add inline static call infrastructure

2020-05-06 Thread Peter Zijlstra
On Tue, May 05, 2020 at 05:10:51PM -0500, Josh Poimboeuf wrote: > On Fri, May 01, 2020 at 10:28:56PM +0200, Peter Zijlstra wrote: > > +#ifdef CONFIG_HAVE_STATIC_CALL_INLINE > > + > > +struct static_call_mod { > > + struct static_call_mod *next; > > + struct module *mod; /* for vmlinux, mod ==

[PATCH 6/7] KVM: X86: TSCDEADLINE MSR emulation fastpath

2020-05-06 Thread Paolo Bonzini
From: Wanpeng Li This patch implements a fast path for emulation of writes to the TSCDEADLINE MSR. Besides shortcutting various housekeeping tasks in the vCPU loop, the fast path can also deliver the timer interrupt directly without going through KVM_REQ_PENDING_TIMER because it runs in vCPU

RE: [RFC][PATCH 1/3] evm: Move hooks outside LSM infrastructure

2020-05-06 Thread Roberto Sassu
> -Original Message- > From: Roberto Sassu > Sent: Wednesday, April 29, 2020 9:40 AM > To: zo...@linux.ibm.com; david.saff...@gmail.com; > v...@zeniv.linux.org.uk; jmor...@namei.org > Cc: linux-fsde...@vger.kernel.org; linux-integr...@vger.kernel.org; linux- >

[PATCH 2/7] KVM: X86: Introduce kvm_vcpu_exit_request() helper

2020-05-06 Thread Paolo Bonzini
From: Wanpeng Li Introduce kvm_vcpu_exit_request() helper, we need to check some conditions before enter guest again immediately, we skip invoking the exit handler and go through full run loop if complete fastpath but there is stuff preventing we enter guest again immediately. Tested-by: Haiwei

[PATCH 5/7] KVM: x86: introduce kvm_can_use_hv_timer

2020-05-06 Thread Paolo Bonzini
Replace the ad hoc test in vmx_set_hv_timer with a test in the caller, start_hv_timer. This test is not Intel-specific and would be duplicated when introducing the fast path for the TSC deadline MSR. Signed-off-by: Paolo Bonzini --- arch/x86/kvm/lapic.c | 13 ++---

[PATCH 1/7] KVM: VMX: Introduce generic fastpath handler

2020-05-06 Thread Paolo Bonzini
From: Wanpeng Li Introduce generic fastpath handler to handle MSR fastpath, VMX-preemption timer fastpath etc; move it after vmx_complete_interrupts() in order to catch events delivered to the guest, and abort the fast path in later patches. While at it, move the kvm_exit tracepoint so that it

[PATCH v5 0/7] KVM: VMX: Tscdeadline timer emulation fastpath

2020-05-06 Thread Paolo Bonzini
This is my cleaned up version of Wanpeng's TSC deadline timer optimizations. The main change is a reorganization of the fast path enums, removing EXIT_FASTPATH_SKIP_EMUL_INS (following the suggestion of 林鑫龙) and renaming EXIT_FASTPATH_NOP to EXIT_FASTPATH_EXIT_HANDLED. Paolo Bonzini (1): KVM:

[PATCH 7/7] KVM: VMX: Handle preemption timer fastpath

2020-05-06 Thread Paolo Bonzini
From: Wanpeng Li This patch implements a fastpath for the preemption timer vmexit. The vmexit can be handled quickly so it can be performed with interrupts off and going back directly to the guest. Testing on SKX Server. cyclictest in guest(w/o mwait exposed, adaptive advance lapic timer is

[PATCH 3/7] KVM: X86: Introduce more exit_fastpath_completion enum values

2020-05-06 Thread Paolo Bonzini
From: Wanpeng Li Adds a fastpath_t typedef since enum lines are a bit long, and replace EXIT_FASTPATH_SKIP_EMUL_INS with two new exit_fastpath_completion enum values. - EXIT_FASTPATH_EXIT_HANDLED kvm will still go through it's full run loop, but it would skip

[PATCH 4/7] KVM: VMX: Optimize posted-interrupt delivery for timer fastpath

2020-05-06 Thread Paolo Bonzini
From: Wanpeng Li While optimizing posted-interrupt delivery especially for the timer fastpath scenario, I measured kvm_x86_ops.deliver_posted_interrupt() to introduce substantial latency because the processor has to perform all vmentry tasks, ack the posted interrupt notification vector, read

Re: [PATCH -next] cpupower: Remove unneeded semicolon

2020-05-06 Thread shuah
On 5/5/20 6:52 PM, Samuel Zou wrote: Hi Shuah, I run with the below command, and get the output report. [local-host linux-next]# make coccicheck MODE=report M=tools/power/cpupower/utils Yes this is the command I am using as well. I don't see the errors you are seeing. What is the

Re: Re: [RFC] DPCM for Tegra

2020-05-06 Thread Sameer Pujar
On 5/6/2020 9:23 PM, Mark Brown wrote: On Wed, May 06, 2020 at 04:47:09PM +0200, Jerome Brunet wrote: On Wed 06 May 2020 at 16:12, Sameer Pujar wrote: XBAR currently exports all routing widgets which can be used to interconnect multiple components and thus implements Mux widgets. Fixing

Re: [PATCH 7/9] KVM: x86: simplify dr6 accessors in kvm_x86_ops

2020-05-06 Thread Paolo Bonzini
On 06/05/20 18:06, Peter Xu wrote: > On Wed, May 06, 2020 at 07:10:32AM -0400, Paolo Bonzini wrote: >> kvm_x86_ops.set_dr6 is only ever called with vcpu->arch.dr6 as the >> second argument, and for both SVM and VMX the VMCB value is kept >> synchronized with vcpu->arch.dr6 on #DB; we can therefore

Re: [patch V4 part 1 20/36] vmlinux.lds.h: Create section for protection against instrumentation

2020-05-06 Thread Sean Christopherson
On Tue, May 05, 2020 at 03:16:22PM +0200, Thomas Gleixner wrote: > Provide also a set of markers: instr_begin()/end() > > These are used to mark code inside a noinstr function which calls > into regular instrumentable text section as safe. ... > --- a/include/linux/compiler.h > +++

Re: [RFC] mm/gup.c: Updated return value of {get|pin}_user_pages_fast()

2020-05-06 Thread Souptick Joarder
On Wed, May 6, 2020 at 6:29 PM Jan Kara wrote: > > On Wed 06-05-20 17:51:39, Souptick Joarder wrote: > > On Wed, May 6, 2020 at 3:36 PM Jan Kara wrote: > > > > > > On Wed 06-05-20 02:06:56, Souptick Joarder wrote: > > > > On Wed, May 6, 2020 at 1:08 AM John Hubbard wrote: > > > > > > > > > > On

[PATCH] Driver: hv: vmbus: drop a no long applicable comment

2020-05-06 Thread Wei Liu
None of the things mentioned in the comment is initialized in hv_init. They've been moved elsewhere. Signed-off-by: Wei Liu --- drivers/hv/vmbus_drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c index 3a27f6c5f3de..7efdcadc335e 100644 ---

Re: [PATCH 7/9] KVM: x86: simplify dr6 accessors in kvm_x86_ops

2020-05-06 Thread Peter Xu
On Wed, May 06, 2020 at 07:10:32AM -0400, Paolo Bonzini wrote: > kvm_x86_ops.set_dr6 is only ever called with vcpu->arch.dr6 as the > second argument, and for both SVM and VMX the VMCB value is kept > synchronized with vcpu->arch.dr6 on #DB; we can therefore remove the > read accessor. > > For

Re: [PATCH] tracing: Fix a typo in comment "fonud"->"found"

2020-05-06 Thread Steven Rostedt
On Sat, 18 Apr 2020 00:48:09 +0800 Ethon Paul wrote: > +++ b/kernel/trace/trace.c > @@ -361,7 +361,7 @@ void trace_free_pid_list(struct trace_pid_list *pid_list) > * @filtered_pids: The list of pids to check > * @search_pid: The PID to find in @filtered_pids > * > - * Returns true if

Re: [patch V4 part 1 19/36] x86/entry: Exclude low level entry code from sanitizing

2020-05-06 Thread Alexandre Chartre
On 5/5/20 3:16 PM, Thomas Gleixner wrote: The sanitizers are not really applicable to the fragile low level entry code. code. Entry code needs to carefully setup a normal 'runtime' typo: code. code. Reviewed-by: Alexandre Chartre alex. environment. Signed-off-by: Peter Zijlstra

Re: [RFC][PATCH 1/4] devicetree: bindings: Add linux,cma-heap tag for reserved memory

2020-05-06 Thread Andrew F. Davis
On 5/4/20 4:50 AM, Brian Starkey wrote: > On Fri, May 01, 2020 at 11:40:16AM -0700, John Stultz wrote: >> On Fri, May 1, 2020 at 3:42 AM Brian Starkey wrote: >>> >>> Hi, >>> >>> On Fri, May 01, 2020 at 07:39:46AM +, John Stultz wrote: This patch adds a linux,cma-heap property for CMA

Re: [PATCH 6/9] KVM: SVM: keep DR6 synchronized with vcpu->arch.dr6

2020-05-06 Thread Peter Xu
On Wed, May 06, 2020 at 07:10:31AM -0400, Paolo Bonzini wrote: > Ensure that the current value of DR6 is always available in vcpu->arch.dr6, > so that the get_dr6 callback can just access vcpu->arch.dr6 and becomes > redundant. > > Signed-off-by: Paolo Bonzini Reviewed-by: Peter Xu -- Peter

Re: Proper use for linking foo.o_shipped after 69ea912fda74 ("kbuild: remove unneeded link_multi_deps")?

2020-05-06 Thread Florian Fainelli
On 5/6/2020 7:37 AM, Masahiro Yamada wrote: > On Wed, May 6, 2020 at 1:45 PM Florian Fainelli wrote: >> >> Hi Masahiro, Michal, >> >> While updating our systems from 4.9 to 5.4, we noticed that one of the >> kernel modules that we build, which is done by linking an object that we >>

Re: [PATCH] sched/fair: Fix nohz.next_balance update

2020-05-06 Thread Valentin Schneider
On 06/05/20 14:45, Vincent Guittot wrote: >> But then we may skip an update if we goto abort, no? Imagine we have just >> NOHZ_STATS_KICK, so we don't call any rebalance_domains(), and then as we >> go through the last NOHZ CPU in the loop we hit need_resched(). We would >> end in the abort part

Re: [PATCH 2/9] KVM: x86: fix DR6 delivery for various cases of #DB injection

2020-05-06 Thread Peter Xu
On Wed, May 06, 2020 at 07:10:27AM -0400, Paolo Bonzini wrote: > Go through kvm_queue_exception_p so that the payload is correctly delivered > through the exit qualification, and add a kvm_update_dr6 call to > kvm_deliver_exception_payload that is needed on AMD. > > Reported-by: Peter Xu >

Re: [PATCH v4 14/18] static_call: Add static_cond_call()

2020-05-06 Thread Peter Zijlstra
On Wed, May 06, 2020 at 03:51:28PM +0200, Peter Zijlstra wrote: > On Tue, May 05, 2020 at 11:13:53AM -0700, Nick Desaulniers wrote: > > On Tue, May 5, 2020 at 2:36 AM Peter Zijlstra wrote: > > > > > > > > > HJ, Nick, > > > > > > Any chance any of you can see a way to make your respective

Re: [PATCH] ipc/util.c: sysvipc_find_ipc() incorrectly updates position index

2020-05-06 Thread Waiman Long
On 5/6/20 2:25 AM, Vasily Averin wrote: new_pos should jump through hole of unused ids, pos can be updated inside "for" cycle. Cc: sta...@vger.kernel.org Fixes: 89163f93c6f9 ("ipc/util.c: sysvipc_find_ipc() should increase position index") Signed-off-by: Vasily Averin --- ipc/util.c | 12

Re: [patch V4 part 1 18/36] samples/kprobes: Add __kprobes and NOKPROBE_SYMBOL() for handlers.

2020-05-06 Thread Alexandre Chartre
On 5/5/20 3:16 PM, Thomas Gleixner wrote: From: Masami Hiramatsu Add __kprobes and NOKPROBE_SYMBOL() for sample kprobe handlers. Signed-off-by: Masami Hiramatsu Signed-off-by: Thomas Gleixner Link: https://lkml.kernel.org/r/158523421177.24735.16273975317343670204.stgit@devnote2 ---

Re: [PATCH 3/3] hwmon: (occ) Add new temperature sensor type

2020-05-06 Thread Eddie James
On 5/6/20 10:57 AM, Guenter Roeck wrote: On Fri, May 01, 2020 at 10:08:33AM -0500, Eddie James wrote: The latest version of the On-Chip Controller (OCC) has a different format for the temperature sensor data. Add a new temperature sensor version to handle this data. Signed-off-by: Eddie

[PATCH v2 2/7] extcon: arizona: Move binding over to dtschema

2020-05-06 Thread Charles Keepax
Signed-off-by: Charles Keepax --- Changes since v1: - Removed some description that duplicates constraints Thanks, Charles .../devicetree/bindings/extcon/extcon-arizona.txt | 76 - .../devicetree/bindings/extcon/wlf,arizona.yaml| 125 + 2 files changed,

[PATCH v2 3/7] ASoC: arizona: Move binding over to dtschema

2020-05-06 Thread Charles Keepax
Signed-off-by: Charles Keepax --- Changes since v1: - Removed some description that duplicates constraints Thanks, Charles .../devicetree/bindings/sound/wlf,arizona.txt | 53 -- .../devicetree/bindings/sound/wlf,arizona.yaml | 114 + 2 files changed, 114

[PATCH v2 1/7] regulator: arizona-regulator: Move binding over to dtschema

2020-05-06 Thread Charles Keepax
Signed-off-by: Charles Keepax --- No changes since v1. Thanks, Charles .../bindings/regulator/arizona-regulator.txt | 18 --- .../devicetree/bindings/regulator/wlf,arizona.yaml | 37 ++ 2 files changed, 37 insertions(+), 18 deletions(-) delete mode 100644

[PATCH v2 7/7] mfd: madera: Move binding over to dtschema

2020-05-06 Thread Charles Keepax
Signed-off-by: Charles Keepax --- New since v1, putting in the same series as Arizona since they share the same regulator binding. Thanks, Charles .../devicetree/bindings/mfd/cirrus,madera.yaml | 317 + Documentation/devicetree/bindings/mfd/madera.txt | 114

[PATCH v2 5/7] ASoC: madera: Move binding over to dtschema

2020-05-06 Thread Charles Keepax
Signed-off-by: Charles Keepax --- New since v1, putting in the same series as Arizona since they share the same regulator binding. Thanks, Charles .../devicetree/bindings/sound/cirrus,madera.yaml | 113 + Documentation/devicetree/bindings/sound/madera.txt | 67

[PATCH v2 6/7] pinctrl: madera: Move binding over to dtschema

2020-05-06 Thread Charles Keepax
Signed-off-by: Charles Keepax --- New since v1, putting in the same series as Arizona since they share the same regulator binding. Thanks, Charles .../bindings/pinctrl/cirrus,madera-pinctrl.txt | 99 -- .../devicetree/bindings/pinctrl/cirrus,madera.yaml | 147

[PATCH v2 4/7] mfd: arizona: Move binding over to dtschema

2020-05-06 Thread Charles Keepax
Signed-off-by: Charles Keepax --- Changes since v1: - Removed some description that duplicates constraints - Added some blank lines for readability Thanks, Charles Documentation/devicetree/bindings/mfd/arizona.txt | 101 --- .../devicetree/bindings/mfd/wlf,arizona.yaml | 298

Re: [PATCH] drm/bridge: ti-sn65dsi86: Implement lane reordering + polarity

2020-05-06 Thread Laurent Pinchart
Hi Doug, On Tue, May 05, 2020 at 05:18:48PM -0700, Doug Anderson wrote: > On Tue, May 5, 2020 at 2:24 PM Doug Anderson wrote: > > On Tue, May 5, 2020 at 2:14 PM Laurent Pinchart wrote: > > > > > > > I'll add this documentation into the comments of the yaml, but I'm not > > > > going to try to

Re: [PATCH 3/3] hwmon: (occ) Add new temperature sensor type

2020-05-06 Thread Guenter Roeck
On Fri, May 01, 2020 at 10:08:33AM -0500, Eddie James wrote: > The latest version of the On-Chip Controller (OCC) has a different > format for the temperature sensor data. Add a new temperature sensor > version to handle this data. > > Signed-off-by: Eddie James For my reference: Acked-by:

Re: [patch V4 part 1 17/36] kprobes: Support NOKPROBE_SYMBOL() in modules

2020-05-06 Thread Alexandre Chartre
On 5/5/20 3:16 PM, Thomas Gleixner wrote: From: Masami Hiramatsu Support NOKPROBE_SYMBOL() in modules. NOKPROBE_SYMBOL() records only symbol address in "_kprobe_blacklist" section in the module. Signed-off-by: Masami Hiramatsu Signed-off-by: Thomas Gleixner Link:

Re: [PATCH 0/4] allow multiple kthreadd's

2020-05-06 Thread J. Bruce Fields
On Wed, May 06, 2020 at 11:39:20AM -0400, Tejun Heo wrote: > Hello, Bruce. > > On Wed, May 06, 2020 at 11:36:58AM -0400, J. Bruce Fields wrote: > > On Tue, May 05, 2020 at 05:25:27PM -0400, J. Bruce Fields wrote: > > > On Tue, May 05, 2020 at 05:09:56PM -0400, Tejun Heo wrote: > > > > It's not

Re: [PATCH] hwmon: adt7411: update contact email

2020-05-06 Thread Guenter Roeck
On Sat, May 02, 2020 at 04:27:00PM +0200, Wolfram Sang wrote: > My 'pengutronix' address is defunct for years. Merge the entries and use > the proper contact address. > > Signed-off-by: Wolfram Sang Applied. Thanks, Guenter > --- > drivers/hwmon/adt7411.c | 3 +-- > 1 file changed, 1

Re: [PATCH] bpf: Tweak BPF jump table optimizations for objtool compatibility

2020-05-06 Thread Josh Poimboeuf
On Tue, May 05, 2020 at 04:59:39PM -0700, Alexei Starovoitov wrote: > As far as workaround I prefer the following: > From 94bbc27c5a70d78846a5cb675df4cf8732883564 Mon Sep 17 00:00:00 2001 > From: Alexei Starovoitov > Date: Tue, 5 May 2020 16:52:41 -0700 > Subject: [PATCH] bpf,objtool: tweak

Re: [RFC] DPCM for Tegra

2020-05-06 Thread Mark Brown
On Wed, May 06, 2020 at 04:47:09PM +0200, Jerome Brunet wrote: > On Wed 06 May 2020 at 16:12, Sameer Pujar wrote: > > XBAR currently exports all routing widgets which can be used to > > interconnect multiple components and thus implements Mux widgets. Fixing > > the routing paths in driver would

Re: [PATCH] media: usb: ttusb-dec: avoid buffer overflow in ttusb_dec_handle_irq() when DMA failures/attacks occur

2020-05-06 Thread Greg KH
On Wed, May 06, 2020 at 11:30:22PM +0800, Jia-Ju Bai wrote: > > > On 2020/5/6 19:07, Greg KH wrote: > > On Wed, May 06, 2020 at 06:13:01PM +0800, Jia-Ju Bai wrote: > > > I have never modified DMA memory in the real world, but an attacker can > > > use > > > a malicious device to do this. > > >

[PATCH v2] sched/pelt: sync util/runnable_sum with PELT window when propagating

2020-05-06 Thread Vincent Guittot
update_tg_cfs_*() propagate the impact of the attach/detach of an entity down into the cfs_rq hierarchy and must keep the sync with the current pelt window. Even if we can't sync child cfs_rq and its group se, we can sync the group se and its parent cfs_rq with current position in the PELT

Re: [patch V4 part 2 01/18] x86/entry/64: Move non entry code into .text section

2020-05-06 Thread Peter Zijlstra
On Tue, May 05, 2020 at 03:41:13PM +0200, Thomas Gleixner wrote: > All ASM code which is not part of the entry functionality can move out into > the .text section. No reason to keep it in the non-instrumentable entry > section. Just to note to self (or others), I'm planning to move all this into

Re: [patch V4 part 1 16/36] kprobes: Support __kprobes blacklist in modules

2020-05-06 Thread Alexandre Chartre
On 5/5/20 3:16 PM, Thomas Gleixner wrote: From: Masami Hiramatsu Support __kprobes attribute for blacklist functions in modules. The __kprobes attribute functions are stored in .kprobes.text section. Signed-off-by: Masami Hiramatsu Signed-off-by: Thomas Gleixner Link:

Re: remove set_fs calls from the coredump code v6

2020-05-06 Thread Eric W. Biederman
Christoph Hellwig writes: > On Tue, May 05, 2020 at 03:28:50PM -0500, Eric W. Biederman wrote: >> We probably can. After introducing a kernel_compat_siginfo that is >> the size that userspace actually would need. >> >> It isn't something I want to mess with until this code gets merged, as I

Re: [PATCH] selftests/ftrace: mark irqsoff_tracer.tc test as unresolved if the test module does not exist

2020-05-06 Thread Shuah Khan
On 5/6/20 9:43 AM, Steven Rostedt wrote: On Wed, 6 May 2020 09:46:21 +0800 Po-Hsu Lin wrote: On Tue, May 5, 2020 at 9:09 PM Steven Rostedt wrote: You keep forgetting to Cc Shuah's other email. Thanks! I got the recipients list from the get_mainter.pl. Hmm. Seems like that is what

Re: [PATCH] arm64: disable patchable function entry on big-endian clang builds

2020-05-06 Thread Fangrui Song
On 2020-05-06, Nathan Chancellor wrote: On Wed, May 06, 2020 at 12:22:58PM +0200, Arnd Bergmann wrote: On Wed, May 6, 2020 at 5:45 AM Nathan Chancellor wrote: > On Tue, May 05, 2020 at 07:42:43PM +0200, Torsten Duwe wrote: > > On Tue, 5 May 2020 15:25:56 +0100 Mark Rutland wrote: > > > On

Re: [PATCH] selftests/ftrace: mark irqsoff_tracer.tc test as unresolved if the test module does not exist

2020-05-06 Thread Steven Rostedt
On Wed, 6 May 2020 09:46:21 +0800 Po-Hsu Lin wrote: > On Tue, May 5, 2020 at 9:09 PM Steven Rostedt wrote: > > > > > > You keep forgetting to Cc Shuah's other email. > Thanks! > I got the recipients list from the get_mainter.pl. Hmm. Seems like that is what get_maintainer.pl does: Steven

Re: [patch V4 part 1 19/36] x86/entry: Exclude low level entry code from sanitizing

2020-05-06 Thread Peter Zijlstra
On Tue, May 05, 2020 at 04:39:01PM -0400, Brian Gerst wrote: > On Tue, May 5, 2020 at 10:13 AM Thomas Gleixner wrote: > > > > The sanitizers are not really applicable to the fragile low level entry > > code. code. Entry code needs to carefully setup a normal 'runtime' > > environment. > > > >

Re: [PATCH] scsi: qla2xxx: make qlafx00_process_aen() return void

2020-05-06 Thread Bart Van Assche
On 2020-05-05 23:17, Jason Yan wrote: > No other functions use the return value of qlafx00_process_aen() and the > return value is always 0 now. Make it return void. This fixes the > following coccicheck warning: > > drivers/scsi/qla2xxx/qla_mr.c:1716:5-9: Unneeded variable: "rval". > Return "0"

Re: [PATCH] x86: bitops: fix build regression

2020-05-06 Thread Nathan Chancellor
On Tue, May 05, 2020 at 09:30:28PM -0700, Nathan Chancellor wrote: > On Tue, May 05, 2020 at 10:44:22AM -0700, Nick Desaulniers wrote: > > From: Sedat Dilek > > > > It turns out that if your config tickles __builtin_constant_p via > > differences in choices to inline or not, this now produces

Re: [PATCH -next] scsi: qla2xxx: Use PTR_ERR_OR_ZERO() to simplify code

2020-05-06 Thread Bart Van Assche
On 2020-05-06 00:54, Samuel Zou wrote: > Fixes coccicheck warning: > > drivers/scsi/qla2xxx/tcm_qla2xxx.c:1488:1-3: WARNING: PTR_ERR_OR_ZERO can be > used > > Reported-by: Hulk Robot > Signed-off-by: Samuel Zou > --- > drivers/scsi/qla2xxx/tcm_qla2xxx.c | 4 +--- > 1 file changed, 1

[RFC 0/2] Enable PF-VF linking with pdev->no_vf_scan (s390)

2020-05-06 Thread Niklas Schnelle
Hello Kernel Hackers, the following series enables PF-VF linking for architectures using the pdev->no_vf_scan flag (currently just s390). This includes kernel internal linking with pdev->physfn as well as creation of the relevant sysfs links. The former are required for example by libvirt to

[RFC 1/2] PCI/IOV: Introduce pci_iov_sysfs_link() function

2020-05-06 Thread Niklas Schnelle
currently pci_iov_add_virtfn() scans the SR-IOV bars, adds the VF to the bus and also creates the sysfs links between the newly added VF and its parent PF. With pdev->no_vf_scan fencing off the entire pci_iov_add_virtfn() call s390 as the sole pdev->no_vf_scan user thus ends up missing these

Re: [PATCH v5 0/6] Add support for O_MAYEXEC

2020-05-06 Thread Aleksa Sarai
On 2020-05-06, Lev R. Oshvang . wrote: > On Tue, May 5, 2020 at 6:36 PM Mickaël Salaün wrote: > > > > > > On 05/05/2020 17:31, Mickaël Salaün wrote: > > > Hi, > > > > > > This fifth patch series add new kernel configurations (OMAYEXEC_STATIC, > > > OMAYEXEC_ENFORCE_MOUNT, and

[RFC 2/2] s390/pci: create links between PFs and VFs

2020-05-06 Thread Niklas Schnelle
On s390 PCI Virtual Functions (VFs) are scanned by firmware and are made available to Linux via the hot-plug interface. As such the common code path of doing the scan directly using the parent Physical Function (PF) is not used and fenced off with the no_vf_scan attribute. Even if the partition

[net-next PATCH] net: hsr: fix incorrect type usage for protocol variable

2020-05-06 Thread Murali Karicheri
Fix following sparse checker warning:- net/hsr/hsr_slave.c:38:18: warning: incorrect type in assignment (different base types) net/hsr/hsr_slave.c:38:18:expected unsigned short [unsigned] [usertype] protocol net/hsr/hsr_slave.c:38:18:got restricted __be16 [usertype] h_proto

Re: [PATCH] phy: tegra: Use PTR_ERR_OR_ZERO() to simplify code

2020-05-06 Thread Dmitry Osipenko
06.05.2020 14:47, Vidya Sagar пишет: > Thanks for pushing this change. > I'm fine with this change as it is attempting to change only the last > occurrence of the (IS_ERR(...)) + PTR_ERR combination. > But, this code was initially written with PTR_ERR_OR_ZERO() itself but > later changed to use

Re: linux-next boot error: WARNING: suspicious RCU usage in ipmr_get_table

2020-05-06 Thread Amol Grover
On Tue, Apr 28, 2020 at 09:56:59AM -0400, Qian Cai wrote: > > > > On Apr 28, 2020, at 4:57 AM, Dmitry Vyukov wrote: > >> net/ipv4/ipmr.c:136 RCU-list traversed in non-reader section!! > > https://lore.kernel.org/netdev/20200222063835.14328-2-frextr...@gmail.com/ > > Never been picked up for a

Re: [patch V4 part 1 15/36] kprobes: Lock kprobe_mutex while showing kprobe_blacklist

2020-05-06 Thread Alexandre Chartre
On 5/5/20 3:16 PM, Thomas Gleixner wrote: From: Masami Hiramatsu Lock kprobe_mutex while showing kprobe_blacklist to prevent updating the kprobe_blacklist. Signed-off-by: Masami Hiramatsu Signed-off-by: Thomas Gleixner Link:

Re: [patch V4 part 1 14/36] x86/entry: Get rid of ist_begin/end_non_atomic()

2020-05-06 Thread Alexandre Chartre
On 5/5/20 3:16 PM, Thomas Gleixner wrote: This is completely overengineered and definitely not an interface which should be made available to anything else than this particular MCE case. Signed-off-by: Thomas Gleixner --- arch/x86/include/asm/traps.h |2 --

Re: [PATCH 0/4] allow multiple kthreadd's

2020-05-06 Thread Tejun Heo
Hello, Bruce. On Wed, May 06, 2020 at 11:36:58AM -0400, J. Bruce Fields wrote: > On Tue, May 05, 2020 at 05:25:27PM -0400, J. Bruce Fields wrote: > > On Tue, May 05, 2020 at 05:09:56PM -0400, Tejun Heo wrote: > > > It's not the end of the world but a bit hacky. I wonder whether something > > >

Re: [patch V4 part 1 06/36] compiler: Simple READ/WRITE_ONCE() implementations

2020-05-06 Thread Peter Zijlstra
On Wed, May 06, 2020 at 02:33:33PM +0100, Will Deacon wrote: > On Tue, May 05, 2020 at 03:16:08PM +0200, Thomas Gleixner wrote: > > READ/WRITE_ONCE_NOCHECK() is required for atomics in code which cannot be > > instrumented like the x86 int3 text poke code. As READ/WRITE_ONCE() is > > undergoing a

Re: [RFC PATCH] PCI: dwc: add support for Allwinner SoCs' PCIe controller

2020-05-06 Thread Maxime Ripard
On Mon, Apr 20, 2020 at 04:18:58PM +0800, Icenowy Zheng wrote: > 在 2020-04-06星期一的 10:27 +0200,Maxime Ripard写道: > > Hi, > > > > On Fri, Apr 03, 2020 at 12:05:49AM +0800, Icenowy Zheng wrote: > > > The Allwinner H6 SoC uses DesignWare's PCIe controller to provide a > > > PCIe > > > host. > > > > >

Re: [PATCH 0/4] allow multiple kthreadd's

2020-05-06 Thread J. Bruce Fields
On Tue, May 05, 2020 at 05:25:27PM -0400, J. Bruce Fields wrote: > On Tue, May 05, 2020 at 05:09:56PM -0400, Tejun Heo wrote: > > It's not the end of the world but a bit hacky. I wonder whether something > > like the following would work better for identifying worker type so that you > > can do

Re: [patch V4 part 1 05/36] x86/entry: Flip _TIF_SIGPENDING and _TIF_NOTIFY_RESUME handling

2020-05-06 Thread Peter Zijlstra
On Wed, May 06, 2020 at 01:53:36PM +0200, Miroslav Benes wrote: > On Tue, 5 May 2020, Thomas Gleixner wrote: > > > Make sure task_work runs before any kind of userspace -- very much > > including signals -- is invoked. > > I might be missing something, but isn't this guaranteed by >

Re: [PATCH v3 0/5] ntb perf, ntb tool and ntb-hw improvements

2020-05-06 Thread Logan Gunthorpe
On 2020-05-05 10:21 p.m., Sanjay R Mehta wrote: > v3: > - Increased ntb_perf command re-try sleep time > - avoid false dma unmap of dst address. > > v2: Incorporated improvements suggested by Logan Gunthorpe > > Links of the review comments for v3: > 1. https://lkml.org/lkml/2020/3/11/981 >

Re: [PATCH] leds: lm355x: avoid enum conversion warning

2020-05-06 Thread Nathan Chancellor
On Wed, May 06, 2020 at 04:19:45PM +0200, Arnd Bergmann wrote: > On Wed, May 6, 2020 at 4:44 AM Nathan Chancellor > wrote: > > > > On Tue, May 05, 2020 at 04:19:17PM +0200, Arnd Bergmann wrote: > > > clang points out that doing arithmetic between diffent enums is usually > >

Re: [PATCH] securityfs: Add missing d_delete() call on removal

2020-05-06 Thread Kees Cook
On Wed, May 06, 2020 at 05:02:52AM +0100, Al Viro wrote: > On Tue, May 05, 2020 at 08:28:33PM -0700, Kees Cook wrote: > > On Wed, May 06, 2020 at 02:14:31AM +0100, Al Viro wrote: > > > On Tue, May 05, 2020 at 04:40:35PM -0700, Kees Cook wrote: > > > > After using simple_unlink(), a call to

Re: [PATCH v2 5/5] [media] mtk-mdp: Remove mtk_mdp_comp.id and supporting functionality

2020-05-06 Thread Enric Balletbo Serra
Hi Eizan, Thank you for the patch. Two trivial comments Missatge de Eizan Miyamoto del dia dc., 6 de maig 2020 a les 7:51: > > Since components are registered in a list, the numeric component id that > specified a location in an array is not necessary. > > Signed-off-by: ei...@chromium.org

Re: [patch V4 part 1 03/36] sched: Clean up scheduler_ipi()

2020-05-06 Thread Peter Zijlstra
On Wed, May 06, 2020 at 02:37:19PM +0200, Alexandre Chartre wrote: > On 5/5/20 3:16 PM, Thomas Gleixner wrote: > > @@ -650,6 +655,16 @@ static inline bool got_nohz_idle_kick(vo > > return false; > > } > > +static void nohz_csd_func(void *info) > > +{ > > + struct rq *rq = info; > > + > > +

Re: [patch V4 part 1 13/36] x86/kvm: Restrict ASYNC_PF to user space

2020-05-06 Thread Alexandre Chartre
On 5/5/20 3:16 PM, Thomas Gleixner wrote: The async page fault injection into kernel space creates more problems than it solves. The host has absolutely no knowledge about the state of the guest if the fault happens in CPL0. The only restriction for the host is interrupt disabled state. If

Re: [PATCH] arm64: disable patchable function entry on big-endian clang builds

2020-05-06 Thread Nathan Chancellor
On Wed, May 06, 2020 at 12:22:58PM +0200, Arnd Bergmann wrote: > On Wed, May 6, 2020 at 5:45 AM Nathan Chancellor > wrote: > > On Tue, May 05, 2020 at 07:42:43PM +0200, Torsten Duwe wrote: > > > On Tue, 5 May 2020 15:25:56 +0100 Mark Rutland > > > wrote: > > > > On Tue, May 05, 2020 at

Re: [PATCH] iio: sca3000: Remove an erroneous get_device() call in sca3000_read_data()

2020-05-06 Thread Markus Elfring
> This looks really unusual to have a 'get_device()' hidden in a 'dev_err()' > call. Is there a need to prevent similar function calls by the means of advanced source code analysis? Regards, Markus

Re: [PATCH 6/7] exec: Move most of setup_new_exec into flush_old_exec

2020-05-06 Thread Kees Cook
On Wed, May 06, 2020 at 09:57:10AM -0500, Eric W. Biederman wrote: > Kees Cook writes: > > > On Tue, May 05, 2020 at 02:45:33PM -0500, Eric W. Biederman wrote: > >> > >> The current idiom for the callers is: > >> > >> flush_old_exec(bprm); > >> set_personality(...); > >> setup_new_exec(bprm);

Re: [PATCH] media: usb: ttusb-dec: avoid buffer overflow in ttusb_dec_handle_irq() when DMA failures/attacks occur

2020-05-06 Thread Jia-Ju Bai
On 2020/5/6 19:07, Greg KH wrote: On Wed, May 06, 2020 at 06:13:01PM +0800, Jia-Ju Bai wrote: I have never modified DMA memory in the real world, but an attacker can use a malicious device to do this. There is a video that shows how to use the Inception tool to perform DMA attacks and login

[PATCH 29/91] libsubcmd: Introduce OPT_CALLBACK_SET()

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo To register that an option was set, like with the upcoming 'perf record --switch-output-option' one. Acked-by: Jiri Olsa Cc: Adrian Hunter Cc: Namhyung Kim Cc: Song Liu Link: http://lore.kernel.org/lkml/20200429131106.27974-7-a...@kernel.org Signed-off-by:

[PATCH 41/91] perf intel-pt: Change branch stack support to use thread-stacks

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Change Intel PT's branch stack support to use thread stacks. The advantages of using branch stack support from the thread-stack are: 1. the branches are accumulated separately for each thread 2. the branch stack is cleared only in between continuous traces This helps pave

[PATCH 52/91] perf evsel: Rename perf_evsel__is_aux_event() to evsel__is_aux_event()

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo As it is a 'struct evsel' method, not part of tools/lib/perf/, aka libperf, to whom the perf_ prefix belongs. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/auxtrace.c | 6 +++---

[PATCH 1/2] module: allow arch overrides for .init section names

2020-05-06 Thread Vincent Whitchurch
ARM stores unwind information for .init.text in sections named .ARM.extab.init.text and .ARM.exidx.init.text. Since those aren't currently recognized as init sections, they're allocated along with the core section, and relocation fails if the core and the init section are allocated from different

[PATCH 30/91] perf record: Introduce --switch-output-event

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Now we can use it with --overwrite to have a flight recorder mode that gets snapshot requests from arbitrary events that are processed in the side band thread together with the PERF_RECORD_BPF_EVENT processing. Example: To collect scheduler events until a

[PATCH 44/91] perf thread-stack: Add thread_stack__br_sample_late()

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Add a thread stack function to create a branch stack for hardware events where the sample records get created some time after the event occurred. Signed-off-by: Adrian Hunter Cc: Andi Kleen Cc: Jiri Olsa Link:

[PATCH 26/91] perf parse-events: Add parse_events_option() variant that creates evlist

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo For the upcoming --switch-output-event option we want to create the side band event, populate it with the specified events and then, if it is present multiple times, go on adding to it, then, if the BPF tracking is required, use the first event to set its

<    3   4   5   6   7   8   9   10   11   12   >