RE: [RFC PATCH v12 10/11] arm64: add mechanism to let user choose which counter to return

2020-05-25 Thread Jianyong Wu
Hi Marc, > -Original Message- > From: Marc Zyngier > Sent: Monday, May 25, 2020 5:17 PM > To: Richard Cochran ; Jianyong Wu > > Cc: net...@vger.kernel.org; yangbo...@nxp.com; john.stu...@linaro.org; > t...@linutronix.de; pbonz...@redhat.com; sean.j.christopher...@intel.com; > Mark Rutlan

[PATCH] mm: dump_page: add debugfs file for dumping page state by pfn

2020-05-25 Thread Konstantin Khlebnikov
Tool 'page-types' could list pages mapped by process or file cache pages, but it shows only limited amount of state exported via procfs. Let's employ existing helper dump_page() to reach remaining information: writing pfn into /sys/kernel/debug/dump_page dumps state into kernel log. # echo 0x37c4

[PATCH] riscv: Remove unnecessary path for syscall_trace

2020-05-25 Thread guoren
From: Guo Ren Obviously, there is no need to recover a0-a7 in reject path. Previous modification is from commit af33d243 by Tycho, to fixup seccomp reject syscall code path. Signed-off-by: Guo Ren Cc: Tycho Andersen Cc: Kees Cook Cc: Palmer Dabbelt --- arch/riscv/kernel/entry.S | 3 +-- 1

Re: [RFC PATCH] gpio: uapi: v2 proposal

2020-05-25 Thread Kent Gibson
On Mon, May 25, 2020 at 10:39:42AM +0200, Linus Walleij wrote: > On Sat, May 16, 2020 at 8:45 AM Kent Gibson wrote: > > > Add a new version of the uAPI to address existing 32/64bit alignment > > issues, add support for debounce, and provide some future proofing by > > adding padding reserved for

[PATCH v4 02/10] perf evlist: introduce control file descriptors

2020-05-25 Thread Alexey Budankov
Define and initialize control file descriptors. Signed-off-by: Alexey Budankov --- tools/perf/util/evlist.c | 3 +++ tools/perf/util/evlist.h | 5 + 2 files changed, 8 insertions(+) diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c index 2a9de6491700..0872b0b04a42 100644 --

[PATCH v4 01/10] tools/libperf: introduce static poll file descriptors

2020-05-25 Thread Alexey Budankov
Implement adding of file descriptors to fixed size (currently 1) storage at struct fdarray by the dedicated fdarray__add_stat(). Append the static descriptors to the array used by poll() syscall at fdarray__poll(). Copy poll() result of the descriptors from the array back to the storage for possi

Re: Endless soft-lockups for compiling workload since next-20200519

2020-05-25 Thread Peter Zijlstra
On Mon, May 25, 2020 at 03:21:05PM +0200, Peter Zijlstra wrote: > - flags = atomic_fetch_andnot(NOHZ_KICK_MASK, nohz_flags(this_cpu)); > - if (!(flags & NOHZ_KICK_MASK)) > + if (idle != CPU_IDLE) > return false; > > _nohz_idle_balance(this_rq, flags, idle); Bah, I

[PATCH] SUNRPC: Remove unreachable error condition in rpcb_getport_async()

2020-05-25 Thread Xiyu Yang
rpcb_getport_async() invokes rpcb_call_async(), which return the value of rpc_run_task() to "child". Since rpc_run_task() is impossible to return an ERR pointer, there is no need to add the IS_ERR() condition on "child" here. So we need to remove it. Signed-off-by: Xiyu Yang Signed-off-by: Xin Ta

[PATCH] scsi: lpfc: Fix lpfc_nodelist leak when processing unsolicited event

2020-05-25 Thread Xiyu Yang
In order to create or activate a new node, lpfc_els_unsol_buffer() invokes lpfc_nlp_init() or lpfc_enable_node() or lpfc_nlp_get(), all of them will return a reference of the specified lpfc_nodelist object to "ndlp" with increased refcnt. When lpfc_els_unsol_buffer() returns, local variable "ndlp"

[PATCH] MAINTAINERS: adjust entry in XDP SOCKETS to actual file name

2020-05-25 Thread Lukas Bulwahn
h. Hence, ./scripts/get_maintainer.pl --self-test=patterns complains: warning: no file matches F: include/net/xsk_buffer_pool.h Adjust the entry in XDP SOCKETS to the actual file name. Signed-off-by: Lukas Bulwahn --- Bj??rn, please pick this minor non-urgent patch. applies to next-20200525 o

[PATCH] nfsd: Fix svc_xprt refcnt leak when setup callback client failed

2020-05-25 Thread Xiyu Yang
nfsd4_process_cb_update() invokes svc_xprt_get(), which increases the refcount of the "c->cn_xprt". The reference counting issue happens in one exception handling path of nfsd4_process_cb_update(). When setup callback client failed, the function forgets to decrease the refcnt increased by svc_xprt

[PATCH] dax: Fix dax_region refcnt leak when creating dev_dax

2020-05-25 Thread Xiyu Yang
__devm_create_dev_dax() invokes kref_get(), which increases the refcount of the "dax_region". The reference counting issue happens in several exception handling paths of __devm_create_dev_dax(). When those error scenarios occur such as add device failed, the function forgets to decrease the refcnt

[PATCH] ASoC: fsl_asrc_dma: Fix dma_chan leak when config DMA channel failed

2020-05-25 Thread Xiyu Yang
fsl_asrc_dma_hw_params() invokes dma_request_channel() or fsl_asrc_get_dma_channel(), which returns a reference of the specified dma_chan object to "pair->dma_chan[dir]" with increased refcnt. The reference counting issue happens in one exception handling path of fsl_asrc_dma_hw_params(). When con

Re: io_uring: BUG: kernel NULL pointer dereference

2020-05-25 Thread Pavel Begunkov
On 25/05/2020 16:45, Stefano Garzarella wrote: > On Mon, May 25, 2020 at 12:30:51PM +0200, Stefano Garzarella wrote: >> >> I'll try to bisect, but I have some suspicions about: >> b41e98524e42 io_uring: add per-task callback handler > > I confirm, the bisection ended with this: > b41e98524e424d104

[PATCH] afs: Fix afs_cb_interest refcnt leak in afs_select_fileserver()

2020-05-25 Thread Xiyu Yang
afs_select_fileserver() invokes afs_get_cb_interest(), which returns a reference of the specified afs_cb_interest object to "fc->cbi" with increased refcnt. The reference counting issue happens in one exception handling path of afs_select_fileserver(). When error occurred in afs_wait_for_fs_probes

[PATCH 2/2] power: supply: bq27xxx_battery: Notify about voltage and current changes

2020-05-25 Thread Krzysztof Kozlowski
Read voltage and current and store them in the cache (like other properties). This has benefits: 1. User-space will be notified on voltage or current change. These are important properties of charging so user-space might be interested in getting them. 2. Closes possible resource exhaustion

[PATCH 1/2] power: supply: bq27xxx_battery: Notify about all battery changes

2020-05-25 Thread Krzysztof Kozlowski
All battery related data could be important for user-space. For example time-to-full could be shown to user on the screen or health could be monitored for any issues. Instead of comparing few selected old/new values, just check if anything changed in the cache. Signed-off-by: Krzysztof Kozlowski

[PATCH v4 00/10] perf: support enable and disable commands in stat and record modes

2020-05-25 Thread Alexey Budankov
Changes in v4: - made checking of ctlfd state unconditional in record trace streaming loop - introduced static poll fds to keep evlist__filter_pollfd() unaffected - handled ret code of evlist__initialize_ctlfd() where need - renamed and structured handle_events() function - applied anonymous stru

Re: io_uring: BUG: kernel NULL pointer dereference

2020-05-25 Thread Jens Axboe
On 5/25/20 7:45 AM, Stefano Garzarella wrote: > On Mon, May 25, 2020 at 12:30:51PM +0200, Stefano Garzarella wrote: >> Hi Jens, >> using fio and io_uring engine with SQPOLL and IOPOLL enabled, I had the >> following issue that happens after 4/5 seconds fio has started. >> Initially I had this issue

[PATCH v6 2/3] dt-bindings: arm: actions: Document Caninos Loucos Labrador

2020-05-25 Thread Matheus Castello
Update the documentation to add the Caninos Loucos Labrador. Labrador project consists of a computer on module based on the Actions Semi S500 processor and the Labrador base board. Signed-off-by: Matheus Castello Acked-by: Rob Herring --- Documentation/devicetree/bindings/arm/actions.yaml | 5 +

Re: [PATCH v1 10/25] seqlock: Add RST directives to kernel-doc code samples and notes

2020-05-25 Thread Peter Zijlstra
On Mon, May 25, 2020 at 03:44:29PM +0200, Peter Zijlstra wrote: > I've never claimed that. My claim is that RST is shite and has no added > value. Or rather, it has negative value, for it makes comments less readable.

Re: Endless soft-lockups for compiling workload since next-20200519

2020-05-25 Thread Frederic Weisbecker
On Mon, May 25, 2020 at 03:21:05PM +0200, Peter Zijlstra wrote: > @@ -2320,7 +2304,7 @@ static void ttwu_queue_remote(struct task_struct *p, > int cpu, int wake_flags) > > if (llist_add(&p->wake_entry, &rq->wake_list)) { > if (!set_nr_if_polling(rq->idle)) > -

Re: [PATCH v5 09/13] soc: mediatek: cmdq: add write_s value function

2020-05-25 Thread Matthias Brugger
On 25/05/2020 12:38, Dennis-YC Hsieh wrote: > > On Mon, 2020-05-25 at 10:39 +0200, Matthias Brugger wrote: >> >> On 25/05/2020 04:27, Dennis-YC Hsieh wrote: >>> >>> On Sun, 2020-05-24 at 20:13 +0200, Matthias Brugger wrote: On 24/05/2020 19:31, Dennis-YC Hsieh wrote: > Hi Matthias

Re: [PATCH v3 1/8] dt-bindings: net: meson-dwmac: Add the amlogic,rx-delay-ns property

2020-05-25 Thread Andrew Lunn
> > standardizing on rx-delay-ps and tx-delay-ps would make sense since that > > is the lowest resolution and the property would be correctly named with > > an unit in the name. > > Seems like similar patch is already being reviewed from Dan Murphy (?) > from TI. Dan is working on the PHY side. B

Re: [RFC linux-next PATCH] mm: khugepaged: remove error message when checking external pins

2020-05-25 Thread Qian Cai
On Thu, May 21, 2020 at 10:56:51AM -0400, Qian Cai wrote: > On Wed, May 13, 2020 at 05:03:03AM +0800, Yang Shi wrote: > [] > > mm/khugepaged.c | 24 +--- > > 1 file changed, 17 insertions(+), 7 deletions(-) > > > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > > index 1fdd6

Re: [PATCH 2/5] seccomp: Introduce addfd ioctl to seccomp user notifier

2020-05-25 Thread Christian Brauner
On Sun, May 24, 2020 at 04:39:39PM -0700, Sargun Dhillon wrote: > This adds a seccomp notifier ioctl which allows for the listener to "add" > file descriptors to a process which originated a seccomp user > notification. This allows calls like mount, and mknod to be "implemented", > as the return va

Re: [PATCH] proc.5: add "wf" to VmFlags in /proc/[pid]/smaps

2020-05-25 Thread Michael Kerrisk (man-pages)
On 5/22/20 1:13 AM, Ian Rogers wrote: > On Thu, May 21, 2020 at 3:25 PM Ian Rogers wrote: >> >> This patch documents a flag added in the following kernel commit: >> >> commit d2cd9ede6e193dd7d88b6d27399e96229a551b19 >> Author: Rik van Riel >> Date: Wed Sep 6 16:25:15 2017 -0700 >> >> mm,for

Re: [RFC 00/16] KVM protected memory extension

2020-05-25 Thread Liran Alon
On 22/05/2020 15:51, Kirill A. Shutemov wrote: == Background / Problem == There are a number of hardware features (MKTME, SEV) which protect guest memory from some unauthorized host access. The patchset proposes a purely software feature that mitigates some of the same host-side read-only atta

Re: [PATCH] proc.5: add "wf" to VmFlags in /proc/[pid]/smaps

2020-05-25 Thread Michael Kerrisk (man-pages)
Hello Ian, On 5/22/20 12:25 AM, Ian Rogers wrote: > This patch documents a flag added in the following kernel commit: > > commit d2cd9ede6e193dd7d88b6d27399e96229a551b19 > Author: Rik van Riel > Date: Wed Sep 6 16:25:15 2017 -0700 > > mm,fork: introduce MADV_WIPEONFORK > > This was alrea

[PATCH v6 1/3] dt-bindings: Add vendor prefix for Caninos Loucos

2020-05-25 Thread Matheus Castello
The Caninos Loucos Program develops Single Board Computers with an open structure. The Program wants to form a community of developers to use IoT technologies and disseminate the learning of embedded systems in Brazil. It is an initiative of the Technological Integrated Systems Laboratory (LSI-TEC

Re: [PATCH] watchdog: bcm_kona_wdt: Use correct return value for bcm_kona_wdt_probe()

2020-05-25 Thread Guenter Roeck
On 5/25/20 12:31 AM, Tiezhu Yang wrote: > When call function devm_platform_ioremap_resource(), we should use IS_ERR() > to check the return value and return PTR_ERR() if failed. > > Signed-off-by: Tiezhu Yang Reviewed-by: Guenter Roeck > --- > drivers/watchdog/bcm_kona_wdt.c | 2 +- > 1 file

Re: io_uring: BUG: kernel NULL pointer dereference

2020-05-25 Thread Stefano Garzarella
On Mon, May 25, 2020 at 12:30:51PM +0200, Stefano Garzarella wrote: > Hi Jens, > using fio and io_uring engine with SQPOLL and IOPOLL enabled, I had the > following issue that happens after 4/5 seconds fio has started. > Initially I had this issue on Linux v5.7-rc6, but I just tried also > Linux v5

Re: [PATCH v1 10/25] seqlock: Add RST directives to kernel-doc code samples and notes

2020-05-25 Thread Peter Zijlstra
On Mon, May 25, 2020 at 11:36:49AM +0200, Ahmed S. Darwish wrote: > Peter Zijlstra wrote: > > I will not let sensible code comments deteriorate to the benefit of some > > external piece of crap. > > > > As a programmer the primary interface to all this is a text editor, not > > a web broswer or a

[PATCH v6 3/3] ARM: dts: Add Caninos Loucos Labrador

2020-05-25 Thread Matheus Castello
Add Device Trees for Caninos Loucos Labrador CoM and base board. Based on the work of Andreas Färber on Lemaker Guitar device tree. Signed-off-by: Matheus Castello Reviewed-by: Manivannan Sadhasivam Reviewed-by: Andreas Färber --- arch/arm/boot/dts/Makefile| 1 + .../arm/b

Re: [RFC 08/11] net: phy: Allow mdio buses to auto-probe c45 devices

2020-05-25 Thread Andrew Lunn
> > > So i think it would be better to have > > > > > > enum { > > > MDIOBUS_UNKNOWN = 0, > > > MDIOBUS_C22, > > > MDIOBUS_C45, > > > MDIOBUS_C45_C22, > > > } bus_capabilities; > > > > > > Describe just what the bus master can support. > > > > Yes, the

Re: [PATCH 0/2] Let pci_fixup_final access iommu_fwnode

2020-05-25 Thread Joerg Roedel
On Tue, May 12, 2020 at 12:08:29PM +0800, Zhangfei Gao wrote: > Some platform devices appear as PCI but are > actually on the AMBA bus, and they need fixup in > drivers/pci/quirks.c handling iommu_fwnode. > So calling pci_fixup_final after iommu_fwnode is allocated. > > For example: > Hisilicon p

Re: [PATCH v2 08/12] i2c: designware: Introduce platform drivers glue layer interface

2020-05-25 Thread Andy Shevchenko
On Mon, May 25, 2020 at 04:16:05PM +0300, Jarkko Nikula wrote: > On 5/21/20 5:37 AM, Serge Semin wrote: > For this patchset I'd like more if changes are done to > i2c-designware-platdrv.c since it's not too complicated yet :-) And after moving ACPI stuff to common code, the one has even been shru

Re: [PATCH 0/6] nouveau/hmm: add support for mapping large pages

2020-05-25 Thread Jason Gunthorpe
On Fri, May 08, 2020 at 12:20:03PM -0700, Ralph Campbell wrote: > hmm_range_fault() returns an array of page frame numbers and flags for > how the pages are mapped in the requested process' page tables. The PFN > can be used to get the struct page with hmm_pfn_to_page() and the page size > order ca

Re: [PATCH] serial: 8250: probe all 16550A variants by default

2020-05-25 Thread Andy Shevchenko
On Mon, May 25, 2020 at 04:02:38PM +0300, Vladimir Oltean wrote: > From: Vladimir Oltean > > On NXP T1040, the UART is typically detected as 16550A_FSL64. After said > patch, it gets detected as plain 16550A and the Linux console is > completely garbled and missing characters. > > So clearly, in

Re: [Tee-dev] [PATCHv3 2/3] optee: use uuid for sysfs driver entry

2020-05-25 Thread Maxim Uvarov
On Mon, 25 May 2020 at 15:10, Jerome Forissier wrote: > > > > On 5/25/20 1:52 PM, Maxim Uvarov wrote: > > Optee device names for sysfs needed to be unique > > s/Optee/OP-TEE/ > s/needed/need/ > > > and it's better if they will mean something. UUID for name > > looks like good solution: > > /sys/bu

Re: [PATCH 2/2] usb: serial: xr_serial: Add gpiochip support

2020-05-25 Thread Greg KH
On Mon, May 25, 2020 at 03:02:15PM +0200, Linus Walleij wrote: > On Mon, May 25, 2020 at 1:12 PM Greg KH wrote: > > > > I remember I even referred to this myself, but I've been waning a bit > > > on it recently, because it turns out that userspace/users aren't very > > > good at parsing sysfs for

Re: [PATCH v2 0/7] Share events between metrics

2020-05-25 Thread Arnaldo Carvalho de Melo
Em Sun, May 24, 2020 at 12:19:36AM +0200, Jiri Olsa escreveu: > On Fri, May 22, 2020 at 10:56:59AM -0700, Ian Rogers wrote: > > SNIP > > > >> > #11 0x004b6911 in cmd_test (argc=1, argv=0x7fffd7f0) > > >> > at tests/builtin-test.c:772 > > >> > #12 0x004e977b in run

Re: [PATCH] qlcnic: Complete exception handling in qlcnic_83xx_interrupt_test()

2020-05-25 Thread Markus Elfring
> …, function qlcnic_83xx_diag_alloc_res() is not handled by > function qlcnic_83xx_diag_free_res() after a call of … I have got understanding difficulties for this wording. > Fix this issue by adding a jump target "fail_mbx_args", > and jump to this new target when qlcnic_alloc_mbx_args() faile

Re: [PATCHv3 2/3] optee: use uuid for sysfs driver entry

2020-05-25 Thread Maxim Uvarov
On Mon, 25 May 2020 at 15:47, Greg KH wrote: > > On Mon, May 25, 2020 at 02:52:34PM +0300, Maxim Uvarov wrote: > > Optee device names for sysfs needed to be unique > > and it's better if they will mean something. UUID for name > > looks like good solution: > > /sys/bus/tee/devices/optee-clnt- > >

Re: [PATCH] media: vsp1: dl: Fix NULL pointer dereference on unbind

2020-05-25 Thread Eugeniu Rosca
Hi Kieran, On Mon, May 25, 2020 at 02:19:02PM +0100, Kieran Bingham wrote: > Hi Eugeniu, > > Yeouch. Looks like I really missed a trick there! Not a big deal. The good part is that it can be proactively fixed and shared across the community. > > We should probably update the $SUBJECT to match

Re: [PATCH] can: mcp251x: convert to half-duplex SPI

2020-05-25 Thread Mark Brown
On Mon, May 25, 2020 at 03:12:05PM +0200, Marc Kleine-Budde wrote: > On 5/25/20 2:57 PM, Mark Brown wrote: > > On Mon, May 25, 2020 at 02:41:31PM +0200, Marc Kleine-Budde wrote: > >> On 5/25/20 1:31 PM, Mark Brown wrote: > >> The core could merge several half duplex transfers (until there's as >

Re: [PATCH v2 2/7] radix-tree: Use local_lock for protection

2020-05-25 Thread Ingo Molnar
* Matthew Wilcox wrote: > On Mon, May 25, 2020 at 08:29:54AM +0200, Ingo Molnar wrote: > > > +void radix_tree_preload_end(void) > > > +{ > > > + local_unlock(&radix_tree_preloads.lock); > > > +} > > > +EXPORT_SYMBOL(radix_tree_preload_end); > > > > Since upstream we are still mapping the local

Re: [PATCH 1/5] seccomp: Add find_notification helper

2020-05-25 Thread Christian Brauner
On Sun, May 24, 2020 at 04:39:38PM -0700, Sargun Dhillon wrote: > This adds a helper which can iterate through a seccomp_filter to > find a notification matching an ID. It removes several replicated > chunks of code. > > Signed-off-by: Sargun Dhillon > Cc: Matt Denton > Cc: Kees Cook , > Cc: Jan

Re: [PATCH v3 10/16] gpio: add a reusable generic gpio_chip using regmap

2020-05-25 Thread Andy Shevchenko
On Mon, May 25, 2020 at 02:59:36PM +0200, Linus Walleij wrote: > On Mon, May 25, 2020 at 12:20 PM Michael Walle wrote: > > > If you like I could submit this patch on its own. But then there > > wouldn't be a user for it. > > I'm pretty much fine with that, we do merge code that has no > users if

Re: [PATCH] iommu: Don't take group reference in iommu_alloc_default_domain()

2020-05-25 Thread Sai Prakash Ranjan
Hi Joerg, On 2020-05-25 18:31, Joerg Roedel wrote: From: Joerg Roedel The iommu_alloc_default_domain() function takes a reference to an IOMMU group without releasing it. This causes the group to never be released, with undefined side effects. The function has only one call-site, which takes a

Re: [RFC/RFT][PATCH] cpufreq: intel_pstate: Work in passive mode with HWP enabled

2020-05-25 Thread Rafael J. Wysocki
On Mon, May 25, 2020 at 3:39 AM Francisco Jerez wrote: > > "Rafael J. Wysocki" writes: > > > From: Rafael J. Wysocki > > > > Allow intel_pstate to work in the passive mode with HWP enabled and > > make it translate the target frequency supplied by the cpufreq > > governor in use into an EPP valu

[PATCH v6 0/3] Add Caninos Loucos Labrador CoM and Base Board Device Tree

2020-05-25 Thread Matheus Castello
Thanks Andreas, Mani and Rob for your time reviewing it. Changes since v5: (Suggested by Andreas Färber) - Put caninos,labrador-v2 as const one level down Changes since v4: (Suggested by Rob Herring) - Fix issues with yaml indentation Matheus Castello (3): dt-bindings: Add vendor prefix for Ca

Re: Endless soft-lockups for compiling workload since next-20200519

2020-05-25 Thread Peter Zijlstra
On Thu, May 21, 2020 at 02:41:14PM +0200, Frederic Weisbecker wrote: > On Thu, May 21, 2020 at 01:00:27PM +0200, Peter Zijlstra wrote: > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > > index 01f94cf52783..b6d8a7b991f0 100644 > > --- a/kernel/sched/fair.c > > +++ b/kernel/sched/fair.c

Re: [PATCH] media: vsp1: dl: Fix NULL pointer dereference on unbind

2020-05-25 Thread Kieran Bingham
Hi Eugeniu, Yeouch. Looks like I really missed a trick there! We should probably update the $SUBJECT to match what is performed in the patch, which is perhaps more like: "media: vsp1: dl: Store VSP reference when creating cmd pools" On 23/05/2020 09:13, Eugeniu Rosca wrote: And then we can exp

Re: [PATCH 1/3 RESEND] sched: Remove __rcu annotation from cred pointer

2020-05-25 Thread Richard Guy Briggs
On 2020-05-24 13:41, Amol Grover wrote: > On Thu, Apr 02, 2020 at 11:26:38AM +0530, Amol Grover wrote: > > task_struct::cred (subjective credentials) is *always* used > > task-synchronously, hence, does not require RCU semantics. > > > > task_struct::real_cred (objective credentials) can be used i

Re: MRP netlink interface

2020-05-25 Thread Michal Kubecek
On Mon, May 25, 2020 at 01:14:35PM +, Horatiu Vultur wrote: > The 05/25/2020 13:26, Nikolay Aleksandrov wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > On 25/05/2020 13:03, Michal Kubecek wrote: > > > On Mon, May 25, 2020 at 11

Re: KVM broken after suspend in most recent kernels.

2020-05-25 Thread Brad Campbell
On 25/5/20 7:46 pm, Maxim Levitsky wrote: On Sun, 2020-05-24 at 18:43 +0800, Brad Campbell wrote: On 24/5/20 12:50 pm, Brad Campbell wrote: G'day all. Machine is a Macbook Pro Retina ~ 2014. Kernels are always vanilla kernel and compiled on the machine. No additional patches. vendor_id

Re: [PATCH v2 08/12] i2c: designware: Introduce platform drivers glue layer interface

2020-05-25 Thread Jarkko Nikula
Hi On 5/21/20 5:37 AM, Serge Semin wrote: On Wed, May 20, 2020 at 03:46:11PM +0300, Jarkko Nikula wrote: Hi On 5/10/20 12:50 PM, Serge Semin wrote: Seeing the DW I2C platform driver is getting overcomplicated with a lot of vendor-specific configs let's introduce a glue-layer interface so new

Re: [GIT PULL] EFI changes for v5.8

2020-05-25 Thread Ingo Molnar
* Ard Biesheuvel wrote: > Ingo, Thomsd, Boris, > > Please pull the changes below. Note that I did not incorporate the GOT > handling changes for the x86 decompressor - Arvind has some changes on > top that might just as well go in at the same time, and they are not > really EFI changes anyway.

Re: [PATCH v13 2/2] media: v4l: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem driver

2020-05-25 Thread Luca Ceresoli
Hi Vishal, thanks. I have only a few minor nitpicking comments. On 12/05/20 17:19, Vishal Sagar wrote: > The Xilinx MIPI CSI-2 Rx Subsystem soft IP is used to capture images > from MIPI CSI-2 camera sensors and output AXI4-Stream video data ready > for image processing. Please refer to PG232 for

Re: [PATCH] can: mcp251x: convert to half-duplex SPI

2020-05-25 Thread Marc Kleine-Budde
On 5/25/20 2:57 PM, Mark Brown wrote: > On Mon, May 25, 2020 at 02:41:31PM +0200, Marc Kleine-Budde wrote: >> On 5/25/20 1:31 PM, Mark Brown wrote: > >>> This isn't something that every individual driver should be doing, such >>> rewriting should happen in the core so that everything sees the bene

Re: [PATCH] sctp: check assoc before SCTP_ADDR_{MADE_PRIM,ADDED} event

2020-05-25 Thread Marcelo Ricardo Leitner
On Mon, May 25, 2020 at 04:42:16PM +0800, Xin Long wrote: > On Sat, May 23, 2020 at 8:04 PM Jonas Falkevik > wrote: > > > > On Tue, May 19, 2020 at 10:42 PM Marcelo Ricardo Leitner > > wrote: > > > > > > On Fri, May 15, 2020 at 10:30:29AM +0200, Jonas Falkevik wrote: > > > > On Wed, May 13, 2020

[PATCH] iio: dac: ad5592r: remove usage of iio_priv_to_dev() helper

2020-05-25 Thread Alexandru Ardelean
This was partially removed when the mlock cleanup was done. Only one more call is left in the ad5592r_alloc_channels() function. This one is simple. We just need to pass the iio_dev object and get the state via iio_priv(). Signed-off-by: Alexandru Ardelean --- drivers/iio/dac/ad5592r-base.c | 6

Re: [PATCH] iommu: Fix group refcount in iommu_alloc_default_domain()

2020-05-25 Thread Sai Prakash Ranjan
Hi Joerg, On 2020-05-25 18:32, Joerg Roedel wrote: Hi, On Fri, May 22, 2020 at 06:31:45PM +0530, Sai Prakash Ranjan wrote: diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index a4c2f122eb8b..05f7b77c432f 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -1491,6 +1491

[PATCH v2 2/2] phy: Remove CONFIG_ARCH_* check for related subdir in Makefile

2020-05-25 Thread Tiezhu Yang
If CONFIG_ARCH_ROCKCHIP is not set but COMPILE_TEST is set, the file in the subdir rockchip can not be built due to CONFIG_ARCH_ROCKCHIP check in drivers/phy/Makefile. Since the related configs in drivers/phy/rockchip/Kconfig depend on ARCH_ROCKCHIP, so remove CONFIG_ARCH_ROCKCHIP check for subdir

[PATCH v2 1/2] phy: rockchip: Fix return value of inno_dsidphy_probe()

2020-05-25 Thread Tiezhu Yang
When call function devm_platform_ioremap_resource(), we should use IS_ERR() to check the return value and return PTR_ERR() if failed. Fixes: b7535a3bc0ba ("phy/rockchip: Add support for Innosilicon MIPI/LVDS/TTL PHY") Signed-off-by: Tiezhu Yang Reviewed-by: Heiko Stuebner --- v2: - No change

Re: [PATCH] arm: dts: am33xx-bone-common: add gpio-line-names

2020-05-25 Thread Linus Walleij
On Mon, May 25, 2020 at 2:07 PM Drew Fustini wrote: > On Mon, May 25, 2020 at 11:23:17AM +0200, Linus Walleij wrote: > > On Thu, May 21, 2020 at 12:02 AM Drew Fustini wrote: > > > > > I've posted a v2 which I hope improves the intent of the line names. [0] > > > > > > I'm happy to integrate any f

Re: [PATCH 05/16] bcache: use bio_{start,end}_io_acct

2020-05-25 Thread Coly Li
On 2020/5/25 19:30, Christoph Hellwig wrote: > Switch bcache to use the nicer bio accounting helpers, and call the > routines where we also sample the start time to give coherent accounting > results. > > Signed-off-by: Christoph Hellwig Acked-by: Coly Li Coly Li > --- > drivers/md/bcache/r

Re: [RFC PATCH v2 0/3] Prefer working VT console over SPCR and device-tree chosen stdout-path

2020-05-25 Thread Petr Mladek
On Fri 2020-05-15 22:27:02, Alper Nebi Yasak wrote: > On 13/05/2020 17:37, Petr Mladek wrote: > > On Thu 2020-04-30 19:14:34, Alper Nebi Yasak wrote: > I think things run roughly in the following order (from what I can > decipher from kernel messages) and I think it matches your explanations: > >

Re: [PATCH] RDMA/core: fix missing release in add_port.

2020-05-25 Thread Jason Gunthorpe
On Mon, May 25, 2020 at 01:06:56AM -0500, wu000...@umn.edu wrote: > From: Qiushi Wu > > In function add_port(), pointer p is not released in error paths. > Fix this issue by adding a kfree(p) into the end of error path. > > Signed-off-by: Qiushi Wu > drivers/infiniband/core/sysfs.c | 1 + > 1

Re: [PATCH] iommu: Fix group refcount in iommu_alloc_default_domain()

2020-05-25 Thread Joerg Roedel
Hi, On Fri, May 22, 2020 at 06:31:45PM +0530, Sai Prakash Ranjan wrote: > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index a4c2f122eb8b..05f7b77c432f 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@ -1491,6 +1491,7 @@ static int iommu_alloc_default_domain(s

[PATCH] serial: 8250: probe all 16550A variants by default

2020-05-25 Thread Vladimir Oltean
From: Vladimir Oltean On NXP T1040, the UART is typically detected as 16550A_FSL64. After said patch, it gets detected as plain 16550A and the Linux console is completely garbled and missing characters. So clearly, introducing the SERIAL_8250_16550A_VARIANTS config option has broken many existin

Re: [PATCH 2/2] usb: serial: xr_serial: Add gpiochip support

2020-05-25 Thread Linus Walleij
On Mon, May 25, 2020 at 1:12 PM Greg KH wrote: > > I remember I even referred to this myself, but I've been waning a bit > > on it recently, because it turns out that userspace/users aren't very > > good at parsing sysfs for topology. > > Which is why they could use libudev :) Yet they insist on

[PATCH] iommu: Don't take group reference in iommu_alloc_default_domain()

2020-05-25 Thread Joerg Roedel
From: Joerg Roedel The iommu_alloc_default_domain() function takes a reference to an IOMMU group without releasing it. This causes the group to never be released, with undefined side effects. The function has only one call-site, which takes a group reference on its own, so to fix this leak, do n

[PATCH] [v2] media: coda: Fix runtime PM imbalance in coda_probe

2020-05-25 Thread Dinghao Liu
When coda_firmware_request() returns an error code, a pairing runtime PM usage counter decrement is needed to keep the counter balanced. Signed-off-by: Dinghao Liu --- Changelog: v2: - Remove changes to coda_remove(), which is incorrect. --- drivers/media/platform/coda/coda-common.c | 2 ++ 1

Re: [PATCH v2 07/12] i2c: designware: Move Baytrail sem config to the platform if-clause

2020-05-25 Thread Jarkko Nikula
On 5/21/20 5:22 AM, Serge Semin wrote: On Wed, May 20, 2020 at 03:16:14PM +0300, Jarkko Nikula wrote: On 5/10/20 12:50 PM, Serge Semin wrote: Currently Intel Baytrail I2C semaphore is a feature of the DW APB I2C platform driver. It's a bit confusing to see it's config in the menu at some separa

Re: [PATCH v5 2/3] dt-bindings: arm: actions: Document Caninos Loucos Labrador

2020-05-25 Thread Matheus Castello
Hi Andreas, Em 5/25/20 7:41 AM, Andreas Färber escreveu: Hi, Am 25.05.20 um 03:30 schrieb Matheus Castello: Update the documentation to add the Caninos Loucos Labrador. Labrador project consists of a computer on module based on the Actions Semi S500 processor and the Labrador base board. Sign

Re: [PATCH v3 10/16] gpio: add a reusable generic gpio_chip using regmap

2020-05-25 Thread Linus Walleij
On Mon, May 25, 2020 at 12:20 PM Michael Walle wrote: > If you like I could submit this patch on its own. But then there > wouldn't be a user for it. I'm pretty much fine with that, we do merge code that has no users if we anticipate they will be around the corner. Yours, Linus Walleij

[PATCH v2 4/4] pwm: jz4740: Add support for the JZ4725B

2020-05-25 Thread Paul Cercueil
The PWM hardware in the JZ4725B works the same as in the JZ4740, but has only six channels available. Signed-off-by: Paul Cercueil --- Notes: v2: Simply return -EINVAL if we can't get match data drivers/pwm/pwm-jz4740.c | 24 1 file changed, 20 insertions(+), 4 del

Re: [PATCH] can: mcp251x: convert to half-duplex SPI

2020-05-25 Thread Mark Brown
On Mon, May 25, 2020 at 02:41:31PM +0200, Marc Kleine-Budde wrote: > On 5/25/20 1:31 PM, Mark Brown wrote: > > This isn't something that every individual driver should be doing, such > > rewriting should happen in the core so that everything sees the benefit. > The core could merge several half d

[PATCH v2 1/4] pwm: jz4740: Drop dependency on MACH_INGENIC

2020-05-25 Thread Paul Cercueil
Depending on MACH_INGENIC prevent us from creating a generic kernel that works on more than one MIPS board. Instead, we just depend on MIPS being set. Signed-off-by: Paul Cercueil Acked-by: Uwe Kleine-König --- Notes: v2: No change drivers/pwm/Kconfig | 2 +- 1 file changed, 1 insertion(+

[PATCH v2 2/4] pwm: jz4740: Enhance precision in calculation of duty cycle

2020-05-25 Thread Paul Cercueil
Calculating the hardware value for the duty from the hardware value of the period resulted in a precision loss versus calculating it from the clock rate directly. (Also remove a cast that doesn't really need to be here) Signed-off-by: Paul Cercueil --- Notes: v2: New patch. I don't consider

[PATCH v2 3/4] pwm: jz4740: Make PWM start with the active part

2020-05-25 Thread Paul Cercueil
The PWM in Ingenic SoCs starts in inactive state until the internal timer reaches the duty value, then becomes active until the timer reaches the period value. In theory, we should then use (period - duty) as the real duty value, as a high duty value would otherwise result in the PWM pin being inac

Re: [PATCH] RDMA/core: Complete exception handling in add_port()

2020-05-25 Thread Markus Elfring
> In function add_port(), pointer p is not released in error paths. 1. I would prefer to describe that an ib_port data structure was not released in some error cases. How relevant can its size be here? > Fix this issue by adding a kfree(p) into the end of error path. 2. I suggest to impro

[PATCH v3 5/6] mm: tlb: Provide flush_*_tlb_range wrappers

2020-05-25 Thread Zhenyu Ye
This patch provides flush_{pte|pmd|pud|p4d}_tlb_range() in generic code, which are expressed through the mmu_gather APIs. These interface set tlb->cleared_* and finally call tlb_flush(), so we can do the tlb invalidation according to the information in struct mmu_gather. Signed-off-by: Zhenyu Ye

[PATCH v3 2/6] arm64: Add level-hinted TLB invalidation helper

2020-05-25 Thread Zhenyu Ye
From: Marc Zyngier Add a level-hinted TLB invalidation helper that only gets used if ARMv8.4-TTL gets detected. Signed-off-by: Marc Zyngier Signed-off-by: Zhenyu Ye Reviewed-by: Catalin Marinas --- arch/arm64/include/asm/tlbflush.h | 29 + 1 file changed, 29 inser

[PATCH v3 0/6] arm64: tlb: add support for TTL feature

2020-05-25 Thread Zhenyu Ye
In order to reduce the cost of TLB invalidation, ARMv8.4 provides the TTL field in TLBI instruction. The TTL field indicates the level of page table walk holding the leaf entry for the address being invalidated. This series provide support for this feature. When ARMv8.4-TTL is implemented, the o

[PATCH v3 1/6] arm64: Detect the ARMv8.4 TTL feature

2020-05-25 Thread Zhenyu Ye
From: Marc Zyngier In order to reduce the cost of TLB invalidation, the ARMv8.4 TTL feature allows TLBs to be issued with a level allowing for quicker invalidation. Let's detect the feature for now. Further patches will implement its actual usage. Signed-off-by: Marc Zyngier Signed-off-by: Zhe

[PATCH v3 4/6] tlb: mmu_gather: add tlb_flush_*_range APIs

2020-05-25 Thread Zhenyu Ye
From: "Peter Zijlstra (Intel)" tlb_flush_{pte|pmd|pud|p4d}_range() adjust the tlb->start and tlb->end, then set corresponding cleared_*. Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Zhenyu Ye Acked-by: Catalin Marinas --- include/asm-generic/tlb.h | 55 ---

[PATCH v3 3/6] arm64: Add tlbi_user_level TLB invalidation helper

2020-05-25 Thread Zhenyu Ye
Add a level-hinted parameter to __tlbi_user, which only gets used if ARMv8.4-TTL gets detected. ARMv8.4-TTL provides the TTL field in tlbi instruction to indicate the level of translation table walk holding the leaf entry for the address that is being invalidated. This patch set the default level

[PATCH v3 6/6] arm64: tlb: Set the TTL field in flush_tlb_range

2020-05-25 Thread Zhenyu Ye
This patch uses the cleared_* in struct mmu_gather to set the TTL field in flush_tlb_range(). Signed-off-by: Zhenyu Ye --- arch/arm64/include/asm/tlb.h | 29 - arch/arm64/include/asm/tlbflush.h | 14 -- 2 files changed, 36 insertions(+), 7 deletions(-

Re: Re: [PATCH] media: coda: Fix runtime PM imbalance in coda_probe

2020-05-25 Thread dinghao . liu
> Hi Dinghao, > > thank you for the patch! The first part is fine, but I think the second > part is not necessary, see below: > > On Sat, May 23, 2020 at 06:03:32PM +0800, Dinghao Liu wrote: > > When coda_firmware_request() returns an error code, > > a pairing runtime PM usage counter decrement i

linux-next: Tree for May 25

2020-05-25 Thread Stephen Rothwell
Hi all, Changes since 20200522: New trees: uniphier and uniphier-fixes My fixes tree contains: cd2b06ec45d6 ("device_cgroup: Fix RCU list debugging warning") The mips tree gained conflicts against Linus' tree. The nand tree gained a build failure for which I applied a patch. The drm tree g

Re: [PATCHv3 2/3] optee: use uuid for sysfs driver entry

2020-05-25 Thread Greg KH
On Mon, May 25, 2020 at 02:52:34PM +0300, Maxim Uvarov wrote: > Optee device names for sysfs needed to be unique > and it's better if they will mean something. UUID for name > looks like good solution: > /sys/bus/tee/devices/optee-clnt- Can you document that in Documentation/ABI/ ? And why UUID?

Re: [PATCH] i2c: core: fix NULL pointer dereference in suspend/resume callbacks

2020-05-25 Thread Marek Szyprowski
Hi Tomasz On 25.05.2020 14:28, Tomasz Figa wrote: > On Fri, May 22, 2020 at 1:15 PM Marek Szyprowski > wrote: >> On 22.05.2020 12:13, Marek Szyprowski wrote: >>> Commit 6fe12cdbcfe3 ("i2c: core: support bus regulator controlling in >>> adapter") added generic suspend and resume functions for i2c

Re: [PATCH] can: mcp251x: convert to half-duplex SPI

2020-05-25 Thread Marc Kleine-Budde
On 5/25/20 1:31 PM, Mark Brown wrote: >>> Should I be submitting this patch with logic that only does >>> half-duplex if the spi controller doesn't support it (if >>> (spi->controller->flags & SPI_CONTROLLER_HALF_DUPLEX)) or is it >>> acceptable to simply make the driver half-duplex like this for a

Re: [PATCH] media: bdisp: Fix runtime PM imbalance on error

2020-05-25 Thread Fabien DESSENNE
Hi, Looks good to me. Reviewed-by: Fabien Dessenne BR Fabien On 21/05/2020 12:00 pm, Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > when it returns an error code. Thus a pairing decrement is needed on > the error handling path to keep the counter ba

linux-next: build warning after merge of the net-next tree

2020-05-25 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (sparc64 defconfig) produced this warning: drivers/net/ethernet/intel/e1000e/netdev.c:137:13: warning: 'e1000e_check_me' defined but not used [-Wunused-function] static bool e1000e_check_me(u16 device_id) ^~~

Re: [PATCH V4 00/17] arm64/cpufeature: Introduce ID_PFR2, ID_DFR1, ID_MMFR5 and other changes

2020-05-25 Thread Anshuman Khandual
On 05/21/2020 08:49 PM, Will Deacon wrote: > On Tue, 19 May 2020 15:10:37 +0530, Anshuman Khandual wrote: >> This series is primarily motivated from an adhoc list from Mark Rutland >> during our previous ID_ISAR6 discussion [1]. The current proposal also >> accommodates some more suggestions fro

Re: [PATCH] media: coda: Fix runtime PM imbalance in coda_probe

2020-05-25 Thread Philipp Zabel
Hi Dinghao, thank you for the patch! The first part is fine, but I think the second part is not necessary, see below: On Sat, May 23, 2020 at 06:03:32PM +0800, Dinghao Liu wrote: > When coda_firmware_request() returns an error code, > a pairing runtime PM usage counter decrement is needed > to ke

<    1   2   3   4   5   6   7   8   9   10   >