Re: [PATCHv3 2/3] optee: use uuid for sysfs driver entry

2020-05-25 Thread Maxim Uvarov
On Mon, 25 May 2020 at 15:47, Greg KH wrote: > > On Mon, May 25, 2020 at 02:52:34PM +0300, Maxim Uvarov wrote: > > Optee device names for sysfs needed to be unique > > and it's better if they will mean something. UUID for name > > looks like good solution: > > /sys/bus/tee/devices/optee-clnt- > >

Re: [PATCH] media: vsp1: dl: Fix NULL pointer dereference on unbind

2020-05-25 Thread Eugeniu Rosca
Hi Kieran, On Mon, May 25, 2020 at 02:19:02PM +0100, Kieran Bingham wrote: > Hi Eugeniu, > > Yeouch. Looks like I really missed a trick there! Not a big deal. The good part is that it can be proactively fixed and shared across the community. > > We should probably update the $SUBJECT to match

Re: [PATCH] can: mcp251x: convert to half-duplex SPI

2020-05-25 Thread Mark Brown
On Mon, May 25, 2020 at 03:12:05PM +0200, Marc Kleine-Budde wrote: > On 5/25/20 2:57 PM, Mark Brown wrote: > > On Mon, May 25, 2020 at 02:41:31PM +0200, Marc Kleine-Budde wrote: > >> On 5/25/20 1:31 PM, Mark Brown wrote: > >> The core could merge several half duplex transfers (until there's as >

Re: [PATCH v2 2/7] radix-tree: Use local_lock for protection

2020-05-25 Thread Ingo Molnar
* Matthew Wilcox wrote: > On Mon, May 25, 2020 at 08:29:54AM +0200, Ingo Molnar wrote: > > > +void radix_tree_preload_end(void) > > > +{ > > > + local_unlock(_tree_preloads.lock); > > > +} > > > +EXPORT_SYMBOL(radix_tree_preload_end); > > > > Since upstream we are still mapping the local_lock

Re: [PATCH 1/5] seccomp: Add find_notification helper

2020-05-25 Thread Christian Brauner
On Sun, May 24, 2020 at 04:39:38PM -0700, Sargun Dhillon wrote: > This adds a helper which can iterate through a seccomp_filter to > find a notification matching an ID. It removes several replicated > chunks of code. > > Signed-off-by: Sargun Dhillon > Cc: Matt Denton > Cc: Kees Cook , > Cc:

Re: [PATCH v3 10/16] gpio: add a reusable generic gpio_chip using regmap

2020-05-25 Thread Andy Shevchenko
On Mon, May 25, 2020 at 02:59:36PM +0200, Linus Walleij wrote: > On Mon, May 25, 2020 at 12:20 PM Michael Walle wrote: > > > If you like I could submit this patch on its own. But then there > > wouldn't be a user for it. > > I'm pretty much fine with that, we do merge code that has no > users

Re: [PATCH] iommu: Don't take group reference in iommu_alloc_default_domain()

2020-05-25 Thread Sai Prakash Ranjan
Hi Joerg, On 2020-05-25 18:31, Joerg Roedel wrote: From: Joerg Roedel The iommu_alloc_default_domain() function takes a reference to an IOMMU group without releasing it. This causes the group to never be released, with undefined side effects. The function has only one call-site, which takes

Re: [RFC/RFT][PATCH] cpufreq: intel_pstate: Work in passive mode with HWP enabled

2020-05-25 Thread Rafael J. Wysocki
On Mon, May 25, 2020 at 3:39 AM Francisco Jerez wrote: > > "Rafael J. Wysocki" writes: > > > From: Rafael J. Wysocki > > > > Allow intel_pstate to work in the passive mode with HWP enabled and > > make it translate the target frequency supplied by the cpufreq > > governor in use into an EPP

[PATCH v6 0/3] Add Caninos Loucos Labrador CoM and Base Board Device Tree

2020-05-25 Thread Matheus Castello
Thanks Andreas, Mani and Rob for your time reviewing it. Changes since v5: (Suggested by Andreas Färber) - Put caninos,labrador-v2 as const one level down Changes since v4: (Suggested by Rob Herring) - Fix issues with yaml indentation Matheus Castello (3): dt-bindings: Add vendor prefix for

Re: Endless soft-lockups for compiling workload since next-20200519

2020-05-25 Thread Peter Zijlstra
On Thu, May 21, 2020 at 02:41:14PM +0200, Frederic Weisbecker wrote: > On Thu, May 21, 2020 at 01:00:27PM +0200, Peter Zijlstra wrote: > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > > index 01f94cf52783..b6d8a7b991f0 100644 > > --- a/kernel/sched/fair.c > > +++ b/kernel/sched/fair.c

Re: [PATCH] media: vsp1: dl: Fix NULL pointer dereference on unbind

2020-05-25 Thread Kieran Bingham
Hi Eugeniu, Yeouch. Looks like I really missed a trick there! We should probably update the $SUBJECT to match what is performed in the patch, which is perhaps more like: "media: vsp1: dl: Store VSP reference when creating cmd pools" On 23/05/2020 09:13, Eugeniu Rosca wrote: And then we can

Re: [PATCH 1/3 RESEND] sched: Remove __rcu annotation from cred pointer

2020-05-25 Thread Richard Guy Briggs
On 2020-05-24 13:41, Amol Grover wrote: > On Thu, Apr 02, 2020 at 11:26:38AM +0530, Amol Grover wrote: > > task_struct::cred (subjective credentials) is *always* used > > task-synchronously, hence, does not require RCU semantics. > > > > task_struct::real_cred (objective credentials) can be used

Re: MRP netlink interface

2020-05-25 Thread Michal Kubecek
On Mon, May 25, 2020 at 01:14:35PM +, Horatiu Vultur wrote: > The 05/25/2020 13:26, Nikolay Aleksandrov wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > On 25/05/2020 13:03, Michal Kubecek wrote: > > > On Mon, May 25, 2020 at

Re: KVM broken after suspend in most recent kernels.

2020-05-25 Thread Brad Campbell
On 25/5/20 7:46 pm, Maxim Levitsky wrote: On Sun, 2020-05-24 at 18:43 +0800, Brad Campbell wrote: On 24/5/20 12:50 pm, Brad Campbell wrote: G'day all. Machine is a Macbook Pro Retina ~ 2014. Kernels are always vanilla kernel and compiled on the machine. No additional patches. vendor_id

Re: [PATCH v2 08/12] i2c: designware: Introduce platform drivers glue layer interface

2020-05-25 Thread Jarkko Nikula
Hi On 5/21/20 5:37 AM, Serge Semin wrote: On Wed, May 20, 2020 at 03:46:11PM +0300, Jarkko Nikula wrote: Hi On 5/10/20 12:50 PM, Serge Semin wrote: Seeing the DW I2C platform driver is getting overcomplicated with a lot of vendor-specific configs let's introduce a glue-layer interface so new

Re: [GIT PULL] EFI changes for v5.8

2020-05-25 Thread Ingo Molnar
* Ard Biesheuvel wrote: > Ingo, Thomsd, Boris, > > Please pull the changes below. Note that I did not incorporate the GOT > handling changes for the x86 decompressor - Arvind has some changes on > top that might just as well go in at the same time, and they are not > really EFI changes

Re: [PATCH v13 2/2] media: v4l: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem driver

2020-05-25 Thread Luca Ceresoli
Hi Vishal, thanks. I have only a few minor nitpicking comments. On 12/05/20 17:19, Vishal Sagar wrote: > The Xilinx MIPI CSI-2 Rx Subsystem soft IP is used to capture images > from MIPI CSI-2 camera sensors and output AXI4-Stream video data ready > for image processing. Please refer to PG232 for

Re: [PATCH] can: mcp251x: convert to half-duplex SPI

2020-05-25 Thread Marc Kleine-Budde
On 5/25/20 2:57 PM, Mark Brown wrote: > On Mon, May 25, 2020 at 02:41:31PM +0200, Marc Kleine-Budde wrote: >> On 5/25/20 1:31 PM, Mark Brown wrote: > >>> This isn't something that every individual driver should be doing, such >>> rewriting should happen in the core so that everything sees the

Re: [PATCH] sctp: check assoc before SCTP_ADDR_{MADE_PRIM,ADDED} event

2020-05-25 Thread Marcelo Ricardo Leitner
On Mon, May 25, 2020 at 04:42:16PM +0800, Xin Long wrote: > On Sat, May 23, 2020 at 8:04 PM Jonas Falkevik > wrote: > > > > On Tue, May 19, 2020 at 10:42 PM Marcelo Ricardo Leitner > > wrote: > > > > > > On Fri, May 15, 2020 at 10:30:29AM +0200, Jonas Falkevik wrote: > > > > On Wed, May 13,

[PATCH] iio: dac: ad5592r: remove usage of iio_priv_to_dev() helper

2020-05-25 Thread Alexandru Ardelean
This was partially removed when the mlock cleanup was done. Only one more call is left in the ad5592r_alloc_channels() function. This one is simple. We just need to pass the iio_dev object and get the state via iio_priv(). Signed-off-by: Alexandru Ardelean --- drivers/iio/dac/ad5592r-base.c | 6

Re: [PATCH] iommu: Fix group refcount in iommu_alloc_default_domain()

2020-05-25 Thread Sai Prakash Ranjan
Hi Joerg, On 2020-05-25 18:32, Joerg Roedel wrote: Hi, On Fri, May 22, 2020 at 06:31:45PM +0530, Sai Prakash Ranjan wrote: diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index a4c2f122eb8b..05f7b77c432f 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -1491,6

[PATCH v2 2/2] phy: Remove CONFIG_ARCH_* check for related subdir in Makefile

2020-05-25 Thread Tiezhu Yang
If CONFIG_ARCH_ROCKCHIP is not set but COMPILE_TEST is set, the file in the subdir rockchip can not be built due to CONFIG_ARCH_ROCKCHIP check in drivers/phy/Makefile. Since the related configs in drivers/phy/rockchip/Kconfig depend on ARCH_ROCKCHIP, so remove CONFIG_ARCH_ROCKCHIP check for

[PATCH v2 1/2] phy: rockchip: Fix return value of inno_dsidphy_probe()

2020-05-25 Thread Tiezhu Yang
When call function devm_platform_ioremap_resource(), we should use IS_ERR() to check the return value and return PTR_ERR() if failed. Fixes: b7535a3bc0ba ("phy/rockchip: Add support for Innosilicon MIPI/LVDS/TTL PHY") Signed-off-by: Tiezhu Yang Reviewed-by: Heiko Stuebner --- v2: - No

Re: [PATCH] arm: dts: am33xx-bone-common: add gpio-line-names

2020-05-25 Thread Linus Walleij
On Mon, May 25, 2020 at 2:07 PM Drew Fustini wrote: > On Mon, May 25, 2020 at 11:23:17AM +0200, Linus Walleij wrote: > > On Thu, May 21, 2020 at 12:02 AM Drew Fustini wrote: > > > > > I've posted a v2 which I hope improves the intent of the line names. [0] > > > > > > I'm happy to integrate any

Re: [PATCH 05/16] bcache: use bio_{start,end}_io_acct

2020-05-25 Thread Coly Li
On 2020/5/25 19:30, Christoph Hellwig wrote: > Switch bcache to use the nicer bio accounting helpers, and call the > routines where we also sample the start time to give coherent accounting > results. > > Signed-off-by: Christoph Hellwig Acked-by: Coly Li Coly Li > --- >

Re: [RFC PATCH v2 0/3] Prefer working VT console over SPCR and device-tree chosen stdout-path

2020-05-25 Thread Petr Mladek
On Fri 2020-05-15 22:27:02, Alper Nebi Yasak wrote: > On 13/05/2020 17:37, Petr Mladek wrote: > > On Thu 2020-04-30 19:14:34, Alper Nebi Yasak wrote: > I think things run roughly in the following order (from what I can > decipher from kernel messages) and I think it matches your explanations: > >

Re: [PATCH] RDMA/core: fix missing release in add_port.

2020-05-25 Thread Jason Gunthorpe
On Mon, May 25, 2020 at 01:06:56AM -0500, wu000...@umn.edu wrote: > From: Qiushi Wu > > In function add_port(), pointer p is not released in error paths. > Fix this issue by adding a kfree(p) into the end of error path. > > Signed-off-by: Qiushi Wu > drivers/infiniband/core/sysfs.c | 1 + > 1

Re: [PATCH] iommu: Fix group refcount in iommu_alloc_default_domain()

2020-05-25 Thread Joerg Roedel
Hi, On Fri, May 22, 2020 at 06:31:45PM +0530, Sai Prakash Ranjan wrote: > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index a4c2f122eb8b..05f7b77c432f 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@ -1491,6 +1491,7 @@ static int

[PATCH] serial: 8250: probe all 16550A variants by default

2020-05-25 Thread Vladimir Oltean
From: Vladimir Oltean On NXP T1040, the UART is typically detected as 16550A_FSL64. After said patch, it gets detected as plain 16550A and the Linux console is completely garbled and missing characters. So clearly, introducing the SERIAL_8250_16550A_VARIANTS config option has broken many

Re: [PATCH 2/2] usb: serial: xr_serial: Add gpiochip support

2020-05-25 Thread Linus Walleij
On Mon, May 25, 2020 at 1:12 PM Greg KH wrote: > > I remember I even referred to this myself, but I've been waning a bit > > on it recently, because it turns out that userspace/users aren't very > > good at parsing sysfs for topology. > > Which is why they could use libudev :) Yet they insist

[PATCH] iommu: Don't take group reference in iommu_alloc_default_domain()

2020-05-25 Thread Joerg Roedel
From: Joerg Roedel The iommu_alloc_default_domain() function takes a reference to an IOMMU group without releasing it. This causes the group to never be released, with undefined side effects. The function has only one call-site, which takes a group reference on its own, so to fix this leak, do

[PATCH] [v2] media: coda: Fix runtime PM imbalance in coda_probe

2020-05-25 Thread Dinghao Liu
When coda_firmware_request() returns an error code, a pairing runtime PM usage counter decrement is needed to keep the counter balanced. Signed-off-by: Dinghao Liu --- Changelog: v2: - Remove changes to coda_remove(), which is incorrect. --- drivers/media/platform/coda/coda-common.c | 2 ++ 1

Re: [PATCH v2 07/12] i2c: designware: Move Baytrail sem config to the platform if-clause

2020-05-25 Thread Jarkko Nikula
On 5/21/20 5:22 AM, Serge Semin wrote: On Wed, May 20, 2020 at 03:16:14PM +0300, Jarkko Nikula wrote: On 5/10/20 12:50 PM, Serge Semin wrote: Currently Intel Baytrail I2C semaphore is a feature of the DW APB I2C platform driver. It's a bit confusing to see it's config in the menu at some

Re: [PATCH v5 2/3] dt-bindings: arm: actions: Document Caninos Loucos Labrador

2020-05-25 Thread Matheus Castello
Hi Andreas, Em 5/25/20 7:41 AM, Andreas Färber escreveu: Hi, Am 25.05.20 um 03:30 schrieb Matheus Castello: Update the documentation to add the Caninos Loucos Labrador. Labrador project consists of a computer on module based on the Actions Semi S500 processor and the Labrador base board.

Re: [PATCH v3 10/16] gpio: add a reusable generic gpio_chip using regmap

2020-05-25 Thread Linus Walleij
On Mon, May 25, 2020 at 12:20 PM Michael Walle wrote: > If you like I could submit this patch on its own. But then there > wouldn't be a user for it. I'm pretty much fine with that, we do merge code that has no users if we anticipate they will be around the corner. Yours, Linus Walleij

[PATCH v2 4/4] pwm: jz4740: Add support for the JZ4725B

2020-05-25 Thread Paul Cercueil
The PWM hardware in the JZ4725B works the same as in the JZ4740, but has only six channels available. Signed-off-by: Paul Cercueil --- Notes: v2: Simply return -EINVAL if we can't get match data drivers/pwm/pwm-jz4740.c | 24 1 file changed, 20 insertions(+), 4

Re: [PATCH] can: mcp251x: convert to half-duplex SPI

2020-05-25 Thread Mark Brown
On Mon, May 25, 2020 at 02:41:31PM +0200, Marc Kleine-Budde wrote: > On 5/25/20 1:31 PM, Mark Brown wrote: > > This isn't something that every individual driver should be doing, such > > rewriting should happen in the core so that everything sees the benefit. > The core could merge several half

[PATCH v2 1/4] pwm: jz4740: Drop dependency on MACH_INGENIC

2020-05-25 Thread Paul Cercueil
Depending on MACH_INGENIC prevent us from creating a generic kernel that works on more than one MIPS board. Instead, we just depend on MIPS being set. Signed-off-by: Paul Cercueil Acked-by: Uwe Kleine-König --- Notes: v2: No change drivers/pwm/Kconfig | 2 +- 1 file changed, 1

[PATCH v2 2/4] pwm: jz4740: Enhance precision in calculation of duty cycle

2020-05-25 Thread Paul Cercueil
Calculating the hardware value for the duty from the hardware value of the period resulted in a precision loss versus calculating it from the clock rate directly. (Also remove a cast that doesn't really need to be here) Signed-off-by: Paul Cercueil --- Notes: v2: New patch. I don't

[PATCH v2 3/4] pwm: jz4740: Make PWM start with the active part

2020-05-25 Thread Paul Cercueil
The PWM in Ingenic SoCs starts in inactive state until the internal timer reaches the duty value, then becomes active until the timer reaches the period value. In theory, we should then use (period - duty) as the real duty value, as a high duty value would otherwise result in the PWM pin being

Re: [PATCH] RDMA/core: Complete exception handling in add_port()

2020-05-25 Thread Markus Elfring
> In function add_port(), pointer p is not released in error paths. 1. I would prefer to describe that an ib_port data structure was not released in some error cases. How relevant can its size be here? > Fix this issue by adding a kfree(p) into the end of error path. 2. I suggest to

[PATCH v3 5/6] mm: tlb: Provide flush_*_tlb_range wrappers

2020-05-25 Thread Zhenyu Ye
This patch provides flush_{pte|pmd|pud|p4d}_tlb_range() in generic code, which are expressed through the mmu_gather APIs. These interface set tlb->cleared_* and finally call tlb_flush(), so we can do the tlb invalidation according to the information in struct mmu_gather. Signed-off-by: Zhenyu Ye

[PATCH v3 2/6] arm64: Add level-hinted TLB invalidation helper

2020-05-25 Thread Zhenyu Ye
From: Marc Zyngier Add a level-hinted TLB invalidation helper that only gets used if ARMv8.4-TTL gets detected. Signed-off-by: Marc Zyngier Signed-off-by: Zhenyu Ye Reviewed-by: Catalin Marinas --- arch/arm64/include/asm/tlbflush.h | 29 + 1 file changed, 29

[PATCH v3 0/6] arm64: tlb: add support for TTL feature

2020-05-25 Thread Zhenyu Ye
In order to reduce the cost of TLB invalidation, ARMv8.4 provides the TTL field in TLBI instruction. The TTL field indicates the level of page table walk holding the leaf entry for the address being invalidated. This series provide support for this feature. When ARMv8.4-TTL is implemented, the

[PATCH v3 1/6] arm64: Detect the ARMv8.4 TTL feature

2020-05-25 Thread Zhenyu Ye
From: Marc Zyngier In order to reduce the cost of TLB invalidation, the ARMv8.4 TTL feature allows TLBs to be issued with a level allowing for quicker invalidation. Let's detect the feature for now. Further patches will implement its actual usage. Signed-off-by: Marc Zyngier Signed-off-by:

[PATCH v3 4/6] tlb: mmu_gather: add tlb_flush_*_range APIs

2020-05-25 Thread Zhenyu Ye
From: "Peter Zijlstra (Intel)" tlb_flush_{pte|pmd|pud|p4d}_range() adjust the tlb->start and tlb->end, then set corresponding cleared_*. Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Zhenyu Ye Acked-by: Catalin Marinas --- include/asm-generic/tlb.h | 55

[PATCH v3 3/6] arm64: Add tlbi_user_level TLB invalidation helper

2020-05-25 Thread Zhenyu Ye
Add a level-hinted parameter to __tlbi_user, which only gets used if ARMv8.4-TTL gets detected. ARMv8.4-TTL provides the TTL field in tlbi instruction to indicate the level of translation table walk holding the leaf entry for the address that is being invalidated. This patch set the default

[PATCH v3 6/6] arm64: tlb: Set the TTL field in flush_tlb_range

2020-05-25 Thread Zhenyu Ye
This patch uses the cleared_* in struct mmu_gather to set the TTL field in flush_tlb_range(). Signed-off-by: Zhenyu Ye --- arch/arm64/include/asm/tlb.h | 29 - arch/arm64/include/asm/tlbflush.h | 14 -- 2 files changed, 36 insertions(+), 7

Re: Re: [PATCH] media: coda: Fix runtime PM imbalance in coda_probe

2020-05-25 Thread dinghao . liu
> Hi Dinghao, > > thank you for the patch! The first part is fine, but I think the second > part is not necessary, see below: > > On Sat, May 23, 2020 at 06:03:32PM +0800, Dinghao Liu wrote: > > When coda_firmware_request() returns an error code, > > a pairing runtime PM usage counter decrement

linux-next: Tree for May 25

2020-05-25 Thread Stephen Rothwell
Hi all, Changes since 20200522: New trees: uniphier and uniphier-fixes My fixes tree contains: cd2b06ec45d6 ("device_cgroup: Fix RCU list debugging warning") The mips tree gained conflicts against Linus' tree. The nand tree gained a build failure for which I applied a patch. The drm tree

Re: [PATCHv3 2/3] optee: use uuid for sysfs driver entry

2020-05-25 Thread Greg KH
On Mon, May 25, 2020 at 02:52:34PM +0300, Maxim Uvarov wrote: > Optee device names for sysfs needed to be unique > and it's better if they will mean something. UUID for name > looks like good solution: > /sys/bus/tee/devices/optee-clnt- Can you document that in Documentation/ABI/ ? And why UUID?

Re: [PATCH] i2c: core: fix NULL pointer dereference in suspend/resume callbacks

2020-05-25 Thread Marek Szyprowski
Hi Tomasz On 25.05.2020 14:28, Tomasz Figa wrote: > On Fri, May 22, 2020 at 1:15 PM Marek Szyprowski > wrote: >> On 22.05.2020 12:13, Marek Szyprowski wrote: >>> Commit 6fe12cdbcfe3 ("i2c: core: support bus regulator controlling in >>> adapter") added generic suspend and resume functions for i2c

Re: [PATCH] can: mcp251x: convert to half-duplex SPI

2020-05-25 Thread Marc Kleine-Budde
On 5/25/20 1:31 PM, Mark Brown wrote: >>> Should I be submitting this patch with logic that only does >>> half-duplex if the spi controller doesn't support it (if >>> (spi->controller->flags & SPI_CONTROLLER_HALF_DUPLEX)) or is it >>> acceptable to simply make the driver half-duplex like this for

Re: [PATCH] media: bdisp: Fix runtime PM imbalance on error

2020-05-25 Thread Fabien DESSENNE
Hi, Looks good to me. Reviewed-by: Fabien Dessenne BR Fabien On 21/05/2020 12:00 pm, Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > when it returns an error code. Thus a pairing decrement is needed on > the error handling path to keep the counter

linux-next: build warning after merge of the net-next tree

2020-05-25 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (sparc64 defconfig) produced this warning: drivers/net/ethernet/intel/e1000e/netdev.c:137:13: warning: 'e1000e_check_me' defined but not used [-Wunused-function] static bool e1000e_check_me(u16 device_id)

Re: [PATCH V4 00/17] arm64/cpufeature: Introduce ID_PFR2, ID_DFR1, ID_MMFR5 and other changes

2020-05-25 Thread Anshuman Khandual
On 05/21/2020 08:49 PM, Will Deacon wrote: > On Tue, 19 May 2020 15:10:37 +0530, Anshuman Khandual wrote: >> This series is primarily motivated from an adhoc list from Mark Rutland >> during our previous ID_ISAR6 discussion [1]. The current proposal also >> accommodates some more suggestions

Re: [PATCH] media: coda: Fix runtime PM imbalance in coda_probe

2020-05-25 Thread Philipp Zabel
Hi Dinghao, thank you for the patch! The first part is fine, but I think the second part is not necessary, see below: On Sat, May 23, 2020 at 06:03:32PM +0800, Dinghao Liu wrote: > When coda_firmware_request() returns an error code, > a pairing runtime PM usage counter decrement is needed > to

Re: [PATCH] FS: BTRFS: ulist.c: Fixed a brace coding style and space before tab

2020-05-25 Thread David Sterba
On Fri, May 22, 2020 at 05:29:02PM -0400, Ethan Edwards wrote: > From: Ethan Edwards > Fixed coding style No thanks. Long answer: https://btrfs.wiki.kernel.org/index.php/Developer%27s_FAQ#How_not_to_start

Re: [PATCH 2/2] phy: Remove CONFIG_ARCH_ROCKCHIP check for subdir rockchip

2020-05-25 Thread Tiezhu Yang
On 05/25/2020 06:48 PM, Heiko Stübner wrote: Am Montag, 25. Mai 2020, 06:08:59 CEST schrieb Tiezhu Yang: If CONFIG_ARCH_ROCKCHIP is not set but COMPILE_TEST is set, the file in the subdir rockchip can not be built due to CONFIG_ARCH_ROCKCHIP check in drivers/phy/Makefile. Since the related

Re: [RFC 00/14] perf tests: Check on subtest for user specified test

2020-05-25 Thread Jiri Olsa
On Mon, May 25, 2020 at 02:06:07PM +0200, Michael Petlan wrote: > On Mon, 25 May 2020, Jiri Olsa wrote: > > hi, > > changes for using metric result in another metric seem > > to change lot of core metric code, so it's better we > > have some more tests before we do that. > > > > Sending as RFC as

Re: block I/O accounting improvements

2020-05-25 Thread Konstantin Khlebnikov
On 25/05/2020 14.29, Christoph Hellwig wrote: Hi Jens, they series contains various improvement for block I/O accounting. The first bunch of patches switch the bio based drivers to better accounting helpers compared to the current mess. The end contains a fix and various performanc

Re: [PATCH] i2c: core: fix NULL pointer dereference in suspend/resume callbacks

2020-05-25 Thread Tomasz Figa
Hi Marek, On Fri, May 22, 2020 at 1:15 PM Marek Szyprowski wrote: > > Hi All, > > On 22.05.2020 12:13, Marek Szyprowski wrote: > > Commit 6fe12cdbcfe3 ("i2c: core: support bus regulator controlling in > > adapter") added generic suspend and resume functions for i2c devices. > > Those functions

Re: [PATCH 01/16] block: add disk/bio-based accounting helpers

2020-05-25 Thread Konstantin Khlebnikov
On 25/05/2020 14.29, Christoph Hellwig wrote: Add two new helpers to simplify I/O accounting for bio based drivers. Currently these drivers use the generic_start_io_acct and generic_end_io_acct helpers which have very cumbersome calling conventions, don't actually return the time they started

[PATCH v2] e1000: use generic power management

2020-05-25 Thread Vaibhav Gupta
compile-tested only With legacy PM hooks, it was the responsibility of a driver to manage PCI states and also the device's power state. The generic approach is to let PCI core handle the work. e1000_suspend() calls __e1000_shutdown() to perform intermediate tasks. __e1000_shutdown() modifies the

Re: [PATCH v3 3/3] vfio-pci: Invalidate mmaps and block MMIO access on disabled memory

2020-05-25 Thread Jason Gunthorpe
On Sat, May 23, 2020 at 07:52:57PM -0400, Peter Xu wrote: > For what I understand now, IMHO we should still need all those handlings of > FAULT_FLAG_RETRY_NOWAIT like in the initial version. E.g., IIUC KVM gup will > try with FOLL_NOWAIT when async is allowed, before the complete slow path. >

Re: [PATCH v5 6/8] drm/panel: Add ilitek ili9341 panel driver

2020-05-25 Thread Linus Walleij
On Mon, May 25, 2020 at 5:46 AM wrote: > From: dillon min > > This driver combine tiny/ili9341.c mipi_dbi_interface driver > with mipi_dpi_interface driver, can support ili9341 with serial > mode or parallel rgb interface mode by register configuration. > > Changes since V3: > >

Re: [PATCH v2 1/4] gpio: gpiolib: Allow GPIO IRQs to lazy disable

2020-05-25 Thread Hans Verkuil
On 25/05/2020 13:55, Linus Walleij wrote: > On Sat, May 23, 2020 at 7:11 PM Maulik Shah wrote: > >> With 'commit 461c1a7d4733 ("gpiolib: override irq_enable/disable")' gpiolib >> overrides irqchip's irq_enable and irq_disable callbacks. If irq_disable >> callback is implemented then genirq takes

Re: [PATCH v1] iommu/tegra-smmu: Add missing locks around mapping operations

2020-05-25 Thread Thierry Reding
On Mon, May 25, 2020 at 01:51:50PM +0300, Dmitry Osipenko wrote: > 25.05.2020 11:35, Thierry Reding пишет: > > On Sun, May 24, 2020 at 09:37:55PM +0300, Dmitry Osipenko wrote: > >> The mapping operations of the Tegra SMMU driver are subjected to a race > >> condition issues because SMMU Address

Re: [PATCH v5 4/8] dt-bindings: display: panel: Add ilitek ili9341 panel bindings

2020-05-25 Thread Linus Walleij
On Mon, May 25, 2020 at 5:46 AM wrote: > From: dillon min > > Add documentation for "ilitek,ili9341" panel. > > Signed-off-by: dillon min This looks good to me! Reviewed-by: Linus Walleij Yours, Linus Walleij

[PATCH v6 3/5] mtd: rawnand: Add write_oob hook in nand_chip_ops

2020-05-25 Thread Bean Huo
From: Bean Huo Break the function nand_write_oob() into two functions, and one of them is named nand_write_oob_nand(), which will be assigned to new added hook write_oob by default. The hook write_oob will be overwritten in the NAND vendor lower-level driver if needed. Signed-off-by: Miquel

[PATCH v6 1/5] mtd: rawnand: group all NAND specific ops into new nand_chip_ops

2020-05-25 Thread Bean Huo
From: Bean Huo This patch is to create a new structure nand_chip_ops, and take all NAND specific functions out from nand_chip and put them in this new structure. Signed-off-by: Bean Huo --- drivers/mtd/nand/raw/nand_base.c | 20 +- drivers/mtd/nand/raw/nand_hynix.c| 2

[PATCH v6 0/5] Micron SLC NAND filling block

2020-05-25 Thread Bean Huo
From: Bean Huo Hi, On planar 2D Micron NAND devices when a block erase command is issued, occasionally even though a block erase operation completes and returns a pass status, the flash block may not be completely erased. Subsequent operations to this block on very rare cases can result in

[PATCH v6 2/5] mtd: rawnand: Add {pre, post}_erase hooks in nand_chip_ops

2020-05-25 Thread Bean Huo
From: Bean Huo Add {pre,post}_erase hooks in the structure nand_chip_ops: pre_erase will be called before a block is physically erased. post_erase will be called after a block is erased. Signed-off-by: Bean Huo --- drivers/mtd/nand/raw/nand_base.c | 18 +-

[PATCH v6 5/5] mtd: rawnand: micron: Micron SLC NAND filling block

2020-05-25 Thread Bean Huo
From: Bean Huo On planar 2D Micron NAND devices when a block erase command is issued, occasionally even though a block erase operation completes and returns a pass status, the flash block may not be completely erased. Subsequent operations to this block on very rare cases can result in subtle

[PATCH v6 4/5] mtd: rawnand: Introduce a new function nand_check_is_erased_page()

2020-05-25 Thread Bean Huo
From: Bean Huo Add a new function nand_check_is_erased_page() in nand_base.c, which is used to check whether one programmable page is empty or already programmed. Signed-off-by: Bean Huo --- drivers/mtd/nand/raw/nand_base.c | 40 include/linux/mtd/rawnand.h

Re: [PATCH] gpiolib: add GPIO_SET_DEBOUNCE_IOCTL

2020-05-25 Thread Linus Walleij
On Mon, May 25, 2020 at 4:22 AM Kent Gibson wrote: > You mention timers for the gpio pins that cannot provide debounce, > so I'm confused. Could you clarify which strategy you have in mind? My idea is that the callback gpiod_set_debounce() for in-kernel consumers should more or less always

linux-next: build failure after merge of the akpm tree

2020-05-25 Thread Stephen Rothwell
Hi all, After merging the akpm tree, today's linux-next build (x86_64 allmodconfig) failed like this: In file included from include/linux/kernel.h:14, from mm/gup.c:2: mm/gup.c: In function 'internal_get_user_pages_fast': mm/gup.c:2732:33: error: 'struct mm_struct' has no member

Re: [Tee-dev] [PATCHv3 2/3] optee: use uuid for sysfs driver entry

2020-05-25 Thread Jerome Forissier
On 5/25/20 1:52 PM, Maxim Uvarov wrote: > Optee device names for sysfs needed to be unique s/Optee/OP-TEE/ s/needed/need/ > and it's better if they will mean something. UUID for name > looks like good solution: > /sys/bus/tee/devices/optee-clnt- How about mentioning it is the UUID of the

Re: [PATCH] iio: magnetometer: ak8974: Fix runtime PM imbalance on error

2020-05-25 Thread Linus Walleij
On Sun, May 24, 2020 at 4:51 AM Dinghao Liu wrote: > When devm_regmap_init_i2c() returns an error code, a pairing > runtime PM usage counter decrement is needed to keep the > counter balanced. For error paths after ak8974_set_power(), > ak8974_detect() and ak8974_reset(), things are the same. >

Re: [PATCH] arm: dts: am33xx-bone-common: add gpio-line-names

2020-05-25 Thread Drew Fustini
On Mon, May 25, 2020 at 11:23:17AM +0200, Linus Walleij wrote: > On Thu, May 21, 2020 at 12:02 AM Drew Fustini wrote: > > > I've posted a v2 which I hope improves the intent of the line names. [0] > > > > I'm happy to integrate any feedback and create a v3 - especially if it > > is prefered for

Re: [RFC 00/14] perf tests: Check on subtest for user specified test

2020-05-25 Thread Michael Petlan
On Mon, 25 May 2020, Jiri Olsa wrote: > hi, > changes for using metric result in another metric seem > to change lot of core metric code, so it's better we > have some more tests before we do that. > > Sending as RFC as it's still alive and you guys might > have some other idea of how to do this.

Re: [PATCH] ASoC: img: Complete exception handling in img_i2s_in_probe()

2020-05-25 Thread Markus Elfring
> Function "pm_runtime_get_sync()" is not handled by "pm_runtime_put()" > if "PTR_ERR(rst) == -EPROBE_DEFER". Fix this issue by adding > "pm_runtime_put()" into this error path. * I suggest to improve this change description. * An other subject can be more appropriate for the final commit.

Re: [PATCH 0/3] STMFX power related fixes

2020-05-25 Thread Amelie DELAUNAY
Hi, Gentle reminder regarding this series sent one month ago. Regards, Amelie On 4/22/20 11:08 AM, Amelie Delaunay wrote: With suspend/resume tests on STM32MP157C-EV1 board, on which STMFX is used by several devices, some errors could occurred: -6 when trying to restore STMFX registers,

Re: [RESEND PATCH v7 4/5] ndctl/papr_scm, uapi: Add support for PAPR nvdimm specific methods

2020-05-25 Thread Vaibhav Jain
Hi Ira, Mpe and Aneesh, Vaibhav Jain writes: > Michael Ellerman writes: > >> Ira Weiny writes: >>> On Wed, May 20, 2020 at 12:30:57AM +0530, Vaibhav Jain wrote: Introduce support for Papr nvDimm Specific Methods (PDSM) in papr_scm modules and add the command family to the white list

Re: [PATCH 5/5] crypto: stm32/crc: protect from concurrent accesses

2020-05-25 Thread Ard Biesheuvel
On Mon, 25 May 2020 at 13:49, Nicolas TOROMANOFF wrote: > > > -Original Message- > > From: Ard Biesheuvel > > Sent: Monday, May 25, 2020 11:07 AM > > To: Nicolas TOROMANOFF ; Eric Biggers > > > > On Mon, 25 May 2020 at 11:01, Nicolas TOROMANOFF > > wrote: > > > > > > > -Original

Re: [PATCH 2/6] arm64: dts: qcom: sm8250: add apps_smmu node

2020-05-25 Thread Sai Prakash Ranjan
On 2020-05-25 17:23, Jonathan Marek wrote: On 5/25/20 7:40 AM, Sai Prakash Ranjan wrote: On 2020-05-25 16:57, Jonathan Marek wrote: On 5/25/20 7:17 AM, Sai Prakash Ranjan wrote: Hi, On 2020-05-25 16:38, Jonathan Marek wrote: On 5/25/20 6:54 AM, Sai Prakash Ranjan wrote: On 2020-05-25

Re: [PATCH v2 1/4] gpio: gpiolib: Allow GPIO IRQs to lazy disable

2020-05-25 Thread Linus Walleij
On Sat, May 23, 2020 at 7:11 PM Maulik Shah wrote: > With 'commit 461c1a7d4733 ("gpiolib: override irq_enable/disable")' gpiolib > overrides irqchip's irq_enable and irq_disable callbacks. If irq_disable > callback is implemented then genirq takes unlazy path to disable irq. > > Underlying

Re: linux-next: Fixes tag needs some work in the iommu tree

2020-05-25 Thread Joerg Roedel
On Wed, May 20, 2020 at 04:36:31AM +1000, Stephen Rothwell wrote: > Maybe you meant > > Fixes: b0d1f8741b81 ("iommu/vt-d: Add nested translation helper function") > Fixes: 56722a4398a3 ("iommu/vt-d: Add bind guest PASID support") Updated, thanks.

[PATCH v2 3/3] iio: remove iio_triggered_buffer_postenable()/iio_triggered_buffer_predisable()

2020-05-25 Thread Alexandru Ardelean
From: Lars-Peter Clausen This patch should be squashed into the first one, as the first one is breaking the build (intentionally) to make the IIO core files easier to review. Signed-off-by: Lars-Peter Clausen Signed-off-by: Alexandru Ardelean --- drivers/iio/accel/adxl372.c |

Re: linux-next: build failure after merge of the nand tree

2020-05-25 Thread Miquel Raynal
Hi Stephen, Stephen Rothwell wrote on Mon, 25 May 2020 20:45:35 +1000: > Hi all, > > After merging the nand tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/mtd/nand/raw/pasemi_nand.c: In function 'pasemi_nand_probe': >

[PATCH v2 1/3] iio: Move attach/detach of the poll func to the core

2020-05-25 Thread Alexandru Ardelean
From: Lars-Peter Clausen All devices using a triggered buffer need to attach and detach the trigger to the device in order to properly work. Instead of doing this in each and every driver by hand move this into the core. At this point in time, all drivers should have been resolved to

[PATCH v2 2/3] iio: adc: at91-sama5d2_adc: remove predisable/postenable hooks

2020-05-25 Thread Alexandru Ardelean
This should be squashed into the first patch, but it's the more peculiar of the changes. I am not sure whether this is correct. The touchscreen channels shouldn't be enabled by the IIO framework. So, we may need a different way to handle those if needed. Signed-off-by: Alexandru Ardelean ---

[PATCHv3 1/3] optee: do drivers initialization before and after tee-supplicant run

2020-05-25 Thread Maxim Uvarov
Some drivers (like ftpm) can operate only after tee-supplicant runs becase of tee-supplicant provides things like storage services. This patch splits probe of non tee-supplicant dependable drivers to early stage, and after tee-supplicant run probe other drivers. Signed-off-by: Maxim Uvarov

[PATCHv3 2/3] optee: use uuid for sysfs driver entry

2020-05-25 Thread Maxim Uvarov
Optee device names for sysfs needed to be unique and it's better if they will mean something. UUID for name looks like good solution: /sys/bus/tee/devices/optee-clnt- Signed-off-by: Maxim Uvarov --- drivers/tee/optee/device.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

Re: [PATCH -next] iommu/vt-d: fix a GCC warning

2020-05-25 Thread Joerg Roedel
On Thu, May 21, 2020 at 05:50:30PM -0400, Qian Cai wrote: > The commit 6ee1b77ba3ac ("iommu/vt-d: Add svm/sva invalidate function") > introduced a GCC warning, > > drivers/iommu/intel-iommu.c:5330:1: warning: 'static' is not at beginning of > declaration [-Wold-style-declaration] > const static

[PATCHv3 3/3] tpm_ftpm_tee: register driver on TEE bus

2020-05-25 Thread Maxim Uvarov
Register driver on the TEE bus. The :module tee registers bus, and module optee calls optee_enumerate_devices() to scan all devices on the bus. Trusted Application for this driver can be Early TA's (can be compiled into optee-os). In that case it will be on OPTEE bus before linux booting. Also

Re: [PATCH 2/6] arm64: dts: qcom: sm8250: add apps_smmu node

2020-05-25 Thread Jonathan Marek
On 5/25/20 7:40 AM, Sai Prakash Ranjan wrote: On 2020-05-25 16:57, Jonathan Marek wrote: On 5/25/20 7:17 AM, Sai Prakash Ranjan wrote: Hi, On 2020-05-25 16:38, Jonathan Marek wrote: On 5/25/20 6:54 AM, Sai Prakash Ranjan wrote: On 2020-05-25 15:39, Jonathan Marek wrote: Hi, On 5/25/20

[PATCHv3 0/3] optee: register drivers on optee bus

2020-05-25 Thread Maxim Uvarov
v3: - support tee-suppicant restart (Jens Wiklander) - description and comments ( Jarkko Sakkinen) - do not name optee drivers by index in sysfs (Sumit Garg) v2: - write TEE with capital letters. - declare __optee_enumerate_device() as static. Hello, This patchset fixes issues with

Re: next/master bisection: baseline.login on panda

2020-05-25 Thread Joerg Roedel
Hi Guillaume, On Wed, May 20, 2020 at 10:54:44AM +0100, Guillaume Tucker wrote: > Please see the bisection report below about a boot failure. > > Reports aren't automatically sent to the public while we're > trialing new bisection features on kernelci.org but this one > looks valid. > >

[PATCH 3/4] exfat: add boot region verification

2020-05-25 Thread Tetsuhiro Kohada
Add Boot-Regions verification specified in exFAT specification. Note that the checksum type is strongly related to the raw structure, so the'u32 'type is used to clarify the number of bits. Signed-off-by: Tetsuhiro Kohada --- fs/exfat/exfat_fs.h | 1 + fs/exfat/misc.c | 14 +

<    1   2   3   4   5   6   7   8   9   10   >