Re: [PATCH] FS: BTRFS: ulist.c: Fixed a brace coding style and space before tab

2020-05-25 Thread David Sterba
On Fri, May 22, 2020 at 05:29:02PM -0400, Ethan Edwards wrote: > From: Ethan Edwards > Fixed coding style No thanks. Long answer: https://btrfs.wiki.kernel.org/index.php/Developer%27s_FAQ#How_not_to_start

Re: [PATCH 2/2] phy: Remove CONFIG_ARCH_ROCKCHIP check for subdir rockchip

2020-05-25 Thread Tiezhu Yang
On 05/25/2020 06:48 PM, Heiko Stübner wrote: Am Montag, 25. Mai 2020, 06:08:59 CEST schrieb Tiezhu Yang: If CONFIG_ARCH_ROCKCHIP is not set but COMPILE_TEST is set, the file in the subdir rockchip can not be built due to CONFIG_ARCH_ROCKCHIP check in drivers/phy/Makefile. Since the related conf

Re: [RFC 00/14] perf tests: Check on subtest for user specified test

2020-05-25 Thread Jiri Olsa
On Mon, May 25, 2020 at 02:06:07PM +0200, Michael Petlan wrote: > On Mon, 25 May 2020, Jiri Olsa wrote: > > hi, > > changes for using metric result in another metric seem > > to change lot of core metric code, so it's better we > > have some more tests before we do that. > > > > Sending as RFC as

Re: block I/O accounting improvements

2020-05-25 Thread Konstantin Khlebnikov
On 25/05/2020 14.29, Christoph Hellwig wrote: Hi Jens, they series contains various improvement for block I/O accounting. The first bunch of patches switch the bio based drivers to better accounting helpers compared to the current mess. The end contains a fix and various performanc improvement

Re: [PATCH] i2c: core: fix NULL pointer dereference in suspend/resume callbacks

2020-05-25 Thread Tomasz Figa
Hi Marek, On Fri, May 22, 2020 at 1:15 PM Marek Szyprowski wrote: > > Hi All, > > On 22.05.2020 12:13, Marek Szyprowski wrote: > > Commit 6fe12cdbcfe3 ("i2c: core: support bus regulator controlling in > > adapter") added generic suspend and resume functions for i2c devices. > > Those functions un

Re: [PATCH 01/16] block: add disk/bio-based accounting helpers

2020-05-25 Thread Konstantin Khlebnikov
On 25/05/2020 14.29, Christoph Hellwig wrote: Add two new helpers to simplify I/O accounting for bio based drivers. Currently these drivers use the generic_start_io_acct and generic_end_io_acct helpers which have very cumbersome calling conventions, don't actually return the time they started acc

[PATCH v2] e1000: use generic power management

2020-05-25 Thread Vaibhav Gupta
compile-tested only With legacy PM hooks, it was the responsibility of a driver to manage PCI states and also the device's power state. The generic approach is to let PCI core handle the work. e1000_suspend() calls __e1000_shutdown() to perform intermediate tasks. __e1000_shutdown() modifies the

Re: [PATCH v3 3/3] vfio-pci: Invalidate mmaps and block MMIO access on disabled memory

2020-05-25 Thread Jason Gunthorpe
On Sat, May 23, 2020 at 07:52:57PM -0400, Peter Xu wrote: > For what I understand now, IMHO we should still need all those handlings of > FAULT_FLAG_RETRY_NOWAIT like in the initial version. E.g., IIUC KVM gup will > try with FOLL_NOWAIT when async is allowed, before the complete slow path. > I

Re: [PATCH v5 6/8] drm/panel: Add ilitek ili9341 panel driver

2020-05-25 Thread Linus Walleij
On Mon, May 25, 2020 at 5:46 AM wrote: > From: dillon min > > This driver combine tiny/ili9341.c mipi_dbi_interface driver > with mipi_dpi_interface driver, can support ili9341 with serial > mode or parallel rgb interface mode by register configuration. > > Changes since V3: > >

Re: [PATCH v2 1/4] gpio: gpiolib: Allow GPIO IRQs to lazy disable

2020-05-25 Thread Hans Verkuil
On 25/05/2020 13:55, Linus Walleij wrote: > On Sat, May 23, 2020 at 7:11 PM Maulik Shah wrote: > >> With 'commit 461c1a7d4733 ("gpiolib: override irq_enable/disable")' gpiolib >> overrides irqchip's irq_enable and irq_disable callbacks. If irq_disable >> callback is implemented then genirq takes

Re: [PATCH v1] iommu/tegra-smmu: Add missing locks around mapping operations

2020-05-25 Thread Thierry Reding
On Mon, May 25, 2020 at 01:51:50PM +0300, Dmitry Osipenko wrote: > 25.05.2020 11:35, Thierry Reding пишет: > > On Sun, May 24, 2020 at 09:37:55PM +0300, Dmitry Osipenko wrote: > >> The mapping operations of the Tegra SMMU driver are subjected to a race > >> condition issues because SMMU Address Spa

Re: [PATCH v5 4/8] dt-bindings: display: panel: Add ilitek ili9341 panel bindings

2020-05-25 Thread Linus Walleij
On Mon, May 25, 2020 at 5:46 AM wrote: > From: dillon min > > Add documentation for "ilitek,ili9341" panel. > > Signed-off-by: dillon min This looks good to me! Reviewed-by: Linus Walleij Yours, Linus Walleij

[PATCH v6 3/5] mtd: rawnand: Add write_oob hook in nand_chip_ops

2020-05-25 Thread Bean Huo
From: Bean Huo Break the function nand_write_oob() into two functions, and one of them is named nand_write_oob_nand(), which will be assigned to new added hook write_oob by default. The hook write_oob will be overwritten in the NAND vendor lower-level driver if needed. Signed-off-by: Miquel Rayn

[PATCH v6 1/5] mtd: rawnand: group all NAND specific ops into new nand_chip_ops

2020-05-25 Thread Bean Huo
From: Bean Huo This patch is to create a new structure nand_chip_ops, and take all NAND specific functions out from nand_chip and put them in this new structure. Signed-off-by: Bean Huo --- drivers/mtd/nand/raw/nand_base.c | 20 +- drivers/mtd/nand/raw/nand_hynix.c| 2

[PATCH v6 0/5] Micron SLC NAND filling block

2020-05-25 Thread Bean Huo
From: Bean Huo Hi, On planar 2D Micron NAND devices when a block erase command is issued, occasionally even though a block erase operation completes and returns a pass status, the flash block may not be completely erased. Subsequent operations to this block on very rare cases can result in subtle

[PATCH v6 2/5] mtd: rawnand: Add {pre, post}_erase hooks in nand_chip_ops

2020-05-25 Thread Bean Huo
From: Bean Huo Add {pre,post}_erase hooks in the structure nand_chip_ops: pre_erase will be called before a block is physically erased. post_erase will be called after a block is erased. Signed-off-by: Bean Huo --- drivers/mtd/nand/raw/nand_base.c | 18 +- include/linux/mtd/raw

[PATCH v6 5/5] mtd: rawnand: micron: Micron SLC NAND filling block

2020-05-25 Thread Bean Huo
From: Bean Huo On planar 2D Micron NAND devices when a block erase command is issued, occasionally even though a block erase operation completes and returns a pass status, the flash block may not be completely erased. Subsequent operations to this block on very rare cases can result in subtle fai

[PATCH v6 4/5] mtd: rawnand: Introduce a new function nand_check_is_erased_page()

2020-05-25 Thread Bean Huo
From: Bean Huo Add a new function nand_check_is_erased_page() in nand_base.c, which is used to check whether one programmable page is empty or already programmed. Signed-off-by: Bean Huo --- drivers/mtd/nand/raw/nand_base.c | 40 include/linux/mtd/rawnand.h

Re: [PATCH] gpiolib: add GPIO_SET_DEBOUNCE_IOCTL

2020-05-25 Thread Linus Walleij
On Mon, May 25, 2020 at 4:22 AM Kent Gibson wrote: > You mention timers for the gpio pins that cannot provide debounce, > so I'm confused. Could you clarify which strategy you have in mind? My idea is that the callback gpiod_set_debounce() for in-kernel consumers should more or less always retur

linux-next: build failure after merge of the akpm tree

2020-05-25 Thread Stephen Rothwell
Hi all, After merging the akpm tree, today's linux-next build (x86_64 allmodconfig) failed like this: In file included from include/linux/kernel.h:14, from mm/gup.c:2: mm/gup.c: In function 'internal_get_user_pages_fast': mm/gup.c:2732:33: error: 'struct mm_struct' has no member

Re: [Tee-dev] [PATCHv3 2/3] optee: use uuid for sysfs driver entry

2020-05-25 Thread Jerome Forissier
On 5/25/20 1:52 PM, Maxim Uvarov wrote: > Optee device names for sysfs needed to be unique s/Optee/OP-TEE/ s/needed/need/ > and it's better if they will mean something. UUID for name > looks like good solution: > /sys/bus/tee/devices/optee-clnt- How about mentioning it is the UUID of the Trus

Re: [PATCH] iio: magnetometer: ak8974: Fix runtime PM imbalance on error

2020-05-25 Thread Linus Walleij
On Sun, May 24, 2020 at 4:51 AM Dinghao Liu wrote: > When devm_regmap_init_i2c() returns an error code, a pairing > runtime PM usage counter decrement is needed to keep the > counter balanced. For error paths after ak8974_set_power(), > ak8974_detect() and ak8974_reset(), things are the same. > >

Re: [PATCH] arm: dts: am33xx-bone-common: add gpio-line-names

2020-05-25 Thread Drew Fustini
On Mon, May 25, 2020 at 11:23:17AM +0200, Linus Walleij wrote: > On Thu, May 21, 2020 at 12:02 AM Drew Fustini wrote: > > > I've posted a v2 which I hope improves the intent of the line names. [0] > > > > I'm happy to integrate any feedback and create a v3 - especially if it > > is prefered for m

Re: [RFC 00/14] perf tests: Check on subtest for user specified test

2020-05-25 Thread Michael Petlan
On Mon, 25 May 2020, Jiri Olsa wrote: > hi, > changes for using metric result in another metric seem > to change lot of core metric code, so it's better we > have some more tests before we do that. > > Sending as RFC as it's still alive and you guys might > have some other idea of how to do this.

Re: [PATCH] ASoC: img: Complete exception handling in img_i2s_in_probe()

2020-05-25 Thread Markus Elfring
> Function "pm_runtime_get_sync()" is not handled by "pm_runtime_put()" > if "PTR_ERR(rst) == -EPROBE_DEFER". Fix this issue by adding > "pm_runtime_put()" into this error path. * I suggest to improve this change description. * An other subject can be more appropriate for the final commit. Regar

Re: [PATCH 0/3] STMFX power related fixes

2020-05-25 Thread Amelie DELAUNAY
Hi, Gentle reminder regarding this series sent one month ago. Regards, Amelie On 4/22/20 11:08 AM, Amelie Delaunay wrote: With suspend/resume tests on STM32MP157C-EV1 board, on which STMFX is used by several devices, some errors could occurred: -6 when trying to restore STMFX registers, spurio

Re: [RESEND PATCH v7 4/5] ndctl/papr_scm, uapi: Add support for PAPR nvdimm specific methods

2020-05-25 Thread Vaibhav Jain
Hi Ira, Mpe and Aneesh, Vaibhav Jain writes: > Michael Ellerman writes: > >> Ira Weiny writes: >>> On Wed, May 20, 2020 at 12:30:57AM +0530, Vaibhav Jain wrote: Introduce support for Papr nvDimm Specific Methods (PDSM) in papr_scm modules and add the command family to the white list

Re: [PATCH 5/5] crypto: stm32/crc: protect from concurrent accesses

2020-05-25 Thread Ard Biesheuvel
On Mon, 25 May 2020 at 13:49, Nicolas TOROMANOFF wrote: > > > -Original Message- > > From: Ard Biesheuvel > > Sent: Monday, May 25, 2020 11:07 AM > > To: Nicolas TOROMANOFF ; Eric Biggers > > > > On Mon, 25 May 2020 at 11:01, Nicolas TOROMANOFF > > wrote: > > > > > > > -Original Mes

Re: [PATCH 2/6] arm64: dts: qcom: sm8250: add apps_smmu node

2020-05-25 Thread Sai Prakash Ranjan
On 2020-05-25 17:23, Jonathan Marek wrote: On 5/25/20 7:40 AM, Sai Prakash Ranjan wrote: On 2020-05-25 16:57, Jonathan Marek wrote: On 5/25/20 7:17 AM, Sai Prakash Ranjan wrote: Hi, On 2020-05-25 16:38, Jonathan Marek wrote: On 5/25/20 6:54 AM, Sai Prakash Ranjan wrote: On 2020-05-25 15:39,

Re: [PATCH v2 1/4] gpio: gpiolib: Allow GPIO IRQs to lazy disable

2020-05-25 Thread Linus Walleij
On Sat, May 23, 2020 at 7:11 PM Maulik Shah wrote: > With 'commit 461c1a7d4733 ("gpiolib: override irq_enable/disable")' gpiolib > overrides irqchip's irq_enable and irq_disable callbacks. If irq_disable > callback is implemented then genirq takes unlazy path to disable irq. > > Underlying irqchi

Re: linux-next: Fixes tag needs some work in the iommu tree

2020-05-25 Thread Joerg Roedel
On Wed, May 20, 2020 at 04:36:31AM +1000, Stephen Rothwell wrote: > Maybe you meant > > Fixes: b0d1f8741b81 ("iommu/vt-d: Add nested translation helper function") > Fixes: 56722a4398a3 ("iommu/vt-d: Add bind guest PASID support") Updated, thanks.

[PATCH v2 3/3] iio: remove iio_triggered_buffer_postenable()/iio_triggered_buffer_predisable()

2020-05-25 Thread Alexandru Ardelean
From: Lars-Peter Clausen This patch should be squashed into the first one, as the first one is breaking the build (intentionally) to make the IIO core files easier to review. Signed-off-by: Lars-Peter Clausen Signed-off-by: Alexandru Ardelean --- drivers/iio/accel/adxl372.c |

Re: linux-next: build failure after merge of the nand tree

2020-05-25 Thread Miquel Raynal
Hi Stephen, Stephen Rothwell wrote on Mon, 25 May 2020 20:45:35 +1000: > Hi all, > > After merging the nand tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/mtd/nand/raw/pasemi_nand.c: In function 'pasemi_nand_probe': > drivers/mtd/nand/raw/pasemi_nand.c:15

[PATCH v2 1/3] iio: Move attach/detach of the poll func to the core

2020-05-25 Thread Alexandru Ardelean
From: Lars-Peter Clausen All devices using a triggered buffer need to attach and detach the trigger to the device in order to properly work. Instead of doing this in each and every driver by hand move this into the core. At this point in time, all drivers should have been resolved to attach/deta

[PATCH v2 2/3] iio: adc: at91-sama5d2_adc: remove predisable/postenable hooks

2020-05-25 Thread Alexandru Ardelean
This should be squashed into the first patch, but it's the more peculiar of the changes. I am not sure whether this is correct. The touchscreen channels shouldn't be enabled by the IIO framework. So, we may need a different way to handle those if needed. Signed-off-by: Alexandru Ardelean --- dri

[PATCHv3 1/3] optee: do drivers initialization before and after tee-supplicant run

2020-05-25 Thread Maxim Uvarov
Some drivers (like ftpm) can operate only after tee-supplicant runs becase of tee-supplicant provides things like storage services. This patch splits probe of non tee-supplicant dependable drivers to early stage, and after tee-supplicant run probe other drivers. Signed-off-by: Maxim Uvarov Sugge

[PATCHv3 2/3] optee: use uuid for sysfs driver entry

2020-05-25 Thread Maxim Uvarov
Optee device names for sysfs needed to be unique and it's better if they will mean something. UUID for name looks like good solution: /sys/bus/tee/devices/optee-clnt- Signed-off-by: Maxim Uvarov --- drivers/tee/optee/device.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --gi

Re: [PATCH -next] iommu/vt-d: fix a GCC warning

2020-05-25 Thread Joerg Roedel
On Thu, May 21, 2020 at 05:50:30PM -0400, Qian Cai wrote: > The commit 6ee1b77ba3ac ("iommu/vt-d: Add svm/sva invalidate function") > introduced a GCC warning, > > drivers/iommu/intel-iommu.c:5330:1: warning: 'static' is not at beginning of > declaration [-Wold-style-declaration] > const static i

[PATCHv3 3/3] tpm_ftpm_tee: register driver on TEE bus

2020-05-25 Thread Maxim Uvarov
Register driver on the TEE bus. The :module tee registers bus, and module optee calls optee_enumerate_devices() to scan all devices on the bus. Trusted Application for this driver can be Early TA's (can be compiled into optee-os). In that case it will be on OPTEE bus before linux booting. Also opte

Re: [PATCH 2/6] arm64: dts: qcom: sm8250: add apps_smmu node

2020-05-25 Thread Jonathan Marek
On 5/25/20 7:40 AM, Sai Prakash Ranjan wrote: On 2020-05-25 16:57, Jonathan Marek wrote: On 5/25/20 7:17 AM, Sai Prakash Ranjan wrote: Hi, On 2020-05-25 16:38, Jonathan Marek wrote: On 5/25/20 6:54 AM, Sai Prakash Ranjan wrote: On 2020-05-25 15:39, Jonathan Marek wrote: Hi, On 5/25/20 5:42

[PATCHv3 0/3] optee: register drivers on optee bus

2020-05-25 Thread Maxim Uvarov
v3: - support tee-suppicant restart (Jens Wiklander) - description and comments ( Jarkko Sakkinen) - do not name optee drivers by index in sysfs (Sumit Garg) v2: - write TEE with capital letters. - declare __optee_enumerate_device() as static. Hello, This patchset fixes issues with pr

Re: next/master bisection: baseline.login on panda

2020-05-25 Thread Joerg Roedel
Hi Guillaume, On Wed, May 20, 2020 at 10:54:44AM +0100, Guillaume Tucker wrote: > Please see the bisection report below about a boot failure. > > Reports aren't automatically sent to the public while we're > trialing new bisection features on kernelci.org but this one > looks valid. > > Unfortun

[PATCH 3/4] exfat: add boot region verification

2020-05-25 Thread Tetsuhiro Kohada
Add Boot-Regions verification specified in exFAT specification. Note that the checksum type is strongly related to the raw structure, so the'u32 'type is used to clarify the number of bits. Signed-off-by: Tetsuhiro Kohada --- fs/exfat/exfat_fs.h | 1 + fs/exfat/misc.c | 14 + fs

[PATCH 2/4] exfat: separate the boot sector analysis

2020-05-25 Thread Tetsuhiro Kohada
Separate the boot sector analysis to read_boot_sector(). Furthermore, add a strict consistency check, because overlapping areas can cause serious corruption. Signed-off-by: Tetsuhiro Kohada --- fs/exfat/exfat_raw.h | 1 + fs/exfat/super.c | 96 +++- 2

[PATCH 4/4] exfat: standardize checksum calculation

2020-05-25 Thread Tetsuhiro Kohada
To clarify that it is a 16-bit checksum, the parts related to the 16-bit checksum are renamed and change type to u16. Furthermore, replace checksum calculation in exfat_load_upcase_table() with exfat_calc_checksum32(). Signed-off-by: Tetsuhiro Kohada --- fs/exfat/dir.c | 12 ++-- fs

[PATCH 1/4] exfat: redefine PBR as boot_sector

2020-05-25 Thread Tetsuhiro Kohada
Aggregate PBR related definitions and redefine as "boot_sector" to comply with the exFAT specification. And, rename variable names including 'pbr'. Signed-off-by: Tetsuhiro Kohada --- fs/exfat/exfat_fs.h | 2 +- fs/exfat/exfat_raw.h | 79 +++-- fs/exfat/supe

RE: [PATCH 5/5] crypto: stm32/crc: protect from concurrent accesses

2020-05-25 Thread Nicolas TOROMANOFF
> -Original Message- > From: Ard Biesheuvel > Sent: Monday, May 25, 2020 11:07 AM > To: Nicolas TOROMANOFF ; Eric Biggers > > On Mon, 25 May 2020 at 11:01, Nicolas TOROMANOFF > wrote: > > > > > -Original Message- > > > From: Ard Biesheuvel > > > Sent: Monday, May 25, 2020 9:46 A

Re: [PATCH] media: rkvdec: Fix H264 scaling list order

2020-05-25 Thread Tomasz Figa
On Fri, May 22, 2020 at 10:21 PM Jonas Karlman wrote: > > The Rockchip Video Decoder driver is expecting that the values in a > scaling list are in zig-zag order and applies the inverse scanning process > to get the values in matrix order. > > Commit 0b0393d59eb4 ("media: uapi: h264: clarify expec

Re: [PATCH 5/8] soc: ux500: Switch to use DEVICE_ATTR_RO()

2020-05-25 Thread Linus Walleij
On Sat, May 23, 2020 at 7:09 PM Sudeep Holla wrote: > Move device attributes to DEVICE_ATTR_RO() as that would make things > a lot more "obvious" what is happening over the existing __ATTR usage. > > Cc: Linus Walleij > Signed-off-by: Sudeep Holla Reviewed-by: Linus Walleij Yours, Linus Wall

Re: [PATCH 6/8] soc: ux500: Use custom soc attribute group instead of device_create_file

2020-05-25 Thread Linus Walleij
On Sat, May 23, 2020 at 7:09 PM Sudeep Holla wrote: > Commit c31e73121f4c ("base: soc: Handle custom soc information sysfs > entries") introduced custom soc attribute group in soc_device_attribute > structure but there are no users treewide. While trying to understand > the motivation and tried t

Re: KVM broken after suspend in most recent kernels.

2020-05-25 Thread Maxim Levitsky
On Sun, 2020-05-24 at 18:43 +0800, Brad Campbell wrote: > > On 24/5/20 12:50 pm, Brad Campbell wrote: > > G'day all. > > > > Machine is a Macbook Pro Retina ~ 2014. Kernels are always vanilla kernel > > and compiled on the machine. No additional patches. > > > > vendor_id: GenuineIntel > >

Re: [PATCH 3/8] soc: integrator: Switch to use DEVICE_ATTR_RO()

2020-05-25 Thread Linus Walleij
On Sat, May 23, 2020 at 7:09 PM Sudeep Holla wrote: > Move device attributes to DEVICE_ATTR_RO() as that would make things > a lot more "obvious" what is happening over the existing __ATTR usage. > > Cc: Linus Walleij > Signed-off-by: Sudeep Holla Reviewed-by: Linus Walleij Yours, Linus Wall

Re: [PATCH 4/8] soc: integrator: Use custom soc attribute group instead of device_create_file

2020-05-25 Thread Linus Walleij
On Sat, May 23, 2020 at 7:09 PM Sudeep Holla wrote: > Commit c31e73121f4c ("base: soc: Handle custom soc information sysfs > entries") introduced custom soc attribute group in soc_device_attribute > structure but there are no users treewide. While trying to understand > the motivation and tried t

Re: [PATCH 1/8] soc: realview: Switch to use DEVICE_ATTR_RO()

2020-05-25 Thread Linus Walleij
On Sat, May 23, 2020 at 7:09 PM Sudeep Holla wrote: > Move device attributes to DEVICE_ATTR_RO() as that would make things > a lot more "obvious" what is happening over the existing __ATTR usage. > > Cc: Linus Walleij > Signed-off-by: Sudeep Holla Reviewed-by: Linus Walleij Yours, Linus Wall

Re: [PATCH 2/8] soc: realview: Use custom soc attribute group instead of device_create_file

2020-05-25 Thread Linus Walleij
On Sat, May 23, 2020 at 7:09 PM Sudeep Holla wrote: > Commit c31e73121f4c ("base: soc: Handle custom soc information sysfs > entries") introduced custom soc attribute group in soc_device_attribute > structure but there are no users treewide. While trying to understand > the motivation and tried t

Re: [PATCH v4 3/8] spi: stm32: Add 'SPI_SIMPLEX_RX', 'SPI_3WIRE_RX' support for stm32f4

2020-05-25 Thread Mark Brown
On Sat, May 23, 2020 at 09:35:06AM +0800, dillon min wrote: > - if (ctlr->flags & (SPI_CONTROLLER_MUST_RX | SPI_CONTROLLER_MUST_TX)) { > + if ((ctlr->flags & (SPI_CONTROLLER_MUST_RX | SPI_CONTROLLER_MUST_TX)) > && > + !(msg->spi->mode & SPI_3WIRE)) { > ma

Re: [PATCH v2 2/2] i2c: busses: convert to devm_platform_request_irq()

2020-05-25 Thread Linus Walleij
On Sat, May 23, 2020 at 4:52 PM Dejin Zheng wrote: > Use devm_platform_request_irq() to simplify code, and it contains > platform_get_irq() and devm_request_irq(). > > I resend this patch by that discussion. > https://patchwork.ozlabs.org/project/linux-i2c/patch/20200520144821.8069-1-zhengdej...@

Re: [PATCH 2/2] pinctrl: at91-pio4: Add COMPILE_TEST support

2020-05-25 Thread Linus Walleij
On Sat, May 23, 2020 at 1:45 PM Tiezhu Yang wrote: > Add COMPILE_TEST support to the AT91 PIO4 pinctrl driver for better compile > testing coverage. > > Signed-off-by: Tiezhu Yang Patch applied, if there is some compile error we will notice shorty :D Yours, Linus Walleij

Re: [PATCH 1/2] pinctrl: Fix return value about devm_platform_ioremap_resource()

2020-05-25 Thread Linus Walleij
On Sat, May 23, 2020 at 1:45 PM Tiezhu Yang wrote: > When call function devm_platform_ioremap_resource(), we should use IS_ERR() > to check the return value and return PTR_ERR() if failed. > > Fixes: 4b024225c4a8 ("pinctrl: use devm_platform_ioremap_resource() to > simplify code") > Signed-off-b

Re: [PATCH v4 01/16] spi: dw: Add Tx/Rx finish wait methods to the MID DMA

2020-05-25 Thread Mark Brown
On Sat, May 23, 2020 at 11:34:10AM +0300, Serge Semin wrote: > On Fri, May 22, 2020 at 04:22:41PM +0100, Mark Brown wrote: > > Right, that definitely needs to be fixed then - 8MHz is indeed a totally > > normal clock rate for SPI so people will hit it. I guess if there's a > > noticable performan

Re: [PATCH 2/6] arm64: dts: qcom: sm8250: add apps_smmu node

2020-05-25 Thread Sai Prakash Ranjan
On 2020-05-25 16:57, Jonathan Marek wrote: On 5/25/20 7:17 AM, Sai Prakash Ranjan wrote: Hi, On 2020-05-25 16:38, Jonathan Marek wrote: On 5/25/20 6:54 AM, Sai Prakash Ranjan wrote: On 2020-05-25 15:39, Jonathan Marek wrote: Hi, On 5/25/20 5:42 AM, Sai Prakash Ranjan wrote: Hi Jonathan, O

Re: [PATCH 0/4] irqchip: qcom: pdc: Introduce irq_set_wake call

2020-05-25 Thread Linus Walleij
On Fri, May 22, 2020 at 3:20 PM Maulik Shah wrote: > pinctrl: qcom: Remove irq_disable callback from msmgpio irqchip > pinctrl: qcom: Add msmgpio irqchip flags For these two: Acked-by: Linus Walleij so the irqchip maintainers can merge them. But you ideally also need Björn's ACKs. Yours,

[PATCH 08/16] zram: nvdimm: use bio_{start,end}_io_acct and disk_{start,end}_io_acct

2020-05-25 Thread Christoph Hellwig
Switch zram to use the nicer bio accounting helpers, and as part of that ensure each bio is counted as a single I/O request. Signed-off-by: Christoph Hellwig --- drivers/block/zram/zram_drv.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/b

[RFC] power: supply: bq27xxx_battery: Fix polling interval after re-bind

2020-05-25 Thread Krzysztof Kozlowski
This reverts commit 8cfaaa811894a3ae2d7360a15a6cfccff3ebc7db. If device was unbound and bound, the polling interval would be set to 0. This is both unexpected and messes up with other bq27xxx devices (if more than one battery device is used). This reset of polling interval was added in commit 8cf

Re: [PATCH 3/3] iio: remove iio_triggered_buffer_postenable()/iio_triggered_buffer_predisable()

2020-05-25 Thread Ardelean, Alexandru
On Sun, 2020-05-24 at 14:38 +0100, Jonathan Cameron wrote: > [External] > > On Fri, 22 May 2020 13:46:32 +0300 > Alexandru Ardelean wrote: > > > From: Lars-Peter Clausen > > > > This patch should be squashed into the first one, as the first one is > > breaking the build (intentionally) to make

[PATCH 03/16] rsxx: use bio_{start,end}_io_acct

2020-05-25 Thread Christoph Hellwig
Switch rsxx to use the nicer bio accounting helpers. Signed-off-by: Christoph Hellwig --- drivers/block/rsxx/dev.c | 19 ++- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/drivers/block/rsxx/dev.c b/drivers/block/rsxx/dev.c index 8ffa8260dcafe..3ba07ab30c84f 10064

Re: [PATCH v3] driver core: Fix SYNC_STATE_ONLY device link implementation

2020-05-25 Thread Michael Walle
Am 2020-05-23 00:47, schrieb Michael Walle: Am 2020-05-23 00:21, schrieb Saravana Kannan: On Fri, May 22, 2020 at 11:41 AM Michael Walle wrote: Am Mon, 18 May 2020 23:30:00 -0700 schrieb Saravana Kannan : > When SYNC_STATE_ONLY support was added in commit 05ef983e0d65 ("driver > core: Add de

[PATCH 07/16] nvdimm: use bio_{start,end}_io_acct

2020-05-25 Thread Christoph Hellwig
Switch dm to use the nicer bio accounting helpers. Signed-off-by: Christoph Hellwig --- drivers/nvdimm/blk.c | 6 -- drivers/nvdimm/btt.c | 6 -- drivers/nvdimm/nd.h | 19 --- drivers/nvdimm/pmem.c | 6 -- 4 files changed, 12 insertions(+), 25 deletions(-) dif

[PATCH 14/16] block: remove rcu_read_lock() from part_stat_lock()

2020-05-25 Thread Christoph Hellwig
From: Konstantin Khlebnikov The RCU lock is required only in disk_map_sector_rcu() to lookup the partition. After that request holds reference to related hd_struct. Replace get_cpu() with preempt_disable() - returned cpu index is unused. Signed-off-by: Konstantin Khlebnikov [hch: rebased] Sig

[PATCH 09/16] block: remove generic_{start,end}_io_acct

2020-05-25 Thread Christoph Hellwig
Remove these now unused functions. Signed-off-by: Christoph Hellwig --- block/bio.c | 39 --- include/linux/bio.h | 6 -- 2 files changed, 45 deletions(-) diff --git a/block/bio.c b/block/bio.c index 9c101a0572ca2..3e89c7b37855a 100644 --- a/bloc

[PATCH 16/16] block: reduce part_stat_lock() scope

2020-05-25 Thread Christoph Hellwig
We only need the stats lock (aka preempt_disable()) for updating the states, not for looking up or dropping the hd_struct reference. Signed-off-by: Christoph Hellwig --- block/blk-core.c | 5 +++-- block/blk-merge.c | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/block/b

[PATCH 13/16] block: add a blk_account_io_merge_bio helper

2020-05-25 Thread Christoph Hellwig
From: Konstantin Khlebnikov Move the non-"new_io" branch of blk_account_io_start() into separate function. Fix merge accounting for discards (they were counted as write merges). The new blk_account_io_merge_bio() doesn't call update_io_ticks() unlike blk_account_io_start(), as there is no reaso

[PATCH 10/16] block: move update_io_ticks to blk-core.c

2020-05-25 Thread Christoph Hellwig
All callers are in blk-core.c, so move update_io_ticks over. Signed-off-by: Christoph Hellwig --- block/bio.c | 16 block/blk-core.c | 15 +++ block/blk.h | 1 - 3 files changed, 15 insertions(+), 17 deletions(-) diff --git a/block/bio.c b/block/bio.c ind

[PATCH 15/16] block: use __this_cpu_add() instead of access by smp_processor_id()

2020-05-25 Thread Christoph Hellwig
From: Konstantin Khlebnikov Most architectures have fast path to access percpu for current cpu. The required preempt_disable() is provided by part_stat_lock(). Signed-off-by: Konstantin Khlebnikov [hch: rebased] Signed-off-by: Christoph Hellwig --- include/linux/part_stat.h | 2 +- 1 file cha

Re: [PATCH] gpio: rcar: Fix runtime PM imbalance on error

2020-05-25 Thread Linus Walleij
On Fri, May 22, 2020 at 10:08 AM Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > when it returns an error code. Thus a pairing decrement is needed on > the error handling path to keep the counter balanced. > > Signed-off-by: Dinghao Liu Patch applied.

Re: [PATCH] can: mcp251x: convert to half-duplex SPI

2020-05-25 Thread Mark Brown
On Mon, May 25, 2020 at 01:17:01PM +0200, Marc Kleine-Budde wrote: > On 5/21/20 10:19 PM, Tim Harvey wrote: > > > Should I be submitting this patch with logic that only does > > half-duplex if the spi controller doesn't support it (if > > (spi->controller->flags & SPI_CONTROLLER_HALF_DUPLEX)) or

Re: [PATCH v1] bluetooth: hci_qca: Fix qca6390 enable failure after warm reboot

2020-05-25 Thread Marcel Holtmann
Hi Zijun, > Warm reboot can not restore qca6390 controller baudrate > to default due to lack of controllable BT_EN pin or power > supply, so fails to download firmware after warm reboot. > > Fixed by sending EDL_SOC_RESET VSC to reset controller > within added device shutdown implementation. > >

[PATCH 11/16] block: always use a percpu variable for disk stats

2020-05-25 Thread Christoph Hellwig
percpu variables have a perfectly fine working stub implementation for UP kernels, so use that. Signed-off-by: Christoph Hellwig --- block/blk.h | 2 +- block/genhd.c | 12 +++-- block/partitions/core.c | 5 ++-- include/linux/genhd.h | 13 - include

[PATCH 12/16] block: account merge of two requests

2020-05-25 Thread Christoph Hellwig
From: Konstantin Khlebnikov Also rename blk_account_io_merge() into blk_account_io_merge_request() to distinguish it from merging request and bio. Signed-off-by: Konstantin Khlebnikov [hch: rebased] Signed-off-by: Christoph Hellwig --- block/blk-merge.c | 12 +--- 1 file changed, 5 in

[PATCH 06/16] dm: use bio_{start,end}_io_acct

2020-05-25 Thread Christoph Hellwig
Switch dm to use the nicer bio accounting helpers. Signed-off-by: Christoph Hellwig --- drivers/md/dm.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/md/dm.c b/drivers/md/dm.c index f215b86664484..3f39fa1ac756e 100644 --- a/drivers/md/dm.c +++ b/drivers/md/

[PATCH 04/16] lightnvm/pblk: use bio_{start,end}_io_acct

2020-05-25 Thread Christoph Hellwig
Switch rsxx to use the nicer bio accounting helpers. Signed-off-by: Christoph Hellwig --- drivers/lightnvm/pblk-cache.c | 8 +++- drivers/lightnvm/pblk-read.c | 11 --- 2 files changed, 7 insertions(+), 12 deletions(-) diff --git a/drivers/lightnvm/pblk-cache.c b/drivers/lightnvm/

block I/O accounting improvements

2020-05-25 Thread Christoph Hellwig
Hi Jens, they series contains various improvement for block I/O accounting. The first bunch of patches switch the bio based drivers to better accounting helpers compared to the current mess. The end contains a fix and various performanc improvements. Most of this comes from a series Konstantin

[PATCH 01/16] block: add disk/bio-based accounting helpers

2020-05-25 Thread Christoph Hellwig
Add two new helpers to simplify I/O accounting for bio based drivers. Currently these drivers use the generic_start_io_acct and generic_end_io_acct helpers which have very cumbersome calling conventions, don't actually return the time they started accounting, and try to deal with accounting for par

[PATCH 05/16] bcache: use bio_{start,end}_io_acct

2020-05-25 Thread Christoph Hellwig
Switch bcache to use the nicer bio accounting helpers, and call the routines where we also sample the start time to give coherent accounting results. Signed-off-by: Christoph Hellwig --- drivers/md/bcache/request.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff -

[PATCH 02/16] drbd: use bio_{start,end}_io_acct

2020-05-25 Thread Christoph Hellwig
Switch drbd to use the nicer bio accounting helpers. Signed-off-by: Christoph Hellwig --- drivers/block/drbd/drbd_req.c | 27 --- 1 file changed, 4 insertions(+), 23 deletions(-) diff --git a/drivers/block/drbd/drbd_req.c b/drivers/block/drbd/drbd_req.c index 840c3aef3c5

Re: [PATCH 2/6] arm64: dts: qcom: sm8250: add apps_smmu node

2020-05-25 Thread Jonathan Marek
On 5/25/20 7:17 AM, Sai Prakash Ranjan wrote: Hi, On 2020-05-25 16:38, Jonathan Marek wrote: On 5/25/20 6:54 AM, Sai Prakash Ranjan wrote: On 2020-05-25 15:39, Jonathan Marek wrote: Hi, On 5/25/20 5:42 AM, Sai Prakash Ranjan wrote: Hi Jonathan, On 2020-05-24 08:08, Jonathan Marek wrote: Ad

Re: [PATCH v2 1/7] locking: Introduce local_lock()

2020-05-25 Thread Sebastian Andrzej Siewior
On 2020-05-25 09:12:14 [+0200], Ingo Molnar wrote: > > * Ingo Molnar wrote: > > > ( The other departure from spinlocks is that the 'spinlock_t' name, > > without underscores, while making the API names such as spin_lock() > > with an underscore, was a conscious didactic choice. Applying th

Re: [PATCH v2 1/7] locking: Introduce local_lock()

2020-05-25 Thread Sebastian Andrzej Siewior
On 2020-05-25 09:01:39 [+0200], Ingo Molnar wrote: > > * Sebastian Andrzej Siewior wrote: > > > From: Thomas Gleixner > > > > To address this PREEMPT_RT introduced the concept of local_locks which are > > strictly per CPU. > > > +++ b/include/linux/locallock_internal.h > > @@ -0,0 +1,90 @@ >

Re: Some -serious- BPF-related litmus tests

2020-05-25 Thread Peter Zijlstra
On Fri, May 22, 2020 at 12:38:21PM -0700, Andrii Nakryiko wrote: > On 5/22/20 10:43 AM, Paul E. McKenney wrote: > > On Fri, May 22, 2020 at 10:32:01AM -0400, Alan Stern wrote: > > > Also, what use is a spinlock that is accessed in only one thread? > > > > Multiple writers synchronize via the spin

[RFC PATCH 4/7] KVM: arm64: Steply write protect page table by mask bit

2020-05-25 Thread Keqian Zhu
During dirty log clear, page table entries are write protected according to a mask. In the past we write protect all entries corresponding to the mask from ffs to fls. Though there may be zero bits between this range, we are holding the kvm mmu lock so we won't write protect entries that we don't w

[RFC PATCH 1/7] KVM: arm64: Add some basic functions for hw DBM

2020-05-25 Thread Keqian Zhu
Prepare some basic functions used by following patches to support hardware DBM. Signed-off-by: Keqian Zhu Signed-off-by: Peng Liang --- arch/arm64/include/asm/kvm_mmu.h | 24 1 file changed, 24 insertions(+) diff --git a/arch/arm64/include/asm/kvm_mmu.h b/arch/arm64/in

[RFC PATCH 7/7] KVM: arm64: Enable stage2 hardware DBM

2020-05-25 Thread Keqian Zhu
We are ready to support hw management of dirty state, enable it if hardware support it. Signed-off-by: Keqian Zhu Signed-off-by: Peng Liang --- arch/arm64/include/asm/sysreg.h | 2 ++ arch/arm64/kvm/reset.c | 9 - 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/a

[RFC PATCH 3/7] KVM: arm64: Traverse page table entries when sync dirty log

2020-05-25 Thread Keqian Zhu
For hardware management of dirty state, dirty state is stored in page table entries. We have to traverse page table entries when sync dirty log. Signed-off-by: Keqian Zhu Signed-off-by: Peng Liang --- arch/arm64/include/asm/kvm_host.h | 1 + virt/kvm/arm/arm.c| 6 +- virt/kv

[RFC PATCH 5/7] kvm: arm64: Modify stage2 young mechanism to support hw DBM

2020-05-25 Thread Keqian Zhu
Making page table entries young (set AF bit) should be atomic to avoid cover dirty info that is set by hardware. Signed-off-by: Keqian Zhu --- arch/arm64/include/asm/kvm_mmu.h | 32 ++-- virt/kvm/arm/mmu.c | 10 +- 2 files changed, 27 insertions(

[RFC PATCH 6/7] kvm: arm64: Save stage2 PTE dirty info if it is coverred

2020-05-25 Thread Keqian Zhu
kvm_set_pte is called to replace a target PTE with a desired one. We always replace it, but if hw DBM is enalbled and dirty info is coverred, should let caller know it. Caller can decide to whether save the dirty info. kvm_set_pmd and kvm_set_pud is not modified, because we only use DBM in PTEs fo

[RFC PATCH 0/7] kvm: arm64: Support stage2 hardware DBM

2020-05-25 Thread Keqian Zhu
This patch series add support for stage2 hardware DBM, and it is only used for dirty log for now. It works well under some migration test cases, including VM with 4K pages or 2M THP. I checked the SHA256 hash digest of all memory and they keep same for source VM and destination VM, which means no

[RFC PATCH 2/7] KVM: arm64: Set DBM bit of PTEs if hw DBM enabled

2020-05-25 Thread Keqian Zhu
In user_mem_abort, for normal case (mem_type is PAGE_S2), set DBM bit of PTEs if hw DBM enabled. We also check and set DBM bit during write protect PTEs to make it works well if we miss some cases. Signed-off-by: Keqian Zhu Signed-off-by: Peng Liang --- arch/arm64/include/asm/pgtable-prot.h |

Re: [PATCH 1/2] software node: implement software_node_unregister()

2020-05-25 Thread Heikki Krogerus
On Sun, May 24, 2020 at 05:30:40PM +0200, Greg Kroah-Hartman wrote: > Sometimes it is better to unregister individual nodes instead of trying > to do them all at once with software_node_unregister_nodes(), so create > software_node_unregister() so that you can unregister them one at a > time. > >

Re: [PATCH v3] thermal: qoriq: Update the settings for TMUv2

2020-05-25 Thread Daniel Lezcano
On 25/05/2020 09:21, Yuantian Tang wrote: > For TMU v2, TMSAR registers need to be set properly to get the > accurate temperature values. > Also the temperature read needs to be converted to degree Celsius > since it is in degrees Kelvin. > Signed-off-by: Yuantian Tang > --- [ ... ] > @@ -202,6

Re: [PATCH 2/6] arm64: dts: qcom: sm8250: add apps_smmu node

2020-05-25 Thread Sai Prakash Ranjan
Hi, On 2020-05-25 16:38, Jonathan Marek wrote: On 5/25/20 6:54 AM, Sai Prakash Ranjan wrote: On 2020-05-25 15:39, Jonathan Marek wrote: Hi, On 5/25/20 5:42 AM, Sai Prakash Ranjan wrote: Hi Jonathan, On 2020-05-24 08:08, Jonathan Marek wrote: Add the apps_smmu node for sm8250. Note that addi

<    2   3   4   5   6   7   8   9   10   >