[PATCH v2 17/41] media: atomisp: add debug functions for received events

2020-05-29 Thread Mauro Carvalho Chehab
For debugging purposes, it helps to know what event was actually received. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/atomisp/pci/atomisp_compat_css20.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c b/dr

[PATCH v2 25/41] media: atomisp: Avoid overflow in compute_blending

2020-05-29 Thread Mauro Carvalho Chehab
From: Nathan Chancellor Clang warns: drivers/staging/media/atomisp/pci/isp/kernels/xnr/xnr_3.0/ia_css_xnr3.host.c:129:35: warning: implicit conversion from 'unsigned long' to 'int32_t' (aka 'int') changes value from 18446744073709543424 to -8192 [-Wconstant-conversion] return MAX(MIN(isp

[PATCH v2 23/41] media: atomisp: Remove unnecessary NULL checks in ia_css_pipe_load_extension

2020-05-29 Thread Mauro Carvalho Chehab
From: Nathan Chancellor Clang warns: ../drivers/staging/media/atomisp/pci/sh_css.c:8537:14: warning: address of 'pipe->output_stage' will always evaluate to 'true' [-Wpointer-bool-conversion] if (&pipe->output_stage) ~~ ~~^~~~ ../drivers/staging/medi

[PATCH v2 03/41] media: atomisp: reduce abstraction at ia_css_memory_access

2020-05-29 Thread Mauro Carvalho Chehab
Yet another memory abstraction layer. Getting rid of this may be a little trickier, but let's reduce it to a minimal. Signed-off-by: Mauro Carvalho Chehab --- .../staging/media/atomisp/include/hmm/hmm.h | 3 - .../memory_access/memory_access.h | 61 +-- drivers/sta

[PATCH v2 15/41] media: atomisp: add debug for hmm alloc

2020-05-29 Thread Mauro Carvalho Chehab
The hmm code is still complex and has bugs. Add a debug print when memory gets allocated, in order to help identifying what's happening out there. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/atomisp/pci/hmm/hmm.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

[PATCH v2 09/41] media: atomisp: hmm_bo: untag user pointers

2020-05-29 Thread Mauro Carvalho Chehab
The kernel ABI was extended to allow pass tagged user pointers. Untag the pointers in this function. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/atomisp/pci/hmm/hmm_bo.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/media/atomisp/pci/hmm/hmm_bo.c b/d

[PATCH v2 13/41] media: atomisp: fix driver caps

2020-05-29 Thread Mauro Carvalho Chehab
This device driver is not MC-centric. So, remove the wrong caps from it. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/atomisp/pci/atomisp_subdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_subdev.c b/drivers

[PATCH v2 04/41] media: atomisp: go one step further to drop ia_css_memory_access.c

2020-05-29 Thread Mauro Carvalho Chehab
Move the attrs handling into hmm, simplifying even further what the ia_css_memory_access.c file does. Yet, the returned type for ia_css_memory_access.c is an integer, instead of a pointer. Signed-off-by: Mauro Carvalho Chehab --- .../staging/media/atomisp/include/hmm/hmm.h | 3 ++- .../media

[PATCH v2 32/41] media: atomisp: don't cause a warn if probe failed

2020-05-29 Thread Mauro Carvalho Chehab
When probe fails, it is possible that hmm_init() to not be called. On such case, hmm_cleanup() will cause a WARN_ON(). Avoid it by adding an explicit check at hmm_cleanup() to ensure that the hmm code was properly initialized. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/atomi

[PATCH v2 05/41] media: atomisp: get rid of mmgr_load and mmgr_store

2020-05-29 Thread Mauro Carvalho Chehab
Those functions are just wrappers for hmm_load/hmm_store. Signed-off-by: Mauro Carvalho Chehab --- .../pci/hive_isp_css_common/host/debug.c | 8 +++--- .../hive_isp_css_common/host/debug_private.h | 8 +++--- .../memory_access/memory_access.h | 20 - drivers/stagi

[PATCH v2 21/41] media: atomisp: Clean up if block in sh_css_sp_init_stage

2020-05-29 Thread Mauro Carvalho Chehab
From: Nathan Chancellor Clang warns: ../drivers/staging/media/atomisp/pci/sh_css_sp.c:1039:23: warning: address of 'binary->in_frame_info' will always evaluate to 'true' [-Wpointer-bool-conversion] } else if (&binary->in_frame_info) { ~~ ^

[PATCH v2 27/41] media: atomisp: avoid an extra memset() when alloc memory

2020-05-29 Thread Mauro Carvalho Chehab
Use the variant which zeroes the memory when allocating, instead of having an explicit memset. Signed-off-by: Mauro Carvalho Chehab --- .../staging/media/atomisp/pci/runtime/pipeline/src/pipeline.c | 3 +-- drivers/staging/media/atomisp/pci/sh_css.c | 3 +-- 2 files changed,

[PATCH v2 36/41] media: atomisp: print firmware data during load

2020-05-29 Thread Mauro Carvalho Chehab
While there's a way to list the firmware binaries in runtime, it is worth to also print it during firmware load. One advantage is that this code also introduces additional checks with regards to invalid firmware types, which can be useful to identify problems. Signed-off-by: Mauro Carvalho Chehab

[PATCH v2 37/41] media: atomisp: allow passing firmware name at modprobe time

2020-05-29 Thread Mauro Carvalho Chehab
It can be useful to be able to test different firmware files at modprobe time, in order to be able to test different variants without much efforts. Signed-off-by: Mauro Carvalho Chehab --- .../staging/media/atomisp/pci/atomisp_v4l2.c | 30 --- 1 file changed, 19 insertions(+), 1

[PATCH v2 39/41] media: atomisp: add some debug messages when binaries are used

2020-05-29 Thread Mauro Carvalho Chehab
The ISP firmware logic is complex, as several binaries are contained into a single file. Print debug messages: - with a stack dump if binary not found; - when a firmware is selected. Signed-off-by: Mauro Carvalho Chehab --- .../atomisp/pci/runtime/binary/src/binary.c | 31

[PATCH v2 00/41] More atomisp fixes and cleanups

2020-05-29 Thread Mauro Carvalho Chehab
The first 20 patches on this series were already submitted, but I forgot to c/c linux-media. So, I'm just resending, without any changes. Most of them are working at the memory management abstraction, cleaning it, removing abstraction layers and getting rid of legacy stuff. Patch 20 contains an im

[PATCH v2 35/41] media: atomisp: provide more details about the firmware binaries

2020-05-29 Thread Mauro Carvalho Chehab
In order to make easier to identify what a firmware file contains, add more info at the firmware dump log facility. Signed-off-by: Mauro Carvalho Chehab --- .../media/atomisp/pci/atomisp_compat_css20.c | 39 +-- .../media/atomisp/pci/ia_css_acc_types.h | 4 +- .../media/at

[PATCH v2 26/41] media: atomisp: Remove binary_supports_input_format

2020-05-29 Thread Mauro Carvalho Chehab
From: Nathan Chancellor Clang warns: drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c:1707:64: warning: implicit conversion from enumeration type 'const enum ia_css_frame_format' to different enumeration type 'enum atomisp_input_format' [-Wenum-conversion] binary_supports_in

[PATCH v2 38/41] media: atomisp: add a debug message at hmm free

2020-05-29 Thread Mauro Carvalho Chehab
In order to check if aren't there any memory leaks, let's add a debug print for hmm_free(). Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/atomisp/pci/hmm/hmm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/media/atomisp/pci/hmm/hmm.c b/drivers/staging/me

[PATCH v2 28/41] media: atomisp: remove some trivial wrappers from compat css20

2020-05-29 Thread Mauro Carvalho Chehab
There are tons of code inside atomisp_compat_css20.c, but several of them are just trivial wrappers to other functions. Getting rid of all of them will take some time, but let's start getting rid of some of the trivial ones. Signed-off-by: Mauro Carvalho Chehab --- .../staging/media/atomisp/pci

[PATCH v2 40/41] media: atomisp: get rid of set_fs() dirty hacks

2020-05-29 Thread Mauro Carvalho Chehab
This file was based on an older version of the V4L2 compat32 code, which had this ugly hack. Change the code to remove the hack. Yet, the entire compat32 code is currently commented out. So, let's add a FIXME note at the code, as we may need to check if some of the atomisp specific ioctls would re

[PATCH v2 31/41] media: atomisp: get rid of an error abstraction layer

2020-05-29 Thread Mauro Carvalho Chehab
There is an abstraction layer there meant to convert to the Linux standard error codes. As the driver now use such errors everywhere. we can get rid of this. Signed-off-by: Mauro Carvalho Chehab --- .../staging/media/atomisp/pci/atomisp_cmd.c | 2 +- .../pci/camera/util/interface/ia_css_util.

[PATCH v2 34/41] media: atomisp: get rid of system_types.h

2020-05-29 Thread Mauro Carvalho Chehab
This is just a wrapper for system_local.h. Signed-off-by: Mauro Carvalho Chehab --- .../base/refcount/interface/ia_css_refcount.h | 2 +- .../input_formatter_global.h | 2 +- .../pci/hive_isp_css_common/irq_global.h | 2 +- .../pci/hive_isp_css_common/isp_global.h |

[PATCH v2 02/41] media: atomisp: get rid of the hrt/hive_isp_css_mm_hrt abstraction layer

2020-05-29 Thread Mauro Carvalho Chehab
Simplify the code by removing this extra memory management abstraction layer. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/atomisp/Makefile| 1 - .../staging/media/atomisp/pci/atomisp_acc.c | 24 --- .../staging/media/atomisp/pci/atomisp_cmd.c | 2 +- .../medi

[PATCH v2 33/41] media: atomisp: get rid of a bunch of other wrappers

2020-05-29 Thread Mauro Carvalho Chehab
There are too many wrapper functions at atomisp_compat_css20.c. Get rid of another set of such wrappers. Signed-off-by: Mauro Carvalho Chehab --- .../staging/media/atomisp/pci/atomisp_cmd.c | 156 +- .../media/atomisp/pci/atomisp_compat.h| 79 - .../media/atomisp/pci/atom

[PATCH v2 19/41] media: atomisp: remove kvmalloc/kvcalloc abstractions

2020-05-29 Thread Mauro Carvalho Chehab
The sh_css layer adds an abstraction for kvmalloc/kvcalloc. Get rid of them. Most of the work here was done by this small coccinelle script: @@ expression size; @@ - sh_css_malloc(size) + kvmalloc(size, GFP_KERNEL) @@ expression n; expression size; @@ - sh_css_calloc(n, size) + kvcalloc(n, si

[PATCH v2 06/41] media: atomisp: get rid of unused memory_realloc code

2020-05-29 Thread Mauro Carvalho Chehab
The code for it is commented out, probably because it is broken or uneeded for the driver to work. So, let's get rid of it. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/atomisp/Makefile| 1 - .../pci/hive_isp_css_include/memory_realloc.h | 38 - .../media/atomi

RE: [PATCH v4 4/4] scsi: ufs: add compatibility with 3.1 UFS unit descriptor length

2020-05-29 Thread Avri Altman
> > From: Bean Huo > > For UFS 3.1, the normal unit descriptor is 10 bytes larger > than the RPMB unit, however, both descriptors share the same > desc_idn, to cover both unit descriptors with one length, we > choose the normal unit descriptor length by desc_index. This is not what your code i

[PATCH v2 29/41] media: atomisp: do another round of coding style cleanup

2020-05-29 Thread Mauro Carvalho Chehab
Run checkpatch --fix-inline again, in order to get rid of some additional issues that got introduced (or that checkpatch can now detect). This should help preventing receiving random cleanups, while keeping the code on a better shape. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/med

[PATCH v2 01/41] media: atomisp: simplify hive_isp_css_mm_hrt wrapper

2020-05-29 Thread Mauro Carvalho Chehab
The code there is a wrapper for hmm/ wrapper. Simplify it, and get rid of ION-specific code. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/atomisp/Makefile| 5 -- .../media/atomisp/include/hmm/hmm_bo.h| 9 --- .../staging/media/atomisp/pci/atomisp_acc.c | 2

[PATCH v2 12/41] media: atomisp: get rid of a warning message

2020-05-29 Thread Mauro Carvalho Chehab
There's a warning message about an unused code. The code that were using it were commented out, due to a problem causing the firmware load to fail on the machines we're using for testing. Change the place where we're commenting the code out, in order to avoid the warning. Fixes: 95d1f398c4dc ("me

[PATCH v2 07/41] media: atomisp: change the type returned by mmgr alloc

2020-05-29 Thread Mauro Carvalho Chehab
The mmgr alloc code returns a different type than hmm, due to some abstraction layer. Change the driver to use just one type to represent the hmm memory. Signed-off-by: Mauro Carvalho Chehab --- .../base/refcount/interface/ia_css_refcount.h | 13 ++-- .../atomisp/pci/base/refcount/src/refcount.

[PATCH v2 11/41] media: atomisp: use Yocto Aero default hmm pool sizes

2020-05-29 Thread Mauro Carvalho Chehab
Yocto Aero driver has a different default for hmm pools. Use the definitions there. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_

[PATCH v2 18/41] media: atomisp: add more comments about frame allocation

2020-05-29 Thread Mauro Carvalho Chehab
The frame allocation logic happens differently for userptr or normal mmap. On a quick look, this sounded to be unbalanced, but the logic should actually work for both cases. Add an extra comment to reflect it. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/atomisp/pci/atomisp_io

[PATCH v2 14/41] media: atomisp: use pin_user_pages() for memory allocation

2020-05-29 Thread Mauro Carvalho Chehab
Instead of using a hacked version of an old copy of get_user_pages(), use pin_user_pages(). Signed-off-by: Mauro Carvalho Chehab --- .../media/atomisp/include/hmm/hmm_bo.h| 2 + .../staging/media/atomisp/pci/hmm/hmm_bo.c| 145 +++--- 2 files changed, 24 insertions(+), 1

[PATCH v2 20/41] media: atomisp: avoid OOPS due to non-existing ref_frames

2020-05-29 Thread Mauro Carvalho Chehab
stage->args->delay_frames array could point to NULL frames. What's weird is that we didn't notice this behavior with the Intel Aero Yocto code. Handle it, while adding a notice at the code, as this could be due to some broken pipeline setup. Signed-off-by: Mauro Carvalho Chehab --- .../pci/isp

[PATCH v2 24/41] media: atomisp: Remove unnecessary NULL check in atomisp_param

2020-05-29 Thread Mauro Carvalho Chehab
From: Nathan Chancellor Clang warns: drivers/staging/media/atomisp/pci/atomisp_cmd.c:4278:17: warning: address of 'config->info' will always evaluate to 'true' [-Wpointer-bool-conversion] if (!&config->info) { ~ ^~~~ config cannot be NULL because it c

[PATCH v2 16/41] media: atomisp: improve warning for IRQ enable function

2020-05-29 Thread Mauro Carvalho Chehab
If something gets wrong when enabling or disabling an IRQ, we should know better about what happened. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/atomisp/pci/atomisp_compat_css20.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/ato

Re: [PATCH v3 6/7] watchdog: dw_wdt: Add pre-timeouts support

2020-05-29 Thread Serge Semin
On Fri, May 29, 2020 at 04:02:19PM -0700, Guenter Roeck wrote: > On Tue, May 26, 2020 at 06:41:22PM +0300, Serge Semin wrote: > > DW Watchdog can rise an interrupt in case if IRQ request mode is enabled > > and timer reaches the zero value. In this case the IRQ lane is left > > pending until either

Re: [RFC v3 1/3] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements

2020-05-29 Thread Wesley Cheng
On 5/29/2020 9:28 AM, Jack Pham wrote: > Hi Wesley, > > On Wed, May 27, 2020 at 06:46:01PM -0700, Wesley Cheng wrote: >> Some devices have USB compositions which may require multiple endpoints >> that support EP bursting. HW defined TX FIFO sizes may not always be >> sufficient for these compo

RE: [PATCH v4 3/4] scsi: ufs: cleanup ufs initialization path

2020-05-29 Thread Avri Altman
> - case QUERY_DESC_IDN_RFU_0: > - case QUERY_DESC_IDN_RFU_1: You forgot to check that desc_id < QUERY_DESC_IDN_MAX > + if (desc_id == QUERY_DESC_IDN_RFU_0 || desc_id == > QUERY_DESC_IDN_RFU_1) > *desc_len = 0; > - break; > - default: > -

Re: Lost PCIe PME after a914ff2d78ce ("PCI/ASPM: Don't select CONFIG_PCIEASPM by default")

2020-05-29 Thread Heiner Kallweit
On 30.05.2020 00:58, Matthew Garrett wrote: > On Sat, May 30, 2020 at 12:26:17AM +0200, Heiner Kallweit wrote: > >> Current situation means that PME is unusable on all systems where >> pcie_aspm_support_enabled() returns false, what is basically every >> system except EXPERT mode is enabled and C

Re: [RFC v3 0/3] Re-introduce TX FIFO resize for larger EP bursting

2020-05-29 Thread Wesley Cheng
On 5/29/2020 3:12 AM, Greg KH wrote: > On Wed, May 27, 2020 at 06:46:00PM -0700, Wesley Cheng wrote: >> Changes in V3: >> - Removed "Reviewed-by" tags >> - Renamed series back to RFC >> - Modified logic to ensure that fifo_size is reset if we pass the minimum >>threshold. Tested with bin

[PATCH] perf/evsel: Fix missing close fd when ignore_missing_thread

2020-05-29 Thread Cheng Jian
While monitoring a multithread process with pid option, if any of the threads exit before we open the event fd, we can ignore the missing thread. We use perf_evsel__remove_fd() to remove the FD of the missing thread, but we missed to close these fds. This patch explicitly closes the fd before remo

[PATCH RFC] seccomp: Implement syscall isolation based on memory areas

2020-05-29 Thread Gabriel Krisman Bertazi
Modern Windows applications are executing system call instructions directly from the application's code without going through the WinAPI. This breaks Wine emulation, because it doesn't have a chance to intercept and emulate these syscalls before they are submitted to Linux. In addition, we cannot

[PATCH net-next] mlx5: Restore err assignment in mlx5_mdev_init

2020-05-29 Thread Nathan Chancellor
Clang warns: drivers/net/ethernet/mellanox/mlx5/core/main.c:1278:6: warning: variable 'err' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] if (!priv->dbg_root) { ^~~ drivers/net/ethernet/mellanox/mlx5/core/main.c:1303:9: note: unin

Re: [PATCH v8 14/18] EFI: Introduce the new AMD Memory Encryption GUID.

2020-05-29 Thread Ashish Kalra
Hello Steve, On Fri, May 29, 2020 at 07:07:56PM -0700, Steve Rutherford wrote: > On Tue, May 5, 2020 at 2:20 PM Ashish Kalra wrote: > > > > From: Ashish Kalra > > > > Introduce a new AMD Memory Encryption GUID which is currently > > used for defining a new UEFI enviroment variable which indicate

Re: [PATCH v8 12/18] KVM: SVM: Add support for static allocation of unified Page Encryption Bitmap.

2020-05-29 Thread Ashish Kalra
Hello Steve, On Fri, May 29, 2020 at 07:07:33PM -0700, Steve Rutherford wrote: > On Tue, May 5, 2020 at 2:18 PM Ashish Kalra wrote: > > > > From: Ashish Kalra > > > > Add support for static allocation of the unified Page encryption bitmap by > > extending kvm_arch_commit_memory_region() callack

Re: [PATCH v2 2/3] seccomp: Introduce addfd ioctl to seccomp user notifier

2020-05-29 Thread Kees Cook
On Sat, May 30, 2020 at 03:58:18AM +, Sargun Dhillon wrote: > Isn't the "right" way to do this to allocate a bunch of file descriptors, > and fill up the user buffer with them, and then install the files? This > seems to like half-install the file descriptors and then error out. > > I know tha

[PATCH V2] mm, memory_failure: don't send BUS_MCEERR_AO for action required error

2020-05-29 Thread Wetp Zhang
Some processes dont't want to be killed early, but in "Action Required" case, those also may be killed by BUS_MCEERR_AO when sharing memory with other which is accessing the fail memory. And sending SIGBUS with BUS_MCEERR_AO for action required error is strange, so ignore the non-current processes

Re: [PATCH 9/9] staging: media: atomisp: add PMIC_OPREGION dependency

2020-05-29 Thread Mauro Carvalho Chehab
Em Fri, 29 May 2020 20:11:29 -0700 Nathan Chancellor escreveu: > On Fri, May 29, 2020 at 10:00:31PM +0200, Arnd Bergmann wrote: > > Without that driver, there is a link failure in > > > > ERROR: modpost: "intel_soc_pmic_exec_mipi_pmic_seq_element" > > [drivers/staging/media/atomisp/pci/atomisp_g

Re: [PATCH v2 2/3] seccomp: Introduce addfd ioctl to seccomp user notifier

2020-05-29 Thread Kees Cook
On Sat, May 30, 2020 at 05:17:24AM +0200, Jann Horn wrote: > On Sat, May 30, 2020 at 4:43 AM Kees Cook wrote: > > I mean, yes, that's certainly better, but it just seems a shame that > > everyone has to do the get_unused/put_unused dance just because of how > > SCM_RIGHTS does this weird put_user(

Re: [PATCH 2/2] exec: Compute file based creds only once

2020-05-29 Thread Kees Cook
On Fri, May 29, 2020 at 10:28:41PM -0500, Eric W. Biederman wrote: > The range-diff winds up being: > 1: c9258ef4879b ! 1: a7868323c263 exec: Add a per bprm->file version of > per_clear > @@ Commit message > > History Tree: > git://git.kernel.org/pub/scm/linux/kernel/git/tglx

Re: [PATCH 1/2] exec: Add a per bprm->file version of per_clear

2020-05-29 Thread Kees Cook
On Fri, May 29, 2020 at 10:23:58PM -0500, Eric W. Biederman wrote: > Kees Cook writes: > > I wish we had more robust execve tests. :( > > I think you have more skill at writing automated tests than I do. So > feel free to write some. Yeah, my limiting factor is available time. No worries; I did

Re: [PATCH 17/30] KVM: nSVM: synchronize VMCB controls updated by the processor on every vmexit

2020-05-29 Thread Paolo Bonzini
On 30/05/20 04:06, Krish Sadhukhan wrote: >> >>   -    nested_vmcb->control.int_ctl   = vmcb->control.int_ctl; >> -    nested_vmcb->control.int_vector    = vmcb->control.int_vector; > > > While it's not related to this patch, I am wondering if we need the > following line in enter_svm

[PATCH v2] locking/Kconfig: Don't forcefully uninline spin_unlock for PREEMPT

2020-05-29 Thread Sultan Alsawaf
From: Sultan Alsawaf This change was originally done in 2005 without any justification in commit bda98685b855 ("[PATCH] x86: inline spin_unlock if !CONFIG_DEBUG_SPINLOCK and !CONFIG_PREEMPT"). Perhaps the reasoning at the time was that PREEMPT was still considered unstable and needed extra debugg

[PATCH] locking/Kconfig: Don't forcefully uninline spin_unlock for PREEMPT

2020-05-29 Thread Sultan Alsawaf
From: Sultan Alsawaf This change was originally done in 2005 without any justification in commit bda98685b855 ("[PATCH] x86: inline spin_unlock if !CONFIG_DEBUG_SPINLOCK and !CONFIG_PREEMPT"). Perhaps the reasoning at the time was that PREEMPT was still considered unstable and needed extra debugg

linux-next: Signed-off-by missing for commit in the clk tree

2020-05-29 Thread Stephen Rothwell
Hi all, Commit 5f2feacb7639 ("clk: vc5: Add support for IDT VersaClock 5P49V6965") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell pgpRr3mitCWYb.pgp Description: OpenPGP digital signature

Re: [PATCH] flow_dissector: work around stack frame size warning

2020-05-29 Thread Cong Wang
On Fri, May 29, 2020 at 1:14 PM Arnd Bergmann wrote: > > The fl_flow_key structure is around 500 bytes, so having two of them > on the stack in one function now exceeds the warning limit after an > otherwise correct change: > > net/sched/cls_flower.c:298:12: error: stack frame size of 1056 bytes i

[PATCH][v5] KVM: X86: support APERF/MPERF registers

2020-05-29 Thread Li RongQing
Guest kernel reports a fixed cpu frequency in /proc/cpuinfo, this is confused to user when turbo is enable, and aperf/mperf can be used to show current cpu frequency after 7d5905dc14a "(x86 / CPU: Always show current CPU frequency in /proc/cpuinfo)" so guest should support aperf/mperf capability T

[RFC][PATCH] usb: typec: tcpci_rt1711h: Try to avoid screaming irq causing boot hangs

2020-05-29 Thread John Stultz
I've recently (since 5.7-rc1) started noticing very rare hangs pretty early in bootup on my HiKey960 board. They have been particularly difficult to debug, as the system seems to not respond at all to sysrq- commands. However, the system is alive as I'll occaionally see firmware loading timeout er

Re: [PATCH v2 2/3] seccomp: Introduce addfd ioctl to seccomp user notifier

2020-05-29 Thread Sargun Dhillon
> > I mean, yes, that's certainly better, but it just seems a shame that > everyone has to do the get_unused/put_unused dance just because of how > SCM_RIGHTS does this weird put_user() in the middle. > > Can anyone clarify the expected failure mode from SCM_RIGHTS? Can we > move the put_user() a

Re: [PATCH] refperf: work around 64-bit division

2020-05-29 Thread Nathan Chancellor
On Fri, May 29, 2020 at 10:15:51PM +0200, Arnd Bergmann wrote: > A 64-bit division was introduced in refperf, breaking compilation > on all 32-bit architectures: > > kernel/rcu/refperf.o: in function `main_func': > refperf.c:(.text+0x57c): undefined reference to `__aeabi_uldivmod' > > Work it by

Re: [PATCH 2/2] exec: Compute file based creds only once

2020-05-29 Thread Eric W. Biederman
Kees Cook writes: > On Fri, May 29, 2020 at 11:47:29AM -0500, Eric W. Biederman wrote: >> diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h >> index cd3dd0afceb5..37bb3df751c6 100644 >> --- a/include/linux/lsm_hooks.h >> +++ b/include/linux/lsm_hooks.h >> @@ -44,18 +44,18 @@ >>

Re: [PATCH 1/2] exec: Add a per bprm->file version of per_clear

2020-05-29 Thread Eric W. Biederman
Kees Cook writes: > On Fri, May 29, 2020 at 11:46:40AM -0500, Eric W. Biederman wrote: >> >> There is a small bug in the code that recomputes parts of bprm->cred >> for every bprm->file. The code never recomputes the part of >> clear_dangerous_personality_flags it is responsible for. >> >> Whi

[PATCH] usb: cdns3: fix possible buffer overflow caused by bad DMA value

2020-05-29 Thread Jia-Ju Bai
In cdns3_ep0_setup_phase(): struct usb_ctrlrequest *ctrl = priv_dev->setup_buf; Because priv_dev->setup_buf (allocated in cdns3_gadget_start) is stored in DMA memory, and thus ctrl is a DMA value. cdns3_ep0_setup_phase() cdns3_ep0_standard_request(priv_dev, ctrl) cdns3_req_ep0_get_status

Re: [PATCH v2 2/3] seccomp: Introduce addfd ioctl to seccomp user notifier

2020-05-29 Thread Jann Horn
On Sat, May 30, 2020 at 4:43 AM Kees Cook wrote: > I mean, yes, that's certainly better, but it just seems a shame that > everyone has to do the get_unused/put_unused dance just because of how > SCM_RIGHTS does this weird put_user() in the middle. > > Can anyone clarify the expected failure mode f

Re: [PATCH 9/9] staging: media: atomisp: add PMIC_OPREGION dependency

2020-05-29 Thread Nathan Chancellor
On Fri, May 29, 2020 at 10:00:31PM +0200, Arnd Bergmann wrote: > Without that driver, there is a link failure in > > ERROR: modpost: "intel_soc_pmic_exec_mipi_pmic_seq_element" > [drivers/staging/media/atomisp/pci/atomisp_gmin_platform.ko] undefined! > > Add an explicit Kconfig dependency. > > S

Re: [PATCH 8/9] staging: media: atomisp: disable all custom formats

2020-05-29 Thread Nathan Chancellor
On Fri, May 29, 2020 at 10:00:30PM +0200, Arnd Bergmann wrote: > clang points out the usage of an incorrect enum type in the > list of supported image formats: > > drivers/staging/media/atomisp/pci/atomisp_subdev.c:49:65: error: implicit > conversion from enumeration type 'enum ia_css_frame_forma

Re: [PATCH 7/9] staging: media: atomisp: fix enum type mixups

2020-05-29 Thread Nathan Chancellor
On Fri, May 29, 2020 at 10:00:29PM +0200, Arnd Bergmann wrote: > Some function calls pass an incorrect enum type: > > drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:858:16: > error: implicit conversion from enumeration type 'input_system_ID_t' to > different enumeratio

Re: [PATCH 5/9] staging: media: atomisp: fix stack overflow in init_pipe_defaults()

2020-05-29 Thread Nathan Chancellor
On Fri, May 29, 2020 at 10:00:27PM +0200, Arnd Bergmann wrote: > When building with clang, multiple copies of the structures to be > initialized are passed around on the stack and copied locally, using an > insane amount of stack space: > > drivers/staging/media/atomisp/pci/sh_css.c:2371:1: error:

Re: [PATCH 2/9] staging: media: atomisp: declare 'struct device' before using it

2020-05-29 Thread Nathan Chancellor
On Fri, May 29, 2020 at 10:00:24PM +0200, Arnd Bergmann wrote: > In some configurations, including this header leads to a warning: > > drivers/staging/media/atomisp//pci/sh_css_firmware.h:41:38: error: > declaration of 'struct device' will not be visible outside of this function > [-Werror,-Wvis

Re: [PATCH 3/9] staging: media: atomisp: annotate an unused function

2020-05-29 Thread Nathan Chancellor
On Fri, May 29, 2020 at 10:00:25PM +0200, Arnd Bergmann wrote: > atomisp_mrfld_power() has no more callers and produces > a warning: > > drivers/staging/media/atomisp/pci/atomisp_v4l2.c:764:12: error: unused > function 'atomisp_mrfld_power' [-Werror,-Wunused-function] > > Mark the function as un

Re: [PATCH 1/9] staging: media: atomisp: fix incorrect NULL pointer check

2020-05-29 Thread Nathan Chancellor
On Fri, May 29, 2020 at 10:31:44PM +0200, Arnd Bergmann wrote: > On Fri, May 29, 2020 at 10:23 PM Arnd Bergmann wrote: > > > > On Fri, May 29, 2020 at 10:04 PM 'Nick Desaulniers' via Clang Built > > Linux wrote: > > > > > > See also Nathan's 7 patch series. > > > https://lore.kernel.org/lkml/2020

Re: [PATCH v2 2/3] seccomp: Introduce addfd ioctl to seccomp user notifier

2020-05-29 Thread Kees Cook
On Sat, May 30, 2020 at 01:10:55AM +, Sargun Dhillon wrote: > // And then SCM reads: > for (i=0, cmfptr=(__force int __user *)CMSG_DATA(cm); ii++, cmfptr++) > { > int new_fd; > err = get_unused_fd_flags(MSG_CMSG_CLOEXEC & msg->msg_flags >

[PATCH] net: vmxnet3: fix possible buffer overflow caused by bad DMA value in vmxnet3_get_rss()

2020-05-29 Thread Jia-Ju Bai
The value adapter->rss_conf is stored in DMA memory, and it is assigned to rssConf, so rssConf->indTableSize can be modified at anytime by malicious hardware. Because rssConf->indTableSize is assigned to n, buffer overflow may occur when the code "rssConf->indTable[n]" is executed. To fix this pos

[PATCH] media: venus: fix possible buffer overlow casued bad DMA value in venus_sfr_print()

2020-05-29 Thread Jia-Ju Bai
The value hdev->sfr.kva is stored in DMA memory, and it is assigned to sfr, so sfr->buf_size can be modified at anytime by malicious hardware. In this case, a buffer overflow may happen when the code "sfr->data[sfr->buf_size - 1]" is executed. To fix this possible bug, sfr->buf_size is assigned

Re: [PATCH v2 2/2] regulator: Add support for sync_state() callbacks

2020-05-29 Thread Saravana Kannan
On Fri, May 29, 2020 at 6:00 AM Mark Brown wrote: > > On Thu, May 28, 2020 at 12:06:10PM -0700, Saravana Kannan wrote: > > When a regulator is left on by the bootloader or anything else before > > the kernel starts (let's call this a "boot on" regulator), we need to > > keep it on till all the con

Re: [net-next 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

2020-05-29 Thread Andrew Lunn
On Sat, May 30, 2020 at 03:46:22AM +0300, Vadym Kochan wrote: > Hi David, > > On Fri, May 29, 2020 at 05:18:39PM -0700, David Miller wrote: > > > > Please remove all of the __packed attributes. > > > > I looked at your data structures and all of them use fixed sized types > > and are multiples o

[PATCH v5 1/2] cpufreq: change '.set_boost' to act on only one policy

2020-05-29 Thread Xiongfeng Wang
Macro 'for_each_active_policy()' is defined internally. To avoid some cpufreq driver needing this macro to iterate over all the policies in '.set_boost' callback, we redefine '.set_boost' to act on only one policy and pass the policy as an argument. 'cpufreq_boost_trigger_state()' iterate over all

[PATCH v5 0/2] add SW BOOST support for CPPC

2020-05-29 Thread Xiongfeng Wang
ACPI spec 6.2 section 8.4.7.1 provide the following two CPC registers. "Highest performance is the absolute maximum performance an individual processor may reach, assuming ideal conditions. This performance level may not be sustainable for long durations, and may only be achievable if other platfo

[PATCH v5 2/2] CPPC: add support for SW BOOST

2020-05-29 Thread Xiongfeng Wang
To add SW BOOST support for CPPC, we need to get the max frequency of boost mode and non-boost mode. ACPI spec 6.2 section 8.4.7.1 describe the following two CPC registers. "Highest performance is the absolute maximum performance an individual processor may reach, assuming ideal conditions. This p

Re: [PATCH v8 17/18] KVM: x86: Add kexec support for SEV Live Migration.

2020-05-29 Thread Steve Rutherford
On Tue, May 5, 2020 at 2:21 PM Ashish Kalra wrote: > > From: Ashish Kalra > > Reset the host's page encryption bitmap related to kernel > specific page encryption status settings before we load a > new kernel by kexec. We cannot reset the complete > page encryption bitmap here as we need to retai

Re: [PATCH v8 18/18] KVM: SVM: Enable SEV live migration feature implicitly on Incoming VM(s).

2020-05-29 Thread Steve Rutherford
On Tue, May 5, 2020 at 2:22 PM Ashish Kalra wrote: > > From: Ashish Kalra > > For source VM, live migration feature is enabled explicitly > when the guest is booting, for the incoming VM(s) it is implied. > This is required for handling A->B->C->... VM migrations case. > > Signed-off-by: Ashish K

Re: [PATCH v8 16/18] KVM: x86: Mark _bss_decrypted section variables as decrypted in page encryption bitmap.

2020-05-29 Thread Steve Rutherford
On Tue, May 5, 2020 at 2:20 PM Ashish Kalra wrote: > > From: Ashish Kalra > > Ensure that _bss_decrypted section variables such as hv_clock_boot and > wall_clock are marked as decrypted in the page encryption bitmap if > sev liv migration is supported. > > Signed-off-by: Ashish Kalra > --- > ar

Re: [PATCH v8 14/18] EFI: Introduce the new AMD Memory Encryption GUID.

2020-05-29 Thread Steve Rutherford
On Tue, May 5, 2020 at 2:20 PM Ashish Kalra wrote: > > From: Ashish Kalra > > Introduce a new AMD Memory Encryption GUID which is currently > used for defining a new UEFI enviroment variable which indicates > UEFI/OVMF support for the SEV live migration feature. This variable > is setup when UEFI

Re: [PATCH v8 15/18] KVM: x86: Add guest support for detecting and enabling SEV Live Migration feature.

2020-05-29 Thread Steve Rutherford
On Tue, May 5, 2020 at 2:20 PM Ashish Kalra wrote: > > From: Ashish Kalra > > The guest support for detecting and enabling SEV Live migration > feature uses the following logic : > > - kvm_init_plaform() checks if its booted under the EFI > >- If not EFI, > > i) check for the KVM_FEATUR

Re: [PATCH v8 12/18] KVM: SVM: Add support for static allocation of unified Page Encryption Bitmap.

2020-05-29 Thread Steve Rutherford
On Tue, May 5, 2020 at 2:18 PM Ashish Kalra wrote: > > From: Ashish Kalra > > Add support for static allocation of the unified Page encryption bitmap by > extending kvm_arch_commit_memory_region() callack to add svm specific x86_ops > which can read the userspace provided memory region/memslots a

Re: [PATCH v8 13/18] KVM: x86: Introduce new KVM_FEATURE_SEV_LIVE_MIGRATION feature & Custom MSR.

2020-05-29 Thread Steve Rutherford
On Tue, May 5, 2020 at 2:19 PM Ashish Kalra wrote: > > From: Ashish Kalra > > Add new KVM_FEATURE_SEV_LIVE_MIGRATION feature for guest to check > for host-side support for SEV live migration. Also add a new custom > MSR_KVM_SEV_LIVE_MIG_EN for guest to enable the SEV live migration > feature. > >

Re: [PATCH v8 11/18] KVM: x86: Introduce KVM_SET_PAGE_ENC_BITMAP ioctl

2020-05-29 Thread Steve Rutherford
On Tue, May 5, 2020 at 2:18 PM Ashish Kalra wrote: > > From: Brijesh Singh > > The ioctl can be used to set page encryption bitmap for an > incoming guest. > > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: Paolo Bonzini > Cc: "Radim Krčmář" > Cc: Joerg Roedel > Cc: Bori

Re: [PATCH v8 10/18] mm: x86: Invoke hypercall when page encryption status is changed

2020-05-29 Thread Steve Rutherford
On Tue, May 5, 2020 at 2:18 PM Ashish Kalra wrote: > > From: Brijesh Singh > > Invoke a hypercall when a memory region is changed from encrypted -> > decrypted and vice versa. Hypervisor needs to know the page encryption > status during the guest migration. > > Cc: Thomas Gleixner > Cc: Ingo Mol

Re: [PATCH v8 08/18] KVM: X86: Introduce KVM_HC_PAGE_ENC_STATUS hypercall

2020-05-29 Thread Steve Rutherford
On Tue, May 5, 2020 at 2:17 PM Ashish Kalra wrote: > > From: Brijesh Singh > > This hypercall is used by the SEV guest to notify a change in the page > encryption status to the hypervisor. The hypercall should be invoked > only when the encryption attribute is changed from encrypted -> decrypted

Re: [PATCH 17/30] KVM: nSVM: synchronize VMCB controls updated by the processor on every vmexit

2020-05-29 Thread Krish Sadhukhan
On 5/29/20 8:39 AM, Paolo Bonzini wrote: The control state changes on every L2->L0 vmexit, and we will have to serialize it in the nested state. So keep it up to date in svm->nested.ctl and just copy them back to the nested VMCB in nested_svm_vmexit. Signed-off-by: Paolo Bonzini --- arch/x

Re: [PATCH v8 09/18] KVM: x86: Introduce KVM_GET_PAGE_ENC_BITMAP ioctl

2020-05-29 Thread Steve Rutherford
On Tue, May 5, 2020 at 2:17 PM Ashish Kalra wrote: > > From: Brijesh Singh > > The ioctl can be used to retrieve page encryption bitmap for a given > gfn range. > > Return the correct bitmap as per the number of pages being requested > by the user. Ensure that we only copy bmap->num_pages bytes i

Re: [PATCH v2] rtc: rv3028: Add missed check for devm_regmap_init_i2c()

2020-05-29 Thread Alexandre Belloni
On 28/05/2020 18:39:50+0800, Chuhong Yuan wrote: > rv3028_probe() misses a check for devm_regmap_init_i2c(). > Add the missed check to fix it. > > Fixes: e6e7376cfd7b ("rtc: rv3028: add new driver") > Signed-off-by: Chuhong Yuan > --- > Changes in v2: > - Add fixes tag. > > drivers/rtc/rtc-rv

Re: [PATCH] Revert "f2fs: fix quota_sync failure due to f2fs_lock_op"

2020-05-29 Thread Chao Yu
On 2020/5/30 9:49, Jaegeuk Kim wrote: > On 05/30, Chao Yu wrote: >> On 2020/5/30 6:34, Jaegeuk Kim wrote: >>> On 05/29, Chao Yu wrote: Under heavy fsstress, we may triggle panic while issuing discard, because __check_sit_bitmap() detects that discard command may earse valid data bloc

Re: [PATCH] rtc: rv3028: add the missed check for devm_regmap_init_i2c

2020-05-29 Thread Alexandre Belloni
On Wed, 27 May 2020 23:07:04 +0800, Chuhong Yuan wrote: > rv3028_probe() misses a check for devm_regmap_init_i2c(). > Add the missed check to fix it. Applied, thanks! [1/1] rtc: rv3028: add the missed check for devm_regmap_init_i2c Best regards, -- Alexandre Belloni

[PATCH net-next v3] hinic: add set_channels ethtool_ops support

2020-05-29 Thread Luo bin
add support to change TX/RX queue number with ethtool -L ethx combined Signed-off-by: Luo bin --- .../net/ethernet/huawei/hinic/hinic_ethtool.c | 40 +++ .../net/ethernet/huawei/hinic/hinic_main.c| 2 +- drivers/net/ethernet/huawei/hinic/hinic_tx.c | 5 +++ 3 files changed

Re: [PATCH] Revert "f2fs: fix quota_sync failure due to f2fs_lock_op"

2020-05-29 Thread Jaegeuk Kim
On 05/30, Chao Yu wrote: > On 2020/5/30 6:34, Jaegeuk Kim wrote: > > On 05/29, Chao Yu wrote: > >> Under heavy fsstress, we may triggle panic while issuing discard, > >> because __check_sit_bitmap() detects that discard command may earse > >> valid data blocks, the root cause is as below race stack

[PATCH v3] virtio_vsock: Fix race condition in virtio_transport_recv_pkt

2020-05-29 Thread Jia He
When client on the host tries to connect(SOCK_STREAM, O_NONBLOCK) to the server on the guest, there will be a panic on a ThunderX2 (armv8a server): [ 463.718844] Unable to handle kernel NULL pointer dereference at virtual address [ 463.718848] Mem abort info: [ 463.718849] E

  1   2   3   4   5   6   7   8   9   10   >