Re: [PATCH v2] mm/percpu: fix 'defined but not used' warning

2020-07-14 Thread Bixuan Cui
On 2020/7/15 2:41, Roman Gushchin wrote: >> Fixes: 26c99879ef01 ("mm: memcg/percpu: account percpu memory to memory >> cgroups") > The "fixes" tag is not valid: the patch is in the mm queue, so it doesn't > have a stable hash. Usually Andrew squashes such fixes into the original patch > on merg

[PATCH v3] mm/percpu: fix 'defined but not used' warning

2020-07-14 Thread Bixuan Cui
Gcc report the following warning without CONFIG_MEMCG_KMEM: mm/percpu-internal.h:145:29: warning: 'pcpu_chunk_type' defined but not used [-Wunused-function] static enum pcpu_chunk_type pcpu_chunk_type(struct pcpu_chunk *chunk) ^~~ Add 'inline' to pcpu_chu

Re: [PATCH] fbdev: Detect integer underflow at "struct fbcon_ops"->clear_margins.

2020-07-14 Thread Tetsuo Handa
On 2020/07/15 2:15, George Kennedy wrote: > Can you try the a.out built from the original Syzkaller modified repro C > program? It walks 0-7 through xres and yres of the fb_var_screeninfo struct. I'm not familiar with exploit code. What do you want to explain via this program? > struct fb_var

Re: [PATCH v3] Makefile: Add clang-tidy and static analyzer support to makefile

2020-07-14 Thread Nick Desaulniers
On Tue, Jul 14, 2020 at 4:24 PM 'Nathan Huckleberry' via Clang Built Linux wrote: > > This patch adds clang-tidy and the clang static-analyzer as make > targets. The goal of this patch is to make static analysis tools > usable and extendable by any developer or researcher who is familiar > with ba

Re: [PATCH v3 1/5] pinctrl: qcom: Remove irq_disable callback from msmgpio irqchip

2020-07-14 Thread Doug Anderson
Hi, On Tue, Jul 14, 2020 at 3:38 AM Maulik Shah wrote: > > Hi, > > On 7/14/2020 3:47 AM, Doug Anderson wrote: > > Hi, > > On Mon, Jun 22, 2020 at 2:32 AM Maulik Shah wrote: > > > > The gpio can be marked for wakeup and drivers can invoke disable_irq() > > > during suspend, in such cases unlazy a

Re: [PATCH v2] powercap: Add Power Limit4 support

2020-07-14 Thread Srinivas Pandruvada
On Tue, 2020-07-14 at 15:21 +0200, Rafael J. Wysocki wrote: > > [...] > On Tue, Jul 14, 2020 at 10:22 AM Sumeet Pawnikar > wrote: > > Srinivas, does the patch look good to you? Some minor comments then Summet can add my Reviewed-and-tested-by: Srinivas Pandruvada < srinivas.pandruv...@linux

Re: [PATCH 12/18] perf metric: Compute referenced metrics

2020-07-14 Thread Ian Rogers
On Sun, Jul 12, 2020 at 6:27 AM Jiri Olsa wrote: > > Adding computation (expr__parse call) of referenced metric at > the point when it needs to be resolved during the 'master' > metric computation. Same note on wrt master: https://www.kernel.org/doc/html/latest/process/coding-style.html?highlight

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-14 Thread Francisco Jerez
"Rafael J. Wysocki" writes: > From: Rafael J. Wysocki > > Allow intel_pstate to work in the passive mode with HWP enabled and > make it set the HWP minimum performance limit (HWP floor) to the > P-state value given by the target frequency supplied by the cpufreq > governor, so as to prevent the

Re: [PATCH 09/18] perf metric: Collect referenced metrics in struct metric_ref_node

2020-07-14 Thread Ian Rogers
On Sun, Jul 12, 2020 at 6:27 AM Jiri Olsa wrote: > > Collecting referenced metrics in struct metric_ref_node object, > so we can process them later on. > > The change will parse nested metric names out of expression and > 'resolve' them. > > All referenced metrics are dissolved into one context, m

Re: [PATCH v2 3/4] x86: Expose SERIALIZE for supported cpuid

2020-07-14 Thread Zhang, Cathy
On 7/15/2020 7:05 AM, h...@zytor.com wrote: On July 14, 2020 3:42:08 PM PDT, "Zhang, Cathy" wrote: On 7/14/2020 11:00 AM, Sean Christopherson wrote: On Tue, Jul 07, 2020 at 10:16:22AM +0800, Cathy Zhang wrote: SERIALIZE instruction is supported by intel processors, like Sapphire Rapids. Expos

Re: mmotm 2020-07-09-21-00 uploaded (drivers/net/ethernet/mellanox/mlx5/core/en_main.c)

2020-07-14 Thread Saeed Mahameed
On Sun, 2020-07-12 at 21:17 -0700, Randy Dunlap wrote: > On 7/12/20 9:02 PM, Stephen Rothwell wrote: > > Hi Randy, > > > > On Fri, 10 Jul 2020 10:40:29 -0700 Randy Dunlap < > > rdun...@infradead.org> wrote: > > > on i386: > > > > > > In file included from > > > ../drivers/net/ethernet/mellanox/ml

Re: [PATCH] Replace HTTP links with HTTPS ones: Xilinx video IP cores

2020-07-14 Thread Laurent Pinchart
Hi Alexander, Thank you for the patch. The subject line should be dt-bindings: media: xilinx: Replace HTTP links with HTTPS ones On Sun, Jul 05, 2020 at 09:55:24AM +0200, Alexander A. Klimov wrote: > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffi

Re: [PATCH v4 1/5] docs: IOMMU user API

2020-07-14 Thread Jacob Pan
On Tue, 14 Jul 2020 13:04:12 -0600 Alex Williamson wrote: > On Mon, 13 Jul 2020 22:00:23 -0700 > Jacob Pan wrote: > > > Hi Alex, > > > > On Mon, 13 Jul 2020 16:48:42 -0600 > > Alex Williamson wrote: > > > > > On Tue, 7 Jul 2020 16:43:45 -0700 > > > Jacob Pan wrote: > > > > > > > IOM

Re: [PATCH v2 1/1] phy: tusb1210: use bitmasks to set VENDOR_SPECIFIC2

2020-07-14 Thread kernel test robot
Hi Liam, Thank you for the patch! Yet something to improve: [auto build test ERROR on 8f3d9f354286745c751374f5f1fcafee6b3f3136] url: https://github.com/0day-ci/linux/commits/Liam-Beguin/phy-tusb1210-use-bitmasks-to-set-VENDOR_SPECIFIC2/20200715-003517 base:8f3d9f354286745c751374f5f1fcafe

Re: [PATCH v3 03/12] powerpc/kexec_file: add helper functions for getting memory ranges

2020-07-14 Thread Thiago Jung Bauermann
Hello Hari, Hari Bathini writes: > In kexec case, the kernel to be loaded uses the same memory layout as > the running kernel. So, passing on the DT of the running kernel would > be good enough. > > But in case of kdump, different memory ranges are needed to manage > loading the kdump kernel,

Re: [PATCH v2] staging: gasket: core: Fix a coding style issue in gasket_core.c

2020-07-14 Thread Zhixu Zhao
On Thu, Jun 18, 2020 at 12:11:27AM +0800, Zhixu Zhao wrote: > A coding alignment issue is found by checkpatch.pl. > Fix it by using a temporary for gasket_dev->bar_data[bar_num]. > > Signed-off-by: Zhixu Zhao Hi, there~ Does anybody have any further comments on this? Can it be merged? Zhixu

Re: [RFC PATCH 00/35] Move all PCIBIOS* definitions into arch/x86

2020-07-14 Thread Bjorn Helgaas
[+cc Kjetil] On Wed, Jul 15, 2020 at 12:01:56AM +0200, Arnd Bergmann wrote: > On Tue, Jul 14, 2020 at 8:45 PM Bjorn Helgaas wrote: > > On Mon, Jul 13, 2020 at 05:08:10PM +0200, Arnd Bergmann wrote: > > > On Mon, Jul 13, 2020 at 3:22 PM Saheed O. Bolarinwa > > > Starting with a), my first question

[PATCH v2] x86/entry: add compatibility with IAS

2020-07-14 Thread Jian Cai
Clang's integrated assembler does not allow symbols with non-absolute values to be reassigned. This patch allows the affected code to be compatible with IAS. Link: https://github.com/ClangBuiltLinux/linux/issues/1043 Reported-by: Nick Desaulniers Reported-by: Sedat Dilek Suggested-by: Nick Desau

[PATCH v2] x86/entry: add compatibility with IAS

2020-07-14 Thread Jian Cai
Clang's integrated assembler does not allow symbols with non-absolute values to be reassigned. This patch allows the affected code to be compatible with IAS. Link: https://github.com/ClangBuiltLinux/linux/issues/1043 Reported-by: Nick Desaulniers Reported-by: Sedat Dilek Suggested-by: Nick Desau

Re: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher

2020-07-14 Thread Westergreen, Dalon
On Tue, 2020-07-14 at 13:23 -0700, David Miller wrote: > From: "Westergreen, Dalon" > Date: Tue, 14 Jul 2020 18:51:15 + > > > I don't think this is necessary, i think just having a module parameter > > meets our needs. I don't see a need for the value to change on a per > > interface basis

[PATCH v3] Makefile: Add clang-tidy and static analyzer support to makefile

2020-07-14 Thread Nathan Huckleberry
This patch adds clang-tidy and the clang static-analyzer as make targets. The goal of this patch is to make static analysis tools usable and extendable by any developer or researcher who is familiar with basic c++. The current static analysis tools require intimate knowledge of the internal workin

Re: [PATCH v2] blk-rq-qos: remove redundant finish_wait to rq_qos_wait.

2020-07-14 Thread Qian Cai
On Sun, Jun 28, 2020 at 09:56:25AM -0400, Guo Xuenan wrote: > It is no need do finish_wait twice after acquiring inflight. > > Signed-off-by: Guo Xuenan > --- > block/blk-rq-qos.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/block/blk-rq-qos.c b/block/blk-rq-qos.c > index 656460636

Re: [PATCH v3] mm/hugetlb: split hugetlb_cma in nodes with memory

2020-07-14 Thread Mike Kravetz
On 7/10/20 5:09 AM, Barry Song wrote: > Online nodes are not necessarily memory containing nodes. Splitting > huge_cma in online nodes can lead to inconsistent hugetlb_cma size > with user setting. For example, for one system with 4 numa nodes and > only one of them has memory, if users set hugetlb

Re: [PATCH v4 4/4] thermal: core: Add notifications call in the framework

2020-07-14 Thread Daniel Lezcano
On 13/07/2020 22:32, Daniel Lezcano wrote: > On 13/07/2020 11:31, Marek Szyprowski wrote: >> Hi >> >> On 07.07.2020 11:15, Marek Szyprowski wrote: >>> On 06.07.2020 15:46, Daniel Lezcano wrote: On 06/07/2020 15:17, Marek Szyprowski wrote: > On 06.07.2020 12:55, Daniel Lezcano wrote: >>

Re: [PATCH v3 1/9] dt-bindings: reset: Add a binding for the RPi Firmware reset controller

2020-07-14 Thread Rob Herring
On Tue, Jul 14, 2020 at 3:18 PM Florian Fainelli wrote: > > > > On 7/14/2020 2:07 PM, Rob Herring wrote: > > On Tue, Jul 14, 2020 at 01:59:21PM +0200, Nicolas Saenz Julienne wrote: > >> On Mon, 2020-07-13 at 12:23 -0600, Rob Herring wrote: > >>> On Fri, Jun 12, 2020 at 07:13:25PM +0200, Nicolas Sa

Re: WARNING in __kernel_write

2020-07-14 Thread syzbot
syzbot has bisected this issue to: commit 81238b2cff1469ff5b94390d026cd075105d6dcd Author: Christoph Hellwig Date: Thu May 7 17:33:03 2020 + fs: implement kernel_write using __kernel_write bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=10d829bf10 start commit: be97

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-14 Thread John Paul Adrian Glaubitz
On 7/15/20 1:12 AM, John Paul Adrian Glaubitz wrote: > See the traces below and let me know what you think. (The second trace is redundant, I actually meant to post the two traces only and not the whole kernel boot sequence). Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer

Re: [RFC PATCH 00/35] Move all PCIBIOS* definitions into arch/x86

2020-07-14 Thread Rob Herring
On Tue, Jul 14, 2020 at 12:45 PM Bjorn Helgaas wrote: > > [trimmed the cc list; it's still too large but maybe arch folks care] > > On Mon, Jul 13, 2020 at 05:08:10PM +0200, Arnd Bergmann wrote: > > On Mon, Jul 13, 2020 at 3:22 PM Saheed O. Bolarinwa > > wrote: > > > This goal of these series is

[PATCH 3/3 v2] usb: typec: tcpm: Stay in BIST mode till hardreset or unattached

2020-07-14 Thread Badhri Jagan Sridharan
Port starts to toggle when transitioning to unattached state. This is incorrect while in BIST mode. 6.4.3.1 BIST Carrier Mode Upon receipt of a BIST Message, with a BIST Carrier Mode BIST Data Object, the UUT Shall send out a continuous string of BMC encoded alternating "1"s and “0”s. The UUT Shal

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-14 Thread John Paul Adrian Glaubitz
Hello! I have applied Christoph's full series on top of Linus' tree and I can confirm that the kernel boots fine on my SH-7785LCR board. Thus, for the whole series of patches: Tested-by: John Paul Adrian Glaubitz However, independent of Christoph's series, the kernels throws two backtraces d

[PATCH 2/3 v2] usb: typec: tcpm: Support bist test data mode for compliance

2020-07-14 Thread Badhri Jagan Sridharan
TCPM supports BIST carried mode. PD compliance tests require BIST Test Data to be supported as well. Introducing set_bist_data callback to signal tcpc driver for configuring the port controller hardware to enable/disable BIST Test Data mode. Signed-off-by: Badhri Jagan Sridharan --- Version hist

[PATCH 1/3 v2] usb: typec: tcpci: Support BIST test data mode for compliance.

2020-07-14 Thread Badhri Jagan Sridharan
Quoting from TCPCI spec: "Setting this bit to 1 is intended to be used only when a USB compliance tester is using USB BIST Test Data to test the PHY layer of the TCPC. The TCPM should clear this bit when a disconnect is detected. 0: Normal Operation. Incoming messages enabled by RECEIVE_DETECT pass

[PATCH V2] md: fix deadlock causing by sysfs_notify

2020-07-14 Thread Junxiao Bi
The following deadlock was captured. The first process is holding 'kernfs_mutex' and hung by io. The io was staging in 'r1conf.pending_bio_list' of raid1 device, this pending bio list would be flushed by second process 'md127_raid1', but it was hung by 'kernfs_mutex'. Using sysfs_notify_dirent_safe

Re: [PATCH v2 1/2] PCI/ERR: Fix fatal error recovery for non-hotplug capable devices

2020-07-14 Thread Bjorn Helgaas
On Thu, Jun 04, 2020 at 02:50:01PM -0700, sathyanarayanan.kuppusw...@linux.intel.com wrote: > From: Kuppuswamy Sathyanarayanan > > Fatal (DPC) error recovery is currently broken for non-hotplug > capable devices. With current implementation, after successful > fatal error recovery, non-hotplug c

Re: [PATCH v2 3/4] x86: Expose SERIALIZE for supported cpuid

2020-07-14 Thread hpa
On July 14, 2020 3:42:08 PM PDT, "Zhang, Cathy" wrote: >On 7/14/2020 11:00 AM, Sean Christopherson wrote: >> On Tue, Jul 07, 2020 at 10:16:22AM +0800, Cathy Zhang wrote: >>> SERIALIZE instruction is supported by intel processors, >>> like Sapphire Rapids. Expose it in KVM supported cpuid. >> Provi

Re: [PATCH v2 24/24] scsi: aic7xxx: aic79xx_osm: Remove set but unused variabes 'saved_scsiid' and 'saved_modes'

2020-07-14 Thread James Bottomley
On Tue, 2020-07-14 at 22:39 +0100, Lee Jones wrote: > On Tue, 14 Jul 2020, James Bottomley wrote: > > > On Tue, 2020-07-14 at 09:46 +0200, Hannes Reinecke wrote: > > > On 7/13/20 10:00 AM, Lee Jones wrote: > > > > Haven't been used since 2006. > > > > > > > > Fixes the following W=1 kernel build

Re: [PATCH] Drivers: hv: vmbus: Copy packets sent by Hyper-V out of the ring buffer

2020-07-14 Thread kernel test robot
Hi Andres, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on next-20200714] [cannot apply to mkp-scsi/for-next scsi/for-next linux/master linus/master v5.8-rc5 v5.8-rc4 v5.8-rc3 v5.8-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note

Re: [Freedreno] [PATCH 0/9] drm/msm: Avoid possible infinite probe deferral and speed booting

2020-07-14 Thread Bjorn Andersson
On Tue 14 Jul 15:13 PDT 2020, Rob Herring wrote: > On Tue, Jul 14, 2020 at 10:33 AM Jeffrey Hugo > wrote: > > > > On Mon, Jul 13, 2020 at 5:50 PM Doug Anderson wrote: > > > > > > Hi, > > > > > > On Mon, Jul 13, 2020 at 1:25 PM Rob Herring wrote: > > > > > > > > On Mon, Jul 13, 2020 at 9:08 AM

Re: [PATCH v5 0/4] nvmem: qfprom: Patches for fuse blowing on Qualcomm SoCs

2020-07-14 Thread Doug Anderson
Srinivas, On Fri, Jul 10, 2020 at 7:35 AM Douglas Anderson wrote: > > This series enables blowing of fuses on Qualcomm SoCs by extending the > existing qfprom driver with write support. > > A few notes: > - Though I don't have any firsthand knowledge of it, it's my > understanding that these ch

Re: [PATCH v2 3/4] x86: Expose SERIALIZE for supported cpuid

2020-07-14 Thread Zhang, Cathy
On 7/14/2020 11:00 AM, Sean Christopherson wrote: On Tue, Jul 07, 2020 at 10:16:22AM +0800, Cathy Zhang wrote: SERIALIZE instruction is supported by intel processors, like Sapphire Rapids. Expose it in KVM supported cpuid. Providing at least a rough overview of the instruction, e.g. its enumera

Re: [PATCH] leds: add NCT6795D driver

2020-07-14 Thread Pavel Machek
Hi! > Add support for the LED feature of the NCT6795D chip found on some > motherboards, notably MSI ones. The LEDs are typically used using a > RGB connector so this driver creates one LED device for each color > component. Ok, let me take a look. What entries does it present in /sys? We'll wan

[PATCH v3 1/3] kprobes: Add text_alloc() and text_free()

2020-07-14 Thread Jarkko Sakkinen
Introduce new API for allocating space for code generaed at run-time leveraging from module_alloc() and module_memfree() code. Use this to perform memory allocations in the kprobes code in order to loose the bound between kprobes and modules subsystem. Initially, use this API only with arch/x86 an

[PATCH v3 3/3] kprobes: Flag out CONFIG_MODULES dependent code

2020-07-14 Thread Jarkko Sakkinen
Remove CONFIG_MODULES dependency by flagging out the dependent code. This allows to use kprobes in a kernel without support for loadable modules, which could be useful for a test kernel or perhaps an embedded kernel. Cc: Andi Kleen Signed-off-by: Jarkko Sakkinen --- include/linux/module.h

[PATCH v3 2/3] module: Add lock_modules() and unlock_modules()

2020-07-14 Thread Jarkko Sakkinen
Add wrappers to take the modules "big lock" in order to encapsulate conditional compilation (CONFIG_MODULES) inside the wrapper. Cc: Andi Kleen Suggested-by: Masami Hiramatsu Signed-off-by: Jarkko Sakkinen --- include/linux/module.h | 15 ++ kernel/kprobes.c| 4 +-- k

[PATCH v3 0/3] kprobes: Remove MODULES dependency

2020-07-14 Thread Jarkko Sakkinen
Remove MODULES dependency and migrate from module_alloc to the new text_alloc() API Right now one has to compile LKM support only to enable kprobes. With this change applied, it is somewhat easier to create custom test kernel's with a proper debugging capabilities, thus making Linux more developer

Re: [PATCH] ksz884x: switch from 'pci_' to 'dma_' API

2020-07-14 Thread David Miller
From: Christophe JAILLET Date: Tue, 14 Jul 2020 20:35:01 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [Freedreno] [PATCH 0/9] drm/msm: Avoid possible infinite probe deferral and speed booting

2020-07-14 Thread Rob Herring
On Tue, Jul 14, 2020 at 10:33 AM Jeffrey Hugo wrote: > > On Mon, Jul 13, 2020 at 5:50 PM Doug Anderson wrote: > > > > Hi, > > > > On Mon, Jul 13, 2020 at 1:25 PM Rob Herring wrote: > > > > > > On Mon, Jul 13, 2020 at 9:08 AM Doug Anderson > > > wrote: > > > > > > > > Hi, > > > > > > > > On Mon

Re: [PATCH] selftests: fib_nexthop_multiprefix: fix cleanup() netns deletion

2020-07-14 Thread David Miller
From: Paolo Pisati Date: Tue, 14 Jul 2020 17:40:55 +0200 > During setup(): > ... > for ns in h0 r1 h1 h2 h3 > do > create_ns ${ns} > done > ... > > while in cleanup(): > ... > for n in h1 r1 h2 h3 h4 > do > ip netns del ${n}

[PATCH 5/5] media/v4l2-subdev.h: drop duplicated word in comment

2020-07-14 Thread Randy Dunlap
Delete the doubled words "the" in comments. Signed-off-by: Randy Dunlap Cc: Mauro Carvalho Chehab Cc: linux-me...@vger.kernel.org --- include/media/v4l2-subdev.h |8 1 file changed, 4 insertions(+), 4 deletions(-) --- linux-next-20200714.orig/include/media/v4l2-subdev.h

[PATCH 2/5] media/media-devnode.h: drop duplicated word in comment

2020-07-14 Thread Randy Dunlap
Delete the doubled word "the" in a comment. Signed-off-by: Randy Dunlap Cc: Mauro Carvalho Chehab Cc: linux-me...@vger.kernel.org --- include/media/media-devnode.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200714.orig/include/media/media-devnode.h

[PATCH 4/5] media/media-entity.h: drop duplicated word in comment

2020-07-14 Thread Randy Dunlap
Delete the doubled word "flag" in a comment. Signed-off-by: Randy Dunlap Cc: Mauro Carvalho Chehab Cc: linux-me...@vger.kernel.org --- include/media/media-entity.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200714.orig/include/media/media-entity.h +++

[PATCH 1/5] media/media-device.h: drop duplicated word in comment

2020-07-14 Thread Randy Dunlap
Delete the doubled word "the" in a comment. Signed-off-by: Randy Dunlap Cc: Mauro Carvalho Chehab Cc: linux-me...@vger.kernel.org --- include/media/media-device.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200714.orig/include/media/media-device.h +++

[PATCH 3/5] media/dvbdev.h: fix duplicated word in comment

2020-07-14 Thread Randy Dunlap
Change the doubled word "the" in a comment to "to the". Signed-off-by: Randy Dunlap Cc: Mauro Carvalho Chehab Cc: linux-me...@vger.kernel.org --- include/media/dvbdev.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200714.orig/include/media/dvb

Re: [RFC PATCH 00/35] Move all PCIBIOS* definitions into arch/x86

2020-07-14 Thread Arnd Bergmann
On Tue, Jul 14, 2020 at 8:45 PM Bjorn Helgaas wrote: > On Mon, Jul 13, 2020 at 05:08:10PM +0200, Arnd Bergmann wrote: > > On Mon, Jul 13, 2020 at 3:22 PM Saheed O. Bolarinwa > > Starting with a), my first question is whether any high-level > > drivers even need to care about errors from these func

Re: [PATCH] CREDITS: remove link http://www.dementia.org/~shadow

2020-07-14 Thread Randy Dunlap
On 7/14/20 2:47 PM, Jonathan Corbet wrote: > On Tue, 14 Jul 2020 21:38:05 +0200 > "Alexander A. Klimov" wrote: > >> Rationale: >> The way it redirects looks like a fallback from a dead URL to a generic one. >> >> Signed-off-by: Alexander A. Klimov >> --- >> Yes, I noted that some of the links r

Re: [PATCH 7/7] exec: Implement kernel_execve

2020-07-14 Thread Kees Cook
On Tue, Jul 14, 2020 at 08:31:40AM -0500, Eric W. Biederman wrote: > +static int count_strings_kernel(const char *const *argv) > +{ > + int i; > + > + if (!argv) > + return 0; > + > + for (i = 0; argv[i]; ++i) { > + if (i >= MAX_ARG_STRINGS) > +

Re: [PATCH] CREDITS: remove link http://www.dementia.org/~shadow

2020-07-14 Thread Jonathan Corbet
On Tue, 14 Jul 2020 21:38:05 +0200 "Alexander A. Klimov" wrote: > Rationale: > The way it redirects looks like a fallback from a dead URL to a generic one. > > Signed-off-by: Alexander A. Klimov > --- > Yes, I noted that some of the links removed by these "CREDITS: remove link:" > patches hav

Re: [PATCH v7 2/7] lib: add zstd support to decompress

2020-07-14 Thread Arvind Sankar
On Wed, Jul 08, 2020 at 11:50:19AM -0700, Nick Terrell wrote: > From: Nick Terrell > > * Add unzstd() and the zstd decompress interface. > * Add zstd support to decompress_method(). > > The decompress_method() and unzstd() functions are used to decompress > the initramfs and the initrd. The __de

Re: [PATCH 6/7] exec: Factor bprm_stack_limits out of prepare_arg_pages

2020-07-14 Thread Kees Cook
On Tue, Jul 14, 2020 at 08:31:03AM -0500, Eric W. Biederman wrote: > > In preparation for implementiong kernel_execve (which will take kernel > pointers not userspace pointers) factor out bprm_stack_limits out of > prepare_arg_pages. This separates the counting which depends upon the > getting da

Re: [PATCH v2 24/24] scsi: aic7xxx: aic79xx_osm: Remove set but unused variabes 'saved_scsiid' and 'saved_modes'

2020-07-14 Thread Lee Jones
On Tue, 14 Jul 2020, James Bottomley wrote: > On Tue, 2020-07-14 at 09:46 +0200, Hannes Reinecke wrote: > > On 7/13/20 10:00 AM, Lee Jones wrote: > > > Haven't been used since 2006. > > > > > > Fixes the following W=1 kernel build warning(s): > > > > > > drivers/scsi/aic7xxx/aic79xx_osm.c: In f

[PATCH v2] mei: Avoid the use of one-element arrays

2020-07-14 Thread Gustavo A. R. Silva
One-element arrays are being deprecated[1]. Replace the one-element arrays with a simple value type u8 reserved, once this is just a placeholder for alignment. Also, while there, use the preferred form for passing a size of a struct. The alternative form where struct name is spelled out hurts read

Re: [RFC PATCH 0/4] thermal: Introduce support for monitoring falling temperature

2020-07-14 Thread Thara Gopinath
On 7/14/20 9:49 AM, Zhang Rui wrote: On Mon, 2020-07-13 at 17:03 +0200, Daniel Lezcano wrote: On 10/07/2020 15:51, Thara Gopinath wrote: Thermal framework today supports monitoring for rising temperatures and subsequently initiating cooling action in case of a thermal trip point being crosse

Re: [PATCH 3/7] exec: Move initialization of bprm->filename into alloc_bprm

2020-07-14 Thread Kees Cook
On Tue, Jul 14, 2020 at 08:29:36AM -0500, Eric W. Biederman wrote: > > Currently it is necessary for the usermode helper code and the code > that launches init to use set_fs so that pages coming from the kernel > look like they are coming from userspace. > > To allow that usage of set_fs to be re

Re: [PATCH 2/7] exec: Factor out alloc_bprm

2020-07-14 Thread Kees Cook
On Tue, Jul 14, 2020 at 08:29:05AM -0500, Eric W. Biederman wrote: > > Currently it is necessary for the usermode helper code and the code > that launches init to use set_fs so that pages coming from the kernel > look like they are coming from userspace. > > To allow that usage of set_fs to be re

Re: [PATCH 1/7] exec: Remove unnecessary spaces from binfmts.h

2020-07-14 Thread Kees Cook
On Tue, Jul 14, 2020 at 08:28:42AM -0500, Eric W. Biederman wrote: > > The general convention in the linux kernel is to define a pointer > member as "type *name". The declaration of struct linux_binprm has > several pointer defined as "type * name". Update them to the > form of "type *name" for

Re: [PATCH 5/7] exec: Factor bprm_execve out of do_execve_common

2020-07-14 Thread Kees Cook
On Tue, Jul 14, 2020 at 08:30:30AM -0500, Eric W. Biederman wrote: > > Currently it is necessary for the usermode helper code and the code > that launches init to use set_fs so that pages coming from the kernel > look like they are coming from userspace. > > To allow that usage of set_fs to be re

Re: [PATCH v3 2/2] riscv: Enable per-task stack canaries

2020-07-14 Thread Palmer Dabbelt
On Fri, 10 Jul 2020 09:19:58 PDT (-0700), guo...@kernel.org wrote: From: Guo Ren This enables the use of per-task stack canary values if GCC has support for emitting the stack canary reference relative to the value of tp, which holds the task struct pointer in the riscv kernel. After compare a

Re: [PATCH 4/7] exec: Move bprm_mm_init into alloc_bprm

2020-07-14 Thread Kees Cook
On Tue, Jul 14, 2020 at 08:30:02AM -0500, Eric W. Biederman wrote: > > Currently it is necessary for the usermode helper code and the code that > launches init to use set_fs so that pages coming from the kernel look like > they are coming from userspace. > > To allow that usage of set_fs to be re

Re: [PATCH 09/13] cpufreq: acpi-cpufreq: Remove unused ID structs

2020-07-14 Thread Lee Jones
On Tue, 14 Jul 2020, Rafael J. Wysocki wrote: > On Tue, Jul 14, 2020 at 4:51 PM Lee Jones wrote: > > > > Can't see them being used anywhere and the compiler doesn't complain > > that they're missing, so ... > > Aren't they needed for automatic module loading in certain configurations? Any idea

Re: [RFC PATCH 2/4] rseq: Allow extending struct rseq

2020-07-14 Thread Carlos O'Donell
On 7/14/20 9:19 AM, Mathieu Desnoyers wrote: > Is there an arch-agnostic way to get the thread pointer from user-space code > ? That > would be needed by all rseq critical section implementations. Yes, and no. We have void *__builtin_thread_pointer (void), but few architectures implement the buil

[PATCH v2] Bluetooth: Add per-instance adv disable/remove

2020-07-14 Thread Daniel Winkler
Add functionality to disable and remove advertising instances, and use that functionality in MGMT add/remove advertising calls. Signed-off-by: Daniel Winkler Reviewed-by: Shyh-In Hwang Reviewed-by: Alain Michaud --- Hi Maintainers, Currently, advertising is globally-disabled, i.e. all instance

[PATCH] riscv: Select ARCH_HAS_DEBUG_VM_PGTABLE

2020-07-14 Thread Emil Renner Berthing
This allows the pgtable tests to be built. Signed-off-by: Emil Renner Berthing --- The tests seem to succeed both in Qemu and on the HiFive Unleashed Both with and without the recent additions in https://lore.kernel.org/linux-riscv/1594610587-4172-1-git-send-email-anshuman.khand...@arm.com/ D

Re: [PATCH 01/18] perf metric: Rename expr__add_id to expr__add_val

2020-07-14 Thread Ian Rogers
On Sun, Jul 12, 2020 at 6:26 AM Jiri Olsa wrote: > > Renaming expr__add_id to expr__add_val so we can use > expr__add_id to actually add just id without any value > in following changes. > > There's no functional change. > > Signed-off-by: Jiri Olsa Acked-by: Ian Rogers Thanks, Ian > --- > t

Re: [PATCH 13/13] cpufreq: amd_freq_sensitivity: Remove unused ID structs

2020-07-14 Thread Lee Jones
On Tue, 14 Jul 2020, Kim Phillips wrote: > On 7/14/20 9:50 AM, Lee Jones wrote: > > Can't see them being used anywhere and the compiler doesn't complain > > that they're missing, so ... > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/cpufreq/amd_freq_sensitivity.c:147:3

[PATCH] staging: rtl8188eu: core: fix coding style issues

2020-07-14 Thread Arpitha
Fixing WARNING: Prefer using '"%s...", __func__' to using 'function_name' in a string in rtw_ioctl_set.c Signed-off-by: Arpitha <98.a...@gmail.com> --- drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl

Re: [PATCH 12/13] cpufreq: intel_pstate: Supply struct attribute description for get_aperf_mperf_shift()

2020-07-14 Thread Lee Jones
On Tue, 14 Jul 2020, Rafael J. Wysocki wrote: > On Tue, Jul 14, 2020 at 4:51 PM Lee Jones wrote: > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/cpufreq/intel_pstate.c:293: warning: Function parameter or member > > 'get_aperf_mperf_shift' not described in 'pstate_funcs'

Re: [PATCH 10/25] pinctrl: mediatek: pinctrl-mtk-common-v2: Mark 'mtk_default_register_base_names' as __maybe_unused

2020-07-14 Thread Sean Wang
On Mon, Jul 13, 2020 at 7:49 AM Lee Jones wrote: > > Not all sourcefiles which end up including pinctrl-mtk-common-v2.h make use > of 'mtk_default_register_base_names' and there is nowhere we can place the > definition to void the need for __maybe_unused except its own headerfile, > which seems li

Re: [PATCH] x86/bugs/multihit: Fix mitigation reporting when KVM is not in use

2020-07-14 Thread Dave Hansen
On 7/14/20 2:04 PM, Pawan Gupta wrote: >> I see three inputs and four possible states (sorry for the ugly table, >> it was this or a spreadsheet :): >> >> X86_FEATURE_VMX CONFIG_KVM_*hpage split ResultReason >> N x xNot Affected No VMX

[PATCH v3 2/2] block: add max_active_zones to blk-sysfs

2020-07-14 Thread Niklas Cassel
Add a new max_active zones definition in the sysfs documentation. This definition will be common for all devices utilizing the zoned block device support in the kernel. Export max_active_zones according to this new definition for NVMe Zoned Namespace devices, ZAC ATA devices (which are treated as

[PATCH v3 1/2] block: add max_open_zones to blk-sysfs

2020-07-14 Thread Niklas Cassel
Add a new max_open_zones definition in the sysfs documentation. This definition will be common for all devices utilizing the zoned block device support in the kernel. Export max open zones according to this new definition for NVMe Zoned Namespace devices, ZAC ATA devices (which are treated as SCSI

[PATCH v3 0/2] Export max open zones and max active zones to sysfs

2020-07-14 Thread Niklas Cassel
Export max open zones and max active zones to sysfs. This patch series in based on Jens's linux-block/for-next branch. All zoned block devices in the kernel utilize the "zoned block device support" (CONFIG_BLK_DEV_ZONED). The Zoned Namespace Command Set Specification defines two different resour

Re: [PATCH v3 1/9] dt-bindings: reset: Add a binding for the RPi Firmware reset controller

2020-07-14 Thread Florian Fainelli
On 7/14/2020 2:07 PM, Rob Herring wrote: > On Tue, Jul 14, 2020 at 01:59:21PM +0200, Nicolas Saenz Julienne wrote: >> On Mon, 2020-07-13 at 12:23 -0600, Rob Herring wrote: >>> On Fri, Jun 12, 2020 at 07:13:25PM +0200, Nicolas Saenz Julienne wrote: The firmware running on the RPi VideoCore c

Re: [PATCH] gianfar: Use random MAC address when none is given

2020-07-14 Thread David Miller
From: Maxim Kochetkov Date: Tue, 14 Jul 2020 15:01:04 +0300 > If there is no valid MAC address in the device tree, > use a random MAC address. > > Signed-off-by: Maxim Kochetkov Looks good, patch applied, thanks.

Re: [PATCH 3/3] ASoC: fsl-asoc-card: Support Headphone and Microphone Jack detection

2020-07-14 Thread Nicolin Chen
Hi Shengjiu, The whole series looks good to me. Just a couple of small questions inline: On Tue, Jul 14, 2020 at 05:05:36PM +0800, Shengjiu Wang wrote: > Use asoc_simple_init_jack function from simple card to implement > the Headphone and Microphone detection. > Register notifier to disable Speak

Re: [PATCH 06/18] perf metric: Add find_metric function

2020-07-14 Thread Ian Rogers
On Sun, Jul 12, 2020 at 6:27 AM Jiri Olsa wrote: > > Decouple lookup metric logic into find_metric function, > so it can be used from other places in following changes. > > Signed-off-by: Jiri Olsa Acked-by: Ian Rogers Thanks, Ian > --- > tools/perf/util/metricgroup.c | 89 ++

[PATCH v1] Bluetooth: Add per-instance adv disable/remove

2020-07-14 Thread Daniel Winkler
Add functionality to disable and remove advertising instances, and use that functionality in MGMT add/remove advertising calls. Signed-off-by: Daniel Winkler Reviewed-by: Shyh-In Hwang Reviewed-by: Alain Michaud --- net/bluetooth/hci_conn.c| 2 +- net/bluetooth/hci_request.c | 59 +++

Re: [PATCH v2 18/29] scsi: aic7xxx: aic7xxx_osm: Remove unused variable 'tinfo'

2020-07-14 Thread Lee Jones
On Tue, 14 Jul 2020, Doug Ledford wrote: > On Mon, 2020-07-13 at 08:46 +0100, Lee Jones wrote: > > Looks like none of the artifact from ahc_fetch_transinfo() are used > > anymore. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/scsi/aic7xxx/aic7xxx_osm.c: In function >

Re: [PATCH 3/3] pinctrl: add pinctrl driver on mt8192

2020-07-14 Thread Sean Wang
On Fri, Jul 10, 2020 at 12:28 AM Zhiyong Tao wrote: > > This commit includes pinctrl driver for mt8192. > > Signed-off-by: Zhiyong Tao It is good to see the clean driver with mtk-common-v2. Acked-by: Sean Wang > --- > drivers/pinctrl/mediatek/Kconfig |7 + > drivers/pinctrl/

Re: [PATCH 13/13] cpufreq: amd_freq_sensitivity: Remove unused ID structs

2020-07-14 Thread Kim Phillips
On 7/14/20 4:02 PM, Lee Jones wrote: > On Tue, 14 Jul 2020, Kim Phillips wrote: >> On 7/14/20 9:50 AM, Lee Jones wrote: >>> Can't see them being used anywhere and the compiler doesn't complain >>> that they're missing, so ... >>> >>> Fixes the following W=1 kernel build warning(s): >>> >>> drivers

Re: [PATCH v3 3/7] dt-bindings: clock: Add Keem Bay clock IDs

2020-07-14 Thread Rob Herring
On Tue, Jul 14, 2020 at 05:13:01PM +0100, Daniele Alessandrelli wrote: > From: Daniele Alessandrelli > > Add clock dt-bindings for Keem Bay SoC. Where's the binding schema? > > Signed-off-by: Daniele Alessandrelli > --- > include/dt-bindings/clock/keembay-clocks.h | 188 +

Re: [PATCH] mm/hugetlb: hide nr_nodes in the internal of for_each_node_mask_to_[alloc|free]

2020-07-14 Thread Mike Kravetz
On 7/14/20 3:02 AM, Vlastimil Babka wrote: > On 7/14/20 11:57 AM, Wei Yang wrote: >> On Tue, Jul 14, 2020 at 11:22:03AM +0200, Vlastimil Babka wrote: >>> On 7/14/20 11:13 AM, Vlastimil Babka wrote: On 7/14/20 9:34 AM, Wei Yang wrote: > The second parameter of for_each_node_mask_to_[alloc|f

Re: [PATCH 08/18] perf metric: Rename __metricgroup__add_metric to __add_metric

2020-07-14 Thread Ian Rogers
On Sun, Jul 12, 2020 at 6:27 AM Jiri Olsa wrote: > > Renaming __metricgroup__add_metric to __add_metric > to fit in the current function names. > > Signed-off-by: Jiri Olsa Acked-by: Ian Rogers Thanks, Ian > --- > tools/perf/util/metricgroup.c | 17 ++--- > 1 file changed, 6 inse

Re: [PATCH 07/18] perf metric: Add add_metric function

2020-07-14 Thread Ian Rogers
On Sun, Jul 12, 2020 at 6:27 AM Jiri Olsa wrote: > > Decouple metric adding login into add_metric function, s/login/logging/ ? > so it can be used from other places in following changes. > > Signed-off-by: Jiri Olsa Acked-by: Ian Rogers Thanks, Ian > --- > tools/perf/util/metricgroup.c | 4

Re: [PATCH v3 2/7] dt-bindings: arm: Add Keem Bay bindings

2020-07-14 Thread Rob Herring
On Tue, Jul 14, 2020 at 05:13:00PM +0100, Daniele Alessandrelli wrote: > From: Daniele Alessandrelli > > Document Intel Movidius SoC code-named Keem Bay, along with the Keem Bay > EVM board. > > Reviewed-by: Dinh Nguyen > Signed-off-by: Daniele Alessandrelli > --- > .../devicetree/bindings/ar

Re: [PATCH] hippi: Fix a size used in a 'pci_free_consistent()' in an error handling path

2020-07-14 Thread David Miller
From: Christophe JAILLET Date: Tue, 14 Jul 2020 13:00:27 +0200 > The size used when calling 'pci_alloc_consistent()' and > 'pci_free_consistent()' should match. > > Fix it and have it consistent with the corresponding call in 'rr_close()'. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-o

Re: [PATCH v12 2/2] PCI: hip: Add handling of HiSilicon HIP PCIe controller errors

2020-07-14 Thread Bjorn Helgaas
[+cc Lorenzo] On Mon, Jul 13, 2020 at 03:10:19PM +0100, Shiju Jose wrote: > From: Yicong Yang > > The HiSilicon HIP PCIe controller is capable of handling errors > on root port and perform port reset separately at each root port. s/perform/performing/ (to match "handling") > Add error handling

Re: [PATCH] x86/bugs/multihit: Fix mitigation reporting when KVM is not in use

2020-07-14 Thread Pawan Gupta
On Tue, Jul 14, 2020 at 12:54:26PM -0700, Dave Hansen wrote: > On 7/14/20 12:17 PM, Pawan Gupta wrote: > > On Tue, Jul 14, 2020 at 07:57:53AM -0700, Dave Hansen wrote: > >> Let's stick to things which are at least static per reboot. Checking > >> for X86_FEATURE_VMX or even CONFIG_KVM_INTEL seems

Re: [PATCH] fs/9p: Fix TCREATE's fid in protocol

2020-07-14 Thread Victor Hsieh
Please disregard this patch. I misunderstood the protocol and have found the actual problem in the hypervisor's 9P implementation. Sorry about the noise. On Tue, Jul 14, 2020 at 1:54 PM Eric Biggers wrote: > > On Tue, Jul 14, 2020 at 02:12:49PM +0200, Dominique Martinet wrote: > > > > > Fixes:

Re: [PATCH v5 07/13] pwm: add support for sl28cpld PWM controller

2020-07-14 Thread Michael Walle
Hi Uwe, Am 2020-07-14 18:08, schrieb Uwe Kleine-König: On Tue, Jul 14, 2020 at 01:31:13PM +0200, Michael Walle wrote: Am 2020-07-13 10:47, schrieb Uwe Kleine-König: > I already thought about proposing pwm_get_rate_hw(), but for now there > is (AFAICT) no user who would need it. And it's hard to

Re: [PATCH] net: neterion: vxge: switch from 'pci_' to 'dma_' API

2020-07-14 Thread David Miller
From: Christophe JAILLET Date: Tue, 14 Jul 2020 11:14:12 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below. No GFP_ > flag needs to be corrected. > It has been compile tested. ... > Signed-off-by: Christophe

<    1   2   3   4   5   6   7   8   9   10   >