Re: [PATCH 4.19 000/133] 4.19.134-rc1 review

2020-07-21 Thread Pavel Machek
Hi! > This is the start of the stable review cycle for the 4.19.134 release. > There are 133 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses should be made by Wed, 22 Jul 2020 15:27:31

Re: [PATCH v2 1/8] usb: dwc2: gadget: Make use of GINTMSK2

2020-07-21 Thread Felipe Balbi
Hi, Lee Jones writes: > On Tue, 21 Jul 2020, Felipe Balbi wrote: > >> Minas Harutyunyan writes: >> >> > Hi Felipe, >> > >> > On 7/21/2020 1:43 PM, Felipe Balbi wrote: >> >> Minas Harutyunyan writes: >> >> >> >>> On 7/15/2020 1:32 PM, Lee Jones wrote: >> The value obtained from GINTSTS2

Re: WARNING in pvr2_i2c_core_done

2020-07-21 Thread B K Karthik
On Tue, Jul 21, 2020 at 4:50 PM syzbot wrote: > > Hello, > > syzbot has tested the proposed patch but the reproducer is still triggering > an issue: > general protection fault in kernfs_find_ns > > pvrusb2: Invalid write control endpoint > pvrusb2: Invalid write control endpoint > pvrusb2:

Re: [PATCH 4.19 094/133] USB: serial: iuu_phoenix: fix memory corruption

2020-07-21 Thread Johan Hovold
On Tue, Jul 21, 2020 at 01:33:00PM +0200, Pavel Machek wrote: > Hi! > > > commit e7b931bee739e8a77ae216e613d3b99342b6dec0 upstream. > > > > The driver would happily overwrite its write buffer with user data in > > 256 byte increments due to a removed buffer-space sanity check. > > > +++

Re: [PATCH v5 0/8] Enable ili9341 and l3gd20 on stm32f429-disco

2020-07-21 Thread Alexandre Torgue
On 7/21/20 12:39 PM, dillon min wrote: Hi Alexandre, On Tue, Jul 21, 2020 at 5:19 PM Alexandre Torgue wrote: Hi Dillon On 5/25/20 5:40 AM, dillon.min...@gmail.com wrote: From: dillon min V5's update based on Mark Brown's suggestion, use 'SPI_MASTER_MUST_RX' for SPI_SIMPLEX_RX mode on

Re: [PATCH] serial: 8250: fix null-ptr-deref in serial8250_start_tx()

2020-07-21 Thread Yang Yingliang
On 2020/7/21 18:48, Greg KH wrote: On Tue, Jul 21, 2020 at 02:38:52PM +, Yang Yingliang wrote: I got null-ptr-deref in serial8250_start_tx(): [ 78.114630] Unable to handle kernel NULL pointer dereference at virtual address [ 78.123778] Mem abort info: [ 78.126560]

Re: [PATCH v5 00/11] Add ASoC AHUB components for Tegra210 and later

2020-07-21 Thread Sameer Pujar
Hi Mark, On 7/20/2020 8:08 PM, Mark Brown wrote: External email: Use caution opening links or attachments On Sun, 19 Jul 2020 10:31:19 +0530, Sameer Pujar wrote: Overview Audio Processing Engine (APE) comprises of Audio DMA (ADMA) and Audio Hub (AHUB) unit. AHUB is a collection of

Re: [PATCH v2 1/8] usb: dwc2: gadget: Make use of GINTMSK2

2020-07-21 Thread Lee Jones
On Tue, 21 Jul 2020, Felipe Balbi wrote: > Minas Harutyunyan writes: > > > Hi Felipe, > > > > On 7/21/2020 1:43 PM, Felipe Balbi wrote: > >> Minas Harutyunyan writes: > >> > >>> On 7/15/2020 1:32 PM, Lee Jones wrote: > The value obtained from GINTSTS2 should be masked with the GINTMSK2 >

[PATCH 2/3] docs: staging/kprobes.rst: Move references to a separate appendix

2020-07-21 Thread Naveen N. Rao
Kprobes references are currently listed right after kretprobes example, and appears to be part of the same section. Move this out to a separate appendix for clarity. Signed-off-by: Naveen N. Rao --- Documentation/staging/kprobes.rst | 14 +- 1 file changed, 9 insertions(+), 5

Re: [PATCH 4.19 123/133] thermal/drivers/cpufreq_cooling: Fix wrong frequency converted from power

2020-07-21 Thread Pavel Machek
Hi! > From: Finley Xiao > > commit 371a3bc79c11b707d7a1b7a2c938dc3cc042fffb upstream. > > The function cpu_power_to_freq is used to find a frequency and set the > cooling device to consume at most the power to be converted. For example, > if the power to be converted is 80mW, and the em table

[PATCH 3/3] docs: Move kprobes.rst from staging/ to trace/

2020-07-21 Thread Naveen N. Rao
Kprobes contitutes a dynamic tracing technology and as such can be moved alongside documentation of other tracing technologies. Signed-off-by: Naveen N. Rao --- Documentation/staging/index.rst | 1 - Documentation/trace/index.rst| 1 + Documentation/{staging =>

[PATCH 0/3] docs: kprobes: Update URLs and move under trace/

2020-07-21 Thread Naveen N. Rao
This series updates some of the URLs in the kprobes document and moves the same under trace/ directory. - Naveen Naveen N. Rao (3): docs: staging/kprobes.rst: Update some of the references docs: staging/kprobes.rst: Move references to a separate appendix docs: Move kprobes.rst from

[PATCH 1/3] docs: staging/kprobes.rst: Update some of the references

2020-07-21 Thread Naveen N. Rao
Some of the kprobes references are not valid anymore. Update the URLs to point to their changed locations, where appropriate. Drop two URLs which do not exist anymore. Reported-by: Masami Hiramatsu Signed-off-by: Naveen N. Rao --- Documentation/staging/kprobes.rst | 6 ++ 1 file changed, 2

Re: [PATCH v4 2/4] clocksource/drivers: Add CLINT timer driver

2020-07-21 Thread Anup Patel
On Tue, Jul 21, 2020 at 4:32 PM Daniel Lezcano wrote: > > On 17/07/2020 09:50, Anup Patel wrote: > > We add a separate CLINT timer driver for Linux RISC-V M-mode (i.e. > > RISC-V NoMMU kernel). > > > > The CLINT MMIO device provides three things: > > 1. 64bit free running counter register > > 2.

Re: Speaker pops with max98357a on rk3399-gru-kevin since v5.7

2020-07-21 Thread Tzung-Bi Shih
On Tue, Jul 21, 2020 at 6:40 AM Alper Nebi Yasak wrote: > > On 17/07/2020 05:27, Tzung-Bi Shih wrote: > > I am not convinced the pop comes from 128f825aeab7. > > Maybe some pre-existing defect in rk3399_gru_sound got exposed by > 128f825aeab7 or the machine driver needs some changes to complement

Re: [PATCH v2] MAINTAINERS: add KCOV section

2020-07-21 Thread Dmitry Vyukov
On Tue, Jul 21, 2020 at 1:41 PM Andrey Konovalov wrote: > > To link KCOV to the kasan-dev@ mailing list. > > Signed-off-by: Andrey Konovalov > --- > MAINTAINERS | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index d53db30d1365..fbe59955646d

Re: [PATCH v4 2/4] clocksource/drivers: Add CLINT timer driver

2020-07-21 Thread Anup Patel
On Tue, Jul 21, 2020 at 6:41 AM Atish Patra wrote: > > On Fri, Jul 17, 2020 at 12:52 AM Anup Patel wrote: > > > > We add a separate CLINT timer driver for Linux RISC-V M-mode (i.e. > > RISC-V NoMMU kernel). > > > > The CLINT MMIO device provides three things: > > 1. 64bit free running counter

Re: [PATCH 4.19 123/133] thermal/drivers/cpufreq_cooling: Fix wrong frequency converted from power

2020-07-21 Thread Pavel Machek
On Mon 2020-07-20 17:37:50, Greg Kroah-Hartman wrote: > From: Finley Xiao > > commit 371a3bc79c11b707d7a1b7a2c938dc3cc042fffb upstream. > > The function cpu_power_to_freq is used to find a frequency and set the > cooling device to consume at most the power to be converted. For example, > if the

Re: [RFC PATCH] mm: silence soft lockups from unlock_page

2020-07-21 Thread Qian Cai
> On Jul 21, 2020, at 7:25 AM, Michal Hocko wrote: > > Are these really important? I believe I can dig that out from the bug > report but I didn't really consider that important enough. Please dig them out. We have also been running those things on “large” powerpc as well and never saw such

Re: [PATCH] MAINTAINERS: add KCOV section

2020-07-21 Thread Andrey Konovalov
On Tue, Jul 21, 2020 at 1:38 PM Marco Elver wrote: > > On Tue, 21 Jul 2020 at 13:34, Andrey Konovalov wrote: > > > > To link KCOV to the kasan-dev@ mailing list. > > > > Signed-off-by: Andrey Konovalov > > --- > > MAINTAINERS | 9 + > > 1 file changed, 9 insertions(+) > > > > diff

[PATCH v2] MAINTAINERS: add KCOV section

2020-07-21 Thread Andrey Konovalov
To link KCOV to the kasan-dev@ mailing list. Signed-off-by: Andrey Konovalov --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index d53db30d1365..fbe59955646d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9305,6 +9305,17 @@ F:

RE: [PATCH 2/2] fpga: dfl: create a dfl bus type to support DFL devices

2020-07-21 Thread Wu, Hao
> > > +} > > > + > > > +dfl_dev->type = feature_dev_id_type(pdev); > > > +dfl_dev->feature_id = (unsigned long long)feature->id; > > > + > > > +dfl_dev->dev.parent = >dev; > > > +dfl_dev->dev.bus = _bus_type; > > > +dfl_dev->dev.release = release_dfl_dev; > > > +dev_set_name(_dev->dev,

Re: [RESEND PATCH] usb: common: usb-conn-gpio: Register optional charger

2020-07-21 Thread Greg Kroah-Hartman
On Mon, Jun 22, 2020 at 12:48:07AM +0200, Paul Cercueil wrote: > Register a power supply charger, if the Kconfig option > USB_CONN_GPIO_CHARGER is set, whose online state depends on whether > the USB role is set to device or not. > > This is useful when the USB role is the only way to know if the

[PATCH v2 03/10] powerpc/smp: Move powerpc_topology above

2020-07-21 Thread Srikar Dronamraju
Just moving the powerpc_topology description above. This will help in using functions in this file and avoid declarations. No other functional changes Cc: linuxppc-dev Cc: LKML Cc: Michael Ellerman Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Nick Piggin Cc: Oliver

Re: [PATCH v4 4/4] dt-bindings: timer: Add CLINT bindings

2020-07-21 Thread Anup Patel
On Tue, Jul 21, 2020 at 6:45 AM Atish Patra wrote: > > On Fri, Jul 17, 2020 at 12:52 AM Anup Patel wrote: > > > > We add DT bindings documentation for CLINT device. > > > > Signed-off-by: Anup Patel > > Reviewed-by: Palmer Dabbelt > > Tested-by: Emil Renner Berhing > > --- > >

Re: [PATCH] MAINTAINERS: add KCOV section

2020-07-21 Thread Marco Elver
On Tue, 21 Jul 2020 at 13:34, Andrey Konovalov wrote: > > To link KCOV to the kasan-dev@ mailing list. > > Signed-off-by: Andrey Konovalov > --- > MAINTAINERS | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index d53db30d1365..eec0b687eb08 100644 >

[PATCH v2 10/10] powerpc/smp: Implement cpu_to_coregroup_id

2020-07-21 Thread Srikar Dronamraju
Lookup the coregroup id from the associativity array. If unable to detect the coregroup id, fallback on the core id. This way, ensure sched_domain degenerates and an extra sched domain is not created. Ideally this function should have been implemented in arch/powerpc/kernel/smp.c. However if its

[PATCH v2 04/10] powerpc/smp: Enable small core scheduling sooner

2020-07-21 Thread Srikar Dronamraju
Enable small core scheduling as soon as we detect that we are in a system that supports thread group. Doing so would avoid a redundant check. Cc: linuxppc-dev Cc: LKML Cc: Michael Ellerman Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Nick Piggin Cc: Oliver OHalloran Cc:

[PATCH v2 08/10] powerpc/smp: Allocate cpumask only after searching thread group

2020-07-21 Thread Srikar Dronamraju
If allocated earlier and the search fails, then cpumask need to be freed. However cpu_l1_cache_map can be allocated after we search thread group. Cc: linuxppc-dev Cc: LKML Cc: Michael Ellerman Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Nick Piggin Cc: Oliver OHalloran

[PATCH v2 07/10] Powerpc/numa: Detect support for coregroup

2020-07-21 Thread Srikar Dronamraju
Add support for grouping cores based on the device-tree classification. - The last domain in the associativity domains always refers to the core. - If primary reference domain happens to be the penultimate domain in the associativity domains device-tree property, then there are no coregroups.

[PATCH v2 06/10] powerpc/smp: Generalize 2nd sched domain

2020-07-21 Thread Srikar Dronamraju
Currently "CACHE" domain happens to be the 2nd sched domain as per powerpc_topology. This domain will collapse if cpumask of l2-cache is same as SMT domain. However we could generalize this domain such that it could mean either be a "CACHE" domain or a "BIGCORE" domain. While setting up the

[PATCH v2 09/10] Powerpc/smp: Create coregroup domain

2020-07-21 Thread Srikar Dronamraju
Add percpu coregroup maps and masks to create coregroup domain. If a coregroup doesn't exist, the coregroup domain will be degenerated in favour of SMT/CACHE domain. Cc: linuxppc-dev Cc: LKML Cc: Michael Ellerman Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Valentin Schneider Cc: Nick Piggin Cc:

[PATCH v2 05/10] powerpc/smp: Dont assume l2-cache to be superset of sibling

2020-07-21 Thread Srikar Dronamraju
Current code assumes that cpumask of cpus sharing a l2-cache mask will always be a superset of cpu_sibling_mask. Lets stop that assumption. cpu_l2_cache_mask is a superset of cpu_sibling_mask if and only if shared_caches is set. Cc: linuxppc-dev Cc: LKML Cc: Michael Ellerman Cc: Ingo Molnar

[PATCH v2 02/10] powerpc/smp: Merge Power9 topology with Power topology

2020-07-21 Thread Srikar Dronamraju
A new sched_domain_topology_level was added just for Power9. However the same can be achieved by merging powerpc_topology with power9_topology and makes the code more simpler especially when adding a new sched domain. Cc: linuxppc-dev Cc: LKML Cc: Michael Ellerman Cc: Ingo Molnar Cc: Peter

[PATCH v2 01/10] powerpc/smp: Cache node for reuse

2020-07-21 Thread Srikar Dronamraju
While cpu_to_node is inline function with access to per_cpu variable. However when using repeatedly, it may be cleaner to cache it in a local variable. Also fix a build error in a some weird config. "error: _numa_cpu_lookup_table_ undeclared" No functional change Cc: linuxppc-dev Cc: LKML Cc:

Re: [PATCH -v2 1/5] sched: Fix ttwu() race

2020-07-21 Thread peterz
On Tue, Jul 21, 2020 at 11:49:05AM +0100, Chris Wilson wrote: > Quoting Peter Zijlstra (2020-06-22 11:01:23) > > @@ -2378,6 +2385,9 @@ static inline bool ttwu_queue_cond(int c > > static bool ttwu_queue_wakelist(struct task_struct *p, int cpu, int > > wake_flags) > > { > > if

[PATCH v2 00/10] Coregroup support on Powerpc

2020-07-21 Thread Srikar Dronamraju
Changelog v1 -> v2: v1: https://lore.kernel.org/linuxppc-dev/20200714043624.5648-1-sri...@linux.vnet.ibm.com/t/#u powerpc/smp: Merge Power9 topology with Power topology Replaced a reference to cpu_smt_mask with per_cpu(cpu_sibling_map, cpu) since cpu_smt_mask is only defined

Re: [PATCH v4 09/10] powerpc/watchpoint: Return available watchpoints dynamically

2020-07-21 Thread Michael Ellerman
Ravi Bangoria writes: > On 7/20/20 9:12 AM, Jordan Niethe wrote: >> On Fri, Jul 17, 2020 at 2:11 PM Ravi Bangoria >> wrote: >>> >>> So far Book3S Powerpc supported only one watchpoint. Power10 is >>> introducing 2nd DAWR. Enable 2nd DAWR support for Power10. >>> Availability of 2nd DAWR will

Re: [PATCH] dma-pool: Do not allocate pool memory from CMA

2020-07-21 Thread Nicolas Saenz Julienne
On Tue, 2020-07-21 at 13:28 +0200, Christoph Hellwig wrote: > On Tue, Jul 21, 2020 at 01:15:23PM +0200, Nicolas Saenz Julienne > wrote: > > I'm at loss at what could be failing here. Your device should be > > able > > to address the whole 8GB memory space, which AFAIK is the max > > available > >

Re: [PATCH 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration

2020-07-21 Thread Cheng-yi Chiang
Hi Tzung-Bi, Thanks for the review! On Mon, Jul 20, 2020 at 10:47 AM Tzung-Bi Shih wrote: > > On Fri, Jul 17, 2020 at 8:02 PM Cheng-Yi Chiang wrote: > > diff --git a/sound/soc/qcom/sc7180.c b/sound/soc/qcom/sc7180.c > > new file mode 100644 > > index ..cbe6b487d432 > > --- /dev/null

I am Dr. Philippe Don,

2020-07-21 Thread Philippe Don
Attention: Friend, How are you, I am Dr. Philippe Don Siaka, a medical doctor working with Gabriel Toure Hospital Bamako Mali, please don't be upset by the way i am sending this message to you without knowing you before, i only trying to render help that is needed from me by someone who is no

[PATCH] MAINTAINERS: add KCOV section

2020-07-21 Thread Andrey Konovalov
To link KCOV to the kasan-dev@ mailing list. Signed-off-by: Andrey Konovalov --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index d53db30d1365..eec0b687eb08 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9305,6 +9305,15 @@ F:

Re: [PATCH v2] usb: gadget: configfs: Fix use-after-free issue with udc_name

2020-07-21 Thread Greg Kroah-Hartman
On Sat, Jul 18, 2020 at 10:58:53AM +0800, Macpaul Lin wrote: > On Sat, 2020-07-18 at 10:45 +0800, Macpaul Lin wrote: > > From: Eddie Hung > > > > Well, it's strange, I simply replaced the uploader's name to my > colleague, git send-email pop up this line automatically. > > Shouldn't I do that

Re: [PATCH 4.19 094/133] USB: serial: iuu_phoenix: fix memory corruption

2020-07-21 Thread Pavel Machek
Hi! > commit e7b931bee739e8a77ae216e613d3b99342b6dec0 upstream. > > The driver would happily overwrite its write buffer with user data in > 256 byte increments due to a removed buffer-space sanity check. > +++ b/drivers/usb/serial/iuu_phoenix.c > @@ -697,14 +697,16 @@ static int

Re: [PATCH v2 1/8] usb: dwc2: gadget: Make use of GINTMSK2

2020-07-21 Thread Felipe Balbi
Minas Harutyunyan writes: > Hi Felipe, > > On 7/21/2020 1:43 PM, Felipe Balbi wrote: >> Minas Harutyunyan writes: >> >>> On 7/15/2020 1:32 PM, Lee Jones wrote: The value obtained from GINTSTS2 should be masked with the GINTMSK2 value. Looks like this has been broken since

Re: [PATCH v2] ipmi/watchdog: add missing newlines when printing parameters by sysfs

2020-07-21 Thread Corey Minyard
On Tue, Jul 21, 2020 at 02:35:09PM +0800, Xiongfeng Wang wrote: > When I cat some ipmi_watchdog parameters by sysfs, it displays as > follows. It's better to add a newline for easy reading. > > root@(none):/# cat /sys/module/ipmi_watchdog/parameters/action > resetroot@(none):/# cat

Re: [PATCH 01/10] block: introduce blk_is_valid_logical_block_size

2020-07-21 Thread Damien Le Moal
On 2020/07/21 20:09, Maxim Levitsky wrote: > On Tue, 2020-07-21 at 11:05 +, Damien Le Moal wrote: >> On 2020/07/21 19:53, Maxim Levitsky wrote: >>> Kernel block layer has never supported logical block >>> sizes less that SECTOR_SIZE nor larger that PAGE_SIZE. >>> >>> Some drivers have runtime

[PATCH v2 2/2] remoteproc: qcom_q6v5_mss: Add MBA log extraction support

2020-07-21 Thread Sibi Sankar
On SC7180 the MBA firmware stores the bootup text logs in a 4K segment at the beginning of the MBA region. Add support to extract the logs which will be useful to debug mba boot/authentication issues. Signed-off-by: Sibi Sankar --- V2: * Don't dump logs in mba_reclaim path [Bjorn] * Move

Re: [PATCH v10 05/17] mtd: spi-nor: add support for DTR protocol

2020-07-21 Thread Pratyush Yadav
Hi Tudor, On 07/07/20 05:37PM, tudor.amba...@microchip.com wrote: > Hi, Pratyush, > > On 6/23/20 9:30 PM, Pratyush Yadav wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > Double Transfer Rate (DTR) is SPI protocol in which data is

[PATCH v2 0/2] Add modem debug features

2020-07-21 Thread Sibi Sankar
The series adds support for the following modem debug features: * Modem debug policy which enables coredumps/live debug on secure devices * MBA text logs extraction on SC7180 SoCs V2: * Use request_firmware_direct [Bjorn] * Use Bjorn's template to show if debug policy is present * Add size

Re: [PATCH 1/2] ASoC: qcom: dt-bindings: Add sc7180 machine bindings

2020-07-21 Thread Cheng-yi Chiang
On Fri, Jul 17, 2020 at 11:03 PM Doug Anderson wrote: > > Hi, > Thanks for the review! > On Fri, Jul 17, 2020 at 5:02 AM Cheng-Yi Chiang wrote: > > > > Add devicetree bindings documentation file for sc7180 sound card. > > > > Signed-off-by: Cheng-Yi Chiang > > --- > >

[PATCH v2 1/2] remoteproc: qcom_q6v5_mss: Add modem debug policy support

2020-07-21 Thread Sibi Sankar
Add modem debug policy support which will enable coredumps and live debug support when the msadp firmware is present on secure devices. Signed-off-by: Sibi Sankar --- v2: * Use request_firmware_direct [Bjorn] * Use Bjorn's template to show if debug policy is present * Add size check to

Re: [PATCH v4 05/10] powerpc/dt_cpu_ftrs: Add feature for 2nd DAWR

2020-07-21 Thread Michael Ellerman
Ravi Bangoria writes: > On 7/17/20 11:14 AM, Jordan Niethe wrote: >> On Fri, Jul 17, 2020 at 2:10 PM Ravi Bangoria >> wrote: >>> >>> Add new device-tree feature for 2nd DAWR. If this feature is present, >>> 2nd DAWR is supported, otherwise not. >>> >>> Signed-off-by: Ravi Bangoria >>> --- >>>

Re: [PATCH 4.19 041/133] Revert "usb/ohci-platform: Fix a warning when hibernating"

2020-07-21 Thread Pavel Machek
Hi! > > > >After some investigations, we concluded the following: > > > > - the issue does not exist in vanilla v5.8-rc4+ > > > > - [bisecting shows that] the panic on v4.14.186 is caused by the lack > > > > of v5.6-rc1 commit 987351e1ea7772 ("phy: core: Add consumer device > > > > link

Re: [PATCH 10/10] block: scsi: sr: use blk_is_valid_logical_block_size

2020-07-21 Thread Damien Le Moal
On 2020/07/21 19:55, Maxim Levitsky wrote: > Plus some tiny refactoring. > > Signed-off-by: Maxim Levitsky > --- > drivers/scsi/sr.c | 31 +-- > 1 file changed, 13 insertions(+), 18 deletions(-) > > diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c > index

Re: [PATCH v2 4/4] platform/chrome: cros_ec_proto: Convert EC error codes to Linux error codes

2020-07-21 Thread Enric Balletbo i Serra
Hi Guenter, Thank you for work on this. Cc'ing Gwendal as he has a deep knowledge of the EC and their errors. On 20/7/20 22:22, Guenter Roeck wrote: > The EC reports a variety of error codes. Most of those, with the exception > of EC_RES_INVALID_VERSION, are converted to -EPROTO. As result, the

Re: [PATCH] dma-pool: Do not allocate pool memory from CMA

2020-07-21 Thread Christoph Hellwig
On Tue, Jul 21, 2020 at 01:15:23PM +0200, Nicolas Saenz Julienne wrote: > I'm at loss at what could be failing here. Your device should be able > to address the whole 8GB memory space, which AFAIK is the max available > on that smartphone family. But maybe the device-tree is lying, who > knows...

Re: [PATCH 2/2] nds32: use get_kernel_nofault in dump_mem

2020-07-21 Thread Christoph Hellwig
Can you pich the patches up in the nds32 tree for Linus? There are not short-term dependencies on them.

Re: [PATCH v2] virtio_ring: use alloc_pages_node for NUMA-aware allocation

2020-07-21 Thread Shile Zhang
On 2020/7/21 16:18, Michael S. Tsirkin wrote: On Tue, Jul 21, 2020 at 03:00:13PM +0800, Shile Zhang wrote: Use alloc_pages_node() allocate memory for vring queue with proper NUMA affinity. Reported-by: kernel test robot Suggested-by: Jiang Liu Signed-off-by: Shile Zhang Do you observe

Re: hibernation reverts in 4.19.134: better alternative?

2020-07-21 Thread Pavel Machek
Hi! > On Mon, Jul 20, 2020 at 12:15:22PM +0200, Pavel Machek wrote: > > This is queued for 4.19.134-stable, reverting 3 patches. But it seems > > better alternative is available... > > > > commit f3e697b7b6f5e2c570226f8f8692fb7db57215ec > > Author: Sasha Levin > > Date: Fri Jul 17 12:58:32

Re: [PATCH] Revert "kbuild: use -flive-patching when CONFIG_LIVEPATCH is enabled"

2020-07-21 Thread Miroslav Benes
On Sun, 19 Jul 2020, Joe Lawrence wrote: > On 7/17/20 2:29 PM, Josh Poimboeuf wrote: > > Use of the new -flive-patching flag was introduced with the following > > commit: > > > >43bd3a95c98e ("kbuild: use -flive-patching when CONFIG_LIVEPATCH is > >enabled") > > > > This flag has

Re: [PATCH v4 2/6] media: v4l2: Add extended buffer operations

2020-07-21 Thread Stanimir Varbanov
On 7/17/20 2:54 PM, Helen Koike wrote: > From: Hans Verkuil > > Those extended buffer ops have several purpose: > 1/ Fix y2038 issues by converting the timestamp into an u64 counting >the number of ns elapsed since 1970 > 2/ Unify single/multiplanar handling > 3/ Add a new start offset

Re: [PATCH v2] iommu/mediatek: check 4GB mode by reading infracfg

2020-07-21 Thread Yong Wu
On Tue, 2020-07-21 at 11:40 +0200, Matthias Brugger wrote: > > On 21/07/2020 04:16, Miles Chen wrote: > > In previous discussion [1] and [2], we found that it is risky to > > use max_pfn or totalram_pages to tell if 4GB mode is enabled. > > > > Check 4GB mode by reading infracfg register, remove

Re: [PATCH 09/10] block: scsi: sd: use blk_is_valid_logical_block_size

2020-07-21 Thread Damien Le Moal
On 2020/07/21 19:55, Maxim Levitsky wrote: > Use blk_is_valid_logical_block_size instead of hardcoded list s/hardcoded list/hardcoded checks./ > > Signed-off-by: Maxim Levitsky > --- > drivers/scsi/sd.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git

Re: [RFC PATCH] mm: silence soft lockups from unlock_page

2020-07-21 Thread Michal Hocko
On Tue 21-07-20 07:10:14, Qian Cai wrote: > > > > On Jul 21, 2020, at 2:33 AM, Michal Hocko wrote: > > > > on a large ppc machine. The very likely cause is a suboptimal > > configuration when systed-udev spawns way too many workders to bring the > > system up. > > This is strange. The problem

RE: [PATCH] ath10k: Add interrupt summary based CE processing

2020-07-21 Thread Rakesh Pillai
> -Original Message- > From: Peter Oh > Sent: Tuesday, July 21, 2020 7:03 AM > To: Kalle Valo > Cc: Brian Norris ; Doug Anderson > ; linux-wireless wirel...@vger.kernel.org>; Rakesh Pillai ; ath10k > ; LKML > Subject: Re: [PATCH] ath10k: Add interrupt summary based CE processing >

[PATCH] iio: frequency: ad9523: convert rest of driver to device managed functions

2020-07-21 Thread Alexandru Ardelean
The driver pretty much uses device managed functions. The only left-over is the iio_device_register() function, which also requires an action-or-reset hook to disable the regulator on the remove and error path. Signed-off-by: Alexandru Ardelean --- drivers/iio/frequency/ad9523.c | 60

Re: [PATCH 08/10] block: nvme: use blk_is_valid_logical_block_size

2020-07-21 Thread Damien Le Moal
On 2020/07/21 19:55, Maxim Levitsky wrote: > This replaces manual checking in the driver > > Signed-off-by: Maxim Levitsky > --- > drivers/nvme/host/core.c | 17 - > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git a/drivers/nvme/host/core.c

[PATCH v2] brcmfmac: Set timeout value when configuring power save

2020-07-21 Thread Nicolas Saenz Julienne
Set the timeout value as per cfg80211's set_power_mgmt() request. If the requested value value is left undefined we set it to 2 seconds, the maximum supported value. Signed-off-by: Nicolas Saenz Julienne --- Changes since v1: - Use min_t()

[PATCH] csky: Fix build with upstream gcc

2020-07-21 Thread Joerg Roedel
From: Joerg Roedel Building a kernel for the CSKY architecture with CONFIG_FRAME_POINTER set requires a gcc supporting the non-upstream '-mbacktrace' option. Check for the '-mbacktrace' option before enabling CONFIG_FRAMEPOINTER and fix building CSKY with an upstream gcc compiler.

PROBLEM: cgroup cost too much memory when transfer small files to tmpfs

2020-07-21 Thread jingrui
Cc: Johannes Weiner ; Michal Hocko ; Vladimir Davydov Thanks. --- PROBLEM: cgroup cost too much memory when transfer small files to tmpfs. keywords: cgroup PERCPU/memory cost too much. description: We send small files from node-A to node-B tmpfs /tmp directory using sftp. On node-B the

Re: [PATCH v3 0/6] powerpc: queued spinlocks and rwlocks

2020-07-21 Thread Nicholas Piggin
Excerpts from Peter Zijlstra's message of July 9, 2020 6:31 pm: > On Wed, Jul 08, 2020 at 07:54:34PM -0400, Waiman Long wrote: >> On 7/8/20 4:41 AM, Peter Zijlstra wrote: >> > On Tue, Jul 07, 2020 at 03:57:06PM +1000, Nicholas Piggin wrote: >> > > Yes, powerpc could certainly get more performance

Re: WARNING in pvr2_i2c_core_done

2020-07-21 Thread syzbot
Hello, syzbot has tested the proposed patch but the reproducer is still triggering an issue: general protection fault in kernfs_find_ns pvrusb2: Invalid write control endpoint pvrusb2: Invalid write control endpoint pvrusb2: Invalid write control endpoint pvrusb2: Invalid write control endpoint

Re: [PATCH 1/2] nds32: remove dump_instr

2020-07-21 Thread Nick Hu
On Mon, Jul 20, 2020 at 01:44:47PM +0200, Christoph Hellwig wrote: > dump_inst has a return before actually doing anything, so just drop the > whole thing. > > Signed-off-by: Christoph Hellwig > --- > arch/nds32/kernel/traps.c | 35 --- > 1 file changed, 35

Re: [PATCH 2/2] nds32: use get_kernel_nofault in dump_mem

2020-07-21 Thread Nick Hu
On Mon, Jul 20, 2020 at 01:44:48PM +0200, Christoph Hellwig wrote: > Use the proper get_kernel_nofault helper to access an unsafe kernel > pointer without faulting instead of playing with set_fs and get_user. > > Signed-off-by: Christoph Hellwig > --- > arch/nds32/kernel/traps.c | 15

[PATCH v6 1/4] power: supply: core: add quick charge type property

2020-07-21 Thread Qiwu Huang
From: Qiwu Huang Reports the kind of quick charge type based on different adapter power. Signed-off-by: Qiwu Huang --- Documentation/ABI/testing/sysfs-class-power | 21 + drivers/power/supply/power_supply_sysfs.c | 1 + include/linux/power_supply.h| 10

[PATCH v6 2/4] power: supply: core: add wireless charger adapter type property

2020-07-21 Thread Qiwu Huang
From: Qiwu Huang Reports what type of wireless adapter connection is currently active for the supply. for example it can show if ADAPTER_PD capable source is attached. Signed-off-by: Qiwu Huang --- Documentation/ABI/testing/sysfs-class-power | 28 +

[PATCH v6 4/4] power: supply: core: property to control reverse charge

2020-07-21 Thread Qiwu Huang
From: Qiwu Huang Interface to control wireless reverse charge. Signed-off-by: Qiwu Huang --- Documentation/ABI/testing/sysfs-class-power | 14 ++ drivers/power/supply/power_supply_sysfs.c | 1 + include/linux/power_supply.h| 1 + 3 files changed, 16

[PATCH v6 3/4] power: supply: core: add wireless signal strength property

2020-07-21 Thread Qiwu Huang
From: Qiwu Huang reports wireless signal strength. The value show degree of coupling between tx and rx. Signed-off-by: Qiwu Huang --- Documentation/ABI/testing/sysfs-class-power | 22 + drivers/power/supply/power_supply_sysfs.c | 1 + include/linux/power_supply.h

[PATCH v5 0/4] add some power supply properties about wireless/wired charging

2020-07-21 Thread Qiwu Huang
From: Qiwu Huang This patchset aims to provide power supply properties about wireless/wired charging. "quick_charge_type" reports different types of quick charge based on the charging power; "tx_adapter" shows" the type of wireless charging adapter; "signal_strength" shows the coupling level

Re: [PATCH 07/10] block: mspro_blk: use blk_is_valid_logical_block_size

2020-07-21 Thread Damien Le Moal
On 2020/07/21 19:55, Maxim Levitsky wrote: > Signed-off-by: Maxim Levitsky > --- > drivers/memstick/core/mspro_block.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/memstick/core/mspro_block.c > b/drivers/memstick/core/mspro_block.c > index cd6b8d4f23350..86c9eb0aef512

Re: [PATCH] Revert "kbuild: use -flive-patching when CONFIG_LIVEPATCH is enabled"

2020-07-21 Thread Miroslav Benes
On Fri, 17 Jul 2020, Josh Poimboeuf wrote: > Use of the new -flive-patching flag was introduced with the following > commit: > > 43bd3a95c98e ("kbuild: use -flive-patching when CONFIG_LIVEPATCH is > enabled") > > This flag has several drawbacks: > > - It disables some optimizations, so it

Re: [PATCH 06/10] block: ms_block: use blk_is_valid_logical_block_size

2020-07-21 Thread Damien Le Moal
On 2020/07/21 19:54, Maxim Levitsky wrote: > Signed-off-by: Maxim Levitsky > --- > drivers/memstick/core/ms_block.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/memstick/core/ms_block.c > b/drivers/memstick/core/ms_block.c > index

Re: [PATCH 05/10] block: null: use blk_is_valid_logical_block_size

2020-07-21 Thread Damien Le Moal
On 2020/07/21 19:54, Maxim Levitsky wrote: > This slightly changes the behavier of the driver, s/behavier/behavior > when given invalid block size (non power of two, or below 512 bytes), > but shoudn't matter. > > Signed-off-by: Maxim Levitsky > --- > drivers/block/null_blk_main.c | 6 +++---

Re: [PATCH v4 0/6] media: v4l2: Add extended fmt and buffer ioctls

2020-07-21 Thread Boris Brezillon
Hello Helen, Just a few drive-by comments. On Fri, 17 Jul 2020 08:54:29 -0300 Helen Koike wrote: > Hi, > > I'm sorry for taking too long to submit v4. > > It is not perfect, not all v4l2-compliance tests passes, but I'd like a > review, > specially on the API and potential problems, so I

Re: [PATCH] dma-pool: Do not allocate pool memory from CMA

2020-07-21 Thread Nicolas Saenz Julienne
On Tue, 2020-07-21 at 14:24 +0530, Amit Pundir wrote: > On Tue, 21 Jul 2020 at 14:09, Nicolas Saenz Julienne > wrote: > > Hi Amit, > > > Hi Nicolas, > > > > > > I see a boot regression with this commit d9765e41d8e9 "dma-pool: > > > Do not allocate pool memory from CMA" on my Xiaomi Poco F1 > > >

Re: kernel BUG at include/linux/swapops.h:LINE!

2020-07-21 Thread Kirill A. Shutemov
On Mon, Jul 20, 2020 at 04:51:44PM -0700, Andrew Morton wrote: > On Sun, 19 Jul 2020 14:10:19 -0700 syzbot > wrote: > > > syzbot has found a reproducer for the following issue on: > > > > HEAD commit:4c43049f Add linux-next specific files for 20200716 > > git tree: linux-next > >

[patch V4 07/15] x86/entry: Consolidate 32/64 bit syscall entry

2020-07-21 Thread Thomas Gleixner
From: Thomas Gleixner 64bit and 32bit entry code have the same open coded syscall entry handling after the bitwidth specific bits. Move it to a helper function and share the code. Signed-off-by: Thomas Gleixner --- arch/x86/entry/common.c | 93

[patch V4 11/15] x86/entry: Use generic syscall exit functionality

2020-07-21 Thread Thomas Gleixner
Replace the x86 variant with the generic version. Provide the relevant architecture specific helper functions and defines. Use a temporary define for idtentry_exit_user which will be cleaned up seperately. Signed-off-by: Thomas Gleixner --- V4: Drop a pointless define Adjust to moved

[PATCH] i2c: fix WARNING in pvr2_i2c_core_done

2020-07-21 Thread B K Karthik
#syz test: https://github.com/google/kasan.git usb-fuzzer fix WARNING in pvr2_i2c_core_done by unregistering device in the release handler instead of the disconnect handler. Reported-by: syzbot+e74a998ca8f1df9cc...@syzkaller.appspotmail.com Signed-off-by: B K Karthik ---

[patch V4 04/15] entry: Provide generic interrupt entry/exit code

2020-07-21 Thread Thomas Gleixner
From: Thomas Gleixner Like the syscall entry/exit code interrupt/exception entry after the real low level ASM bits should not be different accross architectures. Provide a generic version based on the x86 code. irqentry_enter() is called after the low level entry code and irqentry_exit() must

[patch V4 05/15] entry: Provide infrastructure for work before exiting to guest mode

2020-07-21 Thread Thomas Gleixner
From: Thomas Gleixner Entering a guest is similar to exiting to user space. Pending work like handling signals, rescheduling, task work etc. needs to be handled before that. Provide generic infrastructure to avoid duplication of the same handling code all over the place. The exit to guest mode

Re: [RFC PATCH] mm: silence soft lockups from unlock_page

2020-07-21 Thread Qian Cai
> On Jul 21, 2020, at 2:33 AM, Michal Hocko wrote: > > on a large ppc machine. The very likely cause is a suboptimal > configuration when systed-udev spawns way too many workders to bring the > system up. This is strange. The problem description is missing quite a few important details. For

[patch V4 03/15] entry: Provide generic syscall exit function

2020-07-21 Thread Thomas Gleixner
Like syscall entry all architectures have similar and pointlessly different code to handle pending work before returning from a syscall to user space. 1) One-time syscall exit work: - rseq syscall exit - audit - syscall tracing - tracehook (single stepping) 2)

[patch V4 10/15] x86/entry: Use generic syscall entry function

2020-07-21 Thread Thomas Gleixner
Replace the syscall entry work handling with the generic version. Provide the necessary helper inlines to handle the real architecture specific parts, e.g. ptrace. Use a temporary define for idtentry_enter_user which will be cleaned up seperately. Signed-off-by: Thomas Gleixner --- V4: Drop the

Re: [PATCH 01/10] block: introduce blk_is_valid_logical_block_size

2020-07-21 Thread Maxim Levitsky
On Tue, 2020-07-21 at 11:05 +, Damien Le Moal wrote: > On 2020/07/21 19:53, Maxim Levitsky wrote: > > Kernel block layer has never supported logical block > > sizes less that SECTOR_SIZE nor larger that PAGE_SIZE. > > > > Some drivers have runtime configurable block size, > > so it makes

Re: [PATCH v3 0/6] powerpc: queued spinlocks and rwlocks

2020-07-21 Thread Nicholas Piggin
Excerpts from Peter Zijlstra's message of July 8, 2020 6:41 pm: > On Tue, Jul 07, 2020 at 03:57:06PM +1000, Nicholas Piggin wrote: >> Yes, powerpc could certainly get more performance out of the slow >> paths, and then there are a few parameters to tune. > Sorry for the delay, got bogged down

[patch V4 13/15] x86/entry: Use generic interrupt entry/exit code

2020-07-21 Thread Thomas Gleixner
Replace the x86 code with the generic variant. Use temporary defines for idtentry_* which will be cleaned up in the next step. Signed-off-by: Thomas Gleixner --- arch/x86/entry/common.c | 167 arch/x86/include/asm/idtentry.h | 10 -- 2 files

[patch V4 14/15] x86/entry: Cleanup idtentry_enter/exit

2020-07-21 Thread Thomas Gleixner
Remove the temporary defines and fixup all references. Signed-off-by: Thomas Gleixner --- arch/x86/entry/common.c |6 +++--- arch/x86/include/asm/idtentry.h | 33 ++--- arch/x86/kernel/kvm.c |6 +++--- arch/x86/kernel/traps.c |

Re: [PATCH 04/10] block: nbd: use blk_is_valid_logical_block_size

2020-07-21 Thread Damien Le Moal
On 2020/07/21 19:54, Maxim Levitsky wrote: > This allows to remove nbd's own check for valid block size > > Signed-off-by: Maxim Levitsky > --- > drivers/block/nbd.c | 12 ++-- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c

<    6   7   8   9   10   11   12   13   14   15   >