On 7/21/20 7:43 AM, Al Cooper wrote:
> Version v1.0.40 of the Android host ADB software increased maximum
> transfer sizes from 256K to 1M. Since the STB ADB gadget driver
> requests only 16K at a time, the BDC driver ran out of buffer
> descriptors (BDs) if the queuing happens faster than the
On 7/21/20 7:43 AM, Al Cooper wrote:
> On Android systems, After temporarily putting device to S2 by
> short pressing the power button on the remote, the display turns
> off. Then press the power button to turn the display back up. Adb
> devices would show the devices is offline. It needs a
On 7/21/20 7:43 AM, Al Cooper wrote:
> Remove "brcm,bdc-v0.16" because it was never used on any system.
> Add "brcm,bdc-udc-v2" which exists for any STB system with BDC.
>
> Signed-off-by: Al Cooper
Acked-by: Florian Fainelli
--
Florian
On 7/21/20 7:43 AM, Al Cooper wrote:
> From: Sasi Kumar
>
> Multiple connects/disconnects can cause a crash on the second
> disconnect. The driver had a problem where it would try to send
> endpoint commands after it was disconnected which is not allowed
> by the hardware. The fix is to only
On Tue, Jul 21, 2020 at 10:43:11PM +0530, B K Karthik wrote:
> prevent a bad shift operation by verifying that
> sport->rx_dma_rng_buf_len is non zero.
>
> Signed-off-by: B K Karthik
> ---
> drivers/tty/serial/fsl_lpuart.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
What about
When CROSS_COMPILE is set (e.g. aarch64-linux-gnu-), if
$(CROSS_COMPILE)elfedit is found at /usr/bin/aarch64-linux-gnu-elfedit,
GCC_TOOLCHAIN_DIR will be set to /usr/bin/. --prefix= will be set to
/usr/bin/ and Clang as of 11 will search for both
$(prefix)aarch64-linux-gnu-$needle and
bahci libphy libata dm_mirror dm_region_hash
dm_log dm_mod
[14933.435176][T1176230] CPU: 25 PID: 1176230 Comm: trinity-c25 Not tainted
5.8.0-rc6-next-20200721 #5
[14933.435200][T1176230] NIP: c00c4560 LR: c00d4fb4 CTR:
[14933.435223][T1176230] REGS: c0001520f910 TRAP
On 7/21/20 11:23 AM, Andy Lutomirski wrote:
> On Tue, Jul 21, 2020 at 8:31 AM Jens Axboe wrote:
>>
>> On 7/21/20 9:27 AM, Andy Lutomirski wrote:
>>> On Fri, Jul 17, 2020 at 1:02 AM Stefano Garzarella
>>> wrote:
On Thu, Jul 16, 2020 at 08:12:35AM -0700, Kees Cook wrote:
> On Thu,
On 20-07-20, 15:12, Álvaro Fernández Rojas wrote:
> Add BCM63xx USBH PHY driver for BMIPS.
>
> v8: readd Simon as author and remove his email address from the source code.
> v7: remove Simon from authors and introduce changes suggested by Rob:
> - Move clock conditions to the main section.
>
This makes possible to install and load KUnit tests
as modules in a root filesystem and boot UML with
this filesystem.
The filesystem was created using debootstrap:
sudo debootstrap buster .uml_rootfs
And change the owner of the root filesystem files
for your user:
sudo chown -R
Hi Stephen,
Thanks for the review.
On 7/21/2020 1:21 PM, Stephen Boyd wrote:
+...
diff --git a/include/dt-bindings/clock/qcom,gcc-sc7180.h
b/include/dt-bindings/clock/qcom,gcc-sc7180.h
index 992b67b..bdf43adc 100644
--- a/include/dt-bindings/clock/qcom,gcc-sc7180.h
+++
On Mon, 2020-07-20 at 12:38 -0300, Bruno Meneguele wrote:
> On Mon, Jul 20, 2020 at 10:56:55AM -0400, Mimi Zohar wrote:
> > On Mon, 2020-07-20 at 10:40 -0400, Nayna wrote:
> > > On 7/13/20 12:48 PM, Bruno Meneguele wrote:
> > > > The IMA_APPRAISE_BOOTPARAM config allows enabling different
> > > >
On 7/21/20 10:16 AM, Jonathan McDowell wrote:
> This adds full 802.1q VLAN support to the qca8k, allowing the use of
> vlan_filtering and more complicated bridging setups than allowed by
> basic port VLAN support.
>
> Tested with a number of untagged ports with separate VLANs and then a
> trunk
On Tue, Jul 21, 2020 at 7:34 AM Christoph Hellwig wrote:
>
> On Tue, Jul 21, 2020 at 07:31:02AM -0700, Andy Lutomirski wrote:
> > > What do you mean with "properly wired up". Do you really want to spread
> > > ->compat_foo methods everywhere, including read and write? I found
> > >
On Tue, Jul 21, 2020 at 10:44:19PM +0530, Rakesh Pillai wrote:
> NAPI gets scheduled on the CPU core which got the
> interrupt. The linux scheduler cannot move it to a
> different core, even if the CPU on which NAPI is running
> is heavily loaded. This can lead to degraded wifi
> performance when
On Tue, Jul 21, 2020 at 8:31 AM Jens Axboe wrote:
>
> On 7/21/20 9:27 AM, Andy Lutomirski wrote:
> > On Fri, Jul 17, 2020 at 1:02 AM Stefano Garzarella
> > wrote:
> >>
> >> On Thu, Jul 16, 2020 at 08:12:35AM -0700, Kees Cook wrote:
> >>> On Thu, Jul 16, 2020 at 03:14:04PM +0200, Stefano
Use the new macb bindings and add an mdio sub-node to contain all the
phy nodes.
Signed-off-by: Codrin Ciubotariu
---
Changes in v2:
- none
arch/arm/boot/dts/at91-sam9x60ek.dts | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/at91-sam9x60ek.dts
Use the new macb bindings and add an mdio sub-node to contain all the
phy nodes.
Signed-off-by: Codrin Ciubotariu
---
Changes in v2:
- none
arch/arm/boot/dts/at91-sama5d4_xplained.dts | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git
Use the new macb bindings and add an mdio sub-node to contain all the
phy nodes.
Signed-off-by: Codrin Ciubotariu
---
Changes in v2:
- none;
arch/arm/boot/dts/at91-sama5d3_xplained.dts | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git
Use the new macb bindings and add an mdio sub-node to contain all the
phy nodes.
Signed-off-by: Codrin Ciubotariu
---
Changes in v2:
- none
arch/arm/boot/dts/at91-sama5d27_som1.dtsi | 16 ++--
arch/arm/boot/dts/at91-sama5d27_wlsom1.dtsi | 17 ++---
The MACB embeds an MDIO bus controller. For this reason, the PHY nodes
were represented as sub-nodes in the MACB node. Generally, the
Ethernet controller is different than the MDIO controller, so the PHYs
are probed by a separate MDIO driver. Since adding the PHY nodes directly
under the ETH node
On 7/21/2020 9:28 AM, Greg KH wrote:
On Tue, Jul 21, 2020 at 09:02:15AM -0700, Dave Jiang wrote:
v2:
"RFC" to me means "I don't really think this is mergable, so I'm
throwing it out there." Which implies you know it needs more work
before others should review it as you are not comfortable
The MACB driver embeds an MDIO bus controller and for this reason there
was no need for an MDIO sub-node present to contain the PHY nodes. Adding
MDIO devies directly under an Ethernet node is deprecated, so an MDIO node
is included to contain of the PHY nodes (and other MDIO devices' nodes).
On Tue, Jul 21, 2020 at 09:49:17AM -0700, Linus Torvalds wrote:
> On Tue, Jul 21, 2020 at 9:28 AM Christoph Hellwig wrote:
> >
> > +
> > + /* traverse into overmounted root and then chroot to it */
> > + if (!kern_path("/..", LOOKUP_FOLLOW | LOOKUP_DIRECTORY, ) &&
> > +
This adds full 802.1q VLAN support to the qca8k, allowing the use of
vlan_filtering and more complicated bridging setups than allowed by
basic port VLAN support.
Tested with a number of untagged ports with separate VLANs and then a
trunk port with all the VLANs tagged on it.
Signed-off-by:
NAPI instance gets scheduled on a CPU core on which
the IRQ was triggered. The processing of rx packets
can be CPU intensive and since NAPI cannot be moved
to a different CPU core, to get better performance,
its better to move the gist of rx packet processing
in a high priority thread.
Add the
During the system suspend or resume, the rx thread
also needs to be suspended or resume respectively.
Handle the rx thread as well during the system
suspend and resume.
Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
Signed-off-by: Rakesh Pillai
---
Use the device-managed variant for the allocating the MDIO bus. This
cleans-up the code a little on the remove and error paths.
Signed-off-by: Codrin Ciubotariu
---
Changes in v2:
- none
drivers/net/ethernet/cadence/macb_main.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
On 7/21/20 11:30 AM, Vaibhav Gupta wrote:
> On Tue, Jul 21, 2020 at 10:19:33AM -0500, Tom Lendacky wrote:
>> On 7/21/20 7:31 AM, Vaibhav Gupta wrote:
>>> Drivers using legacy power management .suspen()/.resume() callbacks
>>> have to manage PCI states and device's PM states themselves. They also
Add the support to handle the receive packet and
the tx completion processing in a thread context
if the feature has been enabled via module parameter.
Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
Signed-off-by: Rakesh Pillai
---
drivers/net/wireless/ath/ath10k/core.c | 8
When the receive packets are submitted to the stack
from a thread context, the NAPI handle should be passed
as NULL to the function ieee80211_rx_napi. This will
make sure that the packets are submitted to stack via
non-napi method
Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
Add a module parameter to enable or disable
the processing of received packets in rx thread.
To enable rx packet processing in a thread
context, use the belo command to load driver:
insmod ath10k_snoc.ko rx_thread_enable=1
Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
Adding the PHY nodes directly under the Ethernet node became deprecated,
so the aim of this patch series is to make MACB use an MDIO node as
container for MDIO devices.
This patch series starts with a small patch to use the device-managed
devm_mdiobus_alloc(). In the next two patches we update the
Currently the entire NAPI budget is marked as exhausted
if any tx completion is processed.
In scenarios of bi-directional traffic, this leads to a
situation where the irqs are never enabled and the NAPI
is rescheuled again and again.
Increase the work done quota by the number of tx completions
The function ieee80211_rx_napi can be now called
from a thread context as well, with napi context
being NULL.
Hence add the napi context check before giving out
a warning for softirq count being 0.
Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
Signed-off-by: Rakesh Pillai
---
NAPI gets scheduled on the CPU core which got the
interrupt. The linux scheduler cannot move it to a
different core, even if the CPU on which NAPI is running
is heavily loaded. This can lead to degraded wifi
performance when running traffic at peak data rates.
A thread on the other hand can be
add parentheses to expression to improve
code readability.
Signed-off-by: B K Karthik
---
drivers/tty/serial/fsl_lpuart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index 0cc64279cd2d..3108f5ab57fa 100644
On Tue, Jul 21, 2020 at 04:52:56PM +0200, Sedat Dilek wrote:
> On Tue, Jul 21, 2020 at 12:40 PM Greg KH wrote:
> >
> > On Mon, Jul 20, 2020 at 09:19:38PM -0700, Fangrui Song wrote:
> > > When CROSS_COMPILE is set (e.g. aarch64-linux-gnu-), if
> > > $(CROSS_COMPILE)elfedit is found at
prevent a bad shift operation by verifying that
sport->rx_dma_rng_buf_len is non zero.
Signed-off-by: B K Karthik
---
drivers/tty/serial/fsl_lpuart.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index
Applied. Thanks!
Alex
On Fri, Jul 17, 2020 at 8:23 AM Qiu Wenbo wrote:
>
> Avoid kernel crash when vddci_control is SMU7_VOLTAGE_CONTROL_NONE and
> vddci_voltage_table is empty. It has been tested on Intel Hades Canyon
> (i7-8809G).
>
> Bug: https://bugzilla.kernel.org/show_bug.cgi?id=208489
>
On Tue, Jul 21, 2020 at 06:28:07PM +0200, Christoph Hellwig wrote:
> diff --git a/init/fs.c b/init/fs.c
> index 73423f5461f934..1bdb5dc5ec12ba 100644
> --- a/init/fs.c
> +++ b/init/fs.c
> @@ -3,6 +3,7 @@
> #include
> #include
> #include
> +#include <../fs/internal.h>
... and that is why the
On 7/21/20 4:40 AM, Stefano Garzarella wrote:
> On Thu, Jul 16, 2020 at 03:26:51PM -0600, Jens Axboe wrote:
>> On 7/16/20 6:48 AM, Stefano Garzarella wrote:
>>> diff --git a/include/uapi/linux/io_uring.h b/include/uapi/linux/io_uring.h
>>> index efc50bd0af34..0774d5382c65 100644
>>> ---
On Tue, Jul 21, 2020 at 06:28:10PM +0200, Christoph Hellwig wrote:
> +int __init init_chroot(const char *filename)
> +{
> + struct path path;
> + int error;
> +
> + error = kern_path(filename, LOOKUP_FOLLOW | LOOKUP_DIRECTORY, );
> + if (error)
> + return error;
> +
On 7/21/20 3:57 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the akpm-current tree, today's linux-next build
> (sparc64 defconfig) failed like this:
>
> mm/hugetlb.c: In function 'free_gigantic_page':
> mm/hugetlb.c:1233:18: error: 'hugetlb_cma' undeclared (first use in this
>
So what we are looking at, at salepoints for an optimal nix machine is:
- 48bit Graphics
- LCPU - Library Accelerated CPU, for low latency and jitter.
- 4K / 8K subpixels resolution.
- name sdX, as supply and demand is a monotheistic principle of a
perfected nix name.
With realtime audio
For gapless playback it is possible that each track can have different
codec profile with same decoder, for example we have WMA album,
we may have different tracks as WMA v9, WMA v10 and so on
Or if DSP's like QDSP have abililty to switch decoders on single stream
for each track, then this call
Move codec parameter checking to dedicated function so that other
callers do not duplicate it. This is in preparedness for adding
snd_compr_set_codec_params() support.
Signed-off-by: Srinivas Kandagatla
---
sound/core/compress_offload.c | 20 +---
1 file changed, 13
For gapless playback it is possible that each track can have different
codec profile with same decoder, for example we have WMA album,
we may have different tracks as WMA v9, WMA v10 and so on
Or if DSP's like QDSP have abililty to switch decoders on single stream
for each track, then this call
This patch adds support to metadata required to do a gapless playback.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/qcom/qdsp6/q6asm-dai.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c b/sound/soc/qcom/qdsp6/q6asm-dai.c
index
On Tue, Jul 21, 2020 at 06:28:06PM +0200, Christoph Hellwig wrote:
> Like do_mount, but takes a kernel pointer for the destination path.
> Switch over the mounts in the init code and devtmpfs to it, which
> just happen to work due to the implicit set_fs(KERNEL_DS) during early
> init right now.
>
On Tue, Jul 21, 2020 at 06:28:15PM +0200, Christoph Hellwig wrote:
> Add a simple helper to symlink with a kernel space file name and switch
> the early init code over to it. Remove the now unused ksys_symlink.
> +int __init init_symlink(const char *oldname, const char *newname)
> +{
> +
Some of the DSPs like Qualcomm QDSP has ablity to change decoders
dynamically on a single stream, This could be used for features
like Cross Fade or gapless with different codec profile tracks.
Exposing such features in flags variable of compress caps descriptor
would provide userspace more
On Tue, Jul 21, 2020 at 06:28:00PM +0200, Christoph Hellwig wrote:
> Instead of passing a kernel pointer to vfs_stat by relying on the
> implicit set_fs(KERNEL_DS) in md_setup_drive, just open code the
> trivial getattr, and use the opportunity to move a little bit more
> code from the caller into
Add support to gapless playback by implementing metadata,
next_track, drain and partial drain support.
Gapless on Q6ASM is implemented by opening 2 streams in a single
q6asm stream and toggling them on next track.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/qcom/qdsp6/q6asm-dai.c | 253
On Tue, Jul 21, 2020 at 06:28:17PM +0200, Christoph Hellwig wrote:
> +int __init init_mknod(const char *filename, umode_t mode, unsigned int dev)
> +{
> + struct dentry *dentry;
> + struct path path;
> + int error;
> +
> + if (S_ISFIFO(mode) || S_ISSOCK(mode))
> + dev
Now that we have added support for new IOCTL and flags to
struct snd_compr_caps, bump up the version to 0,2,1
to help users find it.
Signed-off-by: Srinivas Kandagatla
---
include/uapi/sound/compress_offload.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Make use of new set_codec_params callback to allow decoder switching
during gapless playback.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/qcom/qdsp6/q6asm-dai.c | 33
1 file changed, 33 insertions(+)
diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c
Add corresponding ASoC changes to support gapless playback of tracks
which have different codec profile with or without same decoder.
Signed-off-by: Srinivas Kandagatla
---
include/sound/soc-component.h | 3 +++
include/sound/soc-dai.h | 5 +
sound/soc/soc-compress.c | 30
This patch adds support to gapless flag to q6asm_open_write().
Signed-off-by: Srinivas Kandagatla
---
sound/soc/qcom/qdsp6/q6asm-dai.c | 4 ++--
sound/soc/qcom/qdsp6/q6asm.c | 4 +++-
sound/soc/qcom/qdsp6/q6asm.h | 2 +-
3 files changed, 6 insertions(+), 4 deletions(-)
diff --git
During gapless playback, its possible for previous track to
end at unaligned boundary, starting next track on the same
boundary can lead to unaligned address exception in dsp.
So implement copy callback for finer control on the buffer offsets.
Signed-off-by: Srinivas Kandagatla
---
This patch adds support to ASM_DATA_CMD_REMOVE_INITIAL_SILENCE
and ASM_DATA_CMD_REMOVE_TRAILING_SILENCE q6asm command to support
compressed metadata for gapless playback.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/qcom/qdsp6/q6asm.c | 53
Add length to write command packet token so that we can track exactly
how many bytes are consumed by DSP in the command reply.
This is useful in some use-cases where the end of the file/stream
is not aligned with period size.
Signed-off-by: Srinivas Kandagatla
---
use flags set by q6asm-dais directly!
This will be useful gapless case where write needs a special flag to indicate
that last buffer.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/qcom/qdsp6/q6asm.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git
Each ASM session can have multiple streams attached to it,
current design was to allow only one static stream id 1 per each session.
However for use-case like gapless, we would need 2 streams to open per session.
This patch converts all the q6asm apis to take stream id as argument
to allow
Each q6asm session can have multiple streams, mixing usage of these
names in variable are bit misleading to reader, so rename them accordingly.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/qcom/qdsp6/q6asm.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
This patchset adds gapless compressed audio support on q6asm.
Gapless on q6asm is implemented using 2 streams in a single q6asm session.
First few patches such as stream id per each command, gapless flags
and silence meta data are for preparedness for adding gapless support.
Last patch implements
On Tue, Jul 21, 2020 at 9:28 AM Christoph Hellwig wrote:
>
> +
> + /* traverse into overmounted root and then chroot to it */
> + if (!kern_path("/..", LOOKUP_FOLLOW | LOOKUP_DIRECTORY, ) &&
> + !inode_permission(path.dentry->d_inode, MAY_EXEC | MAY_CHDIR) &&
> +
Yes, I am using OVMF with SEV-ES (sev-es-v12 patches applied). I am
running Ubuntu 18.04 distro. My grub target is x86_64-efi. I also
tried installing the grub-efi-amd64 package. In all cases, the grub is
running in 64bit but enters the startup_32 in 32 bit mode. I think
there should be a 32bit
Convert to yaml the VersaClock bindings document. The mapping between
clock specifier and physical pins cannot be described formally in yaml
schema, then keep it verbatim in the description field.
Signed-off-by: Luca Ceresoli
---
Changes in v3:
- schema syntax fixes: use enum to constrain
Marek has been the primary developer of this driver (thanks!). Now as
he is not working on it anymore he suggested I take over maintainership.
Cc: Marek Vasut
Signed-off-by: Luca Ceresoli
---
Changes in v3: none
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
'idt' is misspelled 'itd' in a few places, fix it.
Fixes: 34662f6e3084 ("dt: Add additional option bindings for IDT VersaClock")
Signed-off-by: Luca Ceresoli
Reviewed-by: Rob Herring
---
Changes in v3: add Reviewed-by: Rob Herring
---
Reusing the generic struct vc5_hw_data for all blocks is handy. However it
implies we allocate space the div_int and div_frc fields even for the
output drivers where they are unused, and the clk_output_cfg0 and
clk_output_cfg0_mask fields that are used only for the output
drivers.
Use a dedicated
On Tue, Jul 21, 2020 at 09:02:15AM -0700, Dave Jiang wrote:
> v2:
> IMS (now dev-msi):
> With recommendations from Jason/Thomas/Dan on making IMS more generic:
> Pass a non-pci generic device(struct device) for IMS management instead of
> mdev
> Remove all references to mdev and symbol_get/put
>
Ack. Will have that in v2.
Hao
On Mon, Jul 20, 2020 at 7:37 PM Andrii Nakryiko
wrote:
>
> On Mon, Jul 20, 2020 at 1:28 PM Hao Luo wrote:
> >
> > >
> > > This should ideally look like a real global variable extern:
> > >
> > > extern const struct rq runqueues __ksym;
> > >
> > >
> > > But
Question: Can 'ahd_inb(ahd, LQISTAT2);' also be safely removed?
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aic7xxx/aic79xx_core.c: In function ‘ahd_dump_sglist’:
drivers/scsi/aic7xxx/aic79xx_core.c:1738:14: warning: variable ‘len’ set but
not used
'qla4_83xx_reg_tbl' is only used in 'drivers/scsi/qla4xxx/ql4_os.c',
move it there.
Fixes the following W=1 kernel build warning(s):
In file included from drivers/scsi/qla4xxx/ql4_def.h:46,
from drivers/scsi/qla4xxx/ql4_init.c:9:
At top level:
drivers/scsi/qla4xxx/ql4_83xx.h:90:23: warning:
We're assuming that the string should be NUL terminated here.
If not, then memcpy() might be more appropriate.
Fixes the following W=1 kernel build warning(s):
from drivers/scsi/pm8001/pm8001_sas.c:41:
In function ‘strncpy’,
inlined from ‘pm8001_issue_ssp_tmf’ at
Also remove 'tstate' which became unused after this patch.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aic7xxx/aic79xx_core.c: In function ‘ahd_handle_seqint’:
drivers/scsi/aic7xxx/aic79xx_core.c:1907:32: warning: variable ‘targ_info’ set
but not used
Fixes the following W=1 kernel build warning(s):
In file included from drivers/scsi/qla4xxx/ql4_def.h:43,
from drivers/scsi/qla4xxx/ql4_mbx.c:9:
drivers/scsi/qla4xxx/ql4_nx.h:602:23: warning: ‘qla4_82xx_reg_tbl’ defined but
not used [-Wunused-const-variable=]
602 | static const uint32_t
Also clean-up some white space issues while we're here.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/sa.c:147: warning: Function parameter or member 'p2' not
described in 'sa_sync_cmd'
drivers/scsi/aacraid/sa.c:147: warning: Function parameter or member 'p3' not
Kerneldoc expects attributes/parameters to be in '@*.: ' format.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aic94xx/aic94xx_dev.c:246: warning: Function parameter or member
'dev' not described in 'asd_init_sata_pm_port_ddb'
drivers/scsi/aic94xx/aic94xx_dev.c:290: warning:
Fixes the following W=1 kernel build warning(s):
from drivers/scsi/qla4xxx/ql4_iocb.c:8:
drivers/scsi/qla4xxx/ql4_iocb.c:87: warning: Function parameter or member
'mrkr_mod' not described in 'qla4xxx_send_marker_iocb'
drivers/scsi/qla4xxx/ql4_iocb.c:87: warning: Excess function parameter
Hi Baolu,
Not sure what state is this patch in, there is a bug in this patch
(see below), shall I send out an updated version of this one only? or
another incremental patch.
Thanks,
Jacob
On Mon, 6 Jul 2020 17:12:51 -0700
Jacob Pan wrote:
> From: Liu Yi L
>
> Address information for
Hasn't been used since 2009.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/pm8001/pm8001_hwi.c: In function ‘mpi_set_phys_g3_with_ssc’:
drivers/scsi/pm8001/pm8001_hwi.c:415:6: warning: variable ‘value’ set but not
used [-Wunused-but-set-variable]
Cc: Jack Wang
Signed-off-by:
Other headers have been demoted as they are too far out of sync and
ideally require effort from the authors.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/lpfc/lpfc_ct.c:321: warning: Function parameter or member
'usr_flg' not described in 'lpfc_gen_req'
Also demote incomplete header from kerneldoc.
Fixes the following W=1 kernel build warning(s):
from drivers/scsi/qla4xxx/ql4_mbx.c:9:
drivers/scsi/qla4xxx/ql4_mbx.c:53: warning: Excess function parameter 'ret'
description in 'qla4xxx_is_intr_poll_mode'
drivers/scsi/qla4xxx/ql4_mbx.c:832:
Fixes the following W=1 kernel build warning(s):
drivers/scsi/lpfc/lpfc_sli.c:257: warning: Function parameter or member 'mqe'
not described in 'lpfc_sli4_mq_put'
drivers/scsi/lpfc/lpfc_sli.c:257: warning: Excess function parameter 'wqe'
description in 'lpfc_sli4_mq_put'
Fix one formatting issue, one misspelling and three missing
descriptions.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/qla4xxx/ql4_isr.c:588: warning: Excess function parameter 'ret'
description in 'qla4_83xx_loopback_in_progress'
drivers/scsi/qla4xxx/ql4_isr.c:661: warning:
Fixes the following W=1 kernel build warning(s):
drivers/scsi/lpfc/lpfc_sli.c: In function ‘lpfc_wq_create’:
drivers/scsi/lpfc/lpfc_sli.c:15810:16: warning: variable ‘pg_addr’ set but not
used [-Wunused-but-set-variable]
15810 | unsigned long pg_addr;
| ^~~
Cc: James Smart
Cc: Dick
Fixes the following W=1 kernel build warning(s):
drivers/scsi/sym53c8xx_2/sym_glue.c:1784: warning: Function parameter or
member 'pdev' not described in 'sym2_reset_workarounds'
Cc: Matthew Wilcox
Cc: Gerard Roudier
Cc: Wolfgang Stanglmeier
Cc: Stefan Esser
Cc: Richard Waltham
This matches some of the other headers in the file.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/csiostor/csio_lnode.c:2079: warning: Function parameter or member
'hw' not described in 'csio_lnode_init'
drivers/scsi/csiostor/csio_lnode.c:2079: warning: Function parameter or
'pg_addr' is only used when CONFIG_X86 is defined. So only declare it
if CONFIG_X86 is defined.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/lpfc/lpfc_sli.c: In function ‘lpfc_wq_create’:
drivers/scsi/lpfc/lpfc_sli.c:15813:16: warning: unused variable ‘pg_addr’
Only declare 'tp' and 'lp' if they are going to be used.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/sym53c8xx_2/sym_hipd.c: In function ‘sym_complete_error’:
drivers/scsi/sym53c8xx_2/sym_hipd.c:5356:18: warning: variable ‘lp’ set but
not used [-Wunused-but-set-variable]
Fixes the following W=1 kernel build warning(s):
drivers/scsi/lpfc/lpfc_mem.c:85: warning: Function parameter or member 'align'
not described in 'lpfc_mem_alloc'
Cc: James Smart
Cc: Dick Kennedy
Cc: Sumit Semwal
Cc: "Christian König"
Cc: linux-me...@vger.kernel.org
Cc:
On Tue, 21 Jul 2020 12:37:33 -0400
Steven Rostedt wrote:
> On Mon, 20 Jul 2020 10:21:15 +0800
> Tingwei Zhang wrote:
>
> > Only function traces can be exported to other destinations currently.
> > This patch exports event trace as well.
> >
> > Signed-off-by: Tingwei Zhang
> > ---
> >
Demote other headers which are clearly not kerneldoc.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/qla4xxx/ql4_nx.c:983: warning: Function parameter or member 'ha'
not described in 'qla4_82xx_pinit_from_rom'
drivers/scsi/qla4xxx/ql4_nx.c:983: warning: Function parameter or
Fixes the following W=1 kernel build warning(s):
drivers/scsi/qla4xxx/ql4_nx.c: In function ‘qla4_84xx_minidump_process_rddfe’:
drivers/scsi/qla4xxx/ql4_nx.c:2648:23: warning: variable ‘data_size’ set but
not used [-Wunused-but-set-variable]
2648 | uint32_t poll, mask, data_size, modify_mask;
Only declare 'core_nr' if its conditions for use are met.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/mvsas/mv_init.c: In function ‘mvs_interrupt’:
drivers/scsi/mvsas/mv_init.c:180:6: warning: variable ‘core_nr’ set but not
used [-Wunused-but-set-variable]
Also move the header block above the correct function.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/cxgbi/cxgb3i/cxgb3i.c:390: warning: Function parameter or member
'dev' not described in 'arp_failure_skb_discard'
drivers/scsi/cxgbi/cxgb3i/cxgb3i.c:390: warning: Function
pci_set_mwi() has 'warn_unused_result' so the result should be checked.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/qla4xxx/ql4_init.c: In function ‘qla4xxx_pci_config’:
drivers/scsi/qla4xxx/ql4_init.c:664:6: warning: variable ‘status’ set but not
used
501 - 600 of 1463 matches
Mail list logo
