Re: [PATCH V3 vhost next 00/10] VDPA support for Mellanox ConnectX devices

2020-07-27 Thread Eli Cohen
On Tue, Jul 28, 2020 at 02:53:34PM +0800, Jason Wang wrote: > > On 2020/7/28 下午2:40, Jason Wang wrote: > > > >On 2020/7/28 下午2:32, Eli Cohen wrote: > >>On Tue, Jul 28, 2020 at 02:18:16PM +0800, Jason Wang wrote: > >>>On 2020/7/28 下午2:05, Eli Cohen wrote: > Hi Michael, > please note that th

Re: [PATCH v2 1/9] mfd: mt6360: Rearrange include file

2020-07-27 Thread Lee Jones
On Tue, 28 Jul 2020, Gene Chen wrote: > Lee Jones 於 2020年7月27日 週一 下午7:08寫道: > > > > On Fri, 17 Jul 2020, Gene Chen wrote: > > > > > From: Gene Chen > > > > > > Rearrange include file without sorting by alphabet. > > > > Why are you making this change? > > > > Personal coding style references fr

Re: [PATCH v7 0/2] phy: Add USB PHY support on Intel LGM SoC

2020-07-27 Thread Andy Shevchenko
On Tue, Jul 28, 2020 at 5:52 AM Ramuthevar, Vadivel MuruganX wrote: > On 27/7/2020 7:09 pm, Andy Shevchenko wrote: > > On Mon, Jul 27, 2020 at 1:08 PM Ramuthevar,Vadivel MuruganX > > wrote: ... > >> v7: > >>- No Change > > > > I guess it's not the correct changelog entry. > > You moved file

Re: [PATCH v2 4/9] mfd: mt6360: Combine mt6360 pmic/ldo resouces into mt6360 regulator resources

2020-07-27 Thread Lee Jones
On Tue, 28 Jul 2020, Gene Chen wrote: > Lee Jones 於 2020年7月27日 週一 下午7:29寫道: > > > > On Fri, 17 Jul 2020, Gene Chen wrote: > > > > > From: Gene Chen > > > > > > Combine mt6360 pmic/ldo resouces into mt6360 regulator resources > > > to simplify the similar resources object. > > > > Do the sub-devi

Re: [PATCH V3 vhost next 00/10] VDPA support for Mellanox ConnectX devices

2020-07-27 Thread Jason Wang
On 2020/7/28 下午2:40, Jason Wang wrote: On 2020/7/28 下午2:32, Eli Cohen wrote: On Tue, Jul 28, 2020 at 02:18:16PM +0800, Jason Wang wrote: On 2020/7/28 下午2:05, Eli Cohen wrote: Hi Michael, please note that this series depends on mlx5 core device driver patches in mlx5-next branch in git://g

Re: [PATCH v3 00/13] msm8992 DTS updates, peripheral enablement

2020-07-27 Thread Bjorn Andersson
On Mon 27 Jul 11:20 PDT 2020, Konrad Dybcio wrote: > Bumping this up, in case it just got overlooked. > It was just overlooked, thanks for the bump! I think it looks good, will pick up the patches, and the previous series that it depends on. Thanks, Bjorn

RE: [PATCH RESEND 1/1] power_supply: wilco_ec: Add permanent long life charging mode

2020-07-27 Thread Wang, Crag
> > + Permanent Long Life: Last longer battery life, this mode > > + is programmed once in the factory. Switching to a > > + different mode is unavailable. > > The documentation lacks one important aspect: What happens if I have a > device where the fa

[PATCH] usb: hso: check for return value in hso_serial_common_create()

2020-07-27 Thread Rustam Kovhaev
in case of an error tty_register_device_attr() returns ERR_PTR(), add IS_ERR() check Reported-and-tested-by: syzbot+67b2bd0e34f952d03...@syzkaller.appspotmail.com Link: https://syzkaller.appspot.com/bug?extid=67b2bd0e34f952d0321e Signed-off-by: Rustam Kovhaev --- drivers/net/usb/hso.c | 5 -

[PATCH 1/2] watchdog: imx7ulp: Strictly follow the sequence for wdog operations

2020-07-27 Thread Anson Huang
According to reference manual, the i.MX7ULP WDOG's operations should follow below sequence: 1. disable global interrupts; 2. unlock the wdog and wait unlock bit set; 3. reconfigure the wdog and wait for reconfiguration bit set; 4. enabel global interrupts. Strictly follow the recommended sequence

[PATCH 2/2] watchdog: imx7ulp: Watchdog should continue running for wait/stop mode

2020-07-27 Thread Anson Huang
When kernel idle, system will enter wait/stop mode, wdog should continue running in this scenario, and the refresh thread can wake up system from wait/stop mode. Signed-off-by: Anson Huang --- drivers/watchdog/imx7ulp_wdt.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/

[PATCH] kprobes: fix NULL pointer dereference at kprobe_ftrace_handler

2020-07-27 Thread Muchun Song
We found a case of kernel panic on our server. The stack trace is as follows(omit some irrelevant information): BUG: kernel NULL pointer dereference, address: 0080 RIP: 0010:kprobe_ftrace_handler+0x5e/0xe0 RSP: 0018:b512c6550998 EFLAGS: 00010282 RAX: RBX: f

Re: [PATCH 4/8] mfd: Add support for the MediaTek MT6359 PMIC

2020-07-27 Thread Lee Jones
On Thu, 23 Jul 2020, Hsin-Hsiung Wang wrote: > This adds support for the MediaTek MT6359 PMIC. This is a > multifunction device with the following sub modules: > > - Regulator > - Codec > - Interrupt > > It is interfaced to the host controller using SPI interface > by a proprietary hardware call

Re: [PATCH 2/4] clk: x86: Change name from ST to FCH

2020-07-27 Thread Agrawal, Akshu
On 7/21/2020 1:36 PM, Stephen Boyd wrote: Quoting Akshu Agrawal (2020-07-19 22:04:57) diff --git a/drivers/clk/x86/clk-st.c b/drivers/clk/x86/clk-fch.c similarity index 73% rename from drivers/clk/x86/clk-st.c rename to drivers/clk/x86/clk-fch.c index 25d4b97aff9b..b252f0cf0628 100644 --- a/dr

Re: [PATCH V3 vhost next 00/10] VDPA support for Mellanox ConnectX devices

2020-07-27 Thread Eli Cohen
On Tue, Jul 28, 2020 at 02:18:16PM +0800, Jason Wang wrote: > > On 2020/7/28 下午2:05, Eli Cohen wrote: > >Hi Michael, > >please note that this series depends on mlx5 core device driver patches > >in mlx5-next branch in > >git://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git. > > > >git

Re: [PATCH V3 vhost next 00/10] VDPA support for Mellanox ConnectX devices

2020-07-27 Thread Jason Wang
On 2020/7/28 下午2:32, Eli Cohen wrote: On Tue, Jul 28, 2020 at 02:18:16PM +0800, Jason Wang wrote: On 2020/7/28 下午2:05, Eli Cohen wrote: Hi Michael, please note that this series depends on mlx5 core device driver patches in mlx5-next branch in git://git.kernel.org/pub/scm/linux/kernel/git/mell

Re: [PATCH] tty/synclink: remove leftover bits of non-PCI card support

2020-07-27 Thread Jiri Slaby
On 28. 07. 20, 8:20, Christoph Hellwig wrote: > On Tue, Jul 28, 2020 at 08:05:36AM +0200, Jiri Slaby wrote: >> On 27. 07. 20, 15:05, Christoph Hellwig wrote: >>> Since commit 1355cba9c3ba ("tty/synclink: remove ISA support"), the >>> synlink driver only supports PCI card. Remove any leftover dead

[PATCH 2/2] media: stm32-dcmi: fix probe error path & module remove

2020-07-27 Thread Alain Volmat
This commit add missing vb2_queue_release calls with the probe error path and module remove. Missing v4l2_async_notifier_unregister is also added within the probe error path Fixes: 37404f91ef8b ("[media] stm32-dcmi: STM32 DCMI camera interface driver") Signed-off-by: Alain Volmat --- drivers/med

[PATCH 1/2] media: stm32-dcmi: create video dev within notifier bound

2020-07-27 Thread Alain Volmat
In case of an error during the initialization of the sensor, the video device is still available since created at the probe of the dcmi driver. Moreover the device wouldn't be released even when removing the module since the release is performed as part of the notifier unbind callback (not called i

[PATCH 0/2] Error handling fixes in stm32-dcmi driver

2020-07-27 Thread Alain Volmat
This serie implements fixes in error path of the stm32-dcmi driver. As part of it, it also fixes the way video device is handled in order to ensure that it is only created when the attached sensor is well initialized. (current implementation leads to having a video device always created and but nev

Re: [PATCH] ARM: dts: berlin: Align L2 cache-controller nodename with dtschema

2020-07-27 Thread Jisheng Zhang
Hi arm-soc, On Fri, 26 Jun 2020 10:06:41 +0200 Krzysztof Kozlowski wrote: > > > Fix dtschema validator warnings like: > l2-cache-controller@ac: $nodename:0: > 'l2-cache-controller@ac' does not match > '^(cache-controller|cpu)(@[0-9a-f,]+)*$' > > Signed-off-by: Krzysztof K

Re: [PATCH 02/15] dma-contiguous: simplify cma_early_percent_memory()

2020-07-27 Thread Christoph Hellwig
On Tue, Jul 28, 2020 at 08:11:40AM +0300, Mike Rapoport wrote: > From: Mike Rapoport > > The memory size calculation in cma_early_percent_memory() traverses > memblock.memory rather than simply call memblock_phys_mem_size(). The > comment in that function suggests that at some point there should

Re: [v2 4/4] clk: x86: Support RV architecture

2020-07-27 Thread Agrawal, Akshu
On 7/21/2020 1:35 PM, Stephen Boyd wrote: Quoting Akshu Agrawal (2020-07-19 22:04:59) diff --git a/drivers/clk/x86/clk-fch.c b/drivers/clk/x86/clk-fch.c index b252f0cf0628..d68bca7b213f 100644 --- a/drivers/clk/x86/clk-fch.c +++ b/drivers/clk/x86/clk-fch.c [...] static int fch_clk_remove

[PATCH v2 2/2] iio: light: as73211: New driver

2020-07-27 Thread Christian Eggers
Support for AMS AS73211 JENCOLOR(R) Digital XYZ Sensor. This driver has no built-in trigger. In order for making triggered measurements, an external (software) trigger driver like iio-trig-hrtimer or iio-trig-sysfs is required. The sensor supports single and continuous measurement modes. The latt

Re: [PATCH 2/8] dt-bindings: mfd: Add compatible for the MediaTek MT6359 PMIC

2020-07-27 Thread Lee Jones
On Thu, 23 Jul 2020, Hsin-Hsiung Wang wrote: > This adds compatible for the MediaTek MT6359 PMIC. > > Signed-off-by: Hsin-Hsiung Wang > --- > Documentation/devicetree/bindings/mfd/mt6397.txt | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) For my own reference (apply this as-is t

Re: [PATCH 2/4] arm64: dts: qcom: sc7180: Add iommus property to ETR

2020-07-27 Thread Bjorn Andersson
On Mon 27 Jul 21:40 PDT 2020, Sai Prakash Ranjan wrote: > On 2020-07-28 02:28, Bjorn Andersson wrote: > > On Tue 23 Jun 23:56 PDT 2020, Sai Prakash Ranjan wrote: > > > > > Hi Bjorn, > > > > > > On 2020-06-21 13:39, Sai Prakash Ranjan wrote: > > > > Hi Bjorn, > > > > > > > > On 2020-06-21 12:52,

Re: [PATCH] virtio_balloon: fix up endian-ness for free cmd id

2020-07-27 Thread Wei Wang
On 07/28/2020 12:03 AM, Michael S. Tsirkin wrote: free cmd id is read using virtio endian, spec says all fields in balloon are LE. Fix it up. Fixes: 86a559787e6f ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT") Cc: sta...@vger.kernel.org Signed-off-by: Michael S. Tsirkin --- drivers/virtio

[PATCH v2 1/2] dt-bindings: iio: light: add AMS AS73211 support

2020-07-27 Thread Christian Eggers
Add DT bindings for AMS AS73211 XYZ True Color Sensor. Signed-off-by: Christian Eggers --- .../bindings/iio/light/ams,as73211.yaml | 54 +++ 1 file changed, 54 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/light/ams,as73211.yaml diff --git a/Docum

[PATCH v2 0/2] iio: light: Support AMS AS73211 digital XYZ sensor

2020-07-27 Thread Christian Eggers
This series adds support for the AMS AS73211 digital XYZ sensor. Changes in v2: --- - Fix $id in dt binding - Document full I2C address range in "reg" property - Move "buffer" member out of "struct as73211_data" - Fix sparse warnings by using correct data types

Re: [PATCH v3] proc,fcntl: introduce F_SET_DESCRIPTION

2020-07-27 Thread Pascal Bouchareine
On Mon, Jul 27, 2020 at 6:39 PM Pascal Bouchareine wrote: > > struct file is nicely aligned to 256 bytes on distro configs. > > Will this break everything? > > > > $ cat /sys/kernel/slab/filp/object_size > > Indeed on the config I'm using here this jumped to 264 bytes > > Would it be bette

Re: [PATCH 2/2] remoteproc: qcom_q6v5_mss: Remove redundant running state

2020-07-27 Thread Bjorn Andersson
On Tue 02 Jun 09:32 PDT 2020, Sibi Sankar wrote: > Remove the redundant running state, as an equivalent is maintained in > the common q6v5 resource handling helpers. > > Signed-off-by: Sibi Sankar Reviewed-by: Bjorn Andersson > --- > drivers/remoteproc/qcom_q6v5_mss.c | 5 - > 1 file cha

RE: [PATCH v3 2/3] ltc2471: ltc2461/ltc2463 compatible strings

2020-07-27 Thread Berghe, Darius
Hi Jonathan, Thanks for review, comments inline. > -Original Message- > From: Jonathan Cameron > Sent: Monday, July 27, 2020 8:27 PM > To: Berghe, Darius > Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; > devicet...@vger.kernel.org; ji...@kernel.org; r...@kernel.org > Subj

Re: checkpatch: support deprecated terms checking

2020-07-27 Thread SeongJae Park
On Mon, 27 Jul 2020 13:49:00 -0700 Joe Perches wrote: > On Mon, 2020-07-27 at 13:44 -0700, Andrew Morton wrote: > > On Mon, 27 Jul 2020 08:54:41 +0200 SeongJae Park wrote: > > > > > > > > Unfortunately, the inexperienced _do_ in fact run > > > > > > checkpatch on files and submit inappropriate

Re: [PATCH 1/2] remoteproc: qcom: q6v5: Update running state before requesting stop

2020-07-27 Thread Bjorn Andersson
On Wed 03 Jun 15:33 PDT 2020, Evan Green wrote: > On Tue, Jun 2, 2020 at 10:29 PM Sibi Sankar wrote: > > > > Evan, > > Thanks for taking time to review > > the series. > > > > On 2020-06-02 23:14, Evan Green wrote: > > > On Tue, Jun 2, 2020 at 9:33 AM Sibi Sankar > > > wrote: > > >> > > >> Somet

[PATCH v6 04/15] vfio/type1: Report iommu nesting info to userspace

2020-07-27 Thread Liu Yi L
This patch exports iommu nesting capability info to user space through VFIO. Userspace is expected to check this info for supported uAPIs (e.g. PASID alloc/free, bind page table, and cache invalidation) and the vendor specific format information for first level/stage page table that will be bound t

[PATCH v6 06/15] iommu/vt-d: Support setting ioasid set to domain

2020-07-27 Thread Liu Yi L
>From IOMMU p.o.v., PASIDs allocated and managed by external components (e.g. VFIO) will be passed in for gpasid_bind/unbind operation. IOMMU needs some knowledge to check the PASID ownership, hence add an interface for those components to tell the PASID owner. In latest kernel design, PASID owner

[PATCH v6 05/15] vfio: Add PASID allocation/free support

2020-07-27 Thread Liu Yi L
Shared Virtual Addressing (a.k.a Shared Virtual Memory) allows sharing multiple process virtual address spaces with the device for simplified programming model. PASID is used to tag an virtual address space in DMA requests and to identify the related translation structure in IOMMU. When a PASID-cap

[PATCH v6 13/15] vfio/pci: Expose PCIe PASID capability to guest

2020-07-27 Thread Liu Yi L
This patch exposes PCIe PASID capability to guest for assigned devices. Existing vfio_pci driver hides it from guest by setting the capability length as 0 in pci_ext_cap_length[]. And this patch only exposes PASID capability for devices which has PCIe PASID extended struture in its configuration s

[PATCH v6 09/15] iommu/vt-d: Check ownership for PASIDs from user-space

2020-07-27 Thread Liu Yi L
When an IOMMU domain with nesting attribute is used for guest SVA, a system-wide PASID is allocated for binding with the device and the domain. For security reason, we need to check the PASID passed from user-space. e.g. page table bind/unbind and PASID related cache invalidation. Cc: Kevin Tian

[PATCH v6 03/15] iommu/smmu: Report empty domain nesting info

2020-07-27 Thread Liu Yi L
This patch is added as instead of returning a boolean for DOMAIN_ATTR_NESTING, iommu_domain_get_attr() should return an iommu_nesting_info handle. For now, return an empty nesting info struct for now as true nesting is not yet supported by the SMMUs. Cc: Will Deacon Cc: Robin Murphy Cc: Eric Aug

[PATCH v6 14/15] vfio: Document dual stage control

2020-07-27 Thread Liu Yi L
From: Eric Auger The VFIO API was enhanced to support nested stage control: a bunch of new ioctls and usage guideline. Let's document the process to follow to set up nested mode. Cc: Kevin Tian CC: Jacob Pan Cc: Alex Williamson Cc: Eric Auger Cc: Jean-Philippe Brucker Cc: Joerg Roedel Cc:

[PATCH v6 15/15] iommu/vt-d: Support reporting nesting capability info

2020-07-27 Thread Liu Yi L
This patch reports nesting info, and only supports the case where all the physical iomms have the same CAP/ECAP MASKS. Cc: Kevin Tian CC: Jacob Pan Cc: Alex Williamson Cc: Eric Auger Cc: Jean-Philippe Brucker Cc: Joerg Roedel Cc: Lu Baolu Signed-off-by: Liu Yi L Signed-off-by: Jacob Pan -

[PATCH v6 07/15] vfio/type1: Add VFIO_IOMMU_PASID_REQUEST (alloc/free)

2020-07-27 Thread Liu Yi L
This patch allows userspace to request PASID allocation/free, e.g. when serving the request from the guest. PASIDs that are not freed by userspace are automatically freed when the IOASID set is destroyed when process exits. Cc: Kevin Tian CC: Jacob Pan Cc: Alex Williamson Cc: Eric Auger Cc: J

Re: [PATCH] can: m_can: Set device to software init mode before closing

2020-07-27 Thread Faiz Abbas
Hi, On 16/07/20 9:53 am, Faiz Abbas wrote: > There might be some requests pending in the buffer when the > interface close sequence occurs. In some devices, these > pending requests might lead to the module not shutting down > properly when m_can_clk_stop() is called. > > Therefore, move the devi

[PATCH v6 02/15] iommu: Report domain nesting info

2020-07-27 Thread Liu Yi L
IOMMUs that support nesting translation needs report the capability info to userspace. It gives information about requirements the userspace needs to implement plus other features characterizing the physical implementation. This patch reports nesting info by DOMAIN_ATTR_NESTING. Caller can get nes

[PATCH v6 10/15] vfio/type1: Support binding guest page tables to PASID

2020-07-27 Thread Liu Yi L
Nesting translation allows two-levels/stages page tables, with 1st level for guest translations (e.g. GVA->GPA), 2nd level for host translations (e.g. GPA->HPA). This patch adds interface for binding guest page tables to a PASID. This PASID must have been allocated by the userspace before the bindi

[PATCH v6 12/15] vfio/type1: Add vSVA support for IOMMU-backed mdevs

2020-07-27 Thread Liu Yi L
Recent years, mediated device pass-through framework (e.g. vfio-mdev) is used to achieve flexible device sharing across domains (e.g. VMs). Also there are hardware assisted mediated pass-through solutions from platform vendors. e.g. Intel VT-d scalable mode which supports Intel Scalable I/O Virtual

[PATCH v6 00/15] vfio: expose virtual Shared Virtual Addressing to VMs

2020-07-27 Thread Liu Yi L
Shared Virtual Addressing (SVA), a.k.a, Shared Virtual Memory (SVM) on Intel platforms allows address space sharing between device DMA and applications. SVA can reduce programming complexity and enhance security. This VFIO series is intended to expose SVA usage to VMs. i.e. Sharing guest applicati

Re: [PATCH] tty/synclink: remove leftover bits of non-PCI card support

2020-07-27 Thread Christoph Hellwig
On Tue, Jul 28, 2020 at 08:05:36AM +0200, Jiri Slaby wrote: > On 27. 07. 20, 15:05, Christoph Hellwig wrote: > > Since commit 1355cba9c3ba ("tty/synclink: remove ISA support"), the > > synlink driver only supports PCI card. Remove any leftover dead code > > to support other cards. > > So now you

[PATCH v6 11/15] vfio/type1: Allow invalidating first-level/stage IOMMU cache

2020-07-27 Thread Liu Yi L
This patch provides an interface allowing the userspace to invalidate IOMMU cache for first-level page table. It is required when the first level IOMMU page table is not managed by the host kernel in the nested translation setup. Cc: Kevin Tian CC: Jacob Pan Cc: Alex Williamson Cc: Eric Auger

[PATCH v6 08/15] iommu: Pass domain to sva_unbind_gpasid()

2020-07-27 Thread Liu Yi L
From: Yi Sun Current interface is good enough for SVA virtualization on an assigned physical PCI device, but when it comes to mediated devices, a physical device may attached with multiple aux-domains. Also, for guest unbind, the PASID to be unbind should be allocated to the VM. This check requir

[PATCH v6 01/15] vfio/type1: Refactor vfio_iommu_type1_ioctl()

2020-07-27 Thread Liu Yi L
This patch refactors the vfio_iommu_type1_ioctl() to use switch instead of if-else, and each command got a helper function. Cc: Kevin Tian CC: Jacob Pan Cc: Alex Williamson Cc: Eric Auger Cc: Jean-Philippe Brucker Cc: Joerg Roedel Cc: Lu Baolu Reviewed-by: Eric Auger Suggested-by: Christop

Re: [PATCH v2 1/2] interconnect: Add sync state support

2020-07-27 Thread Mike Tipton
On 7/22/2020 10:07 AM, Saravana Kannan wrote: On Wed, Jul 22, 2020 at 4:01 AM Georgi Djakov wrote: The bootloaders often do some initial configuration of the interconnects in the system and we want to keep this configuration until all consumers have probed and expressed their bandwidth needs.

Re: [PATCH V3 vhost next 00/10] VDPA support for Mellanox ConnectX devices

2020-07-27 Thread Jason Wang
On 2020/7/28 下午2:05, Eli Cohen wrote: Hi Michael, please note that this series depends on mlx5 core device driver patches in mlx5-next branch in git://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git. git pull git://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git mlx5-nex

Re: [PATCH v3 2/3] remoteproc: qcom_q6v5_mss: Validate modem blob firmware size before load

2020-07-27 Thread Bjorn Andersson
On Wed 22 Jul 13:10 PDT 2020, Sibi Sankar wrote: > The following mem abort is observed when one of the modem blob firmware > size exceeds the allocated mpss region. Fix this by restricting the copy > size to segment size using request_firmware_into_buf before load. > > Err Logs: > Unable to handl

drivers/usb/gadget/udc/max3420_udc.c:1311:34: warning: unused variable 'max3420_udc_of_match'

2020-07-27 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 92ed301919932f13b9172e525674157e983d commit: 48ba02b2e2b1a1c80718e93fefe99c8319597c4a usb: gadget: add udc driver for max3420 date: 5 months ago config: x86_64-randconfig-r001-20200728 (attached as .co

[PATCH v2] clk: ti: clkctrl: fix the missed kfree() for _ti_omap4_clkctrl_setup()

2020-07-27 Thread Jing Xiangfeng
_ti_omap4_clkctrl_setup() misses to call kfree() in an error path. Jump to cleanup to fix it. Fixes: 6c3090520554 ("clk: ti: clkctrl: Fix hidden dependency to node name") Signed-off-by: Jing Xiangfeng --- drivers/clk/ti/clkctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Linux-kernel-mentees] [PATCH net v2] xdp: Prevent kernel-infoleak in xsk_getsockopt()

2020-07-27 Thread Song Liu
> On Jul 27, 2020, at 11:13 PM, Björn Töpel wrote: > > On Tue, 28 Jul 2020 at 07:37, Peilin Ye wrote: >> >> xsk_getsockopt() is copying uninitialized stack memory to userspace when >> `extra_stats` is `false`. Fix it. >> >> Fixes: 8aa5a33578e9 ("xsk: Add new statistics") >> Suggested-by: Dan

Re: [PATCH bpf-next v2 34/35] bpf: samples: do not touch RLIMIT_MEMLOCK

2020-07-27 Thread Song Liu
On Mon, Jul 27, 2020 at 12:26 PM Roman Gushchin wrote: > > Since bpf is not using rlimit memlock for the memory accounting > and control, do not change the limit in sample applications. > > Signed-off-by: Roman Gushchin Acked-by: Song Liu > --- [...] > samples/bpf/xdp_rxq_info_user.c | 6

Re: [Linux-kernel-mentees] [PATCH net v2] xdp: Prevent kernel-infoleak in xsk_getsockopt()

2020-07-27 Thread Björn Töpel
On Tue, 28 Jul 2020 at 07:37, Peilin Ye wrote: > > xsk_getsockopt() is copying uninitialized stack memory to userspace when > `extra_stats` is `false`. Fix it. > > Fixes: 8aa5a33578e9 ("xsk: Add new statistics") > Suggested-by: Dan Carpenter > Signed-off-by: Peilin Ye > --- Acked-by: Björn Töpe

Re: [RESEND v1] soc: qcom: pdr: Reorder the PD state indication ack

2020-07-27 Thread Bjorn Andersson
On Wed 01 Jul 12:59 PDT 2020, Sibi Sankar wrote: > The Protection Domains (PD) have a mechanism to keep its resources > enabled until the PD down indication is acked. Reorder the PD state > indication ack so that clients get to release the relevant resources > before the PD goes down. > > Fixes:

Re: [PATCH bpf-next v2 32/35] bpf: selftests: delete bpf_rlimit.h

2020-07-27 Thread Song Liu
> On Jul 27, 2020, at 11:06 PM, Andrii Nakryiko > wrote: > > On Mon, Jul 27, 2020 at 12:25 PM Roman Gushchin wrote: >> >> As rlimit-based memory accounting is not used by bpf anymore, >> there are no more reasons to play with memlock rlimit. >> >> Delete bpf_rlimit.h which contained a code

[PATCH V3 vhost next 02/10] vdpa_sim: use the batching API

2020-07-27 Thread Eli Cohen
From: Jason Wang Change-Id: I3751f1aecce285e0f61530c69616852d49e5f547 Signed-off-by: Jason Wang --- drivers/vdpa/vdpa_sim/vdpa_sim.c | 20 drivers/vhost/vdpa.c | 1 - 2 files changed, 21 deletions(-) diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa

[PATCH V3 vhost next 00/10] VDPA support for Mellanox ConnectX devices

2020-07-27 Thread Eli Cohen
Hi Michael, please note that this series depends on mlx5 core device driver patches in mlx5-next branch in git://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git. git pull git://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git mlx5-next They also depend Jason Wang's patches

[PATCH V3 vhost next 10/10] vdpa/mlx5: Add VDPA driver for supported mlx5 devices

2020-07-27 Thread Eli Cohen
Add a front end VDPA driver that registers in the VDPA bus and provides networking to a guest. The VDPA driver creates the necessary resources on the VF it is driving such that data path will be offloaded. Notifications are being communicated through the driver. Currently, only VFs are supported.

Re: [PATCH bpf-next v2 27/35] bpf: eliminate rlimit-based memory accounting infra for bpf maps

2020-07-27 Thread Song Liu
On Mon, Jul 27, 2020 at 10:58 PM Andrii Nakryiko wrote: > > On Mon, Jul 27, 2020 at 10:47 PM Song Liu wrote: > > > > On Mon, Jul 27, 2020 at 12:26 PM Roman Gushchin wrote: > > > > > > Remove rlimit-based accounting infrastructure code, which is not used > > > anymore. > > > > > > Signed-off-by:

Re: [PATCH bpf-next v2 32/35] bpf: selftests: delete bpf_rlimit.h

2020-07-27 Thread Andrii Nakryiko
On Mon, Jul 27, 2020 at 12:25 PM Roman Gushchin wrote: > > As rlimit-based memory accounting is not used by bpf anymore, > there are no more reasons to play with memlock rlimit. > > Delete bpf_rlimit.h which contained a code to bump the limit. > > Signed-off-by: Roman Gushchin > --- We run test_

[PATCH V3 vhost next 04/10] net/vdpa: Use struct for set/get vq state

2020-07-27 Thread Eli Cohen
For now VQ state involves 16 bit available index value encoded in u64 variable. In the future it will be extended to contain more fields. Use struct to contain the state, now containing only a single u16 for the available index. In the future we can add fields to this struct. Reviewed-by: Parav Pa

Re: [RESEND PATCH] usb: common: usb-conn-gpio: Register optional charger

2020-07-27 Thread Chunfeng Yun
On Mon, 2020-07-27 at 17:02 +0200, Paul Cercueil wrote: > > Le lun. 27 juil. 2020 à 13:42, Chunfeng Yun > a écrit : > > On Sun, 2020-07-26 at 12:27 +0200, Paul Cercueil wrote: > >> > >> Le dim. 26 juil. 2020 à 13:14, Andy Shevchenko > >> a écrit : > >> > On Mon, Jun 22, 2020 at 1:51 AM Paul

Re: [PATCH] tty/synclink: remove leftover bits of non-PCI card support

2020-07-27 Thread Jiri Slaby
On 27. 07. 20, 15:05, Christoph Hellwig wrote: > Since commit 1355cba9c3ba ("tty/synclink: remove ISA support"), the > synlink driver only supports PCI card. Remove any leftover dead code > to support other cards. So now you can remove also the defines and bus_type completely: $ git grep -E 'MGSL

Re: [PATCH bpf-next v2 35/35] perf: don't touch RLIMIT_MEMLOCK

2020-07-27 Thread Andrii Nakryiko
On Mon, Jul 27, 2020 at 12:21 PM Roman Gushchin wrote: > > Since bpf stopped using memlock rlimit to limit the memory usage, > there is no more reason for perf to alter its own limit. > > Signed-off-by: Roman Gushchin > --- Cc'd Armaldo, but I'm guessing it's a similar situation that latest perf

Re: [PATCH] tty/synclink: remove leftover bits of non-PCI card support

2020-07-27 Thread Jiri Slaby
On 28. 07. 20, 8:05, Jiri Slaby wrote: > On 27. 07. 20, 15:05, Christoph Hellwig wrote: >> Since commit 1355cba9c3ba ("tty/synclink: remove ISA support"), the >> synlink driver only supports PCI card. Remove any leftover dead code >> to support other cards. > > So now you can remove also the defi

Re: [PATCH bpf-next v2 33/35] bpf: selftests: don't touch RLIMIT_MEMLOCK

2020-07-27 Thread Andrii Nakryiko
On Mon, Jul 27, 2020 at 12:21 PM Roman Gushchin wrote: > > Since bpf is not using memlock rlimit for memory accounting, > there are no more reasons to bump the limit. > > Signed-off-by: Roman Gushchin > --- Similarly for bench, it's a tool that's not coupled with the latest kernel version, it wi

[PATCH V3 vhost next 08/10] vdpa/mlx5: Add support library for mlx5 VDPA implementation

2020-07-27 Thread Eli Cohen
Following patches introduce VDPA network driver for Mellanox Connectx6 devices. This patch provides functionality that will be used by those patches. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen --- drivers/vdpa/Kconfig | 8 + drivers/vdpa/Makefile | 1 + dr

Re: [PATCH 10/11] usb: mtu3: clear dual mode of u3port when disable device

2020-07-27 Thread Chunfeng Yun
On Mon, 2020-07-27 at 11:07 +0300, Sergei Shtylyov wrote: > Hello! > > On 27.07.2020 10:14, Chunfeng Yun wrote: > > > If not clear u3port's dual mode when disable device, the IP > > If we don't clear ... when disabling ...? > > > will fail to enter sleep mode when suspend. Ok, thanks a lot

[PATCH V3 vhost next 03/10] vdpa: remove hard coded virtq num

2020-07-27 Thread Eli Cohen
From: Max Gurtovoy This will enable vdpa providers to add support for multi queue feature and publish it to upper layers (vhost and virtio). Signed-off-by: Max Gurtovoy Reviewed-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_main.c | 3 ++- drivers/vdpa/vdpa.c | 3 +++ drivers/vdpa

[PATCH V3 vhost next 07/10] vdpa/mlx5: Add hardware descriptive header file

2020-07-27 Thread Eli Cohen
Keep all vdpa related hardware definitions in this file. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen --- drivers/vdpa/mlx5/core/mlx5_vdpa_ifc.h | 168 + 1 file changed, 168 insertions(+) create mode 100644 drivers/vdpa/mlx5/core/mlx5_vdpa_ifc.h diff --git a/driv

[PATCH V3 vhost next 01/10] vhost-vdpa: support batch updating

2020-07-27 Thread Eli Cohen
From: Jason Wang Change-Id: Ifd7139cfbd122dc22493f4bb93fa884f8edbddb6 Signed-off-by: Jason Wang --- drivers/vhost/vdpa.c | 23 +-- include/uapi/linux/vhost_types.h | 2 ++ 2 files changed, 19 insertions(+), 6 deletions(-) diff --git a/drivers/vhost/vdpa.c b/dri

[PATCH V3 vhost next 09/10] vdpa/mlx5: Add shared memory registration code

2020-07-27 Thread Eli Cohen
Add code to support registering address space region for the device. The virtio driver can run as either: 1. Guest virtio driver 2. Userspace virtio driver on the host 3. Kernel virtio driver on the host In any case a memory key object is required to provide access to memory for the device. This

[PATCH V3 vhost next 05/10] vhost: Fix documentation

2020-07-27 Thread Eli Cohen
Fix documentation to match actual function prototypes. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen --- drivers/vhost/iotlb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/vhost/iotlb.c b/drivers/vhost/iotlb.c index 1f0ca6e44410..0d4213a54a88 100644 --- a

[PATCH V3 vhost next 06/10] vdpa: Modify get_vq_state() to return error code

2020-07-27 Thread Eli Cohen
Modify get_vq_state() so it returns an error code. In case of hardware acceleration, the available index may be retrieved from the device, an operation that can possibly fail. Reviewed-by: Parav Pandit Signed-off-by: Eli Cohen --- drivers/vdpa/ifcvf/ifcvf_main.c | 5 +++-- drivers/vdpa/vdpa_si

Re: [PATCH bpf-next v2 31/35] bpf: runqslower: don't touch RLIMIT_MEMLOCK

2020-07-27 Thread Andrii Nakryiko
On Mon, Jul 27, 2020 at 12:24 PM Roman Gushchin wrote: > > Since bpf is not using memlock rlimit for memory accounting, > there are no more reasons to bump the limit. > > Signed-off-by: Roman Gushchin > --- > tools/bpf/runqslower/runqslower.c | 16 > 1 file changed, 16 deletions

[PATCH] crypto: sun8i-ce - Fix writel byte-order on big-endian

2020-07-27 Thread Herbert Xu
On Tue, Jul 28, 2020 at 01:10:13PM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 92ed301919932f13b9172e525674157e983d > commit: 93c7f4d357de68f1e3a998b2fc775466d75c4c07 crypto: sun8i-ce - enable > working on big

Re: [PATCH bpf-next v2 30/35] bpf: bpftool: do not touch RLIMIT_MEMLOCK

2020-07-27 Thread Song Liu
On Mon, Jul 27, 2020 at 12:21 PM Roman Gushchin wrote: > > Since bpf stopped using memlock rlimit to limit the memory usage, > there is no more reason for bpftool to alter its own limits. > > Signed-off-by: Roman Gushchin I think we will need feature check for memcg based accounting. Thanks, So

Re: [PATCH bpf-next v2 30/35] bpf: bpftool: do not touch RLIMIT_MEMLOCK

2020-07-27 Thread Andrii Nakryiko
On Mon, Jul 27, 2020 at 12:21 PM Roman Gushchin wrote: > > Since bpf stopped using memlock rlimit to limit the memory usage, > there is no more reason for bpftool to alter its own limits. > > Signed-off-by: Roman Gushchin > --- This can't be removed either, due to old kernel support. We probably

Re: [PATCH bpf-next v2 29/35] bpf: libbpf: cleanup RLIMIT_MEMLOCK usage

2020-07-27 Thread Andrii Nakryiko
On Mon, Jul 27, 2020 at 4:15 PM Roman Gushchin wrote: > > On Mon, Jul 27, 2020 at 03:05:11PM -0700, Andrii Nakryiko wrote: > > On Mon, Jul 27, 2020 at 12:21 PM Roman Gushchin wrote: > > > > > > As bpf is not using memlock rlimit for memory accounting anymore, > > > let's remove the related code f

Re: [PATCH bpf-next v2 27/35] bpf: eliminate rlimit-based memory accounting infra for bpf maps

2020-07-27 Thread Andrii Nakryiko
On Mon, Jul 27, 2020 at 10:47 PM Song Liu wrote: > > On Mon, Jul 27, 2020 at 12:26 PM Roman Gushchin wrote: > > > > Remove rlimit-based accounting infrastructure code, which is not used > > anymore. > > > > Signed-off-by: Roman Gushchin > [...] > > > > static void bpf_map_put_uref(struct bpf_ma

Re: [PATCH bpf-next v2 22/35] bpf: eliminate rlimit-based memory accounting for bpf ringbuffer

2020-07-27 Thread Andrii Nakryiko
On Mon, Jul 27, 2020 at 12:21 PM Roman Gushchin wrote: > > Do not use rlimit-based memory accounting for bpf ringbuffer. > It has been replaced with the memcg-based memory accounting. > > bpf_ringbuf_alloc() can't return anything except ERR_PTR(-ENOMEM) > and a valid pointer, so to simplify the co

[PATCH -mmotm] pinctrl: mediatek: fix build for tristate changes

2020-07-27 Thread Randy Dunlap
From: Randy Dunlap Export mtk_is_virt_gpio() for the case when CONFIG_PINCTRL_MTK=y CONFIG_PINCTRL_MTK_V2=y CONFIG_PINCTRL_MTK_MOORE=y CONFIG_PINCTRL_MTK_PARIS=m to fix this build error: ERROR: modpost: "mtk_is_virt_gpio" [drivers/pinctrl/mediatek/pinctrl-paris.ko] undefined! Signed-off-by: R

Re: [PATCH bpf-next v2 28/35] bpf: eliminate rlimit-based memory accounting for bpf progs

2020-07-27 Thread Song Liu
On Mon, Jul 27, 2020 at 12:21 PM Roman Gushchin wrote: > > Do not use rlimit-based memory accounting for bpf progs. It has been > replaced with memcg-based memory accounting. > > Signed-off-by: Roman Gushchin Acked-by: Song Liu

Re: [PATCH 01/24] asm-generic: add generic versions of mmu context functions

2020-07-27 Thread kernel test robot
Hi Nicholas, I love your patch! Yet something to improve: [auto build test ERROR on openrisc/for-next] [also build test ERROR on sparc/master linus/master asm-generic/master v5.8-rc7 next-20200727] [cannot apply to nios2/for-linus] [If your patch is applied to the wrong git tree, kindly drop us

答复: [PATCH] USB:Fix kernel NULL pointer when unbind UHCI form vfio-pci

2020-07-27 Thread WeitaoWang-oc
On Fri, 24 Jul 2020 19:17:49 + Alex wrote: > On Fri, 24 Jul 2020 12:57:49 + > WeitaoWang-oc wrote: > > > On Thu, 23 Jul 2020 12:38:21 -0400, Alan wrote: > > > On Thu, Jul 23, 2020 at 10:17:35AM -0600, Alex Williamson wrote: > > > > The IOMMU grouping restriction does solve the hardware i

Re: [PATCH v3 3/3] remoteproc: qcom_q6v5_mss: Add modem debug policy support

2020-07-27 Thread Bjorn Andersson
On Wed 22 Jul 13:10 PDT 2020, Sibi Sankar wrote: > Add modem debug policy support which will enable coredumps and live > debug support when the msadp firmware is present on secure devices. > > Signed-off-by: Sibi Sankar Reviewed-by: Bjorn Andersson > --- > > v3: > * Fix dp_fw leak and creat

Re: [PATCH 1/4] ACPI: APD: Change name from ST to FCH

2020-07-27 Thread Agrawal, Akshu
On 7/27/2020 6:58 PM, Rafael J. Wysocki wrote: On Mon, Jul 20, 2020 at 7:06 AM Akshu Agrawal wrote: AMD SoC general pupose clk is present in new platforms with same MMIO mappings. We can reuse the same clk handler support for other platforms. Hence, changing name from ST(SoC) to FCH(IP) Sign

linux-next: manual merge of the devicetree tree with the pci tree

2020-07-27 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the devicetree tree got a conflict in: Documentation/devicetree/bindings/pci/qcom,pcie.txt between commits: 736ae5c91712 ("dt-bindings: PCI: qcom: Add missing clks") b11b8cc161de ("dt-bindings: PCI: qcom: Add ext reset") d511580ea9c2 ("dt-bindings: PC

Re: [PATCH v3 1/3] remoteproc: qcom_q6v5_mss: Validate MBA firmware size before load

2020-07-27 Thread Bjorn Andersson
On Wed 22 Jul 13:10 PDT 2020, Sibi Sankar wrote: > The following mem abort is observed when the mba firmware size exceeds > the allocated mba region. MBA firmware size is restricted to a maximum > size of 1M and remaining memory region is used by modem debug policy > firmware when available. Hence

Re: linux-next: Tree for Jul 27 (kernel/bpf/syscall.o)

2020-07-27 Thread Andrii Nakryiko
On Mon, Jul 27, 2020 at 11:58 AM Randy Dunlap wrote: > > On 7/27/20 6:23 AM, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20200724: > > > > on i386: > when CONFIG_XPS is not set/enabled: > > ld: kernel/bpf/syscall.o: in function `__do_sys_bpf': > syscall.c:(.text+0x4482): undefined re

Re: [PATCH bpf-next v2 27/35] bpf: eliminate rlimit-based memory accounting infra for bpf maps

2020-07-27 Thread Song Liu
On Mon, Jul 27, 2020 at 12:26 PM Roman Gushchin wrote: > > Remove rlimit-based accounting infrastructure code, which is not used > anymore. > > Signed-off-by: Roman Gushchin [...] > > static void bpf_map_put_uref(struct bpf_map *map) > @@ -541,7 +484,7 @@ static void bpf_map_show_fdinfo(struct s

RE: rtsx_pci not restoring ASPM state after suspend/resume

2020-07-27 Thread 吳昊澄 Ricky
> On Mon, Jul 27, 2020 at 08:52:25PM +0100, James Ettle wrote: > > On Mon, 2020-07-27 at 09:14 -0500, Bjorn Helgaas wrote: > > > I don't know the connection between ASPM and package C-states, so I > > > need to simplify this even more. All I want to do right now is > > > verify > > > that if we d

Re: [PATCH bpf-next v2 26/35] bpf: eliminate rlimit-based memory accounting for xskmap maps

2020-07-27 Thread Song Liu
On Mon, Jul 27, 2020 at 12:21 PM Roman Gushchin wrote: > > Do not use rlimit-based memory accounting for xskmap maps. > It has been replaced with the memcg-based memory accounting. > > Signed-off-by: Roman Gushchin Acked-by: Song Liu > --- > net/xdp/xskmap.c | 10 +- > 1 file changed

Re: [PATCH bpf-next v2 25/35] bpf: eliminate rlimit-based memory accounting for socket storage maps

2020-07-27 Thread Song Liu
On Mon, Jul 27, 2020 at 12:26 PM Roman Gushchin wrote: > > Do not use rlimit-based memory accounting for socket storage maps. > It has been replaced with the memcg-based memory accounting. > > Signed-off-by: Roman Gushchin Acked-by: Song Liu > --- > net/core/bpf_sk_storage.c | 11 ---

  1   2   3   4   5   6   7   8   9   10   >