Re: [Linux-kernel-mentees] [PATCH] block/scsi-ioctl: Prevent kernel-infoleak in scsi_put_cdrom_generic_arg()

2020-07-27 Thread Jens Axboe
On 7/27/20 10:19 AM, Peilin Ye wrote: > scsi_put_cdrom_generic_arg() is copying uninitialized stack memory to > userspace due to the compiler not initializing holes in statically > allocated structures. Fix it by initializing `cgc32` using memset(). Could also just add the appropriate pad, so the

Re: [PATCH 12/26] netfilter: switch nf_setsockopt to sockptr_t

2020-07-27 Thread Christoph Hellwig
On Mon, Jul 27, 2020 at 06:16:32PM +0200, Jason A. Donenfeld wrote: > Maybe sockptr_advance should have some safety checks and sometimes > return -EFAULT? Or you should always use the implementation where > being a kernel address is an explicit bit of sockptr_t, rather than > being implicit? I

[Linux-kernel-mentees] [PATCH] block/scsi-ioctl: Prevent kernel-infoleak in scsi_put_cdrom_generic_arg()

2020-07-27 Thread Peilin Ye
scsi_put_cdrom_generic_arg() is copying uninitialized stack memory to userspace due to the compiler not initializing holes in statically allocated structures. Fix it by initializing `cgc32` using memset(). Cc: sta...@vger.kernel.org Fixes: f3ee6e63a9df ("compat_ioctl: move CDROM_SEND_PACKET

[PATCH] memory: jz4780_nemc: Only request IO memory the driver will use

2020-07-27 Thread Paul Cercueil
The driver only uses the registers up to offset 0x54. Since the EFUSE registers are in the middle of the NEMC registers, we only request the registers we will use for now - that way the EFUSE driver can probe too. Tested-by: H. Nikolaus Schaller Signed-off-by: Paul Cercueil ---

[PATCH v7 4/9] hwmon: pmbus: adm1266: add debugfs for states

2020-07-27 Thread alexandru.tachici
From: Alexandru Tachici Add a debugfs entry which prints the current state of the adm1266 sequencer. Signed-off-by: Alexandru Tachici --- drivers/hwmon/pmbus/adm1266.c | 41 ++- 1 file changed, 40 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 08/10] media: uapi: h264: Clean slice invariants syntax elements

2020-07-27 Thread Ezequiel Garcia
On Mon, 2020-07-27 at 16:52 +0200, Tomasz Figa wrote: > On Mon, Jul 27, 2020 at 4:39 PM Ezequiel Garcia > wrote: > > Hi Alexandre, > > > > Thanks a lot for the review. > > > > On Sat, 2020-07-25 at 23:34 +0900, Alexandre Courbot wrote: > > > On Thu, Jul 16, 2020 at 5:23 AM Ezequiel Garcia >

[PATCH v7 3/9] hwmon: pmbus: adm1266: Add support for GPIOs

2020-07-27 Thread alexandru.tachici
From: Alexandru Tachici Adm1266 exposes 9 GPIOs and 16 PDIOs which are currently read-only. They are controlled by the internal sequencing engine. This patch makes adm1266 driver expose GPIOs and PDIOs to user-space using GPIO provider kernel api. Signed-off-by: Alexandru Tachici ---

[PATCH v7 5/9] hwmon: pmbus: adm1266: read blackbox

2020-07-27 Thread alexandru.tachici
From: Alexandru Tachici Use the nvmem kernel api to expose the black box chip functionality to userspace. Using this feature, the device is capable of recording to nonvolatile flash memory the vital data about the system status that caused the system to perform a black box write. A blackbox is

[PATCH v7 2/9] hwmon: pmbus: adm1266: Add Block process call

2020-07-27 Thread alexandru.tachici
From: Alexandru Tachici PmBus devices support Block Write-Block Read Process Call described in SMBus specification v 2.0 with the exception that Block writes and reads are permitted to have up 255 data bytes instead of max 32 bytes (SMBus). This patch adds Block WR process call support for

[PATCH v7 7/9] hwmon: pmbus: adm1266: program firmware

2020-07-27 Thread alexandru.tachici
From: Alexandru Tachici Writing the firmware Intel hex file to the nvmem, of the master adm1266, with offset 0, will now trigger the firmware programming of all cascaded devices simultaneously through pmbus. During this process all adm1266 sequencers will be stopped and at the end will be

[PATCH v7 1/9] hwmon: pmbus: adm1266: add support

2020-07-27 Thread alexandru.tachici
From: Alexandru Tachici Add pmbus probing driver for the adm1266 Cascadable Super Sequencer with Margin Control and Fault Recording. Driver is using the pmbus_core, creating sysfs files under hwmon for inputs: vh1->vh4 and vp1->vp13. Signed-off-by: Alexandru Tachici ---

[PATCH v7 6/9] hwmon: pmbus: adm1266: Add group command support

2020-07-27 Thread alexandru.tachici
From: Alexandru Tachici The Group Command Protocol is used to send commands to more than one PMBus device. Some devices working together require that they must execute some commands all at once. The commands are sent in one continuous transmission. When the devices detect the STOP condition

[PATCH v7 8/9] hwmon: pmbus: adm1266: program configuration

2020-07-27 Thread alexandru.tachici
From: Alexandru Tachici Writing the configuration Intel hex file to the nvmem, of an adm1266, with offset 0x3, will now trigger the configuration programming. During this process the adm1266 sequencer will be stopped and at the end will be issued a seq reset (see AN-1453 Programming the

[PATCH v7 9/9] dt-bindings: hwmon: Add bindings for ADM1266

2020-07-27 Thread alexandru.tachici
From: Alexandru Tachici Add bindings for the Analog Devices ADM1266 sequencer. Signed-off-by: Alexandru Tachici --- .../bindings/hwmon/adi,adm1266.yaml | 56 +++ 1 file changed, 56 insertions(+) create mode 100644

[PATCH v7 0/9] hwmon: pmbus: adm1266: add support

2020-07-27 Thread alexandru.tachici
From: Alexandru Tachici Add PMBus probing driver for the adm1266 Cascadable Super Sequencer with Margin Control and Fault Recording. Driver is using the pmbus_core, creating sysfs files under hwmon for inputs: vh1->vh4 and vp1->vp13. 1. Add PMBus probing driver for inputs vh1->vh4 and

[PATCH v7 5/9] hwmon: pmbus: adm1266: read blackbox

2020-07-27 Thread alexandru.tachici
From: Alexandru Tachici Use the nvmem kernel api to expose the black box chip functionality to userspace. Using this feature, the device is capable of recording to nonvolatile flash memory the vital data about the system status that caused the system to perform a black box write. A blackbox is

[PATCH v7 4/9] hwmon: pmbus: adm1266: add debugfs for states

2020-07-27 Thread alexandru.tachici
From: Alexandru Tachici Add a debugfs entry which prints the current state of the adm1266 sequencer. Signed-off-by: Alexandru Tachici --- drivers/hwmon/pmbus/adm1266.c | 41 ++- 1 file changed, 40 insertions(+), 1 deletion(-) diff --git

[PATCH v7 2/9] hwmon: pmbus: adm1266: Add Block process call

2020-07-27 Thread alexandru.tachici
From: Alexandru Tachici PmBus devices support Block Write-Block Read Process Call described in SMBus specification v 2.0 with the exception that Block writes and reads are permitted to have up 255 data bytes instead of max 32 bytes (SMBus). This patch adds Block WR process call support for

Re: [PATCH] qed: fix assignment of n_rq_elems to incorrect params field

2020-07-27 Thread Jason Gunthorpe
On Mon, Jul 27, 2020 at 03:17:12PM +0100, Colin King wrote: > From: Colin Ian King > > Currently n_rq_elems is being assigned to params.elem_size instead of the > field params.num_elems. Coverity is detecting this as a double assingment > to params.elem_size and reporting this as an usused

[PATCH v7 6/9] hwmon: pmbus: adm1266: Add group command support

2020-07-27 Thread alexandru.tachici
From: Alexandru Tachici The Group Command Protocol is used to send commands to more than one PMBus device. Some devices working together require that they must execute some commands all at once. The commands are sent in one continuous transmission. When the devices detect the STOP condition

[PATCH v7 9/9] dt-bindings: hwmon: Add bindings for ADM1266

2020-07-27 Thread alexandru.tachici
From: Alexandru Tachici Add bindings for the Analog Devices ADM1266 sequencer. Signed-off-by: Alexandru Tachici --- .../bindings/hwmon/adi,adm1266.yaml | 56 +++ 1 file changed, 56 insertions(+) create mode 100644

Re: [PATCH] KVM: nVMX: properly pad struct kvm_vmx_nested_state_hdr

2020-07-27 Thread Paolo Bonzini
On 27/07/20 17:46, Sean Christopherson wrote: >> It might as well send it now if the code didn't attempt to zero the >> struct before filling it in (this is another good reason to use a >> "flags" field to say what's been filled in). > The issue is that flags itself could hold garbage. > >

Re: [PATCH 12/26] netfilter: switch nf_setsockopt to sockptr_t

2020-07-27 Thread Jason A. Donenfeld
On Mon, Jul 27, 2020 at 5:06 PM Christoph Hellwig wrote: > > On Mon, Jul 27, 2020 at 05:03:10PM +0200, Jason A. Donenfeld wrote: > > Hi Christoph, > > > > On Thu, Jul 23, 2020 at 08:08:54AM +0200, Christoph Hellwig wrote: > > > diff --git a/net/ipv4/ip_sockglue.c b/net/ipv4/ip_sockglue.c > > >

Re: [PATCH 2/2] media: bt8xx: avoid a useless memset

2020-07-27 Thread Joe Perches
On Mon, 2020-07-27 at 09:09 -0700, Joe Perches wrote: > On Mon, 2020-07-27 at 15:51 +0200, Christophe JAILLET wrote: > > Avoid a memset after a call to 'dma_alloc_coherent()'. > > This is useless since > > commit 518a2f1925c3 ("dma-mapping: zero memory returned from dma_alloc_*") > [] > > diff

[PATCH v7 8/9] hwmon: pmbus: adm1266: program configuration

2020-07-27 Thread alexandru.tachici
From: Alexandru Tachici Writing the configuration Intel hex file to the nvmem, of an adm1266, with offset 0x3, will now trigger the configuration programming. During this process the adm1266 sequencer will be stopped and at the end will be issued a seq reset (see AN-1453 Programming the

Re: [PATCH 12/26] netfilter: switch nf_setsockopt to sockptr_t

2020-07-27 Thread Christoph Hellwig
Can you try the patch below? --- >From cce2d2e1b43ecee5f4af7cf116808b74b330080f Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date: Mon, 27 Jul 2020 17:42:27 +0200 Subject: net: remove sockptr_advance sockptr_advance never properly worked. Replace it with _offset variants of

Re: [PATCH v2 1/3] dt-bindings: rtc: pcf8523: add DSM pm option for battery switch-over

2020-07-27 Thread Alexandre Belloni
On 27/07/2020 17:55:50+0200, Jon Nettleton wrote: > > So, can we please have that discussion, it is pertinent to this patch. > > > > Thinking about this some more, I believe whether or not an IOCTL > interface is in the works or needed is irrelevant. This patch > describes the hardware and how

[PATCH v7 1/9] hwmon: pmbus: adm1266: add support

2020-07-27 Thread alexandru.tachici
From: Alexandru Tachici Add pmbus probing driver for the adm1266 Cascadable Super Sequencer with Margin Control and Fault Recording. Driver is using the pmbus_core, creating sysfs files under hwmon for inputs: vh1->vh4 and vp1->vp13. Signed-off-by: Alexandru Tachici ---

[PATCH v7 0/9] hwmon: pmbus: adm1266: add support

2020-07-27 Thread alexandru.tachici
From: Alexandru Tachici Add PMBus probing driver for the adm1266 Cascadable Super Sequencer with Margin Control and Fault Recording. Driver is using the pmbus_core, creating sysfs files under hwmon for inputs: vh1->vh4 and vp1->vp13. 1. Add PMBus probing driver for inputs vh1->vh4 and

Re: [PATCH 19/26] net/ipv6: switch ipv6_flowlabel_opt to sockptr_t

2020-07-27 Thread Christoph Hellwig
I have to admit I didn't spot the difference between the good and the bad output even after trying hard.. But can you try the patch below? --- >From cce2d2e1b43ecee5f4af7cf116808b74b330080f Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date: Mon, 27 Jul 2020 17:42:27 +0200 Subject: net:

[PATCH v7 3/9] hwmon: pmbus: adm1266: Add support for GPIOs

2020-07-27 Thread alexandru.tachici
From: Alexandru Tachici Adm1266 exposes 9 GPIOs and 16 PDIOs which are currently read-only. They are controlled by the internal sequencing engine. This patch makes adm1266 driver expose GPIOs and PDIOs to user-space using GPIO provider kernel api. Signed-off-by: Alexandru Tachici ---

[PATCH v7 7/9] hwmon: pmbus: adm1266: program firmware

2020-07-27 Thread alexandru.tachici
From: Alexandru Tachici Writing the firmware Intel hex file to the nvmem, of the master adm1266, with offset 0, will now trigger the firmware programming of all cascaded devices simultaneously through pmbus. During this process all adm1266 sequencers will be stopped and at the end will be

[PATCH] ARM: multi_v7_defconfig: enable caam crypto module

2020-07-27 Thread Horia Geantă
caam crypto module is included in several ARMv7-based SoCs from i.MX, Layerscape, Vybrid families. Signed-off-by: Horia Geantă --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig

[PATCH] Re: PROBLEM: cryptsetup fails to unlock drive in 5.8-rc6 (regression)

2020-07-27 Thread Al Viro
On Mon, Jul 27, 2020 at 05:05:54PM +0100, Al Viro wrote: > On Thu, Jul 23, 2020 at 11:51:01AM -0400, Nick Bowler wrote: > > Hi, > > > > After installing Linux 5.8-rc6, it seems cryptsetup can no longer > > open LUKS volumes. Regardless of the entered passphrase (correct > > or otherwise), the

Re: [RFC PATCH 6/9] PCI: Add 'rcec' field to pci_dev for associated RCiEPs

2020-07-27 Thread Jonathan Cameron
On Mon, 27 Jul 2020 12:23:58 +0100 Jonathan Cameron wrote: > On Fri, 24 Jul 2020 10:22:20 -0700 > Sean V Kelley wrote: > > > From: Qiuxu Zhuo > > > > When attempting error recovery for an RCiEP associated with an RCEC device, > > there needs to be a way to update the Root Error Status, the

Re: [PATCH 2/2] media: bt8xx: avoid a useless memset

2020-07-27 Thread Joe Perches
On Mon, 2020-07-27 at 15:51 +0200, Christophe JAILLET wrote: > Avoid a memset after a call to 'dma_alloc_coherent()'. > This is useless since > commit 518a2f1925c3 ("dma-mapping: zero memory returned from dma_alloc_*") [] > diff --git a/drivers/media/pci/bt8xx/btcx-risc.c >

Re: [PATCH v4] kvm,x86: Exit to user space in case page fault error

2020-07-27 Thread Vitaly Kuznetsov
Vivek Goyal writes: > On Mon, Jul 20, 2020 at 05:13:59PM -0400, Vivek Goyal wrote: >> Page fault error handling behavior in kvm seems little inconsistent when >> page fault reports error. If we are doing fault synchronously >> then we capture error (-EFAULT) returned by __gfn_to_pfn_memslot()

Re: [PATCH 3/6] ASoC: amd: SND_SOC_RT5682_I2C does not build rt5682

2020-07-27 Thread Mark Brown
On Mon, Jul 27, 2020 at 10:31:24AM -0500, Pierre-Louis Bossart wrote: > On 7/27/20 9:58 AM, Ravulapati Vishnu vardhan rao wrote: > > changing SND_SOC_RT5682_I2C to SND_SOC_RT5682 because, > > This flag which was previously set as SND_SOC_RT5682 > > used to build rt5682 codec driver but by

fixes for: decruft the early init / initrd / initramfs code v2

2020-07-27 Thread Christoph Hellwig
Hi all, this series fixes up a few issues found in my git://git.infradead.org/users/hch/misc.git init-user-pointers tree. The patches are relative to it.

[PATCH 3/3] initd: pass a non-f_pos offset to kernel_read/kernel_write

2020-07-27 Thread Christoph Hellwig
Pass an explicit offset instead of ->f_pos, and to make that easier use file scope file structs and offsets everywhere except for identify_ramdisk_image instead of the current strange mix. This also fixes the fact that identify_ramdisk_image fails to reset the file position to the rd_image_start

[PATCH 1/3] initramfs: remove clean_rootfs

2020-07-27 Thread Christoph Hellwig
There is no point in trying to clean up after unpacking the initramfs failed, as it should never get past the magic number check. In addition d_genocide is actually the wrong thing to do here, it should have been simple_recursive_remove(). Fixes: 38d014f6d446 ("initramfs: simplify clean_rootfs")

[PATCH 2/3] initramfs: pass a non-f_pos offset to xwrite

2020-07-27 Thread Christoph Hellwig
Pass a offset with the same scope as the file instead of ->f_pos. Fixes: b63c1cd1c339 ("initramfs: switch initramfs unpacking to struct file based APIs") Reported-by: Al Viro Signed-off-by: Christoph Hellwig --- init/initramfs.c | 15 ++- 1 file changed, 10 insertions(+), 5

Re: PROBLEM: cryptsetup fails to unlock drive in 5.8-rc6 (regression)

2020-07-27 Thread Al Viro
On Thu, Jul 23, 2020 at 11:51:01AM -0400, Nick Bowler wrote: > Hi, > > After installing Linux 5.8-rc6, it seems cryptsetup can no longer > open LUKS volumes. Regardless of the entered passphrase (correct > or otherwise), the result is a very unhelpful "Keyslot open failed." > message. > > On

Re: [PATCH -next] arm64: Export __cpu_logical_map

2020-07-27 Thread Sudeep Holla
On Sun, Jul 26, 2020 at 05:16:27PM +0530, Sumit Gupta wrote: > > > > ERROR: modpost: "__cpu_logical_map" > > > > [drivers/cpufreq/tegra194-cpufreq.ko] undefined! > > > > > > > > ARM64 tegra194-cpufreq driver use cpu_logical_map, export > > > > __cpu_logical_map to fix build issue. > > > > > > > >

Re: [PATCH v3] smp: Fix a potential usage of stale nr_cpus

2020-07-27 Thread Thomas Gleixner
Ingo Molnar writes: >> -get_option(, _cpus); >> +if (get_option(, _cpus) != 1) >> +return -EINVAL; >> + >> if (nr_cpus > 0 && nr_cpus < nr_cpu_ids) >> nr_cpu_ids = nr_cpus; >> +else >> +return -EINVAL; > > Exactly what does 'not valid' mean,

[PATCH] virtio_balloon: fix up endian-ness for free cmd id

2020-07-27 Thread Michael S. Tsirkin
free cmd id is read using virtio endian, spec says all fields in balloon are LE. Fix it up. Fixes: 86a559787e6f ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT") Cc: sta...@vger.kernel.org Signed-off-by: Michael S. Tsirkin --- drivers/virtio/virtio_balloon.c | 6 +- 1 file changed, 5

Re: [PATCH] tools/memory-model: document the "one-time init" pattern

2020-07-27 Thread Paul E. McKenney
On Mon, Jul 27, 2020 at 04:28:27PM +0100, Matthew Wilcox wrote: > On Mon, Jul 27, 2020 at 11:17:46AM -0400, Alan Stern wrote: > > Given a type "T", an object x of type pointer-to-T, and a function > > "func" that takes various arguments and returns a pointer-to-T, the > > accepted API for calling

Re: [PATCH] net: tipc: fix general protection fault in tipc_conn_delete_sub

2020-07-27 Thread kernel test robot
in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/B-K-Karthik/net-tipc-fix-general-protection-fault-in-tipc_conn_delete_sub/20200727-211330 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

Re: [PATCH] RDMA/core: fix return error value to negative

2020-07-27 Thread Jason Gunthorpe
On Sat, Jul 25, 2020 at 10:56:27AM +0800, Li Heng wrote: > Fixes: 8d9ec9addd6c (IB/core: Add a sgid_attr pointer to struct rdma_ah_attr) > Reported-by: Hulk Robot > Signed-off-by: Li Heng > Reviewed-by: Parav Pandit > --- > drivers/infiniband/core/verbs.c | 2 +- > 1 file changed, 1

Your Urgent Assistance Needed Pls.

2020-07-27 Thread Mr.Dickson Nsebeh
Dear Friend, I contact you with good reason. My name is Mr.Dickson Nsebeh, a banker by profession, with position of ( Assistant Manager ) I will be going on retirement end of August 2020. Please can i trust you to release the sum of $9.3 Million Dollars, to you for safe keeping in any account

Re: [PATCH 18/23] init: open code setting up stdin/stdout/stderr

2020-07-27 Thread Christoph Hellwig
On Mon, Jul 27, 2020 at 04:54:53PM +0100, Al Viro wrote: > On Mon, Jul 27, 2020 at 08:48:28AM +0200, Christoph Hellwig wrote: > > On Mon, Jul 27, 2020 at 07:03:22AM +0100, Al Viro wrote: > > > On Mon, Jul 27, 2020 at 07:46:25AM +0200, Christoph Hellwig wrote: > > > > On Mon, Jul 27, 2020 at

Re: [PATCH v2 1/3] dt-bindings: rtc: pcf8523: add DSM pm option for battery switch-over

2020-07-27 Thread Jon Nettleton
On Mon, Jul 27, 2020 at 5:43 PM Russell King - ARM Linux admin wrote: > > On Mon, Jul 27, 2020 at 05:41:04PM +0200, Alexandre Belloni wrote: > > On 27/07/2020 16:24:39+0100, Russell King - ARM Linux admin wrote: > > > On Mon, Jul 27, 2020 at 04:49:38PM +0200, Alexandre Belloni wrote: > > > > On

Re: [PATCH] x86/PCI: Use MMCONFIG by default for KVM guests

2020-07-27 Thread Vitaly Kuznetsov
Andy Shevchenko writes: > On Wed, Jul 22, 2020 at 12:47 PM Vitaly Kuznetsov wrote: >> Julia Suvorova writes: > >> > Scanning for PCI devices at boot takes a long time for KVM guests. It >> > can be reduced if KVM will handle all configuration space accesses for >> > non-existent devices

Re: [PATCH 4/4] quota: simplify the quotactl compat handling

2020-07-27 Thread Al Viro
On Mon, Jul 27, 2020 at 02:41:27PM +0200, Jan Kara wrote: > On Sun 26-07-20 18:04:01, Christoph Hellwig wrote: > > Fold the misaligned u64 workarounds into the main quotactl flow instead > > of implementing a separate compat syscall handler. > > > > Signed-off-by: Christoph Hellwig > > The

Re: [PATCH 18/23] init: open code setting up stdin/stdout/stderr

2020-07-27 Thread Al Viro
On Mon, Jul 27, 2020 at 08:48:28AM +0200, Christoph Hellwig wrote: > On Mon, Jul 27, 2020 at 07:03:22AM +0100, Al Viro wrote: > > On Mon, Jul 27, 2020 at 07:46:25AM +0200, Christoph Hellwig wrote: > > > On Mon, Jul 27, 2020 at 04:05:34AM +0100, Al Viro wrote: > > > > On Tue, Jul 14, 2020 at

Re: [PATCH v5 08/10] net: eth: altera: add support for ptp and timestamping

2020-07-27 Thread Jakub Kicinski
On Mon, 27 Jul 2020 17:21:55 +0800 Ooi, Joyce wrote: > From: Dalon Westergreen > > Add support for the ptp clock used with the tse, and update > the driver to support timestamping when enabled. We also > enable debugfs entries for the ptp clock to allow some user > control and interaction with

Re: [PATCH 1/8] mfd: mt6358: refine interrupt code

2020-07-27 Thread Lee Jones
On Thu, 23 Jul 2020, Hsin-Hsiung Wang wrote: > This patch refines the interrupt related code to support new chips. Refines in what way? What makes this better? > Signed-off-by: Hsin-Hsiung Wang > --- > drivers/mfd/mt6358-irq.c| 65 > - >

Re: [PATCH] KVM: nVMX: properly pad struct kvm_vmx_nested_state_hdr

2020-07-27 Thread Sean Christopherson
On Mon, Jul 27, 2020 at 01:43:34PM +0200, Paolo Bonzini wrote: > On 13/07/20 17:54, Vitaly Kuznetsov wrote: > > Which means that userspace built for the old kernel will potentially send in > > garbage for the new 'flags' field due to it being uninitialized stack data, > > even with the layout

[Linux-kernel-mentees] [PATCH v2] firewire: Prevent kernel-infoleak in ioctl_get_info()

2020-07-27 Thread Peilin Ye
ioctl_get_info() is copying uninitialized stack memory to userspace due to the compiler not initializing holes in statically allocated structures. Fix it by initializing `event` using memset() in fill_bus_reset_event(). Cc: sta...@vger.kernel.org Fixes: 344bbc4de14e ("firewire: Generalize

Re: [PATCH] drm/amd/display: Clear dm_state for fast updates

2020-07-27 Thread Duncan
On Mon, 27 Jul 2020 10:05:01 -0400 "Kazlauskas, Nicholas" wrote: > On 2020-07-27 9:39 a.m., Christian König wrote: > > Am 27.07.20 um 07:40 schrieb Mazin Rezk: > >> This patch fixes a race condition that causes a use-after-free > >> during amdgpu_dm_atomic_commit_tail. This can occur when 2 > >>

Re: [PATCH v16 6/9] nvmet-passthru: Add passthru code to process commands

2020-07-27 Thread Logan Gunthorpe
On 2020-07-26 9:41 a.m., Christoph Hellwig wrote: > On Fri, Jul 24, 2020 at 12:33:51PM -0700, Keith Busch wrote: >> On Fri, Jul 24, 2020 at 11:25:17AM -0600, Logan Gunthorpe wrote: >>> + /* >>> +* The passthru NVMe driver may have a limit on the number of segments >>> +* which depends

Re: [PATCH v2 1/3] dt-bindings: rtc: pcf8523: add DSM pm option for battery switch-over

2020-07-27 Thread Russell King - ARM Linux admin
On Mon, Jul 27, 2020 at 05:41:04PM +0200, Alexandre Belloni wrote: > On 27/07/2020 16:24:39+0100, Russell King - ARM Linux admin wrote: > > On Mon, Jul 27, 2020 at 04:49:38PM +0200, Alexandre Belloni wrote: > > > On 27/07/2020 10:45:53+0100, Russell King - ARM Linux admin wrote: > > > > > This is

Re: [PATCH] ftrace: fix ftrace_trace_task return value

2020-07-27 Thread Steven Rostedt
On Fri, 24 Jul 2020 20:50:48 -0400 Josef Bacik wrote: > I was attempting to use pid filtering with function_graph, but it wasn't > allowing anything to make it through. Turns out ftrace_trace_task > returns false if ftrace_ignore_pid is not-empty, which isn't correct > anymore. We're now

Re: [PATCH] i2c: iproc: fix race between client unreg and isr

2020-07-27 Thread Ray Jui
Hi Wolfram, On 7/25/2020 3:18 AM, Wolfram Sang wrote: > >> I think the following sequence needs to be implemented to make this >> safe, i.e., after 'synchronize_irq', no further slave interrupt will be >> fired. >> >> In 'bcm_iproc_i2c_unreg_slave': >> >> 1. Set an atomic variable 'unreg_slave'

Re: [PATCH V4] Softirq:avoid large sched delay from the pending softirqs

2020-07-27 Thread Thomas Gleixner
Qian, qianjun.ker...@gmail.com writes: > /* > * We restart softirq processing for at most MAX_SOFTIRQ_RESTART times, > * but break the loop if need_resched() is set or after 2 ms. > - * The MAX_SOFTIRQ_TIME provides a nice upper bound in most cases, but in > - * certain cases, such as

Re: [PATCH v2 1/3] dt-bindings: rtc: pcf8523: add DSM pm option for battery switch-over

2020-07-27 Thread Alexandre Belloni
On 27/07/2020 16:24:39+0100, Russell King - ARM Linux admin wrote: > On Mon, Jul 27, 2020 at 04:49:38PM +0200, Alexandre Belloni wrote: > > On 27/07/2020 10:45:53+0100, Russell King - ARM Linux admin wrote: > > > > This is but this shouldn't be a DT property as it has to be changed > > > >

Re: [Linux-kernel-mentees] [PATCH] firewire: Prevent kernel-infoleak in ioctl_get_info()

2020-07-27 Thread Peilin Ye
On Mon, Jul 27, 2020 at 05:35:12PM +0200, Arnd Bergmann wrote: > On Mon, Jul 27, 2020 at 5:18 PM Peilin Ye wrote: > > > > ioctl_get_info() is copying uninitialized stack memory to userspace due to > > the compiler not initializing holes in statically allocated structures. > > Fix it by

Re: [RFC PATCH 6/9] PCI: Add 'rcec' field to pci_dev for associated RCiEPs

2020-07-27 Thread Sean V Kelley
On 27 Jul 2020, at 4:23, Jonathan Cameron wrote: On Fri, 24 Jul 2020 10:22:20 -0700 Sean V Kelley wrote: From: Qiuxu Zhuo When attempting error recovery for an RCiEP associated with an RCEC device, there needs to be a way to update the Root Error Status, the Uncorrectable Error Status

Re: [PATCH v4 4/5] arm64: dts: sdm845: Add OPP tables and power-domains for venus

2020-07-27 Thread Viresh Kumar
On 27-07-20, 17:38, Rajendra Nayak wrote: > > On 7/27/2020 11:23 AM, Rajendra Nayak wrote: > > > > > > On 7/24/2020 7:39 PM, Stanimir Varbanov wrote: > > > Hi, > > > > > > On 7/23/20 9:06 PM, Stanimir Varbanov wrote: > > > > Hi Rajendra, > > > > > > > > After applying 2,3 and 4/5 patches on

Re: [PATCH v5 10/16] mfd: axp20x: Allow the AXP803 to be probed by I2C

2020-07-27 Thread Lee Jones
On Fri, 24 Jul 2020, Frank Lee wrote: > From: Yangtao Li > > The AXP803 can be used both using the RSB proprietary bus, or a more > traditional I2C bus. > > Let's add that possibility. > > Signed-off-by: Yangtao Li > Acked-by: Chen-Yu Tsai > --- > drivers/mfd/axp20x-i2c.c | 2 ++ > 1 file

Re: fs/btrfs/tests/../ctree.h:2166:8: warning: type qualifiers ignored on function return type

2020-07-27 Thread David Sterba
5674157e983d > commit: f7cea56c0fff95bd5a6cd21b9fa299f66193b604 btrfs: sysfs: export > supported checksums > date: 8 months ago > config: h8300-randconfig-r021-20200727 (attached as .config) > compiler: h8300-linux-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wget > https://raw.gith

Re: [Linux-kernel-mentees] [PATCH] firewire: Prevent kernel-infoleak in ioctl_get_info()

2020-07-27 Thread Arnd Bergmann
On Mon, Jul 27, 2020 at 5:18 PM Peilin Ye wrote: > > ioctl_get_info() is copying uninitialized stack memory to userspace due to > the compiler not initializing holes in statically allocated structures. > Fix it by initializing `event` using memset() in fill_bus_reset_event(). > > Cc:

Re: [net-next v4 2/6] net: marvell: prestera: Add PCI interface support

2020-07-27 Thread Andy Shevchenko
On Mon, Jul 27, 2020 at 5:11 PM Jiri Pirko wrote: > Mon, Jul 27, 2020 at 03:29:17PM CEST, andy.shevche...@gmail.com wrote: > >On Mon, Jul 27, 2020 at 3:23 PM Vadym Kochan > >wrote: ... > >> +err_prestera_dev_register: > >> + free_irq(pci_irq_vector(pdev, 0), fw); > >> +err_request_irq:

Re: [PATCH v3 00/10] ASoC: qdsp6: add gapless compressed audio support

2020-07-27 Thread Pierre-Louis Bossart
On 7/27/20 4:37 AM, Srinivas Kandagatla wrote: This patchset adds gapless compressed audio support on q6asm. Gapless on q6asm is implemented using 2 streams in a single q6asm session. First few patches such as stream id per each command, gapless flags and silence meta data are for

Re: [PATCH 3/6] ASoC: amd: SND_SOC_RT5682_I2C does not build rt5682

2020-07-27 Thread Pierre-Louis Bossart
On 7/27/20 9:58 AM, Ravulapati Vishnu vardhan rao wrote: changing SND_SOC_RT5682_I2C to SND_SOC_RT5682 because, This flag which was previously set as SND_SOC_RT5682 used to build rt5682 codec driver but by changing into SND_SOC_RT5682_I2C is preventing to build rt5682 codec driver and machine

Re: [PATCH] Module argument to control whether intel-spi-pci attempts to turn the SPI flash chip writeable

2020-07-27 Thread Daniel Gutson
On Mon, Jul 27, 2020 at 12:15 PM Arnd Bergmann wrote: > > On Mon, Jul 27, 2020 at 5:05 PM Daniel Gutson wrote: > > On Sun, Jul 26, 2020 at 4:17 AM Greg Kroah-Hartman > > wrote: > >> > >> On Sat, Jul 25, 2020 at 02:20:03PM -0300, Daniel Gutson wrote: > >> > El sáb., 25 jul. 2020 2:56 a. m.,

Re: [Linux-kernel-mentees] [PATCH v3] media/v4l2-core: Fix kernel-infoleak in video_put_user()

2020-07-27 Thread Peilin Ye
On Mon, Jul 27, 2020 at 05:46:09PM +0300, Dan Carpenter wrote: > On Mon, Jul 27, 2020 at 10:14:16AM -0400, Peilin Ye wrote: > > Yes, I would like to! I will start from: > > > > drivers/firewire/core-cdev.c:463 > > My prefered fix for this would be to add a memset at the start of >

Re: [PATCH] tools/memory-model: document the "one-time init" pattern

2020-07-27 Thread Matthew Wilcox
On Mon, Jul 27, 2020 at 11:17:46AM -0400, Alan Stern wrote: > Given a type "T", an object x of type pointer-to-T, and a function > "func" that takes various arguments and returns a pointer-to-T, the > accepted API for calling func once would be to create once_func() as > follows: > > T

Re: [PATCH v2 1/3] dt-bindings: rtc: pcf8523: add DSM pm option for battery switch-over

2020-07-27 Thread Russell King - ARM Linux admin
On Mon, Jul 27, 2020 at 04:49:38PM +0200, Alexandre Belloni wrote: > On 27/07/2020 10:45:53+0100, Russell King - ARM Linux admin wrote: > > > This is but this shouldn't be a DT property as it has to be changed > > > dynamically. I'm working on an ioctl interface to change this > > > configuration.

Re: [PATCH] sched/fair: provide u64 read for 32-bits arch helper

2020-07-27 Thread Vincent Donnefort
On Mon, Jul 27, 2020 at 02:38:01PM +0200, pet...@infradead.org wrote: > On Mon, Jul 27, 2020 at 11:59:24AM +0100, vincent.donnef...@arm.com wrote: > > From: Vincent Donnefort > > > > Introducing two macro helpers u64_32read() and u64_32read_set_copy() to > > factorize the u64 vminruntime and

Re: [RFC PATCH 1/9] pci_ids: Add class code and extended capability for RCEC

2020-07-27 Thread Sean V Kelley
On 27 Jul 2020, at 3:21, Jonathan Cameron wrote: On Mon, 27 Jul 2020 11:00:10 +0100 Jonathan Cameron wrote: On Fri, 24 Jul 2020 10:22:15 -0700 Sean V Kelley wrote: From: Qiuxu Zhuo A PCIe Root Complex Event Collector(RCEC) has the base class 0x08, sub-class 0x07, and programming

Re: [RFC PATCH 3/9] PCI/portdrv: Add pcie_walk_rcec() to walk RCiEPs associated with RCEC

2020-07-27 Thread Sean V Kelley
Hi, Comments below: On 27 Jul 2020, at 3:49, Jonathan Cameron wrote: On Fri, 24 Jul 2020 10:22:17 -0700 Sean V Kelley wrote: From: Qiuxu Zhuo When an RCEC device signals error(s) to a CPU core, the CPU core needs to walk all the RCiEPs associated with that RCEC to check errors. So add

Re: [RFC PATCH 7/9] PCI/AER: Add RCEC AER handling

2020-07-27 Thread Sean V Kelley
On 27 Jul 2020, at 5:22, Jonathan Cameron wrote: On Fri, 24 Jul 2020 10:22:21 -0700 Sean V Kelley wrote: The Root Complex Event Collectors(RCEC) appear as peers to Root Ports and also have the AER capability. So add RCEC support to the current AER service driver and attach the AER service

[Linux-kernel-mentees] [PATCH] firewire: Prevent kernel-infoleak in ioctl_get_info()

2020-07-27 Thread Peilin Ye
ioctl_get_info() is copying uninitialized stack memory to userspace due to the compiler not initializing holes in statically allocated structures. Fix it by initializing `event` using memset() in fill_bus_reset_event(). Cc: sta...@vger.kernel.org Suggested-by: Dan Carpenter Suggested-by: Arnd

[PATCH v3 2/2] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-27 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Allow intel_pstate to work in the passive mode with HWP enabled and make it set the HWP minimum performance limit (HWP floor) to the P-state value given by the target frequency supplied by the cpufreq governor, so as to prevent the HWP algorithm and the CPU scheduler from

[PATCH v3 1/2] cpufreq: intel_pstate: Rearrange the storing of new EPP values

2020-07-27 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Move the locking away from intel_pstate_set_energy_pref_index() into its only caller and drop the (now redundant) return_pref label from it. Also move the "raw" EPP value check into the caller of that function, so as to do it before acquiring the mutex, and reduce code

Re: [PATCH] tools/memory-model: document the "one-time init" pattern

2020-07-27 Thread Alan Stern
On Fri, Jul 17, 2020 at 10:28:18PM -0700, Eric Biggers wrote: > I'm still not sure this is the best API. I cast my vote for something along the following lines. It's simple, easily understood and easily used. The approach has two variants: One that returns an integer and one that returns a

[PATCH v3 0/2] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-27 Thread Rafael J. Wysocki
Hi All, On Thursday, July 16, 2020 7:37:04 PM CEST Rafael J. Wysocki wrote: > > This really is a v2 of this patch: > > https://patchwork.kernel.org/patch/11663271/ > > with an extra preceding cleanup patch to avoid making unrelated changes in the > [2/2]. Almost the same as before, but the

[PATCH v2 1/1] Input: atmel_mxt_ts - only read messages in mxt_acquire_irq() when necessary

2020-07-27 Thread Jiada Wang
From: Nick Dyer The workaround of reading all messages until an invalid is received is a way of forcing the CHG line high, which means that when using edge-triggered interrupts the interrupt can be acquired. With level-triggered interrupts the workaround is unnecessary. Also, most recent

Re: [PATCH] Module argument to control whether intel-spi-pci attempts to turn the SPI flash chip writeable

2020-07-27 Thread Arnd Bergmann
On Mon, Jul 27, 2020 at 5:05 PM Daniel Gutson wrote: > On Sun, Jul 26, 2020 at 4:17 AM Greg Kroah-Hartman > wrote: >> >> On Sat, Jul 25, 2020 at 02:20:03PM -0300, Daniel Gutson wrote: >> > El sáb., 25 jul. 2020 2:56 a. m., Greg Kroah-Hartman < >> > gre...@linuxfoundation.org> escribió: >> > >>

Re: [LTP] [blk] 6e6fcbc27e: ltp.fs_fill.fail

2020-07-27 Thread Ming Lei
On Mon, Jul 27, 2020 at 11:31:56AM +0200, Petr Vorel wrote: > Hi, > > > FYI, we noticed the following commit (built with gcc-9): > > > commit: 6e6fcbc27e7788af54139c53537395d95560f2ef ("blk-mq: support batching > > dispatch in case of io") > >

fs/btrfs/tests/../ctree.h:2166:8: warning: type qualifiers ignored on function return type

2020-07-27 Thread kernel test robot
config: h8300-randconfig-r021-20200727 (attached as .config) compiler: h8300-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout

Re: [PATCH][next] counter: microchip-tcb-capture: remove ATMEL_TC_ETRGEDG_NONE bit check

2020-07-27 Thread William Breathitt Gray
On Mon, Jul 27, 2020 at 03:06:00PM +0100, Colin King wrote: > From: Colin Ian King > > The macro ATMEL_TC_ETRGEDG_NONE is defined as 0 << 8 which is zero and > hence the check cmr & ATMEL_TC_ETRGEDG_NONE can never be true. Since > *action is already assigned MCHP_TC_SYNAPSE_ACTION_NONE then this

arch/mips/include/asm/mach-ip27/topology.h:19:7: error: implicit declaration of function 'hub_data'

2020-07-27 Thread kernel test robot
months ago config: mips-randconfig-r016-20200727 (attached as .config) compiler: mips64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git

Re: [PATCH v3 4/4] xen: add helpers to allocate unpopulated memory

2020-07-27 Thread Jürgen Groß
On 27.07.20 11:13, Roger Pau Monne wrote: To be used in order to create foreign mappings. This is based on the ZONE_DEVICE facility which is used by persistent memory devices in order to create struct pages and kernel virtual mappings for the IOMEM areas of such devices. Note that on kernels

Re: linux-next: Fixes tag needs some work in the printk tree

2020-07-27 Thread John Ogness
On 2020-07-27, Stephen Rothwell wrote: > In commit > > 96b917f8e9ec ("printk: ringbuffer: support dataless records") > > Fixes tag > > Fixes: ("printk: use the lockless ringbuffer") > > has these problem(s): > > - No SHA1 recognised > > Maybe you meant > > Fixes: 896fbe20b4e2 ("printk: use

Re: [PATCH 12/26] netfilter: switch nf_setsockopt to sockptr_t

2020-07-27 Thread Christoph Hellwig
On Mon, Jul 27, 2020 at 05:03:10PM +0200, Jason A. Donenfeld wrote: > Hi Christoph, > > On Thu, Jul 23, 2020 at 08:08:54AM +0200, Christoph Hellwig wrote: > > diff --git a/net/ipv4/ip_sockglue.c b/net/ipv4/ip_sockglue.c > > index da933f99b5d517..42befbf12846c0 100644 > > ---

Re: [RFC PATCH 2/9] PCI: Extend Root Port Driver to support RCEC

2020-07-27 Thread Sean V Kelley
On 27 Jul 2020, at 5:30, Jonathan Cameron wrote: On Fri, 24 Jul 2020 10:22:16 -0700 Sean V Kelley wrote: From: Qiuxu Zhuo If a Root Complex Integrated Endpoint (RCiEP) is implemented, errors may optionally be sent to a corresponding Root Complex Event Collector (RCEC). Each RCiEP must be

Re: [Freedreno] [PATCH v10 06/13] iommu/arm-smmu-qcom: Get and set the pagetable config for split pagetables

2020-07-27 Thread Jordan Crouse
On Sun, Jul 26, 2020 at 10:03:07AM -0700, Rob Clark wrote: > On Mon, Jul 20, 2020 at 8:41 AM Jordan Crouse wrote: > > > > The Adreno GPU has the capability to manage its own pagetables and switch > > them dynamically from the hardware. To do this the GPU uses TTBR1 for > > "global" GPU memory and

Re: [RESEND PATCH] usb: common: usb-conn-gpio: Register optional charger

2020-07-27 Thread Paul Cercueil
Le lun. 27 juil. 2020 à 13:42, Chunfeng Yun a écrit : On Sun, 2020-07-26 at 12:27 +0200, Paul Cercueil wrote: Le dim. 26 juil. 2020 à 13:14, Andy Shevchenko a écrit : > On Mon, Jun 22, 2020 at 1:51 AM Paul Cercueil > wrote: >> >> Register a power supply charger, if the Kconfig

<    4   5   6   7   8   9   10   11   12   13   >