Re: [PATCH 00/16] IOMMU driver for Kirin 960/970

2020-08-18 Thread John Stultz
On Tue, Aug 18, 2020 at 9:26 AM Robin Murphy wrote: > On 2020-08-18 16:29, Mauro Carvalho Chehab wrote: > > Em Tue, 18 Aug 2020 15:47:55 +0100 > > Basically, the DT binding has this, for IOMMU: > > > > > > smmu_lpae { > > compatible = "hisilicon,smmu-lpae"; > > }; > > >

Re: [PATCH] rcu: shrink each possible cpu krcp

2020-08-18 Thread Paul E. McKenney
On Tue, Aug 18, 2020 at 11:55:11PM +0200, Uladzislau Rezki wrote: > > On Tue, Aug 18, 2020 at 03:00:35PM -0400, Joel Fernandes wrote: > > > On Tue, Aug 18, 2020 at 1:18 PM Paul E. McKenney > > > wrote: > > > > > > > > On Mon, Aug 17, 2020 at 06:03:54PM -0400, Joel Fernandes wrote: > > > > > On

Re: [PATCH 0/4] -ffreestanding/-fno-builtin-* patches

2020-08-18 Thread Nick Desaulniers
On Tue, Aug 18, 2020 at 2:41 PM Arvind Sankar wrote: > > On Tue, Aug 18, 2020 at 01:58:51PM -0700, Nick Desaulniers wrote: > > On Tue, Aug 18, 2020 at 1:27 PM Nick Desaulniers > > wrote: > > > > > > On Tue, Aug 18, 2020 at 1:24 PM Arvind Sankar > > > wrote: > > > > > > > > On Tue, Aug 18, 2020

Re: [PATCH v3] drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets

2020-08-18 Thread Stephen Boyd
Quoting Kuogee Hsieh (2020-08-18 14:15:46) > add event thread to execute events serially from event queue. Also > timeout mode is supported which allow an event be deferred to be > executed at later time. Both link and phy compliant tests had been > done successfully. > > Changes in v2: > - Fix

Re: [GIT PULL] mailmap update for v5.9-rc2

2020-08-18 Thread Kees Cook
On Mon, Aug 17, 2020 at 05:32:32PM -0700, Linus Torvalds wrote: > If you want dictionary sorting you'd use "sort -d". > > But the commit message says "sort -f". O_o Err, I don't know how that happened. I must have cut/pasted into the commit log from my command history at the wrong place or

Re: [RFC PATCH v2 0/3] mikroBUS driver for add-on boards

2020-08-18 Thread Vaishnav M A
On Wed, Aug 19, 2020 at 2:08 AM Frank Rowand wrote: > > Hi Vaishnav, > > +me +devicetree > > Please add these two recipients to future versions. > > I will comment more after reading the first version and v2. > > -Frank > Hi Frank, Sorry, I missed to run get_maintainer.pl after making the

Re: [PATCH] rcu: shrink each possible cpu krcp

2020-08-18 Thread Uladzislau Rezki
> On Tue, Aug 18, 2020 at 03:00:35PM -0400, Joel Fernandes wrote: > > On Tue, Aug 18, 2020 at 1:18 PM Paul E. McKenney wrote: > > > > > > On Mon, Aug 17, 2020 at 06:03:54PM -0400, Joel Fernandes wrote: > > > > On Fri, Aug 14, 2020 at 2:51 PM Uladzislau Rezki > > > > wrote: > > > > > > > > > > >

RE: [PATCH 0/4] -ffreestanding/-fno-builtin-* patches

2020-08-18 Thread David Laight
From: Nick Desaulniers > Sent: 18 August 2020 21:59 > > On Tue, Aug 18, 2020 at 1:27 PM Nick Desaulniers > wrote: ... > > > -ffreestanding as it stands today does have __builtin_memcpy and > > > friends. But you need to then use #define memcpy __builtin_memcpy etc, > > > which is messy and also

Re: [RFC PATCH v2 0/3] mikroBUS driver for add-on boards

2020-08-18 Thread Vaishnav M A
On Tue, Aug 18, 2020 at 8:54 PM Greg KH wrote: > > On Tue, Aug 18, 2020 at 06:18:12PM +0530, Vaishnav M A wrote: > > Hi, > > > > This Patch series is an update to the mikroBUS driver > > RFC v1 Patch : https://lkml.org/lkml/2020/7/24/518 . > > Please use lore.kernel.org for links, we have no idea

Re: [PATCH 0/4] -ffreestanding/-fno-builtin-* patches

2020-08-18 Thread Dávid Bolvanský
So -fno-builtin-stpcpy is not ideal solution then.. gcc may implement this opt too and here we go again, red builds. We should either provide stpcpy implementation or fix few places and do not use sprintf there. > Dňa 18. 8. 2020 o 23:41 užívateľ Arvind Sankar > napísal: > > On Tue, Aug

Re: [PATCH 04/10] remoteproc: imx_rproc: make syscon optional

2020-08-18 Thread Mathieu Poirier
Hi Peng, On Fri, Jul 24, 2020 at 04:08:07PM +0800, Peng Fan wrote: > Make syscon optional, since i.MX8QM/QXP/7ULP not have SRC to control M4. > But currently i.MX8QM/QXP/7ULP not added, so still check regmap > when start/stop to avoid unhappy things. On the i.MX8QM/QXP/7ULP processors, the

Re: [PATCH v3] arm64: dts: qcom: sc7180: Add DisplayPort HPD pin dt node

2020-08-18 Thread Stephen Boyd
Quoting Tanmay Shah (2020-08-17 20:36:57) > This node defines alternate DP HPD functionality of GPIO. > > Signed-off-by: Tanmay Shah > --- Reviewed-by: Stephen Boyd

Re: [PATCH 0/4] -ffreestanding/-fno-builtin-* patches

2020-08-18 Thread Arvind Sankar
On Tue, Aug 18, 2020 at 01:58:51PM -0700, Nick Desaulniers wrote: > On Tue, Aug 18, 2020 at 1:27 PM Nick Desaulniers > wrote: > > > > On Tue, Aug 18, 2020 at 1:24 PM Arvind Sankar wrote: > > > > > > On Tue, Aug 18, 2020 at 12:13:22PM -0700, Linus Torvalds wrote: > > > > On Tue, Aug 18, 2020 at

[PATCH v6 0/5] iio: temperature: mlx90632: Add extended calibration calculations

2020-08-18 Thread Crt Mori
Add extended calibration calculations for the new subversion of DSP5. V6 review comments from Andy Shevchenko V5: - Add style changes patch along with current series. V4 review comments from Andy Shevchenko : - Move the function creation for Ta4 to first patch - Add

[PATCH v6 2/5] iio:temperature:mlx90632: Add kerneldoc to the internal struct

2020-08-18 Thread Crt Mori
Document internal/private struct for mlx90632 device. Signed-off-by: Crt Mori Reviewed-by: Andy Shevchenko --- drivers/iio/temperature/mlx90632.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/iio/temperature/mlx90632.c b/drivers/iio/temperature/mlx90632.c

[PATCH v6 1/5] iio:temperature:mlx90632: Reduce number of equal calulcations

2020-08-18 Thread Crt Mori
TAdut4 was calculated each iteration although it did not change. In light of near future additions of the Extended range DSP calculations, this function refactoring will help reduce unrelated changes in that series as well as reduce the number of new functions needed. Signed-off-by: Crt Mori

[PATCH v6 3/5] iio:temperature:mlx90632: Convert polling while loop to regmap

2020-08-18 Thread Crt Mori
Reduce number of lines and improve readability to convert polling while loops to regmap_read_poll_timeout. Signed-off-by: Crt Mori --- drivers/iio/temperature/mlx90632.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/iio/temperature/mlx90632.c

[PATCH v6 4/5] iio:temperature:mlx90632: Adding extended calibration option

2020-08-18 Thread Crt Mori
For some time the market wants medical grade accuracy in medical range, while still retaining the declared accuracy outside of the medical range within the same sensor. That is why we created extended calibration which is automatically switched to when object temperature is too high. This patch

Re: [PATCH v3 16/19] media: rkvdec: Drop unneeded per_request driver-specific control flag

2020-08-18 Thread Ezequiel Garcia
On Tue, 2020-08-18 at 20:17 +, Jonas Karlman wrote: > Hi Ezequiel, > > On 2020-08-14 15:36, Ezequiel Garcia wrote: > > Currently, the drivers makes no distinction between per_request > > and mandatory, as both are used in the same request validate check. > > > > The driver only cares to know

[PATCH v6 5/5] iio:temperature:mlx90632: Some stylefixing leftovers

2020-08-18 Thread Crt Mori
There is some inconsistency and whitespace cleanup performed in this patch. It was done on top of my other patches, but I can rebase to head of the togreg branch if it would go in sooner. Signed-off-by: Crt Mori --- drivers/iio/temperature/mlx90632.c | 10 +- 1 file changed, 5

Re: [PATCH 4.19 073/168] media: firewire: Using uninitialized values in node_probe()

2020-08-18 Thread Pavel Machek
Hi! > From: Dan Carpenter > > [ Upstream commit 2505a210fc126599013aec2be741df20aaacc490 ] > > If fw_csr_string() returns -ENOENT, then "name" is uninitialized. So > then the "strlen(model_names[i]) <= name_len" is true because strlen() > is unsigned and -ENOENT is type promoted to a very

Re: [GIT PULL] Fix regression in IA-64 caused by page table allocation refactoring

2020-08-18 Thread pr-tracker-bot
The pull request you sent on Tue, 18 Aug 2020 13:15:49 +0300: > https://git.kernel.org/pub/scm/linux/kernel/git/rppt/memblock.git > tags/fixes-2020-08-18 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/9899b587588fb6ced0597e188e049f1ab92c7003 Thank you! --

Re: [GIT PULL] SPI fixes for v5.9-rc1

2020-08-18 Thread pr-tracker-bot
The pull request you sent on Tue, 18 Aug 2020 19:32:51 +0100: > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git > tags/spi-fix-v5.9-rc1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/18445bf405cb331117bc98427b1ba6f12418ad17 Thank you! --

Re: [greybus-dev] [RFC PATCH v2 3/3] Add Device Tree Bindings for mikroBUS port

2020-08-18 Thread Vaishnav M A
On Tue, Aug 18, 2020 at 7:05 PM Laurent Pinchart wrote: > > Hi Vaishnav, > > Thank you for the patch. > > On Tue, Aug 18, 2020 at 06:18:15PM +0530, Vaishnav M A wrote: > > This patch adds device tree bindings for the mikroBUS port, > > device tree overlays for the mikrobus Port on the

[PATCH v3] drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets

2020-08-18 Thread Kuogee Hsieh
add event thread to execute events serially from event queue. Also timeout mode is supported which allow an event be deferred to be executed at later time. Both link and phy compliant tests had been done successfully. Changes in v2: - Fix potential deadlock by removing redundant connect_mutex -

Re: [PATCH] coresight: etm4x: Handle unreachable sink in perf mode

2020-08-18 Thread Jeremy Linton
Hi, On 8/18/20 2:29 PM, Suzuki K Poulose wrote: If the specified/hinted sink is not reachable from a subset of the CPUs, we could end up unable to trace the event on those CPUs. This is the best effort we could do until we support 1:1 configurations. Fail gracefully in such cases avoiding a

Re: [PATCH] iio: pulse: Support PWM capture with TI AM3358 eCAP module

2020-08-18 Thread kernel test robot
Hi Darren, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on iio/togreg] [also build test WARNING on linux/master linus/master v5.9-rc1 next-20200818] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

Re: [PATCH] rcu: shrink each possible cpu krcp

2020-08-18 Thread Paul E. McKenney
On Tue, Aug 18, 2020 at 03:00:35PM -0400, Joel Fernandes wrote: > On Tue, Aug 18, 2020 at 1:18 PM Paul E. McKenney wrote: > > > > On Mon, Aug 17, 2020 at 06:03:54PM -0400, Joel Fernandes wrote: > > > On Fri, Aug 14, 2020 at 2:51 PM Uladzislau Rezki wrote: > > > > > > > > > From: Zqiang > > > >

Re: [PATCH] block: convert tasklets to use new tasklet_setup() API

2020-08-18 Thread James Bottomley
On Tue, 2020-08-18 at 13:10 -0700, Kees Cook wrote: > On Tue, Aug 18, 2020 at 01:00:33PM -0700, James Bottomley wrote: > > On Mon, 2020-08-17 at 13:02 -0700, Jens Axboe wrote: > > > On 8/17/20 12:48 PM, Kees Cook wrote: > > > > On Mon, Aug 17, 2020 at 12:44:34PM -0700, Jens Axboe wrote: > > > > >

Re: [PATCH 0/4] -ffreestanding/-fno-builtin-* patches

2020-08-18 Thread Nick Desaulniers
On Tue, Aug 18, 2020 at 1:27 PM Nick Desaulniers wrote: > > On Tue, Aug 18, 2020 at 1:24 PM Arvind Sankar wrote: > > > > On Tue, Aug 18, 2020 at 12:13:22PM -0700, Linus Torvalds wrote: > > > On Tue, Aug 18, 2020 at 12:03 PM H. Peter Anvin wrote: > > > > > > > > I'm not saying "change the

Re: [PATCH 0/3] Chunk Heap Support on DMA-HEAP

2020-08-18 Thread John Stultz
On Tue, Aug 18, 2020 at 12:45 AM Hyesoo Yu wrote: > > These patch series to introduce a new dma heap, chunk heap. > That heap is needed for special HW that requires bulk allocation of > fixed high order pages. For example, 64MB dma-buf pages are made up > to fixed order-4 pages * 1024. > > The

Re: file metadata via fs API

2020-08-18 Thread Linus Torvalds
On Tue, Aug 18, 2020 at 1:18 PM Miklos Szeredi wrote: > > So why mix a binary structure into it? Would it not make more sense > to make it text only? .. because for basic and standard stuff, the binary structure just makes sense and is easier for everybody. When I want to get the size of a

Re: Kernel build system broken in 5.8?

2020-08-18 Thread Martin Burnicki
Hello Masahiro, Masahiro Yamada wrote: > On Wed, Aug 19, 2020 at 1:14 AM Martin Burnicki > wrote: [...] >> I usually build the kernel module as standard user, and only install the >> new module as root, e.g.: >> >> git checkout devel # The 'devel' branch is appropriate for testing >> cd

Re: [PATCH RFC 1/2] mm: Extract SLAB_QUARANTINE from KASAN

2020-08-18 Thread Alexander Popov
On 18.08.2020 18:45, Andrey Konovalov wrote: > On Mon, Aug 17, 2020 at 7:32 PM Alexander Popov wrote: >> >> On 15.08.2020 19:52, Kees Cook wrote: >>> On Thu, Aug 13, 2020 at 06:19:21PM +0300, Alexander Popov wrote: Heap spraying is an exploitation technique that aims to put controlled

Re: [PATCH v4 2/3] irqchip: Add Actions Semi Owl SIRQ controller

2020-08-18 Thread Marc Zyngier
On Tue, 18 Aug 2020 18:42:41 +0100, Cristian Ciocaltea wrote: > > Hi Marc, > > Thanks for your quick and detailed review! > > On Mon, Aug 17, 2020 at 02:52:06PM +0100, Marc Zyngier wrote: > > On 2020-08-16 12:33, Cristian Ciocaltea wrote: > > > This controller appears on Actions Semi Owl

Re: [RFC PATCH v2 0/3] mikroBUS driver for add-on boards

2020-08-18 Thread Frank Rowand
Hi Vaishnav, +me +devicetree Please add these two recipients to future versions. I will comment more after reading the first version and v2. -Frank On 2020-08-18 07:48, Vaishnav M A wrote: > Hi, > > This Patch series is an update to the mikroBUS driver > RFC v1 Patch :

[PATCH] mailmap: add Andi Kleen

2020-08-18 Thread Nick Desaulniers
I keep getting bounce back from the suse.de address. Cc: Andi Kleen Signed-off-by: Nick Desaulniers --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index 97fd835bd2a4..21f965400a28 100644 --- a/.mailmap +++ b/.mailmap @@ -32,6 +32,7 @@ Alex Shi Alex Shi

[PATCH] drm: ast: fix double __iomem sparse warning

2020-08-18 Thread Randy Dunlap
From: Randy Dunlap sparse complains about having 2 "__iomem" attributes on the same line where only one is needed since the first one applies to everything up to the ending ';'. However, to make it clear(er) that both of these pointers are "__iomem", use separate lines for them.

Re: [PATCH 0/4] -ffreestanding/-fno-builtin-* patches

2020-08-18 Thread Nick Desaulniers
On Tue, Aug 18, 2020 at 1:24 PM Arvind Sankar wrote: > > On Tue, Aug 18, 2020 at 12:13:22PM -0700, Linus Torvalds wrote: > > On Tue, Aug 18, 2020 at 12:03 PM H. Peter Anvin wrote: > > > > > > I'm not saying "change the semantics", nor am I saying that playing > > > whack-a-mole *for a limited

Re: [PATCH 4.19 000/168] 4.19.140-rc1 review

2020-08-18 Thread Pavel Machek
Hi! > This is the start of the stable review cycle for the 4.19.140 release. > There are 168 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses should be made by Wed, 19 Aug 2020 14:36:49

Re: [PATCH 0/4] -ffreestanding/-fno-builtin-* patches

2020-08-18 Thread Arvind Sankar
On Tue, Aug 18, 2020 at 12:13:22PM -0700, Linus Torvalds wrote: > On Tue, Aug 18, 2020 at 12:03 PM H. Peter Anvin wrote: > > > > I'm not saying "change the semantics", nor am I saying that playing > > whack-a-mole *for a limited time* is unreasonable. But I would like to go > > back > > to the

Re: [PATCH] sched/cputime: Mark function as __maybe_unused

2020-08-18 Thread Steven Rostedt
On Tue, 18 Aug 2020 13:02:26 -0700 Nick Desaulniers wrote: > On Tue, Aug 18, 2020 at 12:57 PM Alex Dewar wrote: > > > > On Tue, Aug 18, 2020 at 11:13:10AM -0700, Nick Desaulniers wrote: > > > On Tue, Aug 18, 2020 at 10:04 AM Alex Dewar > > > wrote: > > > > > > > > Depending on config

Re: file metadata via fs API

2020-08-18 Thread Miklos Szeredi
On Tue, Aug 18, 2020 at 8:51 PM Linus Torvalds wrote: > I think people who have problems parsing plain ASCII text are just > wrong. It's not that expensive. The thing that makes /proc/mounts > expensive is not the individual lines - it's that there are a lot of > them. I agree completely with

Re: [PATCH v3 16/19] media: rkvdec: Drop unneeded per_request driver-specific control flag

2020-08-18 Thread Jonas Karlman
Hi Ezequiel, On 2020-08-14 15:36, Ezequiel Garcia wrote: > Currently, the drivers makes no distinction between per_request > and mandatory, as both are used in the same request validate check. > > The driver only cares to know if a given control is > required to be part of a request, so only one

Re: [PATCH] net: gianfar: Add of_node_put() before goto statement

2020-08-18 Thread David Miller
From: Sumera Priyadarsini Date: Wed, 19 Aug 2020 00:22:41 +0530 > Every iteration of for_each_available_child_of_node() decrements > reference count of the previous node, however when control > is transferred from the middle of the loop, as in the case of > a return or break or goto, there is no

Re: [PATCH 2/2] remoteproc: Move recovery debugfs entry to sysfs

2020-08-18 Thread Mathieu Poirier
On Tue, Jul 28, 2020 at 04:08:17PM -0700, Rishabh Bhatnagar wrote: > Expose recovery mechanism through sysfs rather than exposing through > debugfs. Some operating systems may limit access to debugfs through > access policies. This restricts user access to recovery mechanism, > hence move it to

Covid 19 Recovery contract

2020-08-18 Thread Mark Paulson
Attention. I work in a pharmaceutical company. I have a contract supply opportunity to be a contractor/Supplier to the pharmaceutical company. The company always pays in advance for contractors to supply raw materials to the company. These contract opportunities will help us to gain

Re: [PATCH V2 1/3] gpio: xilinx: Add clock adaptation support

2020-08-18 Thread Bartosz Golaszewski
On Thu, Jul 23, 2020 at 4:06 PM Srinivas Neeli wrote: > > Add support of clock adaptation for AXI GPIO driver. > Please make the commit message more specific. I can tell from the patch that it's about power management but I've never heard anyone referring to it as clock adaptation. There's also

Re: [PATCH] block: convert tasklets to use new tasklet_setup() API

2020-08-18 Thread Kees Cook
On Tue, Aug 18, 2020 at 01:00:33PM -0700, James Bottomley wrote: > On Mon, 2020-08-17 at 13:02 -0700, Jens Axboe wrote: > > On 8/17/20 12:48 PM, Kees Cook wrote: > > > On Mon, Aug 17, 2020 at 12:44:34PM -0700, Jens Axboe wrote: > > > > On 8/17/20 12:29 PM, Kees Cook wrote: > > > > > On Mon, Aug

Re: [PATCH] add support for battery charging threshold, mute. correctly save ac/dc brightness to hardware registers

2020-08-18 Thread kernel test robot
Hi Kenneth, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linux/master] [also build test WARNING on linus/master v5.9-rc1 next-20200818] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH 08/11] x86: make TASK_SIZE_MAX usable from assembly code

2020-08-18 Thread Kees Cook
On Tue, Aug 18, 2020 at 10:00:16PM +0200, Christoph Hellwig wrote: > On Tue, Aug 18, 2020 at 12:59:05PM -0700, Kees Cook wrote: > > > I didn't see a problem bisecting, do you have something particular in > > > mind? > > > > Oh, I misunderstood this patch to be a fix for compilation. Is this just

Re: [PATCH net-next] net: dsa: loop: Return VLAN table size through devlink

2020-08-18 Thread Florian Fainelli
On 8/18/2020 10:43 AM, Andrew Lunn wrote: On Mon, Aug 17, 2020 at 09:03:54PM -0700, Florian Fainelli wrote: We return the VLAN table size through devlink as a simple parameter, we do not support altering it at runtime: devlink resource show mdio_bus/fixed-0:1f mdio_bus/fixed-0:1f: name

Re: [PATCH 03/11] fs: don't allow splice read/write without explicit ops

2020-08-18 Thread Christoph Hellwig
On Tue, Aug 18, 2020 at 12:58:07PM -0700, Kees Cook wrote: > On Tue, Aug 18, 2020 at 09:54:46PM +0200, Christoph Hellwig wrote: > > On Tue, Aug 18, 2020 at 12:39:34PM -0700, Kees Cook wrote: > > > On Mon, Aug 17, 2020 at 09:32:04AM +0200, Christoph Hellwig wrote: > > > > default_file_splice_write

Re: [LKP] Re: [x86/mce] 1de08dccd3: will-it-scale.per_process_ops -14.1% regression

2020-08-18 Thread Luck, Tony
On Tue, Aug 18, 2020 at 04:29:43PM +0800, Feng Tang wrote: > Hi Borislav, > > On Sat, Apr 25, 2020 at 03:01:36PM +0200, Borislav Petkov wrote: > > On Sat, Apr 25, 2020 at 07:44:14PM +0800, kernel test robot wrote: > > > Greeting, > > > > > > FYI, we noticed a -14.1% regression of

Re: [PATCH net-next RFC v2 13/13] devlink: Add Documentation/networking/devlink/devlink-reload.rst

2020-08-18 Thread Moshe Shemesh
On 8/18/2020 2:07 PM, Jiri Pirko wrote: Tue, Aug 18, 2020 at 11:14:16AM CEST, mo...@nvidia.com wrote: On 8/17/2020 7:39 PM, Jiri Pirko wrote: Mon, Aug 17, 2020 at 11:37:52AM CEST, mo...@mellanox.com wrote: Add devlink reload rst documentation file. Update index file to include it.

Re: [PATCH 1/2] remoteproc: Move coredump entry from debugfs to sysfs.

2020-08-18 Thread Mathieu Poirier
On Tue, Jul 28, 2020 at 04:08:16PM -0700, Rishabh Bhatnagar wrote: > Expose coredump configuration from sysfs instead of debugfs. > In some operating systems access to debugfs might be limited. > This restricts user from selecting the coredump configuration > at all, hence move this interface to

Re: [PATCH] sched/cputime: Mark function as __maybe_unused

2020-08-18 Thread Nick Desaulniers
On Tue, Aug 18, 2020 at 12:57 PM Alex Dewar wrote: > > On Tue, Aug 18, 2020 at 11:13:10AM -0700, Nick Desaulniers wrote: > > On Tue, Aug 18, 2020 at 10:04 AM Alex Dewar wrote: > > > > > > Depending on config options, account_other_time() may not be called > > > anywhere. Add __maybe_unused flag

Re: [PATCH 08/11] x86: make TASK_SIZE_MAX usable from assembly code

2020-08-18 Thread Christoph Hellwig
On Tue, Aug 18, 2020 at 12:59:05PM -0700, Kees Cook wrote: > > I didn't see a problem bisecting, do you have something particular in > > mind? > > Oh, I misunderstood this patch to be a fix for compilation. Is this just > a correctness fix? It prepares for using the definition from assembly,

Re: [PATCH] block: convert tasklets to use new tasklet_setup() API

2020-08-18 Thread James Bottomley
On Mon, 2020-08-17 at 13:02 -0700, Jens Axboe wrote: > On 8/17/20 12:48 PM, Kees Cook wrote: > > On Mon, Aug 17, 2020 at 12:44:34PM -0700, Jens Axboe wrote: > > > On 8/17/20 12:29 PM, Kees Cook wrote: > > > > On Mon, Aug 17, 2020 at 06:56:47AM -0700, Jens Axboe wrote: > > > > > On 8/17/20 2:15 AM,

Re: [RFC PATCH 08/17] gpio: Drop uses of pci_read_config_*() return value

2020-08-18 Thread Bartosz Golaszewski
On Sat, Aug 1, 2020 at 2:24 PM Saheed O. Bolarinwa wrote: > > The return value of pci_read_config_*() may not indicate a device error. > However, the value read by these functions is more likely to indicate > this kind of error. This presents two overlapping ways of reporting > errors and

Re: [RFC v4 1/3] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements

2020-08-18 Thread Wesley Cheng
On 8/12/2020 11:34 AM, Wesley Cheng wrote: >> >> awesome, thanks a lot for this :-) It's a considerable increase in your >> setup. My only fear here is that we may end up creating a situation >> where we can't allocate enough FIFO for all endpoints. This is, of >> course, a consequence of the

Re: [PATCH 0/4] -ffreestanding/-fno-builtin-* patches

2020-08-18 Thread Nick Desaulniers
On Tue, Aug 18, 2020 at 12:25 PM Nick Desaulniers wrote: > > On Tue, Aug 18, 2020 at 12:19 PM Linus Torvalds > wrote: > > > > On Tue, Aug 18, 2020 at 12:03 PM H. Peter Anvin wrote: > > > > > > I'm not saying "change the semantics", nor am I saying that playing > > > whack-a-mole *for a limited

Re: [PATCH 08/11] x86: make TASK_SIZE_MAX usable from assembly code

2020-08-18 Thread Kees Cook
On Tue, Aug 18, 2020 at 09:55:39PM +0200, Christoph Hellwig wrote: > On Tue, Aug 18, 2020 at 12:44:49PM -0700, Kees Cook wrote: > > On Mon, Aug 17, 2020 at 09:32:09AM +0200, Christoph Hellwig wrote: > > > For 64-bit the only hing missing was a strategic _AC, and for 32-bit we > > > > typo: thing

Re: [PATCH] sched/cputime: Mark function as __maybe_unused

2020-08-18 Thread Alex Dewar
On Tue, Aug 18, 2020 at 11:13:10AM -0700, Nick Desaulniers wrote: > On Tue, Aug 18, 2020 at 10:04 AM Alex Dewar wrote: > > > > Depending on config options, account_other_time() may not be called > > anywhere. Add __maybe_unused flag to fix clang warning. > > Just curious, would moving this

Re: [PATCH 03/11] fs: don't allow splice read/write without explicit ops

2020-08-18 Thread Kees Cook
On Tue, Aug 18, 2020 at 09:54:46PM +0200, Christoph Hellwig wrote: > On Tue, Aug 18, 2020 at 12:39:34PM -0700, Kees Cook wrote: > > On Mon, Aug 17, 2020 at 09:32:04AM +0200, Christoph Hellwig wrote: > > > default_file_splice_write is the last piece of generic code that uses > > > set_fs to make

Re: [PATCH] libceph: Convert to use the preferred fallthrough macro

2020-08-18 Thread Jeff Layton
On Tue, 2020-08-18 at 08:26 -0400, Miaohe Lin wrote: > Convert the uses of fallthrough comments to fallthrough macro. > > Signed-off-by: Miaohe Lin > --- > net/ceph/ceph_hash.c| 20 ++-- > net/ceph/crush/mapper.c | 2 +- > net/ceph/messenger.c| 4 ++-- >

Re: [PATCH 08/11] x86: make TASK_SIZE_MAX usable from assembly code

2020-08-18 Thread Christoph Hellwig
On Tue, Aug 18, 2020 at 12:44:49PM -0700, Kees Cook wrote: > On Mon, Aug 17, 2020 at 09:32:09AM +0200, Christoph Hellwig wrote: > > For 64-bit the only hing missing was a strategic _AC, and for 32-bit we > > typo: thing > > > need to use __PAGE_OFFSET instead of PAGE_OFFSET in the TASK_SIZE > >

Re: [PATCH 03/11] fs: don't allow splice read/write without explicit ops

2020-08-18 Thread Christoph Hellwig
On Tue, Aug 18, 2020 at 12:39:34PM -0700, Kees Cook wrote: > On Mon, Aug 17, 2020 at 09:32:04AM +0200, Christoph Hellwig wrote: > > default_file_splice_write is the last piece of generic code that uses > > set_fs to make the uaccess routines operate on kernel pointers. It > > implements a

Re: [PATCH] ethernet: cirrus: Remove unused macros

2020-08-18 Thread David Miller
From: Alex Dewar Date: Tue, 18 Aug 2020 15:06:01 +0100 > Remove a couple of unused #defines in cs89x0.h. > > Signed-off-by: Alex Dewar Applied to net-next.

Re: [PATCH net] net: gemini: Fix missing free_netdev() in error path of gemini_ethernet_port_probe()

2020-08-18 Thread David Miller
From: Wang Hai Date: Tue, 18 Aug 2020 21:44:04 +0800 > Fix the missing free_netdev() before return from > gemini_ethernet_port_probe() in the error handling case. > > Fixes: 4d5ae32f5e1e ("net: ethernet: Add a driver for Gemini gigabit > ethernet") > Reported-by: Hulk Robot > Signed-off-by:

Re: [PATCH v2 0/3] Add Broadcom VK driver

2020-08-18 Thread Kees Cook
On Wed, Aug 05, 2020 at 05:46:28PM -0700, Scott Branden wrote: > This patch series drops previous patches in [1] > that were incorporated by Kees Cook into patch series > "Introduce partial kernel_read_file() support" [2]. > > Remaining patches are contained in this series to add Broadcom VK

Re: [PATCH v2] powerpc/pseries/svm: Allocate SWIOTLB buffer anywhere in memory

2020-08-18 Thread Thiago Jung Bauermann
Christoph Hellwig writes: > On Mon, Aug 17, 2020 at 06:46:58PM -0300, Thiago Jung Bauermann wrote: >> POWER secure guests (i.e., guests which use the Protection Execution >> Facility) need to use SWIOTLB to be able to do I/O with the hypervisor, but >> they don't need the SWIOTLB memory to be

Re: [PATCH v7 1/6] net: introduce helper sendpage_ok() in include/linux/net.h

2020-08-18 Thread Christoph Hellwig
On Wed, Aug 19, 2020 at 12:33:37AM +0800, Coly Li wrote: > On 2020/8/19 00:24, Christoph Hellwig wrote: > > I think we should go for something simple like this instead: > > This idea is fine to me. Should a warning message be through here? IMHO > the driver still sends an improper page in, fix it

Re: [PATCH 09/11] x86: remove address space overrides using set_fs()

2020-08-18 Thread Kees Cook
On Mon, Aug 17, 2020 at 09:32:10AM +0200, Christoph Hellwig wrote: > Stop providing the possibility to override the address space using > set_fs() now that there is no need for that any more. To properly > handle the TASK_SIZE_MAX checking for 4 vs 5-level page tables on > x86 a new alternative

Re: [PATCH] net: tipc: Convert to use the preferred fallthrough macro

2020-08-18 Thread David Miller
From: Miaohe Lin Date: Tue, 18 Aug 2020 08:07:13 -0400 > Convert the uses of fallthrough comments to fallthrough macro. > > Signed-off-by: Miaohe Lin Applied to net-next.

Re: [PATCH] net: Avoid strcmp current->comm with warncomm when warned >= 5

2020-08-18 Thread David Miller
From: Miaohe Lin Date: Tue, 18 Aug 2020 07:41:32 -0400 > @@ -417,7 +417,7 @@ static void sock_warn_obsolete_bsdism(const char *name) > { > static int warned; > static char warncomm[TASK_COMM_LEN]; > - if (strcmp(warncomm, current->comm) && warned < 5) { > + if (warned < 5 &&

Re: [PATCH 08/11] x86: make TASK_SIZE_MAX usable from assembly code

2020-08-18 Thread Kees Cook
On Mon, Aug 17, 2020 at 09:32:09AM +0200, Christoph Hellwig wrote: > For 64-bit the only hing missing was a strategic _AC, and for 32-bit we typo: thing > need to use __PAGE_OFFSET instead of PAGE_OFFSET in the TASK_SIZE > definition to escape the explicit unsigned long cast. This just works >

Re: [PATCH 05/11] test_bitmap: skip user bitmap tests for !CONFIG_SET_FS

2020-08-18 Thread Kees Cook
On Mon, Aug 17, 2020 at 09:32:06AM +0200, Christoph Hellwig wrote: > We can't run the tests for userspace bitmap parsing if set_fs() doesn't > exist. > > Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook -- Kees Cook

Re: [PATCH 04/11] uaccess: add infrastructure for kernel builds with set_fs()

2020-08-18 Thread Kees Cook
On Mon, Aug 17, 2020 at 09:32:05AM +0200, Christoph Hellwig wrote: > Add a CONFIG_SET_FS option that is selected by architecturess that > implement set_fs, which is all of them initially. If the option is not > set stubs for routines related to overriding the address space are > provided so that

Re: [PATCH 03/11] fs: don't allow splice read/write without explicit ops

2020-08-18 Thread Kees Cook
On Mon, Aug 17, 2020 at 09:32:04AM +0200, Christoph Hellwig wrote: > default_file_splice_write is the last piece of generic code that uses > set_fs to make the uaccess routines operate on kernel pointers. It > implements a "fallback loop" for splicing from files that do not actually > provide a

Re: [PATCH 0/4] -ffreestanding/-fno-builtin-* patches

2020-08-18 Thread Nick Desaulniers
On Tue, Aug 18, 2020 at 12:03 PM H. Peter Anvin wrote: > > I'm not saying "change the semantics", nor am I saying that playing > whack-a-mole *for a limited time* is unreasonable. Ah, ok then. Sorry I mischaracterized your position. > But I would like to go back > to the compiler authors and

Re: [PATCH] rpl_iptunnel: simplify the return expression of rpl_do_srh()

2020-08-18 Thread David Miller
From: Xu Wang Date: Tue, 18 Aug 2020 08:54:54 + > @@ -197,11 +197,7 @@ static int rpl_do_srh(struct sk_buff *skb, const struct > rpl_lwt *rlwt) > > tinfo = rpl_encap_lwtunnel(dst->lwtstate); > > - err = rpl_do_srh_inline(skb, rlwt, tinfo->srh); > - if (err) > -

Re: [PATCH 02/11] fs: don't allow kernel reads and writes without iter ops

2020-08-18 Thread Kees Cook
On Mon, Aug 17, 2020 at 09:32:03AM +0200, Christoph Hellwig wrote: > Don't allow calling ->read or ->write with set_fs as a preparation for > killing off set_fs. All the instances that we use kernel_read/write on > are using the iter ops already. > > If a file has both the regular ->read/->write

Re: [PATCH 01/11] mem: remove duplicate ops for /dev/zero and /dev/null

2020-08-18 Thread Kees Cook
On Mon, Aug 17, 2020 at 09:32:02AM +0200, Christoph Hellwig wrote: > There is no good reason to implement both the traditional ->read and > ->write as well as the iter based ops. So implement just the iter > based ones. > > Suggested-by: Al Viro > Signed-off-by: Christoph Hellwig Reviewed-by:

Re: [PATCH] gpio: stp-xway: automatically drive GPHY leds on ar10 and grx390

2020-08-18 Thread Bartosz Golaszewski
On Fri, Aug 14, 2020 at 9:49 PM Aleksander Jan Bajkowski wrote: > > Ar10 (xr300) has 3 and grx390 (xrx330) has 4 built-in GPHY. PHY LEDs are > connected via STP. STP is a peripheral controller used to drive external > shift register cascades. The hardware is able to allow the GPHY to drive > some

Re: [PATCH 06/11] lkdtm: disable set_fs-based tests for !CONFIG_SET_FS

2020-08-18 Thread Kees Cook
On Mon, Aug 17, 2020 at 09:32:07AM +0200, Christoph Hellwig wrote: > Once we can't manipulate the address limit, we also can't test what > happens when the manipulation is abused. > > Signed-off-by: Christoph Hellwig > --- > drivers/misc/lkdtm/bugs.c | 2 ++ > drivers/misc/lkdtm/core.c

Re: [PATCH 4/6] iio: dac: ad5686: Constify static struct iio_chan_spec

2020-08-18 Thread Rikard Falkeborn
On Sun, May 31, 2020 at 02:47:15PM +0100, Jonathan Cameron wrote: > On Wed, 27 May 2020 04:50:46 + > "Ardelean, Alexandru" wrote: > > > On Tue, 2020-05-26 at 23:02 +0200, Rikard Falkeborn wrote: > > > [External] > > > > > > These are never modified and can be made const to allow the

[PATCH] coresight: etm4x: Handle unreachable sink in perf mode

2020-08-18 Thread Suzuki K Poulose
If the specified/hinted sink is not reachable from a subset of the CPUs, we could end up unable to trace the event on those CPUs. This is the best effort we could do until we support 1:1 configurations. Fail gracefully in such cases avoiding a WARN_ON, which can be easily triggered by the user on

Re: [RFC PATCH 0/8] memcg: Enable fine-grained per process memory control

2020-08-18 Thread Waiman Long
On 8/18/20 5:27 AM, Chris Down wrote: pet...@infradead.org writes: On Mon, Aug 17, 2020 at 10:08:23AM -0400, Waiman Long wrote: Memory controller can be used to control and limit the amount of physical memory used by a task. When a limit is set in "memory.high" in a v2 non-root memory cgroup,

Re: [RFC PATCH 0/8] memcg: Enable fine-grained per process memory control

2020-08-18 Thread Waiman Long
On 8/18/20 5:14 AM, pet...@infradead.org wrote: On Mon, Aug 17, 2020 at 10:08:23AM -0400, Waiman Long wrote: Memory controller can be used to control and limit the amount of physical memory used by a task. When a limit is set in "memory.high" in a v2 non-root memory cgroup, the memory

[PATCH v6] usb: typec: tcpm: Migrate workqueue to RT priority for processing events

2020-08-18 Thread Badhri Jagan Sridharan
"tReceiverResponse 15 ms Section 6.6.2 The receiver of a Message requiring a response Shall respond within tReceiverResponse in order to ensure that the sender’s SenderResponseTimer does not expire." When the cpu complex is busy running other lower priority work items, TCPM's work queue sometimes

Re: [PATCH 07/11] x86: move PAGE_OFFSET, TASK_SIZE & friends to page_{32,64}_types.h

2020-08-18 Thread Kees Cook
On Mon, Aug 17, 2020 at 09:32:08AM +0200, Christoph Hellwig wrote: > At least for 64-bit this moves them closer to some of the defines > they are based on, and it prepares for using the TASK_SIZE_MAX > definition from assembly. > > Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook --

Re: [PATCH 0/4] -ffreestanding/-fno-builtin-* patches

2020-08-18 Thread Nick Desaulniers
On Tue, Aug 18, 2020 at 12:19 PM Linus Torvalds wrote: > > On Tue, Aug 18, 2020 at 12:03 PM H. Peter Anvin wrote: > > > > I'm not saying "change the semantics", nor am I saying that playing > > whack-a-mole *for a limited time* is unreasonable. But I would like to go > > back > > to the

Re: [PATCH 2/4] Revert "lib/string.c: implement a basic bcmp"

2020-08-18 Thread Kees Cook
On Tue, Aug 18, 2020 at 11:00:01AM -0700, Nick Desaulniers wrote: > On Mon, Aug 17, 2020 at 10:44 PM Nathan Chancellor > wrote: > > > > On Mon, Aug 17, 2020 at 03:02:10PM -0700, Nick Desaulniers wrote: > > > This reverts commit 5f074f3e192f10c9fade898b9b3b8812e3d83342. > > > > > > Use

[PATCH V3] scripts: coccicheck: Change default value for parallelism

2020-08-18 Thread Sumera Priyadarsini
By default, coccicheck utilizes all available threads to implement parallelisation. However, when all available threads are used, a decrease in performance is noted. The elapsed time is minimum when at most one thread per core is used. For example, on benchmarking the semantic patch kfree.cocci

Re: [PATCH 4/4] x86: don't build CONFIG_X86_32 as -ffreestanding

2020-08-18 Thread Kees Cook
On Mon, Aug 17, 2020 at 03:02:12PM -0700, Nick Desaulniers wrote: > -ffreestanding typically inhibits "libcall optimizations" where calls to > certain library functions can be replaced by the compiler in certain > cases to calls to other library functions that may be more efficient. > This can be

Re: [PATCH 3/4] x86/boot: use -fno-builtin-bcmp

2020-08-18 Thread Kees Cook
On Mon, Aug 17, 2020 at 03:02:11PM -0700, Nick Desaulniers wrote: > We're reverting > commit 5f074f3e192f ("lib/string.c: implement a basic bcmp") > in favor of -fno-builtin-bcmp. Remove the additional definition here, > too. > > arch/x86/purgatory/Makefile uses -ffreestanding, so there's no risk

Re: [PATCH 1/4] Makefile: add -fno-builtin-stpcpy

2020-08-18 Thread Kees Cook
On Mon, Aug 17, 2020 at 03:02:09PM -0700, Nick Desaulniers wrote: > LLVM implemented a recent "libcall optimization" that lowers calls to > `sprintf(dest, "%s", str)` where the return value is used to > `stpcpy(dest, str) - dest`. This generally avoids the machinery involved > in parsing format

Re: [RFC v7 03/10] mm/damon-test: Add more unit tests for 'init_regions'

2020-08-18 Thread Brendan Higgins
On Tue, Aug 18, 2020 at 12:26 AM SeongJae Park wrote: > > From: SeongJae Park > > This commit adds more test cases for the new feature, 'init_regions'. > > Signed-off-by: SeongJae Park Reviewed-by: Brendan Higgins

Re: [PATCH 1/4] Makefile: add -fno-builtin-stpcpy

2020-08-18 Thread Kees Cook
On Mon, Aug 17, 2020 at 03:31:26PM -0700, H. Peter Anvin wrote: > On 2020-08-17 15:02, Nick Desaulniers wrote: > > LLVM implemented a recent "libcall optimization" that lowers calls to > > `sprintf(dest, "%s", str)` where the return value is used to > > `stpcpy(dest, str) - dest`. This generally

<    1   2   3   4   5   6   7   8   9   10   >