Re: [LKP] Re: [x86/mce] 1de08dccd3: will-it-scale.per_process_ops -14.1% regression

2020-08-24 Thread Borislav Petkov
On Mon, Aug 24, 2020 at 11:33:00PM +0800, Feng Tang wrote: > diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c > index 43b1519..2c020ef 100644 > --- a/arch/x86/kernel/cpu/mce/core.c > +++ b/arch/x86/kernel/cpu/mce/core.c > @@ -95,7 +95,7 @@ struct mca_config mca_cfg

Re: [PATCH 5/7] mm: Remove nr_entries parameter from pagevec_lookup_entries

2020-08-24 Thread Jan Kara
On Wed 19-08-20 16:05:53, Matthew Wilcox (Oracle) wrote: > All callers want to fetch the full size of the pvec. > > Signed-off-by: Matthew Wilcox (Oracle) Looks good to me. You can add: Reviewed-by: Jan Kara Honza > --- >

Re: [PATCH - stable v5.4 and v5.7] opp: Enable resources again if they were disabled earlier

2020-08-24 Thread Greg KH
On Mon, Aug 24, 2020 at 02:52:23PM +0530, Viresh Kumar wrote: > From: Rajendra Nayak > > commit a4501bac0e553bed117b7e1b166d49731caf7260 upstream. > > dev_pm_opp_set_rate() can now be called with freq = 0 in order > to either drop performance or bandwidth votes or to disable > regulators on

Re: [PATCH] MIPS: Paravirt: remove remaining pieces of paravirt

2020-08-24 Thread Thomas Bogendoerfer
On Sat, Aug 22, 2020 at 10:02:51AM +0200, Thomas Bogendoerfer wrote: > Commit 35546aeede8e ("MIPS: Retire kvm paravirt") removed > kvm paravirt support, but missed arch/mips/include/mach-paravirt. > Remove it as well. > > Signed-off-by: Thomas Bogendoerfer > --- >

Re: [PATCH - for v5.7 stable] opp: Put opp table in dev_pm_opp_set_rate() for empty tables

2020-08-24 Thread Greg KH
On Mon, Aug 24, 2020 at 03:00:03PM +0530, Viresh Kumar wrote: > From: Stephen Boyd > > commit 8979ef70850eb469e1094279259d1ef393ffe85f upstream. > > We get the opp_table pointer at the top of the function and so we should > put the pointer at the end of the function like all other exit paths >

Re: [PATCH] MIPS: Remove PNX833x alias NXP_STB22x

2020-08-24 Thread Thomas Bogendoerfer
On Sat, Aug 22, 2020 at 10:04:27AM +0200, Thomas Bogendoerfer wrote: > Remove another unused MIPS platform. > > Signed-off-by: Thomas Bogendoerfer > --- > arch/mips/Kbuild.platforms | 1 - > arch/mips/Kconfig| 30 --- >

Re: [PATCH 4/7] mm: Add an 'end' parameter to pagevec_lookup_entries

2020-08-24 Thread Jan Kara
On Wed 19-08-20 16:05:52, Matthew Wilcox (Oracle) wrote: > Simplifies the callers and uses the existing functionality of > find_get_entries(). > > Signed-off-by: Matthew Wilcox (Oracle) The patch looks good to me. You can add: Reviewed-by: Jan Kara

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-24 Thread Mauro Carvalho Chehab
Em Fri, 21 Aug 2020 17:56:50 +0200 Sam Ravnborg escreveu: > Hi Mauro. > > On Fri, Aug 21, 2020 at 04:41:58PM +0200, Mauro Carvalho Chehab wrote: > > Another quick question: > > > > Em Wed, 19 Aug 2020 19:35:58 +0200 > > Sam Ravnborg escreveu: > > > > > > +#define DSS_REDUCE(x) ((x) > 0 ?

[PATCH v3 3/4] arm64: dts: imx8mm-var-som: Add Variscite VAR-SOM-MX8MM System on Module

2020-08-24 Thread Krzysztof Kozlowski
Add DTSI of Variscite VAR-SOM-MX8MM System on Module in a basic version, delivered with Variscite Symphony Evaluation kit. This version comes with: - 2 GB of RAM, - 16 GB eMMC, - Gigabit Ethernet PHY, - 802.11 ac/a/b/g/n WiFi with 4.2 Bluetooth (Cypress CYW43353), - CAN bus, - Audio codec

[PATCH v3 1/4] dt-bindings: arm: fsl: Add binding for Variscite VAR-SOM-MX8MM module

2020-08-24 Thread Krzysztof Kozlowski
Add a binding for the Variscite VAR-SOM-MX8MM System on Module. Signed-off-by: Krzysztof Kozlowski --- Based on top of: https://lore.kernel.org/linux-arm-kernel/20200823172019.18606-1-k...@kernel.org/ Changes since v1: 1. None --- Documentation/devicetree/bindings/arm/fsl.yaml | 1 + 1 file

[PATCH v3 4/4] arm64: dts: imx8mm-var-som-symphony: Add Variscite Symphony board with VAR-SOM-MX8MM

2020-08-24 Thread Krzysztof Kozlowski
Add a DTS for Variscite Symphony evaluation kit with VAR-SOM-MX8MM System on Module. Signed-off-by: Krzysztof Kozlowski --- Changes since v2: 1. Use 'led' as node name to be generic, 2. Remove orphaned pinctrl-names. 3. Use more specific regulator node names. Changes since v1: 1. Remove

Re: [PATCH 3/3] mm/memcg: Unify swap and memsw page counters

2020-08-24 Thread Waiman Long
On 8/20/20 11:46 AM, Shakeel Butt wrote: On Thu, Aug 20, 2020 at 6:04 AM Waiman Long wrote: The swap page counter is v2 only while memsw is v1 only. As v1 and v2 controllers cannot be active at the same time, there is no point to keep both swap and memsw page counters in mem_cgroup. The

[PATCH v3 2/4] dt-bindings: arm: fsl: Add binding for Variscite Symphony board with VAR-SOM-MX8MM

2020-08-24 Thread Krzysztof Kozlowski
Add a binding for the Variscite Symphony evaluation kit board with VAR-SOM-MX8MM System on Module. Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. None --- Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [PATCH] mtd: spi-nor: intel-spi: Do not try to make the SPI flash chip writable

2020-08-24 Thread Daniel Gutson
On Mon, Aug 24, 2020 at 6:44 AM Mika Westerberg wrote: > > On Mon, Aug 24, 2020 at 11:31:40AM +0200, Arnd Bergmann wrote: > > On Mon, Aug 24, 2020 at 11:15 AM Mika Westerberg > > wrote: > > > On Mon, Aug 24, 2020 at 11:08:33AM +0200, Arnd Bergmann wrote: > > > > On Mon, Aug 24, 2020 at 10:22 AM

Re: [PATCH] x86/entry: Fix AC assertion

2020-08-24 Thread Andrew Cooper
On 24/08/2020 16:21, pet...@infradead.org wrote: > On Mon, Aug 24, 2020 at 03:22:06PM +0100, Andrew Cooper wrote: >> On 24/08/2020 11:14, pet...@infradead.org wrote: >>> The WARN added in commit 3c73b81a9164 ("x86/entry, selftests: Further >>> improve user entry sanity checks") unconditionally

Re: [PATCH 0/4] -ffreestanding/-fno-builtin-* patches

2020-08-24 Thread Masahiro Yamada
On Wed, Aug 19, 2020 at 6:41 AM Arvind Sankar wrote: > > On Tue, Aug 18, 2020 at 01:58:51PM -0700, Nick Desaulniers wrote: > > On Tue, Aug 18, 2020 at 1:27 PM Nick Desaulniers > > wrote: > > > > > > On Tue, Aug 18, 2020 at 1:24 PM Arvind Sankar > > > wrote: > > > > > > > > On Tue, Aug 18, 2020

drivers/ata/ahci_xgene.c:196:41: sparse: sparse: incorrect type in initializer (different address spaces)

2020-08-24 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: d012a7190fc1fd72ed48911e77ca97ba4521bccd commit: 670d0a4b10704667765f7d18f7592993d02783aa sparse: use identifiers to define address spaces date: 10 weeks ago config: powerpc64-randconfig-s031-20200824

Re: [PATCH] staging: emxx_udc: Fix passing of NULL to dma_alloc_coherent()

2020-08-24 Thread Alex Dewar
On Mon, Aug 24, 2020 at 04:19:17PM +0100, Alex Dewar wrote: > In nbu2ss_eq_queue() memory is allocated with dma_alloc_coherent(), > though, strangely, NULL is passed as the struct device* argument. Pass > the UDC's device instead. > > Build-tested on x86 only. > > Fixes: 33aa8d45a4fe ("staging:

Re: x86/kprobes: kretprobe fails to triggered if kprobe at function entry is not optimized (trigger by int3 breakpoint)

2020-08-24 Thread Masami Hiramatsu
On Mon, 24 Aug 2020 12:02:58 + "eddy...@trendmicro.com" wrote: > Greetings! > > Starting from kernel 5.8 (x86_64), kretprobe handler will always missed if > corresponding kprobe on function entry is not optimized (using break point > instead). Oops, good catch. I always enabled ftrace

Re: [PATCH v4 2/3] sdhci: sparx5: Add Sparx5 SoC eMMC driver

2020-08-24 Thread Adrian Hunter
On 24/08/20 6:10 pm, Lars Povlsen wrote: > This adds the eMMC driver for the Sparx5 SoC. It is based upon the > designware IP, but requires some extra initialization and quirks. > > Signed-off-by: Lars Povlsen Already acked this, still: Acked-by: Adrian Hunter > --- >

[RFC PATCH] usb: sync_all_pins() can be static

2020-08-24 Thread kernel test robot
Signed-off-by: kernel test robot --- brcmstb-usb-pinmap.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/brcmstb-usb-pinmap.c b/drivers/usb/host/brcmstb-usb-pinmap.c index 647373b7e53b7a..2dd117d4fcfefc 100644 ---

Re: [PATCH 3/3] usb: Add Kconfig and Makefile changes to build brcmstb-usb-pinmap

2020-08-24 Thread kernel test robot
Hi Al, I love your patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [also build test WARNING on linux/master linus/master v5.9-rc2 next-20200824] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH] iomap: Fix the write_count in iomap_add_to_ioend().

2020-08-24 Thread Brian Foster
On Mon, Aug 24, 2020 at 04:04:17PM +0100, Christoph Hellwig wrote: > On Mon, Aug 24, 2020 at 10:28:23AM -0400, Brian Foster wrote: > > Do I understand the current code (__bio_try_merge_page() -> > > page_is_mergeable()) correctly in that we're checking for physical page > > contiguity and not

Re: [LKP] Re: [x86/mce] 1de08dccd3: will-it-scale.per_process_ops -14.1% regression

2020-08-24 Thread Feng Tang
On Mon, Aug 24, 2020 at 11:38:53PM +0800, Luck, Tony wrote: > > Yes, that's what we suspected. And I just did another try to force the > > percpu mce structure aligned. And the regression seems to be gone (reduced > > from 14.1% to 2%), which further proved it. > > I wonder whether it would be

Re: [RFC 13/20] drm/i915/dp: Extract drm_dp_downstream_read_info()

2020-08-24 Thread Imre Deak
On Fri, Aug 21, 2020 at 01:43:39PM -0400, Lyude Paul wrote: > [...] > > The wording is a bit unclear, but as I understand the Standard only > > calls for the above: > > > > """ > > A DP upstream device shall read the capability from DPCD Addresses 00080h > > through 00083h. A DP Branch device

Re: [PATCH 1/2] mm/migrate: Fixup setting UFFD_WP flag

2020-08-24 Thread Peter Xu
On Mon, Aug 24, 2020 at 06:31:27PM +1000, Alistair Popple wrote: > Commit f45ec5ff16a75 ("userfaultfd: wp: support swap and page > migration") introduced support for tracking the uffd wp bit during page > migration. However the non-swap PTE variant was used to set the flag for > zone device

LOOP_CONFIGURE ioctl doesn't work if lo_offset/lo_sizelimit are set

2020-08-24 Thread Lennart Poettering
Hi! Even with fe6a8fc5ed2f0081f17375ae2005718522c392c6 the LOOP_CONFIGURE ioctl doesn't work correctly. It gets confused if the lo_offset/lo_sizelimit fields are set to non-zero. In a quick test I ran (on Linux 5.8.3) I call LOOP_CONFIGURE with .lo_offset=3221204992 and .lo_sizelimit=50331648

[ANNOUNCE] v5.9-rc2-rt1

2020-08-24 Thread Sebastian Andrzej Siewior
Dear RT folks! I'm pleased to announce the v5.9-rc2-rt1 patch set. Changes since v5.6.19-rt12: - Rebase to v5.9-rc2 - The seqcount related patches have been replaced on top of the seqcount series by Ahmed S. Darwis which landed mainline. - The posix-timer patches have been dropped

[PATCH 2/4] mm: support nesting memalloc_use_memcg()

2020-08-24 Thread Dan Schatzberg
From: Johannes Weiner The memalloc_use_memcg() function to override the default memcg accounting context currently doesn't nest. But the patches to make the loop driver cgroup-aware will end up nesting: [ 98.137605] alloc_page_buffers+0x210/0x288 [ 98.141799] __getblk_gfp+0x1d4/0x400 [

Re: [PATCH 2/2] mm/rmap: Fixup copying of soft dirty and uffd ptes

2020-08-24 Thread Peter Xu
On Mon, Aug 24, 2020 at 06:31:28PM +1000, Alistair Popple wrote: > During memory migration a pte is temporarily replaced with a migration > swap pte. Some pte bits from the existing mapping such as the soft-dirty > and uffd write-protect bits are preserved by copying these to the > temporary

[PATCH 3/4] mm: Charge active memcg when no mm is set

2020-08-24 Thread Dan Schatzberg
memalloc_use_memcg() worked for kernel allocations but was silently ignored for user pages. This patch establishes a precedence order for who gets charged: 1. If there is a memcg associated with the page already, that memcg is charged. This happens during swapin. 2. If an explicit mm is

Re: [PATCH 4.9 15/39] jbd2: add the missing unlock_buffer() in the error path of jbd2_write_superblock()

2020-08-24 Thread Greg Kroah-Hartman
On Mon, Aug 24, 2020 at 07:15:25PM +0800, zhangyi (F) wrote: > Hi,Greg > > The problem this patch want to fix only exists on the kernel both > 538bcaa6261b and 742b06b5628f these two upstream patches were merged, > but 538bcaa6261b was not merged to 4.9, so we don't need this patch > for 4.9.

Re: [PATCH 1/4] mm: Trial do_wp_page() simplification

2020-08-24 Thread Kirill Tkhai
On 24.08.2020 17:30, Jan Kara wrote: > On Mon 24-08-20 11:36:22, Kirill Tkhai wrote: >> On 22.08.2020 02:49, Peter Xu wrote: >>> From: Linus Torvalds >>> >>> How about we just make sure we're the only possible valid user fo the >>> page before we bother to reuse it? >>> >>> Simplify, simplify,

RE: [LKP] Re: [x86/mce] 1de08dccd3: will-it-scale.per_process_ops -14.1% regression

2020-08-24 Thread Luck, Tony
> Yes, that's what we suspected. And I just did another try to force the > percpu mce structure aligned. And the regression seems to be gone (reduced > from 14.1% to 2%), which further proved it. I wonder whether it would be useful for bisection of performance issues for you to change the global

[PATCH v1] sched/topology: Make compiler happy about unused constant definitions

2020-08-24 Thread Andy Shevchenko
Compilation of almost each file ends up with In file included from .../include/linux/energy_model.h:10, from .../include/linux/device.h:16, from .../drivers/spi/spi.c:8: .../include/linux/sched/topology.h:30:27: warning: ‘SD_DEGENERATE_GROUPS_MASK’ defined

[PATCH 4/4] loop: Charge i/o to mem and blk cg

2020-08-24 Thread Dan Schatzberg
The current code only associates with the existing blkcg when aio is used to access the backing file. This patch covers all types of i/o to the backing file and also associates the memcg so if the backing file is on tmpfs, memory is charged appropriately. This patch also exports cgroup_get_e_css

[PATCH 1/4] loop: Use worker per cgroup instead of kworker

2020-08-24 Thread Dan Schatzberg
Existing uses of loop device may have multiple cgroups reading/writing to the same device. Simply charging resources for I/O to the backing file could result in priority inversion where one cgroup gets synchronously blocked, holding up all other I/O to the loop device. In order to avoid this

[PATCH v7 0/4] Charge loop device i/o to issuing cgroup

2020-08-24 Thread Dan Schatzberg
Much of the discussion about this has died down. There's been a concern raised that we could generalize infrastructure across loop, md, etc. This may be possible, in the future, but it isn't clear to me how this would look like. I'm inclined to fix the existing issue with loop devices now (this is

Re: [PATCH] MAINTAINERS: Add entry for HPE Superdome Flex (UV) maintainers

2020-08-24 Thread Borislav Petkov
On Mon, Aug 24, 2020 at 09:45:23AM -0500, Steve Wahl wrote: > Added Darren Hart, Andy Shevchenko, Thomas Gleixner, Ingo Molnar, > Borislav Petkov, and x86.kernel.org, after being told that > get_maintainers.pl doesn't work on MAINTAINERS. > > Thanks, > > Steve Wahl, HPE > > On Fri, Aug 21, 2020

sound/soc/ti/ams-delta.c:449:9: error: implicit declaration of function 'ams_delta_digital_mute'; did you mean

2020-08-24 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: d012a7190fc1fd72ed48911e77ca97ba4521bccd commit: 059374fe9ea5dd1e5a1d6b14741baf994dbc8dd2 ASoC: ti: merge .digital_mute() into .mute_stream() date: 6 weeks ago config: arm-randconfig-r035-20200824

AW: [PATCH v2] HID: roccat: add bounds checking in kone_sysfs_write_settings()

2020-08-24 Thread Walter Harms
hello Dan, i notice that you can shorten the line to: (line above checks for count==sizeof(struct kone_settings)) difference = memcmp(settings, >settings, count); nothing special just to shorten the line and make use of count. and just to save one indent level and because its readabel

Re: [PATCH] net: systemport: Fix memleak in bcm_sysport_probe

2020-08-24 Thread Florian Fainelli
On 8/23/2020 10:58 PM, Dinghao Liu wrote: When devm_kcalloc() fails, dev should be freed just like what we've done in the subsequent error paths. Fixes: 7b78be48a8eb6 ("net: systemport: Dynamically allocate number of TX rings") Signed-off-by: Dinghao Liu Acked-by: Florian Fainelli This

Re: [LKP] Re: [x86/mce] 1de08dccd3: will-it-scale.per_process_ops -14.1% regression

2020-08-24 Thread Feng Tang
On Mon, Aug 24, 2020 at 05:14:25PM +0200, Borislav Petkov wrote: > On Fri, Aug 21, 2020 at 10:02:59AM +0800, Feng Tang wrote: > > 1de08dccd383 x86/mce: Add a struct mce.kflags field > > 9554bfe403bd x86/mce: Convert the CEC to use the MCE notifier > > > > And strange thing is after using gcc9

[PATCH 1/2] Add a manpage for watch_queue(7)

2020-08-24 Thread David Howells
Add a manual page for the notifications/watch_queue facility. Signed-off-by: David Howells --- man7/watch_queue.7 | 304 1 file changed, 304 insertions(+) create mode 100644 man7/watch_queue.7 diff --git a/man7/watch_queue.7

[PATCH 2/2] Modify the pipe(2) manpage for notification queues

2020-08-24 Thread David Howells
Modify the pipe(2) manual page to cover support for notification queues Signed-off-by: David Howells --- man2/pipe.2 | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/man2/pipe.2 b/man2/pipe.2 index 117f8950c..c50b38530 100644 --- a/man2/pipe.2 +++ b/man2/pipe.2

[PATCH v2 1/1] mm, oom_adj: don't loop through tasks in __set_oom_adj when not necessary

2020-08-24 Thread Suren Baghdasaryan
Currently __set_oom_adj loops through all processes in the system to keep oom_score_adj and oom_score_adj_min in sync between processes sharing their mm. This is done for any task with more that one mm_users, which includes processes with multiple threads (sharing mm and signals). However for such

Re: [PATCH v3] btrfs: block-group: Fix free-space bitmap threshould

2020-08-24 Thread David Sterba
On Fri, Aug 21, 2020 at 11:54:44AM -0300, Marcos Paulo de Souza wrote: > From: Marcos Paulo de Souza > > [BUG] > After commit 9afc66498a0b ("btrfs: block-group: refactor how we read one > block group item"), cache->length is being assigned after calling > btrfs_create_block_group_cache. This

Re: [PATCH 1/2] Add a manpage for watch_queue(7)

2020-08-24 Thread David Howells
Ben Boeckel wrote: > > +In the case of message loss, > > +.BR read (2) > > +will fabricate a loss message and pass that to userspace immediately after > > the > > +point at which the loss occurred. > > If multiple messages are dropped in a row, is there one loss message per > loss message or

Re: [RFC PATCH 2/3] sched: membarrier: cover kthread_use_mm (v2)

2020-08-24 Thread Mathieu Desnoyers
- On Aug 16, 2020, at 11:29 AM, Boqun Feng boqun.f...@gmail.com wrote: > On Fri, Aug 14, 2020 at 12:43:57PM -0400, Mathieu Desnoyers wrote: >> Add comments and memory barrier to kthread_use_mm and kthread_unuse_mm >> to allow the effect of membarrier(2) to apply to kthreads accessing >>

Re: [PATCH v1] brcmfmac: increase F2 watermark for BCM4329

2020-08-24 Thread Dmitry Osipenko
24.08.2020 11:28, Arend Van Spriel пишет: > > > On 8/23/2020 4:20 PM, Dmitry Osipenko wrote: >> This patch fixes SDHCI CRC errors during of RX throughput testing on >> BCM4329 chip if SDIO BUS is clocked above 25MHz. In particular the >> checksum problem is observed on NVIDIA Tegra20 SoCs. The

[PATCH 0/2] ARM: dts: sun8i: r40: Enable mali400 GPU

2020-08-24 Thread Jernej Skrabec
Following two patches enable Mali400 GPU on Allwinner R40 SoC. At this point I didn't add table for frequency switching because it would require far more testing and defaults work stable and reasonably well. Please take a look. Best regards, Jernej Jernej Skrabec (2): dt-bindings: gpu:

Re: [PATCH 5.8 000/148] 5.8.4-rc1 review

2020-08-24 Thread Sasha Levin
On Mon, Aug 24, 2020 at 06:40:27AM -0700, Guenter Roeck wrote: On Mon, Aug 24, 2020 at 10:28:18AM +0200, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.8.4 release. There are 148 patches in this series, all will be posted as a response to this one. If anyone

Re: [PATCH] gpu: amd: Remove duplicate semicolons at the end of line

2020-08-24 Thread Alex Deucher
On Sat, Aug 22, 2020 at 5:02 AM Youling Tang wrote: > > Remove duplicate semicolons at the end of line. > > Signed-off-by: Youling Tang Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 2 +- > drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.c | 2 +-

[PATCH 3/9] iomap: Use kzalloc to allocate iomap_page

2020-08-24 Thread Matthew Wilcox (Oracle)
We can skip most of the initialisation, although spinlocks still need explicit initialisation as architectures may use a non-zero value to indicate unlocked. The comment is no longer useful as attach_page_private() handles the refcount now. Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by:

[PATCH 03/11] mm: Zero the head page, not the tail page

2020-08-24 Thread Matthew Wilcox (Oracle)
Pass the head page to zero_user_segment(), not the tail page, and adjust the byte offsets appropriately. Signed-off-by: Matthew Wilcox (Oracle) --- mm/shmem.c| 7 +++ mm/truncate.c | 7 +++ 2 files changed, 14 insertions(+) diff --git a/mm/shmem.c b/mm/shmem.c index

[PATCH 04/11] block: Add bio_for_each_thp_segment_all

2020-08-24 Thread Matthew Wilcox (Oracle)
Iterate once for each THP instead of once for each base page. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/bio.h | 13 + include/linux/bvec.h | 27 +++ 2 files changed, 40 insertions(+) diff --git a/include/linux/bio.h b/include/linux/bio.h

[PATCH 06/11] iomap: Support THPs in invalidatepage

2020-08-24 Thread Matthew Wilcox (Oracle)
If we're punching a hole in a THP, we need to remove the per-page iomap data as the THP is about to be split and each page will need its own. This means that writepage can now come across a page with no iop allocated, so remove the assertions that there is already one, and just create one (with

[PATCH 07/11] iomap: Support THPs in read paths

2020-08-24 Thread Matthew Wilcox (Oracle)
Use thp_size() instead of PAGE_SIZE, offset_in_thp() instead of offset_in_page() and bio_for_each_thp_segment_all(). Signed-off-by: Matthew Wilcox (Oracle) --- fs/iomap/buffered-io.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git

[PATCH 05/11] iomap: Support THPs in iomap_adjust_read_range

2020-08-24 Thread Matthew Wilcox (Oracle)
Pass the struct page instead of the iomap_page so we can determine the size of the page. Use offset_in_thp() instead of offset_in_page() and use thp_size() instead of PAGE_SIZE. Convert the arguments to be size_t instead of unsigned int, in case pages ever get larger than 2^31 bytes.

[PATCH 00/11] iomap/fs/block patches for 5.11

2020-08-24 Thread Matthew Wilcox (Oracle)
As promised earlier [1], here are the patches which I would like to merge into 5.11 to support THPs. They depend on that earlier series. If there's anything in here that you'd like to see pulled out and added to that earlier series, let me know. There are a couple of pieces in here which aren't

Re: [PATCH v2] module: Harden STRICT_MODULE_RWX

2020-08-24 Thread Jessica Yu
+++ Ard Biesheuvel [22/08/20 15:47 +0200]: (+ Masahiro) On Fri, 21 Aug 2020 at 14:30, Will Deacon wrote: On Fri, Aug 21, 2020 at 02:27:05PM +0200, Ard Biesheuvel wrote: > On Fri, 21 Aug 2020 at 14:20, Will Deacon wrote: > > > > On Thu, Aug 13, 2020 at 03:07:13PM +0200, Ard Biesheuvel wrote:

[PATCH 10/11] iomap: Inline data shouldn't see THPs

2020-08-24 Thread Matthew Wilcox (Oracle)
Assert that we're not seeing THPs in functions that read/write inline data, rather than zeroing out the tail. Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Christoph Hellwig --- fs/iomap/buffered-io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/iomap/buffered-io.c

Re: Is: virtio_gpu_object_shmem_init issues? Was:Re: upstream boot error: general protection fault in swiotlb_map

2020-08-24 Thread Dmitry Vyukov
On Mon, Aug 24, 2020 at 5:07 PM Konrad Rzeszutek Wilk wrote: > > On Thu, Aug 06, 2020 at 03:46:23AM -0700, syzbot wrote: > > Hello, > > > > syzbot found the following issue on: > > > > HEAD commit:47ec5303 Merge git://git.kernel.org/pub/scm/linux/kernel/g.. > > git tree: upstream > >

[PATCH 11/11] iomap: Handle tail pages in iomap_page_mkwrite

2020-08-24 Thread Matthew Wilcox (Oracle)
iomap_page_mkwrite() can be called with a tail page. If we are, operate on the head page, since we're treating the entire thing as a single unit and the whole page is dirtied at the same time. Signed-off-by: Matthew Wilcox (Oracle) --- fs/iomap/buffered-io.c | 2 +- 1 file changed, 1

[PATCH] staging: emxx_udc: Fix passing of NULL to dma_alloc_coherent()

2020-08-24 Thread Alex Dewar
In nbu2ss_eq_queue() memory is allocated with dma_alloc_coherent(), though, strangely, NULL is passed as the struct device* argument. Pass the UDC's device instead. Build-tested on x86 only. Fixes: 33aa8d45a4fe ("staging: emxx_udc: Add Emma Mobile USB Gadget driver") Signed-off-by: Alex Dewar

Re: [PATCH] lib: pldmfw: delete duplicated words

2020-08-24 Thread Jacob Keller
On 8/22/2020 9:05 PM, Randy Dunlap wrote: > Drop the repeated word "header". > Thanks for fixing this! Reviewed-by: Jacob Keller > Signed-off-by: Randy Dunlap > Cc: Jacob Keller > Cc: "David S. Miller" > Cc: Jakub Kicinski > --- > lib/pldmfw/pldmfw.c |2 +- > 1 file changed, 1

Re: [RFC] security: replace indirect calls with static calls

2020-08-24 Thread Brendan Jackman
On Fri, 21 Aug 2020 at 00:46, Casey Schaufler wrote: > > On 8/20/2020 9:47 AM, Brendan Jackman wrote: [...] > What does NOP really look like? The NOP is the same as a regular function call but the CALL instruction is replaced with a NOP instruction. The code that sets up the call parameters is

[PATCH 7/9] iomap: Convert write_count to byte count

2020-08-24 Thread Matthew Wilcox (Oracle)
Instead of counting bio segments, count the number of bytes submitted. This insulates us from the block layer's definition of what a 'same page' is, which is not necessarily clear once THPs are involved. Signed-off-by: Matthew Wilcox (Oracle) --- fs/iomap/buffered-io.c | 11 ++- 1 file

Re: [PATCH] x86/entry: Fix AC assertion

2020-08-24 Thread peterz
On Mon, Aug 24, 2020 at 03:22:06PM +0100, Andrew Cooper wrote: > On 24/08/2020 11:14, pet...@infradead.org wrote: > > The WARN added in commit 3c73b81a9164 ("x86/entry, selftests: Further > > improve user entry sanity checks") unconditionally triggers on my IVB > > machine because it does not

Re: [PATCH stable-5.8.y backport 1/2] KVM: Pass MMU notifier range flags to kvm_unmap_hva_range()

2020-08-24 Thread Greg KH
On Mon, Aug 24, 2020 at 12:30:47PM +0100, Will Deacon wrote: > commit fdfe7cbd58806522e799e2a50a15aee7f2cbb7b6 upstream. > > The 'flags' field of 'struct mmu_notifier_range' is used to indicate > whether invalidate_range_{start,end}() are permitted to block. In the > case of

[PATCH 08/11] iomap: Change iomap_write_begin calling convention

2020-08-24 Thread Matthew Wilcox (Oracle)
Pass (up to) the remaining length of the extent to iomap_write_begin() and have it return the number of bytes that will fit in the page. That lets us copy more bytes per call to iomap_write_begin() if the page cache has already allocated a THP (and will in future allow us to pass a hint to the

[PATCH 09/11] iomap: Support THPs in write paths

2020-08-24 Thread Matthew Wilcox (Oracle)
Use thp_size() instead of PAGE_SIZE and offset_in_thp() instead of offset_in_page(). Also simplify the logic in iomap_do_writepage() for determining end of file. Signed-off-by: Matthew Wilcox (Oracle) --- fs/iomap/buffered-io.c | 54 -- 1 file changed,

[PATCH 02/11] mm: Support THPs in zero_user_segments

2020-08-24 Thread Matthew Wilcox (Oracle)
We can only kmap() one subpage of a THP at a time, so loop over all relevant subpages, skipping ones which don't need to be zeroed. This is too large to inline when THPs are enabled and we actually need highmem, so put it in highmem.c. Signed-off-by: Matthew Wilcox (Oracle) ---

[PATCH 1/9] iomap: Fix misplaced page flushing

2020-08-24 Thread Matthew Wilcox (Oracle)
If iomap_unshare_actor() unshares to an inline iomap, the page was not being flushed. block_write_end() and __iomap_write_end() already contain flushes, so adding it to iomap_write_end_inline() seems like the best place. That means we can remove it from iomap_write_actor(). Signed-off-by:

[PATCH 01/11] fs: Make page_mkwrite_check_truncate thp-aware

2020-08-24 Thread Matthew Wilcox (Oracle)
If the page is compound, check the last index in the page and return the appropriate size. Change the return type to ssize_t in case we ever support pages larger than 2GB. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/pagemap.h | 10 +- 1 file changed, 5 insertions(+), 5

[PATCH 0/9] THP iomap patches for 5.10

2020-08-24 Thread Matthew Wilcox (Oracle)
These patches are carefully plucked from the THP series. I would like them to hit 5.10 to make the THP patchset merge easier. Some of these are just generic improvements that make sense on their own terms, but the overall intent is to support THPs in iomap. I'll send another patch series later

Re: Is: virtio_gpu_object_shmem_init issues? Was:Re: upstream boot error: general protection fault in swiotlb_map

2020-08-24 Thread Christoph Hellwig
On Mon, Aug 24, 2020 at 11:06:51AM -0400, Konrad Rzeszutek Wilk wrote: > So it fails at > > 683 dev_WARN_ONCE(dev, 1, > > 684 "swiotlb addr %pad+%zu overflow (mask %llx, bus > limit %llx).\n", > 685

Re: [LKP] Re: [x86/mce] 1de08dccd3: will-it-scale.per_process_ops -14.1% regression

2020-08-24 Thread Borislav Petkov
On Fri, Aug 21, 2020 at 10:02:59AM +0800, Feng Tang wrote: > 1de08dccd383 x86/mce: Add a struct mce.kflags field > 9554bfe403bd x86/mce: Convert the CEC to use the MCE notifier > > And strange thing is after using gcc9 and debian10 rootfs, with same commits > the regression turns to a

Re: [PATCH] ceph: add column 'mds' to show caps in more user friendly

2020-08-24 Thread Jeff Layton
On Mon, 2020-08-24 at 11:00 +0800, Yanhu Cao wrote: > In multi-mds, the 'caps' debugfs file will have duplicate ino, > add the 'mds' column to indicate which mds session the cap belongs to. > > Signed-off-by: Yanhu Cao > --- > fs/ceph/debugfs.c | 7 --- > 1 file changed, 4 insertions(+), 3

[PATCH v4 3/3] arm64: dts: sparx5: Add Sparx5 eMMC support

2020-08-24 Thread Lars Povlsen
This adds eMMC support to the applicable Sparx5 board configuration files. Signed-off-by: Lars Povlsen --- arch/arm64/boot/dts/microchip/sparx5.dtsi | 24 +++ .../boot/dts/microchip/sparx5_pcb125.dts | 23 ++ .../boot/dts/microchip/sparx5_pcb134_emmc.dts

[net v3 PATCH 2/2] net: ethernet: ti: cpsw_new: fix clean up of vlan mc entries for host port

2020-08-24 Thread Murali Karicheri
To flush the vid + mc entries from ALE, which is required when a VLAN interface is removed, driver needs to call cpsw_ale_flush_multicast() with ALE_PORT_HOST for port mask as these entries are added only for host port. Without this, these entries remain in the ALE table even after removing the

[net v3 PATCH 1/2] net: ethernet: ti: cpsw: fix clean up of vlan mc entries for host port

2020-08-24 Thread Murali Karicheri
To flush the vid + mc entries from ALE, which is required when a VLAN interface is removed, driver needs to call cpsw_ale_flush_multicast() with ALE_PORT_HOST for port mask as these entries are added only for host port. Without this, these entries remain in the ALE table even after removing the

[PATCH v4 2/3] sdhci: sparx5: Add Sparx5 SoC eMMC driver

2020-08-24 Thread Lars Povlsen
This adds the eMMC driver for the Sparx5 SoC. It is based upon the designware IP, but requires some extra initialization and quirks. Signed-off-by: Lars Povlsen --- drivers/mmc/host/Kconfig | 13 ++ drivers/mmc/host/Makefile | 1 + drivers/mmc/host/sdhci-of-sparx5.c | 269

[PATCH v4 0/3] mmc: Adding support for Microchip Sparx5 SoC

2020-08-24 Thread Lars Povlsen
(This is a resend of an identical patch set, sent at a time where Sparx5 support was not integrated yet. With the Sparx5 clock driver and associated header now in place in the v5.9rc series, the driver is now resubmitted for inclusion). The patch adds eMMC support for Sparx5, by adding a driver

[PATCH v4 1/3] dt-bindings: mmc: Add Sparx5 SDHCI controller bindings

2020-08-24 Thread Lars Povlsen
The Sparx5 SDHCI controller is based on the Designware controller IP. Signed-off-by: Lars Povlsen --- .../mmc/microchip,dw-sparx5-sdhci.yaml| 65 +++ 1 file changed, 65 insertions(+) create mode 100644

Is: virtio_gpu_object_shmem_init issues? Was:Re: upstream boot error: general protection fault in swiotlb_map

2020-08-24 Thread Konrad Rzeszutek Wilk
On Thu, Aug 06, 2020 at 03:46:23AM -0700, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:47ec5303 Merge git://git.kernel.org/pub/scm/linux/kernel/g.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=16fe1dea90 >

[PATCH 8/9] iomap: Convert iomap_write_end types

2020-08-24 Thread Matthew Wilcox (Oracle)
iomap_write_end cannot return an error, so switch it to return size_t instead of int and remove the error checking from the callers. Also convert the arguments to size_t from unsigned int, in case anyone ever wants to support a page size larger than 2GB. Signed-off-by: Matthew Wilcox (Oracle)

Re: [PATCH] x86/mce: Increase maximum number of banks to 64

2020-08-24 Thread Yazen Ghannam
On Thu, Aug 20, 2020 at 06:15:15PM +, Luck, Tony wrote: > >> How much does vmlinux size grow with your change? > >> > > > > It seems to get smaller. > > > > -rwxrwxr-x 1 yghannam yghannam 807634088 Aug 20 17:51 vmlinux-32banks > > -rwxrwxr-x 1 yghannam yghannam 807634072 Aug 20 17:50

Re: [Resend PATCH 1/6] mm/memcg: warning on !memcg after readahead page charged

2020-08-24 Thread Michal Hocko
On Mon 24-08-20 10:52:02, Qian Cai wrote: > On Thu, Aug 20, 2020 at 10:58:50AM -0400, Qian Cai wrote: > > On Tue, Aug 11, 2020 at 07:10:27PM +0800, Alex Shi wrote: > > > Since readahead page is charged on memcg too, in theory we don't have to > > > check this exception now. Before safely remove

[PATCH 5/9] iomap: Support arbitrarily many blocks per page

2020-08-24 Thread Matthew Wilcox (Oracle)
Size the uptodate array dynamically to support larger pages in the page cache. With a 64kB page, we're only saving 8 bytes per page today, but with a 2MB maximum page size, we'd have to allocate more than 4kB per page. Add a few debugging assertions. Signed-off-by: Matthew Wilcox (Oracle) ---

Re: [PATCH -next] amdgpu: fix Documentation builds for pm/ file movement

2020-08-24 Thread Alex Deucher
Applied. Thanks! Alex On Sun, Aug 23, 2020 at 11:00 PM Quan, Evan wrote: > > [AMD Official Use Only - Internal Distribution Only] > > Thanks for fixing this. The patch is reviewed-by: Evan Quan > > > BR > Evan > -Original Message- > From: Randy Dunlap > Sent: Monday, August 24, 2020

Re: [RFC PATCH 3/3] opp: Power on (virtual) power domains managed by the OPP core

2020-08-24 Thread Stephan Gerhold
On Mon, Aug 24, 2020 at 04:36:57PM +0200, Ulf Hansson wrote: > On Mon, 24 Aug 2020 at 13:56, Stephan Gerhold wrote: > > > > On Mon, Aug 24, 2020 at 04:57:44PM +0530, Viresh Kumar wrote: > > > On 30-07-20, 10:01, Stephan Gerhold wrote: > > > > dev_pm_opp_attach_genpd() allows attaching an

[PATCH 9/9] iomap: Change calling convention for zeroing

2020-08-24 Thread Matthew Wilcox (Oracle)
Pass the full length to iomap_zero() and dax_iomap_zero(), and have them return how many bytes they actually handled. This is preparatory work for handling THP, although it looks like DAX could actually take advantage of it if there's a larger contiguous area. Signed-off-by: Matthew Wilcox

RE: [PATCH] MAINTAINERS: Update Intel TXT maintainer

2020-08-24 Thread Sun, Ning
Acknowledged. -Ning -Original Message- From: Lukasz Hawrylko Sent: Wednesday, August 12, 2020 5:24 AM To: Sun, Ning Cc: Lukasz Hawrylko ; Mauro Carvalho Chehab ; David S. Miller ; Rob Herring ; linux-kernel@vger.kernel.org Subject: [PATCH] MAINTAINERS: Update Intel TXT maintainer

[PATCH 2/9] fs: Introduce i_blocks_per_page

2020-08-24 Thread Matthew Wilcox (Oracle)
This helper is useful for both THPs and for supporting block size larger than page size. Convert all users that I could find (we have a few different ways of writing this idiom, and I may have missed some). Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Christoph Hellwig ---

Re: [Resend PATCH 1/6] mm/memcg: warning on !memcg after readahead page charged

2020-08-24 Thread Michal Hocko
On Fri 21-08-20 15:48:44, Michal Hocko wrote: > On Fri 21-08-20 08:39:37, Qian Cai wrote: > > On Fri, Aug 21, 2020 at 10:01:27AM +0200, Michal Hocko wrote: > > > On Thu 20-08-20 10:58:51, Qian Cai wrote: > > > > On Tue, Aug 11, 2020 at 07:10:27PM +0800, Alex Shi wrote: > > > > > Since readahead

Re: [PATCH][next] NTB: Use struct_size() helper in devm_kzalloc()

2020-08-24 Thread Jon Mason
On Fri, Jun 19, 2020 at 01:10:55PM -0600, Logan Gunthorpe wrote: > > > On 2020-06-19 11:25 a.m., Gustavo A. R. Silva wrote: > > Make use of the struct_size() helper instead of an open-coded version > > in order to avoid any potential type mistakes. Also, remove unnecessary > > variable

[PATCH 6/9] iomap: Convert read_count to byte count

2020-08-24 Thread Matthew Wilcox (Oracle)
Instead of counting bio segments, count the number of bytes submitted. This insulates us from the block layer's definition of what a 'same page' is, which is not necessarily clear once THPs are involved. Signed-off-by: Matthew Wilcox (Oracle) --- fs/iomap/buffered-io.c | 29

[PATCH 4/9] iomap: Use bitmap ops to set uptodate bits

2020-08-24 Thread Matthew Wilcox (Oracle)
Now that the bitmap is protected by a spinlock, we can use the more efficient bitmap ops instead of individual test/set bit ops. Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Christoph Hellwig --- fs/iomap/buffered-io.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-)

RE: Re:Re: [PATCH] powerpc: Fix a bug in __div64_32 if divisor is zero

2020-08-24 Thread David Laight
From: Guohua Zhong > Sent: 24 August 2020 14:26 > > >> >In generic version in lib/math/div64.c, there is no checking of 'base' > >> >either. > >> >Do we really want to add this check in the powerpc version only ? > >> > >> >The only user of __div64_32() is do_div() in > >>

<    6   7   8   9   10   11   12   13   14   15   >