Add shutdown/wakeup a resource eemi operations to shutdown
or bringup a resource.
Note alignment of args matches convention of other fn's in this file.
The reason being that the long fn name results in aligned args that
otherwise go over 80 chars so shift right to avoid this
Signed-off-by: Ben
On Wed, Sep 02, 2020 at 10:06:14PM +0800, YueHaibing wrote:
> In case of error, the function devm_ioremap_wc() returns NULL pointer
> not ERR_PTR(). The IS_ERR() test in the return value check should be
> replaced with NULL test.
>
> Fixes: 87218f96c21a ("remoteproc: k3-dsp: Add support for C71x
The driver was tested on Xilinx ZynqMP QEMU
For sake of ease of review, only support ZynqMP. Once accepted, then
add support for Versal platform and R5 loading onto OCM.
v2:
- remove domain struct
v3:
- add xilinx-related platform mgmt fn's instead of wrapping around
function pointer in xilinx
Add support for migrating transparent huge pages to and from device
private memory.
Signed-off-by: Ralph Campbell
---
drivers/gpu/drm/nouveau/nouveau_dmem.c | 289 ++---
drivers/gpu/drm/nouveau/nouveau_svm.c | 11 +-
drivers/gpu/drm/nouveau/nouveau_svm.h | 3 +-
3 files
Add ZynqMP firmware ioctl enums for RPU configuration.
Signed-off-by: Ben Levinsky
---
v3:
- add xilinx-related platform mgmt fn's instead of wrapping around
function pointer in xilinx eemi ops struct
v4:
- add default values for enums
---
include/linux/firmware/xlnx-zynqmp.h | 19
Transparent huge page allocation policy is controlled by several sysfs
variables. Rather than expose these to each device driver that needs to
allocate THPs, provide a helper function.
Signed-off-by: Ralph Campbell
---
include/linux/gfp.h | 10 ++
mm/huge_memory.c| 14 ++
Add a helper function to allow device drivers to create device private
transparent huge pages. This is intended to help support device private
THP migrations.
Signed-off-by: Ralph Campbell
---
include/linux/huge_mm.h | 5 +
mm/huge_memory.c| 8
2 files changed, 13
A migrating transparent huge page has to already be unmapped. Otherwise,
the page could be modified while it is being copied to a new page and
data could be lost. The function __split_huge_pmd() checks for a PMD
migration entry before calling __split_huge_pmd_locked() leading one to
think that
check_charging_duration() contains some copy-pasted code, which makes it
less readable. Refactor the function to be a bit tidier.
I've also fixed a couple of typos.
Signed-off-by: Alex Dewar
---
drivers/power/supply/charger-manager.c | 39 +-
1 file changed, 14
On Wed, 2020-09-02 at 09:53 +0200, Thomas Gleixner wrote:
> On Tue, Sep 01 2020 at 21:29, Joel Fernandes wrote:
> > On Tue, Sep 01, 2020 at 10:02:10PM +0200, Thomas Gleixner wrote:
> > >
> > Or, are you saying users may want 'core scheduling' enabled but may
> > want to
> > leave out the kernel
On Wed, Sep 02, 2020 at 05:43:03PM +0200, Christophe Leroy wrote:
> >Try with a newer ld? If it still happens with current versions, please
> >open a bug report? https://sourceware.org/bugzilla
>
> Yes it works with 2.30 and 2.34
Ah okay, I missed this part.
> But minimum for building kernel
On Wed, Sep 02, 2020 at 11:35:33PM +0800, cy_huang wrote:
> From: ChiYuan Huang
>
> Fix: If vbus event is before cc_event trigger, hard_reset_count
> won't bt reset for some case.
>
> Signed-off-by: ChiYuan Huang
> ---
> Below's the flow.
>
> _tcpm_pd_vbus_off() -> run_state_machine to change
On 02.09.2020 18:14, Krzysztof Kozlowski wrote:
> The Samsung Exynos System Registers (Sysreg) bindings are quite simple -
> just additional compatible to the syscon. They do not have any value so
> merge them into generic MFD syscon bindings.
>
> Suggested-by: Sylwester Nawrocki
>
On Wed, Sep 02, 2020 at 03:32:18PM +, Nadav Amit wrote:
> Thanks for pointer. I did not see the discussion, and embarrassingly, I have
> also never figured out how to reply on lkml emails without registering to
> lkml.
The lore.kernel.org thing I pointed you to allows you to download an
mbox
On Wednesday 02 September 2020 18:13:28 Andrew Lunn wrote:
> On Wed, Sep 02, 2020 at 04:43:43PM +0200, Pali Rohár wrote:
> > Driver ->power_on and ->power_off callbacks leaks internal SMCC firmware
> > return codes to phy caller. This patch converts SMCC error codes to
> > standard linux errno
ср, 2 сент. 2020 г. в 19:46, Jernej Škrabec :
>
> Dne sreda, 02. september 2020 ob 09:01:17 CEST je Roman Stratiienko
> napisal(a):
> > ср, 2 сент. 2020 г. в 00:58, Jernej Skrabec :
> > > Function sun8i_vi_layer_get_csc_mode() is supposed to return CSC mode
> > > but due to inproper return type
On Wed, Sep 02, 2020 at 07:07:15PM +0800, Nicolas Boichat wrote:
> If rpmsg_register_device fails, it will call
> mtk_rpmsg_release_device which already frees mdev.
>
> Fixes: 7017996951fde84 ("rpmsg: add rpmsg support for mt8183 SCP.")
The SHA should be 12 characters instead of 15. With that:
On 9/1/20 5:30 PM, Nishanth Menon wrote:
> Use temperature-sensor@ naming for nodes following standard conventions of
> device
> tree (section 2.2.2 Generic Names recommendation in [1]).
>
> [1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3
>
> Suggested-by: Suman Anna
>
On Wed, Sep 02, 2020 at 06:45:38PM +0200, pet...@infradead.org wrote:
> We really should clear the CPUID bits when the kernel explicitly
> disables things.
Actually, you want to *disable* the functionality behind it by clearing
a bit in CR4 - and yes, not all features have CR4 bits - so that
On 9/1/20 5:30 PM, Nishanth Menon wrote:
> Building with W=2 throws up a bunch of easy to fixup errors..
> node_name_chars_strict is one of them.. Knock those out.
>
> Signed-off-by: Nishanth Menon
> ---
> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 6 +++---
>
On 01.09.2020 12:37, Adrian Hunter wrote:
> The documentation descibes snapshot mode. Update it to include the new
> snapshot control command.
>
> Signed-off-by: Adrian Hunter
> ---
> tools/perf/Documentation/perf-intel-pt.txt | 23 +++---
> 1 file changed, 20 insertions(+),
On Wed, Sep 02, 2020 at 09:25:17AM -0700, Dave Hansen wrote:
> Ugh. I hate text parsers. But, I do see what you're getting at.
That's why it'll be a simple one. Nothing fancy. I'm hoping the final
version would be somewhat readable to humans too.
> If we do this, I bet having each value on its
On 9/2/20 9:45 AM, pet...@infradead.org wrote:
> On Thu, Aug 27, 2020 at 03:49:03PM +0800, Feng Tang wrote:
>> End users frequently want to know what features their processor
>> supports, independent of what the kernel supports.
>>
>> /proc/cpuinfo is great. It is omnipresent and since it is
On Wed, Sep 02, 2020 at 09:49:11AM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.8.6 release.
> There are 253 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me
On 9/1/20 5:30 PM, Nishanth Menon wrote:
> Use adc@ naming for nodes following standard conventions of device
> tree (section 2.2.2 Generic Names recommendation in [1]).
>
> [1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3
>
> Suggested-by: Suman Anna
> Signed-off-by:
On Wed, Sep 2, 2020 at 1:29 AM Thomas Gleixner wrote:
>
> On Tue, Sep 01 2020 at 17:09, Andy Lutomirski wrote:
> > On Tue, Sep 1, 2020 at 4:50 PM Thomas Gleixner wrote:
> >> > I think that they almost work for x86, but not quite as
> >> > indicated by this bug. Even if we imagine we can somehow
On Fri, Aug 28, 2020 at 02:16:03PM +0100, Boyan Karatotev wrote:
> PAuth signs and verifies return addresses on the stack. It does so by
> inserting a Pointer Authentication code (PAC) into some of the unused top
> bits of an address. This is achieved by adding paciasp/autiasp instructions
> at
On Fri, Aug 28, 2020 at 02:16:02PM +0100, Boyan Karatotev wrote:
> Pointer Authentication (PAuth) is a security feature introduced in ARMv8.3.
> It introduces instructions to sign addresses and later check for potential
> corruption using a second modifier value and one of a set of keys. The
>
On Tue, Sep 01, 2020 at 05:09:15PM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.19.143 release.
> There are 125 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me
On Wed, Sep 02, 2020 at 09:48:59AM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.4.62 release.
> There are 213 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me
On Thu, Aug 27, 2020 at 6:21 AM Randy Dunlap wrote:
>
> From: Randy Dunlap
>
> A user reported:
> 'Use of uninitialized value $ENV{"LMC_KEEP"} in split at
> ./scripts/kconfig/streamline_config.pl line 596.'
>
> so first check that $ENV{LMC_KEEP} is defined before trying
> to use it.
>
> Fixes:
On Tue, Sep 01, 2020 at 05:09:34PM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.14.196 release.
> There are 91 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me
On 02/09/2020 17:43, Gustavo A. R. Silva wrote:
> On Wed, Sep 02, 2020 at 09:29:31AM -0700, Randy Dunlap wrote:
>> On 9/2/20 9:23 AM, Gustavo A. R. Silva wrote:
>>> A few months ago, commit e132fc6bb89b ("power: supply: charger-manager:
>>> Make decisions focussed on battery status")
>>> changed
On Tue, Sep 01, 2020 at 05:09:36PM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.9.235 release.
> There are 78 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me
Dne sreda, 02. september 2020 ob 09:01:17 CEST je Roman Stratiienko
napisal(a):
> ср, 2 сент. 2020 г. в 00:58, Jernej Skrabec :
> > Function sun8i_vi_layer_get_csc_mode() is supposed to return CSC mode
> > but due to inproper return type (bool instead of u32) it returns just 0
> > or 1. Colors
On Thu, Aug 27, 2020 at 03:49:03PM +0800, Feng Tang wrote:
> End users frequently want to know what features their processor
> supports, independent of what the kernel supports.
>
> /proc/cpuinfo is great. It is omnipresent and since it is provided by
> the kernel it is always as up to date as
On Wed, Sep 02, 2020 at 09:48:35AM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.4.235 release.
> There are 61 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me
On Thu, Aug 27, 2020 at 1:30 AM Changbin Du wrote:
>
> On Tue, Aug 25, 2020 at 02:34:34PM -0700, Randy Dunlap wrote:
> > On 8/25/20 2:12 PM, Randy Dunlap wrote:
> > >> On Tue, Aug 25, 2020 at 2:13 PM Randy Dunlap
> > >> wrote:
> > >>>
> > >>> so intel_rapl_perf is listed in your lsmod.cfg file:
On Tue, Aug 18, 2020 at 03:07:04PM +0800, chenzhou wrote:
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index a8e34d97a894..4df18c7ea438 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -147,7 +147,7 @@ static void __init reserve_crashkernel(void)
> }
>
On Wed, 2 Sep 2020 at 10:30, Deepak Kumar Singh wrote:
>
>
> On 7/6/2020 11:34 PM, Mathieu Poirier wrote:
> > Hi Deepak,
> >
> > On Fri, Jun 26, 2020 at 08:16:55PM +0530, Deepak Kumar Singh wrote:
> >> Change from version 5
> >> [V5,4/4] rpmsg: char: Add signal callback and POLLPRI support
> >>
I emailed you earlier without a response, Haven't you received it?
Please update me urgently for more clarification on time.
On Wed, 2 Sep 2020 at 13:18, Greg Kroah-Hartman
wrote:
>
> This is the start of the stable review cycle for the 5.4.62 release.
> There are 213 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
>
On Wed, Sep 02, 2020 at 09:29:31AM -0700, Randy Dunlap wrote:
> On 9/2/20 9:23 AM, Gustavo A. R. Silva wrote:
> > A few months ago, commit e132fc6bb89b ("power: supply: charger-manager:
> > Make decisions focussed on battery status")
> > changed the expression in the if statement from "duration >
On 02/09/2020 17:03:39+0200, Krzysztof Kozlowski wrote:
> The at91sam9g45_pcr_layout is not used so drop it to fix build warning:
>
> drivers/clk/at91/at91sam9g45.c:49:36: warning:
> 'at91sam9g45_pcr_layout' defined but not used [-Wunused-const-variable=]
>
> Signed-off-by: Krzysztof
On Wed, Aug 12, 2020 at 09:46:56AM -0700, Sean V Kelley wrote:
> From: Qiuxu Zhuo
>
> When attempting error recovery for an RCiEP associated with an RCEC device,
> there needs to be a way to update the Root Error Status, the Uncorrectable
> Error Status and the Uncorrectable Error Severity of
On Wed, Sep 2, 2020 at 6:31 PM Sakari Ailus
wrote:
>
> Hi Rafael,
>
> Thank you for the review.
>
> On Wed, Sep 02, 2020 at 05:57:01PM +0200, Rafael J. Wysocki wrote:
> > On Tue, Sep 1, 2020 at 11:03 PM Sakari Ailus
> > wrote:
> > >
> > > Document the probe-low-power _DSD property and how it is
In xp_create_dma_map(), memory is allocated to dma_map->dma_pages, but
then dma_map is erroneously compared to NULL, rather than the member.
Fix this.
Addresses-Coverity: ("Dead code")
Fixes: 921b68692abb ("xsk: Enable sharing of dma mappings")
Signed-off-by: Alex Dewar
---
The ROHM BD71847 PMIC has a 32.768 kHz clock. Adding necessary parent
allows to probe the bd718x7 clock driver fixing boot errors:
bd718xx-clk bd71847-clk.1.auto: No parent clk found
bd718xx-clk: probe of bd71847-clk.1.auto failed with error -22
Signed-off-by: Krzysztof Kozlowski
---
On Wed, Sep 02, 2020 at 06:24:27PM +0200, Jürgen Groß wrote:
> On 02.09.20 17:58, Brian Gerst wrote:
> > On Wed, Sep 2, 2020 at 9:38 AM Peter Zijlstra wrote:
> > >
> > > From: Peter Zijlstra
> > >
> > > The WARN added in commit 3c73b81a9164 ("x86/entry, selftests: Further
> > > improve user
Hi Rafael,
Thank you for the review.
On Wed, Sep 02, 2020 at 05:57:01PM +0200, Rafael J. Wysocki wrote:
> On Tue, Sep 1, 2020 at 11:03 PM Sakari Ailus
> wrote:
> >
> > Document the probe-low-power _DSD property and how it is used with I²C
> > drivers.
>
> I would reorder the series to make
On 7/6/2020 11:34 PM, Mathieu Poirier wrote:
Hi Deepak,
On Fri, Jun 26, 2020 at 08:16:55PM +0530, Deepak Kumar Singh wrote:
Change from version 5
[V5,4/4] rpmsg: char: Add signal callback and POLLPRI support
Updated for sparse warning. Replaced POLLPRI => EPOLLPRI to fix
warning.
Change
On 9/2/20 9:23 AM, Gustavo A. R. Silva wrote:
> A few months ago, commit e132fc6bb89b ("power: supply: charger-manager: Make
> decisions focussed on battery status")
> changed the expression in the if statement from "duration >
> desc->discharging_max_duration_ms"
> to "duration >
From: Colin Ian King
Currently when an xa_alloc failure occurs the error exit path leaks
the allocated object mc. Fix this by adding an error return path
that frees mc and rename error exit paths err3 to err4 and err2 to err3.
Fixes: 95fe51096b7a ("RDMA/ucma: Remove mc_list and rely on
On Wed, 2 Sep 2020 at 13:18, Greg Kroah-Hartman
wrote:
>
> This is the start of the stable review cycle for the 5.8.6 release.
> There are 253 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
>
Hi Mauro,
Thank you for the patch.
On Wed, Sep 02, 2020 at 06:10:05PM +0200, Mauro Carvalho Chehab wrote:
> There are some reports about possible memory leaks:
>
> drivers/media/v4l2-core//v4l2-ioctl.c:3203 video_put_user() warn: check
> that 'ev32' doesn't leak information (struct has a
Add documentation for introduction to
-context-switch
-x86 context-switch
-MIPS context switch
Suggested-by: Lukas Bulwahn
Co-developed-by: Mostafa Chamanara
Signed-off-by: Mostafa Chamanara
Co-developed-by: Oleg Tsymbal
Signed-off-by: Oleg Tsymbal
Signed-off-by: John Mathew
---
Add new sections to enable addition of new documentation on
the scheduler. Existing documentation is moved under the related
new sections. The sections are
- overview
- sched-features
- arch-specific.rst
- sched-debugging.rst
Suggested-by: Lukas Bulwahn
Signed-off-by: John Mathew
---
On 02/09/2020 16:58, Brian Gerst wrote:
> On Wed, Sep 2, 2020 at 9:38 AM Peter Zijlstra wrote:
>> From: Peter Zijlstra
>>
>> The WARN added in commit 3c73b81a9164 ("x86/entry, selftests: Further
>> improve user entry sanity checks") unconditionally triggers on my IVB
>> machine because it does
On Thu, Sep 03, 2020 at 12:58:14AM +0900, Masahiro Yamada wrote:
> Sorry for the long delay.
>
> First, this patch breaks 'make TAGS'
> if 'etags' is a symlink to exuberant ctags.
>
>
> masahiro@oscar:~/ref/linux$ etags --version
> Exuberant Ctags 5.9~svn20110310, Copyright (C) 1996-2009
This patch series updates the scheduler documentation to add more topics
wrt to scheduler overview. New sections are added to provide a brief
overview of the kernel structs used by the scheduler, scheduler invocation,
and context switch. Previous version of the patch was reviewed at:
Add documentation for
-scheduler overview
-scheduler state transtion
-CFS overview
-scheduler data structs
Add rst for scheduler APIs and modify sched/core.c
to add kernel-doc comments.
Suggested-by: Lukas Bulwahn
Co-developed-by: Mostafa Chamanara
Signed-off-by: Mostafa Chamanara
On 9/2/20 8:40 AM, Borislav Petkov wrote:
> When you need to add a new leaf, you simply extend the text file and the
> tool parses it anew and has its all CPUID info uptodate. This way you
> won't even have to recompile it. Adding new CPUID leafs would be adding new
> lines to the file.
>
> For
In ucma_process_join(), if the call to xa_alloc() fails, the function
will return without freeing mc. Fix this by jumping to the correct line.
In the process I renamed the jump labels to something more memorable for
extra clarity.
Addresses-Coverity: ("Resource leak")
Fixes: 95fe51096b7a
From: Arun Kumar Neelakantam
Add TICOMGET and TIOCMSET ioctl support for rpmsg char device nodes
to get/set the low level transport signals.
Signed-off-by: Deepak Kumar Singh
Signed-off-by: Arun Kumar Neelakantam
---
drivers/rpmsg/rpmsg_char.c | 54
Some transports like Glink support the state notifications between
clients using signals similar to serial protocol signals.
Local glink client drivers can send and receive signals to glink
clients running on remote processors.
Add apis to support sending and receiving of signals by rpmsg
On 02.09.20 17:58, Brian Gerst wrote:
On Wed, Sep 2, 2020 at 9:38 AM Peter Zijlstra wrote:
From: Peter Zijlstra
The WARN added in commit 3c73b81a9164 ("x86/entry, selftests: Further
improve user entry sanity checks") unconditionally triggers on my IVB
machine because it does not support
Hi everyone,
On Tue, Sep 1, 2020 at 7:19 AM 吴兴育B01779 wrote:
>
> Hi Sakari,
>
> It seems the e-mails you're sending do not end up to LMML nor kernel.org
> Patchwork.
> ===>It looks like we need to fix this before patch can land in patchwork.
>
FYI, I'll take care of addressing the comments to
From: Arun Kumar Neelakantam
Register a callback to get the signal notifications from rpmsg and
send POLLPRI mask to indicate the signal change in POLL system call.
Signed-off-by: Deepak Kumar Singh
Signed-off-by: Arun Kumar Neelakantam
---
drivers/rpmsg/rpmsg_char.c | 22
From: Arun Kumar Neelakantam
Remote peripherals send signal notifications over glink with commandID 15.
Add support to send and receive the signal command and convert the signals
from NATIVE to TIOCM while receiving and vice versa while sending.
Signed-off-by: Chris Lew
Signed-off-by: Deepak
Change from version 6
In last series(v6) i had put wrong version(v5) for cover note.
Which led to confusion for patch set series.
In this series i have updated the label for cover letter(v7).
There is no change in patches. Only cover note label is updated.
Change from version 5
[V6,4/4] rpmsg:
n't send emails to the list
> > informing of the inclusion of a patch/series in your tree?
> >
> > Anyway applied now to v5.9-next/dts64 :)
>
> arm64 build dtbs failed on linux next 20200902.
I just hit it as well... I wish the kernel was built after applying
patches... it would make the next a better place.
Best regards,
Krzysztof
On 9/2/20 9:16 AM, Antoni Przybylik wrote:
> Changed return type to bool and removed inline specifier. Also added
> static specifier.
why remove the inline specifier?
thanks.
> Signed-off-by: Antoni Przybylik
> ---
> drivers/staging/gdm724x/gdm_tty.c | 2 +-
> 1 file changed, 1 insertion(+),
On Wed, Sep 02 2020 at 11:11am -0400,
Christoph Hellwig wrote:
> On Wed, Aug 26, 2020 at 06:07:38PM -0400, Mike Snitzer wrote:
> > On Sun, Jul 26 2020 at 11:03am -0400,
> > Christoph Hellwig wrote:
> >
> > > Drivers shouldn't really mess with the readahead size, as that is a VM
> > > concept.
On Wed, Sep 02, 2020 at 05:12:51PM +0200, Björn Töpel wrote:
> On 2020-09-02 17:07, Gustavo A. R. Silva wrote:
> > Currently, dma_map is being checked, when the right object identifier
> > to be null-checked is dma_map->dma_pages, instead.
> >
> > Fix this by null-checking dma_map->dma_pages.
> >
On 9/2/20 5:12 PM, Christoph Hellwig wrote:
> Switch to use bdev_check_media_change instead of check_disk_change and
> call cd_revalidate_disk manually. As sd also calls sd_revalidate_disk
s/cd/sd/?
> manually during probe and open, , the extra call into ->revalidate_disk
> from
Move such logic from vivid_create_instance(), as otherwise
smatch takes forever.
The vivid_create_instance() is still a too big for my taste.
So, further cleanups are still needed.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/test-drivers/vivid/vivid-core.c | 161 +-
Instead of placing everything inside vivid_create_instance(),
we can move the part which creates per-type video queues
into a separate function.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/test-drivers/vivid/vivid-core.c | 175 +-
1 file changed, 92 insertions(+), 83
The original logic had an integer to unsigned integer
conversion, plus a float-point math. While gcc should be
able to do the match at compile time, other compilers might
not do the same. Also, those produce the following warnings
with static code analyzers:
The vivid_create_instance() function is too harry. Smatch can't
process it, because it takes too long.
The detection part is an important piece of it. As such, there
are even comments before and after such block.
So, it makes sense to just move it to a separate function.
Signed-off-by: Mauro
While smatch reports an issue there:
drivers/media/pci/ttpci/av7110_v4l.c:163 ves1820_set_tv_freq() warn:
unsigned 'freq' is never less than zero.
drivers/media/pci/ttpci/av7110_v4l.c:165 ves1820_set_tv_freq() warn:
unsigned 'freq' is never less than zero.
The logic is actually
The usage of castings and float point when checking for
the setup based at the symbol_rate cause those warnings
with smatch:
drivers/media/dvb-frontends/tda10021.c:153 tda10021_set_symbolrate()
warn: unsigned 'symbolrate' is never less than zero.
Hi Tobias,
Am 31.08.20 um 23:59 schrieb Tobias Schramm:
> This commit enables ddr modes for eMMC storage on emmc2.
> The bcm2711 supports eMMC storage using ddr modes. The board
> layout of the Raspberry Pi 4 supports them, too.
i want to inform you that Ulf Hansson already applied my driver
There are some reports about possible memory leaks:
drivers/media/v4l2-core//v4l2-ioctl.c:3203 video_put_user() warn: check
that 'ev32' doesn't leak information (struct has a hole after 'type')
drivers/media/v4l2-core//v4l2-ioctl.c:3230 video_put_user() warn: check
that 'vb32'
Move this code out of the long vivid_create_instance() function.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/test-drivers/vivid/vivid-core.c | 182 +-
1 file changed, 96 insertions(+), 86 deletions(-)
diff --git a/drivers/media/test-drivers/vivid/vivid-core.c
As reported by smatch:
drivers/media/v4l2-core/videobuf-dma-sg.c:245
videobuf_dma_init_kernel() warn: should 'nr_pages << 12' be a 64 bit type?
The printk should not be using %d for the number of pages.
After looking better, the real problem here is that the
number of pages should be
As reported by smatch:
drivers/media/pci/saa7134//saa7134-tvaudio.c:686 saa_dsp_writel() warn:
should 'reg << 2' be a 64 bit type?
On a 64-bits Kernel, the shift might be bigger than 32 bits.
In real, this should never happen, but let's shut up the warning.
Signed-off-by: Mauro
A few months ago, commit e132fc6bb89b ("power: supply: charger-manager: Make
decisions focussed on battery status")
changed the expression in the if statement from "duration >
desc->discharging_max_duration_ms"
to "duration > desc->charging_max_duration_ms", but the arguments for
dev_info()
As warned by smatch:
drivers/media/rc/serial_ir.c:550 serial_ir_probe() warn: should '8 <<
ioshift' be a 64 bit type?
the "8" constant should be unsigned long.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/rc/serial_ir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
If something fails after calling v4l2_device_register(),
it should call v4l2_device_put().
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/test-drivers/vivid/vivid-core.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git
As reported by smatch:
drivers/media/pci/cx25821/cx25821-alsa.c:146 cx25821_alsa_dma_init()
warn: should 'nr_pages << 12' be a 64 bit type?
the number of patches should be unsigned long.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/pci/cx25821/cx25821-alsa.c | 11
From: Colin Ian King
The failed memory allocation check for dma_map->dma_pages is incorrect,
it is null checking dma_map and not dma_map->dma_pages. Fix this.
Addresses-Coverity: ("Logicall dead code")
Fixes: 921b68692abb ("xsk: Enable sharing of dma mappings")
Signed-off-by: Colin Ian King
Changed return type to bool and removed inline specifier. Also added
static specifier.
Signed-off-by: Antoni Przybylik
---
drivers/staging/gdm724x/gdm_tty.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_tty.c
As reported by smatch:
drivers/media/pci/saa7134/saa7134-alsa.c:267 saa7134_alsa_dma_init()
warn: should 'nr_pages << 12' be a 64 bit type?
the number of patches should be unsigned long.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/pci/saa7134/saa7134-alsa.c | 7 ---
This approach is more elegant and prevents some problems related to
macros such as operator precedence in expanded expression.
Signed-off-by: Antoni Przybylik
---
drivers/staging/gdm724x/gdm_tty.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git
As reported by smatch:
drivers/media//pci/cx23885/cx23885-alsa.c:83 cx23885_alsa_dma_init()
warn: should 'nr_pages << 12' be a 64 bit type?
the number of patches should be unsigned long.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/pci/cx23885/cx23885-alsa.c | 7 ---
Hello!
On 9/2/20 5:12 PM, Christoph Hellwig wrote:
> The pcd driver does not have a ->revalidate_disk method, so it can just
s/pcd/md/?
> use bdev_check_media_change without any additional changes.
>
> Signed-off-by: Christoph Hellwig
> ---
> drivers/md/md.c | 2 +-
> 1 file changed, 1
The Samsung Exynos System Registers (Sysreg) bindings are quite simple -
just additional compatible to the syscon. They do not have any value so
merge them into generic MFD syscon bindings.
Suggested-by: Sylwester Nawrocki
Signed-off-by: Krzysztof Kozlowski
---
Changes since v1:
1. New patch
On Wed, Sep 02, 2020 at 04:43:43PM +0200, Pali Rohár wrote:
> Driver ->power_on and ->power_off callbacks leaks internal SMCC firmware
> return codes to phy caller. This patch converts SMCC error codes to
> standard linux errno codes. Include file linux/arm-smccc.h already provides
> defines for
Just move the stuff there to the places where this header is
included.
Signed-off-by: Mauro Carvalho Chehab
---
.../css_2401_system/host/ibuf_ctrl_local.h| 1 +
.../css_2401_system/host/ibuf_ctrl_private.h | 268 --
.../host/ibuf_ctrl_public.h | 94
Document Samsung Exynos3 and Exynos5433 compatibles for system
registers.
Reviewed-by: Sylwester Nawrocki
Signed-off-by: Krzysztof Kozlowski
---
Changes since v1:
1. Rebase on first patch
---
Documentation/devicetree/bindings/mfd/syscon.yaml | 2 ++
1 file changed, 2 insertions(+)
diff
501 - 600 of 1333 matches
Mail list logo
