Re: Packet gets stuck in NOLOCK pfifo_fast qdisc

2020-09-10 Thread Cong Wang
On Thu, Sep 3, 2020 at 8:21 PM Kehuan Feng wrote: > I also tried Cong's patch (shown below on my tree) and it could avoid > the issue (stressing for 30 minutus for three times and not jitter > observed). Thanks for verifying it! > > --- ./include/net/sch_generic.h.orig 2020-08-21

Re: [PATCH 05/15] habanalabs/gaudi: add NIC Ethernet support

2020-09-10 Thread Oded Gabbay
On Thu, Sep 10, 2020 at 11:03 PM Jakub Kicinski wrote: > > On Thu, 10 Sep 2020 19:11:16 +0300 Oded Gabbay wrote: > > +module_param(nic_rx_poll, int, 0444); > > +MODULE_PARM_DESC(nic_rx_poll, > > + "Enable NIC Rx polling mode (0 = no, 1 = yes, default no)"); > > If your chip does not support

Re: [PATCH 12/15] habanalabs/gaudi: add debugfs entries for the NIC

2020-09-10 Thread Oded Gabbay
On Thu, Sep 10, 2020 at 11:16 PM Jakub Kicinski wrote: > > On Thu, 10 Sep 2020 23:10:47 +0300 Oded Gabbay wrote: > > On Thu, Sep 10, 2020 at 11:01 PM Jakub Kicinski wrote: > > > > > > On Thu, 10 Sep 2020 19:11:23 +0300 Oded Gabbay wrote: > > > > From: Omer Shpigelman > > > > > > > > Add several

Re: Packet gets stuck in NOLOCK pfifo_fast qdisc

2020-09-10 Thread Cong Wang
On Thu, Sep 3, 2020 at 10:08 PM John Fastabend wrote: > Maybe this would unlock us, > > diff --git a/net/core/dev.c b/net/core/dev.c > index 7df6c9617321..9b09429103f1 100644 > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -3749,7 +3749,7 @@ static inline int __dev_xmit_skb(struct sk_buff

Re: [PATCH 00/15] Adding GAUDI NIC code to habanalabs driver

2020-09-10 Thread Oded Gabbay
On Thu, Sep 10, 2020 at 11:01 PM Jakub Kicinski wrote: > > On Thu, 10 Sep 2020 19:11:11 +0300 Oded Gabbay wrote: > > create mode 100644 drivers/misc/habanalabs/gaudi/gaudi_nic.c > > create mode 100644 drivers/misc/habanalabs/gaudi/gaudi_nic.h > > create mode 100644

Re: [PATCH 12/15] habanalabs/gaudi: add debugfs entries for the NIC

2020-09-10 Thread Jakub Kicinski
On Thu, 10 Sep 2020 23:10:47 +0300 Oded Gabbay wrote: > On Thu, Sep 10, 2020 at 11:01 PM Jakub Kicinski wrote: > > > > On Thu, 10 Sep 2020 19:11:23 +0300 Oded Gabbay wrote: > > > From: Omer Shpigelman > > > > > > Add several debugfs entries to help us debug the NIC engines and ports and > > >

[PATCH net-next 1/6] hinic: Fix some kernel-doc warnings in hinic_hw_io.c

2020-09-10 Thread Wang Hai
Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/huawei/hinic/hinic_hw_io.c:373: warning: Excess function parameter 'sq_msix_entry' description in 'hinic_io_create_qps' drivers/net/ethernet/huawei/hinic/hinic_hw_io.c:373: warning: Excess function parameter 'rq_msix_entry'

[PATCH net-next 6/6] net: hns: Fix a kernel-doc warning in hinic_hw_eqs.c

2020-09-10 Thread Wang Hai
Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c:115: warning: Excess function parameter 'hw_handler' description in 'hinic_aeq_register_hw_cb' Reported-by: Hulk Robot Signed-off-by: Wang Hai ---

[PATCH net-next 2/6] net: hns: fix 'cdev' kernel-doc warning in hnae_ae_unregister()

2020-09-10 Thread Wang Hai
Rename cdev to hdev. Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/hisilicon/hns/hnae.c:444: warning: Excess function parameter 'cdev' description in 'hnae_ae_unregister' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/hisilicon/hns/hnae.c |

[PATCH net-next 5/6] net: hns: Fix a kernel-doc warning in hinic_hw_api_cmd.c

2020-09-10 Thread Wang Hai
Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/huawei/hinic/hinic_hw_api_cmd.c:382: warning: Excess function parameter 'size' description in 'api_cmd' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/huawei/hinic/hinic_hw_api_cmd.c | 2 +- 1

Re: [PATCH 12/15] habanalabs/gaudi: add debugfs entries for the NIC

2020-09-10 Thread Oded Gabbay
On Thu, Sep 10, 2020 at 11:01 PM Jakub Kicinski wrote: > > On Thu, 10 Sep 2020 19:11:23 +0300 Oded Gabbay wrote: > > From: Omer Shpigelman > > > > Add several debugfs entries to help us debug the NIC engines and ports and > > also the communication layer of the DL training application that use

[PATCH net-next 4/6] net: hns: Fix some kernel-doc warnings in hns_enet.c

2020-09-10 Thread Wang Hai
Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/hisilicon/hns/hns_enet.c:1841: warning: Excess function parameter 'netdev' description in 'hns_set_multicast_list' drivers/net/ethernet/hisilicon/hns/hns_enet.c:1841: warning: Excess function parameter 'p' description in

Re: [PATCHv2] perf tools: Call test_attr__open directly

2020-09-10 Thread Arnaldo Carvalho de Melo
Em Thu, Aug 27, 2020 at 09:32:01PM +0200, Jiri Olsa escreveu: > nack.. forgot python header change :-\ v2 attached > > thanks, > jirka Thanks, applied. > > --- > There's no longer need to have test_attr__open inside > sys_perf_event_open call, because both record and stat > call

Re: [PATCH v3 3/5] i2c: aspeed: Mask IRQ status to relevant bits

2020-09-10 Thread Eddie James
On 9/10/20 4:00 AM, Brendan Higgins wrote: On Wed, Sep 9, 2020 at 1:31 PM Eddie James wrote: Mask the IRQ status to only the bits that the driver checks. This prevents excessive driver warnings when operating in slave mode when additional bits are set that the driver doesn't handle.

[PATCH net-next 3/6] net: hns: Fix some kernel-doc warnings in hns_dsaf_xgmac.c

2020-09-10 Thread Wang Hai
Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c:137: warning: Excess function parameter 'drv' description in 'hns_xgmac_enable' drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c:497: warning: Excess function parameter 'cmd' description in

[PATCH v5 1/3] PCI/IOV: Mark VFs as not implementing PCI_COMMAND_MEMORY

2020-09-10 Thread Matthew Rosato
For VFs, the Memory Space Enable bit in the Command Register is hard-wired to 0. Add a new bit to signify devices where the Command Register Memory Space Enable bit does not control the device's response to MMIO accesses. Signed-off-by: Matthew Rosato --- drivers/pci/iov.c | 1 +

[PATCH v5 2/3] s390/pci: Mark all VFs as not implementing PCI_COMMAND_MEMORY

2020-09-10 Thread Matthew Rosato
For s390 we can have VFs that are passed-through without the associated PF. Firmware provides an emulation layer to allow these devices to operate independently, but is missing emulation of the Memory Space Enable bit. For these as well as linked VFs, set no_command_memory which specifies these

Re: [PATCH v2 net] net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc

2020-09-10 Thread Cong Wang
On Tue, Sep 8, 2020 at 4:06 AM Yunsheng Lin wrote: > > Currently there is concurrent reset and enqueue operation for the > same lockless qdisc when there is no lock to synchronize the > q->enqueue() in __dev_xmit_skb() with the qdisc reset operation in > qdisc_deactivate() called by

[PATCH v5 0/3] vfio/pci: Restore MMIO access for s390 detached VFs

2020-09-10 Thread Matthew Rosato
Changes from v4: - Switch from dev_flags to a bitfield - Scrubbed improper use of MSE acronym - Restored the fixes tag to patch 3 (but the other 2 patches are now pre-reqs -- cc stable 5.8?) Since commit abafbc551fdd ("vfio-pci: Invalidate mmaps and block MMIO access on disabled memory") VFIO

Re: [PATCH v2 0/5] HWpoison: further fixes and cleanups

2020-09-10 Thread osalvador
On 2020-09-08 09:56, Oscar Salvador wrote: The important bit of this patchset is patch#1, which is a fix to take off HWPoison pages off a buddy freelist since it can lead us to having HWPoison pages back in the game without no one noticing it. So fix it (we did that already for

Re: [RFC PATCH v9 0/3] Add introspect_access(2) (was O_MAYEXEC)

2020-09-10 Thread Matthew Wilcox
On Thu, Sep 10, 2020 at 09:00:10PM +0100, Al Viro wrote: > On Thu, Sep 10, 2020 at 07:40:33PM +0100, Matthew Wilcox wrote: > > On Thu, Sep 10, 2020 at 08:38:21PM +0200, Mickaël Salaün wrote: > > > There is also the use case of noexec mounts and file permissions. From > > > user space point of

Re: Ways to deprecate /sys/devices/system/memory/memoryX/phys_device ?

2020-09-10 Thread Dave Hansen
On 9/10/20 3:20 AM, David Hildenbrand wrote: > I was just exploring how /sys/devices/system/memory/memoryX/phys_device > is/was used. It's one of these interfaces that most probably never > should have been added but now we are stuck with it. While I'm all for cleanups, what specific problems is

Re: [PATCH 05/15] habanalabs/gaudi: add NIC Ethernet support

2020-09-10 Thread Jakub Kicinski
On Thu, 10 Sep 2020 19:11:16 +0300 Oded Gabbay wrote: > +module_param(nic_rx_poll, int, 0444); > +MODULE_PARM_DESC(nic_rx_poll, > + "Enable NIC Rx polling mode (0 = no, 1 = yes, default no)"); If your chip does not support IRQ coalescing you can configure polling and the timeout via ethtool

Re: [RFC PATCH v9 0/3] Add introspect_access(2) (was O_MAYEXEC)

2020-09-10 Thread Al Viro
On Thu, Sep 10, 2020 at 07:40:33PM +0100, Matthew Wilcox wrote: > On Thu, Sep 10, 2020 at 08:38:21PM +0200, Mickaël Salaün wrote: > > There is also the use case of noexec mounts and file permissions. From > > user space point of view, it doesn't matter which kernel component is in > > charge of

[PATCH] ASoC: core: Optionaly add the component driver name to the component name

2020-09-10 Thread Dafna Hirschfeld
The ASoC platform driver for Mediatek MT8173 registers several components with identical name. This cause an error: "Directory '1122.audio-controller' with parent 'mtk-rt5650' already present!" when adding debugfs directory for those components. To fix this, the function 'fmt_single_name' can

Re: [PATCH 00/15] Adding GAUDI NIC code to habanalabs driver

2020-09-10 Thread Jakub Kicinski
On Thu, 10 Sep 2020 19:11:11 +0300 Oded Gabbay wrote: > create mode 100644 drivers/misc/habanalabs/gaudi/gaudi_nic.c > create mode 100644 drivers/misc/habanalabs/gaudi/gaudi_nic.h > create mode 100644 drivers/misc/habanalabs/gaudi/gaudi_nic_dcbnl.c > create mode 100644

Re: [PATCH 12/15] habanalabs/gaudi: add debugfs entries for the NIC

2020-09-10 Thread Jakub Kicinski
On Thu, 10 Sep 2020 19:11:23 +0300 Oded Gabbay wrote: > From: Omer Shpigelman > > Add several debugfs entries to help us debug the NIC engines and ports and > also the communication layer of the DL training application that use them. > > There are eight new entries. Detailed description is in

[PATCH v5 3/3] vfio/pci: Decouple PCI_COMMAND_MEMORY bit checks from is_virtfn

2020-09-10 Thread Matthew Rosato
While it is true that devices with is_virtfn=1 will have a Memory Space Enable bit that is hard-wired to 0, this is not the only case where we see this behavior -- For example some bare-metal hypervisors lack Memory Space Enable bit emulation for devices not setting is_virtfn (s390). Fix this by

Re: [PATCH net-next + leds v2 6/7] net: phy: marvell: add support for LEDs controlled by Marvell PHYs

2020-09-10 Thread Andrew Lunn
> I propose that at least these HW modes should be available (and > documented) for ethernet PHY controlled LEDs: > mode to determine link on: > - `link` > mode for activity (these should blink): > - `activity` (both rx and tx), `rx`, `tx` > mode for link (on) and activity (blink) >

[net-next v8 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

2020-09-10 Thread Vadym Kochan
Marvell Prestera 98DX326x integrates up to 24 ports of 1GbE with 8 ports of 10GbE uplinks or 2 ports of 40Gbps stacking for a largely wireless SMB deployment. The current implementation supports only boards designed for the Marvell Switchdev solution and requires special firmware. The core

[PATCH] brcmsmac: main: Eliminate empty brcms_c_down_del_timer()

2020-09-10 Thread Jason Yan
This function does nothing so remove it. This addresses the following coccicheck warning: drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c:5103:6-15: Unneeded variable: "callbacks". Return "0" on line 5105 Reported-by: Hulk Robot Signed-off-by: Jason Yan ---

[net-next v8 2/6] net: marvell: prestera: Add PCI interface support

2020-09-10 Thread Vadym Kochan
Add PCI interface driver for Prestera Switch ASICs family devices, which provides: - Firmware loading mechanism - Requests & events handling to/from the firmware - Access to the firmware on the bus level The firmware has to be loaded each time the device is reset. The driver is

Re: [PATCH net v2] net: Clarify the difference between hard_header_len and needed_headroom

2020-09-10 Thread Xie He
OK. I'll make the changes you suggested and resubmit the patch. Thanks! I'll drop the change to netdevice.h and the check for dev_hard_header's return value. If there's still a need for something similar to these, we can do them in a separate patch.

Re: [PATCH v2] arm64: defconfig: Enable REGULATOR_MP8859

2020-09-10 Thread Jagan Teki
Hi Heiko, On Fri, Jul 31, 2020 at 9:33 PM Jagan Teki wrote: > > RK3399 boards like ROC-RK3399-PC is using MP8859 DC/DC converter > for 12V supply. > > roc-rk3399-pc initially used 12V fixed regulator for this supply, > but the below commit has switched to use MP8859. > > commit

Re: [PATCH net 1/2] hv_netvsc: Switch the data path at the right time during hibernation

2020-09-10 Thread David Miller
From: Dexuan Cui Date: Tue, 8 Sep 2020 21:07:32 -0700 > When netvsc_resume() is called, the mlx5 VF NIC has not been resumed yet, > so in the future the host might sliently fail the call netvsc_vf_changed() > -> netvsc_switch_datapath() there, even if the call works now. > > Call

Re: [PATCH net 2/2] hv_netvsc: Cache the current data path to avoid duplicate call and message

2020-09-10 Thread David Miller
From: Dexuan Cui Date: Tue, 8 Sep 2020 21:08:19 -0700 > The previous change "hv_netvsc: Switch the data path at the right time > during hibernation" adds the call of netvsc_vf_changed() upon > NETDEV_CHANGE, so it's necessary to avoid the duplicate call and message > when the VF is brought UP

Re: [PATCH v2] usb: serial: Repair FTDI FT232R bricked eeprom

2020-09-10 Thread Hector Martin
On 11/09/2020 03.51, James Hilliard wrote: I haven't tested this yet but my assumption was that either a kernel driver or libusb can issue usb control messages, but both can not be bound to a device at the same time. I figured this wouldn't have come up when you tested your python script since

Re: [PATCH 4.19 142/206] gfs2: fix use-after-free on transaction ail lists

2020-09-10 Thread Salvatore Bonaccorso
Hi, On Tue, Jun 23, 2020 at 09:57:50PM +0200, Greg Kroah-Hartman wrote: > From: Bob Peterson > > [ Upstream commit 83d060ca8d90fa1e3feac227f995c013100862d3 ] > > Before this patch, transactions could be merged into the system > transaction by function gfs2_merge_trans(), but the transaction

[tip: x86/seves] x86/efi: Add GHCB mappings when SEV-ES is active

2020-09-10 Thread tip-bot2 for Tom Lendacky
The following commit has been merged into the x86/seves branch of tip: Commit-ID: 39336f4ffb2478ad384075cf4ba7ef2e5db2bbd7 Gitweb: https://git.kernel.org/tip/39336f4ffb2478ad384075cf4ba7ef2e5db2bbd7 Author:Tom Lendacky AuthorDate:Mon, 07 Sep 2020 15:16:12 +02:00

[tip: x86/seves] x86/sev-es: Check required CPU features for SEV-ES

2020-09-10 Thread tip-bot2 for Martin Radev
The following commit has been merged into the x86/seves branch of tip: Commit-ID: f5ed777586e08e09c4b6f1e87161a145ee1431cf Gitweb: https://git.kernel.org/tip/f5ed777586e08e09c4b6f1e87161a145ee1431cf Author:Martin Radev AuthorDate:Mon, 07 Sep 2020 15:16:13 +02:00

[net-next v8 4/6] net: marvell: prestera: Add ethtool interface support

2020-09-10 Thread Vadym Kochan
The ethtool API provides support for the configuration of the following features: speed and duplex, auto-negotiation, MDI-x, forward error correction, port media type. The API also provides information about the port status, hardware and software statistic. The following limitation exists: -

[PATCH 02/15] habanalabs/gaudi: add NIC firmware-related definitions

2020-09-10 Thread Oded Gabbay
From: Omer Shpigelman Add new structures and messages that the driver use to interact with the firmware to receive information and events (errors) about GAUDI's NIC. Signed-off-by: Omer Shpigelman Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay ---

[net-next v8 3/6] net: marvell: prestera: Add basic devlink support

2020-09-10 Thread Vadym Kochan
Add very basic support for devlink interface: - driver name - fw version - devlink ports Signed-off-by: Vadym Kochan --- PATCH v8: 1) Put license in one line. 2) Use traditional error handling pattern in prestera_devlink_port_register(): err = F(); if (err)

[PATCH 04/15] habanalabs/gaudi: add support for NIC QMANs

2020-09-10 Thread Oded Gabbay
From: Omer Shpigelman Initialize the QMANs that are responsible to submit doorbells to the NIC engines. Add support for stopping and disabling them, and reset them as part of the hard-reset procedure of GAUDI. This will allow the user to submit work to the NICs. Add support for receiving events

[PATCH 05/15] habanalabs/gaudi: add NIC Ethernet support

2020-09-10 Thread Oded Gabbay
From: Omer Shpigelman Basic NIC driver which handles Ethernet packet of several types like IPv4, IPv6, LLDP, VLAN and ARP. The NIC HW is composed of 5 NIC macros, in each macro 2 NIC engines of 100GbE each. Each engine exposes a single port of 100GbE, so in total we have 10 ports per GAUDI

[PATCH 00/15] Adding GAUDI NIC code to habanalabs driver

2020-09-10 Thread Oded Gabbay
This patch-set adds support for initializing and using the GAUDI NIC ports, functioning as scale-out interconnect when doing distributed Deep Learning training. The training can be performed over tens of thousands of GAUDIs and it is done using the RDMA-over-converged-Ethernet (RoCE) v2 protocol.

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-09-10 Thread Derrick, Jonathan
On Thu, 2020-09-10 at 14:17 -0500, Bjorn Helgaas wrote: > On Thu, Sep 10, 2020 at 06:52:48PM +, Derrick, Jonathan wrote: > > On Thu, 2020-09-10 at 12:38 -0500, Bjorn Helgaas wrote: > > > On Thu, Sep 10, 2020 at 04:33:39PM +, Derrick, Jonathan wrote: > > > > On Wed, 2020-09-09 at 20:55

Re: [PATCH v2 -next] remoteproc: k3-dsp: Fix return value check in k3_dsp_rproc_of_get_memories()

2020-09-10 Thread Mathieu Poirier
On Sat, Sep 05, 2020 at 08:25:03PM +0800, YueHaibing wrote: > In case of error, the function devm_ioremap_wc() returns NULL pointer > not ERR_PTR(). The IS_ERR() test in the return value check should be > replaced with NULL test. > > Fixes: 6edbe024ba17 ("remoteproc: k3-dsp: Add a remoteproc

[net-next v8 6/6] dt-bindings: marvell,prestera: Add description for device-tree bindings

2020-09-10 Thread Vadym Kochan
Add brief description how to configure base mac address binding in device-tree. Describe requirement for the PCI port which is connected to the ASIC, to allow access to the firmware related registers. Signed-off-by: Vadym Kochan --- .../bindings/net/marvell,prestera.txt | 34

Re: [PATCH] checkpatch: Warn on self-assignments

2020-09-10 Thread Kees Cook
On Sat, Sep 05, 2020 at 10:58:29AM -0700, Joe Perches wrote: > The uninitialized_var() macro was removed recently via > commit 63a0895d960a ("compiler: Remove uninitialized_var() macro") > as it's not a particularly useful warning and its use can > "paper over real bugs". > > Add a checkpatch

Re: [PATCH v2 08/10] rtc: New driver for RTC in Netronix embedded controller

2020-09-10 Thread Jonathan Neuschäfer
On Sat, Sep 05, 2020 at 08:56:35PM +0300, Andy Shevchenko wrote: > On Saturday, September 5, 2020, Jonathan Neuschäfer > wrote: [...] > > +#include > > > No user for this. Perhaps you meant mod_devicetable.h? Yes > > +/* Convert an 8-bit value into the correct format for writing into a > >

Re: [PATCH v8 1/5] PCI: Conditionally initialize host bridge native_* members

2020-09-10 Thread Bjorn Helgaas
On Fri, Jul 24, 2020 at 08:58:52PM -0700, sathyanarayanan.kuppusw...@linux.intel.com wrote: > From: Kuppuswamy Sathyanarayanan > > If CONFIG_PCIEPORTBUS is not enabled in kernel then initialing > struct pci_host_bridge PCIe specific native_* members to "1" is > incorrect. So protect the PCIe

[PATCH 09/15] habanalabs/gaudi: add CQ control operations

2020-09-10 Thread Oded Gabbay
From: Omer Shpigelman Add NIC Completion Queue (CQ) opcodes to NIC ioctl. The CQ is used by the user-space process to get notification of a completed work. A CQ entry (CQE) has three types: requester (sender), responder (receiver) and error. Each type has unique fields as well as shared ones.

Re: [PATCH V2 1/2] thermal: ti-soc-thermal: Enable addition power management

2020-09-10 Thread Andreas Kemnade
On Thu, 10 Sep 2020 14:33:13 -0500 Adam Ford wrote: > On Thu, Sep 10, 2020 at 2:14 PM Daniel Lezcano > wrote: > > > On 10/09/2020 20:01, Andreas Kemnade wrote: > > > On Wed, 19 Aug 2020 07:59:23 -0500 > > > Adam Ford wrote: > > > > > >> The bandgap sensor can be idled when the processor

[PATCH 11/15] habanalabs/gaudi: add QP error handling

2020-09-10 Thread Oded Gabbay
From: Omer Shpigelman Add Queue Pair (QP) error notification to the user e.g. security violation, too many retransmissions, invalid QP etc. Whenever a QP caused an error, the firmware will send an event to the driver which will push the error as an error entry to the Completion Queue (if

[PATCH 13/15] habanalabs/gaudi: Add ethtool support using coresight

2020-09-10 Thread Oded Gabbay
From: Omer Shpigelman The driver supports ethtool callbacks and provides statistics using the device's profiling infrastructure (coresight). We support the basic ethtool functionality and counters, as far as our H/W provides support. A summary of the supported callbacks: - get_drvinfo: fill

RE: [PATCH] vfs: add fchmodat2 syscall

2020-09-10 Thread David Laight
From: Rich Felker > Sent: 10 September 2020 15:24 ... > index 9af548fb841b..570a21f4d81e 100644 > --- a/fs/open.c > +++ b/fs/open.c > @@ -610,15 +610,30 @@ SYSCALL_DEFINE2(fchmod, unsigned int, fd, umode_t, mode) > return err; > } > > -static int do_fchmodat(int dfd, const char __user

[net-next v8 5/6] net: marvell: prestera: Add Switchdev driver implementation

2020-09-10 Thread Vadym Kochan
The following features are supported: - VLAN-aware bridge offloading - VLAN-unaware bridge offloading - FDB offloading (learning, ageing) - Switchport configuration Currently there are some limitations like: - Only 1 VLAN-aware bridge instance supported - FDB ageing

[PATCH] objtool: Fix noreturn detection for ignored functions

2020-09-10 Thread Josh Poimboeuf
When a function is annotated with STACK_FRAME_NON_STANDARD, objtool doesn't validate its code paths. It also skips sibling call detection within the function. But sibling call detection is actually needed for the case where the ignored function doesn't have any return instructions. Otherwise

Re: [PATCH] kbuild: preprocess module linker script

2020-09-10 Thread Kees Cook
On Fri, Sep 04, 2020 at 10:31:21PM +0900, Masahiro Yamada wrote: > There was a request to preprocess the module linker script like we do > for the vmlinux one (https://lkml.org/lkml/2020/8/21/512). > > The difference between vmlinux.lds and module.lds is that the latter > is needed for external

[PATCH net-next] igb: Fix some kernel-doc warnings in e1000_82575.c

2020-09-10 Thread Wang Hai
Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/intel/igb/e1000_82575.c:2563: warning: Excess function parameter 'addr' description in '__igb_access_emi_reg' drivers/net/ethernet/intel/igb/e1000_82575.c:2599: warning: Excess function parameter 'adv100m' description in

Re: [RFC PATCH 00/16] 1GB THP support on x86_64

2020-09-10 Thread David Hildenbrand
On 10.09.20 16:41, Zi Yan wrote: > On 10 Sep 2020, at 10:34, David Hildenbrand wrote: > As long as we stay in safe zone boundaries you get a benefit in most scenarios. As soon as we would have a (temporary) workload that would require more unmovable allocations we would fallback to

[PATCH net-next] igb: Fix some kernel-doc warnings in e1000_82575.c

2020-09-10 Thread Wang Hai
Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/intel/igb/e1000_82575.c:2563: warning: Excess function parameter 'addr' description in '__igb_access_emi_reg' drivers/net/ethernet/intel/igb/e1000_82575.c:2599: warning: Excess function parameter 'adv100m' description in

[PATCH 4/4] spi: bcm-qspi: Clean up 7425, 7429, and 7435 settings

2020-09-10 Thread Ray Jui
The Broadcom QSPI driver now falls back to no MSPI_DEV support as the default setting in the generic compatible string, explicit settings for STB chips 7425, 7429, and 7435 can be removed. Signed-off-by: Ray Jui --- drivers/spi/spi-bcm-qspi.c | 12 1 file changed, 12 deletions(-)

RE: [RFC PATCH] x86/mce: Make mce_rdmsrl() do a plain RDMSR only

2020-09-10 Thread Luck, Tony
> Considering how this situation is supposed to almost never happen and > how we're actually interested in the first line of the whole splat I > pasted, how much output comes after it, doesn't really matter. All it > matters is that the machine stops any further progress (as much as we > can do

[PATCH 2/4] spi: bcm-qspi: Add compatible string for BRCMSTB 7445 SoCs

2020-09-10 Thread Ray Jui
Add compatible string for BRCMSTB 7445 SoCs and indicate it has MSPI rev support. Signed-off-by: Ray Jui --- drivers/spi/spi-bcm-qspi.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/spi/spi-bcm-qspi.c b/drivers/spi/spi-bcm-qspi.c index 681d09085175..c5209b42b0d2 100644 ---

[PATCH] kbuild: Try up to eight kallsyms link passes

2020-09-10 Thread Guenter Roeck
Since v5.8, powerpc:allmodconfig often fails to build with the following error message. Inconsistent kallsyms data Try make KALLSYMS_EXTRA_PASS=1 as a workaround Setting KALLSYMS_EXTRA_PASS=1 does not help. As it turns out, the build currently needs up to four link passes to

Re: [PATCH v2 00/28] Add support for Clang LTO

2020-09-10 Thread Sami Tolvanen
On Thu, Sep 10, 2020 at 10:18:05AM +0900, Masahiro Yamada wrote: > On Wed, Sep 9, 2020 at 8:46 AM Sami Tolvanen wrote: > > > > On Sun, Sep 06, 2020 at 09:24:38AM +0900, Masahiro Yamada wrote: > > > On Fri, Sep 4, 2020 at 5:30 AM Sami Tolvanen > > > wrote: > > > > > > > > This patch series adds

Re: (EXT) Re: [PATCH v2 1/1] edac: fsl_ddr_edac: fix expected data message

2020-09-10 Thread Gregor Herburger

WARNING: Kernel stack regs has bad 'bp' value

2020-09-10 Thread Logan Gunthorpe
Hi, A couple of times now, I've hit a very rare kernel warning (see below) while doing IO to an NVMe drive. I do not have a reliable way to reproduce this bug but it seems to have started very roughly around v5.8. I've found someone else (Naresh Kamboju) has reported a very similar issue here[1]

Re: [PATCH -next] drm/amd/display: Fix possible memleak in dp_trigger_hotplug()

2020-09-10 Thread Harry Wentland
On 2020-09-09 11:26 p.m., YueHaibing wrote: If parse_write_buffer_into_params() fails, we should free wr_buf before return. Fixes: 6f77b2ac6280 ("drm/amd/display: Add connector HPD trigger debugfs entry") Signed-off-by: YueHaibing Reviewed-by: Harry Wentland Harry ---

[[PATCH V4]] audit: trigger accompanying records when no rules present

2020-09-10 Thread Richard Guy Briggs
When there are no audit rules registered, mandatory records (config, etc.) are missing their accompanying records (syscall, proctitle, etc.). This is due to audit context dummy set on syscall entry based on absence of rules that signals that no other records are to be printed. Clear the dummy

Re: [PATCH 1/5] misc: eeprom: at24: Initialise AT24 NVMEM ID field

2020-09-10 Thread Bartosz Golaszewski
On Thu, Sep 10, 2020 at 3:43 PM Jon Hunter wrote: > > The AT24 EEPROM driver does not initialise the 'id' field of the > nvmem_config structure and because the entire structure is not > initialised, it ends up with a random value. This causes the NVMEM > driver to append the device 'devid' value

[PATCH v1] kernel.h: Split out min()/max() et al. helpers

2020-09-10 Thread Andy Shevchenko
kernel.h is being used as a dump for all kinds of stuff for a long time. Here is the attempt to start cleaning it up by splitting out min()/max() et al. helpers. At the same time convert users in header and lib folder to use new header. Though for time being include new header back to kernel.h to

Re: [PATCH v2 0/2] MTE support for KVM guest

2020-09-10 Thread Richard Henderson
On 9/10/20 3:24 AM, Steven Price wrote: > It is a shame, however I suspect this is because to use those instructions you > need to know the block size held in GMID_EL1. And at least in theory that > could > vary between CPUs. Which is no different from having to read DCZID_EL0 in order to

Re: [PATCH -next] drm/amd/display: Create trigger_hotplug entry

2020-09-10 Thread Harry Wentland
On 2020-09-09 11:13 p.m., YueHaibing wrote: Add trigger_hotplug debugfs entry. Fixes: 6f77b2ac6280 ("drm/amd/display: Add connector HPD trigger debugfs entry") Signed-off-by: YueHaibing Reviewed-by: Harry Wentland Harry --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 1

Re: [RFC PATCH] PCI/portdrv: No need to call pci_disable_device() during shutdown

2020-09-10 Thread Bjorn Helgaas
On Sat, Sep 05, 2020 at 04:33:26PM +0800, Tiezhu Yang wrote: > After commit 745be2e700cd ("PCIe: portdrv: call pci_disable_device > during remove") and commit cc27b735ad3a ("PCI/portdrv: Turn off PCIe > services during shutdown"), it also calls pci_disable_device() during > shutdown, this seems

[PATCH V4] ASoC: Intel: boards: Use FS as nau8825 sysclk in nau88125_* machine

2020-09-10 Thread Radoslaw Biernacki
Since 256xFS clocks cannot be generated by SKL, the NAU8825 is configured to re-generate its system clock from the BCLK using the FLL. The link is configured to use a 48kHz frame rate, and 24 bits in 25-bit slot. The SSP configuration is extracted from NHLT settings and not dynamically changed.

Re: [PATCH V3] ASoC: Intel: boards: Use FS as nau8825 sysclk in nau88125_* machine

2020-09-10 Thread Radosław Biernacki
Thank you Pierre. All your comments are addressed in V4. skylake_nau8825_resume_post() is in fact unnecessary as my test shows no difference if we do the FLL setup in skylake_nau8825_trigger(). patch is coming... wt., 8 wrz 2020 o 22:59 Pierre-Louis Bossart napisał(a): > > Sorry, I couldn't

[PATCH] mailmap: Add older email addresses for Kees Cook

2020-09-10 Thread Kees Cook
This adds explicit mailmap entries for my older/other email addresses. Reported-by: Joe Perches Signed-off-by: Kees Cook --- .mailmap | 4 1 file changed, 4 insertions(+) diff --git a/.mailmap b/.mailmap index 50096b96c85d..a780211468e4 100644 --- a/.mailmap +++ b/.mailmap @@ -169,6

[PATCH] sh: remove spurious circular inclusion from asm/smp.h

2020-09-10 Thread Rich Felker
Commit 0cd39f4600ed4de8 added inclusion of smp.h to lockdep.h, creating a circular include dependency where arch/sh's asm/smp.h in turn includes spinlock.h which depends on lockdep.h. Since our asm/smp.h does not actually need spinlock.h, just remove it. Fixes: 0cd39f4600ed4de8 ("locking/seqlock,

Re: [PATCH v2 net] net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc

2020-09-10 Thread David Miller
From: Yunsheng Lin Date: Tue, 8 Sep 2020 19:02:34 +0800 > Currently there is concurrent reset and enqueue operation for the > same lockless qdisc when there is no lock to synchronize the > q->enqueue() in __dev_xmit_skb() with the qdisc reset operation in > qdisc_deactivate() called by

[PATCH 1/2] ARM: samsung: fix PM debug build with DEBUG_LL but !MMU

2020-09-10 Thread Krzysztof Kozlowski
Selecting CONFIG_SAMSUNG_PM_DEBUG (depending on CONFIG_DEBUG_LL) but without CONFIG_MMU leads to build errors: arch/arm/plat-samsung/pm-debug.c: In function ‘s3c_pm_uart_base’: arch/arm/plat-samsung/pm-debug.c:57:2: error: implicit declaration of function ‘debug_ll_addr’

Re: [PATCH net-next 0/3] Fix some kernel-doc warnings for e1000/e1000e

2020-09-10 Thread Jakub Kicinski
On Thu, 10 Sep 2020 12:38:00 -0700 Jakub Kicinski wrote: > On Thu, 10 Sep 2020 23:04:26 +0800 Wang Hai wrote: > > Wang Hai (3): > > e1000e: Fix some kernel-doc warnings in ich8lan.c > > e1000e: Fix some kernel-doc warnings in netdev.c > > e1000: Fix a bunch of kerneldoc parameter issues in

Re: [PATCH net-next 0/3] Fix some kernel-doc warnings for e1000/e1000e

2020-09-10 Thread Jakub Kicinski
On Thu, 10 Sep 2020 23:04:26 +0800 Wang Hai wrote: > Wang Hai (3): > e1000e: Fix some kernel-doc warnings in ich8lan.c > e1000e: Fix some kernel-doc warnings in netdev.c > e1000: Fix a bunch of kerneldoc parameter issues in e1000_hw.c You should put some text here but I can confirm this set

Re: [PATCH v7 1/3] virtio: add dma-buf support for exported objects

2020-09-10 Thread Guenter Roeck
On Tue, Aug 18, 2020 at 04:13:41PM +0900, David Stevens wrote: > This change adds a new flavor of dma-bufs that can be used by virtio > drivers to share exported objects. A virtio dma-buf can be queried by > virtio drivers to obtain the UUID which identifies the underlying > exported object. > >

[PATCH 12/15] habanalabs/gaudi: add debugfs entries for the NIC

2020-09-10 Thread Oded Gabbay
From: Omer Shpigelman Add several debugfs entries to help us debug the NIC engines and ports and also the communication layer of the DL training application that use them. There are eight new entries. Detailed description is in the documentation file but here is a summary: - nic_mac_loopback:

[PATCH 10/15] habanalabs/gaudi: add WQ control operations

2020-09-10 Thread Oded Gabbay
From: Omer Shpigelman Add Work Queue (WQ) opcodes to NIC ioctl. A WQ contains entries (WQEs) where each WQE represents a packet that should be sent or received. Each WQ has two types: requester (sender) and responder (receiver). The added opcodes are: - Set WQ: set the WQ configuration in the

Re: [PATCH] sched.h: drop in_ubsan field when UBSAN is in trap mode

2020-09-10 Thread Jann Horn
On Thu, Sep 10, 2020 at 3:48 PM Elena Petrova wrote: > in_ubsan field of task_struct is only used in lib/ubsan.c, which in its > turn is used only `ifneq ($(CONFIG_UBSAN_TRAP),y)`. > > Removing unnecessary field from a task_struct will help preserve the > ABI between vanilla and

Re: [LTP] [PATCH v2] syscall/ptrace08: Simplify the test.

2020-09-10 Thread Cyril Hrubis
Hi! > looks good and the test passes on older fixed kernels. Just one > compatibility issue below. I've fixed that and also the kernel version when the behavior had changed and pushed, thanks for the review and testing. ... > > + if (TST_RET != -1) { > > + tst_res(TFAIL, "ptrace()

[PATCH 08/15] habanalabs/gaudi: add a new IOCTL for NIC control operations

2020-09-10 Thread Oded Gabbay
From: Omer Shpigelman Add Queue Pair (QP) opcodes to the NIC ioctl. A QP represents a connection between two Gaudi ports. Each port currently supports 1024 QPs where QP 0 is reserved for the driver for Ethernet. User-space process needs to create a QP in order to communicate with other Gaudis.

Re: [PATCH -next] PCI: dwc: unexport dw_pcie_link_set_max_speed

2020-09-10 Thread Bjorn Helgaas
On Wed, Sep 09, 2020 at 09:42:34PM +0800, YueHaibing wrote: > This function has been made static, which causes warning: > > WARNING: modpost: "dw_pcie_link_set_max_speed" [vmlinux] is a static > EXPORT_SYMBOL_GPL > > Fixes: 3af45d34d30c ("PCI: dwc: Centralize link gen setting") This commit is

Re: [PATCH net] net: dec: de2104x: Increase receive ring size for Tulip

2020-09-10 Thread Moritz Fischer
On Thu, Sep 10, 2020 at 12:05:09PM -0700, Lucy Yan wrote: > Increase Rx ring size to address issue where hardware is reaching > the receive work limit. > > Before: > > [ 102.223342] de2104x :17:00.0 eth0: rx work limit reached > [ 102.245695] de2104x :17:00.0 eth0: rx work limit

[PATCH 14/15] habanalabs/gaudi: support DCB protocol

2020-09-10 Thread Oded Gabbay
From: Omer Shpigelman Add DCB support to configure the NIC's Priority Flow Control (PFC). The added support is minimal because a full support is not currently required. A summary of the supported callbacks: - ieee_getpfc: get the current PFC configuration. PFC is enabled by

[PATCH v2 3/4] crypto: stm32-hash - Simplify with dev_err_probe()

2020-09-10 Thread Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed. Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. None --- drivers/crypto/stm32/stm32-hash.c | 11 +++ 1 file changed, 3 insertions(+), 8

Re: [RFC][Patch v1 3/3] PCI: Limit pci_alloc_irq_vectors as per housekeeping CPUs

2020-09-10 Thread Nitesh Narayan Lal
On 9/10/20 3:22 PM, Marcelo Tosatti wrote: > On Wed, Sep 09, 2020 at 11:08:18AM -0400, Nitesh Narayan Lal wrote: >> This patch limits the pci_alloc_irq_vectors max vectors that is passed on >> by the caller based on the available housekeeping CPUs by only using the >> minimum of the two. >> >> A

[PATCH v2 1/4] crypto: caam - Fix kerneldoc

2020-09-10 Thread Krzysztof Kozlowski
Fix kerneldoc warnings like: drivers/crypto/caam/caamalg_qi2.c:73: warning: cannot understand function prototype: 'struct caam_ctx' drivers/crypto/caam/caamalg_qi2.c:2962: warning: cannot understand function prototype: 'struct caam_hash_ctx' drivers/crypto/caam/ctrl.c:449: warning:

[PATCH v2 2/4] crypto: caam - Simplify with dev_err_probe()

2020-09-10 Thread Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Iuliana Prodan --- Changes since v1: 1. Add Reviewed-by --- drivers/crypto/caam/caamalg_qi2.c | 3 +-- 1 file

Re: [RFC PATCH v2 1/3] mm/gup: fix gup_fast with dynamic page table folding

2020-09-10 Thread Linus Torvalds
On Thu, Sep 10, 2020 at 12:11 PM Gerald Schaefer wrote: > > That sounds a lot like the pXd_offset_orig() from Martins first approach > in this thread: > https://lore.kernel.org/linuxppc-dev/20190418100218.0a4afd51@mschwideX1/ I have to admit to finding that name horrible, but aside from that,

Re: [MPTCP][PATCH v2 net 0/2] mptcp: fix subflow's local_id/remote_id issues

2020-09-10 Thread David Miller
From: Geliang Tang Date: Tue, 8 Sep 2020 10:49:37 +0800 > v2: > - add Fixes tags; > - simply with 'return addresses_equal'; > - use 'reversed Xmas tree' way. Series applied, thanks.

<    1   2   3   4   5   6   7   8   9   10   >