Re: [PATCH v2] soc: mediatek: Check if power domains can be powered on at boot time

2020-10-04 Thread Nicolas Boichat
On Thu, Oct 1, 2020 at 11:03 PM Matthias Brugger wrote: > > > > On 28/09/2020 05:31, Nicolas Boichat wrote: > > In the error case, where a power domain cannot be powered on > > successfully at boot time (in mtk_register_power_domains), > > pm_genpd_init would still be called with is_off=false, and

[PATCH 3/3] KEYS: trusted: Fix migratable=1 failing

2020-10-04 Thread Jarkko Sakkinen
Consider the following transcript: $ keyctl add trusted kmk "new 32 blobauth=helloworld keyhandle=8000 migratable=1" @u add_key: Invalid argument The documentation has the following description: migratable= 0|1 indicating permission to reseal to new PCR values, default 1

[PATCH 2/3] KEYS: trusted: Reserve TPM for seal and unseal operations

2020-10-04 Thread Jarkko Sakkinen
When TPM 2.0 trusted keys code was moved to the trusted keys subsystem, the operations were unwrapped from tpm_try_get_ops() and tpm_put_ops(), which are used to take temporarily the ownership of the TPM chip. The ownership is only taken inside tpm_send(), but this is not sufficient, as in the key

[PATCH 1/3] KEYS: trusted: Fix incorrect handling of tpm_get_random()

2020-10-04 Thread Jarkko Sakkinen
When tpm_get_random() was introduced, it defined the following API for the return value: 1. A positive value tells how many bytes of random data was generated. 2. A negative value on error. However, in the call sites the API was used incorrectly, i.e. as it would only return negative values and o

Re: [PATCH] rcu,ftrace: Fix ftrace recursion

2020-10-04 Thread Paul E. McKenney
On Tue, Sep 29, 2020 at 01:04:49PM -0400, Steven Rostedt wrote: > On Tue, 29 Sep 2020 09:56:40 -0700 > "Paul E. McKenney" wrote: > > > > Well, I think we should actually apply both, but the comment needs to be > > > updated, as it will no longer be outside recursion. And the comment is > > > wron

Re: [PATCH 04/14] drm/msm: Add priv->mm_lock to protect active/inactive lists

2020-10-04 Thread Rob Clark
On Sun, Oct 4, 2020 at 3:15 PM Daniel Vetter wrote: > > On Sun, Oct 4, 2020 at 9:21 PM Rob Clark wrote: > > > > From: Rob Clark > > > > Rather than relying on the big dev->struct_mutex hammer, introduce a > > more specific lock for protecting the bo lists. > > > > Signed-off-by: Rob Clark > > -

Re: [PATCH v4] staging: qlge: fix build breakage with dumping enabled

2020-10-04 Thread Benjamin Poirier
On 2020-10-04 23:22 +0800, Coiby Xu wrote: > On Sat, Oct 03, 2020 at 02:53:48PM +0900, Benjamin Poirier wrote: > > On 2020-10-03 07:59 +0800, Coiby Xu wrote: > > > This fixes commit 0107635e15ac > > > ("staging: qlge: replace pr_err with netdev_err") which introduced an > > > build breakage of miss

[PATCH net-next v2 1/2] mptcp: Constify mptcp_pm_ops

2020-10-04 Thread Rikard Falkeborn
The only usages of mptcp_pm_ops is to assign its address to the small_ops field of the genl_family struct, which is a const pointer, and applying ARRAY_SIZE() on it. Make it const to allow the compiler to put it in read-only memory. Signed-off-by: Rikard Falkeborn --- net/mptcp/pm_netlink.c | 2

[PATCH net-next v2 2/2] net: openvswitch: Constify static struct genl_small_ops

2020-10-04 Thread Rikard Falkeborn
The only usage of these is to assign their address to the small_ops field in the genl_family struct, which is a const pointer, and applying ARRAY_SIZE() on them. Make them const to allow the compiler to put them in read-only memory. Signed-off-by: Rikard Falkeborn --- net/openvswitch/conntrack.c

[PATCH net-next v2 0/2] net: Constify struct genl_small_ops

2020-10-04 Thread Rikard Falkeborn
Make a couple of static struct genl_small_ops const to allow the compiler to put them in read-only memory. Patches are independent. v2: Rebase on net-next, genl_ops -> genl_small_ops Rikard Falkeborn (2): mptcp: Constify mptcp_pm_ops net: openvswitch: Constify static struct genl_small_ops n

riscv32-linux-ld: drivers/vdpa/mlx5/net/mlx5_vnet.c:1251: undefined reference to `mlx5_fill_page_frag_array_perm'

2020-10-04 Thread kernel test robot
Hi Eli, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 22fbc037cd32e4e6771d2271b565806cfb8c134c commit: 1a86b377aa2147a7c866b03142e848c18e5f3cb8 vdpa/mlx5: Add VDPA driver for supported mlx5 devices date: 9 wee

Re: [PATCH v39 11/24] x86/sgx: Add SGX enclave driver

2020-10-04 Thread Jarkko Sakkinen
On Sun, Oct 04, 2020 at 11:27:50PM +0100, Matthew Wilcox wrote: > On Mon, Oct 05, 2020 at 12:50:49AM +0300, Jarkko Sakkinen wrote: > > What is shoukd take is encl->lock. > > > > The loop was pre-v36 like: > > > > idx_start = PFN_DOWN(start); > > idx_end = PFN_DOWN(end - 1); > > > > f

Re: [PATCH 10/10] fpga: fpga-mgr: altera-pr-ip: Simplify registration

2020-10-04 Thread Moritz Fischer
On Sun, Oct 04, 2020 at 11:47:26AM -0700, Tom Rix wrote: > > On 10/3/20 10:14 PM, Moritz Fischer wrote: > > Simplify registration using new devm_fpga_mgr_register() API. > > Remove the now obsolete altera_pr_unregister() function. > > > > Signed-off-by: Moritz Fischer > > --- > > > > We should ta

Re: [PATCH 03/10] fpga: fpga-mgr: dfl-fme-mgr: Simplify registration

2020-10-04 Thread Moritz Fischer
On Sun, Oct 04, 2020 at 11:22:31AM -0700, Tom Rix wrote: > > On 10/3/20 10:14 PM, Moritz Fischer wrote: > > Simplify registration using new devm_fpga_mgr_register() API. > > > > Signed-off-by: Moritz Fischer > > --- > > drivers/fpga/dfl-fme-mgr.c | 12 +--- > > 1 file changed, 1 insertio

Re: Litmus test for question from Al Viro

2020-10-04 Thread Paul E. McKenney
On Fri, Oct 02, 2020 at 10:35:45PM -0400, Jon Masters wrote: > On 10/1/20 12:15 PM, Alan Stern wrote: > > On Wed, Sep 30, 2020 at 09:51:16PM -0700, Paul E. McKenney wrote: > > > Hello! > > > > > > Al Viro posted the following query: > > > > > >

Re: Litmus test for question from Al Viro

2020-10-04 Thread Paul E. McKenney
On Sat, Oct 03, 2020 at 09:22:12AM -0400, Alan Stern wrote: > To expand on my statement about the LKMM's weakness regarding control > constructs, here is a litmus test to illustrate the issue. You might > want to add this to one of the archives. > > Alan > > C crypto-control-data > (* > * LB

Re: [PATCH v3] RISC-V: Remove any memblock representing unusable memory area

2020-10-04 Thread Palmer Dabbelt
On Thu, 01 Oct 2020 12:05:57 PDT (-0700), Atish Patra wrote: RISC-V limits the physical memory size by -PAGE_OFFSET. Any memory beyond that size from DRAM start is unusable. Just remove any memblock pointing to those memory region without worrying about computing the maximum size. Signed-off-by:

Re: [PATCH] RISC-V: Make sure memblock reserves the memory containing DT

2020-10-04 Thread Palmer Dabbelt
On Thu, 01 Oct 2020 12:04:56 PDT (-0700), Atish Patra wrote: Currently, the memory containing DT is not reserved. Thus, that region of memory can be reallocated or reused for other purposes. This may result in corrupted DT for nommu virt board in Qemu. We may not face any issue in kendryte as DT

Re: [PATCH v3 10/13] ASoC: tegra: Add audio graph based card driver

2020-10-04 Thread Kuninori Morimoto
Hi Sameer > > This is just an idea, > > but can we use hooks here somehow ? > > > > .ops_hook_pre > > .ops_hook_func > > .ops_hook_post > > > > if (priv->ops_hook_pre->func) > > priv->ops_hook_pre->func_pre(...); > > > > if (priv->

Linux 5.9-rc8

2020-10-04 Thread Linus Torvalds
So things have been pretty calm, and rc8 is fairly small. I'm still waiting for a networking pull with some fixes, so it's not like I could have made a final 5.9 release even if I had wanted to, but there was nothing scary going on this past week, and it all feels ready for a final 5.9 next weekend

Re: [EXT] Re: [PATCH v4 03/13] task_isolation: userspace hard isolation from kernel

2020-10-04 Thread Frederic Weisbecker
On Sun, Oct 04, 2020 at 02:44:39PM +, Alex Belits wrote: > On Thu, 2020-10-01 at 15:56 +0200, Frederic Weisbecker wrote: > > External Email > > > > --- > > --- > > On Wed, Jul 22, 2020 at 02:49:49PM +, Alex Belits wrote: > > >

Re: Litmus test for question from Al Viro

2020-10-04 Thread Paul E. McKenney
On Sat, Oct 03, 2020 at 12:11:59PM -0400, j...@joelfernandes.org wrote: > On Sat, Oct 03, 2020 at 12:08:46PM -0400, j...@joelfernandes.org wrote: > [...] > > static void code0(struct v_struct* v,spinlock_t* l,int* out_0_r1) { > > > > struct v_struct *r1; /* to_free */ > > > > r1

Re: [PATCH] tools: memory-model: Document that the LKMM can easily miss control dependencies

2020-10-04 Thread Paul E. McKenney
On Sun, Oct 04, 2020 at 05:07:47PM -0400, j...@joelfernandes.org wrote: > On Sat, Oct 03, 2020 at 09:40:22PM -0400, Alan Stern wrote: > > Add a small section to the litmus-tests.txt documentation file for > > the Linux Kernel Memory Model explaining that the memory model often > > fails to recogniz

Re: [PATCH 2/2] power: bq25980: Add support for the BQ259xx family

2020-10-04 Thread Sebastian Reichel
Hi, On Mon, Aug 31, 2020 at 11:48:49AM -0500, Dan Murphy wrote: > Add support for the BQ25980, BQ25975 and BQ25960 family of flash > chargers. > > Signed-off-by: Dan Murphy > --- Thanks, queued (together with the binding) -- Sebastian > drivers/power/supply/Kconfig |9 + > driv

[PATCH v6 3/3] iommu/tegra-smmu: Add PCI support

2020-10-04 Thread Nicolin Chen
This patch simply adds support for PCI devices. Reviewed-by: Dmitry Osipenko Tested-by: Dmitry Osipenko Signed-off-by: Nicolin Chen --- Changelog v5->v6 * Added Dmitry's Reviewed-by and Tested-by. v4->v5 * Added Dmitry's Reviewed-by v3->v4 * Dropped !iommu_present() check * Added CONFIG_PC

[PATCH v6 2/3] iommu/tegra-smmu: Rework tegra_smmu_probe_device()

2020-10-04 Thread Nicolin Chen
The bus_set_iommu() in tegra_smmu_probe() enumerates all clients to call in tegra_smmu_probe_device() where each client searches its DT node for smmu pointer and swgroup ID, so as to configure an fwspec. But this requires a valid smmu pointer even before mc and smmu drivers are probed. So in tegra_

[PATCH v6 0/3] iommu/tegra-smmu: Add PCI support

2020-10-04 Thread Nicolin Chen
This series is to add PCI support in tegra-smmu driver. Changelog (Detail in each patch) v5->v6 * Dropped a NULL check, per Dmitry's comments * Added Dmitry's Reviewed-by and Tested-by v4->v5 * PATCH-1 Cleaned two variables inits * PATCH-2 Fixed put() in ->of_xlate() and Updated commit message

[PATCH v6 1/3] iommu/tegra-smmu: Use fwspec in tegra_smmu_(de)attach_dev

2020-10-04 Thread Nicolin Chen
In tegra_smmu_(de)attach_dev() functions, we poll DTB for each client's iommus property to get swgroup ID in order to prepare "as" and enable smmu. Actually tegra_smmu_configure() prepared an fwspec for each client, and added to the fwspec all swgroup IDs of client DT node in DTB. So this patch us

Re: [PATCH v39 16/24] x86/sgx: Add a page reclaimer

2020-10-04 Thread Jarkko Sakkinen
On Sat, Oct 03, 2020 at 01:23:49PM -0500, Haitao Huang wrote: > On Sat, 03 Oct 2020 08:32:45 -0500, Jarkko Sakkinen > wrote: > > > On Sat, Oct 03, 2020 at 12:22:47AM -0500, Haitao Huang wrote: > > > When I turn on CONFIG_PROVE_LOCKING, kernel reports following > > > suspicious RCU > > > usages. N

Re: [RFC] Documentation: Add documentation for new performance_profile sysfs class

2020-10-04 Thread Elia Devito
Hi Hans, On 2020-10-03 9:19 a.m., Hans de Goede wrote: > On modern systems CPU/GPU/... performance is often dynamically configurable > in the form of e.g. variable clock-speeds and TPD. The performance is often > automatically adjusted to the load by some automatic-mechanism (which may > very well

Re: [PATCH v39 11/24] x86/sgx: Add SGX enclave driver

2020-10-04 Thread Matthew Wilcox
On Mon, Oct 05, 2020 at 12:50:49AM +0300, Jarkko Sakkinen wrote: > What is shoukd take is encl->lock. > > The loop was pre-v36 like: > > idx_start = PFN_DOWN(start); > idx_end = PFN_DOWN(end - 1); > > for (idx = idx_start; idx <= idx_end; ++idx) { > mutex_lock(&en

Re: [PATCH] test_power: add missing newlines when printing parameters by sysfs

2020-10-04 Thread Sebastian Reichel
Hi, On Sat, Oct 03, 2020 at 02:55:41PM -0700, Joe Perches wrote: > On Sat, 2020-10-03 at 23:50 +0200, Sebastian Reichel wrote: > > Hi, > > > > On Sat, Oct 03, 2020 at 02:43:09PM -0700, Joe Perches wrote: > > > On Sat, 2020-10-03 at 23:23 +0200, Sebastian Reichel wrote: > > > > On Fri, Sep 04, 202

Re: [PATCH 04/14] drm/msm: Add priv->mm_lock to protect active/inactive lists

2020-10-04 Thread Daniel Vetter
On Sun, Oct 4, 2020 at 9:21 PM Rob Clark wrote: > > From: Rob Clark > > Rather than relying on the big dev->struct_mutex hammer, introduce a > more specific lock for protecting the bo lists. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/msm_debugfs.c | 7 +++ > drivers/gpu/

Re: [PATCH net] drivers/net/wan: lapb: Replace the skb->len checks with pskb_may_pull

2020-10-04 Thread David Miller
From: Xie He Date: Sat, 3 Oct 2020 17:46:19 -0700 > The purpose of these skb->len checks in these drivers is to ensure that > there is a header in the skb available to be read and pulled. > > However, we already have the pskb_may_pull function for this purpose. > > The pskb_may_pull function a

[PATCH v4 4/7] tracing: Add support for dynamic strings to synthetic events

2020-10-04 Thread Tom Zanussi
Currently, sythetic events only support static string fields such as: # echo 'test_latency u64 lat; char somename[32]' > /sys/kernel/debug/tracing/synthetic_events Which is fine, but wastes a lot of space in the event. It also prevents the most commonly-defined strings in the existing trace e

[PATCH v4 6/7] selftests/ftrace: Add test case for synthetic event dynamic strings

2020-10-04 Thread Tom Zanussi
Add a selftest that defines and traces a synthetic event that uses a dynamic string event field. Signed-off-by: Tom Zanussi --- .../trigger-synthetic-event-dynstring.tc | 31 +++ 1 file changed, 31 insertions(+) create mode 100644 tools/testing/selftests/ftrace/test.d/trig

[PATCH v4 0/7] tracing: Add dynamic strings for synthetic events

2020-10-04 Thread Tom Zanussi
Hi, This is v4 of the dynamic string support for synthetic events. This version adds several patches addressing previous comments - a new testcase for the dynamic synth event strings along with a patch adding a blurb about the synthetic_events file, which should have been there in any case, Steve

Re: [PATCH v5 3/3] iommu/tegra-smmu: Add PCI support

2020-10-04 Thread Nicolin Chen
On Sat, Oct 03, 2020 at 05:16:20PM +0300, Dmitry Osipenko wrote: > 03.10.2020 09:59, Nicolin Chen пишет: > > This patch simply adds support for PCI devices. > > > > Signed-off-by: Nicolin Chen > > Reviewed-by: Dmitry Osipenko > > Small nit: yours s-b tag always should be the last line of the co

[PATCH v4 3/7] tracing: Save normal string variables

2020-10-04 Thread Tom Zanussi
String variables created as field variables and save variables are already handled properly by having their values copied when set. The same isn't done for normal variables, but needs to be - simply saving a pointer to a string contained in an old event isn't sufficient, since that event's data ma

[PATCH v4 2/7] tracing: Fix parse_synth_field() error handling

2020-10-04 Thread Tom Zanussi
synth_field_size() returns either a positive size or an error (zero or a negative value). However, the existing code assumes the only error value is 0. It doesn't handle negative error codes, as it assigns directly to field->size (a size_t; unsigned), thereby interpreting the error code as a valid

[PATCH v4 7/7] tracing: Change synthetic event string format to limit printed length

2020-10-04 Thread Tom Zanussi
From: Steven Rostedt Change the format for printing synthetic field strings to limit the length of the string printed even if it's not correctly terminated. Description from Steve: I also added this for a bit of paranoid, and probably should be a separate patch, just to make sure if the string

[PATCH v4 5/7] tracing: Add README information for synthetic_events file

2020-10-04 Thread Tom Zanussi
Add an entry with a basic description of events/synthetic_events along with a simple example. Signed-off-by: Tom Zanussi --- kernel/trace/trace.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 3f2533adae72..73fd0e0c0f39

[PATCH v4 1/7] tracing: Change STR_VAR_MAX_LEN

2020-10-04 Thread Tom Zanussi
32 is too small for this value, and anyway it makes more sense to use MAX_FILTER_STR_VAL, as this is also the value used for variable-length __strings. Tested-by: Axel Rasmussen Signed-off-by: Tom Zanussi --- kernel/trace/trace_events_hist.c | 2 ++ kernel/trace/trace_synth.h | 2 +- 2 fi

Re: [PATCH net-next] drivers/net/wan/hdlc_fr: Improvements to the code of pvc_xmit

2020-10-04 Thread David Miller
From: Xie He Date: Sat, 3 Oct 2020 15:41:05 -0700 > 1. Keep the code for the normal (non-error) flow at the lowest > indentation level. And use "goto drop" for all error handling. > > 2. Replace code that pads short Ethernet frames with a "__skb_pad" call. > > 3. Change "dev_kfree_skb" to "kfr

Re: [PATCH v5 2/3] iommu/tegra-smmu: Rework tegra_smmu_probe_device()

2020-10-04 Thread Nicolin Chen
On Sat, Oct 03, 2020 at 05:05:52PM +0300, Dmitry Osipenko wrote: > 03.10.2020 09:59, Nicolin Chen пишет: > > ubuntu@jetson:~$ dmesg | grep iommu > > iommu: Default domain type: Translated > > tegra-i2c 7000c400.i2c: Adding to iommu group 0 > > tegra-i2c 7000c500.i2c: Adding to iomm

Re: [PATCH] net: mvneta: fix double free of txq->buf

2020-10-04 Thread David Miller
From: t...@redhat.com Date: Sat, 3 Oct 2020 11:51:21 -0700 > From: Tom Rix > > clang static analysis reports this problem: > > drivers/net/ethernet/marvell/mvneta.c:3465:2: warning: > Attempt to free released memory > kfree(txq->buf); > ^~~ > > When mvneta_txq_sw

Re: [PATCH net-next 0/2] net: Constify struct genl_ops

2020-10-04 Thread David Miller
From: Rikard Falkeborn Date: Sun, 4 Oct 2020 23:58:08 +0200 > Make a couple of static struct genl_ops const to allow the compiler to put > them in read-only memory. Patches are independent. These do not apply cleanly to net-next, please respin.

Re: [PATCH] crypto: jitterentropy - bind statically into kernel

2020-10-04 Thread Palmer Dabbelt
On Sun, 04 Oct 2020 14:16:10 PDT (-0700), a...@kernel.org wrote: On Sun, 4 Oct 2020 at 20:48, Stephan Müller wrote: The RISC-V architecture is about to implement the callback random_get_entropy with a function that is not exported to modules. Why is that? Wouldn't it be better to export the

Re: [PATCH v5 2/3] iommu/tegra-smmu: Rework tegra_smmu_probe_device()

2020-10-04 Thread Nicolin Chen
On Sat, Oct 03, 2020 at 05:06:42PM +0300, Dmitry Osipenko wrote: > 03.10.2020 09:59, Nicolin Chen пишет: > > static int tegra_smmu_of_xlate(struct device *dev, > >struct of_phandle_args *args) > > { > > + struct platform_device *iommu_pdev = of_find_device_by_node(ar

Re: [PATCH v39 11/24] x86/sgx: Add SGX enclave driver

2020-10-04 Thread Jarkko Sakkinen
On Mon, Oct 05, 2020 at 12:51:00AM +0300, Jarkko Sakkinen wrote: > On Sat, Oct 03, 2020 at 08:54:40PM +0100, Matthew Wilcox wrote: > > On Sat, Oct 03, 2020 at 07:50:46AM +0300, Jarkko Sakkinen wrote: > > > + XA_STATE(xas, &encl->page_array, idx_start); > > > + > > > + /* > > > + * Disallow READ_IM

Re: [PATCH 3/3] power: supply: Constify static w1_family_ops structs

2020-10-04 Thread Sebastian Reichel
Hi, On Sun, Oct 04, 2020 at 09:32:02PM +0200, Rikard Falkeborn wrote: > The only usage of these structs is to assign their address to the fops > field in the w1_family struct, which is a const pointer. Make them const > to allow the compiler to put them in read-only memory. > > This was done with

riscv32-linux-ld: drivers/vdpa/mlx5/core/resources.c:230: undefined reference to `mlx5_cmd_exec'

2020-10-04 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 22fbc037cd32e4e6771d2271b565806cfb8c134c commit: 29064bfdabd5ef49eac6909d3a36a075e3b52255 vdpa/mlx5: Add support library for mlx5 VDPA implementation date: 9 weeks ago config: riscv-randconfig-r036-2020100

[PATCH net-next 0/2] net: Constify struct genl_ops

2020-10-04 Thread Rikard Falkeborn
Make a couple of static struct genl_ops const to allow the compiler to put them in read-only memory. Patches are independent. Rikard Falkeborn (2): mptcp: Constify mptcp_pm_ops net: openvswitch: Constify static struct genl_ops net/mptcp/pm_netlink.c | 2 +- net/openvswitch/conntrack.c |

[PATCH net-next 1/2] mptcp: Constify mptcp_pm_ops

2020-10-04 Thread Rikard Falkeborn
The only usages of mptcp_pm_ops is to assign its address to the ops field of the genl_family struct, which is a const pointer, and applying ARRAY_SIZE() on it. Make it const to allow the compiler to put it in read-only memory. Signed-off-by: Rikard Falkeborn --- net/mptcp/pm_netlink.c | 2 +- 1

[PATCH net-next 2/2] net: openvswitch: Constify static struct genl_ops

2020-10-04 Thread Rikard Falkeborn
The only usage of these is to assign their address to the ops field in the genl_family struct, which is a const pointer, and applying ARRAY_SIZE() on them. Make them const to allow the compiler to put them in read-only memory. Signed-off-by: Rikard Falkeborn --- net/openvswitch/conntrack.c | 2 +

Re: [PATCH 1/3] w1: Constify struct w1_family_ops

2020-10-04 Thread Sebastian Reichel
Hi, On Sun, Oct 04, 2020 at 09:32:00PM +0200, Rikard Falkeborn wrote: > The fops field in the w1_family struct is never modified. Make it const > to indicate that. Constifying the pointer makes it possible for drivers > to declare static w1_family_ops structs const, which in turn will allow > the

Re: [PATCH v39 11/24] x86/sgx: Add SGX enclave driver

2020-10-04 Thread Jarkko Sakkinen
On Sat, Oct 03, 2020 at 08:54:40PM +0100, Matthew Wilcox wrote: > On Sat, Oct 03, 2020 at 07:50:46AM +0300, Jarkko Sakkinen wrote: > > + XA_STATE(xas, &encl->page_array, idx_start); > > + > > + /* > > +* Disallow READ_IMPLIES_EXEC tasks as their VMA permissions might > > +* conflict wit

Re: [PATCH] net: team: fix memory leak in __team_options_register

2020-10-04 Thread David Miller
From: Anant Thazhemadam Date: Mon, 5 Oct 2020 02:25:36 +0530 > The variable "i" isn't initialized back correctly after the first loop > under the label inst_rollback gets executed. > > The value of "i" is assigned to be option_count - 1, and the ensuing > loop (under alloc_rollback) begins by

RE: [PATCH] mtd: spi-nor: Fix 3-or-4 address byte mode logic

2020-10-04 Thread David Laight
From: Bert Vermeulen > Sent: 04 October 2020 22:12 > > On 10/2/20 9:50 AM, David Laight wrote: > > From: Bert Vermeulen > >> The SoCs I'm dealing with have an SPI_ADDR_SEL pin, indicating whether it > >> should be in 3 or 4-byte mode. The vendor's hacked-up U-Boot sets the mode > >> accordingly, a

[PATCH v2] mtd: spi-nor: Fix address width on flash chips > 16MB

2020-10-04 Thread Bert Vermeulen
If a flash chip has more than 16MB capacity but its BFPT reports BFPT_DWORD1_ADDRESS_BYTES_3_OR_4, the spi-nor framework defaults to 3. The check in spi_nor_set_addr_width() doesn't catch it because addr_width did get set. This fixes that check. Signed-off-by: Bert Vermeulen --- drivers/mtd/spi

From Mr. Fabian yaw.

2020-10-04 Thread Mr. Fabian Yaw.
Greetings. I am Mr. Fabian yaw. I got your contact while looking for a reliable and trustworthy partner there in your country to work with, that is why I contacted you.I have a business proposal from our Company which I will like to discuss In more details with you. only if you are Interested and

Re: Kernel 5.9-rc regression.

2020-10-04 Thread Zhou Yanjie
在 2020/10/2 上午5:55, Thomas Bogendoerfer 写道: On Fri, Oct 02, 2020 at 04:15:43AM +0800, Zhou Yanjie wrote: Hi Thomas and list, There is a strange phenomenon in kernel 5.9-rc: when using kernel 5.9-rc with debian 10 and running htop, the memory footprint will be displayed as 3.99T. When the actu

Re: [PATCH v2 0/7] Intel FPGA Security Manager Class Driver

2020-10-04 Thread Tom Rix
On 10/2/20 3:36 PM, Russ Weight wrote: > The Intel FPGA Security Manager class driver provides a common > API for user-space tools to manage updates for secure Intel FPGA > devices. Device drivers that instantiate the Intel Security > Manager class driver will interact with a HW secure update > e

Re: [PATCH] crypto: jitterentropy - bind statically into kernel

2020-10-04 Thread Ard Biesheuvel
On Sun, 4 Oct 2020 at 20:48, Stephan Müller wrote: > > The RISC-V architecture is about to implement the callback > random_get_entropy with a function that is not exported to modules. Why is that? Wouldn't it be better to export the symbol instead? > Thus, the Jitter RNG is changed to be only bo

Re: [PATCH v2 6/7] fpga: sec-mgr: enable cancel of secure update

2020-10-04 Thread Tom Rix
On 10/2/20 3:37 PM, Russ Weight wrote: > Extend the Intel Security Manager class driver to include > an update/cancel sysfs file that can be written to request > that an update be canceled. The write may return EBUSY if > the update has progressed to the point that it cannot be > canceled by soft

[PATCH v2] platform/x86: hp-wmi: add support for thermal policy

2020-10-04 Thread Elia Devito
HP Spectre notebooks (and probably other model as well) support up to 4 thermal policy: - HP Recommended - Performance - Cool - Quiet at least on HP Spectre x360 Convertible 15-df0xxx the firmware sets the thermal policy to default but hardcode the odvp0 variable to 1, this causes thermald to

Re: [PATCH] mtd: spi-nor: Fix 3-or-4 address byte mode logic

2020-10-04 Thread Bert Vermeulen
On 10/2/20 9:50 AM, David Laight wrote: > From: Bert Vermeulen >> The SoCs I'm dealing with have an SPI_ADDR_SEL pin, indicating whether it >> should be in 3 or 4-byte mode. The vendor's hacked-up U-Boot sets the mode >> accordingly, as does their BSP. It seems to me like a misfeature, and I want >

drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c:416 stmmac_probe_config_dt() warn: unsigned 'plat->phy_interface' is never less than zero.

2020-10-04 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 22fbc037cd32e4e6771d2271b565806cfb8c134c commit: b9f0b2f634c0765999bec5547bc7a4ac08fda3ff net: stmmac: platform: fix probe for ACPI devices date: 8 months ago config: x86_64-randconfig-m001-20201005 (attac

Re: [PATCH] tools: memory-model: Document that the LKMM can easily miss control dependencies

2020-10-04 Thread joel
On Sat, Oct 03, 2020 at 09:40:22PM -0400, Alan Stern wrote: > Add a small section to the litmus-tests.txt documentation file for > the Linux Kernel Memory Model explaining that the memory model often > fails to recognize certain control dependencies. > > Suggested-by: Akira Yokosawa > Signed-off-

Re: [PATCH v2 4/7] fpga: sec-mgr: expose sec-mgr update errors

2020-10-04 Thread Tom Rix
On 10/2/20 3:36 PM, Russ Weight wrote: > Extend Intel Security Manager class driver to include > an update/error sysfs node that can be read for error > information when a secure update fails. > > Signed-off-by: Russ Weight > --- > v2: > - Bumped documentation date and version > - Added warn

Re: [PATCH v2 3/7] fpga: sec-mgr: expose sec-mgr update status

2020-10-04 Thread Tom Rix
On 10/2/20 3:36 PM, Russ Weight wrote: > Extend the Intel Security Manager class driver to > include an update/status sysfs node that can be polled > and read to monitor the progress of an ongoing secure > update. Sysfs_notify() is used to signal transitions > between different phases of the upda

[GIT PULL] tpmdd updates for v5.10

2020-10-04 Thread Jarkko Sakkinen
Hi Here's updates for v5.10 containing support for a new TPM device and fixes and Git URL change (infraded -> korg). Some bug fixes for tpm_tis and trusted keys might be coming up in subsequent PR's for rc's. /Jarkko The following changes since commit fcadab740480e0e0e9fa9bd272acd409884d431a:

[PATCH] net: team: fix memory leak in __team_options_register

2020-10-04 Thread Anant Thazhemadam
The variable "i" isn't initialized back correctly after the first loop under the label inst_rollback gets executed. The value of "i" is assigned to be option_count - 1, and the ensuing loop (under alloc_rollback) begins by initializing i--. Thus, the value of i when the loop begins execution wil

Re: [PATCH v2 2/7] fpga: sec-mgr: enable secure updates

2020-10-04 Thread Tom Rix
On 10/2/20 3:36 PM, Russ Weight wrote: > Extend the FPGA Intel Security Manager class driver to > include an update/filename sysfs node that can be used > to initiate a security update. The filename of a secure > update file (BMC image, FPGA image, Root Entry Hash image, > or Code Signing Key ca

Re: [PATCH] MIPS: cevt-r4k: Enable intimer for Loongson64 CPUs with extimer

2020-10-04 Thread Paul Cercueil
Hi, Le mer. 23 sept. 2020 à 19:02, Jiaxun Yang a écrit : Loongson64C and Loongson64G have extimer feature, which is a timer sharing Cause.TI with cevt-r4k (named intimer). To ensure the cevt-r4k's usability, we need to add a callback for clock device to switch intimer. Signed-off-by: Jiaxun

Re: [PATCH v2 1/7] fpga: sec-mgr: intel fpga security manager class driver

2020-10-04 Thread Tom Rix
On 10/2/20 3:36 PM, Russ Weight wrote: > Create the Intel Security Manager class driver. The security > manager provides interfaces to manage secure updates for the > FPGA and BMC images that are stored in FLASH. The driver can > also be used to update root entry hashes and to cancel code > signi

Re: [PATCH] MIPS: cevt-r4k: Enable intimer for Loongson64 CPUs with extimer

2020-10-04 Thread Thomas Bogendoerfer
On Sat, Oct 03, 2020 at 02:25:42PM +0800, Jiaxun Yang wrote: > > > 于 2020年10月2日 GMT+08:00 下午9:27:21, Thomas Bogendoerfer > 写到: > >On Wed, Sep 23, 2020 at 07:02:54PM +0800, Jiaxun Yang wrote: > >> > >> +#ifdef CONFIG_CPU_LOONGSON64 > >> +static int c0_compare_int_enable(struct clock_event_devi

Re: [PATCH] Revert "gpu/drm: ingenic: Add option to mmap GEM buffers cached"

2020-10-04 Thread Paul Cercueil
Hi, Le dim. 4 oct. 2020 à 21:59, Sam Ravnborg a écrit : Hi Paul. On Sun, Oct 04, 2020 at 04:17:58PM +0200, Paul Cercueil wrote: This reverts commit 37054fc81443cc6a8c3a38395f384412b8373d82. In the changelog please refer to commits like this: 37054fc81443 ("gpu/drm: ingenic: Add option to m

[PATCH] drm: bridge: dw-hdmi: Constify dw_hdmi_i2s_ops

2020-10-04 Thread Rikard Falkeborn
The only usage of dw_hdmi_i2s_ops is to assign its address to the ops field in the hdmi_codec_pdata struct, which is a const pointer. Make it const to allow the compiler to put it in read-only memory. Signed-off-by: Rikard Falkeborn --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c | 2 +-

Re: [RFC][PATCHSET] epoll cleanups

2020-10-04 Thread Al Viro
On Sun, Oct 04, 2020 at 11:08:11AM -0700, Linus Torvalds wrote: > On Sat, Oct 3, 2020 at 7:36 PM Al Viro wrote: > > > > Locking and especially control flow in fs/eventpoll.c is > > overcomplicated. As the result, the code has been hard to follow > > and easy to fuck up while modifying. >

Re: [PATCH] Revert "gpu/drm: ingenic: Add option to mmap GEM buffers cached"

2020-10-04 Thread Sam Ravnborg
Hi Paul. On Sun, Oct 04, 2020 at 04:17:58PM +0200, Paul Cercueil wrote: > This reverts commit 37054fc81443cc6a8c3a38395f384412b8373d82. In the changelog please refer to commits like this: 37054fc81443 ("gpu/drm: ingenic: Add option to mmap GEM buffers cached") Use "dim cite 37054fc81443cc6a8c3a3

Re: [PATCH] perf inject: Flush ordered events on FINISHED_ROUND

2020-10-04 Thread Jiri Olsa
On Fri, Oct 02, 2020 at 10:03:17PM +0900, Namhyung Kim wrote: > Currently perf inject just repipes the event without any flush. It > makes an issue that it changes the order of events processed. > > Normally we want to process events in time order, but events are > recorded from several cpus and

Re: [RFC PATCH 1/1] overlayfs: add ioctls that allows to get fhandle for layers dentries

2020-10-04 Thread Randy Dunlap
On 10/4/20 12:24 PM, Alexander Mikhalitsyn wrote: > +#define OVL_IOC_GETLWRFHNDLSNUM _IO('o', 1) > +// DISCUSS: what if MAX_HANDLE_SZ will change? > +#define OVL_IOC_GETLWRFHNDL _IOR('o', 2, struct > ovl_mnt_opt_fh) > +#define OVL_IOC_GETUPPRFHNDL

Re: [PATCH] dt-bindings: vendor-prefixes: favor "gateworks" over "gw"

2020-10-04 Thread Linus Walleij
On Sat, Oct 3, 2020 at 12:33 PM Krzysztof Kozlowski wrote: > There are two vendor prefixes for Gateworks: "gw" and "gateworks". > Favor the longer one (more descriptive) and mark "gw" as deprecated so > it will not be used in new bindings. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Lin

[PATCH 0/3] w1: Constify w1_family_ops

2020-10-04 Thread Rikard Falkeborn
None of the current instances of struct w1_family_ops in the kernel is modified. Constify these to let the compiler put them in read-only memory. The first patch changes the fops field in w1_family struct to a pointer to const and makes a local variable a pointer to const to avoid a compiler warni

[PATCH 2/3] w1: Constify static w1_family_ops structs

2020-10-04 Thread Rikard Falkeborn
The only usage of these structs is to assign their address to the fops field in the w1_family struct, which is a const pointer. Make them const to allow the compiler to put them in read-only memory. This was done with the following Coccinelle semantic patch (http://coccinelle.lip6.fr/): // @r1 d

[PATCH 3/3] power: supply: Constify static w1_family_ops structs

2020-10-04 Thread Rikard Falkeborn
The only usage of these structs is to assign their address to the fops field in the w1_family struct, which is a const pointer. Make them const to allow the compiler to put them in read-only memory. This was done with the following Coccinelle semantic patch (http://coccinelle.lip6.fr/): // @r1 d

[PATCH 1/3] w1: Constify struct w1_family_ops

2020-10-04 Thread Rikard Falkeborn
The fops field in the w1_family struct is never modified. Make it const to indicate that. Constifying the pointer makes it possible for drivers to declare static w1_family_ops structs const, which in turn will allow the compiler to put it in read-only memory. Signed-off-by: Rikard Falkeborn ---

[RFC PATCH 1/1] overlayfs: add ioctls that allows to get fhandle for layers dentries

2020-10-04 Thread Alexander Mikhalitsyn
Add several ioctls to ovl_dir_operations that allows to get file handles for upperdir, workdir, lowerdir dentries. Special {s_dev; fhandle} format used. (Ideally should be {mnt_id; fhandle} but this impossible because overlayfs not keeps mounts refcnt for layers.) Added ioctls list: OVL_IOC_GETLWR

[RFC PATCH 0/1] overlayfs: C/R enhancments (RFC)

2020-10-04 Thread Alexander Mikhalitsyn
Some time ago we discussed about the problem of Checkpoint-Restoring overlayfs mounts [1]. Big thanks to Amir for review and suggestions. Brief from previous discussion. Problem statement: to checkpoint-restore overlayfs mounts we need to save overlayfs mount state and save it into the image. Basi

Re: [PATCH] mm/vmscan: drop unneeded assignment in kswapd()

2020-10-04 Thread Mel Gorman
On Sun, Oct 04, 2020 at 02:58:27PM +0200, Lukas Bulwahn wrote: > The refactoring to kswapd() in commit e716f2eb24de ("mm, vmscan: prevent > kswapd sleeping prematurely due to mismatched classzone_idx") turned an > assignment to reclaim_order into a dead store, as in all further paths, > reclaim_ord

Re: [PATCH v7 3/5] PCI: pciehp: check and wait port status out of DPC before handling DLLSC and PDC

2020-10-04 Thread Lukas Wunner
On Sat, Oct 03, 2020 at 03:55:12AM -0400, Ethan Zhao wrote: > When root port has DPC capability and it is enabled, then triggered by > errors, DPC DLLSC and PDC etc interrupts will be sent to DPC driver, pciehp > drivers almost at the same time. Do the DLLSC and PDC events occur as a result of han

[PATCH 10/14] drm/msm: Drop struct_mutex in free_object() path

2020-10-04 Thread Rob Clark
From: Rob Clark Now that active_list/inactive_list is protected by mm_lock, we no longer need dev->struct_mutex in the free_object() path. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drive

[PATCH 09/14] drm/msm: Drop struct_mutex from the retire path

2020-10-04 Thread Rob Clark
From: Rob Clark Now that we are not relying on dev->struct_mutex to protect the ring->submits lists, drop the struct_mutex lock. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gpu.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gpu.c b

[PATCH 06/14] drm/msm: Protect ring->submits with it's own lock

2020-10-04 Thread Rob Clark
From: Rob Clark One less place to rely on dev->struct_mutex. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_submit.c | 2 ++ drivers/gpu/drm/msm/msm_gpu.c| 37 ++-- drivers/gpu/drm/msm/msm_ringbuffer.c | 1 + drivers/gpu/drm/msm/msm_ringbuffer.h | 6

[PATCH 07/14] drm/msm: Refcount submits

2020-10-04 Thread Rob Clark
From: Rob Clark Before we remove dev->struct_mutex from the retire path, we have to deal with the situation of a submit retiring before the submit ioctl returns. To deal with this, ring->submits will hold a reference to the submit, which is dropped when the submit is retired. And the submit ioc

[PATCH 11/14] drm/msm: remove msm_gem_free_work

2020-10-04 Thread Rob Clark
From: Rob Clark Now that we don't need struct_mutex in the free path, we can get rid of the asynchronous free altogether. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_drv.c | 3 --- drivers/gpu/drm/msm/msm_drv.h | 5 - drivers/gpu/drm/msm/msm_gem.c | 27 --

[PATCH 14/14] drm/msm: Don't implicit-sync if only a single ring

2020-10-04 Thread Rob Clark
From: Rob Clark Any cross-device sync use-cases *must* use explicit sync. And if there is only a single ring (no-preemption), everything is FIFO order and there is no need to implicit-sync. Mesa should probably just always use MSM_SUBMIT_NO_IMPLICIT, as behavior is undefined when fences are not

[PATCH 01/14] drm/msm: Use correct drm_gem_object_put() in fail case

2020-10-04 Thread Rob Clark
From: Rob Clark We only want to use the _unlocked() variant in the unlocked case. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c index 14e14caf90f9

[PATCH 00/14] drm/msm: de-struct_mutex-ification

2020-10-04 Thread Rob Clark
From: Rob Clark This doesn't remove *all* the struct_mutex, but it covers the worst of it, ie. shrinker/madvise/free/retire. The submit path still uses struct_mutex, but it still needs *something* serialize a portion of the submit path, and lock_stat mostly just shows the lock contention there b

<    1   2   3   4   >