Re: [PATCH v3 0/4] ASoC: pcm512x: Patch series to set fmt from `set_fmt()`

2020-11-16 Thread Mark Brown
On Sun, 15 Nov 2020 13:23:02 +0100, Kirill Marinushkin wrote: > Set format from `set_fmt()` func instead of `hw_params()`, plus supportive > commits > > Kirill Marinushkin (4): > ASoC: pcm512x: Fix not setting word length if DAIFMT_CBS_CFS > ASoC: pcm512x: Rearrange operations in

Re: [PATCH v1 net-next] net: dsa: qca: ar9331: add ethtool stats support

2020-11-16 Thread Florian Fainelli
On 11/16/20 3:27 PM, Vladimir Oltean wrote: > On Mon, Nov 16, 2020 at 03:13:47PM -0800, Jakub Kicinski wrote: >> On Tue, 17 Nov 2020 01:00:53 +0200 Vladimir Oltean wrote: >>> On Mon, Nov 16, 2020 at 02:35:44PM -0800, Jakub Kicinski wrote: On Tue, 17 Nov 2020 00:21:46 +0200 Vladimir Oltean

Re: [PATCH net-next 3/3] net: ethernet: ti: am65-cpsw: enable broadcast/multicast rate limit support

2020-11-16 Thread Andrew Lunn
> Same as above, just in packets per second. > > tc qdisc add dev eth0 clsact > tc filter add dev eth0 ingress flower skip_sw \ > dst_mac 01:00:00:00:00:00/01:00:00:00:00:00 \ > action police rate 20kpps I agree with Vladimir here. Since the hardware does PPS limits, the TC API

Re: [PATCH net] cx82310_eth: fix error return code in cx82310_bind()

2020-11-16 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 13 Nov 2020 14:07:07 +0800 you wrote: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: ca139d76b0d9 ("cx82310_eth: re-enable ethernet

Re: [RFC PATCH 2/9] cxl/acpi: add OSC support

2020-11-16 Thread Dan Williams
On Mon, Nov 16, 2020 at 10:00 AM Jonathan Cameron wrote: > > On Tue, 10 Nov 2020 21:43:49 -0800 > Ben Widawsky wrote: > > > From: Vishal Verma > > > > Add support to advertise OS capabilities, and request OS control for CXL > > features using the ACPI _OSC mechanism. Advertise support for all >

Re: [PATCH v1 net-next] net: dsa: qca: ar9331: add ethtool stats support

2020-11-16 Thread Vladimir Oltean
On Mon, Nov 16, 2020 at 03:13:47PM -0800, Jakub Kicinski wrote: > On Tue, 17 Nov 2020 01:00:53 +0200 Vladimir Oltean wrote: > > On Mon, Nov 16, 2020 at 02:35:44PM -0800, Jakub Kicinski wrote: > > > On Tue, 17 Nov 2020 00:21:46 +0200 Vladimir Oltean wrote: > > > > On Mon, Nov 16, 2020 at 01:34:53PM

[PATCH bpf-next v2 1/2] bpf: Add bpf_lsm_set_bprm_opts helper

2020-11-16 Thread KP Singh
From: KP Singh The helper allows modification of certain bits on the linux_binprm struct starting with the secureexec bit which can be updated using the BPF_LSM_F_BPRM_SECUREEXEC flag. secureexec can be set by the LSM for privilege gaining executions to set the AT_SECURE auxv for glibc. When

Re: [PATCH 1/1] RFC: add pidfd_send_signal flag to reclaim mm while killing a process

2020-11-16 Thread Minchan Kim
On Fri, Nov 13, 2020 at 06:16:32PM -0800, Andrew Morton wrote: > On Fri, 13 Nov 2020 17:57:02 -0800 Suren Baghdasaryan > wrote: > > > On Fri, Nov 13, 2020 at 5:18 PM Andrew Morton > > wrote: > > > > > > On Fri, 13 Nov 2020 17:09:37 -0800 Suren Baghdasaryan > > > wrote: > > > > > > > > > >

[PATCH bpf-next v2 2/2] bpf: Add tests for bpf_lsm_set_bprm_opts

2020-11-16 Thread KP Singh
From: KP Singh The test forks a child process, updates the local storage to set/unset the securexec bit. The BPF program in the test attaches to bprm_creds_for_exec which checks the local storage of the current task to set the secureexec bit on the binary parameters (bprm). The child then

Re: iommu/vt-d: Cure VF irqdomain hickup

2020-11-16 Thread Jason Gunthorpe
On Thu, Nov 12, 2020 at 08:15:02PM +0100, Thomas Gleixner wrote: > The recent changes to store the MSI irqdomain pointer in struct device > missed that Intel DMAR does not register virtual function devices. Due to > that a VF device gets the plain PCI-MSI domain assigned and then issues > compat

Re: [PATCH] Revert "mm/vunmap: add cond_resched() in vunmap_pmd_range"

2020-11-16 Thread Andrew Morton
Let's cc Uladzislau on vmalloc things? > How about this? Well, lol, that's a simple approach to avoiding the problem ;) > unmap_kernel_range had been atomic operation and zsmalloc has used > it in atomic context in zs_unmap_object. > However, ("e47110e90584, mm/vunmap: add cond_resched() in

Re: [RFC PATCH 4/9] cxl/mem: Map memory device registers

2020-11-16 Thread Dan Williams
On Fri, Nov 13, 2020 at 5:12 PM Ben Widawsky wrote: > > On 20-11-13 12:17:32, Bjorn Helgaas wrote: > > On Tue, Nov 10, 2020 at 09:43:51PM -0800, Ben Widawsky wrote: > > > All the necessary bits are initialized in order to find and map the > > > register space for CXL Memory Devices. This is

Re: [PATCH net] net: Have netpoll bring-up DSA management interface

2020-11-16 Thread Florian Fainelli
On 11/16/20 3:06 PM, Florian Fainelli wrote: > On 10/20/20 6:12 PM, Jakub Kicinski wrote: >> On Tue, 20 Oct 2020 00:19:16 +0300 Vladimir Oltean wrote: >>> On Mon, Oct 19, 2020 at 02:03:40PM -0700, Florian Fainelli wrote: > Completely crazy and outlandish idea, I know, but what's wrong with

Re: [PATCH] tracepoint: Do not fail unregistering a probe due to memory allocation

2020-11-16 Thread Steven Rostedt
On Mon, 16 Nov 2020 17:51:07 -0500 Steven Rostedt wrote: > [ Kees, I added you because you tend to know about these things. > Is it OK to assign a void func(void) that doesn't do anything and returns > nothing to a function pointer that could be call with parameters? We need > to add stubs

[RESEND PATCH 1/3] drm/mediatek: Separate mtk_mipi_tx to an independent module

2020-11-16 Thread Chun-Kuang Hu
mtk_mipi_tx is a part of mtk_drm module, but phy driver should be an independent module rather than be part of drm module, so separate the phy driver to an independent module. Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/Kconfig | 8 drivers/gpu/drm/mediatek/Makefile

[RESEND PATCH 3/3] MAINTAINERS: add files for Mediatek DRM drivers

2020-11-16 Thread Chun-Kuang Hu
Mediatek MIPI DSI phy driver is moved from drivers/gpu/drm/mediatek to drivers/phy/mediatek, so add the new folder to the Mediatek DRM drivers' information. Signed-off-by: Chun-Kuang Hu --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index

[RESEND PATCH 2/3] phy: mediatek: Move mtk_mipi_dsi_phy driver into drivers/phy/mediatek folder

2020-11-16 Thread Chun-Kuang Hu
mtk_mipi_dsi_phy is currently placed inside mediatek drm driver, but it's more suitable to place a phy driver into phy driver folder, so move mtk_mipi_dsi_phy driver into phy driver folder. Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/Kconfig | 7 ---

Re: [PATCH v1 net-next] net: dsa: qca: ar9331: add ethtool stats support

2020-11-16 Thread Jakub Kicinski
On Tue, 17 Nov 2020 01:00:53 +0200 Vladimir Oltean wrote: > On Mon, Nov 16, 2020 at 02:35:44PM -0800, Jakub Kicinski wrote: > > On Tue, 17 Nov 2020 00:21:46 +0200 Vladimir Oltean wrote: > > > On Mon, Nov 16, 2020 at 01:34:53PM -0800, Jakub Kicinski wrote: > > > > You must expose relevant

[RESEND PATCH 0/3] Move Mediatek MIPI DSI PHY driver from DRM folder to PHY folder

2020-11-16 Thread Chun-Kuang Hu
mtk_mipi_dsi_phy is currently placed inside mediatek drm driver, but it's more suitable to place a phy driver into phy driver folder, so move mtk_mipi_dsi_phy driver into phy driver folder. Chun-Kuang Hu (3): drm/mediatek: Separate mtk_mipi_tx to an independent module phy: mediatek: Move

Re: [GIT PULL] vhost,vdpa: fixes

2020-11-16 Thread pr-tracker-bot
The pull request you sent on Mon, 16 Nov 2020 08:14:20 -0500: > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/a08f4523243c86fe35dec8c81c5ec50f721004ce Thank you! -- Deet-doot-dot, I am a

Re: [GIT PULL] Hyper-V fixes for 5.10-rc5

2020-11-16 Thread pr-tracker-bot
The pull request you sent on Mon, 16 Nov 2020 17:13:53 +: > ssh://g...@gitolite.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git > tags/hyperv-fixes-signed has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/a5698b3835f5990deef30fa5397cae563af3c68a Thank you! --

Re: [PATCH net] net: Have netpoll bring-up DSA management interface

2020-11-16 Thread Florian Fainelli
On 10/20/20 6:12 PM, Jakub Kicinski wrote: > On Tue, 20 Oct 2020 00:19:16 +0300 Vladimir Oltean wrote: >> On Mon, Oct 19, 2020 at 02:03:40PM -0700, Florian Fainelli wrote: Completely crazy and outlandish idea, I know, but what's wrong with doing this in DSA? >>> >>> I really do not

Re: [RFC][PATCH v2 11/21] x86/pti: Extend PTI user mappings

2020-11-16 Thread Andy Lutomirski
On Mon, Nov 16, 2020 at 12:18 PM Alexandre Chartre wrote: > > > On 11/16/20 8:48 PM, Andy Lutomirski wrote: > > On Mon, Nov 16, 2020 at 6:49 AM Alexandre Chartre > > wrote: > >> > >> Extend PTI user mappings so that more kernel entry code can be executed > >> with the user page-table. To do so,

Re: [PATCH v2] x86/dumpstack: Fix misleading instruction pointer error message

2020-11-16 Thread Andy Lutomirski
On Mon, Nov 16, 2020 at 2:01 PM Thomas Gleixner wrote: > arch/x86/kernel/dumpstack.c | 23 +++ > 1 file changed, 19 insertions(+), 4 deletions(-) > > --- a/arch/x86/kernel/dumpstack.c > +++ b/arch/x86/kernel/dumpstack.c > @@ -78,6 +78,9 @@ static int copy_code(struct

Re: [PATCH] checkpatch: Fix unescaped left brace

2020-11-16 Thread Joe Perches
On Sun, 2020-11-15 at 19:43 -0800, Joe Perches wrote: > On Mon, 2020-11-16 at 01:59 +0530, Dwaipayan Ray wrote: > > There is an unescaped left brace in a regex in OPEN_BRACE > > check. This throws a runtime error when checkpatch is run > > with --fix flag and the OPEN_BRACE check is executed. > >

Re: [PATCH bpf-next 1/2] bpf: Add bpf_lsm_set_bprm_opts helper

2020-11-16 Thread Alexei Starovoitov
On Mon, Nov 16, 2020 at 2:48 PM KP Singh wrote: > > [...] > > > > > > > +BPF_CALL_2(bpf_lsm_set_bprm_opts, struct linux_binprm *, bprm, u64, > > > flags) > > > +{ > > > > This should also reject invalid flags. I'd rather change this helper from > > RET_VOID > > to RET_INTEGER and throw -EINVAL

drivers/phy/tegra/phy-tegra194-p2u.c:95:1-3: WARNING: PTR_ERR_OR_ZERO can be used

2020-11-16 Thread kernel test robot
-20201116 (attached as .config) compiler: h8300-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot "coccinelle warnings: (new ones prefixed by >>)" >> drivers/phy/tegra/phy-tegra194-p2u.c:95:1-3: WARNIN

Re: [PATCH v1 net-next] net: dsa: qca: ar9331: add ethtool stats support

2020-11-16 Thread Vladimir Oltean
On Mon, Nov 16, 2020 at 02:35:44PM -0800, Jakub Kicinski wrote: > On Tue, 17 Nov 2020 00:21:46 +0200 Vladimir Oltean wrote: > > On Mon, Nov 16, 2020 at 01:34:53PM -0800, Jakub Kicinski wrote: > > > You must expose relevant statistics via the normal get_stats64 NDO > > > before you start dumping

[PATCH] phy: fix ptr_ret.cocci warnings

2020-11-16 Thread kernel test robot
From: kernel test robot drivers/phy/tegra/phy-tegra194-p2u.c:95:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 133552bf03ed ("phy: Remove CONFIG_ARCH_* check for related subdir in

Re: [PATCH] md: dm-writeback: add __noreturn to BUG-ging function

2020-11-16 Thread Randy Dunlap
On 11/15/20 11:30 PM, Christian Borntraeger wrote: > > > On 13.11.20 23:52, Randy Dunlap wrote: >> Building on arch/s390/ flags this as an error, so add the >> __noreturn attribute modifier to prevent the build error. >> >> cc1: some warnings being treated as errors >>

Re: [PATCH] USB: serial: mos7720: defer state restore to a workqueue

2020-11-16 Thread Davidlohr Bueso
On Mon, 16 Nov 2020, Johan Hovold wrote: On Fri, Nov 13, 2020 at 08:27:25PM -0800, Davidlohr Bueso wrote: @@ -1883,21 +1724,17 @@ static void mos7720_release(struct usb_serial *serial) if (mos_parport->msg_pending)

Re: [PATCH] arm64: Fix off-by-one vdso trampoline return value

2020-11-16 Thread William Mcvicker
Hi All, After digging into this even deeper with Nick, we found that the underlying issue is with ld.lld not carrying over the st_type for the VDSO_compat* symbol assignments in `arch/arm64/kernel/vdso32/vdso.lds.S`. >From my Android Common Kernel 4.19 build: $ llvm-readelf -s

Re: [PATCH bpf-next 1/2] bpf: Add bpf_lsm_set_bprm_opts helper

2020-11-16 Thread KP Singh
On Mon, Nov 16, 2020 at 11:48 PM KP Singh wrote: > > [...] > > > > > > > +BPF_CALL_2(bpf_lsm_set_bprm_opts, struct linux_binprm *, bprm, u64, > > > flags) > > > +{ > > > > This should also reject invalid flags. I'd rather change this helper from > > RET_VOID > > to RET_INTEGER and throw -EINVAL

Re: [PATCH v2 0/2] phy: phy-brcm-sata: Allow configuration SATA AFE TX amplitude

2020-11-16 Thread Florian Fainelli
On 11/15/20 11:42 PM, Vinod Koul wrote: > On 22-10-20, 13:50, Florian Fainelli wrote: >> Hi Vinod, Kishon, >> >> This patch series allows the configuration of the Broadcom SATA PHY TX >> amplitude which may be required in order to meet specific tests. > > Applied, thanks > > Btw please do

[PATCH] tracepoint: Do not fail unregistering a probe due to memory allocation

2020-11-16 Thread Steven Rostedt
[ Kees, I added you because you tend to know about these things. Is it OK to assign a void func(void) that doesn't do anything and returns nothing to a function pointer that could be call with parameters? We need to add stubs for tracepoints when we fail to allocate a new array on

Re: [PATCH bpf-next 1/2] bpf: Add bpf_lsm_set_bprm_opts helper

2020-11-16 Thread KP Singh
[...] > > > > +BPF_CALL_2(bpf_lsm_set_bprm_opts, struct linux_binprm *, bprm, u64, flags) > > +{ > > This should also reject invalid flags. I'd rather change this helper from > RET_VOID > to RET_INTEGER and throw -EINVAL for everything other than > BPF_LSM_F_BPRM_SECUREEXEC > passed in here

[PATCH v12 2/5] bus: mhi: core: Move MHI_MAX_MTU to external header file

2020-11-16 Thread Hemant Kumar
Currently this macro is defined in internal MHI header as a TRE length mask. Moving it to external header allows MHI client drivers to set this upper bound for the transmit buffer size. Signed-off-by: Hemant Kumar Reviewed-by: Jeffrey Hugo Reviewed-by: Manivannan Sadhasivam ---

[PATCH v12 5/5] selftest: mhi: Add support to test MHI LOOPBACK channel

2020-11-16 Thread Hemant Kumar
Loopback test opens the MHI device file node and writes a data buffer to it. MHI UCI kernel space driver copies the data and sends it to MHI uplink (Tx) LOOPBACK channel. MHI device loops back the same data to MHI downlink (Rx) LOOPBACK channel. This data is read by test application and compared

[PATCH v12 3/5] docs: Add documentation for userspace client interface

2020-11-16 Thread Hemant Kumar
MHI userspace client driver is creating device file node for user application to perform file operations. File operations are handled by MHI core driver. Currently Loopback MHI channel is supported by this driver. Signed-off-by: Hemant Kumar --- Documentation/mhi/index.rst | 1 +

[PATCH v12 1/5] bus: mhi: core: Add helper API to return number of free TREs

2020-11-16 Thread Hemant Kumar
Introduce mhi_get_free_desc_count() API to return number of TREs available to queue buffer. MHI clients can use this API to know before hand if ring is full without calling queue API. Signed-off-by: Hemant Kumar Reviewed-by: Jeffrey Hugo Reviewed-by: Manivannan Sadhasivam ---

[PATCH v12 0/5] userspace MHI client interface driver

2020-11-16 Thread Hemant Kumar
This patch series adds support for UCI driver. UCI driver enables userspace clients to communicate to external MHI devices like modem and WLAN. UCI driver probe creates standard character device file nodes for userspace clients to perform open, read, write, poll and release file operations. These

Re: [PATCH bpf v6 1/2] lib/strncpy_from_user.c: Don't overcopy bytes after NUL terminator

2020-11-16 Thread Linus Torvalds
On Mon, Nov 16, 2020 at 2:15 PM Linus Torvalds wrote: > > So I've verified that at least on x86-64, this doesn't really make > code generation any worse, and I'm ok with the patch from that > standpoint. .. looking closer, it will generate extra code on big-endian architectures and on alpha,

[PATCH v12 4/5] bus: mhi: Add userspace client interface driver

2020-11-16 Thread Hemant Kumar
This MHI client driver allows userspace clients to transfer raw data between MHI device and host using standard file operations. Driver instantiates UCI device object which is associated to device file node. UCI device object instantiates UCI channel object when device file node is opened. UCI

Re: [PATCH v5 8/8] rpmsg: Turn name service into a stand alone driver

2020-11-16 Thread Mathieu Poirier
On Mon, Nov 16, 2020 at 04:51:52PM +0100, Arnaud POULIQUEN wrote: > Hi Guennadi, > > On 11/16/20 4:10 PM, Guennadi Liakhovetski wrote: > > Hi Arnaud, > > > > On Mon, Nov 16, 2020 at 03:43:35PM +0100, Arnaud POULIQUEN wrote: > >> Hi Guennadi, Mathieu, > > > > [snip] > > > >> I tried the

Re: [PATCH v4 bpf-next 3/5] kbuild: build kernel module BTFs if BTF is enabled and pahole supports it

2020-11-16 Thread Andrii Nakryiko
On Mon, Nov 16, 2020 at 1:24 PM Jakub Kicinski wrote: > > On Mon, 16 Nov 2020 12:34:17 -0800 Andrii Nakryiko wrote: > > > This change, commit 5f9ae91f7c0d ("kbuild: Build kernel module BTFs if > > > BTF is enabled and pahole > > > supports it") currently in net-next, linux-next, etc. breaks the

Re: [PATCH v1 net-next] net: dsa: qca: ar9331: add ethtool stats support

2020-11-16 Thread Jakub Kicinski
On Tue, 17 Nov 2020 00:21:46 +0200 Vladimir Oltean wrote: > On Mon, Nov 16, 2020 at 01:34:53PM -0800, Jakub Kicinski wrote: > > You must expose relevant statistics via the normal get_stats64 NDO > > before you start dumping free form stuff in ethtool -S. > > Completely agree on the point,

Re: [PATCH] security/smack: remove unused varible 'rc'

2020-11-16 Thread Casey Schaufler
On 11/7/2020 10:45 PM, Alex Shi wrote: > This varible isn't used and can be removed to avoid a gcc warning: > security/smack/smack_lsm.c:3873:6: warning: variable ‘rc’ set but not > used [-Wunused-but-set-variable] > > Signed-off-by: Alex Shi > Cc: Casey Schaufler > Cc: James Morris > Cc:

Re: [PATCH] MIPS: reserve the memblock right after the kernel

2020-11-16 Thread Serge Semin
On Fri, Nov 13, 2020 at 02:09:09PM +0100, Alexander Sverdlin wrote: > Hello Serge, Thomas, > > On 13/11/2020 10:17, Alexander Sverdlin wrote: > >> So IMHO what could be the best conclusion in the framework of this patch: > >> 1) As Thomas said any platform-specific reservation should be done in

[PATCH] x86/sgx: clarify 'laundry_list' locking

2020-11-16 Thread Dave Hansen
From: Dave Hansen Short Version: The SGX section->laundry_list structure is effectively thread-local, but declared next to some shared structures. Its semantics are clear as mud. Fix that. No functional changes. Compile tested only. Long Version: The SGX hardware keeps per-page metadata.

Re: [PATCH] pinctrl: bcm: pinctrl-iproc-gpio: Fix setting GPIO as output

2020-11-16 Thread Ray Jui
On 11/16/2020 1:58 PM, Mark Tomlinson wrote: > When setting a GPIO pin to an output, it is important to set the value > correctly before enabling the output so that a glitch is not seen on the > pin. This glitch may be very short, but can be important if this is a > reset signal. > > Fixes:

Re: [PATCH] KVM: SVM: check CR4 changes against vcpu->arch

2020-11-16 Thread Jim Mattson
On Mon, Nov 16, 2020 at 10:11 AM Paolo Bonzini wrote: > > Similarly to what vmx/vmx.c does, use vcpu->arch.cr4 to check if CR4 > bits PGE, PKE and OSXSAVE have changed. When switching between VMCB01 > and VMCB02, CPUID has to be adjusted every time if CR4.PKE or CR4.OSXSAVE > change; without

Re: [PATCH v1 net-next] net: dsa: qca: ar9331: add ethtool stats support

2020-11-16 Thread Vladimir Oltean
On Mon, Nov 16, 2020 at 01:34:53PM -0800, Jakub Kicinski wrote: > You must expose relevant statistics via the normal get_stats64 NDO > before you start dumping free form stuff in ethtool -S. Completely agree on the point, Jakub, but to be honest we don't give him that possibility within the DSA

[RFC PATCH] ASoC: ak4458: use reset control instead of reset gpio

2020-11-16 Thread Viorel Suman (OSS)
From: Viorel Suman Using GPIO API seems not a way to go for the case when the same reset GPIO is used to control several codecs. For a such case we can use the "gpio-reset" driver and the "shared" reset API to manage the reset GPIO - to deassert the reset when the first codec is powered up and

Re: [PATCH] compiler.h: Fix barrier_data() on clang

2020-11-16 Thread Randy Dunlap
On 11/16/20 11:28 AM, Randy Dunlap wrote: > On 11/16/20 10:30 AM, Andreas Schwab wrote: >> On Nov 16 2020, Randy Dunlap wrote: >> >>> What kernel version are you building? >> >> 5.10-rc4 >> >> Andreas. > > OK, thanks. > > My build machine is slow, but I have a patch that I am testing: > > --- >

Re: [PATCH] Fix warning for static const char * array in audio_manager_module.c

2020-11-16 Thread kernel test robot
Hi Emmanouil, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] [also build test ERROR on v5.10-rc4 next-20201116] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base

Re: [PATCH bpf v6 1/2] lib/strncpy_from_user.c: Don't overcopy bytes after NUL terminator

2020-11-16 Thread Linus Torvalds
On Mon, Nov 16, 2020 at 1:17 PM Daniel Xu wrote: > > Based on on-list discussion and some off-list discussion with Alexei, > I'd like to propose the v4-style patch without the `(*out & ~mask)` > bit. So I've verified that at least on x86-64, this doesn't really make code generation any worse,

Re: rmk/for-next bisection: baseline.login on bcm2836-rpi-2-b

2020-11-16 Thread Guillaume Tucker
On 16/11/2020 12:20, Ard Biesheuvel wrote: > On Mon, 16 Nov 2020 at 12:20, Ard Biesheuvel wrote: >> >> On Sun, 15 Nov 2020 at 15:11, Ard Biesheuvel wrote: >>> >>> On Fri, 13 Nov 2020 at 17:25, Ard Biesheuvel wrote: On Fri, 13 Nov 2020 at 17:15, Ard Biesheuvel wrote: > > On

Re: [PATCH] bpf: don't fail kmalloc while releasing raw_tp

2020-11-16 Thread Steven Rostedt
On Mon, 16 Nov 2020 16:34:41 -0500 (EST) Mathieu Desnoyers wrote: > - On Nov 16, 2020, at 4:02 PM, rostedt rost...@goodmis.org wrote: > > > On Mon, 16 Nov 2020 15:44:37 -0500 > > Steven Rostedt wrote: > > > >> If you use a stub function, it shouldn't affect anything. And the worse > >>

[PATCH] unlz4: Handle 0-size chunks, discard trailing padding/garbage

2020-11-16 Thread siarhei . liakh
From: Siarhei Liakh TL;DR: There are two places in unlz4() function where reads beyond the end of a buffer might happen under certain conditions which had been observed in real life on stock Ubuntu 20.04 x86_64 with several vanilla mainline kernels, including 5.10. As a result of this issue,

Re: [PATCH 3/5] arm64: dts: sdm845: add oneplus 6/t devices

2020-11-16 Thread Pavel Machek
Hi! > Add initial support for the OnePlus 6 (enchilada) and 6T (fajita) based > on the sdm845-mtp DT. Support includes: > > * Display panels and Adreno 630 > * Touch screen support with synaptics rmi4 > * All remoteprocs start correctly > * WLAN / Bluetooth > * Volume / power buttons and OnePlus

[GIT RFC PULL rcu/urgent] Fix lockdep issue in rcu_print_task_stall()

2020-11-16 Thread Paul E. McKenney
Hello! This pull request contains a single commit that fixes a bug that was introduced a couple of merge windows ago, but which rather more recently converged to an agreed-upon fix. The bug is that interrupts can be incorrectly enabled while holding an irq-disabled spinlock. This can of course

[PATCH 2/2] mm/vmalloc: rework the drain logic

2020-11-16 Thread Uladzislau Rezki (Sony)
A current "lazy drain" model suffers from at least two issues. First one is related to the unsorted list of vmap areas, thus in order to identify the [min:max] range of areas to be drained, it requires a full list scan. What is a time consuming if the list is too long. Second one and as a next

Re: [PATCH v2] x86/dumpstack: Fix misleading instruction pointer error message

2020-11-16 Thread Thomas Gleixner
On Tue, Nov 03 2020 at 19:20, Borislav Petkov wrote: > On Tue, Nov 03, 2020 at 07:11:15PM +0100, Oleg Nesterov wrote: >> > I'm thinking copy_code() should not use copy_from_user_nmi() if former >> > can be called in non-atomic context too. While copy_from_user_nmi() is named that way, it can be

[PATCH] pinctrl: bcm: pinctrl-iproc-gpio: Fix setting GPIO as output

2020-11-16 Thread Mark Tomlinson
When setting a GPIO pin to an output, it is important to set the value correctly before enabling the output so that a glitch is not seen on the pin. This glitch may be very short, but can be important if this is a reset signal. Fixes: b64333ce769c ("pinctrl: cygnus: add gpio/pinconf driver")

[PATCH 1/2] mm/vmalloc: use free_vm_area() if an allocation fails

2020-11-16 Thread Uladzislau Rezki (Sony)
There is a dedicated and separate function that finds and removes a continuous kernel virtual area. As a final step it also releases the "area", a descriptor of corresponding vm_struct. Use free_vmap_area() in the __vmalloc_node_range() instead of open coded steps which are exactly the same, to

Re: [PATCH v2] checkpatch: add fix option for MAINTAINERS_STYLE

2020-11-16 Thread Joe Perches
On Mon, 2020-11-16 at 12:49 +0530, Aditya Srivastava wrote: > Checkpatch expects entries in MAINTAINERS file in a specific order and > warns if the changes made do not follow the specified order. > > E.g., running checkpatch on commit 6f736909f0a4 ("MAINTAINERS: Add > patchwork link for PWM

Re: [PATCH v2] net: lantiq: Wait for the GPHY firmware to be ready

2020-11-16 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Sun, 15 Nov 2020 17:57:57 +0100 you wrote: > A user reports (slightly shortened from the original message): > libphy: lantiq,xrx200-mdio: probed > mdio_bus 1e108000.switch-mii: MDIO device at address 17 is missing. >

Re: [PATCH 1/3] x86/quirks: Scan all busses for early PCI quirks

2020-11-16 Thread Guilherme Piccoli
On Mon, Nov 16, 2020 at 6:45 PM Eric W. Biederman wrote: > The way to do that would be to collect the set of pci devices when the > kexec on panic kernel is loaded, not during crash_kexec. If someone > performs a device hotplug they would need to reload the kexec on panic > kernel. > > I am not

[PATCH v2 1/3] soc: qcom: Add tracepoints to mdt loader

2020-11-16 Thread Rishabh Bhatnagar
Add trace events to the mdt loader driver. These events can help us trace the region where we are loading the segments and the time it takes to initialize the image and setup the memory region. Signed-off-by: Rishabh Bhatnagar --- drivers/soc/qcom/mdt_loader.c | 7 +++

Re: [PATCH 1/3] x86/quirks: Scan all busses for early PCI quirks

2020-11-16 Thread Eric W. Biederman
"Guilherme G. Piccoli" writes: > First of all, thanks everybody for the great insights/discussion! This > thread ended-up being a great learning for (at least) me. > > Given the big amount of replies and intermixed comments, I wouldn't be > able to respond inline to all, so I'll try another

[PATCH v2 0/3] Add events to trace remoteproc lifecycle

2020-11-16 Thread Rishabh Bhatnagar
Insert tracepoints in mdt_loader, qcom_scm and remoteproc_core drivers. These tracepoints will be used to analyze the time taken at each step during bootup/shutdown of the remoteproc. Tracepoints in mdt_loader driver provides information about location and size of firmware segments being loaded.

[PATCH v2 2/3] firmware: scm: Add tracepoints to scm driver for pas calls

2020-11-16 Thread Rishabh Bhatnagar
Add trace events to the qcom_scm driver to trace pas calls. These events can help us analyze the time impact for each scm operation and can also serve as standard checkpoints in code. Signed-off-by: Rishabh Bhatnagar --- drivers/firmware/qcom_scm.c | 9 +

Re: [PATCH][v2] x86/microcode/intel: check cpu stepping and processor flag before saving microcode

2020-11-16 Thread Borislav Petkov
On Mon, Nov 16, 2020 at 01:30:19PM -0800, Raj, Ashok wrote: > Stable is still left below. with #v4.10+ > > Do you want to keep this? Also do you want him to resend or you have that > covered? No Ashok, read the section "For all other submissions, choose one of the following procedures" here:

[PATCH v2 3/3] remoteproc: Add ftrace events to trace lifecycle of remoteprocs

2020-11-16 Thread Rishabh Bhatnagar
Add trace events to trace bootup/shutdown/recovery of remote processors. These events are useful in analyzing the time spent in each step in the life cycle and can be used for performace analysis. Also these serve as standard checkpoints in debugging. Signed-off-by: Rishabh Bhatnagar ---

Re: [PATCH v22 01/12] landlock: Add object management

2020-11-16 Thread Mickaël Salaün
On 16/11/2020 22:26, Pavel Machek wrote: > Hi! > >> A Landlock object enables to identify a kernel object (e.g. an inode). >> A Landlock rule is a set of access rights allowed on an object. Rules >> are grouped in rulesets that may be tied to a set of processes (i.e. >> subjects) to enforce a

Re: [PATCH] bpf: don't fail kmalloc while releasing raw_tp

2020-11-16 Thread Mathieu Desnoyers
- On Nov 16, 2020, at 4:02 PM, rostedt rost...@goodmis.org wrote: > On Mon, 16 Nov 2020 15:44:37 -0500 > Steven Rostedt wrote: > >> If you use a stub function, it shouldn't affect anything. And the worse >> that would happen is that you have a slight overhead of calling the stub >> until

Re: [PATCH v1 net-next] net: dsa: qca: ar9331: add ethtool stats support

2020-11-16 Thread Jakub Kicinski
On Sun, 15 Nov 2020 08:35:33 +0100 Oleksij Rempel wrote: > +static const struct ar9331_mib_desc ar9331_mib[] = { > + MIB_DESC(1, 0x00, "RxBroad"), > + MIB_DESC(1, 0x04, "RxPause"), > + MIB_DESC(1, 0x08, "RxMulti"), > + MIB_DESC(1, 0x0c, "RxFcsErr"), > + MIB_DESC(1, 0x10,

Re: [PATCH][v2] x86/microcode/intel: check cpu stepping and processor flag before saving microcode

2020-11-16 Thread Raj, Ashok
Hi Boris On Mon, Nov 16, 2020 at 01:27:35PM +0100, Borislav Petkov wrote: > ( drop stable@ from Cc because this is not how fixes get added to stable@ ) Stable is still left below. with #v4.10+ Do you want to keep this? Also do you want him to resend or you have that covered? > > On Fri, Nov

Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP

2020-11-16 Thread Hugh Dickins
On Mon, 16 Nov 2020, Matthew Wilcox wrote: > On Mon, Nov 16, 2020 at 02:34:34AM -0800, Hugh Dickins wrote: > > On Thu, 12 Nov 2020, Matthew Wilcox (Oracle) wrote: > > > > > This THP prep patchset changes several page cache iteration APIs to only > > > return head pages. > > > > > > - It's only

Re: [PATCH bpf] selftests/bpf: fix error return code in run_getsockopt_test()

2020-11-16 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf.git (refs/heads/master): On Mon, 16 Nov 2020 18:16:33 +0800 you wrote: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: 65b4414a05eb ("selftests/bpf: add sockopt test that

Re: [PATCH] samples/ftrace: mark my_tramp[12]? global

2020-11-16 Thread Sami Tolvanen
On Mon, Nov 16, 2020 at 1:18 PM Steven Rostedt wrote: > > On Mon, 16 Nov 2020 13:10:57 -0800 > Sami Tolvanen wrote: > > > Clang doesn't warn about this as we're building a module, it just > > generates a reference to a non-existing global "my_tramp" symbol, > > because the one defined in inline

Re: [PATCH] perf vendor events: Update Skylake client events to v50

2020-11-16 Thread Andi Kleen
> You mean change event-converter-for-linux-perf to add this as JSON > comments at the start of the generated files? JSON doesn't support comments unfortunately (unless they're somehow part of the data schema) -Andi

RE: [RFC][PATCH v2 12/21] x86/pti: Use PTI stack instead of trampoline stack

2020-11-16 Thread David Laight
From: Alexandre Chartre > Sent: 16 November 2020 18:10 > > On 11/16/20 5:57 PM, Andy Lutomirski wrote: > > On Mon, Nov 16, 2020 at 6:47 AM Alexandre Chartre > > wrote: > >> > >> When entering the kernel from userland, use the per-task PTI stack > >> instead of the per-cpu trampoline stack. Like

Re: [PATCH v22 01/12] landlock: Add object management

2020-11-16 Thread Pavel Machek
Hi! > A Landlock object enables to identify a kernel object (e.g. an inode). > A Landlock rule is a set of access rights allowed on an object. Rules > are grouped in rulesets that may be tied to a set of processes (i.e. > subjects) to enforce a scoped access-control (i.e. a domain). > > Because

Re: [PATCH v4 bpf-next 3/5] kbuild: build kernel module BTFs if BTF is enabled and pahole supports it

2020-11-16 Thread Jakub Kicinski
On Mon, 16 Nov 2020 12:34:17 -0800 Andrii Nakryiko wrote: > > This change, commit 5f9ae91f7c0d ("kbuild: Build kernel module BTFs if BTF > > is enabled and pahole > > supports it") currently in net-next, linux-next, etc. breaks the use-case > > of compiling only a specific > > kernel module

[PATCH net-next v5] net: linux/skbuff.h: combine SKB_EXTENSIONS + KCOV handling

2020-11-16 Thread Randy Dunlap
The previous Kconfig patch led to some other build errors as reported by the 0day bot and my own overnight build testing. These are all in when KCOV is enabled but SKB_EXTENSIONS is not enabled, so fix those by combining those conditions in the header file. Fixes: 6370cc3bbd8a ("net: add kcov

Re: [PATCH] bpf: don't fail kmalloc while releasing raw_tp

2020-11-16 Thread Mathieu Desnoyers
- On Nov 16, 2020, at 3:44 PM, rostedt rost...@goodmis.org wrote: > On Mon, 16 Nov 2020 15:37:27 -0500 (EST) > Mathieu Desnoyers wrote: >> > >> > Mathieu, >> > >> > Can't we do something that would still allow to unregister a probe even if >> > a new probe array fails to allocate? We could

Re: [PATCH v2] dt-bindings: adau1977: convert text binding to yaml format

2020-11-16 Thread Mark Brown
On Tue, Nov 10, 2020 at 10:47:54AM +0200, Alexandru Ardelean wrote: > This change converts the old device-tree binding for ADAU1977 from text > format to the new yaml format. Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to

Re: [PATCH] samples/ftrace: mark my_tramp[12]? global

2020-11-16 Thread Steven Rostedt
On Mon, 16 Nov 2020 13:10:57 -0800 Sami Tolvanen wrote: > Clang doesn't warn about this as we're building a module, it just > generates a reference to a non-existing global "my_tramp" symbol, > because the one defined in inline assembly has a local binding: > > $ readelf --symbols --wide

[PATCH bpf v6 1/2] lib/strncpy_from_user.c: Don't overcopy bytes after NUL terminator

2020-11-16 Thread Daniel Xu
do_strncpy_from_user() may copy some extra bytes after the NUL terminator into the destination buffer. This usually does not matter for normal string operations. However, when BPF programs key BPF maps with strings, this matters a lot. A BPF program may read strings from user memory by calling

[PATCH bpf v6 0/2] Fix bpf_probe_read_user_str() overcopying

2020-11-16 Thread Daniel Xu
6ae08ae3dea2 ("bpf: Add probe_read_{user, kernel} and probe_read_{user, kernel}_str helpers") introduced a subtle bug where bpf_probe_read_user_str() would potentially copy a few extra bytes after the NUL terminator. This issue is particularly nefarious when strings are used as map keys, as

[PATCH bpf v6 2/2] selftest/bpf: Test bpf_probe_read_user_str() strips trailing bytes after NUL

2020-11-16 Thread Daniel Xu
Previously, bpf_probe_read_user_str() could potentially overcopy the trailing bytes after the NUL due to how do_strncpy_from_user() does the copy in long-sized strides. The issue has been fixed in the previous commit. This commit adds a selftest that ensures we don't regress

Re: [PATCH v2] net: phy: mscc: fix excluded_middle.cocci warnings

2020-11-16 Thread Antoine Tenart
Hello Julia, Quoting Julia Lawall (2020-11-16 16:34:44) > From: kernel test robot > > Condition !A || A && B is equivalent to !A || B. > > Generated by: scripts/coccinelle/misc/excluded_middle.cocci > > Fixes: b76f0ea01312 ("coccinelle: misc: add excluded_middle.cocci script") > CC: Denis

Re: [PATCH] mfd: cpcap: Fix interrupt regression with regmap clear_ack

2020-11-16 Thread Mark Brown
On Mon, Nov 16, 2020 at 12:43:57PM -0800, Tim Harvey wrote: > What are your thoughts regarding the issue of regmap_irq_sync_unlock > ack_invert ack'ing by writing ~d->mask_buf[i] which ends up setting > all the other bits not trying to be awk'd? I would say that the device > allowing an

Re: [PATCH] mm: memcg: remove obsolete memcg_has_children()

2020-11-16 Thread Roman Gushchin
On Mon, Nov 16, 2020 at 06:50:43AM +0100, Lukas Bulwahn wrote: > Commit 2ef1bf118c40 ("mm: memcg: deprecate the non-hierarchical mode") > removed the only use of memcg_has_children() in > mem_cgroup_hierarchy_write() as part of the feature deprecation. > > Hence, since then, make CC=clang W=1

[tip: core/entry] ptrace: Migrate to use SYSCALL_TRACE flag

2020-11-16 Thread tip-bot2 for Gabriel Krisman Bertazi
The following commit has been merged into the core/entry branch of tip: Commit-ID: 64c19ba29b66e98af9306b4a7525fb22c895d252 Gitweb: https://git.kernel.org/tip/64c19ba29b66e98af9306b4a7525fb22c895d252 Author:Gabriel Krisman Bertazi AuthorDate:Mon, 16 Nov 2020 12:42:02

[tip: core/entry] audit: Migrate to use SYSCALL_WORK flag

2020-11-16 Thread tip-bot2 for Gabriel Krisman Bertazi
The following commit has been merged into the core/entry branch of tip: Commit-ID: 785dc4eb7fd74e3b7f4eac468457b633117e1aea Gitweb: https://git.kernel.org/tip/785dc4eb7fd74e3b7f4eac468457b633117e1aea Author:Gabriel Krisman Bertazi AuthorDate:Mon, 16 Nov 2020 12:42:04

[tip: core/entry] x86: Expose syscall_work field in thread_info

2020-11-16 Thread tip-bot2 for Gabriel Krisman Bertazi
The following commit has been merged into the core/entry branch of tip: Commit-ID: b4581a52caff79eab1ea6c4e08526ce2782b Gitweb: https://git.kernel.org/tip/b4581a52caff79eab1ea6c4e08526ce2782b Author:Gabriel Krisman Bertazi AuthorDate:Mon, 16 Nov 2020 12:41:57

[tip: core/entry] entry: Drop usage of TIF flags in the generic syscall code

2020-11-16 Thread tip-bot2 for Gabriel Krisman Bertazi
The following commit has been merged into the core/entry branch of tip: Commit-ID: 2991552447707d791d9d81a5dc161f9e9e90b163 Gitweb: https://git.kernel.org/tip/2991552447707d791d9d81a5dc161f9e9e90b163 Author:Gabriel Krisman Bertazi AuthorDate:Mon, 16 Nov 2020 12:42:05

[tip: core/entry] entry: Wire up syscall_work in common entry code

2020-11-16 Thread tip-bot2 for Gabriel Krisman Bertazi
The following commit has been merged into the core/entry branch of tip: Commit-ID: b86678cf0f1d76062aa964c5f0c6c89fe5a6dcfd Gitweb: https://git.kernel.org/tip/b86678cf0f1d76062aa964c5f0c6c89fe5a6dcfd Author:Gabriel Krisman Bertazi AuthorDate:Mon, 16 Nov 2020 12:41:59

<    1   2   3   4   5   6   7   8   9   10   >