[PATCH 08/15] coresight: Remove unnecessary THIS_MODULE of funnel and replicator driver

2020-11-27 Thread Mathieu Poirier
From: Qi Liu As THIS_MODULE has been set in platform_driver_register(), so remove it from static funnel driver and static replicator driver to avoid set it twice. Signed-off-by: Qi Liu Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-funnel.c | 2 +-

[PATCH 14/15] coresight-tpiu: Fix W=1 warning in TPIU driver

2020-11-27 Thread Mathieu Poirier
CC drivers/hwtracing/coresight/coresight-etm4x-core.o CC drivers/hwtracing/coresight/coresight-etm4x-sysfs.o CC drivers/hwtracing/coresight/coresight-stm.o drivers/hwtracing/coresight/coresight-tpiu.c:53: warning: Cannot understand * @base: memory mapped base address

[PATCH 09/15] coresight: tmc-etf: Fix NULL ptr dereference in tmc_enable_etf_sink_perf()

2020-11-27 Thread Mathieu Poirier
From: Sai Prakash Ranjan There was a report of NULL pointer dereference in ETF enable path for perf CS mode with PID monitoring. It is almost 100% reproducible when the process to monitor is something very active such as chrome and with ETF as the sink and not ETR. Currently in a bid to find the

[PATCH 15/15] coresight-stm: Fix W=1 warning in STM driver

2020-11-27 Thread Mathieu Poirier
CC drivers/hwtracing/coresight/coresight-cti-core.o CC drivers/hwtracing/coresight/coresight-cti-platform.o CC drivers/hwtracing/coresight/coresight-cti-sysfs.o drivers/hwtracing/coresight/coresight-stm.c:109: warning: Function parameter or member 'guaranteed' not described

[PATCH 11/15] coresight: tmc-etr: Assign boolean values to a bool variable

2020-11-27 Thread Mathieu Poirier
From: Kaixu Xia Fix the following coccinelle warnings: ./drivers/hwtracing/coresight/coresight-tmc-etr.c:957:2-15: WARNING: Assignment of 0/1 to bool variable Fix them by assigning boolean values. Reported-by: Tosk Robot Signed-off-by: Kaixu Xia Signed-off-by: Mathieu Poirier ---

[PATCH 13/15] coresight: Fix W=1 warnings in core framework

2020-11-27 Thread Mathieu Poirier
CC drivers/hwtracing/coresight/coresight-etm4x-sysfs.o CC drivers/hwtracing/coresight/coresight-stm.o drivers/hwtracing/coresight/coresight-core.c:440: warning: Function parameter or member 'csdev' not described in 'coresight_disable_source'

[PATCH 10/15] coresight: etb10: Fix possible NULL ptr dereference in etb_enable_perf()

2020-11-27 Thread Mathieu Poirier
From: Sai Prakash Ranjan There was a report of NULL pointer dereference in ETF enable path for perf CS mode with PID monitoring. It is almost 100% reproducible when the process to monitor is something very active such as chrome and with ETF as the sink, not ETR. But code path shows that ETB has

[PATCH 05/15] coresight: etm4x: Update TRCIDR3.NUMPROCS handling to match v4.2

2020-11-27 Thread Mathieu Poirier
From: Suzuki K Poulose Since ETMv4.2, TRCIDR3.NUMPROCS has been extended to a 5bit field by encoding the top 2 bits[4:3] in TRCIDR3.[13:12], which were RES0. Fix the driver to compute the field correctly for ETMv4.2+ Cc: Mike Leach Cc: Mathieu Poirier Signed-off-by: Suzuki K Poulose

[PATCH 04/15] coresight: etm4x: Fix accesses to TRCCIDCTLR1

2020-11-27 Thread Mathieu Poirier
From: Suzuki K Poulose The TRCCIDCTLR1 is only implemented if TRCIDR4.NUMCIDC > 4. Don't touch the register if it is not implemented. Cc: sta...@vger.kernel.org Cc: Mathieu Poirier Cc: Mike Leach Signed-off-by: Suzuki K Poulose Signed-off-by: Mathieu Poirier ---

[PATCH 07/15] coresight: etm4x: Handle TRCVIPCSSCTLR accesses

2020-11-27 Thread Mathieu Poirier
From: Suzuki K Poulose TRCVIPCSSCTLR is not present if the TRCIDR4.NUMPC > 0. Thus we should only access the register if it is present, preventing any undesired behavior. Cc: sta...@vger.kernel.org Signed-off-by: Suzuki K Poulose Signed-off-by: Mathieu Poirier ---

[PATCH 02/15] coresight: core: Remove unneeded semicolon

2020-11-27 Thread Mathieu Poirier
From: Zou Wei Fixes coccicheck warning: ./drivers/hwtracing/coresight/coresight-core.c:421:4-5: Unneeded semicolon Reported-by: Hulk Robot Signed-off-by: Zou Wei Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-core.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 01/15] coresight: etm4x: Skip setting LPOVERRIDE bit for qcom,skip-power-up

2020-11-27 Thread Mathieu Poirier
From: Sai Prakash Ranjan There is a bug on the systems supporting to skip power up (qcom,skip-power-up) where setting LPOVERRIDE bit(low-power state override behaviour) will result in CPU hangs/lockups even on the implementations which supports it. So skip setting the LPOVERRIDE bit for such

Re: [PATCH] mm/page_owner: Record timestamp and pid

2020-11-27 Thread Vlastimil Babka
On 11/12/20 8:14 PM, Andrew Morton wrote: On Thu, 12 Nov 2020 20:41:06 +0200 Georgi Djakov wrote: From: Liam Mark Collect the time for each allocation recorded in page owner so that allocation "surges" can be measured. Record the pid for each allocation recorded in page owner so that the

[PATCH 00/15] coresight: Patches for v5.11

2020-11-27 Thread Mathieu Poirier
Hi Greg, Here is the tally for coresight to be included in the v5.11 merge window. There might be a part 2 in the next couple of weeks, depending on how things go. Please consider when you have time. Thanks, Mathieu Kaixu Xia (1): coresight: tmc-etr: Assign boolean values to a bool

Re: [PATCH 13/13] ibmvfc: register Sub-CRQ handles with VIOS during channel setup

2020-11-27 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH 11/13] ibmvfc: set and track hw queue in ibmvfc_event struct

2020-11-27 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH 10/13] ibmvfc: advertise client support for using hardware channels

2020-11-27 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH 12/13] ibmvfc: send commands down HW Sub-CRQ when channelized

2020-11-27 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH v3] ASoC: qcom: Fix playback recover problem in suspend resume

2020-11-27 Thread Srinivasa Rao Mandadapu
Thanks a lot  Srinivas for your valuable review comments and for your time!!! On 11/27/2020 5:39 PM, Srinivas Kandagatla wrote: On 27/11/2020 09:56, Srinivasa Rao Mandadapu wrote: To support playback continuation after hard suspend(bypass powerd)   and resume: Prepare device in  platform

Re: [PATCH 09/13] ibmvfc: implement channel enquiry and setup commands

2020-11-27 Thread Brian King
On 11/25/20 7:48 PM, Tyrel Datwyler wrote: > --- a/drivers/scsi/ibmvscsi/ibmvfc.c > +++ b/drivers/scsi/ibmvscsi/ibmvfc.c > @@ -4462,6 +4464,118 @@ static void ibmvfc_discover_targets(struct > ibmvfc_host *vhost) > ibmvfc_link_down(vhost, IBMVFC_LINK_DEAD); > } > > +static void

Re: [PATCH 07/13] ibmvfc: define Sub-CRQ interrupt handler routine

2020-11-27 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH 06/13] ibmvfc: add handlers to drain and complete Sub-CRQ responses

2020-11-27 Thread Brian King
On 11/25/20 7:48 PM, Tyrel Datwyler wrote: > The logic for iterating over the Sub-CRQ responses is similiar to that > of the primary CRQ. Add the necessary handlers for processing those > responses. > > Signed-off-by: Tyrel Datwyler > --- > drivers/scsi/ibmvscsi/ibmvfc.c | 72

Re: [PATCH 08/13] ibmvfc: map/request irq and register Sub-CRQ interrupt handler

2020-11-27 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH v3 19/23] kvm: arm64: Intercept host's CPU_ON SMCs

2020-11-27 Thread Sudeep Holla
On Thu, Nov 26, 2020 at 03:54:17PM +, David Brazdil wrote: > Add a handler of the CPU_ON PSCI call from host. When invoked, it looks > up the logical CPU ID corresponding to the provided MPIDR and populates > the state struct of the target CPU with the provided x0, pc. It then > calls CPU_ON

Re: [PATCH 05/13] ibmvfc: add Sub-CRQ IRQ enable/disable routine

2020-11-27 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH 04/13] ibmvfc: add alloc/dealloc routines for SCSI Sub-CRQ Channels

2020-11-27 Thread Brian King
On 11/25/20 7:48 PM, Tyrel Datwyler wrote: > Allocate a set of Sub-CRQs in advance. During channel setup the client > and VIOS negotiate the number of queues the VIOS supports and the number > that the client desires to request. Its possible that the final channel > resources allocated is less

Re: [PATCH 03/13] ibmvfc: add Subordinate CRQ definitions

2020-11-27 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [RFC PATCH v0 00/19] x86/insn: Add an insn_decode() API

2020-11-27 Thread Andy Lutomirski
On Tue, Nov 24, 2020 at 9:46 AM Borislav Petkov wrote: > > On Tue, Nov 24, 2020 at 11:19:33AM +0100, Borislav Petkov wrote: > > In any case, at least the case where I give it > > > > 0x48 0xcf 0x48 0x83 > > > > and say that buf size is 4, should return an error because the second > > insn is

Re: [PATCH 02/13] ibmvfc: define hcall wrapper for registering a Sub-CRQ

2020-11-27 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH 01/13] ibmvfc: add vhost fields and defaults for MQ enablement

2020-11-27 Thread Brian King
On 11/25/20 7:48 PM, Tyrel Datwyler wrote: > diff --git a/drivers/scsi/ibmvscsi/ibmvfc.h b/drivers/scsi/ibmvscsi/ibmvfc.h > index 9d58cfd774d3..8225bdbb127e 100644 > --- a/drivers/scsi/ibmvscsi/ibmvfc.h > +++ b/drivers/scsi/ibmvscsi/ibmvfc.h > @@ -41,6 +41,11 @@ > #define IBMVFC_DEFAULT_LOG_LEVEL

Re: [PATCH v3] mm/shmem.c: make shmem_mapping() inline

2020-11-27 Thread Vlastimil Babka
On 11/15/20 5:52 PM, Hui Su wrote: shmem_mapping() isn't worth an out-of-line call from any callsite. So make it inline by - make shmem_aops global - export shmem_aops - inline the shmem_mapping() and replace the direct call 'shmem_aops' with shmem_mapping() in shmem.c. v1->v2: remove the

Re: [PATCH 0/3] clear_warn_once: add timed interval resetting

2020-11-27 Thread Paul Gortmaker
[Re: [PATCH 0/3] clear_warn_once: add timed interval resetting] On 27/11/2020 (Fri 17:13) Petr Mladek wrote: > On Thu 2020-11-26 01:30:26, Paul Gortmaker wrote: > > The existing clear_warn_once functionality is currently a manually > > issued state reset via the file

Re: [PATCH] misc: altera-stapl: remove trailing semicolon in macro definition

2020-11-27 Thread Tom Rix
On 11/27/20 9:03 AM, Greg KH wrote: > On Fri, Nov 27, 2020 at 08:54:21AM -0800, t...@redhat.com wrote: >> From: Tom Rix >> >> The macro use will already have a semicolon. >> >> Signed-off-by: Tom Rix >> --- >> drivers/misc/altera-stapl/altera-jtag.c | 4 ++-- >> 1 file changed, 2

Re: [PATCH 0/8] Rid W=1 warnings in Net

2020-11-27 Thread Jakub Kicinski
On Thu, 26 Nov 2020 13:38:45 + Lee Jones wrote: > Resending the stragglers. > > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. This set doesn't apply to net-next, please rebase.

Re: [PATCH] mtd: parser: cmdline: Support MTD names containing one or more colons

2020-11-27 Thread Sven Eckelmann
On Friday, 27 November 2020 18:16:54 CET ron minnich wrote: > What none of the people involved in the original patch knew was that > there would be other ':' in use. Sorry! > > But you are right, my idea is a complete non-starter, don't know what > I was thinking. I am still not sure because I

Re: [PATCH 2/2] perf-probe: Change function definition check due to broken dwarf

2020-11-27 Thread Arnaldo Carvalho de Melo
Em Fri, Nov 27, 2020 at 02:48:55PM +0900, Masami Hiramatsu escreveu: > Since some gcc generates a broken DWARF which lacks DW_AT_declaration > attribute from the subprogram DIE of function prototype. > (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97060) > > So, in addition to the

[PATCH] arm64: dts: qcom: qrb5165-rb5: Add support for MCP2518FD

2020-11-27 Thread Manivannan Sadhasivam
Add support for onboard MCP2518FD SPI CAN transceiver attached to SPI0 of RB5. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 17 + 1 file changed, 17 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts

Re: [PATCH v2 4/4] selftest/x86/signal: Include test cases for validating sigaltstack

2020-11-27 Thread Borislav Petkov
On Thu, Nov 19, 2020 at 11:02:37AM -0800, Chang S. Bae wrote: > +static void test_sigaltstack(void *altstack, unsigned long size) > +{ > + if (setup_altstack(altstack, size)) > + err(1, "sigaltstack()"); > + > + sigalrm_expected = (size > at_minstack_size) ? true : false; > + >

Re: [PATCH v2 1/2] perf stat: Use proper cpu for shadow stats

2020-11-27 Thread Arnaldo Carvalho de Melo
Em Fri, Nov 27, 2020 at 01:14:03PM +0900, Namhyung Kim escreveu: > Currently perf stat shows some metrics (like IPC) for defined events. > But when no aggregation mode is used (-A option), it shows incorrect > values since it used a value from a different cpu. > > Before: > > $ perf stat -aA

Re: [REGRESSION] omapdrm/N900 display broken

2020-11-27 Thread Tomi Valkeinen
On 27/11/2020 17:37, Ivaylo Dimitrov wrote: > With 5.9.11 and the patch on top, n900 boots fine, albeit display remains > blank, could be related to > brightness, we're still investigating. Ok. A DSS regdump for a working version and the latest one would be good too. There's a omapdss debugfs

Re: [PATCH] x86/cpu/amd: Remove dead code for TSEG region remapping

2020-11-27 Thread Borislav Petkov
On Fri, Nov 27, 2020 at 12:13:24PM -0500, Arvind Sankar wrote: > Commit > 26bfa5f89486 ("x86, amd: Cleanup init_amd") > moved the code that remaps the TSEG region using 4k pages from > init_amd() to bsp_init_amd(). > > However, bsp_init_amd() is executed well before the direct mapping is >

Re: [PATCH] perf record: Synthesize cgroup events only if needed

2020-11-27 Thread Arnaldo Carvalho de Melo
Em Fri, Nov 27, 2020 at 04:45:57PM +0100, Jiri Olsa escreveu: > On Fri, Nov 27, 2020 at 02:43:56PM +0900, Namhyung Kim wrote: > > It didn't check the tool->cgroup_events bit which is set when > > the --all-cgroups option is given. Without it, samples will not have > > cgroup info so no reason to

Re: [PATCH] mm/shmem: use kmem_cache_zalloc in shmem_alloc_inode()

2020-11-27 Thread Vlastimil Babka
On 11/15/20 6:40 PM, Hui Su wrote: in shmem_get_inode(): new_inode(); new_inode_pseudo(); alloc_inode(); ops->alloc_inode(); -> shmem_alloc_inode() kmem_cache_alloc(); memset(info, 0, (char *)inode - (char *)info); So use kmem_cache_zalloc() in shmem_alloc_inode(), and

Re: [PATCH 1/1] perf diff: fix error return value in __cmd_diff()

2020-11-27 Thread Arnaldo Carvalho de Melo
Em Fri, Nov 27, 2020 at 02:22:02PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Nov 27, 2020 at 10:35:37PM +0900, Namhyung Kim escreveu: > > On Tue, Nov 24, 2020 at 7:37 PM Zhen Lei wrote: > > > An appropriate return value should be set on the failed path. > > > Reported-by: Hulk Robot

Re: [PATCH v4 03/14] KVM: arm64: Kill 32-bit vCPUs on systems with mismatched EL0 support

2020-11-27 Thread Quentin Perret
On Friday 27 Nov 2020 at 17:14:11 (+), Marc Zyngier wrote: > On 2020-11-27 11:53, Will Deacon wrote: > > On Fri, Nov 27, 2020 at 10:26:47AM +, Marc Zyngier wrote: > > > On 2020-11-24 15:50, Will Deacon wrote: > > > > If a vCPU is caught running 32-bit code on a system with mismatched > > >

Re: [PATCH 1/1] perf diff: fix error return value in __cmd_diff()

2020-11-27 Thread Arnaldo Carvalho de Melo
Em Fri, Nov 27, 2020 at 10:35:37PM +0900, Namhyung Kim escreveu: > Hello, > > On Tue, Nov 24, 2020 at 7:37 PM Zhen Lei wrote: > > > > An appropriate return value should be set on the failed path. > > > > Reported-by: Hulk Robot > > Signed-off-by: Zhen Lei > > Acked-by: Namhyung Kim Thanks,

[RFC PATCH] bpf: bpf_kallsyms_lookup_proto can be static

2020-11-27 Thread kernel test robot
Reported-by: kernel test robot Signed-off-by: kernel test robot --- bpf_trace.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c index 9d86e20c2b13cd..a3dc24695ea9f6 100644 --- a/kernel/trace/bpf_trace.c +++

Re: [PATCH bpf-next 1/2] bpf: Add a bpf_kallsyms_lookup helper

2020-11-27 Thread kernel test robot
Hi Florent, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Florent-Revest/bpf-Add-a-bpf_kallsyms_lookup-helper/20201127-010044 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf

Re: [PATCH 01/25] soc: bcm: brcmstb: pm: pm-arm: Provide prototype for brcmstb_pm_s3_finish()

2020-11-27 Thread Lee Jones
On Fri, 27 Nov 2020, Florian Fainelli wrote: > > > On 11/26/2020 1:20 AM, Lee Jones wrote: > > On Tue, 03 Nov 2020, Florian Fainelli wrote: > > > >> On Tue, 3 Nov 2020 15:28:14 +, Lee Jones wrote: > >>> brcmstb_pm_s3_finish() cannot be made static because it is referenced > >>> from

Re: [PATCH v2] drivers/virt: vmgenid: add vm generation id driver

2020-11-27 Thread Catangiu, Adrian Costin
On 18/11/2020 12:30, Alexander Graf wrote: > > > On 16.11.20 16:34, Catangiu, Adrian Costin wrote: >> - Future improvements >> >> Ideally we would want the driver to register itself based on devices' >> _CID and not _HID, but unfortunately I couldn't find a way to do that. >> The problem is that

Re: [PATCH] mtd: parser: cmdline: Support MTD names containing one or more colons

2020-11-27 Thread ron minnich
Ah ha, I see how different my world is from yours :-) My world is linuxboot, which means the command line is always under control of linux, as linux is my bootloader. So this kind of thing is very easy for me to change. Let me go back to the initial problem and hope I can make better sense. The

Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver

2020-11-27 Thread Andrew Lunn
This is a very large driver, which is going to make it slow to review. > +static int sparx5_probe_port(struct sparx5 *sparx5, > + struct device_node *portnp, > + struct phy *serdes, > + u32 portno, > +

Re: [PATCH 01/29] iov_iter: Switch to using a table of operations

2020-11-27 Thread David Howells
Jens Axboe wrote: > which looks to be around a 6% drop. That's quite a lot. > which looks to be around 2-3%, but we're also running at a much > slower rate (830K vs ~2.3M). That's still a lot. Thanks for having a look! David

Re: [PATCH v4 03/14] KVM: arm64: Kill 32-bit vCPUs on systems with mismatched EL0 support

2020-11-27 Thread Marc Zyngier
On 2020-11-27 11:53, Will Deacon wrote: On Fri, Nov 27, 2020 at 10:26:47AM +, Marc Zyngier wrote: On 2020-11-24 15:50, Will Deacon wrote: > If a vCPU is caught running 32-bit code on a system with mismatched > support at EL0, then we should kill it. > > Acked-by: Marc Zyngier >

Re: [PATCH -next] mm/page_alloc: Mark some symbols with static keyword

2020-11-27 Thread Vlastimil Babka
On 11/16/20 10:02 AM, Zou Wei wrote: Fix the following sparse warnings: mm/page_alloc.c:3040:6: warning: symbol '__drain_all_pages' was not declared. Should it be static? mm/page_alloc.c:6349:6: warning: symbol '__zone_set_pageset_high_and_batch' was not declared. Should it be static?

[PATCH] x86/cpu/amd: Remove dead code for TSEG region remapping

2020-11-27 Thread Arvind Sankar
Commit 26bfa5f89486 ("x86, amd: Cleanup init_amd") moved the code that remaps the TSEG region using 4k pages from init_amd() to bsp_init_amd(). However, bsp_init_amd() is executed well before the direct mapping is actually created: setup_arch() -> early_cpu_init() ->

Re: [PATCH v15 05/26] x86/cet/shstk: Add Kconfig option for user-mode Shadow Stack

2020-11-27 Thread Borislav Petkov
On Tue, Nov 10, 2020 at 08:21:50AM -0800, Yu-cheng Yu wrote: > +config X86_CET > + def_bool n > + > +config ARCH_HAS_SHADOW_STACK > + def_bool n > + > +config X86_SHADOW_STACK_USER Is X86_SHADOW_STACK_KERNEL coming too? Regardless, you can add it when it comes and you can use only

Re: [PATCH] mtd: parser: cmdline: Support MTD names containing one or more colons

2020-11-27 Thread Sven Eckelmann
On Friday, 27 November 2020 17:32:02 CET ron minnich wrote: > I'm a bit worried about how tricky this starts to get. I'm inclined to > go back to an earlier implementation which used a character that had > not yet been used (iirc I used [] around the PCI ID in a very early > version). What if we

Re: [PATCH 01/25] soc: bcm: brcmstb: pm: pm-arm: Provide prototype for brcmstb_pm_s3_finish()

2020-11-27 Thread Florian Fainelli
On 11/26/2020 1:20 AM, Lee Jones wrote: > On Tue, 03 Nov 2020, Florian Fainelli wrote: > >> On Tue, 3 Nov 2020 15:28:14 +, Lee Jones wrote: >>> brcmstb_pm_s3_finish() cannot be made static because it is referenced >>> from brcmstb_pm_s3(), so let's provide a prototype for it instead. >>>

Re: [PATCH] misc: altera-stapl: remove trailing semicolon in macro definition

2020-11-27 Thread Greg KH
On Fri, Nov 27, 2020 at 08:54:21AM -0800, t...@redhat.com wrote: > From: Tom Rix > > The macro use will already have a semicolon. > > Signed-off-by: Tom Rix > --- > drivers/misc/altera-stapl/altera-jtag.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [RFC PATCH 1/3] dt-bindings: net: sparx5: Add sparx5-switch bindings

2020-11-27 Thread Andrew Lunn
> + reg-names: > +minItems: 153 > +items: > + - const: dev2g5_0 > + - const: dev5g_0 > + - const: pcs5g_br_0 > + - const: dev2g5_1 > + - const: dev5g_1 ... > + - const: ana_ac > + - const: vop > +switch: switch@6 { > + compatible =

Re: [PATCH] mm: Don't fault around userfaultfd-registered regions on reads

2020-11-27 Thread David Hildenbrand
On 26.11.20 23:23, Peter Xu wrote: > Faulting around for reads are in most cases helpful for the performance so > that > continuous memory accesses may avoid another trip of page fault. However it > may not always work as expected. > > For example, userfaultfd registered regions may not be the

[ANNOUNCE] v5.10-rc5-rt11

2020-11-27 Thread Sebastian Andrzej Siewior
Dear RT folks! I'm pleased to announce the v5.10-rc5-rt11 patch set. Changes since v5.10-rc5-rt10: - The workaround for the IMX clock driver failure has been replaced with a another patch which was proposed upstream. - Tweak the rtmutex patches to build a allnoconfig with RT enabled.

[PATCH] net: wan: remove trailing semicolon in macro definition

2020-11-27 Thread trix
From: Tom Rix The macro use will already have a semicolon. Signed-off-by: Tom Rix --- drivers/net/wan/pci200syn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wan/pci200syn.c b/drivers/net/wan/pci200syn.c index d0062224b216..ba5cc0c53833 100644 ---

Re: [PATCH] mm/page_alloc: Do not isolate redundant pageblock

2020-11-27 Thread David Hildenbrand
On 27.11.20 17:54, David Hildenbrand wrote: > On 27.11.20 15:19, Muchun Song wrote: >> Current pageblock isolation logic could isolate each pageblock individually >> since commit d9dddbf55667 ("mm/page_alloc: prevent merging between isolated >> and other pageblocks"). So we not need to concern

[PATCH] net: bna: remove trailing semicolon in macro definition

2020-11-27 Thread trix
From: Tom Rix The macro use will already have a semicolon. Signed-off-by: Tom Rix --- drivers/net/ethernet/brocade/bna/bna_hw_defs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/brocade/bna/bna_hw_defs.h

Re: [PATCH net-next V7] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO

2020-11-27 Thread Dmytro Shytyi
Hello, On Mon, 23 Nov 2020 14:26:27 +0100 Hideaki Yoshifuji wrote > Hi, > > 2020年11月20日(金) 18:28 Dmytro Shytyi : > > > > Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO (randomly > > generated hostID or stable privacy + privacy extensions). > > The main

Re: [PATCH] mm/page_alloc: Do not isolate redundant pageblock

2020-11-27 Thread David Hildenbrand
On 27.11.20 15:19, Muchun Song wrote: > Current pageblock isolation logic could isolate each pageblock individually > since commit d9dddbf55667 ("mm/page_alloc: prevent merging between isolated > and other pageblocks"). So we not need to concern about page allocator > merges buddies from different

[PATCH] misc: altera-stapl: remove trailing semicolon in macro definition

2020-11-27 Thread trix
From: Tom Rix The macro use will already have a semicolon. Signed-off-by: Tom Rix --- drivers/misc/altera-stapl/altera-jtag.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/altera-stapl/altera-jtag.c b/drivers/misc/altera-stapl/altera-jtag.c index

Re: [PATCH v3 16/23] kvm: arm64: Forward safe PSCI SMCs coming from host

2020-11-27 Thread Sudeep Holla
On Thu, Nov 26, 2020 at 03:54:14PM +, David Brazdil wrote: > Forward the following PSCI SMCs issued by host to EL3 as they do not > require the hypervisor's intervention. This assumes that EL3 correctly > implements the PSCI specification. > > Only function IDs implemented in Linux are

Re: [PATCH net-next] net: switch to storing KCOV handle directly in sk_buff

2020-11-27 Thread Willem de Bruijn
On Fri, Nov 27, 2020 at 7:26 AM Marco Elver wrote: > > On Thu, 26 Nov 2020 at 17:35, Willem de Bruijn > wrote: > > On Thu, Nov 26, 2020 at 3:19 AM Marco Elver wrote: > [...] > > > Will send v2. > > > > Does it make more sense to revert the patch that added the extensions > > and the follow-on

Re: [PATCH] media: vb2: always set buffer cache sync hints

2020-11-27 Thread Tomasz Figa
On Sat, Nov 28, 2020 at 1:35 AM Sergey Senozhatsky wrote: > > On (20/11/27 15:56), Hans Verkuil wrote: > > Yes. > > > > BTW, wouldn't it be sufficient to change this code to: > > > > if (!q->allow_cache_hints && q->memory != VB2_MEMORY_DMABUF) { > >

[tip: efi/urgent] efi/efivars: Set generic ops before loading SSDT

2020-11-27 Thread tip-bot2 for Amadeusz Sławiński
The following commit has been merged into the efi/urgent branch of tip: Commit-ID: 50bdcf047503e30126327d0be4f0ad7337106d68 Gitweb: https://git.kernel.org/tip/50bdcf047503e30126327d0be4f0ad7337106d68 Author:Amadeusz Sławiński AuthorDate:Mon, 23 Nov 2020 12:28:17 -05:00

[tip: efi/urgent] efivarfs: revert "fix memory leak in efivarfs_create()"

2020-11-27 Thread tip-bot2 for Ard Biesheuvel
The following commit has been merged into the efi/urgent branch of tip: Commit-ID: ff04f3b6f2e27f8ae28a498416af2a8dd5072b43 Gitweb: https://git.kernel.org/tip/ff04f3b6f2e27f8ae28a498416af2a8dd5072b43 Author:Ard Biesheuvel AuthorDate:Wed, 25 Nov 2020 08:45:55 +01:00

[tip: efi/urgent] efi: EFI_EARLYCON should depend on EFI

2020-11-27 Thread tip-bot2 for Geert Uytterhoeven
The following commit has been merged into the efi/urgent branch of tip: Commit-ID: 36a237526cd81ff4b6829e6ebd60921c6f976e3b Gitweb: https://git.kernel.org/tip/36a237526cd81ff4b6829e6ebd60921c6f976e3b Author:Geert Uytterhoeven AuthorDate:Tue, 24 Nov 2020 20:16:46 +01:00

[PATCH 3/9] watch_queue: Drop references to /dev/watch_queue

2020-11-27 Thread David Howells
From: Gabriel Krisman Bertazi The merged API doesn't use a watch_queue device, but instead relies on pipes, so let the documentation reflect that. Fixes: f7e47677e39a ("watch_queue: Add a key/keyring notification facility") Signed-off-by: Gabriel Krisman Bertazi Signed-off-by: David Howells

[PATCH 9/9] encrypted-keys: Replace HTTP links with HTTPS ones

2020-11-27 Thread David Howells
From: Alexander A. Klimov Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link,

Re: [PATCH] kvm/x86/mmu: use the correct inherited permissions to get shadow page

2020-11-27 Thread Paolo Bonzini
On 26/11/20 01:05, Sean Christopherson wrote: On Fri, Nov 20, 2020, Lai Jiangshan wrote: From: Lai Jiangshan Commit 41074d07c78b ("KVM: MMU: Fix inherited permissions for emulated guest pte updates") said role.access is common access permissions for all ptes in this shadow page, which is the

[PATCH 8/9] crypto: asymmetric_keys: fix some comments in pkcs7_parser.h

2020-11-27 Thread David Howells
From: Randy Dunlap Drop the doubled word "the" in a comment. Change "THis" to "This". Signed-off-by: Randy Dunlap Signed-off-by: David Howells Cc: keyri...@vger.kernel.org --- crypto/asymmetric_keys/pkcs7_parser.h |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH 7/9] KEYS: remove redundant memset

2020-11-27 Thread David Howells
From: Tom Rix Reviewing use of memset in keyctrl_pkey.c keyctl_pkey_params_get prologue code to set params up memset(params, 0, sizeof(*params)); params->encoding = "raw"; keyctl_pkey_query has the same prologue and calls keyctl_pkey_params_get. So remove the prologue.

[PATCH 6/9] security: keys: delete repeated words in comments

2020-11-27 Thread David Howells
From: Randy Dunlap Drop repeated words in comments. {to, will, the} Signed-off-by: Randy Dunlap Signed-off-by: David Howells Reviewed-by: Jarkko Sakkinen Cc: keyri...@vger.kernel.org Cc: James Morris Cc: "Serge E. Hallyn" Cc: linux-security-mod...@vger.kernel.org ---

[PATCH 5/9] KEYS: asymmetric: Fix kerneldoc

2020-11-27 Thread David Howells
From: Krzysztof Kozlowski Fix W=1 compile warnings (invalid kerneldoc): crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter or member 'kid1' not described in 'asymmetric_key_id_same' crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter or

[PATCH 4/9] security/keys: use kvfree_sensitive()

2020-11-27 Thread David Howells
From: Denis Efremov Use kvfree_sensitive() instead of open-coding it. Signed-off-by: Denis Efremov Signed-off-by: David Howells Reviewed-by: Jarkko Sakkinen --- security/keys/big_key.c |9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/security/keys/big_key.c

[PATCH 2/9] keys: Remove outdated __user annotations

2020-11-27 Thread David Howells
From: Jann Horn When the semantics of the ->read() handlers were changed such that "buffer" is a kernel pointer, some __user annotations survived. Since they're wrong now, get rid of them. Fixes: d3ec10aa9581 ("KEYS: Don't write out to userspace while holding key semaphore") Signed-off-by:

[PATCH 1/9] security: keys: Fix fall-through warnings for Clang

2020-11-27 Thread David Howells
From: Gustavo A. R. Silva In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva Signed-off-by:

[PATCH 0/9] keys: Miscellaneous fixes

2020-11-27 Thread David Howells
Hi Jarkko, I've collected together a bunch of minor keyrings fixes, but I'm not sure there's anything that can't wait for the next merge window. The patches can be found on the following branch: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=keys-fixes

[PATCH] [media] si4713: remove trailing semicolon in macro definition

2020-11-27 Thread trix
From: Tom Rix The macro use will already have a semicolon. Signed-off-by: Tom Rix --- drivers/media/radio/si4713/si4713.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/radio/si4713/si4713.c b/drivers/media/radio/si4713/si4713.c index

Re: [PATCH v2 1/1] arm64: defconfig: Enable more Librem 5 hardware

2020-11-27 Thread Geert Uytterhoeven
Hi Guido, Thanks for your patch! On Fri, Nov 27, 2020 at 5:42 PM Guido Günther wrote: > This enables > > - CONFIG_BATTERY_MAX17042: battery chip > - CONFIG_CHARGER_BQ25980: charge controller > - CONFIG_DRM_PANEL_MANTIX_MLAF057WE5: LCD panel > - CONFIG_IMX_DCSS: 2nd dislay controller display >

[PATCHv2] media: vb2: set buffer cache sync hints during initialisation

2020-11-27 Thread Sergey Senozhatsky
We need to set ->need_cache_sync_on_prepare and ->need_cache_sync_on_finish when we initialize vb2 buffer. Currently these flags are set/adjusted only in V4L2's vb2_queue_or_prepare_buf(), which means that for the code paths that don't use V4L2 vb2 will always tell videobuf2 core to skip

[tip: x86/urgent] x86/mce: Do not overwrite no_way_out if mce_end() fails

2020-11-27 Thread tip-bot2 for Gabriele Paoloni
The following commit has been merged into the x86/urgent branch of tip: Commit-ID: 25bc65d8ddfc17cc1d7a45bd48e9bdc0e729ced3 Gitweb: https://git.kernel.org/tip/25bc65d8ddfc17cc1d7a45bd48e9bdc0e729ced3 Author:Gabriele Paoloni AuthorDate:Fri, 27 Nov 2020 16:18:15 Committer:

[PATCH v7 02/17] drm/exynos: Use FOLL_LONGTERM for g2d cmdlists

2020-11-27 Thread Daniel Vetter
The exynos g2d interface is very unusual, but it looks like the userptr objects are persistent. Hence they need FOLL_LONGTERM. Signed-off-by: Daniel Vetter Cc: Jason Gunthorpe Cc: Inki Dae Cc: Joonyoung Shim Cc: Seung-Woo Kim Cc: Kyungmin Park Cc: Kukjin Kim Cc: Krzysztof Kozlowski Cc:

[PATCH v2 1/1] arm64: defconfig: Enable more Librem 5 hardware

2020-11-27 Thread Guido Günther
This enables - CONFIG_BATTERY_MAX17042: battery chip - CONFIG_CHARGER_BQ25980: charge controller - CONFIG_DRM_PANEL_MANTIX_MLAF057WE5: LCD panel - CONFIG_IMX_DCSS: 2nd dislay controller - CONFIG_LEDS_LM3692X: LCD backlight - CONFIG_REGULATOR_TPS65132: regulator for the LCD panel -

Re: [PATCH v1 6/8] arm64: defconfig: Enable CONFIG_VCNL4000

2020-11-27 Thread Guido Günther
Hi Krzysztof, On Fri, Nov 27, 2020 at 05:13:58PM +0100, Krzysztof Kozlowski wrote: > On Fri, 27 Nov 2020 at 15:23, Guido Günther wrote: > > > > This is the Librem 5's proximity sensor. > > Just squash all of them. Enabling option by option is too much. Done for v2. Cheers, -- Guido > > Best

[PATCH v7 05/17] mm/frame-vector: Use FOLL_LONGTERM

2020-11-27 Thread Daniel Vetter
This is used by media/videbuf2 for persistent dma mappings, not just for a single dma operation and then freed again, so needs FOLL_LONGTERM. Unfortunately current pup_locked doesn't support FOLL_LONGTERM due to locking issues. Rework the code to pull the pup path out from the mmap_sem critical

[PATCH v7 10/17] resource: Move devmem revoke code to resource framework

2020-11-27 Thread Daniel Vetter
We want all iomem mmaps to consistently revoke ptes when the kernel takes over and CONFIG_IO_STRICT_DEVMEM is enabled. This includes the pci bar mmaps available through procfs and sysfs, which currently do not revoke mappings. To prepare for this, move the code from the /dev/kmem driver to

[PATCH v7 08/17] PCI: Obey iomem restrictions for procfs mmap

2020-11-27 Thread Daniel Vetter
There's three ways to access PCI BARs from userspace: /dev/mem, sysfs files, and the old proc interface. Two check against iomem_is_exclusive, proc never did. And with CONFIG_IO_STRICT_DEVMEM, this starts to matter, since we don't want random userspace having access to PCI BARs while a driver is

[PATCH v7 11/17] sysfs: Support zapping of binary attr mmaps

2020-11-27 Thread Daniel Vetter
We want to be able to revoke pci mmaps so that the same access rules applies as for /dev/kmem. Revoke support for devmem was added in 3234ac664a87 ("/dev/mem: Revoke mappings when a driver claims the region"). The simplest way to achieve this is by having the same filp->f_mapping for all

[PATCH v7 14/17] media/videobuf1|2: Mark follow_pfn usage as unsafe

2020-11-27 Thread Daniel Vetter
The media model assumes that buffers are all preallocated, so that when a media pipeline is running we never miss a deadline because the buffers aren't allocated or available. This means we cannot fix the v4l follow_pfn usage through mmu_notifier, without breaking how this all works. The only

[PATCH v7 15/17] vfio/type1: Mark follow_pfn as unsafe

2020-11-27 Thread Daniel Vetter
The code seems to stuff these pfns into iommu pts (or something like that, I didn't follow), but there's no mmu_notifier to ensure that access is synchronized with pte updates. Hence mark these as unsafe. This means that with CONFIG_STRICT_FOLLOW_PFN, these will be rejected. Real fix is to wire

[PATCH v7 17/17] mm: add mmu_notifier argument to follow_pfn

2020-11-27 Thread Daniel Vetter
The only safe way for non core/arch code to use follow_pfn() is together with an mmu_notifier subscription. follow_pfn() is already marked as _GPL and the kerneldoc explains this restriction. This patch here enforces all this by adding a mmu_notifier argument and verifying that it is registered

<    1   2   3   4   5   6   7   8   >