Re: [PATCH] arch/x86: Propagate $(CLANG_FLAGS) to $(REALMODE_FLAGS)

2020-12-25 Thread Nathan Chancellor
On Fri, Dec 25, 2020 at 11:35:28PM -0800, h...@zytor.com wrote: > On December 25, 2020 11:29:30 PM PST, John Millikin > wrote: > >When compiling with Clang, the `$(CLANG_FLAGS)' variable contains > >additional flags needed to cross-compile C and Assembly sources: I am not sure how or if others

Re: [PATCH] arch/x86: Propagate $(CLANG_FLAGS) to $(REALMODE_FLAGS)

2020-12-25 Thread John Millikin
On 12/26/20 16:35, h...@zytor.com wrote: > Why is CLANG_FLAGS non-null when unused? It would be better to centralize > that. CLANG_FLAGS normally propagates through inclusion in the default KBUILD_CFLAGS and KBUILD_AFLAGS, set in `/Makefile':     # Makefile     KBUILD_CFLAGS += $(CLANG_FLAGS)  

Re: [PATCH] ALSA: hda: Resume codec for system suspend if LED is controlled by codec

2020-12-25 Thread Takashi Iwai
On Fri, 25 Dec 2020 17:47:23 +0100, Kai-Heng Feng wrote: > > Laptop with codec controlled LEDs takes a very long time to suspend > after commit 215a22ed31a1 ("ALSA: hda: Refactor codec PM to use > direct-complete optimization"): > [ 90.065964] PM: suspend entry (s2idle) > [ 90.067337]

[PATCH] RDMA/usnic: Fix memleak in find_free_vf_and_create_qp_grp

2020-12-25 Thread Dinghao Liu
If usnic_ib_qp_grp_create() fails at the first call, dev_list will not be freed on error, which leads to memleak. Signed-off-by: Dinghao Liu --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c

Re: [PATCH] arch/x86: Propagate $(CLANG_FLAGS) to $(REALMODE_FLAGS)

2020-12-25 Thread hpa
On December 25, 2020 11:29:30 PM PST, John Millikin wrote: >When compiling with Clang, the `$(CLANG_FLAGS)' variable contains >additional flags needed to cross-compile C and Assembly sources: > >* `-no-integrated-as' tells clang to assemble with GNU Assembler >  instead of its built-in LLVM

[PATCH] arch/x86: Propagate $(CLANG_FLAGS) to $(REALMODE_FLAGS)

2020-12-25 Thread John Millikin
When compiling with Clang, the `$(CLANG_FLAGS)' variable contains additional flags needed to cross-compile C and Assembly sources: * `-no-integrated-as' tells clang to assemble with GNU Assembler   instead of its built-in LLVM assembler. This flag is set by default   unless `LLVM_IAS=1' is set,

[PATCH] habanalabs: Fix memleak in hl_device_reset

2020-12-25 Thread Dinghao Liu
When kzalloc() fails, we should execute hl_mmu_fini() to release the MMU module. It's the same when hl_ctx_init() fails. Signed-off-by: Dinghao Liu --- drivers/misc/habanalabs/common/device.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/misc/habanalabs/common/device.c

Re: [PATCH] mfd: ab8500-debugfs: Remove extraneous curly brace

2020-12-25 Thread Joe Perches
On Fri, 2020-12-25 at 18:35 -0700, Nathan Chancellor wrote: > Clang errors: > > ../drivers/mfd/ab8500-debugfs.c:1526:2: error: non-void function does > not return a value [-Werror,-Wreturn-type] > } > ^ > ../drivers/mfd/ab8500-debugfs.c:1528:2: error: expected identifier or '(' >

[PATCH 5/5] gpio: xilinx: Add extra check if sum of widths exceed 64

2020-12-25 Thread Syed Nayyar Waris
Add extra check to see if sum of widths does not exceed 64. If it exceeds then return -EINVAL alongwith appropriate error message. Cc: Michal Simek Signed-off-by: Syed Nayyar Waris --- drivers/gpio/gpio-xilinx.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH 2/5] lib/test_bitmap.c: Add for_each_set_clump test cases

2020-12-25 Thread Syed Nayyar Waris
The introduction of the generic for_each_set_clump macro need test cases to verify the implementation. This patch adds test cases for scenarios in which clump sizes are 8 bits, 24 bits, 30 bits and 6 bits. The cases contain situations where clump is getting split at the word boundary and also when

[PATCH 4/5] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

2020-12-25 Thread Syed Nayyar Waris
This patch reimplements the xgpio_set_multiple() function in drivers/gpio/gpio-xilinx.c to use the new generic functions: bitmap_get_value() and bitmap_set_value(). The code is now simpler to read and understand. Moreover, instead of looping for each bit in xgpio_set_multiple() function, now we

[PATCH 3/5] gpio: thunderx: Utilize for_each_set_clump macro

2020-12-25 Thread Syed Nayyar Waris
This patch reimplements the thunderx_gpio_set_multiple function in drivers/gpio/gpio-thunderx.c to use the new for_each_set_clump macro. Instead of looping for each bank in thunderx_gpio_set_multiple function, now we can skip bank which is not set and save cycles. Cc: William Breathitt Gray Cc:

[PATCH 1/5] clump_bits: Introduce the for_each_set_clump macro

2020-12-25 Thread Syed Nayyar Waris
This macro iterates for each group of bits (clump) with set bits, within a bitmap memory region. For each iteration, "start" is set to the bit offset of the found clump, while the respective clump value is stored to the location pointed by "clump". Additionally, the bitmap_get_value() and

[PATCH 0/5] Introduce the for_each_set_clump macro

2020-12-25 Thread Syed Nayyar Waris
Hello Linus, Since this patchset primarily affects GPIO drivers, would you like to pick it up through your GPIO tree? (Note: Patchset resent with the new macro and relevant functions shifted to a new header clump_bits.h [Linus Torvalds]) Michal, What do you think of [PATCH 5/5]? Is the

Re: [PATCH v4 2/4] spi: ls7a: Add YAML schemas

2020-12-25 Thread zhangqing
Hi,Sergei Thank you for your reply and suggestion . I will use extra indentation levels and send v5 in the soon. Thanks, -Qing On 12/25/2020 08:19 PM, Sergei Shtylyov wrote: On 12/25/20 1:35 PM, Qing Zhang wrote: Switch the DT binding to a YAML schema to enable the DT validation.

Re: [PATCH v4 1/4] spi: LS7A: Add Loongson LS7A SPI controller driver support

2020-12-25 Thread zhangqing
Hi,Huacai Thank you for your reply and suggestion . I will remove blank lines and send v5 in the soon. Thanks, -Qing On 12/26/2020 12:28 PM, Huacai Chen wrote: Hi, Qing On Fri, Dec 25, 2020 at 6:40 PM Qing Zhang wrote: The SPI controller has the following characteristics: -

Re: [PATCH v4 2/4] spi: ls7a: Add YAML schemas

2020-12-25 Thread zhangqing
Hi,Jiaxun Thank you for your reply. I will also delete the num chipelects attribute in the device tree. And I will send v5 in the soon. Thanks, -Qing On 12/26/2020 11:31 AM, Jiaxun Yang wrote: 在 2020/12/25 下午6:35, Qing Zhang 写道: Switch the DT binding to a YAML schema to enable the DT

[PATCH] [v2] scsi: scsi_debug: Fix memleak in scsi_debug_init

2020-12-25 Thread Dinghao Liu
When sdeb_zbc_model does not match BLK_ZONED_NONE, BLK_ZONED_HA or BLK_ZONED_HM, we should free sdebug_q_arr to prevent memleak. Also there is no need to execute sdebug_erase_store() on failure of sdeb_zbc_model_str(). Signed-off-by: Dinghao Liu --- Changelog: v2: - Add missed assignment

[PATCH] scsi: scsi_debug: Fix memleak in scsi_debug_init

2020-12-25 Thread Dinghao Liu
When sdeb_zbc_model does not match BLK_ZONED_NONE, BLK_ZONED_HA or BLK_ZONED_HM, we should free sdebug_q_arr to prevent memleak. Also there is no need to execute sdebug_erase_store() on failure of sdeb_zbc_model_str(). Signed-off-by: Dinghao Liu --- drivers/scsi/scsi_debug.c | 4 ++-- 1 file

[PATCH] iommu: check for the deferred attach when attaching a device

2020-12-25 Thread Lianbo Jiang
Currently, because domain attach allows to be deferred from iommu driver to device driver, and when iommu initializes, the devices on the bus will be scanned and the default groups will be allocated. Due to the above changes, some devices could be added to the same group as below: [3.859417]

[PATCH] mm: page-flags.h: Typo fix (It -> If)

2020-12-25 Thread guoren
From: Guo Ren The "If" was wrongly spelled as "It". Signed-off-by: Guo Ren Cc: Andrew Morton Cc: Oscar Salvador Cc: Alexander Duyck Cc: David Hildenbrand Cc: Steven Price --- include/linux/page-flags.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v4 4/4] MIPS: Loongson: Enable Loongson LS7A SPI in loongson3_defconfig

2020-12-25 Thread Huacai Chen
Reviewed-by: Huacai Chen On Fri, Dec 25, 2020 at 6:41 PM Qing Zhang wrote: > > This is now supported, enable for Loongson systems. > > Signed-off-by: Qing Zhang > --- > > v2: > - Modify CONFIG_SPI_LOONGSON to CONFIG_SPI_LS7A > > v3: > - No changes > > v4: > - No changes > > --- >

Re: [PATCH v4 1/4] spi: LS7A: Add Loongson LS7A SPI controller driver support

2020-12-25 Thread Huacai Chen
Hi, Qing On Fri, Dec 25, 2020 at 6:40 PM Qing Zhang wrote: > > The SPI controller has the following characteristics: > > - Full-duplex synchronous serial data transmission > - Support up to 4 variable length byte transmission > - Main mode support > - Mode failure generates an error flag and

Re: [PATCH v4] HID: i2c-hid: add polling mode based on connected GPIO chip's pin status

2020-12-25 Thread Coiby Xu
Hi Greg and Barnabás, On Wed, Dec 09, 2020 at 04:44:35PM +0100, Greg KH wrote: On Wed, Dec 09, 2020 at 03:38:11PM +, Barnabás Pőcze wrote: 2020. december 9., szerda 8:00 keltezéssel, Greg KH írta: > On Tue, Dec 08, 2020 at 09:59:20PM +, Barnabás Pőcze wrote: > > > 2020. november 25.,

Re: [GIT PULL] PCI fixes for v5.11

2020-12-25 Thread pr-tracker-bot
The pull request you sent on Fri, 25 Dec 2020 22:11:03 -0600: > git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git > tags/pci-v5.11-fixes-1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/40f78232f97344afbbeb5b0008615f17c4b93466 Thank you! --

[GIT PULL] PCI fixes for v5.11

2020-12-25 Thread Bjorn Helgaas
The following changes since commit 255b2d524884e4ec60333131aa0ca0ef19826dc2: Merge branch 'remotes/lorenzo/pci/misc' (2020-12-15 15:11:14 -0600) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git tags/pci-v5.11-fixes-1 for you to fetch

Re: [PATCH v4 2/4] spi: ls7a: Add YAML schemas

2020-12-25 Thread Jiaxun Yang
在 2020/12/25 下午6:35, Qing Zhang 写道: Switch the DT binding to a YAML schema to enable the DT validation. Signed-off-by: Qing Zhang --- v4: fix warnings/errors about running 'make dt_binding_check' --- .../devicetree/bindings/spi/loongson,spi-ls7a.yaml | 46 ++ 1 file

[PATCH 2/2] arm64: mm: fix kdump broken with ZONE_DMA reintroduced

2020-12-25 Thread Chen Zhou
If the memory reserved for crash dump kernel falled in ZONE_DMA32, the devices in crash dump kernel need to use ZONE_DMA will alloc fail. Fix this by reserving low memory in ZONE_DMA if CONFIG_ZONE_DMA is enabled, otherwise, reserving in ZONE_DMA32. Fixes: bff3b04460a8 ("arm64: mm: reserve CMA

[PATCH 1/2] arm64: mm: update the comments about ZONE_DMA

2020-12-25 Thread Chen Zhou
Since patchset "arm64: Default to 32-bit wide ZONE_DMA", ZONE_DMA's size is fine-tuned. In the absence of addressing limited masters, ZONE_DMA will span the whole 32-bit address space, otherwise, in the case of the Raspberry Pi 4, it'll only span the 30-bit address space. Update the comments.

[PATCH 0/2] arm64: mm: fix kdump broken with ZONE_DMA reintroduced

2020-12-25 Thread Chen Zhou
If the memory reserved for crash dump kernel falled in ZONE_DMA32, the devices in crash dump kernel need to use ZONE_DMA will alloc fail. Fix this by reserving low memory in ZONE_DMA if CONFIG_ZONE_DMA is enabled, otherwise, reserving in ZONE_DMA32. Patch 1 updates the comments about

ERROR: modpost: ".do_uaccess_flush" undefined!

2020-12-25 Thread kernel test robot
Hi Nicholas, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 5814bc2d4cc241c1a603fac2b5bf1bd4daa108fc commit: 9a32a7e78bd0cd9a9b6332cbdc345ee5ffd0c5de powerpc/64s: flush L1D after user accesses date: 5 weeks

Re: [PATCH 1/1] ARM: LPAE: use phys_addr_t instead of unsigned long in outercache hooks

2020-12-25 Thread Leizhen (ThunderTown)
On 2020/12/25 19:44, Zhen Lei wrote: > The outercache of some Hisilicon SOCs support physical addresses wider > than 32-bits. The unsigned long datatype is not sufficient for mapping > physical addresses >= 4GB. The commit ad6b9c9d78b9 ("ARM: 6671/1: LPAE: > use phys_addr_t instead of unsigned

[PATCH -tip V3 1/8] workqueue: use cpu_possible_mask instead of cpu_active_mask to break affinity

2020-12-25 Thread Lai Jiangshan
From: Lai Jiangshan The scheduler won't break affinity for us any more, and we should "emulate" the same behavior when the scheduler breaks affinity for us. The behavior is "changing the cpumask to cpu_possible_mask". And there might be some other CPUs online later while the worker is still

[PATCH -tip V3 7/8] workqueue: reorganize workqueue_offline_cpu() unbind_workers()

2020-12-25 Thread Lai Jiangshan
From: Lai Jiangshan Just move around the code, no functionality changed. Only wq_pool_attach_mutex protected region becomes a little larger. It prepares for later patch protecting wq_online_cpumask in wq_pool_attach_mutex. Acked-by: Tejun Heo Signed-off-by: Lai Jiangshan ---

[PATCH -tip V3 6/8] workqueue: reorganize workqueue_online_cpu()

2020-12-25 Thread Lai Jiangshan
From: Lai Jiangshan Just move around the code, no functionality changed. It prepares for later patch protecting wq_online_cpumask in wq_pool_attach_mutex. Acked-by: Tejun Heo Signed-off-by: Lai Jiangshan --- kernel/workqueue.c | 11 --- 1 file changed, 8 insertions(+), 3

[PATCH -tip V3 5/8] workqueue: Manually break affinity on hotplug for unbound pool

2020-12-25 Thread Lai Jiangshan
From: Lai Jiangshan There is possible that a per-node pool/woker's affinity is a single CPU. It can happen when the workqueue user changes the cpumask of the workqueue or when wq_unbound_cpumask is changed by system adim via /sys/devices/virtual/workqueue/cpumask. And pool->attrs->cpumask is

[PATCH -tip V3 8/8] workqueue: Fix affinity of kworkers when attaching into pool

2020-12-25 Thread Lai Jiangshan
From: Lai Jiangshan When worker_attach_to_pool() is called, we should not put the workers to pool->attrs->cpumask when there is not CPU online in it. We have to use wq_online_cpumask in worker_attach_to_pool() to check if pool->attrs->cpumask is valid rather than cpu_online_mask or

[PATCH -tip V3 3/8] workqueue: introduce wq_online_cpumask

2020-12-25 Thread Lai Jiangshan
From: Lai Jiangshan wq_online_cpumask is the cached result of cpu_online_mask with the going-down cpu cleared. It is needed for later patches for setting correct cpumask for workers and break affinity initiatively. The first usage of wq_online_cpumask is also in this patch.

[PATCH -tip V3 2/8] workqueue: Manually break affinity on pool detachment

2020-12-25 Thread Lai Jiangshan
From: Lai Jiangshan The pool->attrs->cpumask might be a single CPU and it may go down after detachment, and the scheduler won't force to break affinity for us since it is a per-cpu-ktrhead. So we have to do it on our own and unbind this worker which can't be unbound by workqueue_offline_cpu()

[PATCH -tip V3 4/8] workqueue: use wq_online_cpumask in restore_unbound_workers_cpumask()

2020-12-25 Thread Lai Jiangshan
From: Lai Jiangshan restore_unbound_workers_cpumask() is called when CPU_ONLINE, where wq_online_cpumask equals to cpu_online_mask. So no fucntionality changed. Acked-by: Tejun Heo Signed-off-by: Lai Jiangshan --- kernel/workqueue.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH -tip V3 0/8] workqueue: break affinity initiatively

2020-12-25 Thread Lai Jiangshan
From: Lai Jiangshan 06249738a41a ("workqueue: Manually break affinity on hotplug") said that scheduler will not force break affinity for us. But workqueue highly depends on the old behavior. Many parts of the codes relies on it, 06249738a41a ("workqueue: Manually break affinity on hotplug") is

[PATCH] mfd: ab8500-debugfs: Remove extraneous curly brace

2020-12-25 Thread Nathan Chancellor
Clang errors: ../drivers/mfd/ab8500-debugfs.c:1526:2: error: non-void function does not return a value [-Werror,-Wreturn-type] } ^ ../drivers/mfd/ab8500-debugfs.c:1528:2: error: expected identifier or '(' return 0; ^ ../drivers/mfd/ab8500-debugfs.c:1529:1: error:

Re: [PATCH v3 4/5] RISC-V: Enable Microchip PolarFire ICICLE SoC

2020-12-25 Thread Aurelien Jarno
On 2020-12-04 00:58, Atish Patra wrote: > Enable Microchip PolarFire ICICLE soc config in defconfig. > It allows the default upstream kernel to boot on PolarFire ICICLE board. > > Signed-off-by: Atish Patra > Reviewed-by: Anup Patel > Reviewed-by: Bin Meng > --- > arch/riscv/configs/defconfig

Re: [PATCH 1/7] clk: qcom: clk-alpha-pll: Add support for Stromer PLLs

2020-12-25 Thread Konrad Dybcio
Hi, are you going to resubmit this patch? Looks like MDM9607 uses Stromer PLL for its CPU clocks and could benefit from it. Konrad

Re: [PATCH v1 1/2] dt-bindings: drm/bridge: anx7625: add DPI flag and swing setting

2020-12-25 Thread Rob Herring
On Fri, 25 Dec 2020 19:01:09 +0800, Xin Ji wrote: > Add DPI flag for distinguish MIPI input signal type, DSI or DPI. Add > swing setting for adjusting DP tx PHY swing > > Signed-off-by: Xin Ji > --- > .../bindings/display/bridge/analogix,anx7625.yaml | 19 > +++ > 1 file

[PATCH v4 0/3] drivers/soc/litex: support 32-bit subregisters, 64-bit CPUs

2020-12-25 Thread Gabriel Somlo
This series expands on commit 22447a99c97e ("drivers/soc/litex: add LiteX SoC Controller driver"), adding support for handling both 8- and 32-bit LiteX CSR (MMIO) subregisters, on both 32- and 64-bit CPUs. Notes v4: - improved "eloquence" of some 3/3 commit blurb paragraphs -

[PATCH v4 2/3] drivers/soc/litex: separate MMIO from subregister offset calculation

2020-12-25 Thread Gabriel Somlo
Separate MMIO (read/write) access into _[read|write]_litex_subregister() static inline functions, leaving existing "READ|WRITE" macros to handle calculation of the subregister offset only. NOTE: this is a non-functional change. Signed-off-by: Gabriel Somlo --- include/linux/litex.h | 16

[PATCH v4 1/3] drivers/soc/litex: move generic accessors to litex.h

2020-12-25 Thread Gabriel Somlo
Move generic LiteX CSR (MMIO) register accessors to litex.h and declare them as "static inline", in preparation for supporting 32-bit CSR subregisters and 64-bit CPUs. NOTE: this is a non-functional change. Signed-off-by: Gabriel Somlo --- drivers/soc/litex/litex_soc_ctrl.c | 73

[PATCH v4 3/3] drivers/soc/litex: support 32-bit subregisters, 64-bit CPUs

2020-12-25 Thread Gabriel Somlo
Upstream LiteX now defaults to using 32-bit CSR subregisters (see https://github.com/enjoy-digital/litex/commit/a2b71fde). This patch expands on commit 22447a99c97e ("drivers/soc/litex: add LiteX SoC Controller driver"), adding support for handling both 8- and 32-bit LiteX CSR (MMIO)

Re: [PATCH 1/3] dt-bindings: power: Introduce 'assigned-performance-states' property

2020-12-25 Thread Rob Herring
On Thu, 24 Dec 2020 16:42:08 +0530, Roja Rani Yarubandi wrote: > While most devices within power-domains which support performance states, > scale the performance state dynamically, some devices might want to > set a static/default performance state while the device is active. > These devices

Re: [PATCH 1/2] dt-bindings: Convert Arm Mali Valhall GPU to DT schema

2020-12-25 Thread Rob Herring
On Thu, 24 Dec 2020 20:31:18 +0800, Nick Fan wrote: > Convert the Arm Valhall GPU binding to DT schema format. > > Define a compatible string for the Mali Valhall GPU > for Mediatek's SoC platform. > > Signed-off-by: Nick Fan > --- > .../bindings/gpu/arm,mali-valhall.yaml| 252

[PATCH v7 5/5] counter: 104-quad-8: Add IRQ support for the ACCES 104-QUAD-8

2020-12-25 Thread William Breathitt Gray
The LSI/CSI LS7266R1 chip provides programmable output via the FLG pins. When interrupts are enabled on the ACCES 104-QUAD-8, they occur whenever FLG1 is active. Four functions are available for the FLG1 signal: Carry, Compare, Carry-Borrow, and Index. Carry: Interrupt

[PATCH v7 4/5] docs: counter: Document character device interface

2020-12-25 Thread William Breathitt Gray
This patch adds high-level documentation about the Counter subsystem character device interface. Signed-off-by: William Breathitt Gray --- Documentation/ABI/testing/sysfs-bus-counter | 9 + Documentation/driver-api/generic-counter.rst | 236 +++---

[PATCH v7 3/5] counter: Add character device interface

2020-12-25 Thread William Breathitt Gray
This patch introduces a character device interface for the Counter subsystem. Device data is exposed through standard character device read operations. Device data is gathered when a Counter event is pushed by the respective Counter device driver. Configuration is handled via ioctl operations on

[PATCH v7 0/5] Introduce the Counter character device interface

2020-12-25 Thread William Breathitt Gray
Changes in v7: - Implemented u32 enums; enum types can now be used directly for callbacks and values - Fixed refcount underflow bug - Refactored all err check to check for err < 0; this should help prevent future oversights on valid positive return valids - Use mutex instead of

[PATCH v7 2/5] docs: counter: Update to reflect sysfs internalization

2020-12-25 Thread William Breathitt Gray
The Counter subsystem architecture and driver implementations have changed in order to handle Counter sysfs interactions in a more consistent way. This patch updates the Generic Counter interface documentation to reflect the changes. Signed-off-by: William Breathitt Gray ---

Re: [PATCH] nfp: remove h from printk format specifier

2020-12-25 Thread Joe Perches
On Fri, 2020-12-25 at 14:13 -0800, Tom Rix wrote: > On 12/25/20 9:06 AM, Joe Perches wrote: > > On Fri, 2020-12-25 at 06:56 -0800, Tom Rix wrote: > > > On 12/24/20 2:39 PM, Joe Perches wrote: > > [] > > > > Kernel code doesn't use a signed char or short with %hx or %hu very > > > > often > > > >

Re: [PATCH 03/15] perf: Add build id data in mmap2 event

2020-12-25 Thread Jiri Olsa
On Tue, Dec 15, 2020 at 11:01:51PM +0100, Daniel Borkmann wrote: > Hey Arnaldo, > > On 12/15/20 4:52 PM, Arnaldo Carvalho de Melo wrote: > > Em Mon, Dec 14, 2020 at 11:54:45AM +0100, Jiri Olsa escreveu: > > > Adding support to carry build id data in mmap2 event. > > > > > > The build id data

[PATCH] perf tools: Detect when pipe is passed as perf data

2020-12-25 Thread Jiri Olsa
Currently we allow pipe input/output only through '-' string being passed to '-o' or '-i' options, like: # mkfifo perf.pipe # perf record --no-buffering -e 'sched:sched_switch' -o - > perf.pipe & [1] 354406 # cat perf.pipe | ./perf --no-pager script -i - | head -3 perf 354406

Re: [PATCH] nfp: remove h from printk format specifier

2020-12-25 Thread Tom Rix
On 12/25/20 9:06 AM, Joe Perches wrote: > On Fri, 2020-12-25 at 06:56 -0800, Tom Rix wrote: >> On 12/24/20 2:39 PM, Joe Perches wrote: > [] >>> Kernel code doesn't use a signed char or short with %hx or %hu very often >>> but in case you didn't already know, any signed char/short emitted with

Re: [PATCH v3 3/3] drivers/soc/litex: support 32-bit subregisters, 64-bit CPUs

2020-12-25 Thread Stafford Horne
On Fri, Dec 25, 2020 at 09:21:20AM -0500, Gabriel Somlo wrote: > Upstream LiteX now defaults to using 32-bit CSR subregisters > (see https://github.com/enjoy-digital/litex/commit/a2b71fde). > > This patch expands on commit 22447a99c97e ("drivers/soc/litex: add > LiteX SoC Controller driver"),

Re: [PATCH] nvmet-fc: associations list replaced with hlist rcu,

2020-12-25 Thread kernel test robot
Hi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.10 next-20201223] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in

drivers/mmc/host/s3cmci.c:1684:21: sparse: sparse: incorrect type in argument 1 (different address spaces)

2020-12-25 Thread kernel test robot
Hi Krzysztof, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 5814bc2d4cc241c1a603fac2b5bf1bd4daa108fc commit: 1b0e4a2141c7bf6a122f1e04cbc1690b835707cf mmc: s3cmci: enable compile testing date: 6 weeks ago

[RFC PATCH v2 01/19] dyndbg: fix use before null check

2020-12-25 Thread Jim Cromie
In commit a2d375eda771 ("dyndbg: refine export, rename to dynamic_debug_exec_queries()"), a string is copied before checking it isn't NULL. Fix this, report a usage/interface error, and return the proper error code. Fixes: a2d375eda771 ("dyndbg: refine export, rename to

[RFC PATCH v2 17/19] dyndbg: rearrange struct ddebug_callsites

2020-12-25 Thread Jim Cromie
move static-key field to top of struct. It is the biggest field, and most alignment constrained (I believe), so this improves ambient pahole conditions. It doesn't actually improve the packing, it only simplifies and shrinks the pahole reporting. probably drop during rebase, cleanup.

[RFC PATCH v2 18/19] dyndbg: add module_index to struct _ddebug

2020-12-25 Thread Jim Cromie
We seek to drop the pointer added when we split struct _ddebug. This would restore our footprint to parity worst case, with all the upsides of callsite overhead management. we will rely upon existing structure (and modify it): __dyndbg[], __dyndbg_callsites[] are parallel arrays, packed in

[RFC PATCH v2 16/19] dyndbg: ddebug_site_get/put api commentary

2020-12-25 Thread Jim Cromie
Paths forward: (not mutually exclusive) A: !site -> fill from backing store 1st try at this is/was using zram. At init, it copied each callsite into a zs-allocation, and all site-> refs afterward went thru _get/_put to zs-map on demand, and zs-unmap the site info. This worked until I tried to

[RFC PATCH v2 12/19] dyndbg: allow deleting site info via control interface

2020-12-25 Thread Jim Cromie
Allow users & subsystems to selectively delete callsite info for individual pr-debug callsites, or groups of them. Its purpose is for subsystems such as DRM which: - use distinct categories for logging, and can map them over to a format prefix, like: "drm:core:", "drm:kms:", etc. - are happy

[RFC PATCH v2 15/19] dyndbg: add ddebug_site_get/put api with pass-thru impl

2020-12-25 Thread Jim Cromie
Now that site info is optional, abstract it so we can manage it more flexibly later. Change all site users to use ddebug_site_get(p) instead, which just returns ->site. ddebug_site_put is called to balance gets, it currently does nothing. no functional changes. Signed-off-by: Jim Cromie ---

[RFC PATCH v2 11/19] dyndbg: refactor ddebug_alter_site out of ddebug_change

2020-12-25 Thread Jim Cromie
Move the JUMP_LABEL/static-key code to a separate inline function. no functional changes. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index

[RFC PATCH v2 09/19] dyndbg: optimize ddebug_emit_prefix

2020-12-25 Thread Jim Cromie
Add early return if no callsite info is specified in site-flags. This avoids fetching site info that isn't going to be printed. RFC: is this a proper place to use likely()? Signed-off-by: Jim Cromie --- include/linux/dynamic_debug.h | 9 + lib/dynamic_debug.c | 3 +++ 2 files

[RFC PATCH v2 19/19] dyndbg: try DEFINE_DYNAMIC_DEBUG_TABLE

2020-12-25 Thread Jim Cromie
Test DEFINE_DYNAMIC_DEBUG_TABLE, in i915.ko, by adding an invocation into i915_drv.c, the 1st object built in the Makefile. This does manually what can perhaps be done transparently in headers (hopefully). DEFINE_DYNAMIC_DEBUG_TABLE is based on DEFINE_DYNAMIC_DEBUG_METADATA; just like its model,

[RFC PATCH v2 13/19] dyndbg: verify __dyndbg & __dyndbg_callsite invariant

2020-12-25 Thread Jim Cromie
Prove that linker + DECLARE_DYNAMIC_DEBUG_METADATA reliably place the 2 related struct _ddebug* initializations into parallel/ordered slots in the __dyndbg_* sections. This is a step towards dropping the pointer between the 2 structs; maybe the 2 vectors stay ordered, and we can deduce and use N.

[RFC PATCH v2 10/19] dyndbg: avoid calling dyndbg_emit_prefix when it has no work

2020-12-25 Thread Jim Cromie
Wrap function in a static-inline one, which checks flags to avoid calling the function unnecessarily. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index

[RFC PATCH v2 07/19] dyndbg: accept null site in dynamic_emit_prefix

2020-12-25 Thread Jim Cromie
2 prints use site->member, protect them with if site. no functional changes. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 5422cef58130..190a796da03a 100644

[RFC PATCH v2 14/19] dyndbg+module: expose ddebug_callsites to modules

2020-12-25 Thread Jim Cromie
In order to drop the pointer connecting _ddebug records to _callsites, we need to elevate the latter; we need to track it in (internal) ddebug_tables, and set it in ddebug_add_module. That last part exposes it by interface to module.c, so we add a field to load_info, and adjust load_module to

[RFC PATCH v2 08/19] dyndbg: accept null site in ddebug_proc_show

2020-12-25 Thread Jim Cromie
Accept a ddebug record with a null site pointer, and write abbreviated output for that record that doesn't include site info (but does include line-number, since that can be used in >control queries). Also add a 2nd header line with a template for the new output. Signed-off-by: Jim Cromie ---

[RFC PATCH v2 04/19] dyndbg: accept null site in ddebug_match_site

2020-12-25 Thread Jim Cromie
make ddebug_match_site() tolerate null site. 1- move format and line-number check code to the top of the function, since they don't use/check site info. 2- test site pointer: If its null, we return early, skipping 3: If the query tests against missing site info, fail the match.

[RFC PATCH v2 06/19] dyndbg: accept null site in ddebug_change

2020-12-25 Thread Jim Cromie
fix a debug-print that includes site info, by adding an alternate debug message that does not. no functional changes. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c

[RFC PATCH v2 05/19] dyndbg: hoist ->site out of ddebug_match_site

2020-12-25 Thread Jim Cromie
A coming change adds _get/_put abstraction on the site pointer, to allow managing site info more flexibly. The get/put pattern is best done at a single lexical scope, where its more obviously correct, so hoist the ->site ref out of ddebug_match_site, and pass it in instead. Signed-off-by: Jim

[RFC PATCH v2 02/19] dyndbg: split struct _ddebug, move display fields to new _ddebug_callsite

2020-12-25 Thread Jim Cromie
struct _ddebug has 5 fields used to select/display pr_debug callsites; move 3 of them: module, function, file to new struct _ddebug_callsite, and add pointer from 1st to 2nd (head to body). The format field is excluded from the move because it is always needed for an enabled site, the others are

[RFC PATCH v2 00/19] dynamic debug diet plan

2020-12-25 Thread Jim Cromie
Well, we're mostly overeating, but we can all look forward to a diet in January. And more exersize. dyndbg's compiled-in data-table currently uses 56 bytes per prdebug; this includes 3 pointers to hierarchical "decorator" data, which is primarily for adding "module:function:line:" prefixes to

[RFC PATCH v2 03/19] dyndbg: refactor part of ddebug_change to ddebug_match_site

2020-12-25 Thread Jim Cromie
Move all the site-match logic into a separate function, reindent the code, and replace the continues with return falses. No functional changes. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 75 ++--- 1 file changed, 43 insertions(+), 32

UBSAN: shift-out-of-bounds in dummy_hub_control

2020-12-25 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:e37b12e4 Merge tag 'for-linus-5.11-ofs1' of git://git.kern.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1742993750 kernel config: https://syzkaller.appspot.com/x/.config?x=98408202fed1f636

Re: [PATCH v3 3/3] drivers/soc/litex: support 32-bit subregisters, 64-bit CPUs

2020-12-25 Thread Gabriel L. Somlo
On Fri, Dec 25, 2020 at 09:21:20AM -0500, Gabriel Somlo wrote: > Upstream LiteX now defaults to using 32-bit CSR subregisters > (see https://github.com/enjoy-digital/litex/commit/a2b71fde). > > This patch expands on commit 22447a99c97e ("drivers/soc/litex: add > LiteX SoC Controller driver"),

Re: [v6,3/4] PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192

2020-12-25 Thread Marc Zyngier
Hi Jianjun, On Fri, 25 Dec 2020 10:03:07 +, Jianjun Wang wrote: > > MediaTek's PCIe host controller has three generation HWs, the new > generation HW is an individual bridge, it supports Gen3 speed and > up to 256 MSI interrupt numbers for multi-function devices. > > Add support for new

Re: [PATCH 0/2] crypto: x86/aes-ni-xts - recover and improve performance

2020-12-25 Thread Eric Biggers
On Tue, Dec 22, 2020 at 05:06:27PM +0100, Ard Biesheuvel wrote: > The AES-NI implementation of XTS was impacted significantly by the retpoline > changes, which is due to the fact that both its asm helper and the chaining > mode glue library use indirect calls for processing small quantitities of >

Re: [GIT PULL] perf tools changes for v5.11, 2nd batch

2020-12-25 Thread pr-tracker-bot
The pull request you sent on Thu, 24 Dec 2020 15:56:33 -0300: > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git > tags/perf-tools-2020-12-24 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/5814bc2d4cc241c1a603fac2b5bf1bd4daa108fc Thank you! --

Re: [git pull] vfs.git misc stuff

2020-12-25 Thread pr-tracker-bot
The pull request you sent on Thu, 24 Dec 2020 23:35:07 +: > git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.misc has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/7bb5226c8a4bbf26a9ededc90532b0ad539d2017 Thank you! -- Deet-doot-dot, I am a bot.

[PATCH -next] regulator: qcom-rpmh: fix build after QCOM_COMMAND_DB is tristate

2020-12-25 Thread Randy Dunlap
Restrict REGULATOR_QCOM_RPMH to QCOM_COMMAND_DB it the latter is enabled. Fixes this build error: microblaze-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_probe': (.text+0x354): undefined reference to `cmd_db_read_addr' Fixes: 778279f4f5e4 ("soc: qcom:

[ANNOUNCE] 4.14.212-rt102

2020-12-25 Thread Clark Williams
Hello RT-list! I'm pleased to announce the 4.14.212-rt102 stable release. You can get this release via the git tree at: git://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt.git branch: v4.14-rt Head SHA1: cc763276d939207b3424090ab618c3e52f7d49de Or to build 4.14.212-rt102

arm-linux-gnueabi-ld: sil-sii8620.c:undefined reference to `extcon_register_notifier'

2020-12-25 Thread kernel test robot
Hi Masahiro, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 71c5f03154ac1cb27423b984743ccc2f5d11d14d commit: def2fbffe62c00c330c7f41584a356001179c59c kconfig: allow symbols implied by y to become m date: 10

undefined reference to `__ubsan_handle_alignment_assumption'

2020-12-25 Thread kernel test robot
Hi 周琰杰, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 71c5f03154ac1cb27423b984743ccc2f5d11d14d commit: 31de313dfdcf6971b0a1c30f86eabaa1eede74b3 PHY: Ingenic: Add USB PHY driver using generic PHY framework. date:

Re: [PATCH 2/2] checkpatch: kconfig: add missing types to regex

2020-12-25 Thread Joe Perches
On Fri, 2020-12-25 at 18:27 +0100, Nicolai Fischer wrote: > On 12/21/20 6:17 PM, Joe Perches wrote: [] > > The message you used: > > + WARN("CONFIG_DESCRIPTION", > > + "help text is not indented 2 spaces > > more than the help

[PATCH] drm/amd/display: avoid null pointer dereference in dm_set_vblank

2020-12-25 Thread Defang Bo
[Why] Similar to commit("drm/amd/display: Guard against null crtc in CRC IRQ"), a null pointer deference can occur if crtc is null in dm_set_vblank. [How] Check that CRTC is non-null before accessing its fields. Signed-off-by: Defang Bo --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |

Re: [PATCH 2/2] checkpatch: kconfig: add missing types to regex

2020-12-25 Thread Nicolai Fischer
On 12/21/20 6:17 PM, Joe Perches wrote: > On Mon, 2020-12-21 at 16:08 +0100, Nicolai Fischer wrote: >> On Sun, 2020-12-20 at 20:16 +0100, Joe Perches wrote: >>> On Mon, 2020-12-14 at 11:24 +0100, Nicolai Fischer wrote: Kconfig parsing does not recognise all type attributes. This adds

Re: [PATCH v6 3/5] counter: Add character device interface

2020-12-25 Thread William Breathitt Gray
Hi David, I agree with your suggested changes -- just a couple select comments following below. On Sun, Dec 13, 2020 at 05:58:26PM -0600, David Lechner wrote: > > +static int counter_add_watch(struct counter_device *const counter, > > +const unsigned long arg) > > +{

Wrong __setup() callbacks return values and /init's environment pollution

2020-12-25 Thread Igor Zhbanov
It seems that nobody knows how to write __setup() callback functions for parsing the command line parameters. And there are no documentation or comments about best practices. Despite being declared obsolete __setup() is used about 435 times in the kernel and 51 of them (~11.2%) are erroneous in

Re: riscv+KASAN does not boot

2020-12-25 Thread Dmitry Vyukov
On Fri, Dec 25, 2020 at 5:58 PM Andreas Schwab wrote: > > On Dez 25 2020, Dmitry Vyukov wrote: > > > qemu-system-riscv64 \ > > -machine virt -bios default -smp 1 -m 2G \ > > -device virtio-blk-device,drive=hd0 \ > > -drive file=buildroot-riscv64.ext4,if=none,format=raw,id=hd0 \ > > -kernel

undefined reference to `cmd_db_read_addr'

2020-12-25 Thread kernel test robot
Hi Lina, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 71c5f03154ac1cb27423b984743ccc2f5d11d14d commit: 778279f4f5e4e89ff31803ba48135256563825c2 soc: qcom: cmd-db: allow loading as a module date: 9 weeks ago

  1   2   3   >