Re: [PATCH v2 1/1] mm/madvise: replace ptrace attach requirement for process_madvise

2021-01-12 Thread Suren Baghdasaryan
On Mon, Jan 11, 2021 at 11:46 PM Michal Hocko wrote: > > On Mon 11-01-21 09:06:22, Suren Baghdasaryan wrote: > > process_madvise currently requires ptrace attach capability. > > PTRACE_MODE_ATTACH gives one process complete control over another > > process. It effectively removes the security

[PATCH 15/24] kvm: mmu: Wrap mmu_lock cond_resched and needbreak

2021-01-12 Thread Ben Gardon
Wrap the MMU lock cond_reseched and needbreak operations in a function. This will support a refactoring to move the lock into the struct kvm_arch(s) so that x86 can change the spinlock to a rwlock without affecting the performance of other archs. No functional change intended. Reviewed-by: Peter

[PATCH 24/24] kvm: x86/mmu: Allow parallel page faults for the TDP MMU

2021-01-12 Thread Ben Gardon
Make the last few changes necessary to enable the TDP MMU to handle page faults in parallel while holding the mmu_lock in read mode. Reviewed-by: Peter Feiner Signed-off-by: Ben Gardon --- arch/x86/kvm/mmu/mmu.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git

[PATCH 13/24] kvm: x86/mmu: Only free tdp_mmu pages after a grace period

2021-01-12 Thread Ben Gardon
By waiting until an RCU grace period has elapsed to free TDP MMU PT memory, the system can ensure that no kernel threads access the memory after it has been freed. Reviewed-by: Peter Feiner Signed-off-by: Ben Gardon --- arch/x86/kvm/mmu/mmu_internal.h | 3 +++ arch/x86/kvm/mmu/tdp_mmu.c

[PATCH 19/24] kvm: x86/mmu: Protect tdp_mmu_pages with a lock

2021-01-12 Thread Ben Gardon
Add a lock to protect the data structures that track the page table memory used by the TDP MMU. In order to handle multiple TDP MMU operations in parallel, pages of PT memory must be added and removed without the exclusive protection of the MMU lock. A new lock to protect the list(s) of in-use

[PATCH 21/24] kvm: x86/mmu: Use atomic ops to set SPTEs in TDP MMU map

2021-01-12 Thread Ben Gardon
To prepare for handling page faults in parallel, change the TDP MMU page fault handler to use atomic operations to set SPTEs so that changes are not lost if multiple threads attempt to modify the same SPTE. Reviewed-by: Peter Feiner Signed-off-by: Ben Gardon --- arch/x86/kvm/mmu/tdp_mmu.c |

[PATCH 01/24] locking/rwlocks: Add contention detection for rwlocks

2021-01-12 Thread Ben Gardon
rwlocks do not currently have any facility to detect contention like spinlocks do. In order to allow users of rwlocks to better manage latency, add contention detection for queued rwlocks. CC: Ingo Molnar CC: Will Deacon Acked-by: Peter Zijlstra Acked-by: Davidlohr Bueso Acked-by: Waiman Long

[PATCH 22/24] kvm: x86/mmu: Flush TLBs after zap in TDP MMU PF handler

2021-01-12 Thread Ben Gardon
When the TDP MMU is allowed to handle page faults in parallel there is the possiblity of a race where an SPTE is cleared and then imediately replaced with a present SPTE pointing to a different PFN, before the TLBs can be flushed. This race would violate architectural specs. Ensure that the TLBs

[PATCH 18/24] kvm: x86/mmu: Use an rwlock for the x86 TDP MMU

2021-01-12 Thread Ben Gardon
Add a read / write lock to be used in place of the MMU spinlock when the TDP MMU is enabled. The rwlock will enable the TDP MMU to handle page faults in parallel in a future commit. In cases where the TDP MMU is not in use, no operation would be acquiring the lock in read mode, so a regular spin

[PATCH 10/24] kvm: x86/mmu: Factor out handle disconnected pt

2021-01-12 Thread Ben Gardon
Factor out the code to handle a disconnected subtree of the TDP paging structure from the code to handle the change to an individual SPTE. Future commits will build on this to allow asynchronous page freeing. No functional change intended. Reviewed-by: Peter Feiner Signed-off-by: Ben Gardon

[PATCH v4 1/3] ASoC: SOF: Intel: hda: Resume codec to do jack detection

2021-01-12 Thread Kai-Heng Feng
Instead of queueing jackpoll_work, runtime resume the codec to let it use different jack detection methods based on jackpoll_interval. This partially matches SOF driver's behavior with commit a6e7d0a4bdb0 ("ALSA: hda: fix jack detection with Realtek codecs when in D3"), the difference is SOF

[PATCH 17/24] kvm: mmu: Move mmu_lock to struct kvm_arch

2021-01-12 Thread Ben Gardon
Move the mmu_lock to struct kvm_arch so that it can be replaced with a rwlock on x86 without affecting the performance of other archs. No functional change intended. Reviewed-by: Peter Feiner Signed-off-by: Ben Gardon --- Documentation/virt/kvm/locking.rst | 2 +-

[PATCH 08/24] kvm: x86/mmu: Add lockdep when setting a TDP MMU SPTE

2021-01-12 Thread Ben Gardon
Add lockdep to __tdp_mmu_set_spte to ensure that SPTEs are only modified under the MMU lock. This lockdep will be updated in future commits to reflect and validate changes to the TDP MMU's synchronization strategy. No functional change intended. Reviewed-by: Peter Feiner Signed-off-by: Ben

[PATCH 14/24] kvm: mmu: Wrap mmu_lock lock / unlock in a function

2021-01-12 Thread Ben Gardon
Wrap locking and unlocking the mmu_lock in a function. This will facilitate future logging and stat collection for the lock and more immediately support a refactoring to move the lock into the struct kvm_arch(s) so that x86 can change the spinlock to a rwlock without affecting the performance of

[PATCH 09/24] kvm: x86/mmu: Don't redundantly clear TDP MMU pt memory

2021-01-12 Thread Ben Gardon
The KVM MMU caches already guarantee that shadow page table memory will be zeroed, so there is no reason to re-zero the page in the TDP MMU page fault handler. No functional change intended. Reviewed-by: Peter Feiner Signed-off-by: Ben Gardon --- arch/x86/kvm/mmu/tdp_mmu.c | 1 - 1 file

[PATCH 04/24] kvm: x86/mmu: change TDP MMU yield function returns to match cond_resched

2021-01-12 Thread Ben Gardon
Currently the TDP MMU yield / cond_resched functions either return nothing or return true if the TLBs were not flushed. These are confusing semantics, especially when making control flow decisions in calling functions. To clean things up, change both functions to have the same return value

[PATCH 05/24] kvm: x86/mmu: Fix yielding in TDP MMU

2021-01-12 Thread Ben Gardon
There are two problems with the way the TDP MMU yields in long running functions. 1.) Given certain conditions, the function may not yield reliably / frequently enough. 2.) In some functions the TDP iter risks not making forward progress if two threads livelock yielding to one another. Case 1 is

[PATCH 07/24] kvm: x86/mmu: Add comment on __tdp_mmu_set_spte

2021-01-12 Thread Ben Gardon
__tdp_mmu_set_spte is a very important function in the TDP MMU which already accepts several arguments and will take more in future commits. To offset this complexity, add a comment to the function describing each of the arguemnts. No functional change intended. Reviewed-by: Peter Feiner

[PATCH 02/24] sched: Add needbreak for rwlocks

2021-01-12 Thread Ben Gardon
Contention awareness while holding a spin lock is essential for reducing latency when long running kernel operations can hold that lock. Add the same contention detection interface for read/write spin locks. CC: Ingo Molnar CC: Will Deacon Acked-by: Peter Zijlstra Acked-by: Davidlohr Bueso

[PATCH 00/24] Allow parallel page faults with TDP MMU

2021-01-12 Thread Ben Gardon
The TDP MMU was implemented to simplify and improve the performance of KVM's memory management on modern hardware with TDP (EPT / NPT). To build on the existing performance improvements of the TDP MMU, add the ability to handle vCPU page faults in parallel. In the current implementation, vCPU page

Re: [PATCH 04/11] kasan: add match-all tag tests

2021-01-12 Thread Andrey Konovalov
On Tue, Jan 12, 2021 at 9:05 AM Alexander Potapenko wrote: > > On Tue, Jan 5, 2021 at 7:28 PM Andrey Konovalov wrote: > > > > Add 3 new tests for tag-based KASAN modes: > > > > 1. Check that match-all pointer tag is not assigned randomly. > > 2. Check that 0xff works as a match-all pointer tag.

Re: [PATCH v14 0/6] Carry forward IMA measurement log on kexec on ARM64

2021-01-12 Thread Mimi Zohar
On Tue, 2021-01-12 at 08:42 -0600, Rob Herring wrote: > On Mon, Jan 04, 2021 at 11:25:56AM -0800, Lakshmi Ramasubramanian wrote: > > On kexec file load Integrity Measurement Architecture (IMA) subsystem > > may verify the IMA signature of the kernel and initramfs, and measure > > it. The command

Re: Infinite recursion in device_reorder_to_tail() due to circular device links

2021-01-12 Thread Greg Kroah-Hartman
On Tue, Jan 12, 2021 at 03:32:04PM +0100, Rafael J. Wysocki wrote: > On Mon, Jan 11, 2021 at 7:46 PM Stephan Gerhold wrote: > > > > Hi, > > > > since 5.11-rc1 I get kernel crashes with infinite recursion in > > device_reorder_to_tail() in some situations... It's a bit complicated to > > explain

Re: [PATCH 9/9] drm/msm/dpu: Fix timeout issues on command mode panels

2021-01-12 Thread AngeloGioacchino Del Regno
Il 09/01/21 14:37, AngeloGioacchino Del Regno ha scritto: In function dpu_encoder_phys_cmd_wait_for_commit_done we are always checking if the relative CTL is started by waiting for an interrupt to fire: it is fine to do that, but then sometimes we call this function while the CTL is up and has

Re: [net-next PATCH v3 09/15] device property: Introduce fwnode_get_id()

2021-01-12 Thread Andy Shevchenko
On Tue, Jan 12, 2021 at 09:30:31AM -0800, Saravana Kannan wrote: > On Tue, Jan 12, 2021 at 5:42 AM Calvin Johnson > wrote: > > > > Using fwnode_get_id(), get the reg property value for DT node > > or get the _ADR object value for ACPI node. ... > > +/** > > + * fwnode_get_id - Get the id of a

Re: [PATCH] scsi: lpfc: style: Simplify bool comparison

2021-01-12 Thread James Smart
On 1/12/2021 12:24 AM, YANG LI wrote: Fix the following coccicheck warning: ./drivers/scsi/lpfc/lpfc_bsg.c:5392:5-29: WARNING: Comparison to bool Reported-by: Abaci Robot Signed-off-by: YANG LI --- drivers/scsi/lpfc/lpfc_bsg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [RFC PATCH v3 0/6] Restricted DMA

2021-01-12 Thread Florian Fainelli
On 1/11/21 11:48 PM, Claire Chang wrote: > On Fri, Jan 8, 2021 at 1:59 AM Florian Fainelli wrote: >> >> On 1/7/21 9:42 AM, Claire Chang wrote: >> Can you explain how ATF gets involved and to what extent it does help, besides enforcing a secure region from the ARM CPU's perpsective? Does

Re: [GIT PULL] Please pull NFS client bugfixes

2021-01-12 Thread pr-tracker-bot
The pull request you sent on Tue, 12 Jan 2021 14:31:12 +: > git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-5.11-2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e609571b5ffa3528bf85292de1ceaddac342bc1c Thank you! -- Deet-doot-dot, I am a

Re: [PATCH 1/2] KVM: x86: Add emulation support for #GP triggered by VM instructions

2021-01-12 Thread Sean Christopherson
On Tue, Jan 12, 2021, Sean Christopherson wrote: > On Tue, Jan 12, 2021, Wei Huang wrote: > > From: Bandan Das > > > > While running VM related instructions (VMRUN/VMSAVE/VMLOAD), some AMD > > CPUs check EAX against reserved memory regions (e.g. SMM memory on host) > > before checking VMCB's

5.11-rc3: build error in arm/boot/compressed/.../fdt_ro.c

2021-01-12 Thread Pavel Machek
Hi! I can't build for 32-bit arm: CC arch/arm/boot/compressed/fdt_wip.o In file included from arch/arm/boot/compressed/../../../../lib/fdt_ro.c:2, from arch/arm/boot/compressed/fdt_ro.c:2: arch/arm/boot/compressed/../../../../lib/../scripts/dtc/libfdt/fdt_ro.c: In

Re: [PATCH 3/4] workqueue: Tag bound workers with KTHREAD_IS_PER_CPU

2021-01-12 Thread Valentin Schneider
On 12/01/21 15:43, Peter Zijlstra wrote: > @@ -4919,8 +4922,10 @@ static void unbind_workers(int cpu) > > raw_spin_unlock_irq(>lock); > > - for_each_pool_worker(worker, pool) > + for_each_pool_worker(worker, pool) { > +

Re: 5.11-rc device reordering breaks ThinkPad rmi4 suspend

2021-01-12 Thread Thierry Reding
On Mon, Jan 11, 2021 at 05:57:17PM +0100, Rafael J. Wysocki wrote: > On Mon, Jan 11, 2021 at 5:12 PM Thierry Reding wrote: > > > > On Mon, Jan 11, 2021 at 03:57:37PM +0100, Rafael J. Wysocki wrote: > > > On Mon, Jan 11, 2021 at 2:43 PM Thierry Reding wrote: > > > > > > > > On Sun, Jan 10, 2021

Re: [PATCH 1/2] KVM: x86: Add emulation support for #GP triggered by VM instructions

2021-01-12 Thread Sean Christopherson
On Tue, Jan 12, 2021, Andy Lutomirski wrote: > > > On Jan 12, 2021, at 7:46 AM, Bandan Das wrote: > > > > Andy Lutomirski writes: > > ... > >> #endif diff --git a/arch/x86/kvm/mmu/mmu.c > >> b/arch/x86/kvm/mmu/mmu.c index 6d16481aa29d..c5c4aaf01a1a 100644 > >> ---

RE: [PATCH v3 2/3] x86/platform/dell-privacy-wmi: add document for dell privacy driver

2021-01-12 Thread Limonciello, Mario
> -Original Message- > From: Yuan, Perry > Sent: Tuesday, January 12, 2021 11:18 > To: oder_ch...@realtek.com; pe...@perex.cz; ti...@suse.com; > hdego...@redhat.com; mgr...@linux.intel.com > Cc: lgirdw...@gmail.com; broo...@kernel.org; alsa-de...@alsa-project.org; >

Re: [PATCH 03/11] kasan: clean up comments in tests

2021-01-12 Thread Andrey Konovalov
On Tue, Jan 12, 2021 at 8:53 AM Alexander Potapenko wrote: > > On Tue, Jan 5, 2021 at 7:28 PM Andrey Konovalov wrote: > > > > Clarify and update comments and info messages in KASAN tests. > > > > Signed-off-by: Andrey Konovalov > > Link: > >

Re: [PATCH v13 09/15] s390/vfio-ap: allow hot plug/unplug of AP resources using mdev device

2021-01-12 Thread Halil Pasic
On Tue, 12 Jan 2021 02:12:51 +0100 Halil Pasic wrote: > > @@ -1347,8 +1437,11 @@ void vfio_ap_mdev_remove_queue(struct ap_device > > *apdev) > > apqi = AP_QID_QUEUE(q->apqn); > > vfio_ap_mdev_reset_queue(apid, apqi, 1); > > > > - if (q->matrix_mdev) > > + if (q->matrix_mdev) { > >

Re: [PATCH v3 3/3] ASoC: rt715:add micmute led state control supports

2021-01-12 Thread Mark Brown
On Wed, Jan 13, 2021 at 01:18:14AM +0800, Perry Yuan wrote: > Some new Dell system is going to support audio internal micphone > privacy setting from hardware level with micmute led state changing > When micmute hotkey pressed by user, soft mute will need to be enabled > firstly in case of pop

RE: [PATCH v3 3/3] ASoC: rt715:add micmute led state control supports

2021-01-12 Thread Limonciello, Mario
> -Original Message- > From: Yuan, Perry > Sent: Tuesday, January 12, 2021 11:18 > To: oder_ch...@realtek.com; pe...@perex.cz; ti...@suse.com; > hdego...@redhat.com; mgr...@linux.intel.com > Cc: lgirdw...@gmail.com; broo...@kernel.org; alsa-de...@alsa-project.org; >

Re: [PATCH -tip V3 0/8] workqueue: break affinity initiatively

2021-01-12 Thread Valentin Schneider
On 12/01/21 12:33, Lai Jiangshan wrote: >> I thought only pcpu pools would get the POOL_DISASSOCIATED flag on >> offline, but it seems unbound pools also get it at init time. Did I get >> that right? > > You are right. > > The POOL_DISASSOCIATED flag indicates whether the pool is concurrency >

Re: [PATCH] rcu: remove surplus instrumentation_end in rcu_nmi_enter

2021-01-12 Thread Paul E. McKenney
On Mon, Jan 11, 2021 at 09:08:59AM +0800, Zhouyi Zhou wrote: > In function rcu_nmi_enter, there is a surplus instrumentation_end > in second branch of if statement, although objtool check -f vmlinux.o will > not complain because of its inability to correctly cover all cases > (objtool will visit

Re: [PATCH v2 1/1] mm/madvise: replace ptrace attach requirement for process_madvise

2021-01-12 Thread Suren Baghdasaryan
On Tue, Jan 12, 2021 at 9:45 AM Oleg Nesterov wrote: > > On 01/12, Michal Hocko wrote: > > > > On Mon 11-01-21 09:06:22, Suren Baghdasaryan wrote: > > > > > What we want is the ability for one process to influence another process > > > in order to optimize performance across the entire system

Re: [PATCH 5/7] regulator: qcom-labibb: Implement short-circuit and over-current IRQs

2021-01-12 Thread AngeloGioacchino Del Regno
Il 12/01/21 18:29, Mark Brown ha scritto: On Mon, Jan 11, 2021 at 10:06:18PM +0100, AngeloGioacchino Del Regno wrote: ...which was already a requirement before I touched it. Now, this leaves two options here: 1. Keep the of_get_irq way, or 2. Move the interrupts, change the documentation

Re: [PATCH 8/9] KVM: arm64: vgic-v3: Expose GICR_TYPER.Last for userspace

2021-01-12 Thread Marc Zyngier
On 2021-01-12 17:28, Alexandru Elisei wrote: Hi Eric, On 12/12/20 6:50 PM, Eric Auger wrote: Commit 23bde34771f1 ("KVM: arm64: vgic-v3: Drop the reporting of GICR_TYPER.Last for userspace") temporarily fixed a bug identified when attempting to access the GICR_TYPER register before the

Re: [PATCH v2] blk: avoid divide-by-zero with zero granularity

2021-01-12 Thread Martin K. Petersen
Johannes, >> I use the nvme-tcp as the host, the target is spdk nvme-tcp target, >> and set a wrong block size(i.g. bs=8), then the host prints this oops: > > I think the better fix here is to reject devices which report a block size > small than a sector. Yep, Linux doesn't support logical

ASoC: cpcap: Implement set_tdm_slot for voice call support

2021-01-12 Thread Pavel Machek
From: Tony Lindgren ASoC: cpcap: Implement set_tdm_slot for voice call support For using cpcap for voice calls, we need to route audio directly from the modem to cpcap for TDM (Time Division Multiplexing). The voice call is direct data between the modem and cpcap with no CPU involvment.

Re: [PATCH v8 1/2] Serial: silabs si4455 serial driver

2021-01-12 Thread József Horváth
On Tue, Jan 12, 2021 at 05:13:16PM +0100, 'Greg Kroah-Hartman' wrote: > On Tue, Jan 12, 2021 at 03:43:22PM +, József Horváth wrote: > > On Tue, Jan 12, 2021 at 11:28:08AM +0100, 'Greg Kroah-Hartman' wrote: > > > On Tue, Jan 12, 2021 at 10:18:33AM +, Jozsef Horvath wrote: > > > > ---

Re: [PATCH] scsi: mpt3sas: Simplify _base_display_OEMs_branding

2021-01-12 Thread Joe Perches
On Tue, 2021-01-12 at 17:40 +, Johannes Thumshirn wrote: > On 12/01/2021 18:38, Joe Perches wrote: > >  static void > >  _base_display_OEMs_branding(struct MPT3SAS_ADAPTER *ioc) > >  { > > + const char *b = NULL; /* brand */ > > + const char *v = NULL; /* vendor */ > > Any reason you

Re: [PATCH v2 1/1] mm/madvise: replace ptrace attach requirement for process_madvise

2021-01-12 Thread Oleg Nesterov
On 01/12, Michal Hocko wrote: > > On Mon 11-01-21 09:06:22, Suren Baghdasaryan wrote: > > > What we want is the ability for one process to influence another process > > in order to optimize performance across the entire system while leaving > > the security boundary intact. > > Replace

Re: [PATCH v2] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-12 Thread Fāng-ruì Sòng
On Tue, Jan 12, 2021 at 9:37 AM 'Nick Desaulniers' via Clang Built Linux wrote: > > On Mon, Jan 11, 2021 at 9:14 PM Bill Wendling wrote: > > > > From: Sami Tolvanen > > > > Enable the use of clang's Profile-Guided Optimization[1]. To generate a > > profile, the kernel is instrumented with PGO

Re: [PATCH v3 1/4] ALSA: hda/realtek: Power up codec when setting LED via COEF and GPIO

2021-01-12 Thread Kai-Heng Feng
On Tue, Jan 12, 2021 at 9:17 PM Takashi Iwai wrote: > > On Tue, 12 Jan 2021 14:06:59 +0100, > Kai-Heng Feng wrote: > > > > System takes a very long time to suspend after commit 215a22ed31a1 > > ("ALSA: hda: Refactor codec PM to use direct-complete optimization"): > > [ 90.065964] PM: suspend

Re: [PATCH v3 4/4] ASoC: SOF: Intel: hda: Avoid checking jack on system suspend

2021-01-12 Thread Mark Brown
On Tue, Jan 12, 2021 at 09:07:02PM +0800, Kai-Heng Feng wrote: > Fixes: 215a22ed31a1 ("ALSA: hda: Refactor codec PM to use direct-complete > optimization") > --- > v3: You've not provided a Signed-off-by for this so I can't do anything with it, please see

Re: [PATCH] scsi: mpt3sas: Simplify _base_display_OEMs_branding

2021-01-12 Thread Johannes Thumshirn
On 12/01/2021 18:38, Joe Perches wrote: > static void > _base_display_OEMs_branding(struct MPT3SAS_ADAPTER *ioc) > { > + const char *b = NULL; /* brand */ > + const char *v = NULL; /* vendor */ Any reason you didn't spell out brand and vendor as the variable names?

Re: [PATCH 1/2] KVM: x86: Add emulation support for #GP triggered by VM instructions

2021-01-12 Thread Sean Christopherson
On Tue, Jan 12, 2021, Paolo Bonzini wrote: > On 12/01/21 07:37, Wei Huang wrote: > > static int gp_interception(struct vcpu_svm *svm) > > { > > struct kvm_vcpu *vcpu = >vcpu; > > u32 error_code = svm->vmcb->control.exit_info_1; > > - > > - WARN_ON_ONCE(!enable_vmware_backdoor); > > +

Re: [PATCH v3 1/3] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-01-12 Thread Randy Dunlap
On 1/12/21 9:17 AM, Perry Yuan wrote: > +config DELL_PRIVACY > + tristate "Dell Hardware Privacy Support" > + depends on ACPI > + depends on ACPI_WMI > + depends on INPUT > + depends on DELL_LAPTOP > + depends on LEDS_TRIGGER_AUDIO > + select DELL_WMI > + help > +

Re: [RFC PATCH 0/2] userfaultfd: handle minor faults, add UFFDIO_CONTINUE

2021-01-12 Thread Axel Rasmussen
On Mon, Jan 11, 2021 at 5:49 PM Peter Xu wrote: > > On Mon, Jan 11, 2021 at 04:13:41PM -0800, Mike Kravetz wrote: > > On 1/11/21 3:08 PM, Peter Xu wrote: > > > On Mon, Jan 11, 2021 at 02:42:48PM -0800, Mike Kravetz wrote: > > >> On 1/7/21 11:04 AM, Axel Rasmussen wrote: > > >>> Overview > > >>>

Re: 5.11-rc device reordering breaks ThinkPad rmi4 suspend

2021-01-12 Thread Thierry Reding
t; > ("driver core: Reorder devices on successful probe"), but it's the > > > driver core that suspends/resumes the devices in the wrong order. > > > > > > The reason is because the ACONNECT device depends on the BPMP device > > > (via a power-domains p

Re: [PATCH v2] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-12 Thread Nick Desaulniers
On Mon, Jan 11, 2021 at 9:14 PM Bill Wendling wrote: > > From: Sami Tolvanen > > Enable the use of clang's Profile-Guided Optimization[1]. To generate a > profile, the kernel is instrumented with PGO counters, a representative > workload is run, and the raw profile data is collected from >

Re: [PATCH v2 1/1] mm/madvise: replace ptrace attach requirement for process_madvise

2021-01-12 Thread Suren Baghdasaryan
On Mon, Jan 11, 2021 at 5:22 PM Andrew Morton wrote: > > On Mon, 11 Jan 2021 09:06:22 -0800 Suren Baghdasaryan > wrote: > > > process_madvise currently requires ptrace attach capability. > > PTRACE_MODE_ATTACH gives one process complete control over another > > process. It effectively removes

Re: [PATCH v2] blk: avoid divide-by-zero with zero granularity

2021-01-12 Thread Johannes Thumshirn
On 12/01/2021 18:29, Feng Li wrote: > I use the nvme-tcp as the host, the target is spdk nvme-tcp target, > and set a wrong block size(i.g. bs=8), then the host prints this oops: I think the better fix here is to reject devices which report a block size small than a sector.

[PATCH] scsi: mpt3sas: Simplify _base_display_OEMs_branding

2021-01-12 Thread Joe Perches
Simplify code by using char pointers and not individual calls to ioc_info() when identifying OEMs branding. Reduces object size a bit too: $ size drivers/scsi/mpt3sas/mpt3sas_base.o* textdata bss dec hex filename 72024 88 288 72400 11ad0

Re: [PATCH 1/2] KVM: x86: Add emulation support for #GP triggered by VM instructions

2021-01-12 Thread Sean Christopherson
On Tue, Jan 12, 2021, Wei Huang wrote: > From: Bandan Das > > While running VM related instructions (VMRUN/VMSAVE/VMLOAD), some AMD > CPUs check EAX against reserved memory regions (e.g. SMM memory on host) > before checking VMCB's instruction intercept. It would be very helpful to list exactly

Re: kernel BUG at mm/page-writeback.c:LINE!

2021-01-12 Thread Linus Torvalds
On Tue, Jan 12, 2021 at 2:44 AM Jan Kara wrote: > > On Fri 08-01-21 18:04:21, Linus Torvalds wrote: > > > > Oh, and Michael Larabel (of phoronix) reports that that one-liner does > > something bad to a few PostgreSQL tests, on the order of 5-10% > > regression on some machines (but apparently not

Re: [PATCH v1 (RFC)] docs: discourage users from using bugzilla.kernel.org

2021-01-12 Thread Thorsten Leemhuis
Am 12.01.21 um 00:42 schrieb Randy Dunlap: > On 1/11/21 10:55 AM, Thorsten Leemhuis wrote: >> Am 11.01.21 um 19:14 schrieb Randy Dunlap: >>> On 1/10/21 4:10 AM, Thorsten Leemhuis wrote: > >>> Andrew Morton takes MM bugs and Cc:s them to linux-mm mailing list >>> and then asks for discussion to

Re: [PATCH v2] i2c: tegra: Create i2c_writesl_vi() to use with VI I2C for filling TX FIFO

2021-01-12 Thread Dmitry Osipenko
12.01.2021 19:57, Sowjanya Komatineni пишет: ... >> @@ -326,6 +326,8 @@ static void i2c_writel(struct tegra_i2c_dev >> *i2c_dev, u32 val, unsigned int reg) >>   /* read back register to make sure that register writes >> completed */ >>   if (reg != I2C_TX_FIFO) >>  

Re: [PATCH RESEND v3] venus: venc: set inband mode property to FW.

2021-01-12 Thread Fritz Koenig
On Thu, Jan 7, 2021 at 11:26 PM Dikshita Agarwal wrote: > > set HFI_PROPERTY_CONFIG_VENC_SYNC_FRAME_SEQUENCE_HEADER to FW > to support inband sequence header mode. > > Signed-off-by: Dikshita Agarwal > > Changes since v2: > - fixed Null pointer dereference (Stanimir, Fritz) > - added set

Re: [PATCH v2 00/19] scsi: libsas: Remove in_interrupt() check

2021-01-12 Thread Ahmed S. Darwish
On Tue, Jan 12, 2021 at 04:00:57PM +, John Garry wrote: ... > > I boot-tested on my machines which have hisi_sas v2 and v3 hw, and it's ok. > I will ask some guys to test a bit more. > Thanks a lot! > And generally the changes look ok. But I just have a slight concern that we > don't pass

[PATCH v6 5/5] drivers/soc/litex: make 'litex_[set|get]_reg()' methods private

2021-01-12 Thread Gabriel Somlo
The 'litex_[set|get]_reg()' methods use the 'reg_size' parameter to specify the width of the LiteX CSR (MMIO) register being accessed. Since 'u64' is the widest data being supported, the value of 'reg_size' MUST be between 1 and sizeof(u64), which SHOULD be checked at runtime if these methods are

[PATCH v6 1/5] drivers/soc/litex: move generic accessors to litex.h

2021-01-12 Thread Gabriel Somlo
Move generic LiteX CSR (MMIO) register accessors to litex.h and declare them as "static inline", in preparation for supporting 32-bit CSR subregisters and 64-bit CPUs. NOTE: this is a non-functional change. Signed-off-by: Gabriel Somlo --- drivers/soc/litex/litex_soc_ctrl.c | 73

[PATCH v6 3/5] drivers/soc/litex: s/LITEX_REG_SIZE/LITEX_SUBREG_ALIGN/g

2021-01-12 Thread Gabriel Somlo
The constant LITEX_REG_SIZE is renamed to the more descriptive LITEX_SUBREG_ALIGN (LiteX CSR subregisters are located at 32-bit aligned MMIO addresses). NOTE: this is a non-functional change. Signed-off-by: Gabriel Somlo --- include/linux/litex.h | 8 +--- 1 file changed, 5 insertions(+),

[PATCH v6 4/5] drivers/soc/litex: support 32-bit subregisters, 64-bit CPUs

2021-01-12 Thread Gabriel Somlo
Upstream LiteX now defaults to using 32-bit CSR subregisters (see https://github.com/enjoy-digital/litex/commit/a2b71fde). This patch expands on commit 22447a99c97e ("drivers/soc/litex: add LiteX SoC Controller driver"), adding support for handling both 8- and 32-bit LiteX CSR (MMIO)

[PATCH v6 0/5] drivers/soc/litex: support 32-bit subregisters, 64-bit CPUs

2021-01-12 Thread Gabriel Somlo
This series expands on commit 22447a99c97e ("drivers/soc/litex: add LiteX SoC Controller driver"), adding support for handling both 8- and 32-bit LiteX CSR (MMIO) subregisters, on both 32- and 64-bit CPUs. Notes v6: - split out s/LITEX_REG_SIZE/LITEX_SUBREG_ALIGN/g change into

[PATCH v6 2/5] drivers/soc/litex: separate MMIO from subregister offset calculation

2021-01-12 Thread Gabriel Somlo
Separate MMIO (read/write) access into _[read|write]_litex_subregister() static inline functions, leaving existing "READ|WRITE" macros to handle calculation of the subregister offset only. NOTE: this is a non-functional change. Signed-off-by: Gabriel Somlo --- include/linux/litex.h | 16

Re: [PATCH AUTOSEL 5.10 45/51] gcc-plugins: fix gcc 11 indigestion with plugins...

2021-01-12 Thread Kees Cook
This will need an additional fix, so please don't backport it yet. On Tue, Jan 12, 2021 at 07:55:27AM -0500, Sasha Levin wrote: > From: Valdis Klētnieks > > [ Upstream commit 67a5a68013056cbcf0a647e36cb6f4622fb6a470 ] > > Fedora Rawhide has started including gcc 11,and the g++ compiler >

Re: [net-next PATCH v3 09/15] device property: Introduce fwnode_get_id()

2021-01-12 Thread Saravana Kannan
On Tue, Jan 12, 2021 at 5:42 AM Calvin Johnson wrote: > > Using fwnode_get_id(), get the reg property value for DT node > or get the _ADR object value for ACPI node. > > Signed-off-by: Calvin Johnson > --- > > Changes in v3: > - Modified to retrieve reg property value for ACPI as well > -

Re: [PATCH] rcu: Correct cpu offline trace in rcutree_dying_cpu

2021-01-12 Thread Paul E. McKenney
On Mon, Jan 11, 2021 at 05:15:58PM +0530, Neeraj Upadhyay wrote: > Correctly trace whether the outgoing cpu blocks current gp in > rcutree_dying_cpu(). > > Signed-off-by: Neeraj Upadhyay Good catch, queued, thank you! Please see below for my usual wordsmithing, and please lat me know if I

Re: [PCI] dc83615370: will-it-scale.per_process_ops -1.2% regression

2021-01-12 Thread Kees Cook
On Tue, Jan 12, 2021 at 10:10:45PM +0800, kernel test robot wrote: > FYI, we noticed a -1.2% regression of will-it-scale.per_process_ops due to > commit: > > commit: dc83615370e7ebcb181a21a8ad13a77c278ab81c ("PCI: Fix PREL32 > relocations for LTO") >

Re: [PATCH 5/7] regulator: qcom-labibb: Implement short-circuit and over-current IRQs

2021-01-12 Thread Mark Brown
On Mon, Jan 11, 2021 at 10:06:18PM +0100, AngeloGioacchino Del Regno wrote: > ...which was already a requirement before I touched it. > Now, this leaves two options here: > 1. Keep the of_get_irq way, or > 2. Move the interrupts, change the documentation (currently, only > pmi8998.dtsi) and also

Re: [PATCH] ARM: dts: imx7d-flex-concentrator: fix pcf2127 reset

2021-01-12 Thread Alexandre Belloni
On 11/01/2021 16:15:37+0100, Bruno Thomsen wrote: > RTC pcf2127 device driver has changed default behaviour of the watchdog > feature in v5.11-rc1. Now you need to explicitly enable it with a > device tree property, "reset-source", when used in the board design. > > Fixes: 71ac13457d9d ("rtc:

Re: [PATCH] iommu: check for the deferred attach when attaching a device

2021-01-12 Thread Robin Murphy
On 2021-01-05 07:52, lijiang wrote: 在 2021年01月05日 11:55, lijiang 写道: Hi, Also add Joerg to cc list. Also add more people to cc list, Jerry Snitselaar and Tom Lendacky. Thanks. Thanks. Lianbo 在 2020年12月26日 13:39, Lianbo Jiang 写道: Currently, because domain attach allows to be deferred

Re: [PATCH v7 09/18] virt: acrn: Introduce I/O request management

2021-01-12 Thread Davidlohr Bueso
On Tue, 12 Jan 2021, Shuo A Liu wrote: On Mon 11.Jan'21 at 13:52:19 -0800, Davidlohr Bueso wrote: Could this not be done in process context instead? It could be. The original consideration with tasklet was more about performance as the I/O requests dispatching is a hot code path. I think irq

Re: [PATCH 8/9] KVM: arm64: vgic-v3: Expose GICR_TYPER.Last for userspace

2021-01-12 Thread Alexandru Elisei
Hi Eric, On 12/12/20 6:50 PM, Eric Auger wrote: > Commit 23bde34771f1 ("KVM: arm64: vgic-v3: Drop the > reporting of GICR_TYPER.Last for userspace") temporarily fixed > a bug identified when attempting to access the GICR_TYPER > register before the redistributor region setting but dropped > the

Re: Aarch64 EXT4FS inode checksum failures - seems to be weak memory ordering issues

2021-01-12 Thread Linus Torvalds
On Tue, Jan 12, 2021 at 5:20 AM Lukas Wunner wrote: > > > Variable declarations in for-loops is the only one I can think of. I > > think that would clean up some code (and some macros), but might not > > be compelling on its own. > > Anonymous structs/unions. I used to have a use case for that

Re: [PATCH v2] blk: avoid divide-by-zero with zero granularity

2021-01-12 Thread Feng Li
Hi Martin, I use the nvme-tcp as the host, the target is spdk nvme-tcp target, and set a wrong block size(i.g. bs=8), then the host prints this oops: [ 63.153018] nvme nvme0: creating 3 I/O queues. [ 63.181644] nvme nvme0: mapped 3/0/0 default/read/poll queues. [ 63.185568] nvme nvme0: new

Re: [PATCH V3] drivers: net: marvell: Fixed two spellings,controling to controlling and oen to one

2021-01-12 Thread Randy Dunlap
On 1/12/21 2:31 AM, Bhaskar Chowdhury wrote: > s/oen/one/ > s/controling/controlling/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap Thanks. > --- > Changes from V2 : Correct the versioning,mentioned both the changes > > drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.h | 2 +- >

Re: [PATCH v2 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-01-12 Thread Perry Yuan
Hi Barnabás, On 2021/1/12 0:07, Barnabás Pőcze wrote: Hi 2021. január 11., hétfő 14:42 keltezéssel, Perry Yuan írta: [...] +#define PRIVACY_PLATFORM_NAME "dell-privacy-acpi" +#define DELL_PRIVACY_GUID "6932965F-1671-4CEB-B988-D3AB0A901919" + +struct privacy_acpi_priv { + struct

Re: [PATCH v3] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-12 Thread Nathan Chancellor
Wendling/pgo-add-clang-s-Profile-Guided-Optimization-infrastructure/20210112-133315 > base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > a0d54b4f5b219fb31f0776e9f53aa137e78ae431 > config: x86_64-allyesconfig (attached as .config) > compiler: gcc-9 (Debian 9.3

Re: [PATCH v2 1/3] x86/mce: Avoid infinite loop for copy from user recovery

2021-01-12 Thread Andy Lutomirski
On Tue, Jan 12, 2021 at 9:16 AM Luck, Tony wrote: > > On Tue, Jan 12, 2021 at 09:00:14AM -0800, Andy Lutomirski wrote: > > > On Jan 11, 2021, at 2:21 PM, Luck, Tony wrote: > > > > > > On Mon, Jan 11, 2021 at 02:11:56PM -0800, Andy Lutomirski wrote: > > >> > > On Jan 11, 2021, at 1:45 PM,

[PATCH v3 3/3] ASoC: rt715:add micmute led state control supports

2021-01-12 Thread Perry Yuan
From: Perry Yuan Some new Dell system is going to support audio internal micphone privacy setting from hardware level with micmute led state changing When micmute hotkey pressed by user, soft mute will need to be enabled firstly in case of pop noise, and codec driver need to react to mic mute

[PATCH v3 2/3] x86/platform/dell-privacy-wmi: add document for dell privacy driver

2021-01-12 Thread Perry Yuan
From: Perry Yuan Describe the Dell Privacy feature capabilities and devices state class exposed by BIOS Signed-off-by: Perry Yuan --- .../testing/sysfs-platform-dell-privacy-wmi | 31 +++ 1 file changed, 31 insertions(+) create mode 100644

[PATCH v3 1/3] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-01-12 Thread Perry Yuan
From: Perry Yuan add support for dell privacy driver for the dell units equipped hardware privacy design, which protect users privacy of audio and camera from hardware level. once the audio or camera privacy mode enabled, any applications will not get any audio or video stream when user pressed

Re: [PATCH v2 1/3] x86/mce: Avoid infinite loop for copy from user recovery

2021-01-12 Thread Luck, Tony
On Tue, Jan 12, 2021 at 09:00:14AM -0800, Andy Lutomirski wrote: > > On Jan 11, 2021, at 2:21 PM, Luck, Tony wrote: > > > > On Mon, Jan 11, 2021 at 02:11:56PM -0800, Andy Lutomirski wrote: > >> > On Jan 11, 2021, at 1:45 PM, Tony Luck wrote: > >>> > >>> Recovery action when get_user()

Re: [PATCH v15 0/4] SELinux support for anonymous inodes and UFFD

2021-01-12 Thread Paul Moore
On Fri, Jan 8, 2021 at 5:22 PM Lokesh Gidra wrote: > > Userfaultfd in unprivileged contexts could be potentially very > useful. We'd like to harden userfaultfd to make such unprivileged use > less risky. This patch series allows SELinux to manage userfaultfd > file descriptors and in the future,

[PATCH v3 0/3] Dell hardware privacy implementation for dell laptop

2021-01-12 Thread Perry Yuan
From: Perry Yuan Hi All, This patch set is a new driver for dell mobile platform ,which has the hardware privacy feature. For micmute led control, the hotkey is Fn + F4, it is a hardware based mute state, and new privacy will prevent micphone void input from hardware layer, any application

Re: [PATCH -tip V3 0/8] workqueue: break affinity initiatively

2021-01-12 Thread Paul E. McKenney
On Mon, Jan 11, 2021 at 01:50:52PM -0800, Paul E. McKenney wrote: > On Mon, Jan 11, 2021 at 10:09:07AM -0800, Paul E. McKenney wrote: > > On Mon, Jan 11, 2021 at 06:16:39PM +0100, Peter Zijlstra wrote: > > > > > > While thinking more about this, I'm thinking a big part of the problem > > > is

Re: gdbserver + fsgsbase kaputt

2021-01-12 Thread Andy Lutomirski
On Tue, Jan 12, 2021 at 9:02 AM Metzger, Markus T wrote: > > > [ 26.990644] getreg: gs_base = 0xf7f8e000 > > [ 26.991694] getreg: GS=0x63, GSBASE=0xf7f8e000 > > [ 26.993117] PTRACE_SETREGS > > [ 26.993813] putreg: change gsbase from 0xf7f8e000 to 0x0 > > [ 26.995134] putreg: write

Re: [PATCH v2 03/19] scsi: libsas: Introduce a _gfp() variant of event notifiers

2021-01-12 Thread Sebastian A. Siewior
On 2021-01-12 15:45:12 [+], Christoph Hellwig wrote: > What is the problem with simply adding a gfp_t argument to the existing > calls? The end result of this series looks fine, but the way we get > there looks extremely cumbersome. Maybe I don't understand you fully but if you want to avoid

Re: [PATCH v4] certs: Add EFI_CERT_X509_GUID support for dbx entries

2021-01-12 Thread David Howells
How about the attached? I've changed the function names to something that I think reads better, but otherwise it's the same. David --- commit 8913866babb96fcfe452aac6042ca8862d4c0b53 Author: Eric Snowberg Date: Tue Sep 15 20:49:27 2020 -0400 certs: Add EFI_CERT_X509_GUID support for dbx

Re: [PATCH v2] blk: avoid divide-by-zero with zero granularity

2021-01-12 Thread Martin K. Petersen
Li, > If the physical_block_size and io_min is less than a sector, That's not supposed to happen. What device/driver is this? -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/1] mm: restore full accuracy in COW page reuse

2021-01-12 Thread Andy Lutomirski
On Mon, Jan 11, 2021 at 2:18 PM Linus Torvalds wrote: > > On Mon, Jan 11, 2021 at 11:19 AM Linus Torvalds > wrote: > Actually, what I think might be a better model is to actually > strengthen the rules even more, and get rid of GUP_PIN_COUNTING_BIAS > entirely. > > What we could do is just make

Re: [RFC PATCH v2] selinux: security: Move selinux_state to a separate page

2021-01-12 Thread Casey Schaufler
On 1/12/2021 1:36 AM, pna...@codeaurora.org wrote: > On 2021-01-08 22:41, Casey Schaufler wrote: >> On 1/8/2021 1:49 AM, Preeti Nagar wrote: >>> The changes introduce a new security feature, RunTime Integrity Check >>> (RTIC), designed to protect Linux Kernel at runtime. The motivation >>> behind

<    4   5   6   7   8   9   10   11   12   13   >