Re: linux-next: build warning after merge of the fscache tree

2021-03-02 Thread David Howells
Stephen Rothwell wrote: > After merging the fscache tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: > > fs/afs/file.c: In function 'afs_req_issue_op': > fs/afs/file.c:291:6: warning: unused variable 'ret' [-Wunused-variable] > 291 | int ret; > | ^~~ >

Re: linux-next: build failure after merge of the powerpc-fixes tree

2021-03-02 Thread Michael Ellerman
Uwe Kleine-König writes: > Hello, > > On 3/2/21 3:09 AM, Michael Ellerman wrote: >> Stephen Rothwell writes: >>> Hi all, >>> >>> After merging the powerpc-fixes tree, today's linux-next build (powerpc >>> allyesconfig) failed like this: >>> >>> drivers/net/ethernet/ibm/ibmvnic.c:5399:13: error: c

Re: linux-kernel janitorial RFP: Mark static arrays as const

2021-03-02 Thread Bernd Petrovitsch
Hi all! On 02/03/2021 18:42, Joe Perches wrote: [...] > - For instance: (head -10 of the git grep for file statics) > > drivers/accessibility/speakup/keyhelp.c:18:static u_short masks[] = { 32, 16, > 8, 4, 2, 1 }; > drivers/accessibility/speakup/keyhelp.c:26:static u_char funcvals[]

Re: [PATCH v1 0/3] driver core: Set fw_devlink=on take II

2021-03-02 Thread Saravana Kannan
gt; > > Mh, I'm on latest linux-next (next-20210302) and I've applied patch 3/3 > > and > > reverted commit 7007b745a508 ("PCI: layerscape: Convert to > > builtin_platform_driver()"). I'd assumed that PCIe shouldn't be working, > > right? B

[PATCH] v4l2-ctrls: Fix h264 hierarchical coding type menu ctrl

2021-03-02 Thread Stanimir Varbanov
Add a name of the menu and fill control type. Signed-off-by: Stanimir Varbanov --- drivers/media/v4l2-core/v4l2-ctrls.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c index 016cf6204cbb..5d99e2294335 100644

[PATCH] bus: mhi: core: Remove pre_init flag used for power purposes

2021-03-02 Thread Bhaumik Bhatt
Some controllers can choose to skip preparation for power up. In that case, device context is initialized based on the pre_init flag not being set during mhi_prepare_for_power_up(). There is no reason MHI host driver should maintain and provide controllers with two separate paths for preparing MHI.

Re: [PATCH v1 0/3] driver core: Set fw_devlink=on take II

2021-03-02 Thread Saravana Kannan
On Tue, Mar 2, 2021 at 2:24 PM Michael Walle wrote: > > Am 2021-03-02 22:11, schrieb Saravana Kannan: > > I think Patch 1 should fix [4] without [5]. Can you test the series > > please? > > Mh, I'm on latest linux-next (next-20210302) and I've applied

Re: [PATCH 2/2] Makefile: Only specify '--prefix=' when building with clang + GNU as

2021-03-02 Thread Nick Desaulniers
On Tue, Mar 2, 2021 at 2:09 PM Nick Desaulniers wrote: > > On Tue, Mar 2, 2021 at 2:02 PM Fangrui Song wrote: > > > > On 2021-03-02, Nathan Chancellor wrote: > > >When building with LLVM_IAS=1, there is no point to specifying > > >'--prefix=' because that flag is only used to find the cross assem

Re: [PATCH] gpio: regmap: move struct gpio_regmap definition

2021-03-02 Thread Linus Walleij
On Tue, Mar 2, 2021 at 7:14 PM Álvaro Fernández Rojas wrote: > I'm trying to add support for bcm63xx pin controllers, and Linus > suggested that I could use gpio regmap instead of adding duplicated code. > However, I need to access gpio_chip inside gpio_regmap to call > pinctrl_add_gpio_range() w

[PATCH] bus: mhi: core: Add missing checks for MMIO register entries

2021-03-02 Thread Bhaumik Bhatt
As per documentation, fields marked as (required) in an MHI controller structure need to be populated by the controller driver before calling mhi_register_controller(). Ensure all required fields are present in the controller before proceeding with the registration. Signed-off-by: Bhaumik Bhatt -

[PATCH 2/8] input: Documentation: corrections for event-codes.rst

2021-03-02 Thread Randy Dunlap
Fix hyphenation, typos, capitalization, and a referenced file name (.txt -> .rst). Signed-off-by: Randy Dunlap Cc: Dmitry Torokhov Cc: linux-in...@vger.kernel.org Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org --- Documentation/input/event-codes.rst | 10 +- 1 file changed, 5 inse

[PATCH 1/8] input: Documentation: corrections for input.rst

2021-03-02 Thread Randy Dunlap
Fix grammar, punctuation, and spelling. Signed-off-by: Randy Dunlap Cc: Dmitry Torokhov Cc: linux-in...@vger.kernel.org Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org --- Documentation/input/input.rst |8 1 file changed, 4 insertions(+), 4 deletions(-) --- linux-next-20210202.

[PATCH 3/8 RESEND] input: Documentation: update related file names in ff.rst

2021-03-02 Thread Randy Dunlap
Change other related documentation file names from .txt to .rst and be more explicit about their paths/locations. Signed-off-by: Randy Dunlap Cc: Dmitry Torokhov Cc: linux-in...@vger.kernel.org Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org Cc: Johann Deneux Cc: Anssi Hannula --- where is

[PATCH 8/8] input: Documentation: corrections for uinput.rst

2021-03-02 Thread Randy Dunlap
Fix a typo (supportinf -> supporting). Signed-off-by: Randy Dunlap Cc: Dmitry Torokhov Cc: linux-in...@vger.kernel.org Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org --- Documentation/input/uinput.rst |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20210202.orig/Doc

[PATCH 0/8] input: Documentation: corrections to Doc/input/ files

2021-03-02 Thread Randy Dunlap
Update several Documentation/input/ files for wording, punctutation, struct info, and file names. Cc: Dmitry Torokhov Cc: linux-in...@vger.kernel.org Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org [PATCH 1/8] input: Documentation: corrections for input.rst [PATCH 2/8] input: Documentation:

Re: [PATCH 4.9 000/134] 4.9.259-rc3 review

2021-03-02 Thread Florian Fainelli
On 3/2/21 11:27 AM, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.259 release. > There are 134 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses shou

[PATCH 7/8] input: Documentation: corrections for input-programming.rst

2021-03-02 Thread Randy Dunlap
Drop a repeated word. Fix punctuation of "eg." to "e.g." Fix punctuation of "ie" to "i.e." Add hyphentation to non-zero. Capitalize PM (for Power Management). Capitalize ID (for Identifier). Change "," in a run-on sentence to ";". Signed-off-by: Randy Dunlap Cc: Dmitry Torokhov Cc: linux-in...@v

[PATCH 6/8] input: Documentation: corrections for notifier.rst

2021-03-02 Thread Randy Dunlap
Add 'ledstate' to the keyboard_notifier_param struct info and tell which header file contains that struct. Signed-off-by: Randy Dunlap Cc: Dmitry Torokhov Cc: linux-in...@vger.kernel.org Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org --- Documentation/input/notifier.rst |3 ++- 1 file c

[PATCH 4/8] input: Documentation: corrections for gameport-programming.rst

2021-03-02 Thread Randy Dunlap
Use "E.g." instead of "Eg.". Use correct index for buttons[] array. Update all of struct gameport's descriptions. Signed-off-by: Randy Dunlap Cc: Dmitry Torokhov Cc: linux-in...@vger.kernel.org Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org --- Documentation/input/gameport-programming.rst |

[PATCH 5/8] input: Documentation: corrections for multi-touch-protocol.rst

2021-03-02 Thread Randy Dunlap
Correct hyphenation, spelling, and capitalization. Signed-off-by: Randy Dunlap Cc: Dmitry Torokhov Cc: linux-in...@vger.kernel.org Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org Cc: Henrik Rydberg --- Documentation/input/multi-touch-protocol.rst |8 1 file changed, 4 insertion

Re: [PATCH 1/2] Makefile: Remove '--gcc-toolchain' flag

2021-03-02 Thread Nick Desaulniers
On Tue, Mar 2, 2021 at 1:07 PM Nathan Chancellor wrote: > > This is not necessary anymore now that we specify '--prefix=', which > tells clang exactly where to find the GNU cross tools. This has been > verified with self compiled LLVM 10.0.1 and LLVM 13.0.0 as well as a > distribution version of L

Re: [PATCH] recordmcount: Fix the wrong use of w* in arm64_is_fake_mcount()

2021-03-02 Thread Steven Rostedt
On Tue, 2 Mar 2021 17:30:58 -0500 Steven Rostedt wrote: > I just realized that I received this patch twice, and thought it was the > same patch! Chen was three days ahead of you, so he get's the credit ;-) > > https://lore.kernel.org/r/20210222135840.56250-1-chenjun...@huawei.com I'm applying

Re: 5.11 regression: "ia64: add support for TIF_NOTIFY_SIGNAL" breaks ia64 boot

2021-03-02 Thread John Paul Adrian Glaubitz
Hi Sergei! On 3/2/21 11:26 PM, Sergei Trofimovich wrote: > Gave v5.12-rc1 a try today and got a similar boot failure around > hpsa queue initialization, but my failure is later: > https://dev.gentoo.org/~slyfox/configs/guppy-dmesg-5.12-rc1 > Maybe I get different error because I flipped on mos

Re: 5.12-rc1 regression: freezing iou-mgr/wrk failed

2021-03-02 Thread Jens Axboe
On 3/2/21 3:13 PM, Alex Xu (Hello71) wrote: > I tried 29be7fc03d ("io_uring: ensure that threads freeze on suspend") > and it seems to work OK. The system suspends fine and no errors are > printed to the kernel log. > > I am using Gentoo on the machine in question. > > I didn't test the other p

Re: 5.11 regression: "ia64: add support for TIF_NOTIFY_SIGNAL" breaks ia64 boot

2021-03-02 Thread Jens Axboe
On 3/2/21 3:07 PM, Sergei Trofimovich wrote: > On Tue, 23 Feb 2021 08:08:30 + > Sergei Trofimovich wrote: > >> On Mon, 22 Feb 2021 17:43:58 -0700 >> Jens Axboe wrote: >> >>> On 2/22/21 5:41 PM, Jens Axboe wrote: On 2/22/21 5:34 PM, Jens Axboe wrote: > On 2/22/21 4:53 PM, Serge

[PATCH] bus: mhi: core: Add missing checks for MMIO register entries

2021-03-02 Thread Bhaumik Bhatt
As per documentation, fields marked as (required) in an MHI controller structure need to be populated by the controller driver before calling mhi_register_controller(). Ensure all required fields are present in the controller before proceeding with the registration. Signed-off-by: Bhaumik Bhatt -

Re: [PATCH] recordmcount: Fix the wrong use of w* in arm64_is_fake_mcount()

2021-03-02 Thread Steven Rostedt
On Thu, 25 Feb 2021 16:01:17 + Will Deacon wrote: > On Thu, Feb 25, 2021 at 09:44:26AM -0500, Steven Rostedt wrote: > > This requires an acked-by from one of the ARM64 maintainers. > > > > -- Steve > > > > > > On Thu, 25 Feb 2021 22:07:47 +0800 > > Li Huafei wrote: > > > > > When cross

[tip:x86/mm] BUILD SUCCESS a78eda76b92b81ae3515bcda43a36d671e287c1c

2021-03-02 Thread kernel test robot
onfig i386defconfig mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a00

Re: [PATCH 5.4 000/337] 5.4.102-rc5 review

2021-03-02 Thread Florian Fainelli
On 3/2/21 11:28 AM, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.4.102 release. > There are 337 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses shou

Re: [RFC PATCH v5 19/19] virtio/vsock: update trace event for SEQPACKET

2021-03-02 Thread Steven Rostedt
On Thu, 18 Feb 2021 08:42:15 +0300 Arseny Krasnov wrote: Not sure if this was pulled in yet, but I do have a small issue with this patch. > @@ -69,14 +82,19 @@ TRACE_EVENT(virtio_transport_alloc_pkt, > __entry->type = type; > __entry->op = op; > __entry-

Re: [PATCH v1 0/3] driver core: Set fw_devlink=on take II

2021-03-02 Thread Michael Walle
Am 2021-03-02 22:11, schrieb Saravana Kannan: I think Patch 1 should fix [4] without [5]. Can you test the series please? Mh, I'm on latest linux-next (next-20210302) and I've applied patch 3/3 and reverted commit 7007b745a508 ("PCI: layerscape: Convert to builtin_platform_

linux-next: build warning after merge of the f2fs tree

2021-03-02 Thread Stephen Rothwell
Hi all, After merging the f2fs tree, today's linux-next build (x86_64 allmodconfig) produced this warning: fs/f2fs/sysfs.c:576:25: warning: 'f2fs_attr_ovp_segments' defined but not used [-Wunused-variable] 576 | static struct f2fs_attr f2fs_attr_##name = __ATTR(name, 0444, name##_show, NULL)

Re: [PATCH] mm/hugetlb: use some helper functions to cleanup code

2021-03-02 Thread Mike Kravetz
On 2/9/21 10:53 PM, Miaohe Lin wrote: > We could use pages_per_huge_page to get the number of pages per hugepage, > use get_hstate_idx to calculate hstate index, and use hstate_is_gigantic > to check if a hstate is gigantic to make code more succinct. > > Signed-off-by: Miaohe Lin These are all

[PATCH] Fix ld-version.sh script if LLD was built with LLD_VENDOR

2021-03-02 Thread Bernhard Rosenkränzer
If LLD was built with -DLLD_VENDOR="xyz", ld.lld --version output will prefix LLD_VENDOR. Since LLD_VENDOR can contain spaces, the LLD identifier isn't guaranteed to be $2 either. Adjust the version checker to handle such versions of lld. Signed-off-by: Bernhard Rosenkränzer --- scripts/ld-vers

Re: [PATCH v3 10/10] clocksource/drivers/hyper-v: Move handling of STIMER0 interrupts

2021-03-02 Thread Daniel Lezcano
On 02/03/2021 22:38, Michael Kelley wrote: > STIMER0 interrupts are most naturally modeled as per-cpu IRQs. But > because x86/x64 doesn't have per-cpu IRQs, the core STIMER0 interrupt > handling machinery is done in code under arch/x86 and Linux IRQs are > not used. Adding support for ARM64 means a

linux-next: build warning after merge of the fscache tree

2021-03-02 Thread Stephen Rothwell
Hi all, After merging the fscache tree, today's linux-next build (x86_64 allmodconfig) produced this warning: fs/afs/file.c: In function 'afs_req_issue_op': fs/afs/file.c:291:6: warning: unused variable 'ret' [-Wunused-variable] 291 | int ret; | ^~~ Introduced by commit 799fbdf9

Re: [PATCH v3 07/10] clocksource/drivers/hyper-v: Handle vDSO differences inline

2021-03-02 Thread Daniel Lezcano
On 02/03/2021 22:38, Michael Kelley wrote: > While the driver for the Hyper-V Reference TSC and STIMERs is architecture > neutral, vDSO is implemented for x86/x64, but not for ARM64. Current code > calls into utility functions under arch/x86 (and coming, under arch/arm64) > to handle the differenc

Re: [PATCH v3 08/10] clocksource/drivers/hyper-v: Handle sched_clock differences inline

2021-03-02 Thread Daniel Lezcano
On 02/03/2021 22:38, Michael Kelley wrote: > While the Hyper-V Reference TSC code is architecture neutral, the > pv_ops.time.sched_clock() function is implemented for x86/x64, but not > for ARM64. Current code calls a utility function under arch/x86 (and > coming, under arch/arm64) to handle the di

Re: 5.12-rc1 regression: freezing iou-mgr/wrk failed

2021-03-02 Thread Alex Xu (Hello71)
I tried 29be7fc03d ("io_uring: ensure that threads freeze on suspend") and it seems to work OK. The system suspends fine and no errors are printed to the kernel log. I am using Gentoo on the machine in question. I didn't test the other patches you supplied. Let me know if there's anything you

Re: [RFC PATCH v2 0/2] mm: fix races due to deferred TLB flushes

2021-03-02 Thread Peter Xu
On Fri, Dec 25, 2020 at 01:25:27AM -0800, Nadav Amit wrote: > From: Nadav Amit > > This patch-set went from v1 to RFCv2, as there is still an ongoing > discussion regarding the way of solving the recently found races due to > deferred TLB flushes. These patches are only sent for reference for now

Re: [RFC PATCH v2 0/2] mm: fix races due to deferred TLB flushes

2021-03-02 Thread Nadav Amit
> On Mar 2, 2021, at 2:13 PM, Peter Xu wrote: > > On Fri, Dec 25, 2020 at 01:25:27AM -0800, Nadav Amit wrote: >> From: Nadav Amit >> >> This patch-set went from v1 to RFCv2, as there is still an ongoing >> discussion regarding the way of solving the recently found races due to >> deferred TLB

Re: [PATCH v3 4/8] mm/rmap: Split migration into its own function

2021-03-02 Thread Zi Yan
On 26 Feb 2021, at 2:18, Alistair Popple wrote: > Migration is currently implemented as a mode of operation for > try_to_unmap_one() generally specified by passing the TTU_MIGRATION flag > or in the case of splitting a huge anonymous page TTU_SPLIT_FREEZE. > > However it does not have much in comm

Re: [PATCH 5.10 000/657] 5.10.20-rc4 review

2021-03-02 Thread Florian Fainelli
On 3/2/21 11:28 AM, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.10.20 release. > There are 657 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses shou

Re: [PATCH 2/2] Makefile: Only specify '--prefix=' when building with clang + GNU as

2021-03-02 Thread Nick Desaulniers
On Tue, Mar 2, 2021 at 2:02 PM Fangrui Song wrote: > > On 2021-03-02, Nathan Chancellor wrote: > >When building with LLVM_IAS=1, there is no point to specifying > >'--prefix=' because that flag is only used to find the cross assembler, > >which is clang itself when building with LLVM_IAS=1. All of

Re: 5.11 regression: "ia64: add support for TIF_NOTIFY_SIGNAL" breaks ia64 boot

2021-03-02 Thread Sergei Trofimovich
On Tue, 23 Feb 2021 08:08:30 + Sergei Trofimovich wrote: > On Mon, 22 Feb 2021 17:43:58 -0700 > Jens Axboe wrote: > > > On 2/22/21 5:41 PM, Jens Axboe wrote: > > > On 2/22/21 5:34 PM, Jens Axboe wrote: > > >> On 2/22/21 4:53 PM, Sergei Trofimovich wrote: > > >>> On Mon, 22 Feb 202

[PATCH v4 5/6] can: c_can: prepare to up the message objects number

2021-03-02 Thread Dario Binacchi
As pointed by commit c0a9f4d396c9 ("can: c_can: Reduce register access") the "driver casts the 16 message objects in stone, which is completely braindead as contemporary hardware has up to 128 message objects". The patch prepares the module to extend the number of message objects beyond the 32 cur

[PATCH v4 3/6] can: c_can: add a comment about IF_RX interface's use

2021-03-02 Thread Dario Binacchi
After reading the commit 640916db2bf7 ("can: c_can: Make it SMP safe") it may sound strange to see the IF_RX interface used by the can_inval_tx_object function. A comment was added to avoid any misunderstanding. Signed-off-by: Dario Binacchi --- Changes in v4: - Restore IF_RX interface. - Add a

[PATCH v4 4/6] can: c_can: use 32-bit write to set arbitration register

2021-03-02 Thread Dario Binacchi
The arbitration register is already set up with 32-bit writes in the other parts of the code except for this point. Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/net/can/c_can/c_can.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/can/c_can/

Re: [PATCH 2/2] Makefile: Only specify '--prefix=' when building with clang + GNU as

2021-03-02 Thread Fangrui Song
On 2021-03-02, Nathan Chancellor wrote: When building with LLVM_IAS=1, there is no point to specifying '--prefix=' because that flag is only used to find the cross assembler, which is clang itself when building with LLVM_IAS=1. All of the other tools are invoked directly from PATH or a full path

[PATCH v4 1/6] can: c_can: remove unused code

2021-03-02 Thread Dario Binacchi
Commit 9d23a9818cb1 ("can: c_can: Remove unused inline function") left behind C_CAN_MSG_OBJ_TX_LAST constant. Commit fa39b54ccf28 ("can: c_can: Get rid of pointless interrupts") left behind C_CAN_MSG_RX_LOW_LAST and C_CAN_MSG_OBJ_RX_SPLIT constants. The removed code also made a comment useless an

[PATCH v4 2/6] can: c_can: fix indentation

2021-03-02 Thread Dario Binacchi
Commit 524369e2391f ("can: c_can: remove obsolete STRICT_FRAME_ORDERING Kconfig option") left behind wrong indentation, fix it. Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/net/can/c_can/c_can.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net

[PATCH v4 0/6] can: c_can: add support to 64 message objects

2021-03-02 Thread Dario Binacchi
The D_CAN controller supports up to 128 messages. Until now the driver only managed 32 messages although Sitara processors and DRA7 SOC can handle 64. The series was tested on a beaglebone board. Note: I have not changed the type of tx_field (belonging to the c_can_priv structure) to atomic64_t

[PATCH v4 6/6] can: c_can: add support to 64 message objects

2021-03-02 Thread Dario Binacchi
D_CAN controller supports 16, 32, 64 or 128 message objects, comparing to 32 on C_CAN. AM335x/AM437x Sitara processors and DRA7 SOC all instantiate a D_CAN controller with 64 message objects, as described in the "DCAN features" subsection of the CAN chapter of their technical reference manuals. Th

Re: [PATCH v2] mm/hugetlb: remove redundant reservation check condition in alloc_huge_page()

2021-03-02 Thread Mike Kravetz
On 3/1/21 2:47 AM, Miaohe Lin wrote: > vma_resv_map(vma) checks if a reserve map is associated with the vma. The > routine vma_needs_reservation() will check vma_resv_map(vma) and return 1 > if no reserv map is present. map_chg is set to the return value of > vma_needs_reservation(). Therefore,

[PATCH 3/3] clk: socfpga: Convert to s10/agilex/n5x to use clk_hw

2021-03-02 Thread Dinh Nguyen
As recommended by Stephen Boyd, convert the Agilex/Stratix10/n5x clock driver to use the clk_hw registration method. Suggested-by: Stephen Boyd Signed-off-by: Dinh Nguyen --- drivers/clk/socfpga/clk-agilex.c | 114 ++- drivers/clk/socfpga/clk-gate-s10.c | 15 ++--

Re: [PATCH 1/2] Makefile: Remove '--gcc-toolchain' flag

2021-03-02 Thread Fangrui Song
Reviewed-by: Fangrui Song Thanks for the clean-up! --gcc-toolchain= is an obsscure way searching for GCC installation prefixes (--prefix). The logic is complex and different for different distributions/architectures. If we specify --prefix= (-B) explicitly, --gcc-toolchain is not needed. On 2

[PATCH v3 02/10] x86/hyper-v: Move hv_message_type to architecture neutral module

2021-03-02 Thread Michael Kelley
The definition of enum hv_message_type includes arch neutral and x86/x64-specific values. Ideally there would be a way to put the arch neutral values in an arch neutral module, and the arch specific values in an arch specific module. But C doesn't provide a way to extend enum types. As a compromise

[PATCH v3 03/10] Drivers: hv: Redo Hyper-V synthetic MSR get/set functions

2021-03-02 Thread Michael Kelley
Current code defines a separate get and set macro for each Hyper-V synthetic MSR used by the VMbus driver. Furthermore, the get macro can't be converted to a standard function because the second argument is modified in place, which is somewhat bad form. Redo this by providing a single get and a si

[PATCH v3 08/10] clocksource/drivers/hyper-v: Handle sched_clock differences inline

2021-03-02 Thread Michael Kelley
While the Hyper-V Reference TSC code is architecture neutral, the pv_ops.time.sched_clock() function is implemented for x86/x64, but not for ARM64. Current code calls a utility function under arch/x86 (and coming, under arch/arm64) to handle the difference. Change this approach to handle the diffe

Re: [Cocci] linux-kernel janitorial RFP: Mark static arrays as const

2021-03-02 Thread Julia Lawall
On Tue, 2 Mar 2021, Joe Perches wrote: > Here is a possible opportunity to reduce data usage in the kernel. Does it actually reduce data usage? julia > > $ git grep -P -n '^static\s+(?!const|struct)(?:\w+\s+){1,3}\w+\s*\[\s*\]' > drivers/ | \ > grep -v __initdata | \ > wc -l > 3250 > >

[PATCH 1/3] clk: socfpga: use clk_hw_register for a5/c5

2021-03-02 Thread Dinh Nguyen
As recommended by Stephen Boyd, convert the cyclone5/arria5 clock driver to use the clk_hw registration method. Suggested-by: Stephen Boyd Signed-off-by: Dinh Nguyen --- drivers/clk/socfpga/clk-gate.c | 11 +++ drivers/clk/socfpga/clk-periph.c | 8 drivers/clk/socfpga/clk-pl

[PATCH 2/3] clk: socfpga: arria10: convert to use clk_hw

2021-03-02 Thread Dinh Nguyen
As recommended by Stephen Boyd, convert the Arria10 clock driver to use the clk_hw registration method. Suggested-by: Stephen Boyd Signed-off-by: Dinh Nguyen --- drivers/clk/socfpga/clk-gate-a10.c | 8 drivers/clk/socfpga/clk-periph-a10.c | 11 ++- drivers/clk/socfpga/clk-pl

[PATCH v3 09/10] clocksource/drivers/hyper-v: Set clocksource rating based on Hyper-V feature

2021-03-02 Thread Michael Kelley
On x86/x64, the TSC clocksource is available in a Hyper-V VM only if Hyper-V provides the TSC_INVARIANT flag. The rating on the Hyper-V Reference TSC page clocksource is currently set so that it will not override the TSC clocksource in this case. Alternatively, if the TSC clocksource is not availa

[PATCH v3 10/10] clocksource/drivers/hyper-v: Move handling of STIMER0 interrupts

2021-03-02 Thread Michael Kelley
STIMER0 interrupts are most naturally modeled as per-cpu IRQs. But because x86/x64 doesn't have per-cpu IRQs, the core STIMER0 interrupt handling machinery is done in code under arch/x86 and Linux IRQs are not used. Adding support for ARM64 means adding equivalent code using per-cpu IRQs under arch

[PATCH v3 04/10] Drivers: hv: vmbus: Move hyperv_report_panic_msg to arch neutral code

2021-03-02 Thread Michael Kelley
With the new Hyper-V MSR set function, hyperv_report_panic_msg() can be architecture neutral, so move it out from under arch/x86 and merge into hv_kmsg_dump(). This move also avoids needing a separate implementation under arch/arm64. No functional change. Signed-off-by: Michael Kelley Reviewed-b

[PATCH v3 01/10] Drivers: hv: vmbus: Move Hyper-V page allocator to arch neutral code

2021-03-02 Thread Michael Kelley
The Hyper-V page allocator functions are implemented in an architecture neutral way. Move them into the architecture neutral VMbus module so a separate implementation for ARM64 is not needed. No functional change. Signed-off-by: Michael Kelley Reviewed-by: Boqun Feng --- arch/x86/hyperv/hv_in

[PATCH v3 07/10] clocksource/drivers/hyper-v: Handle vDSO differences inline

2021-03-02 Thread Michael Kelley
While the driver for the Hyper-V Reference TSC and STIMERs is architecture neutral, vDSO is implemented for x86/x64, but not for ARM64. Current code calls into utility functions under arch/x86 (and coming, under arch/arm64) to handle the difference. Change this approach to handle the difference i

[PATCH v3 05/10] Drivers: hv: vmbus: Handle auto EOI quirk inline

2021-03-02 Thread Michael Kelley
On x86/x64, Hyper-V provides a flag to indicate auto EOI functionality, but it doesn't on ARM64. Handle this quirk inline instead of calling into code under arch/x86 (and coming, under arch/arm64). No functional change. Signed-off-by: Michael Kelley Reviewed-by: Boqun Feng --- arch/x86/include

[PATCH v3 06/10] Drivers: hv: vmbus: Move handling of VMbus interrupts

2021-03-02 Thread Michael Kelley
VMbus interrupts are most naturally modelled as per-cpu IRQs. But because x86/x64 doesn't have per-cpu IRQs, the core VMbus interrupt handling machinery is done in code under arch/x86 and Linux IRQs are not used. Adding support for ARM64 means adding equivalent code using per-cpu IRQs under arch/

[PATCH v3 00/10] Refactor arch specific Hyper-V code

2021-03-02 Thread Michael Kelley
To support Linux guests on Hyper-V on multiple architectures, the original approach factored out all differences between Hyper-V on x86/x64 and Hyper-V on ARM64 into functions or #defines under arch/x86 and arch/arm64. Some of these differences are truly related to the architecture, but others are

Re: [PATCH 5.10 000/657] 5.10.20-rc4 review

2021-03-02 Thread Pavel Machek
Hi! > This is the start of the stable review cycle for the 5.10.20 release. > There are 657 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. CIP testing did not find any problems here (failures are ca

Re: [PATCH 4.4 00/92] 4.4.259-rc2 review

2021-03-02 Thread Pavel Machek
Hi! > This is the start of the stable review cycle for the 4.4.259 release. > There are 92 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. CIP testing did not find any problems here: https://gitlab.

Re: [PATCH 4.19 000/246] 4.19.178-rc4 review

2021-03-02 Thread Pavel Machek
Hi! > This is the start of the stable review cycle for the 4.19.178 release. > There are 246 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. CIP testing did not find any problems here: https://gitla

Re: [PATCH] firewire: prevent integer overflow on 32bit systems

2021-03-02 Thread Stefan Richter
On Mar 02 Dan Carpenter wrote: > In TCODE_STREAM_DATA mode, on 32bit systems, the "sizeof(*e) + > request->length" operation can overflow leading to memory corruption. > > Fixes: 18e9b10fcdc0 ("firewire: cdev: add closure to async stream ioctl") > Signed-off-by: Dan Carpenter > --- > drivers/fir

Re: possible deadlock in sk_clone_lock

2021-03-02 Thread Mike Kravetz
On 3/2/21 6:29 AM, Michal Hocko wrote: > On Tue 02-03-21 06:11:51, Shakeel Butt wrote: >> On Tue, Mar 2, 2021 at 1:44 AM Michal Hocko wrote: >>> >>> On Mon 01-03-21 17:16:29, Mike Kravetz wrote: On 3/1/21 9:23 AM, Michal Hocko wrote: > On Mon 01-03-21 08:39:22, Shakeel Butt wrote: >>

[PATCH v1 2/3] driver core: Update device link status properly for device_bind_driver()

2021-03-02 Thread Saravana Kannan
Device link status was not getting updated correctly when device_bind_driver() is called on a device. This causes a warning[1]. Fix this by updating device links that can be updated and dropping device links that can't be updated to a sensible state. [1] - https://lore.kernel.org/lkml/56f7d032-ba

[PATCH v1 1/3] driver core: Avoid pointless deferred probe attempts

2021-03-02 Thread Saravana Kannan
There's no point in adding a device to the deferred probe list if we know for sure that it doesn't have a matching driver. So, check if a device can match with a driver before adding it to the deferred probe list. Signed-off-by: Saravana Kannan --- drivers/base/dd.c | 6 ++ include/linu

[PATCH v1 3/3] Revert "Revert "driver core: Set fw_devlink=on by default""

2021-03-02 Thread Saravana Kannan
This reverts commit 3e4c982f1ce75faf5314477b8da296d2d00919df. Since all reported issues due to fw_devlink=on should be addressed by this series, revert the revert. fw_devlink=on Take II. Signed-off-by: Saravana Kannan --- drivers/base/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: XDP socket rings, and LKMM litmus tests

2021-03-02 Thread Alan Stern
On Tue, Mar 02, 2021 at 07:46:27PM +0100, Björn Töpel wrote: > Hi! > > Firstly; The long Cc-list is to reach the LKMM-folks. > > Some background; the XDP sockets use a ring-buffer to communicate > between the kernel and userland. It's a > single-consumer/single-producer ring, and described in > n

[PATCH 1/2] mm: disable LRU pagevec during the migration temporarily

2021-03-02 Thread Minchan Kim
LRU pagevec holds refcount of pages until the pagevec are drained. It could prevent migration since the refcount of the page is greater than the expection in migration logic. To mitigate the issue, callers of migrate_pages drains LRU pagevec via migrate_prep or lru_add_drain_all before migrate_page

[RESEND PATCH 2/3] mfd: lm3533: Constify static struct attribute_group

2021-03-02 Thread Rikard Falkeborn
The only usage of lm3533_attribute_group is to pass its address to sysfs_create_group() and sysfs_remove_group(), both which takes pointers to const attribute_group structs. Make it const to allow the compiler to put it in read-only memory. Done with the help of coccinelle. Signed-off-by: Rikard

[RESEND PATCH 3/3] mfd: pcf50633: Constify static struct attribute_group

2021-03-02 Thread Rikard Falkeborn
The only usage of pcf_attr_group is to pass its address to sysfs_create_group() and sysfs_remove_group(), both which takes pointers to const attribute_group structs. Make it const to allow the compiler to put it in read-only memory. Done with the help of coccinelle. Signed-off-by: Rikard Falkebor

[RESEND PATCH 0/3] drivers/mfd: Constify static attribute_group structs

2021-03-02 Thread Rikard Falkeborn
Seems the first submission somehow didn't make it to LKML, here's a resend. The only usage of the structs is to pass their address to sysfs_create_group() and sysfs_remove_group(), both which takes pointers to const attribute_group structs. Make them const to allow the compiler to put them in read

[PATCH v1 0/3] driver core: Set fw_devlink=on take II

2021-03-02 Thread Saravana Kannan
This series fixes the last few remaining issues reported when fw_devlink=on by default. Patch 1 is just [6] pulled in without changes into this series. It reduces some unnecessary probe reordering caused by a combination of fw_devlink and existing device link code. This fixes some issue caused by

[PATCH 2/2] mm: fs: Invalidate BH LRU during page migration

2021-03-02 Thread Minchan Kim
Pages containing buffer_heads that are in one of the per-CPU buffer_head LRU caches will be pinned and thus cannot be migrated. This can prevent CMA allocations from succeeding, which are often used on platforms with co-processors (such as a DSP) that can only use physically contiguous memory. It c

[tip:sched/core] BUILD SUCCESS c91b0dcb6482096e7af4adbf39cfe3296af74a78

2021-03-02 Thread kernel test robot
randconfig-a006-20210302 x86_64 randconfig-a001-20210302 x86_64 randconfig-a004-20210302 x86_64 randconfig-a002-20210302 x86_64 randconfig-a005-20210302 x86_64 randconfig-a003-20210302 i386 randconfig

Re: Why do kprobes and uprobes singlestep?

2021-03-02 Thread Andy Lutomirski
> On Mar 2, 2021, at 12:24 PM, Alexei Starovoitov > wrote: > > On Tue, Mar 2, 2021 at 10:38 AM Andy Lutomirski wrote: >> >> Is there something like a uprobe test suite? How maintained / >> actively used is uprobe? > > uprobe+bpf is heavily used in production. > selftests/bpf has only one

[RESEND PATCH 1/3] mfd: gateworks-gsc: Constify static struct attribute_group

2021-03-02 Thread Rikard Falkeborn
The only usage of attr_group is to pass its address to sysfs_create_group() and sysfs_remove_group(), both which takes pointers to const attribute_group structs. Make it const to allow the compiler to put it in read-only memory. Done with the help of coccinelle. Signed-off-by: Rikard Falkeborn -

[PATCH 1/2] Makefile: Remove '--gcc-toolchain' flag

2021-03-02 Thread Nathan Chancellor
This is not necessary anymore now that we specify '--prefix=', which tells clang exactly where to find the GNU cross tools. This has been verified with self compiled LLVM 10.0.1 and LLVM 13.0.0 as well as a distribution version of LLVM 11.1.0 without binutils in the LLVM toolchain locations. Signe

[PATCH 2/2] Makefile: Only specify '--prefix=' when building with clang + GNU as

2021-03-02 Thread Nathan Chancellor
When building with LLVM_IAS=1, there is no point to specifying '--prefix=' because that flag is only used to find the cross assembler, which is clang itself when building with LLVM_IAS=1. All of the other tools are invoked directly from PATH or a full path specified via the command line, which does

Re: [PATCH] sched: Optimize __calc_delta.

2021-03-02 Thread Josh Don
From: Clement Courbet A significant portion of __calc_delta time is spent in the loop shifting a u64 by 32 bits. Use `fls` instead of iterating. This is ~7x faster on benchmarks. The generic `fls` implementation (`generic_fls`) is still ~4x faster than the loop. Architectures that have a better

Re: [PATCH v1 1/5] mfd: intel_quark_i2c_gpio: revert "Constify static struct resources"

2021-03-02 Thread Rikard Falkeborn
On Tue, Mar 02, 2021 at 03:56:16PM +0200, Andy Shevchenko wrote: > The structures are used as place holders, so they are modified at run-time. > Obviously they may not be constants. > > BUG: unable to handle page fault for address: d0643220 > ... > CPU: 0 PID: 110 Comm: modprobe Not tainted

Re: [PATCH] ibmvnic: Fix possibly uninitialized old_num_tx_queues variable warning.

2021-03-02 Thread Sukadev Bhattiprolu
Michal Suchanek [msucha...@suse.de] wrote: > GCC 7.5 reports: > ../drivers/net/ethernet/ibm/ibmvnic.c: In function 'ibmvnic_reset_init': > ../drivers/net/ethernet/ibm/ibmvnic.c:5373:51: warning: 'old_num_tx_queues' > may be used uninitialized in this function [-Wmaybe-uninitialized] > ../drivers/n

Re: [PATCH] sched: Optimize __calc_delta.

2021-03-02 Thread Josh Don
On Fri, Feb 26, 2021 at 1:03 PM Peter Zijlstra wrote: > > On Fri, Feb 26, 2021 at 11:52:39AM -0800, Josh Don wrote: > > From: Clement Courbet > > > > A significant portion of __calc_delta time is spent in the loop > > shifting a u64 by 32 bits. Use a __builtin_clz instead of iterating. > > > > Th

[PATCH 6/7] media: controls: Log VP8 stateless control in .std_log

2021-03-02 Thread Ezequiel Garcia
Simply print the type of the control. Signed-off-by: Ezequiel Garcia --- drivers/media/v4l2-core/v4l2-ctrls.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c index 1a683f4fa978..0fc7180a47e9 100644 --- a/drivers/

Re: [PATCH 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

2021-03-02 Thread Pavel Machek
Hi! > This driver adds initial support for several devices from Siemens. It is > based on a platform driver introduced in an earlier commit. Ok. > diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile > index 2a698df9da57..c15e1e3c5958 100644 > --- a/drivers/leds/Makefile > +++ b/drivers/le

[PATCH 7/7] media: uapi: move VP8 stateless controls out of staging

2021-03-02 Thread Ezequiel Garcia
Until now, the VP8 V4L2 API was not exported as a public API, and only defined in a private media header (media/vp8-ctrls.h). The reason for this was a concern about the API not complete and ready to support VP8 decoding hardware accelerators. After reviewing the VP8 specification in detail, and

[PATCH 3/7] media: uapi: vp8: Add proper kernel-doc documentation

2021-03-02 Thread Ezequiel Garcia
In preparation for making the interface public, document all the structures. Signed-off-by: Ezequiel Garcia --- include/media/vp8-ctrls.h | 99 +++ 1 file changed, 99 insertions(+) diff --git a/include/media/vp8-ctrls.h b/include/media/vp8-ctrls.h index f2011

[PATCH 2/7] media: uapi: vp8: Rename v4l2_vp8_loopfilter to v4l2_vp8_loop_filter

2021-03-02 Thread Ezequiel Garcia
Rename to struct v4l2_vp8_loop_filter, which is closer to the VP8 syntax. This change is only cosmetics, but since this API is exposed to userspace, it's worth the trouble to get it consistent. Signed-off-by: Ezequiel Garcia --- .../userspace-api/media/v4l/ext-ctrls-codec.rst | 12 ++---

[PATCH 5/7] media: uapi: Move the VP8 stateless control type out of staging

2021-03-02 Thread Ezequiel Garcia
Move the VP8 stateless control types out of staging, and re-number it to avoid any confusion. Signed-off-by: Ezequiel Garcia --- include/media/vp8-ctrls.h | 1 - include/uapi/linux/videodev2.h | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/include/media/vp8-ctrls.h b/

  1   2   3   4   5   6   7   8   9   10   >