Re: [PATCH 5.10 000/156] 5.10.26-rc2 review

2021-03-22 Thread Samuel Zou
On 2021/3/22 23:19, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.10.26 release. There are 156 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be

Re: [PATCH] keys: Allow disabling read permissions for key possessor

2021-03-22 Thread Eric Biggers
On Mon, Mar 22, 2021 at 12:57:26PM +0300, Andrey Ryabinin wrote: > keyctl_read_key() has a strange code which allows possessor to read > key's payload regardless of READ permission status: > > $ keyctl add user test test @u > 196773443 > $ keyctl print 196773443 > test > $ keyctl describe

Re: [PATCH v2 1/3] perf-stat: introduce bperf, share hardware PMCs with BPF

2021-03-22 Thread Song Liu
> On Mar 19, 2021, at 11:41 AM, Arnaldo Carvalho de Melo > wrote: > > Em Thu, Mar 18, 2021 at 10:15:13PM +0100, Jiri Olsa escreveu: >> On Tue, Mar 16, 2021 at 02:18:35PM -0700, Song Liu wrote: >>> bperf is off by default. To enable it, pass --bpf-counters option to >>> perf-stat. bperf uses

Re: [PATCH 00/23] userfaultfd-wp: Support shmem and hugetlbfs

2021-03-22 Thread Peter Xu
On Mon, Mar 22, 2021 at 08:48:49PM -0400, Peter Xu wrote: > This patchset is based on tag v5.12-rc3-mmots-2021-03-17-22-26. To run the > selftest, need to apply the two patches to fix minor mode page leak: > > https://lore.kernel.org/lkml/20210322175132.36659-1-pet...@redhat.com/ >

Re: [PATCH 5.4 00/60] 5.4.108-rc1 review

2021-03-22 Thread Samuel Zou
On 2021/3/22 20:27, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.4.108 release. There are 60 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be

Re: [PATCH] crypto: poly1305: fix poly1305_core_setkey() declaration

2021-03-22 Thread Eric Biggers
On Mon, Mar 22, 2021 at 07:51:47PM +0100, Ard Biesheuvel wrote: > On Mon, 22 Mar 2021 at 18:05, Arnd Bergmann wrote: > > > > From: Arnd Bergmann > > > > gcc-11 points out a mismatch between the declaration and the definition > > of poly1305_core_setkey(): > > > >

[PATCH 23/23] userfaultfd/selftests: Enable uffd-wp for shmem/hugetlbfs

2021-03-22 Thread Peter Xu
After we added support for shmem and hugetlbfs, we can turn uffd-wp test on always now. Define HUGETLB_EXPECTED_IOCTLS to avoid using UFFD_API_RANGE_IOCTLS_BASIC, because UFFD_API_RANGE_IOCTLS_BASIC is normally a superset of capabilities, while the test may not satisfy them all. E.g., when

[PATCH 19/23] hugetlb/userfaultfd: Handle uffd-wp special pte in hugetlb pf handler

2021-03-22 Thread Peter Xu
Teach the hugetlb page fault code to understand uffd-wp special pte. For example, when seeing such a pte we need to convert any write fault into a read one (which is fake - we'll retry the write later if so). Meanwhile, for handle_userfault() we'll need to make sure we must wait for the special

[PATCH 22/23] mm/userfaultfd: Enable write protection for shmem & hugetlbfs

2021-03-22 Thread Peter Xu
We've had all the necessary changes ready for both shmem and hugetlbfs. Turn on all the shmem/hugetlbfs switches for userfaultfd-wp. Now we can remove the flags parameter for vma_can_userfault() since not used any more. Meanwhile, we can expand UFFD_API_RANGE_IOCTLS_BASIC with

[PATCH 20/23] hugetlb/userfaultfd: Allow wr-protect none ptes

2021-03-22 Thread Peter Xu
Teach hugetlbfs code to wr-protect none ptes just in case the page cache existed for that pte. Meanwhile we also need to be able to recognize a uffd-wp marker pte and remove it for uffd_wp_resolve. Since at it, introduce a variable "psize" to replace all references to the huge page size fetcher.

[PATCH 21/23] hugetlb/userfaultfd: Only drop uffd-wp special pte if required

2021-03-22 Thread Peter Xu
Just like what we've done with shmem uffd-wp special ptes, we shouldn't drop uffd-wp special swap pte for hugetlb too, only if we're going to unmap the whole vma, or we're punching a hole with safe locks held. For example, remove_inode_hugepages() is safe to drop uffd-wp ptes, because it has

[PATCH 18/23] mm/hugetlb: Introduce huge version of special swap pte helpers

2021-03-22 Thread Peter Xu
This is to let hugetlbfs be prepared to also recognize swap special ptes just like uffd-wp special swap ptes. Signed-off-by: Peter Xu --- mm/hugetlb.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index

ext2_set_link()->ext2_put_page() question

2021-03-22 Thread Ira Weiny
Jan, Why does ext2_set_link() need to call ext2_put_page()? I don't see any reason that we could not match up the ext2_put_page() calls with the ext2_find_entry(). Similarly am I missing something by moving the ext2_put_page() out of ext2_delete_entry()? See below patch. I'm in the process of

[PATCH 17/23] hugetlb/userfaultfd: Handle UFFDIO_WRITEPROTECT

2021-03-22 Thread Peter Xu
This starts from passing cp_flags into hugetlb_change_protection() so hugetlb will be able to handle MM_CP_UFFD_WP[_RESOLVE] requests. huge_pte_clear_uffd_wp() is introduced to handle the case where the UFFDIO_WRITEPROTECT is requested upon migrating huge page entries. Signed-off-by: Peter Xu

[PATCH 16/23] hugetlb/userfaultfd: Take care of UFFDIO_COPY_MODE_WP

2021-03-22 Thread Peter Xu
Firstly, pass the wp_copy variable into hugetlb_mcopy_atomic_pte() thoughout the stack. Then, apply the UFFD_WP bit if UFFDIO_COPY_MODE_WP is with UFFDIO_COPY. Introduce huge_pte_mkuffd_wp() for it. Note that similar to how we've handled shmem, we'd better keep setting the dirty bit even if

[PATCH 13/23] shmem/userfaultfd: Handle the left-overed special swap ptes

2021-03-22 Thread Peter Xu
Note that the special uffd-wp swap pte can be left over even if the page under the pte got evicted. Normally when evict a page, we will unmap the ptes by walking through the reverse mapping. However we never tracked such information for the special swap ptes because they're not real mappings but

[PATCH 15/23] hugetlb/userfaultfd: Hook page faults for uffd write protection

2021-03-22 Thread Peter Xu
Hook up hugetlbfs_fault() with the capability to handle userfaultfd-wp faults. We do this slightly earlier than hugetlb_cow() so that we can avoid taking some extra locks that we definitely don't need. Signed-off-by: Peter Xu --- mm/hugetlb.c | 19 +++ 1 file changed, 19

[PATCH 14/23] shmem/userfaultfd: Pass over uffd-wp special swap pte when fork()

2021-03-22 Thread Peter Xu
It should be handled similarly like other uffd-wp wr-protected ptes: we should pass it over when the dst_vma has VM_UFFD_WP armed, otherwise drop it. Signed-off-by: Peter Xu --- mm/memory.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/mm/memory.c

[PATCH 09/23] mm: Pass zap_flags into unmap_mapping_pages()

2021-03-22 Thread Peter Xu
Give unmap_mapping_pages() more power by allowing to specify a zap flag so that it can pass in more information than "whether we'd also like to zap cow pages". With the new flag, we can remove the even_cow parameter because even_cow==false equals to zap_flags==ZAP_FLAG_CHECK_MAPPING, while

[PATCH 11/23] shmem/userfaultfd: Allow wr-protect none pte for file-backed mem

2021-03-22 Thread Peter Xu
File-backed memory differs from anonymous memory in that even if the pte is missing, the data could still resides either in the file or in page/swap cache. So when wr-protect a pte, we need to consider none ptes too. We do that by installing the uffd-wp special swap pte as a marker. So when

[PATCH 12/23] shmem/userfaultfd: Allows file-back mem to be uffd wr-protected on thps

2021-03-22 Thread Peter Xu
We don't have "huge" version of PTE_SWP_UFFD_WP_SPECIAL, instead when necessary we split the thp if the huge page is uffd wr-protected previously. However split the thp is not enough, because file-backed thp is handled totally differently comparing to anonymous thps - rather than doing a real

[PATCH 10/23] shmem/userfaultfd: Persist uffd-wp bit across zapping for file-backed

2021-03-22 Thread Peter Xu
File-backed memory is prone to being unmapped at any time. It means all information in the pte will be dropped, including the uffd-wp flag. Since the uffd-wp info cannot be stored in page cache or swap cache, persist this wr-protect information by installing the special uffd-wp marker pte when

[PATCH 07/23] mm: Introduce zap_details.zap_flags

2021-03-22 Thread Peter Xu
Instead of trying to introduce one variable for every new zap_details fields, let's introduce a flag so that it can start to encode true/false informations. Let's start to use this flag first to clean up the only check_mapping variable. Firstly, the name "check_mapping" implies this is a

[PATCH 08/23] mm: Introduce ZAP_FLAG_SKIP_SWAP

2021-03-22 Thread Peter Xu
Firstly, the comment in zap_pte_range() is misleading because it checks against details rather than check_mappings, so it's against what the code did. Meanwhile, it's confusing too on not explaining why passing in the details pointer would mean to skip all swap entries. New user of zap_details

[PATCH 03/23] mm/userfaultfd: Introduce special pte for unmapped file-backed mem

2021-03-22 Thread Peter Xu
This patch introduces a very special swap-like pte for file-backed memories. Currently it's only defined for x86_64 only, but as long as any arch that can properly define the UFFD_WP_SWP_PTE_SPECIAL value as requested, it should conceptually work too. We will use this special pte to arm the ptes

[PATCH 05/23] shmem/userfaultfd: Handle uffd-wp special pte in page fault handler

2021-03-22 Thread Peter Xu
File-backed memories are prone to unmap/swap so the ptes are always unstable. This could lead to userfaultfd-wp information got lost when unmapped or swapped out on such types of memory, for example, shmem. To keep such an information persistent, we will start to use the newly introduced

[PATCH 06/23] mm: Drop first_index/last_index in zap_details

2021-03-22 Thread Peter Xu
The first_index/last_index parameters in zap_details are actually only used in unmap_mapping_range_tree(). At the meantime, this function is only called by unmap_mapping_pages() once. Instead of passing these two variables through the whole stack of page zapping code, remove them from

[PATCH 04/23] mm/swap: Introduce the idea of special swap ptes

2021-03-22 Thread Peter Xu
We used to have special swap entries, like migration entries, hw-poison entries, device private entries, etc. Those "special swap entries" reside in the range that they need to be at least swap entries first, and their types are decided by swp_type(entry). This patch introduces another idea

[PATCH 02/23] mm: Clear vmf->pte after pte_unmap_same() returns

2021-03-22 Thread Peter Xu
pte_unmap_same() will always unmap the pte pointer. After the unmap, vmf->pte will not be valid any more. We should clear it. It was safe only because no one is accessing vmf->pte after pte_unmap_same() returns, since the only caller of pte_unmap_same() (so far) is do_swap_page(), where

[PATCH 01/23] shmem/userfaultfd: Take care of UFFDIO_COPY_MODE_WP

2021-03-22 Thread Peter Xu
Firstly, pass wp_copy into shmem_mfill_atomic_pte() through the stack. Then apply the UFFD_WP bit properly when the UFFDIO_COPY on shmem is with UFFDIO_COPY_MODE_WP. One thing to mention is that shmem_mfill_atomic_pte() needs to set the dirty bit in pte even if UFFDIO_COPY_MODE_WP is set. The

Re: [PATCH] clocksource/drivers/timer-mediatek: optimize systimer irq clear flow on Mediatek Socs

2021-03-22 Thread Evan Benn
On Thu, Mar 4, 2021 at 11:07 AM Fengquan Chen wrote: > > 1)ensure systimer is enabled before clear and disable interrupt, which only > for systimer in Mediatek Socs. Why does the timer need to be enabled before the interrupt can be disabled? The datasheet I have does not suggest that this is

[PATCH] block/umem: convert tasklet to threaded irq

2021-03-22 Thread Davidlohr Bueso
Tasklets have long been deprecated as being too heavy on the system by running in irq context - and this is not a performance critical path. If a higher priority process wants to run, it must wait for the tasklet to finish before doing so. A more suitable equivalent is to converted to threaded irq

[PATCH 00/23] userfaultfd-wp: Support shmem and hugetlbfs

2021-03-22 Thread Peter Xu
This patchset is based on tag v5.12-rc3-mmots-2021-03-17-22-26. To run the selftest, need to apply the two patches to fix minor mode page leak: https://lore.kernel.org/lkml/20210322175132.36659-1-pet...@redhat.com/ https://lore.kernel.org/lkml/20210322204836.1650221-1-axelrasmus...@google.com/

Re: [PATCH v2] infiniband: Fix a use after free in isert_connect_request

2021-03-22 Thread Sagi Grimberg
Acked-by: Sagi Grimberg

Re: [PATCH 5.10 000/156] 5.10.26-rc2 review

2021-03-22 Thread Samuel Zou
On 2021/3/22 23:19, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.10.26 release. There are 156 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be

Re: [PATCH] RDMA/include: Mundane typo fixes throughout the file

2021-03-22 Thread Jason Gunthorpe
On Thu, Mar 18, 2021 at 03:34:53PM +0530, Bhaskar Chowdhury wrote: > s/proviee/provide/ > s/undelying/underlying/ > s/quesiton/question/ > s/drivr/driver/ > > Signed-off-by: Bhaskar Chowdhury > Acked-by: Randy Dunlap > --- > include/rdma/rdma_vt.h | 8 > 1 file changed, 4

Re: [PATCH] IB/hns: Fix a spelling

2021-03-22 Thread Jason Gunthorpe
On Mon, Mar 22, 2021 at 07:57:51AM +0530, Bhaskar Chowdhury wrote: > s/wubsytem/subsystem/ > > Signed-off-by: Bhaskar Chowdhury > Acked-by: Weihang Li > --- > .../devicetree/bindings/infiniband/hisilicon-hns-roce.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to

Re: [v1] drm/msm/disp/dpu1: icc path needs to be set before dpu runtime resume

2021-03-22 Thread Matthias Kaehlcke
On Mon, Mar 22, 2021 at 02:17:12AM -0700, Kalyan Thota wrote: > From: Kalyan Thota > > DPU runtime resume will request for a min vote on the AXI bus as > it is a necessary step before turning ON the AXI clock. > > The change does below > 1) Move the icc path set before requesting runtime

[PATCH] soundwire: intel: move to auxiliary bus

2021-03-22 Thread Bard Liao
From: Pierre-Louis Bossart Now that the auxiliary_bus exists, there's no reason to use platform devices as children of a PCI device any longer. This patch refactors the code by extending a basic auxiliary device with Intel link-specific structures that need to be passed between controller and

Re: [PATCH v6 05/14] dt-bindings: display: bridge: Add i.MX8qm/qxp display pixel link binding

2021-03-22 Thread Marcel Ziswiler
On Wed, 2021-03-17 at 11:42 +0800, Liu Ying wrote: > This patch adds bindings for i.MX8qm/qxp display pixel link. > > Reviewed-by: Rob Herring > Signed-off-by: Liu Ying > --- > v5->v6: > * No change. > > v4->v5: > * No change. > > v3->v4: > * No change. > > v2->v3: > * Add Rob's R-b tag. >

Re: [PATCH v6 03/14] dt-bindings: display: bridge: Add i.MX8qm/qxp pixel combiner binding

2021-03-22 Thread Marcel Ziswiler
On Wed, 2021-03-17 at 11:42 +0800, Liu Ying wrote: > This patch adds bindings for i.MX8qm/qxp pixel combiner. > > Reviewed-by: Rob Herring > Signed-off-by: Liu Ying > --- > v5->v6: > * No change. > > v4->v5: > * No change. > > v3->v4: > * No change. > > v2->v3: > * Add Rob's R-b tag. > >

Re: GTE - The hardware timestamping engine

2021-03-22 Thread Kent Gibson
On Mon, Mar 22, 2021 at 01:21:46PM -0700, Dipen Patel wrote: > Hi Linus and Kent, > > Thanks you so much for your valuable inputs and time, Please see below, my > follow ups. > > On 3/21/21 11:00 PM, Kent Gibson wrote: > > On Sat, Mar 20, 2021 at 12:56:36PM +0100, Linus Walleij wrote: > >> Hi

Re: [PATCH v4 1/3] KVM: nVMX: Sync L2 guest CET states between L1/L2

2021-03-22 Thread Yang Weijiang
On Tue, Mar 16, 2021 at 05:03:47PM +0800, Yang Weijiang wrote: Hi, Sean, Could you respond my below rely? I'm not sure how to proceed, thanks! > On Mon, Mar 15, 2021 at 09:45:11AM -0700, Sean Christopherson wrote: > > On Mon, Mar 15, 2021, Yang Weijiang wrote: > > > These fields are rarely

Re: [PATCH net] net: dsa: don't assign an error value to tag_ops

2021-03-22 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 22 Mar 2021 15:26:50 -0500 you wrote: > Use a temporary variable to hold the return value from > dsa_tag_driver_get() instead of assigning it to dst->tag_ops. Leaving > an error value in dst->tag_ops can result in

Re: [PATCH] isdn: capi: fix mismatched prototypes

2021-03-22 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 22 Mar 2021 17:44:29 +0100 you wrote: > From: Arnd Bergmann > > gcc-11 complains about a prototype declaration that is different > from the function definition: > > drivers/isdn/capi/kcapi.c:724:44: error: argument 2

Re: [PATCH 07/18] f2fs: convert to miscattr

2021-03-22 Thread Eric Biggers
On Wed, Feb 03, 2021 at 01:41:01PM +0100, Miklos Szeredi wrote: > @@ -3071,123 +3012,54 @@ static int f2fs_ioc_setproject(struct file *filp, > __u32 projid) > } > #endif > > -/* FS_IOC_FSGETXATTR and FS_IOC_FSSETXATTR support */ > - > -/* > - * To make a new on-disk f2fs i_flag gettable via

linux-next: manual merge of the opp tree with the v4l-dvb tree

2021-03-22 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the opp tree got a conflict in: drivers/media/platform/qcom/venus/pm_helpers.c between commit: 08b1cf474b7f ("media: venus: core, venc, vdec: Fix probe dependency error") from the v4l-dvb tree and commit: 857219ae4043 ("media: venus: Convert to use

Re: [PATCH v6 01/14] media: uapi: Add some RGB bus formats for i.MX8qm/qxp pixel combiner

2021-03-22 Thread Marcel Ziswiler
On Wed, 2021-03-17 at 11:42 +0800, Liu Ying wrote: > This patch adds RGB666_1X30_CPADLO, RGB888_1X30_CPADLO, RGB666_1X36_CPADLO > and RGB888_1X36_CPADLO bus formats used by i.MX8qm/qxp pixel combiner. > The RGB pixels with padding low per component are transmitted on a 30-bit > input bus(10-bit

Re: [PATCH 01/18] vfs: add miscattr ops

2021-03-22 Thread Eric Biggers
On Wed, Feb 03, 2021 at 01:40:55PM +0100, Miklos Szeredi wrote: > + * Verifying attributes involves retrieving current attributes with > + * i_op->miscattr_get(), this also allows initilaizing attributes that have initilaizing => initializing > +int vfs_miscattr_set(struct dentry *dentry, struct

RE: [PATCH 3/5] cifsd: add file operations

2021-03-22 Thread Namjae Jeon
> > > -Original Message- > > From: Namjae Jeon > > Sent: Sunday, March 21, 2021 10:14 PM > > To: linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > > c...@vger.kernel.org > > Cc: linux-cifsd-de...@lists.sourceforge.net; smfre...@gmail.com; > > senozhat...@chromium.org;

Re: [PATCH v6 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs

2021-03-22 Thread Marcel Ziswiler
Hi Liu I gave this a try however I believe I am still missing some piece as it throws the following during compilation of the device tree: arch/arm64/boot/dts/freescale/imx8qxp.dtsi:333.18-439.7: ERROR (phandle_references): /dpu@5618: Reference to non-existent node or label "dc0_irqsteer"

Re: [PATCH 2/2] KVM: x86/mmu: Ensure TLBs are flushed when yielding during NX zapping

2021-03-22 Thread Sean Christopherson
On Mon, Mar 22, 2021, Ben Gardon wrote: > On Fri, Mar 19, 2021 at 4:20 PM Sean Christopherson wrote: > > @@ -5960,19 +5963,21 @@ static void kvm_recover_nx_lpages(struct kvm *kvm) > > lpage_disallowed_link); > >

Re: [PATCH v30 07/12] landlock: Support filesystem access-control

2021-03-22 Thread Jann Horn
On Tue, Mar 16, 2021 at 9:43 PM Mickaël Salaün wrote: > Using Landlock objects and ruleset, it is possible to tag inodes > according to a process's domain. [...] > +static void release_inode(struct landlock_object *const object) > + __releases(object->lock) > +{ > + struct inode

Re: [PATCH v30 02/12] landlock: Add ruleset and domain management

2021-03-22 Thread Jann Horn
On Tue, Mar 16, 2021 at 9:43 PM Mickaël Salaün wrote: > A Landlock ruleset is mainly a red-black tree with Landlock rules as > nodes. This enables quick update and lookup to match a requested > access, e.g. to a file. A ruleset is usable through a dedicated file > descriptor (cf. following

Re: [PATCH -next] x86: Fix unused variable 'msr_val' warning

2021-03-22 Thread Ingo Molnar
* Michael Kelley wrote: > From: Ingo Molnar Sent: Monday, March 22, 2021 > 2:08 PM > > > > * Xu Yihang wrote: > > > > > Fixes the following W=1 kernel build warning(s): > > > arch/x86/hyperv/hv_spinlock.c:28:16: warning: variable 'msr_val' set but > > > not used [- > >

Re: [PATCH] bpf: avoid old-style declaration warnings

2021-03-22 Thread KP Singh
On Mon, Mar 22, 2021 at 10:52 PM Arnd Bergmann wrote: > > From: Arnd Bergmann > > gcc -Wextra wants type modifiers in the normal order: > > kernel/bpf/bpf_lsm.c:70:1: error: 'static' is not at beginning of declaration > [-Werror=old-style-declaration] >70 | const static struct

RE: [PATCH 3/5] cifsd: add file operations

2021-03-22 Thread Namjae Jeon
> On Mon, Mar 22, 2021 at 02:13:42PM +0900, Namjae Jeon wrote: > > This adds file operations and buffer pool for cifsd. > > Some random notes: > > > +static void rollback_path_modification(char *filename) { > > + if (filename) { > > + filename--; > > + *filename = '/'; >

[PATCH] clkdev: remove unnecessary __ref annotations

2021-03-22 Thread Rasmus Villemoes
clkdev_alloc and vclkdev_alloc do not call any functions living in .init.text (nor are there comments as to when and why that would be safe). The original annotation dates back to when the code was imported from ARM in 6d803ba736ab, and AFAICT the last reason to have the annotation vanished with

Re: [PATCH 3/5] cifsd: add file operations

2021-03-22 Thread Sergey Senozhatsky
On (21/03/22 17:09), Matthew Wilcox wrote: > On Mon, Mar 22, 2021 at 06:03:21PM +0900, Sergey Senozhatsky wrote: > > On (21/03/22 08:15), Matthew Wilcox wrote: > > > > > > What's the scenario for which your allocator performs better than slub > > > > > > > IIRC request and reply buffers can be

Re: [PATCH] xsysace: Remove SYSACE driver

2021-03-22 Thread Davidlohr Bueso
Hi, On Mon, 09 Nov 2020, Michal Simek wrote: Sysace IP is no longer used on Xilinx PowerPC 405/440 and Microblaze systems. The driver is not regularly tested and very likely not working for quite a long time that's why remove it. Is there a reason this patch was never merged? can the driver

Re: [PATCH -tip v4 08/12] arm: kprobes: Make a space for regs->ARM_pc at kretprobe_trampoline

2021-03-22 Thread Masami Hiramatsu
On Mon, 22 Mar 2021 15:41:18 +0900 Masami Hiramatsu wrote: > Change kretprobe_trampoline to make a space for regs->ARM_pc so that > kretprobe_trampoline_handler can call instruction_pointer_set() > safely. BTW, if kretprobe_trampoline is replaced with the assembly code, I think it should fill

Re: [PATCH net-next v2 2/2] net: ipa: fix IPA validation

2021-03-22 Thread Alex Elder
On 3/22/21 5:56 PM, Andrew Lunn wrote: The solution is to create a user space tool inside the drivers/net/ipa directory that will link with the kernel source files and will perform all the basic one-time checks I want to make. Hi Alex Have you found any other driver doing this? Where do they

Re: [RFC 2/7] ath10k: Add support to process rx packet in thread

2021-03-22 Thread Ben Greear
On 7/22/20 6:00 AM, Felix Fietkau wrote: On 2020-07-22 14:55, Johannes Berg wrote: On Wed, 2020-07-22 at 14:27 +0200, Felix Fietkau wrote: I'm considering testing a different approach (with mt76 initially): - Add a mac80211 rx function that puts processed skbs into a list instead of handing

Re: [selftests] e48d82b67a: BUG_TestSlub_RZ_alloc(Not_tainted):Redzone_overwritten

2021-03-22 Thread Vlastimil Babka
On 3/17/21 7:53 PM, David Rientjes wrote: > On Wed, 17 Mar 2021, Vlastimil Babka wrote: >> > >> > [ 22.154049] random: get_random_u32 called from >> > __kmem_cache_create+0x23/0x3e0 with crng_init=0 >> > [ 22.154070] random: get_random_u32 called from >> >

Re: [PATCH v2 0/4] drm/bridge: ti-sn65dsi86: Support EDID reading

2021-03-22 Thread Laurent Pinchart
Hi Stephen, On Mon, Nov 02, 2020 at 05:15:24PM -0800, Stephen Boyd wrote: > Quoting Sam Ravnborg (2020-11-01 09:37:41) > > Hi Stephen. > > > > On Thu, Oct 29, 2020 at 06:17:34PM -0700, Stephen Boyd wrote: > > > This patch series cleans up the DDC code a little bit so that > > > it is more

Re: [PATCH 3/3] powerpc/mm/hash: Avoid multiple HPT resize-downs on memory hotunplug

2021-03-22 Thread David Gibson
On Fri, Mar 12, 2021 at 04:29:41AM -0300, Leonardo Bras wrote: > During memory hotunplug, after each LMB is removed, the HPT may be > resized-down if it would map a max of 4 times the current amount of memory. > (2 shifts, due to introduced histeresis) > > It usually is not an issue, but it can

Re: [PATCH -tip v4 12/12] tracing: Show kretprobe unknown indicator only for kretprobe_trampoline

2021-03-22 Thread Masami Hiramatsu
Hi Steve, On Mon, 22 Mar 2021 11:11:42 -0400 Steven Rostedt wrote: > On Mon, 22 Mar 2021 15:42:02 +0900 > Masami Hiramatsu wrote: > > > ftrace shows "[unknown/kretprobe'd]" indicator all addresses in the > > kretprobe_trampoline, but the modified address by kretprobe should > > be only

Re: [PATCH] mm, thp: Relax the VM_DENYWRITE constraint on file-backed THPs

2021-03-22 Thread Song Liu
On Mon, Mar 22, 2021 at 3:00 PM Collin Fijalkovich wrote: > > Transparent huge pages are supported for read-only non-shmem filesystems, > but are only used for vmas with VM_DENYWRITE. This condition ensures that > file THPs are protected from writes while an application is running > (ETXTBSY).

linux-next: manual merge of the v4l-dvb tree with the hwmon-staging tree

2021-03-22 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the v4l-dvb tree got a conflict in: MAINTAINERS between commit: 38f15506d965 ("hwmon: add driver for NZXT Kraken X42/X52/X62/X72") from the hwmon-staging tree and commit: be157db0a3d8 ("media: Add maintainer for IMX jpeg v4l2 driver") from the

[PATCH v4 net-next 11/11] net: ocelot: replay switchdev events when joining bridge

2021-03-22 Thread Vladimir Oltean
From: Vladimir Oltean The premise of this change is that the switchdev port attributes and objects offloaded by ocelot might have been missed when we are joining an already existing bridge port, such as a bonding interface. The patch pulls these switchdev attributes and objects from the bridge,

[PATCH v4 net-next 07/11] net: dsa: pass extack to dsa_port_{bridge,lag}_join

2021-03-22 Thread Vladimir Oltean
From: Vladimir Oltean This is a pretty noisy change that was broken out of the larger change for replaying switchdev attributes and objects at bridge join time, which is when these extack objects are actually used. Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli Reviewed-by:

[PATCH v4 net-next 10/11] net: ocelot: call ocelot_netdevice_bridge_join when joining a bridged LAG

2021-03-22 Thread Vladimir Oltean
From: Vladimir Oltean Similar to the DSA situation, ocelot supports LAG offload but treats this scenario improperly: ip link add br0 type bridge ip link add bond0 type bond ip link set bond0 master br0 ip link set swp0 master bond0 We do the same thing as we do there, which is to simulate a

[PATCH v4 net-next 09/11] net: dsa: sync up switchdev objects and port attributes when joining the bridge

2021-03-22 Thread Vladimir Oltean
From: Vladimir Oltean If we join an already-created bridge port, such as a bond master interface, then we can miss the initial switchdev notifications emitted by the bridge for this port, while it wasn't offloaded by anybody. Signed-off-by: Vladimir Oltean --- net/dsa/dsa_priv.h | 3 +++

[PATCH v4 net-next 08/11] net: dsa: inherit the actual bridge port flags at join time

2021-03-22 Thread Vladimir Oltean
From: Vladimir Oltean DSA currently assumes that the bridge port starts off with this constellation of bridge port flags: - learning on - unicast flooding on - multicast flooding on - broadcast flooding on just by virtue of code copy-pasta from the bridge layer (new_nbp). This was a simple

[PATCH v4 net-next 03/11] net: bridge: add helper to replay port and host-joined mdb entries

2021-03-22 Thread Vladimir Oltean
From: Vladimir Oltean I have a system with DSA ports, and udhcpcd is configured to bring interfaces up as soon as they are created. I create a bridge as follows: ip link add br0 type bridge As soon as I create the bridge and udhcpcd brings it up, I also have avahi which automatically starts

[PATCH v4 net-next 05/11] net: bridge: add helper to replay VLANs installed on port

2021-03-22 Thread Vladimir Oltean
From: Vladimir Oltean Currently this simple setup with DSA: ip link add br0 type bridge vlan_filtering 1 ip link add bond0 type bond ip link set bond0 master br0 ip link set swp0 master bond0 will not work because the bridge has created the PVID in br_add_if -> nbp_vlan_init, and it has

[PATCH v4 net-next 06/11] net: dsa: call dsa_port_bridge_join when joining a LAG that is already in a bridge

2021-03-22 Thread Vladimir Oltean
From: Vladimir Oltean DSA can properly detect and offload this sequence of operations: ip link add br0 type bridge ip link add bond0 type bond ip link set swp0 master bond0 ip link set bond0 master br0 But not this one: ip link add br0 type bridge ip link add bond0 type bond ip link set bond0

[PATCH v4 net-next 04/11] net: bridge: add helper to replay port and local fdb entries

2021-03-22 Thread Vladimir Oltean
From: Vladimir Oltean When a switchdev port starts offloading a LAG that is already in a bridge and has an FDB entry pointing to it: ip link set bond0 master br0 bridge fdb add dev bond0 00:01:02:03:04:05 master static ip link set swp0 master bond0 the switchdev driver will have no idea that

[PATCH v4 net-next 02/11] net: bridge: add helper to retrieve the current ageing time

2021-03-22 Thread Vladimir Oltean
From: Vladimir Oltean The SWITCHDEV_ATTR_ID_BRIDGE_AGEING_TIME attribute is only emitted from: sysfs/ioctl/netlink -> br_set_ageing_time -> __set_ageing_time therefore not at bridge port creation time, so: (a) switchdev drivers have to hardcode the initial value for the address ageing

[PATCH v4 net-next 01/11] net: bridge: add helper for retrieving the current bridge port STP state

2021-03-22 Thread Vladimir Oltean
From: Vladimir Oltean It may happen that we have the following topology with DSA or any other switchdev driver with LAG offload: ip link add br0 type bridge stp_state 1 ip link add bond0 type bond ip link set bond0 master br0 ip link set swp0 master bond0 ip link set swp1 master bond0 STP

[PATCH v4 net-next 00/11] Better support for sandwiched LAGs with bridge and DSA

2021-03-22 Thread Vladimir Oltean
From: Vladimir Oltean Changes in v4: - Added missing EXPORT_SYMBOL_GPL - Using READ_ONCE(fdb->dst) - Split patches into (a) adding the bridge helpers (b) making DSA use them - br_mdb_replay went back to the v1 approach where it allocated memory in atomic context - Created a

Re: [External] : Re: [LKP] Re: [locking/qspinlock] 0e8d8f4f12: stress-ng.zero.ops_per_sec -9.7% regression

2021-03-22 Thread Alex Kogan
> On Mar 22, 2021, at 7:15 PM, Alex Kogan wrote: > > Many thanks to Zhengjun Xing for the help in reproducing the issue. > > On our system, the regression is less than 7% (the numbers are below), > however, > at least at the full capacity, the numbers are very stable. This allowed me > to

Re: [PATCH v5 00/14] Add BLK_CTL support for i.MX8MP

2021-03-22 Thread Adam Ford
On Wed, Mar 3, 2021 at 4:54 AM Marek Vasut wrote: > > On 3/3/21 11:47 AM, Abel Vesa wrote: > > On 20-11-03 13:18:12, Abel Vesa wrote: > >> The BLK_CTL according to HW design is basically the wrapper of the entire > >> function specific group of IPs and holds GPRs that usually cannot be placed >

Re: [PATCH] powerpc/asm: Fix a typo

2021-03-22 Thread Michael Ellerman
Randy Dunlap writes: > On 3/22/21 4:32 AM, Bhaskar Chowdhury wrote: >> >> s/poiner/pointer/ >> >> Signed-off-by: Bhaskar Chowdhury > > Acked-by: Randy Dunlap > > However, it would be a GOOD THING to collect multiple similar > patches that are in e.g. arch/powerpc/ and send them as one patch >

[PATCH] kbuild: Merge module sections if and only if CONFIG_LTO_CLANG is enabled

2021-03-22 Thread Sean Christopherson
Merge module sections only when using Clang LTO. With gcc-10, merging sections does not appear to update the symbol tables for the module, e.g. 'readelf -s' shows the value that a symbol would have had, if sections were not merged. The stale symbol table breaks gdb's function disassambler, and

Re: [PATCH v4 0/3] net: dsa: lantiq: add support for xRX300 and xRX330

2021-03-22 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Mon, 22 Mar 2021 21:37:14 +0100 you wrote: > Changed since v3: > * fixed last compilation warning > > Changed since v2: > * fixed compilation warnings > * removed example bindings for xrx330 >

Re: [PATCH v3 2/3] net: ethernet: actions: Add Actions Semi Owl Ethernet MAC driver

2021-03-22 Thread Andrew Lunn
> +static void owl_emac_set_multicast(struct net_device *netdev, int count) > +{ > + struct owl_emac_priv *priv = netdev_priv(netdev); > + struct netdev_hw_addr *ha; > + int index = 0; > + > + if (count <= 0) { > + priv->mcaddr_list.count = 0; > + return; >

RE: [PATCH -next] x86: Fix unused variable 'msr_val' warning

2021-03-22 Thread Michael Kelley
From: Ingo Molnar Sent: Monday, March 22, 2021 2:08 PM > > * Xu Yihang wrote: > > > Fixes the following W=1 kernel build warning(s): > > arch/x86/hyperv/hv_spinlock.c:28:16: warning: variable 'msr_val' set but > > not used [- > Wunused-but-set-variable] > > unsigned long msr_val; > > > >

[tip: x86/cleanups] x86/fpu/math-emu: Fix function cast warning

2021-03-22 Thread tip-bot2 for Arnd Bergmann
The following commit has been merged into the x86/cleanups branch of tip: Commit-ID: 279d56abc67ed7568168cb31bf1c7d735efc89a7 Gitweb: https://git.kernel.org/tip/279d56abc67ed7568168cb31bf1c7d735efc89a7 Author:Arnd Bergmann AuthorDate:Mon, 22 Mar 2021 22:48:19 +01:00

[tip: x86/boot] x86/boot/tboot: Avoid Wstringop-overread-warning

2021-03-22 Thread tip-bot2 for Arnd Bergmann
The following commit has been merged into the x86/boot branch of tip: Commit-ID: cdc34cb8f25d3125d30868376b8eae6fe690119b Gitweb: https://git.kernel.org/tip/cdc34cb8f25d3125d30868376b8eae6fe690119b Author:Arnd Bergmann AuthorDate:Mon, 22 Mar 2021 17:02:40 +01:00

[tip: x86/boot] x86/boot/compressed: Avoid gcc-11 -Wstringop-overread warning

2021-03-22 Thread tip-bot2 for Arnd Bergmann
The following commit has been merged into the x86/boot branch of tip: Commit-ID: e14cfb3bdd0f82147d09e9f46bedda6302f28ee1 Gitweb: https://git.kernel.org/tip/e14cfb3bdd0f82147d09e9f46bedda6302f28ee1 Author:Arnd Bergmann AuthorDate:Mon, 22 Mar 2021 17:02:39 +01:00

[tip: locking/core] static_call: Fix function type mismatch

2021-03-22 Thread tip-bot2 for Arnd Bergmann
The following commit has been merged into the locking/core branch of tip: Commit-ID: 335c73e7c8f7deb23537afbbbe4f8ab48bd5de52 Gitweb: https://git.kernel.org/tip/335c73e7c8f7deb23537afbbbe4f8ab48bd5de52 Author:Arnd Bergmann AuthorDate:Mon, 22 Mar 2021 22:42:24 +01:00

Re: [RFC PATCH 5/8] hugetlb: change free_pool_huge_page to remove_pool_huge_page

2021-03-22 Thread Mike Kravetz
On 3/22/21 7:31 AM, Michal Hocko wrote: > On Fri 19-03-21 15:42:06, Mike Kravetz wrote: > [...] >> @@ -2090,9 +2084,15 @@ static void return_unused_surplus_pages(struct hstate >> *h, >> while (nr_pages--) { >> h->resv_huge_pages--; >> unused_resv_pages--; >> -

Re: [PATCH net] net: dsa: don't assign an error value to tag_ops

2021-03-22 Thread Florian Fainelli
On 3/22/2021 1:26 PM, George McCollister wrote: > Use a temporary variable to hold the return value from > dsa_tag_driver_get() instead of assigning it to dst->tag_ops. Leaving > an error value in dst->tag_ops can result in deferencing an invalid > pointer when a deferred switch configuration

RE: [PATCH 2/5] cifsd: add server-side procedures for SMB3

2021-03-22 Thread Namjae Jeon
> On Mon, Mar 22, 2021 at 09:47:13AM +0300, Dan Carpenter wrote: > > On Mon, Mar 22, 2021 at 02:13:41PM +0900, Namjae Jeon wrote: > > > +static unsigned char > > > +asn1_octet_decode(struct asn1_ctx *ctx, unsigned char *ch) { > > > + if (ctx->pointer >= ctx->end) { > > > + ctx->error =

Re: [PATCH v3] usb: dwc3: gadget: Prevent EP queuing while stopping transfers

2021-03-22 Thread Wesley Cheng
Hi Andy, On 3/22/2021 2:14 PM, Andy Shevchenko wrote: > On Mon, Mar 22, 2021 at 10:06 PM Wesley Cheng wrote: >> >> Hi Andy, >> >> On 3/22/2021 12:34 PM, Andy Shevchenko wrote: >>> On Mon, Mar 22, 2021 at 8:49 PM Wesley Cheng wrote: Hi Andy, On 3/22/2021 5:48 AM, Andy

RE: [PATCH 2/5] cifsd: add server-side procedures for SMB3

2021-03-22 Thread Namjae Jeon
> On Mon, Mar 22, 2021 at 02:13:41PM +0900, Namjae Jeon wrote: > > +static unsigned char > > +asn1_octet_decode(struct asn1_ctx *ctx, unsigned char *ch) { > > + if (ctx->pointer >= ctx->end) { > > + ctx->error = ASN1_ERR_DEC_EMPTY; > > + return 0; > > + } > > + *ch =

Re: [PATCH v3 03/25] x86/sgx: Wipe out EREMOVE from sgx_free_epc_page()

2021-03-22 Thread Kai Huang
On Mon, 22 Mar 2021 23:37:26 +0100 Borislav Petkov wrote: > On Tue, Mar 23, 2021 at 11:06:43AM +1300, Kai Huang wrote: > > This path is called by host SGX driver only, so yes this leaking is done by > > host enclaves only. > > Yes, so I was told. > > > This patch is purpose is to break EREMOVE

Re: [PATCH 02/11] x86: tboot: avoid Wstringop-overread-warning

2021-03-22 Thread Ingo Molnar
* Martin Sebor wrote: > > I.e. the real workaround might be to turn off the > > -Wstringop-overread-warning, > > until GCC-11 gets fixed? > > In GCC 10 -Wstringop-overread is a subset of -Wstringop-overflow. > GCC 11 breaks it out as a separate warning to make it easier to > control. Both

Re: [PATCH] arm64: dts: ls1028a: fix optee node

2021-03-22 Thread Li Yang
On Thu, Mar 18, 2021 at 3:36 AM Michael Walle wrote: > > Don't enable the optee node in the SoC include. It is an optional > component and actually, if enabled, breaks boards which doesn't have it. Hi Shawn, Shall we make this a general rule? I see quite a few SoC dtsi files are having the

<    1   2   3   4   5   6   7   8   9   10   >