Re: [PATCH] cifs: Remove useless variable

2021-04-08 Thread Steve French
merged into cifs-2.6.git for-next On Thu, Apr 8, 2021 at 3:33 AM Jiapeng Chong wrote: > > Fix the following gcc warning: > > fs/cifs/cifsacl.c:1097:8: warning: variable ‘nmode’ set but not used > [-Wunused-but-set-variable]. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- >

Re: [PATCH v2 12/21] ipmi: kcs_bmc: Strip private client data from struct kcs_bmc

2021-04-08 Thread Zev Weiss
On Fri, Mar 19, 2021 at 01:27:43AM CDT, Andrew Jeffery wrote: >Move all client-private data out of `struct kcs_bmc` into the KCS client >implementation. > >With this change the KCS BMC core code now only concerns itself with >abstract `struct kcs_bmc` and `struct kcs_bmc_client` types, achieving

Re: [PATCH v2 00/21] ipmi: Allow raw access to KCS devices

2021-04-08 Thread Joel Stanley
On Thu, 8 Apr 2021 at 23:47, Andrew Jeffery wrote: > On Thu, 8 Apr 2021, at 21:44, Corey Minyard wrote: > > On Thu, Apr 08, 2021 at 10:27:46AM +0930, Andrew Jeffery wrote: > > > > 1. It begins with patches 1-5 put together by Chia-Wei, which I've > > > > rebased on v5.12-rc2. These fix the

Re: [PATCH -next v2 1/2] mm/debug_vm_pgtable: Move {pmd/pud}_huge_tests out of CONFIG_TRANSPARENT_HUGEPAGE

2021-04-08 Thread Anshuman Khandual
On 4/6/21 10:18 AM, Shixin Liu wrote: > v1->v2: > Modified the commit message. Please avoid change log in the commit message, it should be after '---' below the SOB statement. > > The functions {pmd/pud}_set_huge and {pmd/pud}_clear_huge ars not dependent > on THP. typo

Re: [PATCH -next] ARM: spear: Fix build error with CONFIG_ARCH_SPEAR3XX

2021-04-08 Thread Viresh Kumar
On 09-04-21, 09:55, Chen Lifu wrote: > commit 77f983a9df42 ("spi: pl022: Use GPIOs looked up by the core") > deleted 'struct pl022_ssp_controller' member 'num_chipselect'. > We get build error when CONFIG_ARCH_SPEAR3XX is set: > arch/arm/mach-spear/spear3xx.c:42:3: error: 'struct

RE: [PATCH 2/3] fpga: dfl: Add DFL bus driver for Altera SPI Master

2021-04-08 Thread Wu, Hao
> > > > > > > > + > > > > > > > > +static void dfl_spi_altera_remove(struct dfl_device *dfl_dev) > > > > > > > > +{ > > > > > > > > +struct dfl_altera_spi *aspi = dev_get_drvdata(_dev->dev); > > > > > > > > + > > > > > > > > +platform_device_unregister(aspi->altr_spi); > > > > > > > > +} > > > > >

Re: [PATCH v2 11/21] ipmi: kcs_bmc: Split headers into device and client

2021-04-08 Thread Zev Weiss
On Fri, Mar 19, 2021 at 01:27:42AM CDT, Andrew Jeffery wrote: >Strengthen the distinction between code that abstracts the >implementation of the KCS behaviours (device drivers) and code that >exploits KCS behaviours (clients). Neither needs to know about the APIs >required by the other, so provide

Re: [PATCH v4 1/1] of: unittest: overlay: ensure proper alignment of copied FDT

2021-04-08 Thread Frank Rowand
On 4/8/21 9:20 PM, Guenter Roeck wrote: > On 4/8/21 3:53 PM, Frank Rowand wrote: >> On 4/8/21 4:54 PM, Guenter Roeck wrote: >>> On 4/8/21 2:28 PM, Rob Herring wrote: Applying now so this gets into linux-next this week. >>> The patch doesn't apply on top of today's -next; it

RE: [PATCH v3 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-08 Thread Haiyang Zhang
> -Original Message- > From: David Miller > Sent: Thursday, April 8, 2021 8:41 PM > To: Dexuan Cui > Cc: k...@kernel.org; KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; wei@kernel.org; Wei Liu > ; net...@vger.kernel.org; l...@kernel.org; > and...@lunn.ch;

Re: [PATCH v2 09/21] ipmi: kcs_bmc: Split out kcs_bmc_cdev_ipmi

2021-04-08 Thread Zev Weiss
On Fri, Mar 19, 2021 at 01:27:40AM CDT, Andrew Jeffery wrote: >Take steps towards defining a coherent API to separate the KCS device >drivers from the userspace interface. Decreasing the coupling will >improve the separation of concerns and enable the introduction of >alternative userspace

Re: [PATCH] fs: cifs: Remove repeated struct declaration

2021-04-08 Thread Steve French
merged into cifs-2.6.git for-next On Thu, Apr 8, 2021 at 9:47 PM Wan Jiabing wrote: > > struct cifs_writedata is declared twice. > One is declared at 209th line. > And struct cifs_writedata is defined blew. > The declaration hear is not needed. Remove the duplicate. > > Signed-off-by: Wan

[PATCH] fs: Optimized file struct to improve performance

2021-04-08 Thread Shaokun Zhang
From: Yuqi Jin In the syscall process, @f_count and @f_mod are frequently used, if we put them together with each other and they will share the same cacheline. It is useful for the performance. syscall of unixbench is tested on Intel 8180. before this patch 80 CPUs in system; running 80

[RFC PATCH v3 7/8] vfio/type1: Add selective DMA faulting support

2021-04-08 Thread Shenming Lu
Some devices only allow selective DMA faulting. Similar to the selective dirty page tracking, the vendor driver can call vfio_pin_pages() to indicate the non-faultable scope, we add a new struct vfio_range to record it, then when the IOPF handler receives any page request out of the scope, we can

[RFC PATCH v3 6/8] vfio/type1: No need to statically pin and map if IOPF enabled

2021-04-08 Thread Shenming Lu
If IOPF enabled for the VFIO container, there is no need to statically pin and map the entire DMA range, we can do it on demand. And unmap according to the IOPF mapped bitmap when removing vfio_dma. Note that we still mark all pages dirty even if IOPF enabled, we may add IOPF-based fine grained

[RFC PATCH v3 8/8] vfio: Add nested IOPF support

2021-04-08 Thread Shenming Lu
To set up nested mode, drivers such as vfio_pci need to register a handler to receive stage/level 1 faults from the IOMMU, but since currently each device can only have one iommu dev fault handler, and if stage 2 IOPF is already enabled (VFIO_IOMMU_ENABLE_IOPF), we choose to update the registered

[RFC PATCH v3 3/8] vfio/type1: Add an MMU notifier to avoid pinning

2021-04-08 Thread Shenming Lu
To avoid pinning pages when they are mapped in IOMMU page tables, we add an MMU notifier to tell the addresses which are no longer valid and try to unmap them. Signed-off-by: Shenming Lu --- drivers/vfio/vfio_iommu_type1.c | 112 +++- 1 file changed, 109

[RFC PATCH v3 5/8] vfio/type1: VFIO_IOMMU_ENABLE_IOPF

2021-04-08 Thread Shenming Lu
Since enabling IOPF for devices may lead to a slow ramp up of performance, we add an ioctl VFIO_IOMMU_ENABLE_IOPF to make it configurable. And the IOPF enabling of a VFIO device includes setting IOMMU_DEV_FEAT_IOPF and registering the VFIO IOPF handler. Note that VFIO_IOMMU_DISABLE_IOPF is not

[RFC PATCH v3 4/8] vfio/type1: Pre-map more pages than requested in the IOPF handling

2021-04-08 Thread Shenming Lu
To optimize for fewer page fault handlings, we can pre-map more pages than requested at once. Note that IOPF_PREMAP_LEN is just an arbitrary value for now, which we could try further tuning. Signed-off-by: Shenming Lu --- drivers/vfio/vfio_iommu_type1.c | 131 ++--

[RFC PATCH v3 2/8] vfio/type1: Add a page fault handler

2021-04-08 Thread Shenming Lu
VFIO manages the DMA mapping itself. To support IOPF (on-demand paging) for VFIO (IOMMU capable) devices, we add a VFIO page fault handler to serve the reported page faults from the IOMMU driver. Signed-off-by: Shenming Lu --- drivers/vfio/vfio_iommu_type1.c | 114

[RFC PATCH v3 0/8] Add IOPF support for VFIO passthrough

2021-04-08 Thread Shenming Lu
Hi, Requesting for your comments and suggestions. :-) The static pinning and mapping problem in VFIO and possible solutions have been discussed a lot [1, 2]. One of the solutions is to add I/O Page Fault support for VFIO devices. Different from those relatively complicated software approaches

[RFC PATCH v3 1/8] iommu: Evolve the device fault reporting framework

2021-04-08 Thread Shenming Lu
This patch follows the discussion here: https://lore.kernel.org/linux-acpi/YAaxjmJW+ZMvrhac@myrica/ Besides SVA/vSVA, such as VFIO may also enable (2nd level) IOPF to remove pinning restriction. In order to better support more scenarios of using device faults, we extend

Re: [PATCH 5/5] x86/speculation: Add PSF mitigation kernel parameters

2021-04-08 Thread Randy Dunlap
On 4/7/21 5:50 AM, Ramakrishna Saripalli wrote: > From: Ramakrishna Saripalli > > PSF mitigation introduces new kernel parameters. > > The kernel parameters for PSF mitigation are modeled > after spec_store_bypass_disable. Maybe too much copy-pasta. See below. > > Signed-off-by: Ramakrishna

[PATCH v4] binder: tell userspace to dump current backtrace when detected oneway spamming

2021-04-08 Thread Hang Lu
When async binder buffer got exhausted, some normal oneway transactions will also be discarded and may cause system or application failures. By that time, the binder debug information we dump may not be relevant to the root cause. And this issue is difficult to debug if without the backtrace of

Re: [PATCH -next v2 2/2] mm/debug_vm_pgtable: Remove redundant pfn_{pmd/pte}() and fix one comment mistake

2021-04-08 Thread Anshuman Khandual
On 4/6/21 10:19 AM, Shixin Liu wrote: > v1->v2: > Remove redundant pfn_pte() and fold two patch to one. Change log should always be after the '---' below the SOB statement for git am to ignore them. Please avoid adding them in the commit messages. > > Remove redundant pfn_{pmd/pte}() and fix

Re: [PATCH v3 1/4] kernfs: move revalidate to be near lookup

2021-04-08 Thread kernel test robot
Hi Ian, I love your patch! Yet something to improve: [auto build test ERROR on driver-core/driver-core-testing] [also build test ERROR on v5.12-rc6 next-20210408] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base

Re: [PATCH v2 05/21] soc: aspeed: Adapt to new LPC device tree layout

2021-04-08 Thread Joel Stanley
On Fri, 19 Mar 2021 at 06:28, Andrew Jeffery wrote: > > From: "Chia-Wei, Wang" > > Add check against LPC device v2 compatible string to > ensure that the fixed device tree layout is adopted. > The LPC register offsets are also fixed accordingly. > > Signed-off-by: Chia-Wei Wang > Reviewed-by:

[PATCH v4 1/2] KVM: arm64: Move CMOs from user_mem_abort to the fault handlers

2021-04-08 Thread Yanan Wang
We currently uniformly permorm CMOs of D-cache and I-cache in function user_mem_abort before calling the fault handlers. If we get concurrent guest faults(e.g. translation faults, permission faults) or some really unnecessary guest faults caused by BBM, CMOs for the first vcpu are necessary while

[PATCH v4 0/2] KVM: arm64: Improve efficiency of stage2 page table

2021-04-08 Thread Yanan Wang
Hi, This series makes some efficiency improvement of stage2 page table code, and there are some test results to quantify the benefit of each patch. Changelogs: v3->v4: - perform D-cache flush if we are not mapping device memory - rebased on top of mainline v5.12-rc6 - v3:

[PATCH v4 2/2] KVM: arm64: Distinguish cases of memcache allocations completely

2021-04-08 Thread Yanan Wang
With a guest translation fault, the memcache pages are not needed if KVM is only about to install a new leaf entry into the existing page table. And with a guest permission fault, the memcache pages are also not needed for a write_fault in dirty-logging time if KVM is only about to update the

Re: [PATCH v2 04/21] pinctrl: aspeed-g5: Adapt to new LPC device tree layout

2021-04-08 Thread Joel Stanley
On Fri, 19 Mar 2021 at 06:28, Andrew Jeffery wrote: > > From: "Chia-Wei, Wang" > > Add check against LPC device v2 compatible string to > ensure that the fixed device tree layout is adopted. > The LPC register offsets are also fixed accordingly. > > Signed-off-by: Chia-Wei Wang > Reviewed-by:

Re: New 'make dtbs_check W=1' warnings

2021-04-08 Thread Florian Fainelli
On 4/8/2021 8:08 AM, Arnd Bergmann wrote: > Greetings to all Arm platform maintainers, > > I've just gone through the DT merges I've received so far and, with a > little help from Rob, > managed to run 'make dtbs_check W=1' before and after, to see what > warnings we get. > The good news is

linux-next: build failure after merge of the drm tree

2021-04-08 Thread Stephen Rothwell
Hi all, After merging the drm tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/gpu/drm/i915/display/intel_dp_link_training.c:43:13: error: redefinition of 'intel_dp_reset_lttpr_common_caps' 43 | static void intel_dp_reset_lttpr_common_caps(struct intel_dp

Re: [PATCH v2 03/21] ipmi: kcs: aspeed: Adapt to new LPC DTS layout

2021-04-08 Thread Joel Stanley
On Fri, 19 Mar 2021 at 06:28, Andrew Jeffery wrote: > > From: "Chia-Wei, Wang" > > Add check against LPC device v2 compatible string to > ensure that the fixed device tree layout is adopted. > The LPC register offsets are also fixed accordingly. > > Signed-off-by: Chia-Wei Wang > Reviewed-by:

Re: [PATCH 3/3] powerpc/mm/hash: Avoid multiple HPT resize-downs on memory hotunplug

2021-04-08 Thread Leonardo Bras
Hello David, thanks for commenting. On Tue, 2021-03-23 at 10:45 +1100, David Gibson wrote: > > @@ -805,6 +808,10 @@ static int resize_hpt_for_hotplug(unsigned long > > new_mem_size, bool shrinking) > >   if (shrinking) { > > > > + /* When batch removing entries, only resizes HPT at

Re: [PATCH v2 1/6] dt-bindings: devapc: Update bindings

2021-04-08 Thread Nina Wu
Hi, Rob On Thu, 2021-04-08 at 15:43 -0500, Rob Herring wrote: > On Thu, Apr 01, 2021 at 02:38:02PM +0800, Nina Wu wrote: > > From: Nina Wu > > Every change is an 'update'. Perhaps mention mt8192 in the subject. > OK. I will try to make it clear in the next version. > > > > To support newer

Re: [PATCH v4 3/7] regulator: IRQ based event/error notification helpers

2021-04-08 Thread Kees Cook
On Wed, Apr 07, 2021 at 03:50:15PM +0300, Andy Shevchenko wrote: > On Wed, Apr 7, 2021 at 12:49 PM Vaittinen, Matti > wrote: > > On Wed, 2021-04-07 at 12:10 +0300, Andy Shevchenko wrote: > > > On Wed, Apr 7, 2021 at 8:02 AM Matti Vaittinen > > > wrote: > > > > On Wed, 2021-04-07 at 01:44 +0300,

Re: [PATCH v2 01/21] dt-bindings: aspeed-lpc: Remove LPC partitioning

2021-04-08 Thread Joel Stanley
On Fri, 19 Mar 2021 at 06:28, Andrew Jeffery wrote: > > From: "Chia-Wei, Wang" > > The LPC controller has no concept of the BMC and the Host partitions. > This patch fixes the documentation by removing the description on LPC > partitions. The register offsets illustrated in the DTS node examples

Re: [PATCH 2/2] pm: allow drivers to drop #ifdef and __maybe_unused from pm callbacks

2021-04-08 Thread Masahiro Yamada
On Fri, Apr 9, 2021 at 6:30 AM Arnd Bergmann wrote: > > On Thu, Apr 8, 2021 at 11:00 PM Masahiro Yamada wrote: > > > > Drivers typically surround suspend and resume callbacks with #ifdef > > CONFIG_PM(_SLEEP) or mark them as __maybe_unused in order to avoid > > -Wunused-const-variable warnings.

Re: [PATCH 4/4] mm/hugeltb: handle the error case in hugetlb_fix_reserve_counts()

2021-04-08 Thread Miaohe Lin
On 2021/4/9 7:25, Mike Kravetz wrote: > On 4/2/21 2:32 AM, Miaohe Lin wrote: >> A rare out of memory error would prevent removal of the reserve map region >> for a page. hugetlb_fix_reserve_counts() handles this rare case to avoid >> dangling with incorrect counts. Unfortunately,

[PATCH v6 6/6] w1: ds2438: support for writing to offset register

2021-04-08 Thread Luiz Sampaio
Added a sysfs entry to support writing to the offset register on page1. This register is used to calibrate the chip canceling offset errors in the current ADC. This means that, over time, reading the IAD register will not return the correct current measurement, it will have an offset. Writing to

[PATCH v6 5/6] w1: ds2438: adding support for reading page1

2021-04-08 Thread Luiz Sampaio
Added a sysfs entry to support reading the page1 registers. This registers contain Elapsed Time Meter (ETM) data, which shows for how long the chip is on, as well as an Offset Register data, which can be used to calibrate the current measurement of the chip. Signed-off-by: Luiz Sampaio ---

[PATCH v6 2/6] w1: ds2438: fixed if brackets coding style issue

2021-04-08 Thread Luiz Sampaio
Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c

[PATCH v6 4/6] w1: ds2438: fixing bug that would always get page0

2021-04-08 Thread Luiz Sampaio
The purpose of the w1_ds2438_get_page function is to get the register values at the page passed as the pageno parameter. However, the page0 was hardcoded, such that the function always returned the page0 contents. Fixed so that the function can retrieve any page. Signed-off-by: Luiz Sampaio ---

[PATCH v6 3/6] w1: ds2438: fixed a coding style issue

2021-04-08 Thread Luiz Sampaio
Changed the permissions to preferred octal style. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index 56e53a748059..ccb06b8c2d78 100644 ---

[PATCH v6 1/6] w1: ds2438: fixed a coding style issue

2021-04-08 Thread Luiz Sampaio
There is an if statement and, if the function goes into it, it returns. So, the next else is not required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c

[PATCH v6 0/9] w1: ds2438: adding support for calibration of current measurements

2021-04-08 Thread Luiz Sampaio
The following patches aim to make a user able to calibrate the current measurement of the DS2438. This chip uses a offset register in page1, which is added to the current register to give the user the current measurement. If this value is wrong, the user will get an offset current value, even if

[PATCH v3 4/4] docs: hwmon: (smpro-hwmon) Add documentation

2021-04-08 Thread Quan Nguyen
Add documentation for the Ampere(R)'s Altra(R) SMpro hwmon driver. Signed-off-by: Thu Nguyen Signed-off-by: Quan Nguyen --- Documentation/hwmon/index.rst | 1 + Documentation/hwmon/smpro-hwmon.rst | 101 2 files changed, 102 insertions(+) create mode

[PATCH v3 3/4] hwmon: smpro: Add Ampere's Altra smpro-hwmon driver

2021-04-08 Thread Quan Nguyen
This commit adds support for Ampere SMpro hwmon driver. This driver supports accessing various CPU sensors provided by the SMpro co-processor including temperature, power, voltages, and current. Signed-off-by: Quan Nguyen --- drivers/hwmon/Kconfig | 8 + drivers/hwmon/Makefile |

[PATCH v3 2/4] mfd: simple-mfd-i2c: Adds Ampere's Altra SMpro support

2021-04-08 Thread Quan Nguyen
Adds an MFD driver for SMpro found on the Mt.Jade hardware reference platform with Ampere's Altra processor family. Signed-off-by: Quan Nguyen --- drivers/mfd/Kconfig | 10 ++ drivers/mfd/simple-mfd-i2c.c | 6 ++ 2 files changed, 16 insertions(+) diff --git

[PATCH v3 1/4] dt-bindings: mfd: Add bindings for Ampere Altra SMPro drivers

2021-04-08 Thread Quan Nguyen
Adds device tree bindings for SMPro drivers found on the Mt.Jade hardware reference platform with Ampere's Altra Processor family. Signed-off-by: Quan Nguyen --- .../bindings/hwmon/ampere,ac01-hwmon.yaml | 28 + .../devicetree/bindings/mfd/ampere,smpro.yaml | 105 ++ 2

[PATCH v3 0/4] Add Ampere's Altra SMPro hwmon driver

2021-04-08 Thread Quan Nguyen
This patch series adds support for Ampere SMpro hwmon driver. This driver supports accessing various CPU sensors provided by the SMpro co-processor including temperature, power, voltages, and current found on Ampere Altra processor family. v3: + Supported list of compatible string [Rob] +

Re: [PATCH v3] swiotlb: Make SWIOTLB_NO_FORCE perform no allocation

2021-04-08 Thread Florian Fainelli
On 3/24/2021 1:42 AM, Christoph Hellwig wrote: > On Mon, Mar 22, 2021 at 06:53:49PM -0700, Florian Fainelli wrote: >> When SWIOTLB_NO_FORCE is used, there should really be no allocations of >> default_nslabs to occur since we are not going to use those slabs. If a >> platform was somehow

RE: [PATCH v17 1/2] scsi: ufs: Enable power management for wlun

2021-04-08 Thread Daejun Park
Hi Asutosh Das, >During runtime-suspend of ufs host, the scsi devices are >already suspended and so are the queues associated with them. >But the ufs host sends SSU (START_STOP_UNIT) to wlun >during its runtime-suspend. >During the process blk_queue_enter checks if the queue is not in >suspended

linux-next: manual merge of the drm tree with the drm-misc-fixes tree

2021-04-08 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/vc4/vc4_plane.c between commit: 35d65ab3fdba ("drm/vc4: plane: Remove redundant assignment") from the drm-misc-fixes tree and commit: 5ddb0bd4ddc3 ("drm/atomic: Pass the full state to planes async

Re: [PATCH 00/20] kbuild: unify the install.sh script usage

2021-04-08 Thread Kees Cook
On Wed, Apr 07, 2021 at 07:33:59AM +0200, Greg Kroah-Hartman wrote: > Almost every architecture has copied the "install.sh" script that > originally came with i386, and modified it in very tiny ways. This > patch series unifies all of these scripts into one single script to > allow people to

Re: [PATCH 17/20] kbuild: s390: use common install script

2021-04-08 Thread Kees Cook
On Wed, Apr 07, 2021 at 07:34:16AM +0200, Greg Kroah-Hartman wrote: > The common scripts/install.sh script will now work for s390, no changes > needed. So call that instead and delete the s390-only install script. > > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Christian Borntraeger > Cc:

Re: [PATCH 11/20] kbuild: ia64: use common install script

2021-04-08 Thread Kees Cook
On Wed, Apr 07, 2021 at 07:34:10AM +0200, Greg Kroah-Hartman wrote: > The common scripts/install.sh script will now work for ia64, all that > is needed is to add the compressed image type to it. So add that file > type check and the ability to call /usr/sbin/elilo after copying the > kernel.

[PATCH] mtd: devices: Remove superfluous "break"

2021-04-08 Thread dingsenjie
From: dingsenjie Remove superfluous "break", as there is a "return" before them. Signed-off-by: dingsenjie --- drivers/mtd/devices/ms02-nv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mtd/devices/ms02-nv.c b/drivers/mtd/devices/ms02-nv.c index fb4a6aa..08f76ff 100644 ---

Re: [PATCH 12/20] kbuild: m68k: use common install script

2021-04-08 Thread Kees Cook
On Wed, Apr 07, 2021 at 07:34:11AM +0200, Greg Kroah-Hartman wrote: > The common scripts/install.sh script will now work for m68k, all that > is needed is to add it to the list of arches that do not put the version > number in the installed file name. > > With that we can remove the m68k-only

Re: [PATCH 14/20] kbuild: nios2: use common install script

2021-04-08 Thread Kees Cook
On Wed, Apr 07, 2021 at 07:34:13AM +0200, Greg Kroah-Hartman wrote: > The common scripts/install.sh script will now work for nios2, all that > is needed is to add it to the list of arches that do not put the version > number in the installed file name. > > With that we can remove the nios2-only

Re: [PATCH 10/20] kbuild: arm: use common install script

2021-04-08 Thread Kees Cook
On Wed, Apr 07, 2021 at 07:34:09AM +0200, Greg Kroah-Hartman wrote: > The common scripts/install.sh script will now work for arm, all that > is needed is to add the compressed image type to it. So add that file > type check and the ability to call /sbin/loadmap after copying the > kernel. With

Re: [PATCH 08/20] kbuild: riscv: use common install script

2021-04-08 Thread Kees Cook
On Wed, Apr 07, 2021 at 07:34:07AM +0200, Greg Kroah-Hartman wrote: > The common scripts/install.sh script will now work for riscv, all that > is needed is to add the compressed image type to it. So add that file > type check and remove the riscv-only version of the file. > > Cc: Paul Walmsley

Re: [PATCH 19/20] kbuild: sparc: use common install script

2021-04-08 Thread Kees Cook
On Wed, Apr 07, 2021 at 07:34:18AM +0200, Greg Kroah-Hartman wrote: > The common scripts/install.sh script will now work for sparc, all that > is needed is to add it to the list of arches that do not put the version > number in the installed file name. > > With that we can remove the sparc-only

Re: [PATCH -next] lib: zstd: Make symbol 'HUF_compressWeights_wksp' static

2021-04-08 Thread Miguel Ojeda
On Fri, Apr 9, 2021 at 2:20 AM Nick Desaulniers wrote: > > Quite a few other functions are declared in a header, but I don't see > any existing callers in tree. I wonder if the maintainer could > consider cleaning these up so that we don't retain them in binaries > without dead code elimination

Re: [PATCH 18/20] kbuild: sh: remove unused install script

2021-04-08 Thread Kees Cook
On Wed, Apr 07, 2021 at 07:34:17AM +0200, Greg Kroah-Hartman wrote: > The sh arch has a install.sh script, but no Makefile actually calls it. > Remove it to keep anyone from accidentally calling it in the future. > > Cc: Yoshinori Sato > Cc: Rich Felker > Cc: linux...@vger.kernel.org >

[PATCH v5 6/6] w1: ds2438: support for writing to offset register

2021-04-08 Thread Luiz Sampaio
Added a sysfs entry to support writing to the offset register on page1. This register is used to calibrate the chip canceling offset errors in the current ADC. This means that, over time, reading the IAD register will not return the correct current measurement, it will have an offset. Writing to

[PATCH v5 5/6] w1: ds2438: adding support for reading page1

2021-04-08 Thread Luiz Sampaio
Added a sysfs entry to support reading the page1 registers. This registers contain Elapsed Time Meter (ETM) data, which shows for how long the chip is on, as well as an Offset Register data, which can be used to calibrate the current measurement of the chip. Signed-off-by: Luiz Sampaio ---

[PATCH v5 1/6] w1: ds2438: fixed a coding style issue

2021-04-08 Thread Luiz Sampaio
There is an if statement and, if the function goes into it, it returns. So, the next else is not required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c

[PATCH v5 4/6] w1: ds2438: fixing bug that would always get page0

2021-04-08 Thread Luiz Sampaio
The purpose of the w1_ds2438_get_page function is to get the register values at the page passed as the pageno parameter. However, the page0 was hardcoded, such that the function always returned the page0 contents. Fixed so that the function can retrieve any page. Signed-off-by: Luiz Sampaio ---

[PATCH v5 3/6] w1: ds2438: fixed a coding style issue

2021-04-08 Thread Luiz Sampaio
Changed the permissions to preferred octal style. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index 56e53a748059..ccb06b8c2d78 100644 ---

[PATCH v5 2/6] w1: ds2438: fixed if brackets coding style issue

2021-04-08 Thread Luiz Sampaio
Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c

[PATCH v5 0/9] w1: ds2438: adding support for calibration of current measurements

2021-04-08 Thread Luiz Sampaio
The following patches aim to make a user able to calibrate the current measurement of the DS2438. This chip uses a offset register in page1, which is added to the current register to give the user the current measurement. If this value is wrong, the user will get an offset current value, even if

Re: [PATCH 05/20] kbuild: scripts/install.sh: prepare for arch-specific bootloaders

2021-04-08 Thread Kees Cook
On Wed, Apr 07, 2021 at 07:34:04AM +0200, Greg Kroah-Hartman wrote: > Despite the last release of LILO being in 2015, it seems that it is > still the default x86 bootloader and wants to be called to "install" the > new kernel image when it has been replaced on the disk. To allow > arch-specific

Re: [PATCH 01/20] kbuild: move x86 install script to scripts/install.sh

2021-04-08 Thread Kees Cook
On Wed, Apr 07, 2021 at 07:34:00AM +0200, Greg Kroah-Hartman wrote: > To unify the different architecture kernel installation scripts, start > out with the one they all were based on, the x86 script. Move it from > arch/x86/boot/ into scripts/ so that all architectures can call it in > the

Re: [PATCH v5] userfaultfd/shmem: fix MCOPY_ATOMIC_CONTINUE behavior

2021-04-08 Thread Hugh Dickins
On Thu, 8 Apr 2021, Axel Rasmussen wrote: > On Tue, Apr 6, 2021 at 4:49 PM Peter Xu wrote: > > On Mon, Apr 05, 2021 at 10:19:17AM -0700, Axel Rasmussen wrote: ... > > > --- a/mm/userfaultfd.c > > > +++ b/mm/userfaultfd.c ... > > > + > > > + if (is_file_backed) { > > > + /* The

Re: [PATCH 09/20] kbuild: arm64: use common install script

2021-04-08 Thread Kees Cook
On Wed, Apr 07, 2021 at 07:34:08AM +0200, Greg Kroah-Hartman wrote: > The common scripts/install.sh script will now work for arm65, no changes nit: arm64 > needed so convert the arm64 boot Makefile to call it instead of the > arm64-only version of the file and remove the now unused file. > >

[PATCH] phy: qcom-qmp: remove redundant error of clock bulk

2021-04-08 Thread Chunfeng Yun
There is error log in clk_bulk_prepare/enable() Signed-off-by: Chunfeng Yun --- drivers/phy/qualcomm/phy-qcom-qmp.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c index 9cdebe7..f14b8be

Re: [PATCH] KVM: X86: Do not yield to self

2021-04-08 Thread Wanpeng Li
On Fri, 9 Apr 2021 at 00:56, Sean Christopherson wrote: > > On Thu, Apr 08, 2021, Wanpeng Li wrote: > > From: Wanpeng Li > > > > If the target is self we do not need to yield, we can avoid malicious > > guest to play this. > > > > Signed-off-by: Wanpeng Li > > --- > > Rebased on > >

Re: [PATCH] KVM: X86: Count success and invalid yields

2021-04-08 Thread Wanpeng Li
On Fri, 9 Apr 2021 at 01:08, Sean Christopherson wrote: > > On Tue, Apr 06, 2021, Wanpeng Li wrote: > > From: Wanpeng Li > > > > To analyze some performance issues with lock contention and scheduling, > > it is nice to know when directed yield are successful or failing. > > > > Signed-off-by:

[PATCH] irqchip: gic-pm: remove redundant error log of clock bulk

2021-04-08 Thread Chunfeng Yun
There is error log in clk_bulk_prepare/enable() Signed-off-by: Chunfeng Yun --- drivers/irqchip/irq-gic-pm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-gic-pm.c b/drivers/irqchip/irq-gic-pm.c index 1337cec..b60e185 100644 ---

Re: [PATCH] x86/kvm: Don't alloc __pv_cpu_mask when !CONFIG_SMP

2021-04-08 Thread Wanpeng Li
On Fri, 9 Apr 2021 at 04:20, Sean Christopherson wrote: > > On Wed, Apr 07, 2021, Wanpeng Li wrote: > > From: Wanpeng Li > > > > Enable PV TLB shootdown when !CONFIG_SMP doesn't make sense. Let's move > > it inside CONFIG_SMP. In addition, we can avoid alloc __pv_cpu_mask when > > !CONFIG_SMP

[PATCH 17/17] bit_spinlock: Track bit spin locks with lockdep

2021-04-08 Thread Matthew Wilcox (Oracle)
Now that all users have been converted, require the split_lock parameter be passed to bit_spin_lock(), bit_spin_unlock() and variants. Use it to track the lockdep state of each lock. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/bit_spinlock.h | 26 ++ 1 file

[PATCH v3 2/2] USB:ehci:fix Kunpeng920 ehci hardware problem

2021-04-08 Thread Longfang Liu
Kunpeng920's EHCI controller does not have SBRN register. Reading the SBRN register when the controller driver is initialized will get 0. When rebooting the EHCI driver, ehci_shutdown() will be called. if the sbrn flag is 0, ehci_shutdown() will return directly. The sbrn flag being 0 will cause

[PATCH v3 1/2] USB:ehci:Add a whitelist for EHCI controllers

2021-04-08 Thread Longfang Liu
Some types of EHCI controllers do not have SBRN registers. By comparing the white list, the operation of reading the SBRN registers is skipped. Subsequent EHCI controller types without SBRN registers can be directly added to the white list. The current patch does not affect the drive function.

[PATCH v3 0/2] USB:ehci:fix the no SRBN register problem

2021-04-08 Thread Longfang Liu
(1) Add a whitelist for EHCI devices without SBRN registers. (2) Add Kunpeng920's EHCI device to the whitelist. Changes in v3: - Fix some code style issues. - Update struct name. Changes in v2: - Fix some code style issues. - Update function name. Longfang Liu

[PATCH 16/17] rhashtable: Convert to split_lock

2021-04-08 Thread Matthew Wilcox (Oracle)
NeilBrown noticed the same problem with bit spinlocks that I did, but chose to solve it locally in the rhashtable implementation rather than lift it all the way to the bit spin lock implementation. Convert rhashtables to use split_locks. Signed-off-by: Matthew Wilcox (Oracle) Cc: NeilBrown ---

[PATCH 15/17] zsmalloc: Add zs_pin_lock

2021-04-08 Thread Matthew Wilcox (Oracle)
Allow lockdep to track zsmalloc's pin bit spin lock. Signed-off-by: Matthew Wilcox (Oracle) --- mm/zsmalloc.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 9a7c91c14b84..9d89a1857901 100644 --- a/mm/zsmalloc.c +++

Re: [PATCH 3/4] mm/hugeltb: fix potential wrong gbl_reserve value for hugetlb_acct_memory()

2021-04-08 Thread Miaohe Lin
On 2021/4/9 6:53, Mike Kravetz wrote: > On 4/7/21 8:26 PM, Miaohe Lin wrote: >> On 2021/4/8 11:24, Miaohe Lin wrote: >>> On 2021/4/8 4:53, Mike Kravetz wrote: On 4/7/21 12:24 AM, Miaohe Lin wrote: > Hi: > On 2021/4/7 10:49, Mike Kravetz wrote: >> On 4/2/21 2:32 AM, Miaohe Lin

Re: [PATCH 1/2] zram: fix crashes due to use of cpu hotplug multistate

2021-04-08 Thread Kees Cook
On Thu, Apr 08, 2021 at 10:55:53AM +0200, Greg KH wrote: > Module removal is not a "normal" operation that can be triggered by a > system automatically without a user asking for it. As someone reminded > me on IRC, we used to do this "automatically" for many problematic > drivers years ago for

[PATCH 14/17] slub: Add slab_page_lock

2021-04-08 Thread Matthew Wilcox (Oracle)
Allow lockdep to track slub's page bit spin lock. Signed-off-by: Matthew Wilcox (Oracle) --- mm/slub.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 9c0e26ddf300..2ed2abe080ac 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -346,19 +346,21 @@

[PATCH 13/17] jbd2: Add jbd2_jh_lock

2021-04-08 Thread Matthew Wilcox (Oracle)
Allow lockdep to track the journal bit spin locks. Signed-off-by: Matthew Wilcox (Oracle) --- fs/jbd2/journal.c| 18 ++ include/linux/jbd2.h | 10 ++ 2 files changed, 16 insertions(+), 12 deletions(-) diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c index

[PATCH 12/17] zram: Add zram_table_lock

2021-04-08 Thread Matthew Wilcox (Oracle)
Allow lockdep to track the zram bit spin locks. Signed-off-by: Matthew Wilcox (Oracle) --- drivers/block/zram/zram_drv.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index cf8deecc39ef..8b678cc6ed21

[PATCH 11/17] s390: Add airq_iv_lock

2021-04-08 Thread Matthew Wilcox (Oracle)
Allow lockdep to track the airq bit spin locks. Signed-off-by: Matthew Wilcox (Oracle) --- arch/s390/include/asm/airq.h | 5 +++-- drivers/s390/cio/airq.c | 3 +++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/s390/include/asm/airq.h b/arch/s390/include/asm/airq.h

[PATCH 10/17] hlist_bl: Make the split_lock parameter mandatory

2021-04-08 Thread Matthew Wilcox (Oracle)
Now that all users have been converted, require the split_lock parameter be passed to hlist_bl_lock() and hlist_bl_unlock(). Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/list_bl.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/list_bl.h

Re: [PATCH v2 -next] nilfs2: Fix typos in comments

2021-04-08 Thread Ryusuke Konishi
Thank you. Will apply this. Ryusuke Konishi On Fri, Apr 9, 2021 at 11:25 AM Lu Jialin wrote: > > numer -> number in fs/nilfs2/cpfile.c > Decription -> Description in fs/nilfs2/ioctl.c > isntance -> instance in fs/nilfs2/the_nilfs.c > > Signed-off-by: Lu Jialin > --- > v2: > Exclude two typo

[PATCH 09/17] mbcache: Add mb_cache_lock

2021-04-08 Thread Matthew Wilcox (Oracle)
Allow lockdep to track the mbcache hash bit spin locks. Signed-off-by: Matthew Wilcox (Oracle) --- fs/mbcache.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/fs/mbcache.c b/fs/mbcache.c index 97c54d3a2227..4ce03ea348dd 100644 --- a/fs/mbcache.c

Re: [RFC PATCH v1 00/11] Manage the top tier memory in a tiered memory

2021-04-08 Thread Huang, Ying
Yang Shi writes: > On Thu, Apr 8, 2021 at 10:19 AM Shakeel Butt wrote: >> >> Hi Tim, >> >> On Mon, Apr 5, 2021 at 11:08 AM Tim Chen wrote: >> > >> > Traditionally, all memory is DRAM. Some DRAM might be closer/faster than >> > others NUMA wise, but a byte of media has about the same cost

[PATCH 08/17] gfs2: Add qd_hash_lock

2021-04-08 Thread Matthew Wilcox (Oracle)
Allow lockdep to track the hash bit spin locks. Signed-off-by: Matthew Wilcox (Oracle) --- fs/gfs2/quota.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c index 9b1aca7e1264..a933eb441ee9 100644 --- a/fs/gfs2/quota.c +++

[PATCH -next] media: s3c-camif: fix PM reference leak in s3c_camif_open()

2021-04-08 Thread Lu Jialin
pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get to keep usage counter balanced. Reported-by: Hulk Robot Signed-off-by: Lu Jialin ---

[PATCH 07/17] fscache: Add cookie_hash_lock

2021-04-08 Thread Matthew Wilcox (Oracle)
Allow lockdep to track the fscache cookie hash bit spin locks. Signed-off-by: Matthew Wilcox (Oracle) --- fs/fscache/cookie.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/fs/fscache/cookie.c b/fs/fscache/cookie.c index 751bc5b1cddf..65d514d12592 100644 ---

<    1   2   3   4   5   6   7   8   9   10   >