Re: [PATCH] nvdimm/pmem: Fix an error handling path in 'pmem_attach_disk()'

2021-11-07 Thread Marion & Christophe JAILLET
Le 07/11/2021 à 18:25, Marion & Christophe JAILLET a écrit : Le 07/11/2021 à 18:20, Christophe JAILLET a écrit : Le 07/11/2021 à 18:11, Ira Weiny a écrit : On Sat, Nov 06, 2021 at 06:27:11PM +0100, Christophe JAILLET wrote: If 'devm_init_badblocks()' fails, a previous 'blk_alloc_disk()'

Re: [PATCH] nvdimm/pmem: Fix an error handling path in 'pmem_attach_disk()'

2021-11-07 Thread Marion & Christophe JAILLET
Le 07/11/2021 à 18:20, Christophe JAILLET a écrit : Le 07/11/2021 à 18:11, Ira Weiny a écrit : On Sat, Nov 06, 2021 at 06:27:11PM +0100, Christophe JAILLET wrote: If 'devm_init_badblocks()' fails, a previous 'blk_alloc_disk()' call must be undone. I think this is a problem...

Re: [PATCH] nvdimm/pmem: Fix an error handling path in 'pmem_attach_disk()'

2021-11-07 Thread Christophe JAILLET
Le 07/11/2021 à 18:11, Ira Weiny a écrit : On Sat, Nov 06, 2021 at 06:27:11PM +0100, Christophe JAILLET wrote: If 'devm_init_badblocks()' fails, a previous 'blk_alloc_disk()' call must be undone. I think this is a problem... Signed-off-by: Christophe JAILLET --- This patch is speculative.

Re: [PATCH] nvdimm/pmem: Fix an error handling path in 'pmem_attach_disk()'

2021-11-07 Thread Ira Weiny
On Sat, Nov 06, 2021 at 06:27:11PM +0100, Christophe JAILLET wrote: > If 'devm_init_badblocks()' fails, a previous 'blk_alloc_disk()' call must > be undone. I think this is a problem... > > Signed-off-by: Christophe JAILLET > --- > This patch is speculative. Several fixes on error handling