Re: [PATCH v9 02/10] dax: Introduce holder for dax_device

2022-01-05 Thread Dan Williams
On Wed, Jan 5, 2022 at 3:54 PM Darrick J. Wong wrote: [..] > > Yes, I think we should just fail the holder registration and > > DAX+reflink unless the FS being mounted on a whole device. I know Ted > > and others had reservations about moving filesystems to be mounted on > > dax-devices directly,

Re: [PATCH v9 02/10] dax: Introduce holder for dax_device

2022-01-05 Thread Darrick J. Wong
On Wed, Jan 05, 2022 at 03:01:22PM -0800, Dan Williams wrote: > On Wed, Jan 5, 2022 at 2:47 PM Darrick J. Wong wrote: > > > > On Wed, Jan 05, 2022 at 11:20:12AM -0800, Dan Williams wrote: > > > On Wed, Jan 5, 2022 at 10:56 AM Darrick J. Wong wrote: > > > > > > > > On Wed, Jan 05, 2022 at

Re: [PATCH v9 02/10] dax: Introduce holder for dax_device

2022-01-05 Thread Dan Williams
On Wed, Jan 5, 2022 at 2:47 PM Darrick J. Wong wrote: > > On Wed, Jan 05, 2022 at 11:20:12AM -0800, Dan Williams wrote: > > On Wed, Jan 5, 2022 at 10:56 AM Darrick J. Wong wrote: > > > > > > On Wed, Jan 05, 2022 at 10:23:08AM -0800, Dan Williams wrote: > > > > On Wed, Jan 5, 2022 at 10:12 AM

Re: [PATCH v9 02/10] dax: Introduce holder for dax_device

2022-01-05 Thread Darrick J. Wong
On Wed, Jan 05, 2022 at 11:20:12AM -0800, Dan Williams wrote: > On Wed, Jan 5, 2022 at 10:56 AM Darrick J. Wong wrote: > > > > On Wed, Jan 05, 2022 at 10:23:08AM -0800, Dan Williams wrote: > > > On Wed, Jan 5, 2022 at 10:12 AM Darrick J. Wong wrote: > > > > > > > > On Sun, Dec 26, 2021 at

Re: [PATCH v9 09/10] xfs: Implement ->notify_failure() for XFS

2022-01-05 Thread Dan Williams
On Wed, Jan 5, 2022 at 10:53 AM Darrick J. Wong wrote: > > On Sun, Dec 26, 2021 at 10:34:38PM +0800, Shiyang Ruan wrote: > > Introduce xfs_notify_failure.c to handle failure related works, such as > > implement ->notify_failure(), register/unregister dax holder in xfs, and > > so on. > > > > If

Re: [PATCH v9 02/10] dax: Introduce holder for dax_device

2022-01-05 Thread Dan Williams
On Wed, Jan 5, 2022 at 10:56 AM Darrick J. Wong wrote: > > On Wed, Jan 05, 2022 at 10:23:08AM -0800, Dan Williams wrote: > > On Wed, Jan 5, 2022 at 10:12 AM Darrick J. Wong wrote: > > > > > > On Sun, Dec 26, 2021 at 10:34:31PM +0800, Shiyang Ruan wrote: > > > > To easily track filesystem from a

Re: [PATCH v9 04/10] pagemap,pmem: Introduce ->memory_failure()

2022-01-05 Thread Darrick J. Wong
On Sun, Dec 26, 2021 at 10:34:33PM +0800, Shiyang Ruan wrote: > When memory-failure occurs, we call this function which is implemented > by each kind of devices. For the fsdax case, pmem device driver > implements it. Pmem device driver will find out the filesystem in which > the corrupted page

Re: [PATCH v9 02/10] dax: Introduce holder for dax_device

2022-01-05 Thread Darrick J. Wong
On Wed, Jan 05, 2022 at 10:23:08AM -0800, Dan Williams wrote: > On Wed, Jan 5, 2022 at 10:12 AM Darrick J. Wong wrote: > > > > On Sun, Dec 26, 2021 at 10:34:31PM +0800, Shiyang Ruan wrote: > > > To easily track filesystem from a pmem device, we introduce a holder for > > > dax_device structure,

Re: [PATCH v9 09/10] xfs: Implement ->notify_failure() for XFS

2022-01-05 Thread Darrick J. Wong
On Sun, Dec 26, 2021 at 10:34:38PM +0800, Shiyang Ruan wrote: > Introduce xfs_notify_failure.c to handle failure related works, such as > implement ->notify_failure(), register/unregister dax holder in xfs, and > so on. > > If the rmap feature of XFS enabled, we can query it to find files and >

Re: [PATCH v9 02/10] dax: Introduce holder for dax_device

2022-01-05 Thread Dan Williams
On Wed, Jan 5, 2022 at 10:12 AM Darrick J. Wong wrote: > > On Sun, Dec 26, 2021 at 10:34:31PM +0800, Shiyang Ruan wrote: > > To easily track filesystem from a pmem device, we introduce a holder for > > dax_device structure, and also its operation. This holder is used to > > remember who is using

Re: [PATCH v9 02/10] dax: Introduce holder for dax_device

2022-01-05 Thread Darrick J. Wong
On Sun, Dec 26, 2021 at 10:34:31PM +0800, Shiyang Ruan wrote: > To easily track filesystem from a pmem device, we introduce a holder for > dax_device structure, and also its operation. This holder is used to > remember who is using this dax_device: > - When it is the backend of a filesystem, the

Re: [PATCH v9 05/10] fsdax: fix function description

2022-01-05 Thread Darrick J. Wong
On Sun, Dec 26, 2021 at 10:34:34PM +0800, Shiyang Ruan wrote: > The function name has been changed, so the description should be updated > too. > > Signed-off-by: Shiyang Ruan Reviewed-by: Darrick J. Wong --D > --- > fs/dax.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH v9 01/10] dax: Use percpu rwsem for dax_{read,write}_lock()

2022-01-05 Thread Darrick J. Wong
On Tue, Jan 04, 2022 at 02:44:08PM -0800, Dan Williams wrote: > On Sun, Dec 26, 2021 at 6:35 AM Shiyang Ruan wrote: > > > > In order to introduce dax holder registration, we need a write lock for > > dax. > > As far as I can see, no, a write lock is not needed while the holder > is being