Re: [PATCH 4/5] dax: fix missing writeprotect the pte entry

On Mon, Jan 24, 2022 at 3:41 PM Christoph Hellwig wrote: > > On Fri, Jan 21, 2022 at 03:55:14PM +0800, Muchun Song wrote: > > Reuse some infrastructure of page_mkclean_one() to let DAX can handle > > similar case to fix this issue. > > Can you split out some of the infrastructure changes into prop

Re: [PATCH 3/5] mm: page_vma_mapped: support checking if a pfn is mapped into a vma

On Mon, Jan 24, 2022 at 3:36 PM Christoph Hellwig wrote: > > On Fri, Jan 21, 2022 at 03:55:13PM +0800, Muchun Song wrote: > > + if (pvmw->pte && ((pvmw->flags & PVMW_PFN_WALK) || > > !PageHuge(pvmw->page))) > > Please avoid the overly long line here and in a few other places. OK. > > > +/*

Re: [PATCH 1/5] mm: rmap: fix cache flush on THP pages

On Mon, Jan 24, 2022 at 3:34 PM Christoph Hellwig wrote: > > On Fri, Jan 21, 2022 at 03:55:11PM +0800, Muchun Song wrote: > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/rmap.c b/mm/rmap.c > > index b0fd9dc19eba..65670cb805d6 100644 > > --- a/mm/rmap.c > > +++ b/mm/rmap.