Re: [PATCH v3 8/8] nvdimm: Fix firmware activation deadlock scenarios

2022-04-22 Thread Ira Weiny
On Thu, Apr 21, 2022 at 08:33:51AM -0700, Dan Williams wrote: > Lockdep reports the following deadlock scenarios for CXL root device > power-management, device_prepare(), operations, and device_shutdown() > operations for 'nd_region' devices: > > --- > Chain exists of: >_region_key -->

Re: [PATCH v3 7/8] device-core: Kill the lockdep_mutex

2022-04-22 Thread Ira Weiny
On Thu, Apr 21, 2022 at 08:33:45AM -0700, Dan Williams wrote: > Per Peter [1], the lockdep API has native support for all the use cases > lockdep_mutex was attempting to enable. Now that all lockdep_mutex users > have been converted to those APIs, drop this lock. > > Link: >

Re: [PATCH v3 6/8] nvdimm: Drop nd_device_lock()

2022-04-22 Thread Ira Weiny
On Thu, Apr 21, 2022 at 08:33:39AM -0700, Dan Williams wrote: > Now that all NVDIMM subsystem locking is validated with custom lock > classes, there is no need for the custom usage of the lockdep_mutex. > > Cc: Vishal Verma > Cc: Dave Jiang > Cc: Ira Weiny > Signed-off-by: Dan Williams

Re: [PATCH v3 5/8] ACPI: NFIT: Drop nfit_device_lock()

2022-04-22 Thread Ira Weiny
On Thu, Apr 21, 2022 at 08:33:34AM -0700, Dan Williams wrote: > The nfit_device_lock() helper was added to provide lockdep coverage for > the NFIT driver's usage of device_lock() on the nvdimm_bus object. Now > that nvdimm_bus objects have their own lock class this wrapper can be > dropped. > >

Re: [PATCH v3 4/8] nvdimm: Replace lockdep_mutex with local lock classes

2022-04-22 Thread Ira Weiny
On Thu, Apr 21, 2022 at 08:33:29AM -0700, Dan Williams wrote: > In response to an attempt to expand dev->lockdep_mutex for device_lock() > validation [1], Peter points out [2] that the lockdep API already has > the ability to assign a dedicated lock class per subsystem device-type. > > Use

Re: [PATCH v3 2/8] cxl/acpi: Add root device lockdep validation

2022-04-22 Thread Dan Williams
On Fri, Apr 22, 2022 at 4:58 PM Ira Weiny wrote: > > On Thu, Apr 21, 2022 at 08:33:18AM -0700, Dan Williams wrote: > > The CXL "root" device, ACPI0017, is an attach point for coordinating > > platform level CXL resources and is the parent device for a CXL port > > topology tree. As such it has

Re: [PATCH v3 3/8] cxl: Drop cxl_device_lock()

2022-04-22 Thread Ira Weiny
On Thu, Apr 21, 2022 at 08:33:23AM -0700, Dan Williams wrote: > Now that all CXL subsystem locking is validated with custom lock > classes, there is no need for the custom usage of the lockdep_mutex. > > Cc: Alison Schofield > Cc: Vishal Verma > Cc: Ira Weiny > Cc: Ben Widawsky > Cc: Jonathan

Re: [PATCH v13 0/7] fsdax: introduce fs query to support reflink

2022-04-22 Thread Dave Chinner
On Fri, Apr 22, 2022 at 02:27:32PM -0700, Dan Williams wrote: > On Thu, Apr 21, 2022 at 12:47 AM Dave Chinner wrote: > > > > On Wed, Apr 20, 2022 at 10:54:59PM -0700, Christoph Hellwig wrote: > > > On Thu, Apr 21, 2022 at 02:35:02PM +1000, Dave Chinner wrote: > > > > Sure, I'm not a maintainer

Re: [PATCH v3 2/8] cxl/acpi: Add root device lockdep validation

2022-04-22 Thread Ira Weiny
On Thu, Apr 21, 2022 at 08:33:18AM -0700, Dan Williams wrote: > The CXL "root" device, ACPI0017, is an attach point for coordinating > platform level CXL resources and is the parent device for a CXL port > topology tree. As such it has distinct locking rules relative to other > CXL subsystem

Re: [PATCH v3 1/8] cxl: Replace lockdep_mutex with local lock classes

2022-04-22 Thread Ira Weiny
On Thu, Apr 21, 2022 at 08:33:13AM -0700, Dan Williams wrote: > In response to an attempt to expand dev->lockdep_mutex for device_lock() > validation [1], Peter points out [2] that the lockdep API already has > the ability to assign a dedicated lock class per subsystem device-type. > > Use

Re: [PATCH v13 0/7] fsdax: introduce fs query to support reflink

2022-04-22 Thread Dan Williams
On Thu, Apr 21, 2022 at 12:47 AM Dave Chinner wrote: > > On Wed, Apr 20, 2022 at 10:54:59PM -0700, Christoph Hellwig wrote: > > On Thu, Apr 21, 2022 at 02:35:02PM +1000, Dave Chinner wrote: > > > Sure, I'm not a maintainer and just the stand-in patch shepherd for > > > a single release. However,

Re: [PATCH v13 3/7] pagemap,pmem: Introduce ->memory_failure()

2022-04-22 Thread Shiyang Ruan
在 2022/4/21 16:24, Miaohe Lin 写道: On 2022/4/19 12:50, Shiyang Ruan wrote: When memory-failure occurs, we call this function which is implemented by each kind of devices. For the fsdax case, pmem device driver implements it. Pmem device driver will find out the filesystem in which the