Re: [PATCH] tools/testing/nvdimm: remove unneeded flush_workqueue

2022-04-25 Thread Dan Williams
On Sat, Apr 23, 2022 at 11:27 PM wrote: > > From: ran jianping > > All work currently pending will be done first by calling destroy_workqueue, > so there is no need to flush it explicitly. > Looks good, applied.

Re: [PATCH v3 2/8] cxl/acpi: Add root device lockdep validation

2022-04-25 Thread Dan Williams
On Mon, Apr 25, 2022 at 9:05 AM Dan Williams wrote: > > On Mon, Apr 25, 2022 at 3:33 AM Peter Zijlstra wrote: > > > > On Sat, Apr 23, 2022 at 10:27:52AM -0700, Dan Williams wrote: > > > > > ...so I'm going to drop it and just add a comment about the > > > expectations. As Peter said there's alrea

Re: [PATCH] device-dax: use kobj_to_dev()

2022-04-25 Thread kernel test robot
d in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/cgel-zte-gmail-com/device-dax-use-kobj_to_dev/20220425-185400 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git af2d861d4cd2a4da5137f795ee3509e6f944a25b config: hexagon-

Re: [PATCH] device-dax: use kobj_to_dev()

2022-04-25 Thread kernel test robot
d in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/cgel-zte-gmail-com/device-dax-use-kobj_to_dev/20220425-185400 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git af2d861d4cd2a4da5137f795ee3509e6f944a25b config: i386-randc

Re: [PATCH v3 2/8] cxl/acpi: Add root device lockdep validation

2022-04-25 Thread Dan Williams
On Mon, Apr 25, 2022 at 3:33 AM Peter Zijlstra wrote: > > On Sat, Apr 23, 2022 at 10:27:52AM -0700, Dan Williams wrote: > > > ...so I'm going to drop it and just add a comment about the > > expectations. As Peter said there's already a multitude of ways to > > cause false positive / negative resul

Re: [PATCH] tools/testing/nvdimm: remove unneeded flush_workqueue

2022-04-25 Thread Ira Weiny
On Sun, Apr 24, 2022 at 06:26:55AM +, cgel@gmail.com wrote: > From: ran jianping > > All work currently pending will be done first by calling destroy_workqueue, > so there is no need to flush it explicitly. > > Reported-by: Zeal Robot > Signed-off-by: ran jianping Reviewed-by: Ira Wei

[PATCH] ndtest: use kobj_to_dev()

2022-04-25 Thread cgel . zte
From: Minghao Chi Use kobj_to_dev() instead of open-coding it. Reported-by: Zeal Robot Signed-off-by: Minghao Chi --- tools/testing/nvdimm/test/ndtest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/nvdimm/test/ndtest.c b/tools/testing/nvdimm/test/ndtest.c

[PATCH] libnvdimm: use kobj_to_dev()

2022-04-25 Thread cgel . zte
From: Minghao Chi Use kobj_to_dev() instead of open-coding it. Reported-by: Zeal Robot Signed-off-by: Minghao Chi --- drivers/nvdimm/namespace_devs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvdimm/namespace_devs.c b/drivers/nvdimm/namespace_devs.c index 62b

[PATCH] device-dax: use kobj_to_dev()

2022-04-25 Thread cgel . zte
From: Minghao Chi Use kobj_to_dev() instead of open-coding it. Reported-by: Zeal Robot Signed-off-by: Minghao Chi --- drivers/dax/bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c index 1dad813ee4a6..aebe884f5d99 100644 --- a/drive

Re: [PATCH v3 2/8] cxl/acpi: Add root device lockdep validation

2022-04-25 Thread Peter Zijlstra
On Sat, Apr 23, 2022 at 10:27:52AM -0700, Dan Williams wrote: > ...so I'm going to drop it and just add a comment about the > expectations. As Peter said there's already a multitude of ways to > cause false positive / negative results with lockdep so this is just > one more area where one needs to