Re: [PATCH v2] mm: fix missing wake-up event for FSDAX pages

2022-07-05 Thread Muchun Song
On Tue, Jul 05, 2022 at 08:00:42PM -0700, Andrew Morton wrote: > On Wed, 6 Jul 2022 10:47:32 +0800 Muchun Song > wrote: > > > > If this wakeup is not one of these, then are there reports from the > > > softlockup detector? > > > > > > Do we have reports of processes permanently stuck in D state

Re: [PATCH v2] mm: fix missing wake-up event for FSDAX pages

2022-07-05 Thread Andrew Morton
On Wed, 6 Jul 2022 10:47:32 +0800 Muchun Song wrote: > > If this wakeup is not one of these, then are there reports from the > > softlockup detector? > > > > Do we have reports of processes permanently stuck in D state? > > > > No. The task is in an TASK_INTERRUPTIBLE state (see > __fuse_dax_b

Re: [PATCH v2] mm: fix missing wake-up event for FSDAX pages

2022-07-05 Thread Muchun Song
On Tue, Jul 05, 2022 at 04:47:10PM -0700, Andrew Morton wrote: > On Wed, 6 Jul 2022 00:38:41 +0100 Matthew Wilcox wrote: > > > On Tue, Jul 05, 2022 at 02:18:19PM -0700, Andrew Morton wrote: > > > On Tue, 5 Jul 2022 20:35:32 +0800 Muchun Song > > > wrote: > > > > > > > FSDAX page refcounts are

Re: [PATCH v2] mm: fix missing wake-up event for FSDAX pages

2022-07-05 Thread Andrew Morton
On Wed, 6 Jul 2022 00:38:41 +0100 Matthew Wilcox wrote: > On Tue, Jul 05, 2022 at 02:18:19PM -0700, Andrew Morton wrote: > > On Tue, 5 Jul 2022 20:35:32 +0800 Muchun Song > > wrote: > > > > > FSDAX page refcounts are 1-based, rather than 0-based: if refcount is > > > 1, then the page is freed

Re: [PATCH v2] mm: fix missing wake-up event for FSDAX pages

2022-07-05 Thread Matthew Wilcox
On Tue, Jul 05, 2022 at 02:18:19PM -0700, Andrew Morton wrote: > On Tue, 5 Jul 2022 20:35:32 +0800 Muchun Song > wrote: > > > FSDAX page refcounts are 1-based, rather than 0-based: if refcount is > > 1, then the page is freed. The FSDAX pages can be pinned through GUP, > > then they will be un

Re: [PATCH v2] mm: fix missing wake-up event for FSDAX pages

2022-07-05 Thread Andrew Morton
On Tue, 5 Jul 2022 20:35:32 +0800 Muchun Song wrote: > FSDAX page refcounts are 1-based, rather than 0-based: if refcount is > 1, then the page is freed. The FSDAX pages can be pinned through GUP, > then they will be unpinned via unpin_user_page() using a folio variant > to put the page, howeve

Re: [RFC PATCH v4] mm, pmem, xfs: Introduce MF_MEM_REMOVE for unbind

2022-07-05 Thread Darrick J. Wong
On Sun, Jul 03, 2022 at 09:08:38PM +0800, Shiyang Ruan wrote: > This patch is inspired by Dan's "mm, dax, pmem: Introduce > dev_pagemap_failure()"[1]. With the help of dax_holder and > ->notify_failure() mechanism, the pmem driver is able to ask filesystem > (or mapped device) on it to unmap all f

[PATCH v2] mm: fix missing wake-up event for FSDAX pages

2022-07-05 Thread Muchun Song
FSDAX page refcounts are 1-based, rather than 0-based: if refcount is 1, then the page is freed. The FSDAX pages can be pinned through GUP, then they will be unpinned via unpin_user_page() using a folio variant to put the page, however, folio variants did not consider this special case, the result