Re: [PATCH v2] nvdimm: Support sizeof(struct page) > MAX_STRUCT_PAGE_SIZE

2023-01-25 Thread Yu Zhao
On Wed, Jan 25, 2023 at 1:23 PM Dan Williams wrote: > > Commit 6e9f05dc66f9 ("libnvdimm/pfn_dev: increase MAX_STRUCT_PAGE_SIZE") > > ...updated MAX_STRUCT_PAGE_SIZE to account for sizeof(struct page) > potentially doubling in the case of CONFIG_KMSAN=y. Unfortunately this > doubles the amount of c

RE: [PATCH] dax: super.c: fix kernel-doc bad line warning

2023-01-25 Thread Dan Williams
Randy Dunlap wrote: > Convert an empty line to " *" to avoid a kernel-doc warning: > > drivers/dax/super.c:478: warning: bad line: > > Signed-off-by: Randy Dunlap > Cc: Dan Williams > Cc: Vishal Verma > Cc: Dave Jiang > Cc: nvd...@lists.linux.dev > --- > drivers/dax/super.c |2 +- > 1 f

[PATCH v2] nvdimm: Support sizeof(struct page) > MAX_STRUCT_PAGE_SIZE

2023-01-25 Thread Dan Williams
Commit 6e9f05dc66f9 ("libnvdimm/pfn_dev: increase MAX_STRUCT_PAGE_SIZE") ...updated MAX_STRUCT_PAGE_SIZE to account for sizeof(struct page) potentially doubling in the case of CONFIG_KMSAN=y. Unfortunately this doubles the amount of capacity stolen from user addressable capacity for everyone, rega

RE: [PATCH] ACPI: NFIT: fix a potential deadlock during NFIT teardown

2023-01-25 Thread Dan Williams
Vishal Verma wrote: > Lockdep reports that acpi_nfit_shutdown() may deadlock against an > opportune acpi_nfit_scrub(). acpi_nfit_scrub () is run from inside a > 'work' and therefore has already acquired workqueue-internal locks. It > also acquiires acpi_desc->init_mutex. acpi_nfit_shutdown() first

RE: [PATCH v2] nvdimm: Use kstrtobool() instead of strtobool()

2023-01-25 Thread Dan Williams
Christophe JAILLET wrote: > strtobool() is the same as kstrtobool(). > However, the latter is more used within the kernel. > > In order to remove strtobool() and slightly simplify kstrtox.h, switch to > the other function name. > > While at it, include the corresponding header file () > > Signed

Re: [PATCH v2] nvdimm: Use kstrtobool() instead of strtobool()

2023-01-25 Thread Verma, Vishal L
On Sat, 2023-01-14 at 09:50 +0100, Christophe JAILLET wrote: > strtobool() is the same as kstrtobool(). > However, the latter is more used within the kernel. > > In order to remove strtobool() and slightly simplify kstrtox.h, switch to > the other function name. > > While at it, include the corre

[PATCH] ACPI: NFIT: fix a potential deadlock during NFIT teardown

2023-01-25 Thread Vishal Verma
Lockdep reports that acpi_nfit_shutdown() may deadlock against an opportune acpi_nfit_scrub(). acpi_nfit_scrub () is run from inside a 'work' and therefore has already acquired workqueue-internal locks. It also acquiires acpi_desc->init_mutex. acpi_nfit_shutdown() first acquires init_mutex, and was