Re: [PATCH] nvdimm: nvdimm_bus_register: Avoid adding device to the unregistered bus

On 21/03/2023 10:38, Dan Williams wrote: > lizhij...@fujitsu.com wrote: > [..] >>> Now I do think it would be a good idea to fail device_add() if the bus >>> is not registered, >> >> BTW, below line 369: device_add() didn't fail in practical. >> > > I think that's ok because the device gets adde

Re: [PATCH] nvdimm: nvdimm_bus_register: Avoid adding device to the unregistered bus

lizhij...@fujitsu.com wrote: [..] > > Now I do think it would be a good idea to fail device_add() if the bus > > is not registered, > > BTW, below line 369: device_add() didn't fail in practical. > I think that's ok because the device gets added, but never probed due to this part of that commit

Re: [PATCH] nvdimm: nvdimm_bus_register: Avoid adding device to the unregistered bus

On 21/03/2023 01:30, Dan Williams wrote: > lizhij...@fujitsu.com wrote: > [..] Dan, Configure the kconfig with ACPI_NFIT [=m] && LIBNVDIMM [=y], and add extra kernel booting parameter 'initcall_blacklist=libnvdimm_init'. Then kernel panic! >>> >>> That's expected though,

Re: [PATCH] nvdimm: nvdimm_bus_register: Avoid adding device to the unregistered bus

lizhij...@fujitsu.com wrote: [..] > >> Dan, > >> > >> Configure the kconfig with ACPI_NFIT [=m] && LIBNVDIMM [=y], and add extra > >> kernel booting parameter > >> 'initcall_blacklist=libnvdimm_init'. Then kernel panic! > > > > That's expected though, > > Do you mean we just keep it as it is. Y

Re: [RFC PATCH] xfs: check shared state of when CoW, update reflink flag when io ends

在 2023/3/18 4:35, Darrick J. Wong 写道: On Fri, Mar 17, 2023 at 03:59:48AM +, Shiyang Ruan wrote: As is mentioned[1] before, the generic/388 will randomly fail with dmesg warning. This case uses fsstress with a lot of random operations. It is hard to reproduce. Finally I found a 100% re