Re: [PATCH 3/3] libnvdimm: mark 'security_show' static again

On 5/16/23 1:14 PM, Arnd Bergmann wrote: From: Arnd Bergmann The security_show() function was made global and __weak at some point to allow overriding it. The override was removed later, but it remains global, which causes a warning about the missing declaration: drivers/nvdimm/dimm_devs.c:

Re: [PATCH 2/3] testing: nvdimm: add missing prototypes for wrapped functions

On 5/16/23 1:14 PM, Arnd Bergmann wrote: From: Arnd Bergmann The nvdimm test wraps a number of API functions, but these functions don't have a prototype in a header because they are all called by a different name: drivers/nvdimm/../../tools/testing/nvdimm/test/iomap.c:74:15: error: no prev

Re: [PATCH 1/3] acpi: nfit: add declaration in a local header

On 5/16/23 1:14 PM, Arnd Bergmann wrote: From: Arnd Bergmann The nfit_intel_shutdown_status() function has a __weak defintion in nfit.c and an override in acpi_nfit_test.c for testing purposes. This works without an extern declaration, but causes a W=1 build warning: drivers/acpi/nfit/core.