Re: [PATCH v3 04/13] mm/execmem, arch: convert remaining overrides of module_alloc to execmem

2023-10-04 Thread Mike Rapoport
On Wed, Oct 04, 2023 at 12:29:36AM +, Edgecombe, Rick P wrote: > On Mon, 2023-09-18 at 10:29 +0300, Mike Rapoport wrote: > > diff --git a/arch/x86/kernel/module.c b/arch/x86/kernel/module.c > > index 5f71a0cf4399..9d37375e2f05 100644 > > --- a/arch/x86/kernel/module.c > > +++ b/arch/x86/kernel/

Re: [PATCH v3 03/13] mm/execmem, arch: convert simple overrides of module_alloc to execmem

2023-10-04 Thread Mike Rapoport
On Wed, Oct 04, 2023 at 03:39:26PM +, Edgecombe, Rick P wrote: > On Tue, 2023-10-03 at 17:29 -0700, Rick Edgecombe wrote: > > It seems a bit weird to copy all of this. Is it trying to be faster > > or > > something? > > > > Couldn't it just check r->start in execmem_text/data_alloc() path and

Re: [PATCH 0/4] tracing: improve symbolic printing

2023-10-04 Thread Alan Maguire
On 04/10/2023 22:43, Steven Rostedt wrote: > On Wed, 4 Oct 2023 22:35:07 +0100 > Alan Maguire wrote: > >> One thing we've heard from some embedded folks [1] is that having >> kernel BTF loadable as a separate module (rather than embedded in >> vmlinux) would help, as there are size limits on vmli

Re: [PATCH 0/4] tracing: improve symbolic printing

2023-10-04 Thread Steven Rostedt
On Wed, 4 Oct 2023 22:35:07 +0100 Alan Maguire wrote: > One thing we've heard from some embedded folks [1] is that having > kernel BTF loadable as a separate module (rather than embedded in > vmlinux) would help, as there are size limits on vmlinux that they can > workaround by having modules on

Re: [PATCH 0/4] tracing: improve symbolic printing

2023-10-04 Thread Alan Maguire
On 04/10/2023 18:29, Steven Rostedt wrote: > On Wed, 4 Oct 2023 09:54:31 -0700 > Jakub Kicinski wrote: > >> On Wed, 4 Oct 2023 12:35:24 -0400 Steven Rostedt wrote: Potentially naive question - the trace point holds enum skb_drop_reason. The user space can get the names from BTF. Can we

Re: [PATCH v5 09/18] x86/sgx: Store struct sgx_encl when allocating new VA pages

2023-10-04 Thread Huang, Kai
On Wed, 2023-10-04 at 10:03 -0500, Haitao Huang wrote: > On Tue, 03 Oct 2023 15:07:42 -0500, Huang, Kai wrote: > > > On Tue, 2023-10-03 at 01:45 -0500, Haitao Huang wrote: > > > > > > > > Btw, probably a dumb question: > > > > > > > > Theoretically if you only need to find a victim enclave you

Re: [PATCH v5 06/18] x86/sgx: Introduce EPC page states

2023-10-04 Thread Huang, Kai
On Wed, 2023-10-04 at 10:24 -0500, Haitao Huang wrote: > On Tue, 03 Oct 2023 15:03:48 -0500, Huang, Kai wrote: > > > On Mon, 2023-10-02 at 23:49 -0500, Haitao Huang wrote: > > > On Wed, 27 Sep 2023 05:28:36 -0500, Huang, Kai > > > wrote: > > > > > > > On Fri, 2023-09-22 at 20:06 -0700, Haitao

[PATCH v5] eventfs: Remove eventfs_file and just use eventfs_inode

2023-10-04 Thread Steven Rostedt
From: "Steven Rostedt (Google)" Instead of having a descriptor for every file represented in the eventfs directory, only have the directory itself represented. Change the API to send in a list of entries that represent all the files in the directory (but not other directories). The entry list con

Re: [PATCH] net: appletalk: remove cops support

2023-10-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Wed, 27 Sep 2023 11:00:30 +0200 you wrote: > The COPS Appletalk support is very old, never said to actually work > properly, and the firmware code for the devices are under a very suspect > license. Remove it all

Re: [PATCH v1 1/9] ACPI: bus: Make notify wrappers more generic

2023-10-04 Thread Rafael J. Wysocki
On Mon, Sep 25, 2023 at 6:31 PM Michal Wilczynski wrote: > > acpi_dev_install_notify_handler() and acpi_dev_remove_notify_handler() > are wrappers around ACPICA installers. They are meant to save some > duplicated code from drivers. However as we're moving towards drivers > operating on platform_d

[PATCH v2 72/89] tracefs: convert to new timestamp accessors

2023-10-04 Thread Jeff Layton
Convert to using the new inode timestamp accessor functions. Signed-off-by: Jeff Layton --- fs/tracefs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/tracefs/inode.c b/fs/tracefs/inode.c index 891653ba9cf3..429603d865a9 100644 --- a/fs/tracefs/inode.c +++ b/fs/tra

Re: [PATCH] net: appletalk: remove cops support

2023-10-04 Thread Jakub Kicinski
On Wed, 27 Sep 2023 11:00:30 +0200 Greg Kroah-Hartman wrote: > The COPS Appletalk support is very old, never said to actually work > properly, and the firmware code for the devices are under a very suspect > license. Remove it all to clear up the license issue, if it is still > needed and actually

Re: [PATCH 0/4] tracing: improve symbolic printing

2023-10-04 Thread Steven Rostedt
On Wed, 04 Oct 2023 20:38:46 +0200 Johannes Berg wrote: > On Wed, 2023-10-04 at 09:22 -0700, Jakub Kicinski wrote: > > > > Potentially naive question - the trace point holds enum skb_drop_reason. > > The user space can get the names from BTF. Can we not teach user space > > to generically look u

Re: [PATCH 0/4] tracing: improve symbolic printing

2023-10-04 Thread Johannes Berg
On Wed, 2023-10-04 at 09:22 -0700, Jakub Kicinski wrote: > > Potentially naive question - the trace point holds enum skb_drop_reason. > The user space can get the names from BTF. Can we not teach user space > to generically look up names of enums in BTF? I'll note that, unrelated to the discussio

Re: [PATCH] remoteproc: k3-r5: Wait for core0 power-up before powering up core1

2023-10-04 Thread Mathieu Poirier
On Wed, 4 Oct 2023 at 07:51, Apurva Nandan wrote: > > Hi Mathieu, > > On 11/09/23 22:15, Mathieu Poirier wrote: > > Hi Apurva, > > > > On Wed, Sep 06, 2023 at 06:17:56PM +0530, Apurva Nandan wrote: > >> PSC controller has a limitation that it can only power-up the second core > >> when the first c

Re: [PATCH 0/4] tracing: improve symbolic printing

2023-10-04 Thread Steven Rostedt
On Wed, 4 Oct 2023 09:54:31 -0700 Jakub Kicinski wrote: > On Wed, 4 Oct 2023 12:35:24 -0400 Steven Rostedt wrote: > > > Potentially naive question - the trace point holds enum skb_drop_reason. > > > The user space can get the names from BTF. Can we not teach user space > > > to generically look u

Re: [PATCH v5 01/18] cgroup/misc: Add per resource callbacks for CSS events

2023-10-04 Thread Tejun Heo
Hello, On Wed, Oct 04, 2023 at 10:45:08AM -0500, Haitao Huang wrote: > So I will update to something like following. Let me know if that's correct > understanding. > @tj, I'd appreciate for your input on whether this is acceptable from > cgroups side. Yeah, that's fine by me and I can't tell what

Re: [PATCH 0/4] tracing: improve symbolic printing

2023-10-04 Thread Jakub Kicinski
On Wed, 4 Oct 2023 12:35:24 -0400 Steven Rostedt wrote: > > Potentially naive question - the trace point holds enum skb_drop_reason. > > The user space can get the names from BTF. Can we not teach user space > > to generically look up names of enums in BTF? > > That puts a hard requirement to in

Re: [PATCH 0/4] tracing: improve symbolic printing

2023-10-04 Thread Steven Rostedt
On Wed, 4 Oct 2023 09:22:05 -0700 Jakub Kicinski wrote: > Potentially naive question - the trace point holds enum skb_drop_reason. > The user space can get the names from BTF. Can we not teach user space > to generically look up names of enums in BTF? That puts a hard requirement to include BTF

Re: [PATCH 0/4] tracing: improve symbolic printing

2023-10-04 Thread Jakub Kicinski
On Thu, 21 Sep 2023 10:51:30 +0200 Johannes Berg wrote: > So I was frustrated with not seeing the names of SKB dropreasons > for all but the core reasons, and then while looking into this > all, realized, that the current __print_symbolic() is pretty bad > anyway. > > So I came up with a new appro

Re: [PATCH v5 01/18] cgroup/misc: Add per resource callbacks for CSS events

2023-10-04 Thread Haitao Huang
Hi Jarkko On Mon, 02 Oct 2023 17:55:14 -0500, Jarkko Sakkinen wrote: ... > >> I noticed this one later: > >> > >> It would better to create a separate ops struct and declare the instance > >> as const at minimum. > >> > >> Then there is no need for dynamic assigment of ops and all that is

Re: [PATCH v3 03/13] mm/execmem, arch: convert simple overrides of module_alloc to execmem

2023-10-04 Thread Edgecombe, Rick P
On Tue, 2023-10-03 at 17:29 -0700, Rick Edgecombe wrote: > It seems a bit weird to copy all of this. Is it trying to be faster > or > something? > > Couldn't it just check r->start in execmem_text/data_alloc() path and > switch to EXECMEM_DEFAULT if needed then? The execmem_range_is_data() > part

Re: [PATCH v5 06/18] x86/sgx: Introduce EPC page states

2023-10-04 Thread Haitao Huang
On Tue, 03 Oct 2023 15:03:48 -0500, Huang, Kai wrote: On Mon, 2023-10-02 at 23:49 -0500, Haitao Huang wrote: On Wed, 27 Sep 2023 05:28:36 -0500, Huang, Kai wrote: > On Fri, 2023-09-22 at 20:06 -0700, Haitao Huang wrote: > > Use the lower 3 bits in the flags field of sgx_epc_page struct to

Re: [PATCH v5 09/18] x86/sgx: Store struct sgx_encl when allocating new VA pages

2023-10-04 Thread Haitao Huang
On Tue, 03 Oct 2023 15:07:42 -0500, Huang, Kai wrote: On Tue, 2023-10-03 at 01:45 -0500, Haitao Huang wrote: > > Btw, probably a dumb question: > > Theoretically if you only need to find a victim enclave you don't need > to put VA > pages to the unreclaimable list, because those VA pages will

Re: [PATCH v2] trace: tracing_event_filter: fast path when no subsystem filters

2023-10-04 Thread Steven Rostedt
On Wed, 4 Oct 2023 10:39:33 -0400 Nick Lowell wrote: > > [ cut here ] > > WARNING: CPU: 5 PID: 944 at kernel/trace/trace_events_filter.c:2423 > > apply_subsystem_event_filter+0x18c/0x5e0 > > Modules linked in: > > CPU: 5 PID: 944 Comm: trace-cmd Not tainted > > 6.6.0-

Re: [PATCH v2] trace: tracing_event_filter: fast path when no subsystem filters

2023-10-04 Thread Nick Lowell
On Tue, Oct 3, 2023 at 10:29 PM Steven Rostedt wrote: > > On Mon, 2 Oct 2023 10:41:48 -0400 > Nicholas Lowell wrote: > > > @@ -2411,7 +2418,12 @@ int apply_subsystem_event_filter(struct > > trace_subsystem_dir *dir, > > } > > > > if (!strcmp(strstrip(filter_string), "0")) { > > -

Re: [PATCH] visl: use canonical ftrace path

2023-10-04 Thread Steven Rostedt
On Wed, 4 Oct 2023 16:00:34 +0200 Hans Verkuil wrote: > > The original patch did have linux-me...@vger.kernel.org Cc'd. Was it > > dropped? > > You are correct, it was sitting in patchwork, I somehow missed it. > > It's now delegated to me, so it is in my pipeline. Thanks a lot! I appreciat

Re: [PATCH] visl: use canonical ftrace path

2023-10-04 Thread Hans Verkuil
On 10/4/23 15:57, Steven Rostedt wrote: > On Wed, 4 Oct 2023 08:33:12 +0200 > Hans Verkuil wrote: > >> On 03/10/2023 23:41, Steven Rostedt wrote: >>> >>> Could this go through the linux-media tree, or if you give it an Ack, I'll >>> take it through the tracing tree. >> >> I prefer to take this

Re: [PATCH] visl: use canonical ftrace path

2023-10-04 Thread Steven Rostedt
On Wed, 4 Oct 2023 08:33:12 +0200 Hans Verkuil wrote: > On 03/10/2023 23:41, Steven Rostedt wrote: > > > > Could this go through the linux-media tree, or if you give it an Ack, I'll > > take it through the tracing tree. > > I prefer to take this through the media subsystem. Ross, can you post

Re: [PATCH] remoteproc: k3-r5: Wait for core0 power-up before powering up core1

2023-10-04 Thread Apurva Nandan
Hi Mathieu, On 11/09/23 22:15, Mathieu Poirier wrote: Hi Apurva, On Wed, Sep 06, 2023 at 06:17:56PM +0530, Apurva Nandan wrote: PSC controller has a limitation that it can only power-up the second core when the first core is in ON state. Power-state for core0 should be equal to or higher than

Re: [RFC PATCH] tracing: change syscall number type in struct syscall_trace_*

2023-10-04 Thread Artem Savkov
On Tue, Oct 03, 2023 at 09:38:44PM -0400, Steven Rostedt wrote: > On Mon, 2 Oct 2023 15:52:42 +0200 > Artem Savkov wrote: > > > linux-rt-devel tree contains a patch that adds an extra member to struct > > trace_entry. This causes the offset of args field in struct > > trace_event_raw_sys_enter b

Re: [PATCH V3] tracing/timerlat: Hotplug support for the user-space interface

2023-10-04 Thread Steven Rostedt
On Wed, 4 Oct 2023 08:17:31 -0400 Steven Rostedt wrote: > #!/bin/bash > > find_debugfs() { > debugfs=`cat /proc/mounts | while read mount dir type opts a b; do > if [ $mount == "debugfs" ]; then I guess I should update this to look for tracefs. This script is actually older than trace

Re: [PATCH V3] tracing/timerlat: Hotplug support for the user-space interface

2023-10-04 Thread Steven Rostedt
On Wed, 4 Oct 2023 12:02:52 +0200 Daniel Bristot de Oliveira wrote: > On 10/4/23 03:03, Steven Rostedt wrote: > > On Fri, 29 Sep 2023 17:02:46 +0200 > > Daniel Bristot de Oliveira wrote: > > > >> The osnoise/per_cpu/CPU$/timerlat_fd is create for each possible > >> CPU, but it might create co

Re: [PATCH V3] tracing/timerlat: Hotplug support for the user-space interface

2023-10-04 Thread Daniel Bristot de Oliveira
On 10/4/23 03:03, Steven Rostedt wrote: > On Fri, 29 Sep 2023 17:02:46 +0200 > Daniel Bristot de Oliveira wrote: > >> The osnoise/per_cpu/CPU$/timerlat_fd is create for each possible >> CPU, but it might create confusion if the CPU is not online. >> >> Create the file only for online CPUs, also f

[GIT PULL] rtla: Fixes for 6.6

2023-10-04 Thread Daniel Bristot de Oliveira
Steven, Timerlat auto-analysis: - Timerlat is reporting thread interference time without thread noise events occurrence. It was caused because the thread interference variable was not reset after the analysis of a timerlat activation that did not hit the threshold. - The IRQ hand

Re: [RFC PATCH] tracing: change syscall number type in struct syscall_trace_*

2023-10-04 Thread Artem Savkov
On Tue, Oct 03, 2023 at 03:11:15PM -0700, Andrii Nakryiko wrote: > On Mon, Oct 2, 2023 at 6:53 AM Artem Savkov wrote: > > > > linux-rt-devel tree contains a patch that adds an extra member to struct > > can you please point to the patch itself that makes that change? Of course, some context woul