Re: [RFC PATCH v2 26/31] fprobe: Rewrite fprobe on function-graph tracer

2023-11-09 Thread Google
Hi, On Wed, 8 Nov 2023 23:29:22 +0900 "Masami Hiramatsu (Google)" wrote: > + */ > +static inline int __fprobe_handler(unsigned long ip, unsigned long parent_ip, > +struct fprobe *fp, struct ftrace_regs *fregs, > +void *data) > +{

Re: [RFC v1 3/8] vhost: Add 3 new uapi to support iommufd

2023-11-09 Thread Cindy Lu
Jason Wang 于2023年11月10日周五 10:32写道: > > On Wed, Nov 8, 2023 at 3:09 PM Jason Wang wrote: > > > > On Wed, Nov 8, 2023 at 2:39 PM Cindy Lu wrote: > > > > > > On Wed, Nov 8, 2023 at 11:03 AM Jason Wang wrote: > > > > > > > > On Tue, Nov 7, 2023 at 2:57 PM Cindy Lu wrote: > > > > > > > > > > On

Re: [RFC PATCH v2 12/31] function_graph: Have the instances use their own ftrace_ops for filtering

2023-11-09 Thread Google
On Thu, 9 Nov 2023 21:18:48 -0500 Steven Rostedt wrote: > On Fri, 10 Nov 2023 10:51:54 +0900 > Masami Hiramatsu (Google) wrote: > > > So this patch registers ftrace_ops for each fgraph_ops to ftrace. > > This means that the ftrace_graph_func() will be called twice or more > > on the same

Re: [RFC v1 3/8] vhost: Add 3 new uapi to support iommufd

2023-11-09 Thread Jason Wang
On Wed, Nov 8, 2023 at 3:09 PM Jason Wang wrote: > > On Wed, Nov 8, 2023 at 2:39 PM Cindy Lu wrote: > > > > On Wed, Nov 8, 2023 at 11:03 AM Jason Wang wrote: > > > > > > On Tue, Nov 7, 2023 at 2:57 PM Cindy Lu wrote: > > > > > > > > On Mon, Nov 6, 2023 at 3:30 PM Jason Wang wrote: > > > > > >

Re: [RFC PATCH v2 12/31] function_graph: Have the instances use their own ftrace_ops for filtering

2023-11-09 Thread Steven Rostedt
On Fri, 10 Nov 2023 10:51:54 +0900 Masami Hiramatsu (Google) wrote: > So this patch registers ftrace_ops for each fgraph_ops to ftrace. > This means that the ftrace_graph_func() will be called twice or more > on the same function. > Thus should I call ftrace_startup() once when the first

Re: [RFC PATCH v2 12/31] function_graph: Have the instances use their own ftrace_ops for filtering

2023-11-09 Thread Google
Hi, I found strange behavior that if we set two or more probes on the same function, its callback called twice or more. Also, the stacktrace failed. And I found the root cause is here; On Wed, 8 Nov 2023 23:26:42 +0900 "Masami Hiramatsu (Google)" wrote: > @@ -910,9 +917,10 @@ int

RE: [PATCH] x86/sgx: Charge proper mem_cgroup for usage due to EPC reclamation by cgroups

2023-11-09 Thread Chris Yan (HE/HIM)
Tested by: Chris Yan

Re: [RFC PATCH 07/86] Revert "livepatch,sched: Add livepatch task switching to cond_resched()"

2023-11-09 Thread Steven Rostedt
On Thu, 9 Nov 2023 09:51:18 -0800 Josh Poimboeuf wrote: > > I guess I'm not fully understanding what the cond rescheds are for. But > > would an IPI to all CPUs setting NEED_RESCHED, fix it? > > If all livepatch arches had the ORC unwinder, yes. > > The problem is that frame pointer (and

Re: [RFC PATCH 07/86] Revert "livepatch,sched: Add livepatch task switching to cond_resched()"

2023-11-09 Thread Ankur Arora
Josh Poimboeuf writes: > On Thu, Nov 09, 2023 at 02:50:48PM -0800, Ankur Arora wrote: >> >> I guess I'm not fully understanding what the cond rescheds are for. But >> >> would an IPI to all CPUs setting NEED_RESCHED, fix it? >> >> Yeah. We could just temporarily toggle to full preemption, when

Re: [RFC v1 0/8] vhost-vdpa: add support for iommufd

2023-11-09 Thread Michael S. Tsirkin
On Tue, Nov 07, 2023 at 11:52:17AM -0400, Jason Gunthorpe wrote: > On Tue, Nov 07, 2023 at 09:30:21AM -0500, Michael S. Tsirkin wrote: > > On Tue, Nov 07, 2023 at 10:12:37AM -0400, Jason Gunthorpe wrote: > > > Big company's should take the responsibility to train and provide > > > skill

Re: [RFC PATCH 07/86] Revert "livepatch,sched: Add livepatch task switching to cond_resched()"

2023-11-09 Thread Josh Poimboeuf
On Thu, Nov 09, 2023 at 02:50:48PM -0800, Ankur Arora wrote: > >> I guess I'm not fully understanding what the cond rescheds are for. But > >> would an IPI to all CPUs setting NEED_RESCHED, fix it? > > Yeah. We could just temporarily toggle to full preemption, when > NEED_RESCHED_LAZY is always

Re: [RFC PATCH 07/86] Revert "livepatch,sched: Add livepatch task switching to cond_resched()"

2023-11-09 Thread Ankur Arora
Josh Poimboeuf writes: > On Thu, Nov 09, 2023 at 12:31:47PM -0500, Steven Rostedt wrote: >> On Thu, 9 Nov 2023 09:26:37 -0800 >> Josh Poimboeuf wrote: >> >> > On Tue, Nov 07, 2023 at 06:16:09PM -0500, Steven Rostedt wrote: >> > > On Tue, 7 Nov 2023 13:56:53 -0800 >> > > Ankur Arora wrote:

Re: [RFC PATCH 07/86] Revert "livepatch,sched: Add livepatch task switching to cond_resched()"

2023-11-09 Thread Josh Poimboeuf
On Thu, Nov 09, 2023 at 12:31:47PM -0500, Steven Rostedt wrote: > On Thu, 9 Nov 2023 09:26:37 -0800 > Josh Poimboeuf wrote: > > > On Tue, Nov 07, 2023 at 06:16:09PM -0500, Steven Rostedt wrote: > > > On Tue, 7 Nov 2023 13:56:53 -0800 > > > Ankur Arora wrote: > > > > > > > This reverts

Re: [PATCH kmod v5 5/5] libkmod, depmod, modprobe: Make directory for kernel modules configurable

2023-11-09 Thread Michal Suchánek
On Tue, Oct 17, 2023 at 12:50:15PM -0500, Lucas De Marchi wrote: > On Tue, Jul 18, 2023 at 02:01:56PM +0200, Michal Suchanek wrote: > > Now that modprobe.d is searched under ${prefix}/lib, allow a complete > > transition to files only under ${prefix} by adding a ${module_directory} > >

Re: [PATCH kmod v5 5/5] libkmod, depmod, modprobe: Make directory for kernel modules configurable

2023-11-09 Thread Michal Suchánek
On Wed, Oct 18, 2023 at 03:25:19AM +0200, Jan Engelhardt wrote: > On Tuesday 2023-10-17 19:50, Lucas De Marchi wrote: > >> +AC_ARG_WITH([module_directory], > >> +AS_HELP_STRING([--with-module-directory=DIR], [directory in which > >> to > >> look for kernel modules - typically

Re: [RFC PATCH 07/86] Revert "livepatch,sched: Add livepatch task switching to cond_resched()"

2023-11-09 Thread Steven Rostedt
On Thu, 9 Nov 2023 09:26:37 -0800 Josh Poimboeuf wrote: > On Tue, Nov 07, 2023 at 06:16:09PM -0500, Steven Rostedt wrote: > > On Tue, 7 Nov 2023 13:56:53 -0800 > > Ankur Arora wrote: > > > > > This reverts commit e3ff7c609f39671d1aaff4fb4a8594e14f3e03f8. > > > > > > Note that removing this

Re: [RFC PATCH 07/86] Revert "livepatch,sched: Add livepatch task switching to cond_resched()"

2023-11-09 Thread Josh Poimboeuf
On Tue, Nov 07, 2023 at 06:16:09PM -0500, Steven Rostedt wrote: > On Tue, 7 Nov 2023 13:56:53 -0800 > Ankur Arora wrote: > > > This reverts commit e3ff7c609f39671d1aaff4fb4a8594e14f3e03f8. > > > > Note that removing this commit reintroduces "live patches failing to > > complete within a

Re: [PATCH v7 00/13] selftests/sgx: Fix compilation errors

2023-11-09 Thread Jo Van Bulck
On 08.11.23 21:46, Dave Hansen wrote: Yes, you've missed something. For your reading pleasure: https://www.kernel.org/doc/html/latest/process/2.Process.html?highlight=merge%20window https://www.kernel.org/doc/html/latest/process/maintainer-tip.html My bad, thank you for pointing out the