Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-11-29 Thread Zhu Yanjun
在 2023/5/26 13:46, Liang Chen 写道: The implementation at the moment uses one page per packet in both the normal and XDP path. In addition, introducing a module parameter to enable or disable the usage of page pool (disabled by default). In single-core vm testing environments, it gives a modest

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-11-29 Thread Zhu Yanjun
在 2023/11/30 10:34, Xuan Zhuo 写道: On Wed, 29 Nov 2023 23:29:10 +0800, Zhu Yanjun wrote: 在 2023/11/29 23:22, Zhu Yanjun 写道: 在 2023/11/29 22:59, Michael S. Tsirkin 写道: On Wed, Nov 29, 2023 at 10:50:57PM +0800, Zhu Yanjun wrote: 在 2023/5/26 13:46, Liang Chen 写道: what made you respond to a

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-11-29 Thread Xuan Zhuo
On Wed, 29 Nov 2023 23:29:10 +0800, Zhu Yanjun wrote: > > 在 2023/11/29 23:22, Zhu Yanjun 写道: > > > > 在 2023/11/29 22:59, Michael S. Tsirkin 写道: > >> On Wed, Nov 29, 2023 at 10:50:57PM +0800, Zhu Yanjun wrote: > >>> 在 2023/5/26 13:46, Liang Chen 写道: > >> > >> what made you respond to a patch from

[RFC PATCH v4 0/3] send credit update during setting SO_RCVLOWAT

2023-11-29 Thread Arseniy Krasnov
Hello, DESCRIPTION This patchset fixes old problem with hungup of both rx/tx sides and adds test for it. This happens due to non-default SO_RCVLOWAT value and deferred credit update in virtio/vsock. Link to previous old patchset:

[RFC PATCH v4 2/3] virtio/vsock: send credit update during setting SO_RCVLOWAT

2023-11-29 Thread Arseniy Krasnov
Send credit update message when SO_RCVLOWAT is updated and it is bigger than number of bytes in rx queue. It is needed, because 'poll()' will wait until number of bytes in rx queue will be not smaller than SO_RCVLOWAT, so kick sender to send more data. Otherwise mutual hungup for tx/rx is

Re: [PATCH] dt-bindings: correct white-spaces in examples

2023-11-29 Thread Rob Herring
On Fri, 24 Nov 2023 10:21:21 +0100, Krzysztof Kozlowski wrote: > Use only one and exactly one space around '=' in DTS example. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Merging idea: Rob's DT. > Should apply cleanly on Rob's for-next. > --- >

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-11-29 Thread Zhu Yanjun
在 2023/11/29 23:22, Zhu Yanjun 写道: 在 2023/11/29 22:59, Michael S. Tsirkin 写道: On Wed, Nov 29, 2023 at 10:50:57PM +0800, Zhu Yanjun wrote: 在 2023/5/26 13:46, Liang Chen 写道: what made you respond to a patch from May, now? I want to apply page_pool to our virtio_net. This virtio_net works

Re: [PATCH] tracing: Allow creating instances with specified system events

2023-11-29 Thread Steven Rostedt
On Wed, 29 Nov 2023 23:58:21 +0900 Masami Hiramatsu (Google) wrote: > > - Dynamic events had to be specified directly to still allow them to be > > created. > > I have a question about this point. Does this mean the dynamic event files > will be created in the instance which limits the

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-11-29 Thread Zhu Yanjun
在 2023/11/29 22:59, Michael S. Tsirkin 写道: On Wed, Nov 29, 2023 at 10:50:57PM +0800, Zhu Yanjun wrote: 在 2023/5/26 13:46, Liang Chen 写道: what made you respond to a patch from May, now? I want to apply page_pool to our virtio_net. This virtio_net works on our device. I want to verify

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-11-29 Thread Michael S. Tsirkin
On Wed, Nov 29, 2023 at 10:50:57PM +0800, Zhu Yanjun wrote: > 在 2023/5/26 13:46, Liang Chen 写道: what made you respond to a patch from May, now? -- MST

Re: [PATCH] tracing: Allow creating instances with specified system events

2023-11-29 Thread Google
On Tue, 28 Nov 2023 12:21:17 -0500 Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > A trace instance may only need to enable specific events. As the eventfs > directory of an instance currently creates all events which adds overhead, > allow internal instances to be created with

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-11-29 Thread Zhu Yanjun
在 2023/5/26 13:46, Liang Chen 写道: The implementation at the moment uses one page per packet in both the normal and XDP path. In addition, introducing a module parameter to enable or disable the usage of page pool (disabled by default). In single-core vm testing environments, it gives a modest

Re: [PATCH RFC v2 18/27] arm64: mte: Reserve tag block for the zero page

2023-11-29 Thread Alexandru Elisei
Hi, On Wed, Nov 29, 2023 at 02:13:50PM +0100, David Hildenbrand wrote: > On 29.11.23 12:30, Alexandru Elisei wrote: > > On Tue, Nov 28, 2023 at 06:06:54PM +0100, David Hildenbrand wrote: > > > On 19.11.23 17:57, Alexandru Elisei wrote: > > > > On arm64, the zero page receives special treatment by

[PATCH v5 1/5] x86/paravirt: introduce ALT_NOT_XEN

2023-11-29 Thread Juergen Gross
Introduce the macro ALT_NOT_XEN as a short form of ALT_NOT(X86_FEATURE_XENPV). Suggested-by: Peter Zijlstra (Intel) Signed-off-by: Juergen Gross --- V3: - split off from next patch V5: - move patch to the start of the series (Boris Petkov) --- arch/x86/include/asm/paravirt.h | 42

Re: [PATCH RFC v2 16/27] arm64: mte: Manage tag storage on page allocation

2023-11-29 Thread Alexandru Elisei
Hi, On Wed, Nov 29, 2023 at 06:10:40PM +0900, Hyesoo Yu wrote: > On Sun, Nov 19, 2023 at 04:57:10PM +, Alexandru Elisei wrote: > > [..] > > +static int order_to_num_blocks(int order) > > +{ > > + return max((1 << order) / 32, 1); > > +} > > [..] > > +int reserve_tag_storage(struct page

Re: [PATCH RFC v2 20/27] mm: hugepage: Handle huge page fault on access

2023-11-29 Thread Alexandru Elisei
Hi, On Tue, Nov 28, 2023 at 06:56:34PM +0100, David Hildenbrand wrote: > On 19.11.23 17:57, Alexandru Elisei wrote: > > Handle PAGE_FAULT_ON_ACCESS faults for huge pages in a similar way to > > regular pages. > > > > Signed-off-by: Alexandru Elisei > > --- > > Same comments :) Yes, will have

Re: [PATCH RFC v2 19/27] mm: mprotect: Introduce PAGE_FAULT_ON_ACCESS for mprotect(PROT_MTE)

2023-11-29 Thread Alexandru Elisei
Hi, On Tue, Nov 28, 2023 at 06:55:18PM +0100, David Hildenbrand wrote: > On 19.11.23 17:57, Alexandru Elisei wrote: > > To enable tagging on a memory range, userspace can use mprotect() with the > > PROT_MTE access flag. Pages already mapped in the VMA don't have the > > associated tag storage

Re: [PATCH RFC v2 18/27] arm64: mte: Reserve tag block for the zero page

2023-11-29 Thread Alexandru Elisei
On Tue, Nov 28, 2023 at 06:06:54PM +0100, David Hildenbrand wrote: > On 19.11.23 17:57, Alexandru Elisei wrote: > > On arm64, the zero page receives special treatment by having the tagged > > flag set on MTE initialization, not when the page is mapped in a process > > address space. Reserve the

Re: [PATCH RFC v2 13/27] arm64: mte: Make tag storage depend on ARCH_KEEP_MEMBLOCK

2023-11-29 Thread Alexandru Elisei
Hi, On Tue, Nov 28, 2023 at 06:05:20PM +0100, David Hildenbrand wrote: > On 27.11.23 16:04, Alexandru Elisei wrote: > > Hi, > > > > On Fri, Nov 24, 2023 at 08:51:38PM +0100, David Hildenbrand wrote: > > > On 19.11.23 17:57, Alexandru Elisei wrote: > > > > Tag storage memory requires that the tag

Re: [PATCH RFC v2 12/27] arm64: mte: Add tag storage pages to the MIGRATE_CMA migratetype

2023-11-29 Thread Alexandru Elisei
Hi, On Tue, Nov 28, 2023 at 06:03:52PM +0100, David Hildenbrand wrote: > On 27.11.23 16:01, Alexandru Elisei wrote: > > Hi David, > > > > On Fri, Nov 24, 2023 at 08:40:55PM +0100, David Hildenbrand wrote: > > > On 19.11.23 17:57, Alexandru Elisei wrote: > > > > Add the MTE tag storage pages to

Re: [PATCH v4 4/5] x86/paravirt: switch mixed paravirt/alternative calls to alternative_2

2023-11-29 Thread Juergen Gross
On 21.11.23 19:45, Borislav Petkov wrote: On Mon, Oct 30, 2023 at 03:25:07PM +0100, Juergen Gross wrote: Instead of stacking alternative and paravirt patching, use the new ALT_FLAG_CALL flag to switch those mixed calls to pure alternative handling. This eliminates the need to be careful

Re: [GIT PULL] virtio: features

2023-11-29 Thread Ning, Hongyu
On 2023/11/29 17:16, Jason Wang wrote: On Wed, Nov 29, 2023 at 5:05 PM Ning, Hongyu wrote: On 2023/9/4 6:13, Michael S. Tsirkin wrote: The following changes since commit 2dde18cd1d8fac735875f2e4987f11817cc0bc2c: Linux 6.5 (2023-08-27 14:49:51 -0700) are available in the Git

Re: [PATCH v2 33/33] kmsan: Enable on s390

2023-11-29 Thread Ilya Leoshkevich
On Wed, 2023-11-29 at 10:19 +0100, Alexander Potapenko wrote: > Hi Ilya, > > Sorry for this taking so long, I'll probably take a closer look next > week. > Overall, the s390 part looks good to me, but I wanted to check the > x86 > behavior once again (and perhaps figure out how to avoid

Re: [GIT PULL] virtio: features

2023-11-29 Thread Ning, Hongyu
On 2023/11/29 17:47, Michael S. Tsirkin wrote: On Wed, Nov 29, 2023 at 05:03:50PM +0800, Ning, Hongyu wrote: On 2023/9/4 6:13, Michael S. Tsirkin wrote: The following changes since commit 2dde18cd1d8fac735875f2e4987f11817cc0bc2c: Linux 6.5 (2023-08-27 14:49:51 -0700) are available in

Re: [GIT PULL] virtio: features

2023-11-29 Thread Michael S. Tsirkin
On Wed, Nov 29, 2023 at 05:03:50PM +0800, Ning, Hongyu wrote: > > > On 2023/9/4 6:13, Michael S. Tsirkin wrote: > > The following changes since commit 2dde18cd1d8fac735875f2e4987f11817cc0bc2c: > > > >Linux 6.5 (2023-08-27 14:49:51 -0700) > > > > are available in the Git repository at: > >

Re: [PATCH RFC v2 19/27] mm: mprotect: Introduce PAGE_FAULT_ON_ACCESS for mprotect(PROT_MTE)

2023-11-29 Thread Hyesoo Yu
On Sun, Nov 19, 2023 at 04:57:13PM +, Alexandru Elisei wrote: > To enable tagging on a memory range, userspace can use mprotect() with the > PROT_MTE access flag. Pages already mapped in the VMA don't have the > associated tag storage block reserved, so mark the PTEs as > PAGE_FAULT_ON_ACCESS

Re: [RFC PATCH v3 3/3] vsock/test: SO_RCVLOWAT + deferred credit update test

2023-11-29 Thread Stefano Garzarella
On Wed, Nov 29, 2023 at 12:16:54PM +0300, Arseniy Krasnov wrote: On 29.11.2023 12:16, Stefano Garzarella wrote: On Wed, Nov 22, 2023 at 09:05:10PM +0300, Arseniy Krasnov wrote: Test which checks, that updating SO_RCVLOWAT value also sends credit update message. Otherwise mutual hungup may

Re: [PATCH 1/2] tracing: Simplify and fix "buffered event" synchronization

2023-11-29 Thread Petr Pavlu
On 11/28/23 16:27, Steven Rostedt wrote: > On Tue, 28 Nov 2023 16:05:00 +0100 > Petr Pavlu wrote: > >> On 11/27/23 18:41, Steven Rostedt wrote: >>> On Mon, 27 Nov 2023 16:12:47 +0100 >>> Petr Pavlu wrote: >>> The following warning appears when using buffered events: [ 203.556451]

Re: [PATCH RFC v2 16/27] arm64: mte: Manage tag storage on page allocation

2023-11-29 Thread Hyesoo Yu
On Sun, Nov 19, 2023 at 04:57:10PM +, Alexandru Elisei wrote: > Reserve tag storage for a tagged page by migrating the contents of the tag > storage (if in use for data) and removing the tag storage pages from the > page allocator by calling alloc_contig_range(). > > When all the associated

Re: [PATCH v2 33/33] kmsan: Enable on s390

2023-11-29 Thread Alexander Potapenko
Hi Ilya, Sorry for this taking so long, I'll probably take a closer look next week. Overall, the s390 part looks good to me, but I wanted to check the x86 behavior once again (and perhaps figure out how to avoid introducing another way to disable KMSAN). Do you happen to have a Git repo with your

Re: [GIT PULL] virtio: features

2023-11-29 Thread Jason Wang
On Wed, Nov 29, 2023 at 5:05 PM Ning, Hongyu wrote: > > > > On 2023/9/4 6:13, Michael S. Tsirkin wrote: > > The following changes since commit 2dde18cd1d8fac735875f2e4987f11817cc0bc2c: > > > >Linux 6.5 (2023-08-27 14:49:51 -0700) > > > > are available in the Git repository at: > > > >

Re: [RFC PATCH v3 3/3] vsock/test: SO_RCVLOWAT + deferred credit update test

2023-11-29 Thread Stefano Garzarella
On Wed, Nov 22, 2023 at 09:05:10PM +0300, Arseniy Krasnov wrote: Test which checks, that updating SO_RCVLOWAT value also sends credit update message. Otherwise mutual hungup may happen when receiver didn't send credit update and then calls 'poll()' with non default SO_RCVLOWAT value (e.g.

Re: [GIT PULL] virtio: features

2023-11-29 Thread Ning, Hongyu
On 2023/9/4 6:13, Michael S. Tsirkin wrote: The following changes since commit 2dde18cd1d8fac735875f2e4987f11817cc0bc2c: Linux 6.5 (2023-08-27 14:49:51 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you

Re: [PATCH RFC v2 15/27] arm64: mte: Check that tag storage blocks are in the same zone

2023-11-29 Thread Hyesoo Yu
On Sun, Nov 19, 2023 at 04:57:09PM +, Alexandru Elisei wrote: > alloc_contig_range() requires that the requested pages are in the same > zone. Check that this is indeed the case before initializing the tag > storage blocks. > > Signed-off-by: Alexandru Elisei > --- >

Re: [RFC PATCH v3 2/3] virtio/vsock: send credit update during setting SO_RCVLOWAT

2023-11-29 Thread Stefano Garzarella
On Wed, Nov 22, 2023 at 09:05:09PM +0300, Arseniy Krasnov wrote: Send credit update message when SO_RCVLOWAT is updated and it is bigger than number of bytes in rx queue. It is needed, because 'poll()' will wait until number of bytes in rx queue will be not smaller than SO_RCVLOWAT, so kick

Re: [PATCH RFC v2 11/27] arm64: mte: Reserve tag storage memory

2023-11-29 Thread Hyesoo Yu
Hello. On Sun, Nov 19, 2023 at 04:57:05PM +, Alexandru Elisei wrote: > Allow the kernel to get the size and location of the MTE tag storage > regions from the DTB. This memory is marked as reserved for now. > > The DTB node for the tag storage region is defined as: > > tags0: