Re: [GIT PULL] virtio: features

2023-11-30 Thread Jason Wang
On Thu, Nov 30, 2023 at 5:44 PM Michael S. Tsirkin wrote: > > On Wed, Nov 29, 2023 at 06:20:31PM +0800, Jason Wang wrote: > > On Wed, Nov 29, 2023 at 6:12 PM Ning, Hongyu > > wrote: > > > > > > > > > On 2023/11/29 17:16, Jason Wang wrote: > > > > On Wed, Nov 29, 2023 at 5:05 PM Ning, Hongyu > >

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-11-30 Thread Xuan Zhuo
On Thu, 30 Nov 2023 13:30:40 +0800, Zhu Yanjun wrote: > > 在 2023/11/30 10:34, Xuan Zhuo 写道: > > On Wed, 29 Nov 2023 23:29:10 +0800, Zhu Yanjun wrote: > >> 在 2023/11/29 23:22, Zhu Yanjun 写道: > >>> 在 2023/11/29 22:59, Michael S. Tsirkin 写道: > On Wed, Nov 29, 2023 at 10:50:57PM +0800, Zhu

Re: [PATCH v2] rethook: Use __rcu pointer for rethook::handler

2023-11-30 Thread Google
On Thu, 30 Nov 2023 13:44:55 -0800 JP Kobryn wrote: > On Wed, Nov 29, 2023 at 09:24:22PM +0900, Masami Hiramatsu (Google) wrote: > > From: Masami Hiramatsu (Google) > > > > Since the rethook::handler is an RCU-maganged pointer so that it will > > notice readers the rethook is stopped

ARM Ftrace Function Graph Fails With UNWINDER_FRAME_POINTER

2023-11-30 Thread Justin Chen
Hello, Ran into an odd bug that I am unsure what the solution is. Tested a few kernels versions and they all fail the same. FUNCTION_GRAPH_FP_TEST was enabled with 953f534a7ed6 ("ARM: ftrace: enable HAVE_FUNCTION_GRAPH_FP_TEST"). This test fails when UNWINDER_FRAME_POINTER is enabled.

Re: [PATCH v2] rethook: Use __rcu pointer for rethook::handler

2023-11-30 Thread JP Kobryn
On Wed, Nov 29, 2023 at 09:24:22PM +0900, Masami Hiramatsu (Google) wrote: > From: Masami Hiramatsu (Google) > > Since the rethook::handler is an RCU-maganged pointer so that it will > notice readers the rethook is stopped (unregistered) or not, it should > be an __rcu pointer and use

[PATCH] vhost-vdpa: account iommu allocations

2023-11-30 Thread Pasha Tatashin
iommu allocations should be accounted in order to allow admins to monitor and limit the amount of iommu memory. Signed-off-by: Pasha Tatashin --- drivers/vhost/vdpa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) This patch is spinned of from the series:

Re: [PATCH net-next v5 2/3] virtio/vsock: send credit update during setting SO_RCVLOWAT

2023-11-30 Thread Michael S. Tsirkin
On Thu, Nov 30, 2023 at 03:11:19PM +0100, Stefano Garzarella wrote: > On Thu, Nov 30, 2023 at 08:58:58AM -0500, Michael S. Tsirkin wrote: > > On Thu, Nov 30, 2023 at 04:43:34PM +0300, Arseniy Krasnov wrote: > > > > > > > > > On 30.11.2023 16:42, Michael S. Tsirkin wrote: > > > > On Thu, Nov 30,

Re: [PATCH net-next v5 2/3] virtio/vsock: send credit update during setting SO_RCVLOWAT

2023-11-30 Thread Arseniy Krasnov
On 30.11.2023 20:37, Michael S. Tsirkin wrote: > On Thu, Nov 30, 2023 at 06:41:56PM +0300, Arseniy Krasnov wrote: >> >> >> On 30.11.2023 17:11, Stefano Garzarella wrote: >>> On Thu, Nov 30, 2023 at 08:58:58AM -0500, Michael S. Tsirkin wrote: On Thu, Nov 30, 2023 at 04:43:34PM +0300,

Re: [PATCH RFC v2 21/27] mm: arm64: Handle tag storage pages mapped before mprotect(PROT_MTE)

2023-11-30 Thread Alexandru Elisei
Hi Peter, On Mon, Nov 27, 2023 at 09:39:17PM -0800, Peter Collingbourne wrote: > Hi Alexandru, > > On Sun, Nov 19, 2023 at 8:59 AM Alexandru Elisei > wrote: > > > > Signed-off-by: Alexandru Elisei > > --- > > arch/arm64/include/asm/mte_tag_storage.h | 1 + > >

Re: [PATCH net-next v5 2/3] virtio/vsock: send credit update during setting SO_RCVLOWAT

2023-11-30 Thread Michael S. Tsirkin
On Thu, Nov 30, 2023 at 06:41:56PM +0300, Arseniy Krasnov wrote: > > > On 30.11.2023 17:11, Stefano Garzarella wrote: > > On Thu, Nov 30, 2023 at 08:58:58AM -0500, Michael S. Tsirkin wrote: > >> On Thu, Nov 30, 2023 at 04:43:34PM +0300, Arseniy Krasnov wrote: > >>> > >>> > >>> On 30.11.2023

Re: [PATCH net-next v5 2/3] virtio/vsock: send credit update during setting SO_RCVLOWAT

2023-11-30 Thread Arseniy Krasnov
On 30.11.2023 17:11, Stefano Garzarella wrote: > On Thu, Nov 30, 2023 at 08:58:58AM -0500, Michael S. Tsirkin wrote: >> On Thu, Nov 30, 2023 at 04:43:34PM +0300, Arseniy Krasnov wrote: >>> >>> >>> On 30.11.2023 16:42, Michael S. Tsirkin wrote: >>> > On Thu, Nov 30, 2023 at 04:08:39PM +0300,

Re: [PATCH v2 16/33] mm: slub: Let KMSAN access metadata

2023-11-30 Thread Vlastimil Babka
On 11/21/23 23:01, Ilya Leoshkevich wrote: > Building the kernel with CONFIG_SLUB_DEBUG and CONFIG_KMSAN causes > KMSAN to complain about touching redzones in kfree(). > > Fix by extending the existing KASAN-related metadata_access_enable() > and metadata_access_disable() functions to KMSAN. > >

Re: [PATCH] tracing: Allow creating instances with specified system events

2023-11-30 Thread Google
On Wed, 29 Nov 2023 10:25:45 -0500 Steven Rostedt wrote: > On Wed, 29 Nov 2023 23:58:21 +0900 > Masami Hiramatsu (Google) wrote: > > > > - Dynamic events had to be specified directly to still allow them to be > > > created. > > > > I have a question about this point. Does this mean the

Re: [PATCH RFC v2 19/27] mm: mprotect: Introduce PAGE_FAULT_ON_ACCESS for mprotect(PROT_MTE)

2023-11-30 Thread David Hildenbrand
On 30.11.23 15:33, Alexandru Elisei wrote: On Thu, Nov 30, 2023 at 02:43:48PM +0100, David Hildenbrand wrote: On 30.11.23 14:32, Alexandru Elisei wrote: Hi, On Thu, Nov 30, 2023 at 01:49:34PM +0100, David Hildenbrand wrote: + +out_retry: + put_page(page); + if (vmf->flags &

Re: [PATCH net-next v5 2/3] virtio/vsock: send credit update during setting SO_RCVLOWAT

2023-11-30 Thread Arseniy Krasnov
On 30.11.2023 16:58, Michael S. Tsirkin wrote: > On Thu, Nov 30, 2023 at 04:43:34PM +0300, Arseniy Krasnov wrote: >> >> >> On 30.11.2023 16:42, Michael S. Tsirkin wrote: >>> On Thu, Nov 30, 2023 at 04:08:39PM +0300, Arseniy Krasnov wrote: Send credit update message when SO_RCVLOWAT is

Re: [PATCH net-next v5 2/3] virtio/vsock: send credit update during setting SO_RCVLOWAT

2023-11-30 Thread Michael S. Tsirkin
On Thu, Nov 30, 2023 at 04:43:34PM +0300, Arseniy Krasnov wrote: > > > On 30.11.2023 16:42, Michael S. Tsirkin wrote: > > On Thu, Nov 30, 2023 at 04:08:39PM +0300, Arseniy Krasnov wrote: > >> Send credit update message when SO_RCVLOWAT is updated and it is bigger > >> than number of bytes in rx

Re: [PATCH net-next v5 2/3] virtio/vsock: send credit update during setting SO_RCVLOWAT

2023-11-30 Thread Arseniy Krasnov
On 30.11.2023 16:42, Michael S. Tsirkin wrote: > On Thu, Nov 30, 2023 at 04:08:39PM +0300, Arseniy Krasnov wrote: >> Send credit update message when SO_RCVLOWAT is updated and it is bigger >> than number of bytes in rx queue. It is needed, because 'poll()' will >> wait until number of bytes in

Re: [PATCH RFC v2 19/27] mm: mprotect: Introduce PAGE_FAULT_ON_ACCESS for mprotect(PROT_MTE)

2023-11-30 Thread David Hildenbrand
On 30.11.23 14:32, Alexandru Elisei wrote: Hi, On Thu, Nov 30, 2023 at 01:49:34PM +0100, David Hildenbrand wrote: + +out_retry: + put_page(page); + if (vmf->flags & FAULT_FLAG_VMA_LOCK) + vma_end_read(vma); + if (fault_flag_allow_retry_first(vmf->flags)) { +

Re: [PATCH net-next v5 3/3] vsock/test: SO_RCVLOWAT + deferred credit update test

2023-11-30 Thread Stefano Garzarella
On Thu, Nov 30, 2023 at 04:08:40PM +0300, Arseniy Krasnov wrote: Test which checks, that updating SO_RCVLOWAT value also sends credit update message. Otherwise mutual hungup may happen when receiver didn't send credit update and then calls 'poll()' with non default SO_RCVLOWAT value (e.g.

Re: [PATCH RFC v2 19/27] mm: mprotect: Introduce PAGE_FAULT_ON_ACCESS for mprotect(PROT_MTE)

2023-11-30 Thread Alexandru Elisei
Hi, On Thu, Nov 30, 2023 at 01:49:34PM +0100, David Hildenbrand wrote: > > > > + > > > > +out_retry: > > > > + put_page(page); > > > > + if (vmf->flags & FAULT_FLAG_VMA_LOCK) > > > > + vma_end_read(vma); > > > > + if (fault_flag_allow_retry_first(vmf->flags)) { > >

Re: [PATCH net-next v5 2/3] virtio/vsock: send credit update during setting SO_RCVLOWAT

2023-11-30 Thread Stefano Garzarella
On Thu, Nov 30, 2023 at 04:08:39PM +0300, Arseniy Krasnov wrote: Send credit update message when SO_RCVLOWAT is updated and it is bigger than number of bytes in rx queue. It is needed, because 'poll()' will wait until number of bytes in rx queue will be not smaller than SO_RCVLOWAT, so kick

[PATCH net-next v5 0/3] send credit update during setting SO_RCVLOWAT

2023-11-30 Thread Arseniy Krasnov
Hello, DESCRIPTION This patchset fixes old problem with hungup of both rx/tx sides and adds test for it. This happens due to non-default SO_RCVLOWAT value and deferred credit update in virtio/vsock. Link to previous old patchset:

[PATCH net-next v5 2/3] virtio/vsock: send credit update during setting SO_RCVLOWAT

2023-11-30 Thread Arseniy Krasnov
Send credit update message when SO_RCVLOWAT is updated and it is bigger than number of bytes in rx queue. It is needed, because 'poll()' will wait until number of bytes in rx queue will be not smaller than SO_RCVLOWAT, so kick sender to send more data. Otherwise mutual hungup for tx/rx is

[PATCH net-next v5 1/3] vsock: update SO_RCVLOWAT setting callback

2023-11-30 Thread Arseniy Krasnov
Do not return if transport callback for SO_RCVLOWAT is set (only in error case). In this case we don't need to set 'sk_rcvlowat' field in each transport - only in 'vsock_set_rcvlowat()'. Also, if 'sk_rcvlowat' is now set only in af_vsock.c, change callback name from 'set_rcvlowat' to

[PATCH v12 for-next 4/4] samples: ftrace: Add RISC-V support for SAMPLE_FTRACE_DIRECT[_MULTI]

2023-11-30 Thread Björn Töpel
From: Song Shuai Add RISC-V variants of the ftrace-direct* samples. Tested-by: Evgenii Shatokhin Signed-off-by: Song Shuai Tested-by: Guo Ren Signed-off-by: Guo Ren Acked-by: Björn Töpel --- arch/riscv/Kconfig | 2 + samples/ftrace/ftrace-direct-modify.c |

[PATCH v12 for-next 3/4] riscv: ftrace: Add DYNAMIC_FTRACE_WITH_DIRECT_CALLS support

2023-11-30 Thread Björn Töpel
From: Song Shuai Select the DYNAMIC_FTRACE_WITH_DIRECT_CALLS to provide the register_ftrace_direct[_multi] interfaces allowing users to register the customed trampoline (direct_caller) as the mcount for one or more target functions. And modify_ftrace_direct[_multi] are also provided for

[PATCH v12 for-next 0/4] riscv: ftrace: Miscellaneous ftrace improvements

2023-11-30 Thread Björn Töpel
From: Björn Töpel NB! Song told me that he would not have the time work on this series, so I picked it up. This series includes a three ftrace improvements for RISC-V: 1. Do not require to run recordmcount at build time (patch 1) 2. Simplification of the function graph functionality (patch 2)

Re: [PATCH RFC v2 19/27] mm: mprotect: Introduce PAGE_FAULT_ON_ACCESS for mprotect(PROT_MTE)

2023-11-30 Thread Alexandru Elisei
Hi, On Wed, Nov 29, 2023 at 06:27:25PM +0900, Hyesoo Yu wrote: > On Sun, Nov 19, 2023 at 04:57:13PM +, Alexandru Elisei wrote: > > To enable tagging on a memory range, userspace can use mprotect() with the > > PROT_MTE access flag. Pages already mapped in the VMA don't have the > > associated

Re: [PATCH RFC v2 11/27] arm64: mte: Reserve tag storage memory

2023-11-30 Thread Alexandru Elisei
Hi, On Wed, Nov 29, 2023 at 05:44:24PM +0900, Hyesoo Yu wrote: > Hello. > > On Sun, Nov 19, 2023 at 04:57:05PM +, Alexandru Elisei wrote: > > Allow the kernel to get the size and location of the MTE tag storage > > regions from the DTB. This memory is marked as reserved for now. > > > > The

Re: [GIT PULL] virtio: features

2023-11-30 Thread Michael S. Tsirkin
On Wed, Nov 29, 2023 at 06:20:31PM +0800, Jason Wang wrote: > On Wed, Nov 29, 2023 at 6:12 PM Ning, Hongyu > wrote: > > > > > > On 2023/11/29 17:16, Jason Wang wrote: > > > On Wed, Nov 29, 2023 at 5:05 PM Ning, Hongyu > > > wrote: > > >> > > >> > > >> > > >> On 2023/9/4 6:13, Michael S. Tsirkin

Re: [RFC PATCH v4 2/3] virtio/vsock: send credit update during setting SO_RCVLOWAT

2023-11-30 Thread Arseniy Krasnov
On 30.11.2023 11:38, Stefano Garzarella wrote: > On Thu, Nov 30, 2023 at 12:25:18AM +0300, Arseniy Krasnov wrote: >> Send credit update message when SO_RCVLOWAT is updated and it is bigger >> than number of bytes in rx queue. It is needed, because 'poll()' will >> wait until number of bytes in

Re: [RFC PATCH v4 3/3] vsock/test: SO_RCVLOWAT + deferred credit update test

2023-11-30 Thread Stefano Garzarella
On Thu, Nov 30, 2023 at 12:25:19AM +0300, Arseniy Krasnov wrote: Test which checks, that updating SO_RCVLOWAT value also sends credit update message. Otherwise mutual hungup may happen when receiver didn't send credit update and then calls 'poll()' with non default SO_RCVLOWAT value (e.g.

Re: [RFC PATCH v4 2/3] virtio/vsock: send credit update during setting SO_RCVLOWAT

2023-11-30 Thread Stefano Garzarella
On Thu, Nov 30, 2023 at 12:25:18AM +0300, Arseniy Krasnov wrote: Send credit update message when SO_RCVLOWAT is updated and it is bigger than number of bytes in rx queue. It is needed, because 'poll()' will wait until number of bytes in rx queue will be not smaller than SO_RCVLOWAT, so kick