[PATCH 12/27] tty: hvc: convert to u8 and size_t

2023-12-05 Thread Jiri Slaby (SUSE)
Switch character types to u8 and sizes to size_t. To conform to characters/sizes in the rest of the tty layer. Signed-off-by: Jiri Slaby (SUSE) Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Christophe Leroy Cc: Amit Shah Cc: Arnd Bergmann Cc: Paul Walmsley Cc: Palmer Dabbelt Cc: Albert Ou

[PATCH] hwspinlock/core: fix kernel-doc warnings

2023-12-05 Thread Randy Dunlap
Correct function comments to prevent kernel-doc warnings found when using "W=1". hwspinlock_core.c:208: warning: Excess function parameter 'timeout' description in '__hwspin_lock_timeout' hwspinlock_core.c:318: warning: Excess function parameter 'bank' description in

[PATCH v2] tracing: Allow creating instances with specified system events

2023-12-05 Thread Steven Rostedt
From: "Steven Rostedt (Google)" A trace instance may only need to enable specific events. As the eventfs directory of an instance currently creates all events which adds overhead, allow internal instances to be created with just the events in systems that they care about. This currently only

[PATCH v2 2/3] tracing: Stop current tracer when resizing buffer

2023-12-05 Thread Steven Rostedt
From: "Steven Rostedt (Google)" When the ring buffer is being resized, it can cause side effects to the running tracer. For instance, there's a race with irqsoff tracer that swaps individual per cpu buffers between the main buffer and the snapshot buffer. The resize operation modifies the main

[PATCH v2 1/3] tracing: Always update snapshot buffer size

2023-12-05 Thread Steven Rostedt
From: "Steven Rostedt (Google)" It use to be that only the top level instance had a snapshot buffer (for latency tracers like wakeup and irqsoff). The update of the ring buffer size would check if the instance was the top level and if so, it would also update the snapshot buffer as it needs to

[PATCH v2 3/3] tracing: Disable snapshot buffer when stopping instance tracers

2023-12-05 Thread Steven Rostedt
From: "Steven Rostedt (Google)" It use to be that only the top level instance had a snapshot buffer (for latency tracers like wakeup and irqsoff). When stopping a tracer in an instance would not disable the snapshot buffer. This could have some unintended consequences if the irqsoff tracer is

[PATCH v2 0/3] tracing: Keep instance main and snapshot buffers in sync

2023-12-05 Thread Steven Rostedt
Fix keeping instance buffers in sync. That is, when the main ring buffer size is updated, the size of the instance snapshot buffer also needs to be updated if it is allocated. Changes since v1: https://lore.kernel.org/all/20231205115223.5256e...@gandalf.local.home/ - That was just patch 3

Re: [PATCH net-next] tcp: add tracepoints for data send/recv/acked

2023-12-05 Thread Steven Rostedt
On Tue, 5 Dec 2023 20:39:28 +0100 Eric Dumazet wrote: > > So, we do not want to add some tracepoint to do some unknow debug. > > We have a clear goal. debugging is just an incidental capability. > > > > We have powerful mechanisms in the stack already that ordinary (no > privilege requested)

Re: [net-next PATCH v3 3/3] net: phy: add support for PHY package MMD read/write

2023-12-05 Thread Andrew Lunn
> Having worked with closed-source systems, especially VxWorks, for many > years (where the header files contain all the documentation), it just > seems strange to embed the documentation in the .c files. The key words here might be closed-source. With such black boxes, you don't have access the

Re: [PATCH] ipvs: add a stateless type of service and a stateless Maglev hashing scheduler

2023-12-05 Thread Julian Anastasov
Hello, On Mon, 4 Dec 2023, Lev Pantiukhin wrote: > Maglev Hashing Stateless > > > Introduction > > > This patch to Linux kernel provides the following changes to IPVS: > > 1. Adds a new type (IP_VS_SVC_F_STATELESS) of scheduler that computes the

Re: [net-next PATCH v3 3/3] net: phy: add support for PHY package MMD read/write

2023-12-05 Thread Jeff Johnson
On 12/5/2023 10:14 AM, Russell King (Oracle) wrote: > On Tue, Dec 05, 2023 at 09:44:05AM -0800, Jeff Johnson wrote: >> So in my experience a function prototype IS the function definition, and >> the actual function is just the implementation of that definition. >> >> But that thinking obviously

Re: [PATCH net-next] tcp: add tracepoints for data send/recv/acked

2023-12-05 Thread Eric Dumazet
On Tue, Dec 5, 2023 at 3:11 AM Xuan Zhuo wrote: > > On Mon, 4 Dec 2023 13:28:21 +0100, Eric Dumazet wrote: > > On Mon, Dec 4, 2023 at 12:43 PM Philo Lu wrote: > > > > > > Add 3 tracepoints, namely tcp_data_send/tcp_data_recv/tcp_data_acked, > > > which will be called every time a tcp data

Re: [PATCH] tracing: Allow creating instances with specified system events

2023-12-05 Thread Steven Rostedt
On Tue, 5 Dec 2023 19:13:09 +0100 Dmytro Maluka wrote: > On Tue, Nov 28, 2023 at 12:21:17PM -0500, Steven Rostedt wrote: > > From: "Steven Rostedt (Google)" > > > > A trace instance may only need to enable specific events. As the eventfs > > directory of an instance currently creates all

Re: [net-next PATCH v3 3/3] net: phy: add support for PHY package MMD read/write

2023-12-05 Thread Russell King (Oracle)
On Tue, Dec 05, 2023 at 09:44:05AM -0800, Jeff Johnson wrote: > On 12/5/2023 8:11 AM, Russell King (Oracle) wrote: > > On Tue, Dec 05, 2023 at 07:29:12AM -0800, Jakub Kicinski wrote: > >> On Tue, 5 Dec 2023 15:10:50 + Russell King (Oracle) wrote: > >>> I've raised this before in other

Re: [PATCH] tracing: Allow creating instances with specified system events

2023-12-05 Thread Dmytro Maluka
On Tue, Nov 28, 2023 at 12:21:17PM -0500, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > A trace instance may only need to enable specific events. As the eventfs > directory of an instance currently creates all events which adds overhead, > allow internal instances to be created

Re: [PATCH net-next v6 3/4] virtio/vsock: fix logic which reduces credit update messages

2023-12-05 Thread Arseniy Krasnov
On 05.12.2023 17:21, Stefano Garzarella wrote: > On Tue, Dec 05, 2023 at 03:07:47PM +0300, Arseniy Krasnov wrote: >> >> >> On 05.12.2023 13:54, Stefano Garzarella wrote: >>> On Tue, Dec 05, 2023 at 09:48:05AM +0300, Arseniy Krasnov wrote: Add one more condition for sending credit update

Re: [net-next PATCH v3 3/3] net: phy: add support for PHY package MMD read/write

2023-12-05 Thread Jeff Johnson
On 12/5/2023 8:11 AM, Russell King (Oracle) wrote: > On Tue, Dec 05, 2023 at 07:29:12AM -0800, Jakub Kicinski wrote: >> On Tue, 5 Dec 2023 15:10:50 + Russell King (Oracle) wrote: >>> I've raised this before in other subsystems, and it's suggested that >>> it's better to have it in the .c file.

Re: [PATCH] tracing: Always update snapshot buffer size

2023-12-05 Thread Steven Rostedt
On Tue, 5 Dec 2023 11:52:23 -0500 Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > It use to be that only the top level instance had a snapshot buffer (for > latency tracers like wakeup and irqsoff). The update of the ring buffer > size would check if the instance was the top level

[PATCH] tracing: Always update snapshot buffer size

2023-12-05 Thread Steven Rostedt
From: "Steven Rostedt (Google)" It use to be that only the top level instance had a snapshot buffer (for latency tracers like wakeup and irqsoff). The update of the ring buffer size would check if the instance was the top level and if so, it would also update the snapshot buffer as it needs to

[PATCH v2 3/3] tracing: Fix a possible race when disabling buffered events

2023-12-05 Thread Petr Pavlu
Function trace_buffered_event_disable() is responsible for freeing pages backing buffered events and this process can run concurrently with trace_event_buffer_lock_reserve(). The following race is currently possible: * Function trace_buffered_event_disable() is called on CPU 0. It increments

[PATCH v2 2/3] tracing: Fix a warning when allocating buffered events fails

2023-12-05 Thread Petr Pavlu
Function trace_buffered_event_disable() produces an unexpected warning when the previous call to trace_buffered_event_enable() fails to allocate pages for buffered events. The situation can occur as follows: * The counter trace_buffered_event_ref is at 0. * The soft mode gets enabled for some

[PATCH v2 1/3] tracing: Fix incomplete locking when disabling buffered events

2023-12-05 Thread Petr Pavlu
The following warning appears when using buffered events: [ 203.556451] WARNING: CPU: 53 PID: 10220 at kernel/trace/ring_buffer.c:3912 ring_buffer_discard_commit+0x2eb/0x420 [...] [ 203.670690] CPU: 53 PID: 10220 Comm: stress-ng-sysin Tainted: GE 6.7.0-rc2-default #4

[PATCH v2 0/3] tracing: Simplify and fix "buffered event" synchronization

2023-12-05 Thread Petr Pavlu
Fix a few problems related to the maintenance of buffered events. Changes since v1 [1]: * Address found problems individually. The approach in v1 tried to simplify the buffered event synchronization but had performance issues. [1]

Re: [PATCH 1/2] tracing: Simplify and fix "buffered event" synchronization

2023-12-05 Thread Petr Pavlu
On 12/1/23 15:46, Steven Rostedt wrote: > On Fri, 1 Dec 2023 15:17:35 +0100 > Petr Pavlu wrote: > >> Ok, keeping the current approach, my plan for v2 is to prepare the >> following patches: >> >> [...] >> * Fix the potential race between trace_buffered_event_enable() and >>

Re: [net-next PATCH v3 3/3] net: phy: add support for PHY package MMD read/write

2023-12-05 Thread Russell King (Oracle)
On Tue, Dec 05, 2023 at 07:29:12AM -0800, Jakub Kicinski wrote: > On Tue, 5 Dec 2023 15:10:50 + Russell King (Oracle) wrote: > > I've raised this before in other subsystems, and it's suggested that > > it's better to have it in the .c file. I guess the reason is that it's > > more obvious that

Re: [net-next PATCH v3 3/3] net: phy: add support for PHY package MMD read/write

2023-12-05 Thread Jakub Kicinski
On Tue, 5 Dec 2023 15:10:50 + Russell King (Oracle) wrote: > I've raised this before in other subsystems, and it's suggested that > it's better to have it in the .c file. I guess the reason is that it's > more obvious that the function is documented when modifying it, so > there's a higher

Re: [PATCH v6 2/3] arm64: dts: qcom: sc7280: Add UFS nodes for sc7280 soc

2023-12-05 Thread Manivannan Sadhasivam
On Tue, Dec 05, 2023 at 03:38:55PM +0100, Luca Weiss wrote: > From: Nitin Rawat > > Add UFS host controller and PHY nodes for sc7280 soc. > > Signed-off-by: Nitin Rawat > Reviewed-by: Konrad Dybcio > Tested-by: Konrad Dybcio # QCM6490 FP5 > [luca: various cleanups and additions as written in

Re: [PATCH v3 5/5] input/touchscreen: imagis: add support for IST3032C

2023-12-05 Thread kernel test robot
Hi Karel, kernel test robot noticed the following build warnings: [auto build test WARNING on dtor-input/next] [also build test WARNING on dtor-input/for-linus robh/for-next linus/master v6.7-rc4 next-20231205] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH v3 12/33] function_graph: Have the instances use their own ftrace_ops for filtering

2023-12-05 Thread Google
Hi, On Mon, 27 Nov 2023 22:55:22 +0900 "Masami Hiramatsu (Google)" wrote: > @@ -243,6 +254,27 @@ ftrace_push_return_trace(unsigned long ret, unsigned > long func, > if (!current->ret_stack) > return -EBUSY; > > + if (ret == (unsigned >

[PATCH v6 2/3] arm64: dts: qcom: sc7280: Add UFS nodes for sc7280 soc

2023-12-05 Thread Luca Weiss
From: Nitin Rawat Add UFS host controller and PHY nodes for sc7280 soc. Signed-off-by: Nitin Rawat Reviewed-by: Konrad Dybcio Tested-by: Konrad Dybcio # QCM6490 FP5 [luca: various cleanups and additions as written in the cover letter] Signed-off-by: Luca Weiss ---

[PATCH v6 1/3] scsi: ufs: qcom: dt-bindings: Add SC7280 compatible string

2023-12-05 Thread Luca Weiss
From: Nitin Rawat Document the compatible string for the UFS found on SC7280. Signed-off-by: Nitin Rawat Reviewed-by: Krzysztof Kozlowski Reviewed-by: Bao D. Nguyen Acked-by: Manivannan Sadhasivam Signed-off-by: Luca Weiss --- Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 ++ 1

[PATCH v6 3/3] arm64: dts: qcom: sc7280: Add UFS nodes for sc7280 IDP board

2023-12-05 Thread Luca Weiss
From: Nitin Rawat Add UFS host controller and PHY nodes for sc7280 IDP board. Signed-off-by: Nitin Rawat Acked-by: Manivannan Sadhasivam Signed-off-by: Luca Weiss --- arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 19 +++ 1 file changed, 19 insertions(+) diff --git

[PATCH v6 0/3] Add UFS host controller and Phy nodes for sc7280

2023-12-05 Thread Luca Weiss
This patch adds UFS host controller and Phy nodes for Qualcomm sc7280 SoC and enable it on some sc7280-based boards. Pick up the patchset from Nitin since the last revision (v4) has been sent end of September and is blocking qcm6490-fairphone-fp5 UFS. --- Changes in v6: - Use MX power domain for

Re: [PATCH net-next v6 3/4] virtio/vsock: fix logic which reduces credit update messages

2023-12-05 Thread Stefano Garzarella
On Tue, Dec 05, 2023 at 03:07:47PM +0300, Arseniy Krasnov wrote: On 05.12.2023 13:54, Stefano Garzarella wrote: On Tue, Dec 05, 2023 at 09:48:05AM +0300, Arseniy Krasnov wrote: Add one more condition for sending credit update during dequeue from stream socket: when number of bytes in the rx

Re: [PATCH v5 2/3] arm64: dts: qcom: sc7280: Add UFS nodes for sc7280 soc

2023-12-05 Thread Manivannan Sadhasivam
On Tue, Dec 05, 2023 at 08:51:05AM +0100, Luca Weiss wrote: > On Mon Dec 4, 2023 at 6:28 PM CET, Manivannan Sadhasivam wrote: > > On Mon, Dec 04, 2023 at 01:21:42PM +0100, Luca Weiss wrote: > > > On Mon Dec 4, 2023 at 1:15 PM CET, Nitin Rawat wrote: > > > > > > > > > > > > On 12/4/2023 3:54 PM,

Re: [PATCH net-next v6 3/4] virtio/vsock: fix logic which reduces credit update messages

2023-12-05 Thread Arseniy Krasnov
On 05.12.2023 13:54, Stefano Garzarella wrote: > On Tue, Dec 05, 2023 at 09:48:05AM +0300, Arseniy Krasnov wrote: >> Add one more condition for sending credit update during dequeue from >> stream socket: when number of bytes in the rx queue is smaller than >> SO_RCVLOWAT value of the socket.

Re: [PATCH v2] 9p: prevent read overrun in protocol dump tracepoint

2023-12-05 Thread Christian Schoenebeck
On Monday, December 4, 2023 9:23:20 PM CET JP Kobryn wrote: > An out of bounds read can occur within the tracepoint 9p_protocol_dump. In > the fast assign, there is a memcpy that uses a constant size of 32 (macro > named P9_PROTO_DUMP_SZ). When the copy is invoked, the source buffer is not >

[PATCH net-next 6/6] tools: virtio: introduce vhost_net_test

2023-12-05 Thread Yunsheng Lin
introduce vhost_net_test basing on virtio_test to test vhost_net changing in the kernel. Signed-off-by: Yunsheng Lin --- tools/virtio/Makefile | 8 +- tools/virtio/vhost_net_test.c | 441 ++ 2 files changed, 446 insertions(+), 3 deletions(-) create

[PATCH net-next 5/6] net: introduce page_frag_cache_drain()

2023-12-05 Thread Yunsheng Lin
When draining a page_frag_cache, most user are doing the similar steps, so introduce an API to avoid code duplication. Signed-off-by: Yunsheng Lin --- drivers/net/ethernet/google/gve/gve_main.c | 11 ++- drivers/net/ethernet/mediatek/mtk_wed_wo.c | 17 ++---

[PATCH net-next 4/6] vhost/net: remove vhost_net_page_frag_refill()

2023-12-05 Thread Yunsheng Lin
The page frag in vhost_net_page_frag_refill() uses the 'struct page_frag' from skb_page_frag_refill(), but it's implementation is similar to page_frag_alloc_align() now. This patch removes vhost_net_page_frag_refill() by using 'struct page_frag_cache' instead of 'struct page_frag', and allocating

[PATCH net-next 2/6] page_frag: unify gfp bit for order 3 page allocation

2023-12-05 Thread Yunsheng Lin
Currently there seems to be three page frag implementions which all try to allocate order 3 page, if that fails, it then fail back to allocate order 0 page, and each of them all allow order 3 page allocation to fail under certain condition by using specific gfp bits. The gfp bits for order 3 page

Re: [PATCH v5 2/3] arm64: dts: qcom: sc7280: Add UFS nodes for sc7280 soc

2023-12-05 Thread Dmitry Baryshkov
On 05/12/2023 10:45, Nitin Rawat wrote: On 12/4/2023 10:58 PM, Manivannan Sadhasivam wrote: On Mon, Dec 04, 2023 at 01:21:42PM +0100, Luca Weiss wrote: On Mon Dec 4, 2023 at 1:15 PM CET, Nitin Rawat wrote: On 12/4/2023 3:54 PM, Luca Weiss wrote: From: Nitin Rawat Add UFS host

Re: [PATCH net-next v6 4/4] vsock/test: two tests to check credit update logic

2023-12-05 Thread Stefano Garzarella
On Tue, Dec 05, 2023 at 09:48:06AM +0300, Arseniy Krasnov wrote: Both tests are almost same, only differs in two 'if' conditions, so implemented in a single function. Tests check, that credit update message is sent: 1) During setting SO_RCVLOWAT value of the socket. 2) When number of 'rx_bytes'

Re: [PATCH net-next v6 3/4] virtio/vsock: fix logic which reduces credit update messages

2023-12-05 Thread Stefano Garzarella
On Tue, Dec 05, 2023 at 09:48:05AM +0300, Arseniy Krasnov wrote: Add one more condition for sending credit update during dequeue from stream socket: when number of bytes in the rx queue is smaller than SO_RCVLOWAT value of the socket. This is actual for non-default value of SO_RCVLOWAT (e.g. not

[PATCH vhost v2 8/8] vdpa/mlx5: Add mkey leak detection

2023-12-05 Thread Dragos Tatulea
Track allocated mrs in a list and show warning when leaks are detected on device free or reset. Signed-off-by: Dragos Tatulea Reviewed-by: Gal Pressman --- drivers/vdpa/mlx5/core/mlx5_vdpa.h | 2 ++ drivers/vdpa/mlx5/core/mr.c| 23 +++

[PATCH vhost v2 7/8] vdpa/mlx5: Introduce reference counting to mrs

2023-12-05 Thread Dragos Tatulea
Deleting the old mr during mr update (.set_map) and then modifying the vqs with the new mr is not a good flow for firmware. The firmware expects that mkeys are deleted after there are no more vqs referencing them. Introduce reference counting for mrs to fix this. It is the only way to make sure

[PATCH vhost v2 6/8] vdpa/mlx5: Use vq suspend/resume during .set_map

2023-12-05 Thread Dragos Tatulea
Instead of tearing down and setting up vq resources, use vq suspend/resume during .set_map to speed things up a bit. The vq mr is updated with the new mapping while the vqs are suspended. If the device doesn't support resumable vqs, do the old teardown and setup dance. Signed-off-by: Dragos

[PATCH vhost v2 5/8] vdpa/mlx5: Mark vq state for modification in hw vq

2023-12-05 Thread Dragos Tatulea
.set_vq_state will set the indices and mark the fields to be modified in the hw vq. Signed-off-by: Dragos Tatulea Reviewed-by: Gal Pressman Acked-by: Eugenio Pérez --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 8 include/linux/mlx5/mlx5_ifc_vdpa.h | 2 ++ 2 files changed, 10 insertions(+)

[PATCH vhost v2 4/8] vdpa/mlx5: Mark vq addrs for modification in hw vq

2023-12-05 Thread Dragos Tatulea
Addresses get set by .set_vq_address. hw vq addresses will be updated on next modify_virtqueue. Signed-off-by: Dragos Tatulea Reviewed-by: Gal Pressman Acked-by: Eugenio Pérez --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 9 + include/linux/mlx5/mlx5_ifc_vdpa.h | 1 + 2 files changed, 10

[PATCH vhost v2 3/8] vdpa/mlx5: Introduce per vq and device resume

2023-12-05 Thread Dragos Tatulea
Implement vdpa vq and device resume if capability detected. Add support for suspend -> ready state change. Signed-off-by: Dragos Tatulea Reviewed-by: Gal Pressman Acked-by: Eugenio Pérez --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 69 +++ 1 file changed, 62

[PATCH mlx5-vhost v2 1/8] vdpa/mlx5: Expose resumable vq capability

2023-12-05 Thread Dragos Tatulea
Necessary for checking if resumable vqs are supported by the hardware. Actual support will be added in a downstream patch. Signed-off-by: Dragos Tatulea Reviewed-by: Gal Pressman Acked-by: Eugenio Pérez --- include/linux/mlx5/mlx5_ifc.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH vhost v2 2/8] vdpa/mlx5: Allow modifying multiple vq fields in one modify command

2023-12-05 Thread Dragos Tatulea
Add a bitmask variable that tracks hw vq field changes that are supposed to be modified on next hw vq change command. This will be useful to set multiple vq fields when resuming the vq. Signed-off-by: Dragos Tatulea Reviewed-by: Gal Pressman --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 48

[PATCH vhost v2 0/8] vdpa/mlx5: Add support for resumable vqs

2023-12-05 Thread Dragos Tatulea
Add support for resumable vqs in the driver. This is a firmware feature that can be used for the following benefits: - Full device .suspend/.resume. - .set_map doesn't need to destroy and create new vqs anymore just to update the map. When resumable vqs are supported it is enough to suspend

Re: [PATCH v3 3/5] input/touchscreen: imagis: Add support for Imagis IST3038B

2023-12-05 Thread kernel test robot
Hi Karel, kernel test robot noticed the following build warnings: [auto build test WARNING on dtor-input/next] [also build test WARNING on dtor-input/for-linus robh/for-next linus/master v6.7-rc4 next-20231205] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH v2] 9p: prevent read overrun in protocol dump tracepoint

2023-12-05 Thread asmadeus
JP Kobryn wrote on Mon, Dec 04, 2023 at 12:23:20PM -0800: > An out of bounds read can occur within the tracepoint 9p_protocol_dump. In > the fast assign, there is a memcpy that uses a constant size of 32 (macro > named P9_PROTO_DUMP_SZ). When the copy is invoked, the source buffer is not >

Re: [PATCH v5 2/3] arm64: dts: qcom: sc7280: Add UFS nodes for sc7280 soc

2023-12-05 Thread Nitin Rawat
On 12/4/2023 10:58 PM, Manivannan Sadhasivam wrote: On Mon, Dec 04, 2023 at 01:21:42PM +0100, Luca Weiss wrote: On Mon Dec 4, 2023 at 1:15 PM CET, Nitin Rawat wrote: On 12/4/2023 3:54 PM, Luca Weiss wrote: From: Nitin Rawat Add UFS host controller and PHY nodes for sc7280 soc.