Re: [PATCH v2] virtio: Add support for no-reset virtio PCI PM

2023-12-10 Thread Jason Wang
On Fri, Dec 8, 2023 at 3:09 PM David Stevens wrote: > > If a virtio_pci_device supports native PCI power management and has the > No_Soft_Reset bit set, then skip resetting and reinitializing the device > when suspending and restoring the device. This allows system-wide low > power states like

Re: Re: Re: EEVDF/vhost regression (bisected to 86bfbb7ce4f6 sched/fair: Add lag based placement)

2023-12-10 Thread Jason Wang
On Sat, Dec 9, 2023 at 6:42 PM Michael S. Tsirkin wrote: > > On Fri, Dec 08, 2023 at 12:41:38PM +0100, Tobias Huschle wrote: > > On Fri, Dec 08, 2023 at 05:31:18AM -0500, Michael S. Tsirkin wrote: > > > On Fri, Dec 08, 2023 at 10:24:16AM +0100, Tobias Huschle wrote: > > > > On Thu, Dec 07, 2023

Re: [PATCH v6 2/2] kbuild: rpm-pkg: Fix build with non-default MODLIB

2023-12-10 Thread Masahiro Yamada
On Mon, Dec 11, 2023 at 6:09 AM Michal Suchánek wrote: > > On Mon, Dec 11, 2023 at 03:44:35AM +0900, Masahiro Yamada wrote: > > On Thu, Dec 7, 2023 at 4:48 AM Michal Suchanek wrote: > > > > > > The default MODLIB value is composed of three variables > > > > > > MODLIB =

Re: [PATCH v6 1/2] depmod: Handle installing modules under a different directory

2023-12-10 Thread Masahiro Yamada
On Mon, Dec 11, 2023 at 6:07 AM Michal Suchánek wrote: > > Hello! > > On Mon, Dec 11, 2023 at 03:43:44AM +0900, Masahiro Yamada wrote: > > On Thu, Dec 7, 2023 at 4:48 AM Michal Suchanek wrote: > > > > > > Some distributions aim at shipping all files in /usr. > > > > > > The path under which

[PATCH] tracing: Update snapshot buffer on resize if it is allocated

2023-12-10 Thread Steven Rostedt
From: "Steven Rostedt (Google)" The snapshot buffer is to mimic the main buffer so that when a snapshot is needed, the snapshot and main buffer are swapped. When the snapshot buffer is allocated, it is set to the minimal size that the ring buffer may be at and still functional. When it is

[PATCH] ring-buffer: Fix memory leak of free page

2023-12-10 Thread Steven Rostedt
From: "Steven Rostedt (Google)" Reading the ring buffer does a swap of a sub-buffer within the ring buffer with a empty sub-buffer. This allows the reader to have full access to the content of the sub-buffer that was swapped out without having to worry about contention with the writer. The

Re: [PATCH] ARM: dts: qcom: Disable pm8941 & pm8226 smbb charger by default

2023-12-10 Thread Bjorn Andersson
On Sun, 03 Dec 2023 15:19:18 +0100, Luca Weiss wrote: > Some platforms don't use the built-in charging hardware (e.g. milletwifi). > As this is an optional peripheral, default it to off. > > Keep it enabled for all other boards that use smbb. > > Applied, thanks! [1/1] ARM: dts: qcom:

Re: (subset) [PATCH v2 0/2] Small dtsi fixes for msm8953 SoC

2023-12-10 Thread Bjorn Andersson
On Sat, 25 Nov 2023 13:19:26 +0100, Luca Weiss wrote: > Fix some small things in the qcom/msm8953.dtsi file to make dtbs_check > happier than before. > > Applied, thanks! [1/2] arm64: dts: qcom: msm8953: Set initial address for memory commit: 24187868e195202c67c38bcc3ae28f9c6a663fb4

Re: (subset) [PATCH v6 0/3] Add UFS host controller and Phy nodes for sc7280

2023-12-10 Thread Bjorn Andersson
On Tue, 05 Dec 2023 15:38:53 +0100, Luca Weiss wrote: > This patch adds UFS host controller and Phy nodes for Qualcomm sc7280 > SoC and enable it on some sc7280-based boards. > > Pick up the patchset from Nitin since the last revision (v4) has been > sent end of September and is blocking

Re: (subset) [PATCH v3 00/11] Remoteprocs (ADSP, CDSP, WPSS) for SC7280

2023-12-10 Thread Bjorn Andersson
On Fri, 08 Dec 2023 16:07:56 +0100, Luca Weiss wrote: > This series adds support for the ADSP, CDSP and WPSS remoteprocs found > on SC7280. And finally enable them and WiFi on the QCM6490-based > Fairphone 5 smartphone. > > The first two patches are fixes for the MPSS to fix some dt validation

Re: [PATCH v2] arm64: dts: qcom: qcm6490-fairphone-fp5: Enable UFS

2023-12-10 Thread Bjorn Andersson
On Mon, 02 Oct 2023 14:30:41 +0200, Luca Weiss wrote: > Enable the UFS phy and controller so that we can access the internal > storage of the phone. > > At the same time we need to bump the minimum voltage used for UFS VCC, > otherwise it doesn't initialize properly. The 2.952V is taken from

[PATCH] eventfs: Fix events beyond NAME_MAX blocking tasks

2023-12-10 Thread Beau Belgrave
Eventfs uses simple_lookup(), however, it will fail if the name of the entry is beyond NAME_MAX length. When this error is encountered, eventfs still tries to create dentries instead of skipping the dentry creation. When the dentry is attempted to be created in this state d_wait_lookup() will loop

Re: [PATCH v6 2/2] kbuild: rpm-pkg: Fix build with non-default MODLIB

2023-12-10 Thread Michal Suchánek
On Mon, Dec 11, 2023 at 03:44:35AM +0900, Masahiro Yamada wrote: > On Thu, Dec 7, 2023 at 4:48 AM Michal Suchanek wrote: > > > > The default MODLIB value is composed of three variables > > > > MODLIB = $(INSTALL_MOD_PATH)$(KERNEL_MODULE_DIRECTORY)/$(KERNELRELEASE) > > > > However, the kernel.spec

Re: [PATCH v6 1/2] depmod: Handle installing modules under a different directory

2023-12-10 Thread Michal Suchánek
Hello! On Mon, Dec 11, 2023 at 03:43:44AM +0900, Masahiro Yamada wrote: > On Thu, Dec 7, 2023 at 4:48 AM Michal Suchanek wrote: > > > > Some distributions aim at shipping all files in /usr. > > > > The path under which kernel modules are installed is hardcoded to /lib > > which conflicts with

Re: [PATCH v6 1/2] depmod: Handle installing modules under a different directory

2023-12-10 Thread Woody Suwalski
Masahiro Yamada wrote: On Thu, Dec 7, 2023 at 4:48 AM Michal Suchanek wrote: Some distributions aim at shipping all files in /usr. The path under which kernel modules are installed is hardcoded to /lib which conflicts with this goal. When kmod provides kmod.pc, use it to determine the

Re: [PATCH v6 2/2] kbuild: rpm-pkg: Fix build with non-default MODLIB

2023-12-10 Thread Masahiro Yamada
On Thu, Dec 7, 2023 at 4:48 AM Michal Suchanek wrote: > > The default MODLIB value is composed of three variables > > MODLIB = $(INSTALL_MOD_PATH)$(KERNEL_MODULE_DIRECTORY)/$(KERNELRELEASE) > > However, the kernel.spec hadcodes the default value of > $(KERNEL_MODULE_DIRECTORY), and changed value

Re: [PATCH v6 1/2] depmod: Handle installing modules under a different directory

2023-12-10 Thread Masahiro Yamada
On Thu, Dec 7, 2023 at 4:48 AM Michal Suchanek wrote: > > Some distributions aim at shipping all files in /usr. > > The path under which kernel modules are installed is hardcoded to /lib > which conflicts with this goal. > > When kmod provides kmod.pc, use it to determine the correct module >

[PATCH] vdpa: Remove usage of the deprecated ida_simple_xx() API

2023-12-10 Thread Christophe JAILLET
ida_alloc() and ida_free() should be preferred to the deprecated ida_simple_get() and ida_simple_remove(). This is less verbose. Signed-off-by: Christophe JAILLET --- drivers/vdpa/vdpa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/vdpa/vdpa.c

Re: [PATCH] tracing: Allow for max buffer data size trace_marker writes

2023-12-10 Thread Steven Rostedt
On Sun, 10 Dec 2023 12:28:32 -0500 Mathieu Desnoyers wrote: > > Again, it's not a requirement, it's just an enhancement. > > How does this have anything to do with dispensing from testing the > new behavior ? If the new behavior has a bug that causes it to > silently truncate the trace marker

Re: [PATCH] tracing: Allow for max buffer data size trace_marker writes

2023-12-10 Thread Mathieu Desnoyers
On 2023-12-10 11:38, Steven Rostedt wrote: On Sun, 10 Dec 2023 11:07:22 -0500 Mathieu Desnoyers wrote: It just allows more to be written in one go. I don't see why the tests need to cover this or detect this change. If the purpose of this change is to ensure that the entire trace marker

[PATCH] nvdimm: Remove usage of the deprecated ida_simple_xx() API

2023-12-10 Thread Christophe JAILLET
ida_alloc() and ida_free() should be preferred to the deprecated ida_simple_get() and ida_simple_remove(). This is less verbose. Signed-off-by: Christophe JAILLET --- drivers/nvdimm/btt_devs.c | 6 +++--- drivers/nvdimm/bus.c| 4 ++-- drivers/nvdimm/dax_devs.c | 4 ++--

Re: [PATCH] tracing: Allow for max buffer data size trace_marker writes

2023-12-10 Thread Steven Rostedt
On Sun, 10 Dec 2023 11:07:22 -0500 Mathieu Desnoyers wrote: > > It just allows more to be written in one go. > > > > I don't see why the tests need to cover this or detect this change. > > If the purpose of this change is to ensure that the entire > trace marker payload is shown within a

Re: [PATCH] tracing: Allow for max buffer data size trace_marker writes

2023-12-10 Thread Mathieu Desnoyers
On 2023-12-10 10:30, Steven Rostedt wrote: On Sun, 10 Dec 2023 09:09:06 -0500 Mathieu Desnoyers wrote: On 2023-12-09 17:50, Steven Rostedt wrote: From: "Steven Rostedt (Google)" Allow a trace write to be as big as the ring buffer tracing data will allow. Currently, it only allows writes of

Re: [PATCH 14/14] ringbuffer/selftest: Add basic selftest to test chaning subbuf order

2023-12-10 Thread Steven Rostedt
On Sun, 10 Dec 2023 09:26:13 -0500 Mathieu Desnoyers wrote: > This test has no clue if the record was truncated or not. > > It basically repeats the string > > "1234567890" until it fills the subbuffer size and pads with > as needed as trace marker payload, but the grep looks for the >

Re: [PATCH 00/14] ring-buffer/tracing: Allow ring buffer to have bigger sub buffers

2023-12-10 Thread Steven Rostedt
On Sun, 10 Dec 2023 09:17:44 -0500 Mathieu Desnoyers wrote: > On 2023-12-09 22:54, Steven Rostedt wrote: > [...] > > > > Basically, events to the tracing subsystem are limited to just under a > > PAGE_SIZE, as the ring buffer is split into "sub buffers" of one page > > size, and an event can

Re: [PATCH] tracing: Have large events show up as '[LINE TOO BIG]' instead of nothing

2023-12-10 Thread Steven Rostedt
On Sun, 10 Dec 2023 09:11:40 -0500 Mathieu Desnoyers wrote: > On 2023-12-09 17:10, Steven Rostedt wrote: > [...] > > <...>-852 [001] . 121.550551: > > tracing_mark_write[LINE TOO BIG] > > <...>-852 [001] . 121.550581: tracing_mark_write: > >

Re: [PATCH] tracing: Allow for max buffer data size trace_marker writes

2023-12-10 Thread Steven Rostedt
On Sun, 10 Dec 2023 09:09:06 -0500 Mathieu Desnoyers wrote: > On 2023-12-09 17:50, Steven Rostedt wrote: > > From: "Steven Rostedt (Google)" > > > > Allow a trace write to be as big as the ring buffer tracing data will > > allow. Currently, it only allows writes of 1KB in size, but there's no

Re: [PATCH 13/14] ring-buffer: Add documentation on the buffer_subbuf_order file

2023-12-10 Thread Mathieu Desnoyers
On 2023-12-09 22:54, Steven Rostedt wrote: [...] + buffer_subbuf_order: + + This sets or displays the sub buffer page size order. The ring buffer + is broken up into several same size "sub buffers". An event can not be + bigger than the size of the sub buffer. Normally, the

Re: [PATCH 14/14] ringbuffer/selftest: Add basic selftest to test chaning subbuf order

2023-12-10 Thread Mathieu Desnoyers
On 2023-12-09 22:54, Steven Rostedt wrote: [...] +get_buffer_data_size() { + sed -ne 's/^.*data.*size:\([0-9][0-9]*\).*/\1/p' events/header_page +} + +a="1234567890" + +make_str() { +cnt=$1 +s="" +while [ $cnt -gt 10 ]; do +s="${s}${a}" +

Re: [PATCH 00/14] ring-buffer/tracing: Allow ring buffer to have bigger sub buffers

2023-12-10 Thread Mathieu Desnoyers
On 2023-12-09 22:54, Steven Rostedt wrote: [...] Basically, events to the tracing subsystem are limited to just under a PAGE_SIZE, as the ring buffer is split into "sub buffers" of one page size, and an event can not be bigger than a sub buffer. This allows users to change the size of a sub

Re: [PATCH] tracing: Have large events show up as '[LINE TOO BIG]' instead of nothing

2023-12-10 Thread Mathieu Desnoyers
On 2023-12-09 17:10, Steven Rostedt wrote: [...] <...>-852 [001] . 121.550551: tracing_mark_write[LINE TOO BIG] <...>-852 [001] . 121.550581: tracing_mark_write: 78901234 Failing to print an entire message because it does not fit in the buffer

Re: [PATCH] tracing: Allow for max buffer data size trace_marker writes

2023-12-10 Thread Mathieu Desnoyers
On 2023-12-09 17:50, Steven Rostedt wrote: From: "Steven Rostedt (Google)" Allow a trace write to be as big as the ring buffer tracing data will allow. Currently, it only allows writes of 1KB in size, but there's no reason that it cannot allow what the ring buffer can hold. I would expect

Re: [PATCH v6 1/5] x86/paravirt: introduce ALT_NOT_XEN

2023-12-10 Thread H. Peter Anvin
On December 9, 2023 10:21:34 PM PST, Juergen Gross wrote: >Introduce the macro ALT_NOT_XEN as a short form of >ALT_NOT(X86_FEATURE_XENPV). > >Suggested-by: Peter Zijlstra (Intel) >Signed-off-by: Juergen Gross >--- >V3: >- split off from next patch >V5: >- move patch to the start of the series

[PATCH] nvdimm-btt: simplify code with the scope based resource management

2023-12-10 Thread Dinghao Liu
Use the scope based resource management (defined in linux/cleanup.h) to automate resource lifetime control on struct btt_sb *super in discover_arenas(). Signed-off-by: Dinghao Liu --- drivers/nvdimm/btt.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git

[PATCH] [v2] nvdimm-btt: fix several memleaks

2023-12-10 Thread Dinghao Liu
Resources allocated by kcalloc() in btt_freelist_init(), btt_rtt_init(), and btt_maplocks_init() are not correctly released in their callers when an error happens. For example, when an error happens in btt_freelist_init(), its caller discover_arenas() will directly free arena, which makes