Re: [PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag

2023-12-20 Thread Eugenio Perez Martin
On Thu, Dec 21, 2023 at 3:03 AM Jason Wang wrote: > > On Wed, Dec 20, 2023 at 9:32 PM Eugenio Perez Martin > wrote: > > > > On Wed, Dec 20, 2023 at 5:06 AM Jason Wang wrote: > > > > > > On Wed, Dec 20, 2023 at 11:46 AM Jason Wang wrote: > > > > > > > > On Wed, Dec 20, 2023 at 2:09 AM Dragos

Re: [PATCH 0/3] Fairphone 5 PMIC-GLINK support (USB-C, charger, fuel gauge)

2023-12-20 Thread Luca Weiss
On Wed Dec 20, 2023 at 1:32 PM CET, Konrad Dybcio wrote: > On 20.12.2023 11:02, Luca Weiss wrote: > > This series adds all the necessary bits to enable USB-C role switching, > > charger and fuel gauge (all via pmic-glink) on Fairphone 5. > > > > One thing that could be made different is the

[PATCH 3/3] module: Don't ignore errors from set_memory_XX()

2023-12-20 Thread Christophe Leroy
set_memory_ro(), set_memory_nx(), set_memory_x() and other helps can fail an return an error. In that case the memory might not be protected as expected and the module loading has to be aborted to avoid security issues. Check return value of all calls to set_memory_XX() and handle error if any.

[PATCH 2/3] module: Change module_enable_{nx/x/ro}() to more explicit names

2023-12-20 Thread Christophe Leroy
It's a bit puzzling to see a call to module_enable_nx() followed by a call to module_enable_x(). This is because one applies on text while the other applies on data. Change name to make that more clear. Signed-off-by: Christophe Leroy --- kernel/module/internal.h | 6 +++---

[PATCH 1/3] module: Use set_memory_rox()

2023-12-20 Thread Christophe Leroy
A couple of architectures seem concerned about calling set_memory_ro() and set_memory_x() too frequently and have implemented a version of set_memory_rox(), see commit 60463628c9e0 ("x86/mm: Implement native set_memory_rox()") and commit 22e99fa56443 ("s390/mm: implement set_memory_rox()") Use

Re: [PATCH -next v4 2/2] mm: vmscan: add new event to trace shrink lru

2023-12-20 Thread Bixuan Cui
在 2023/12/21 1:54, Yu Zhao 写道: Signed-off-by: Bixuan Cui Reviewed-by: Andrew Morton --- v4: Add Reviewed-by and Changlog to every patch. Where did Andrew provide his Reviewed-by?Hi, I just want to add Reviewed-by to my patch to thank the reveiw of Steven and Andrew.:-) v2: Modify

[PATCH v2 09/11] fuse: file: limit splice_read to virtiofs

2023-12-20 Thread Ahelenia Ziemiańska
Potentially-blocking splice_reads are allowed for normal filesystems like NFS because they're blessed by root. FUSE is commonly used suid-root, and allows anyone to trivially create a file that, when spliced from, will just sleep forever with the pipe lock held. The only way IPC to the fusing

[PATCH v2 00/11] Avoid unprivileged splice(file->)/(->socket) pipe exclusion

2023-12-20 Thread Ahelenia Ziemiańska
Hi! As it stands, splice(file -> pipe): 1. locks the pipe, 2. does a read from the file, 3. unlocks the pipe. When the file resides on a normal filesystem, this isn't an issue because the filesystem has been defined as trusted by root having mounted it. But when the file is actually IPC (FUSE)

Re: [PATCH net-next 6/6] tools: virtio: introduce vhost_net_test

2023-12-20 Thread Jason Wang
On Thu, Dec 21, 2023 at 10:48 AM Yunsheng Lin wrote: > > On 2023/12/21 10:33, Jason Wang wrote: > > On Wed, Dec 20, 2023 at 8:45 PM Yunsheng Lin wrote: > >> > >> On 2023/12/12 12:35, Jason Wang wrote: +done: > >> + backend.fd = tun_alloc(); > >> + assert(backend.fd >= 0);

Re: [PATCH net-next 6/6] tools: virtio: introduce vhost_net_test

2023-12-20 Thread Yunsheng Lin
On 2023/12/21 10:33, Jason Wang wrote: > On Wed, Dec 20, 2023 at 8:45 PM Yunsheng Lin wrote: >> >> On 2023/12/12 12:35, Jason Wang wrote: +done: >> + backend.fd = tun_alloc(); >> + assert(backend.fd >= 0); >> + vdev_info_init(, features); >> +

Re: [PATCH net-next 6/6] tools: virtio: introduce vhost_net_test

2023-12-20 Thread Jason Wang
On Wed, Dec 20, 2023 at 8:45 PM Yunsheng Lin wrote: > > On 2023/12/12 12:35, Jason Wang wrote: +done: > + backend.fd = tun_alloc(); > + assert(backend.fd >= 0); > + vdev_info_init(, features); > + vq_info_add(, 256); > + run_test(, [0],

Re: [PATCH] modules: wait do_free_init correctly

2023-12-20 Thread Changbin Du
On Wed, Dec 20, 2023 at 06:32:39AM -0800, Luis Chamberlain wrote: > On Wed, Dec 20, 2023 at 01:27:51PM +0800, Changbin Du wrote: > > On Tue, Dec 19, 2023 at 01:52:03PM -0800, Luis Chamberlain wrote: > > > On Tue, Dec 19, 2023 at 12:51:51PM -0800, Andrew Morton wrote: > > > > On Tue, 19 Dec 2023

Re: [PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag

2023-12-20 Thread Jason Wang
On Wed, Dec 20, 2023 at 9:32 PM Eugenio Perez Martin wrote: > > On Wed, Dec 20, 2023 at 5:06 AM Jason Wang wrote: > > > > On Wed, Dec 20, 2023 at 11:46 AM Jason Wang wrote: > > > > > > On Wed, Dec 20, 2023 at 2:09 AM Dragos Tatulea > > > wrote: > > > > > > > > The virtio spec doesn't allow

Re: [PATCH v5 15/15] tracing: Update subbuffer with kilobytes not page order

2023-12-20 Thread Steven Rostedt
On Thu, 21 Dec 2023 09:26:21 +0900 Masami Hiramatsu (Google) wrote: > > If the user specifies 3 via: > > > > echo 3 > buffer_subbuf_size_kb > > > > Then the sub-buffer size will round up to 4kb (on a 4kb page size system). > > > > If they specify: > > > > echo 6 > buffer_subbuf_size_kb >

Re: BUG: unable to handle kernel paging request in bpf_probe_read_compat_str

2023-12-20 Thread Hou Tao
Hi, On 12/21/2023 1:50 AM, Yonghong Song wrote: > > On 12/20/23 1:19 AM, Hou Tao wrote: >> Hi, >> >> On 12/14/2023 11:40 AM, xingwei lee wrote: >>> Hello I found a bug in net/bpf in the lastest upstream linux and >>> comfired in the lastest net tree and lastest net bpf titled BUG: >>> unable to

Re: [PATCH v5 15/15] tracing: Update subbuffer with kilobytes not page order

2023-12-20 Thread Google
On Tue, 19 Dec 2023 13:54:29 -0500 Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > Using page order for deciding what the size of the ring buffer sub buffers > are is exposing a bit too much of the implementation. Although the sub > buffers are only allocated in orders of pages,

Re: [PATCH v5 14/15] ringbuffer/selftest: Add basic selftest to test changing subbuf order

2023-12-20 Thread Google
On Tue, 19 Dec 2023 13:54:28 -0500 Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > Add a self test that will write into the trace buffer with differ trace > sub buffer order sizes. > > Signed-off-by: Steven Rostedt (Google) > --- > .../ftrace/test.d/00basic/ringbuffer_order.tc |

Re: [PATCH v5 04/15] ring-buffer: Set new size of the ring buffer sub page

2023-12-20 Thread Google
On Wed, 20 Dec 2023 11:56:02 -0500 Steven Rostedt wrote: > On Thu, 21 Dec 2023 01:34:56 +0900 > Masami Hiramatsu (Google) wrote: > > > On Tue, 19 Dec 2023 13:54:18 -0500 > > Steven Rostedt wrote: > > > > > From: "Tzvetomir Stoyanov (VMware)" > > > > > > There are two approaches when

Re: [PATCH v5 03/15] ring-buffer: Add interface for configuring trace sub buffer size

2023-12-20 Thread Google
On Wed, 20 Dec 2023 09:40:30 -0500 Steven Rostedt wrote: > On Wed, 20 Dec 2023 23:26:19 +0900 > Masami Hiramatsu (Google) wrote: > > > On Tue, 19 Dec 2023 13:54:17 -0500 > > Steven Rostedt wrote: > > > > > +/** > > > + * ring_buffer_subbuf_order_set - set the size of ring buffer sub page. >

Re: [RFC PATCH 4/5] input: add onkey driver for Marvell 88PM88X PMICs

2023-12-20 Thread Dmitry Torokhov
Hi Karel, On Sun, Dec 17, 2023 at 02:17:02PM +0100, Karel Balej wrote: > From: Karel Balej > > The Marvell 88PM88X PMICs provide onkey among other things. Add client > driver to handle it. The driver currently only provides a basic support > omitting additional functions found in the vendor

[PATCH net-next v3 3/3] net: add netmem_ref to skb_frag_t

2023-12-20 Thread Mina Almasry
Use netmem_ref instead of page in skb_frag_t. Currently netmem_ref is always a struct page underneath, but the abstraction allows efforts to add support for skb frags not backed by pages. There is unfortunately 1 instance where the skb_frag_t is assumed to be a bio_vec in kcm. For this case, add

[PATCH net-next v3 2/3] net: introduce abstraction for network memory

2023-12-20 Thread Mina Almasry
Add the netmem_ref type, an abstraction for network memory. To add support for new memory types to the net stack, we must first abstract the current memory type. Currently parts of the net stack use struct page directly: - page_pool - drivers - skb_frag_t Originally the plan was to reuse struct

[PATCH net-next v3 1/3] vsock/virtio: use skb_frag_*() helpers

2023-12-20 Thread Mina Almasry
Minor fix for virtio: code wanting to access the fields inside an skb frag should use the skb_frag_*() helpers, instead of accessing the fields directly. This allows for extensions where the underlying memory is not a page. Signed-off-by: Mina Almasry --- v2: - Also fix skb_frag_off() +

[PATCH net-next v3 0/3] Abstract page from net stack

2023-12-20 Thread Mina Almasry
Changes in v3: - Replaced the struct netmem union with an opaque netmem_ref type. - Added func docs to the netmem helpers and type. - Renamed the skb_frag_t fields since it's no longer a bio_vec --- Changes in v2: - Reverted changes to the page_pool. The page pool now retains the same

[PATCH v4] virtio_pmem: support feature SHMEM_REGION

2023-12-20 Thread Changyuan Lyu
Thanks Michael for the feedback! On Tue, Dec 19, 2023 at 11:44 PM Michael S. Tsirkin wrote: > > > On Tue, Dec 19, 2023 at 11:32:27PM -0800, Changyuan Lyu wrote: > > > > + if (!have_shm) { > > + dev_err(>dev, "failed to get shared memory region > > %d\n", > > +

Re: [PATCH 0/4] Section alignment issues?

2023-12-20 Thread Luis Chamberlain
On Tue, Dec 19, 2023 at 01:26:49PM -0800, Luis Chamberlain wrote: > On Wed, Nov 22, 2023 at 11:18:10PM +0100, del...@kernel.org wrote: > > From: Helge Deller > > My questions: > > - Am I wrong with my analysis? > > This would typically of course depend on the arch, but whether it helps > is what

Re: [PATCH -next v4 2/2] mm: vmscan: add new event to trace shrink lru

2023-12-20 Thread Yu Zhao
On Tue, Dec 19, 2023 at 6:22 PM Bixuan Cui wrote: > > From: cuibixuan > > Add a new event to calculate the shrink_inactive_list()/shrink_active_list() > execution time. > > Example of output: > kswapd0-103 [007] . 1098.353020: > mm_vmscan_lru_shrink_active_start: nid=0 >

Re: BUG: unable to handle kernel paging request in bpf_probe_read_compat_str

2023-12-20 Thread Yonghong Song
On 12/20/23 1:19 AM, Hou Tao wrote: Hi, On 12/14/2023 11:40 AM, xingwei lee wrote: Hello I found a bug in net/bpf in the lastest upstream linux and comfired in the lastest net tree and lastest net bpf titled BUG: unable to handle kernel paging request in bpf_probe_read_compat_str If you fix

Re: [PATCH -next v4 2/2] mm: vmscan: add new event to trace shrink lru

2023-12-20 Thread Steven Rostedt
On Tue, 19 Dec 2023 17:21:23 -0800 Bixuan Cui wrote: > diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h > index b99cd28c9815..02868bdc5999 100644 > --- a/include/trace/events/vmscan.h > +++ b/include/trace/events/vmscan.h > @@ -395,7 +395,24 @@

Re: [PATCH v5 04/15] ring-buffer: Set new size of the ring buffer sub page

2023-12-20 Thread Steven Rostedt
On Thu, 21 Dec 2023 01:34:56 +0900 Masami Hiramatsu (Google) wrote: > On Tue, 19 Dec 2023 13:54:18 -0500 > Steven Rostedt wrote: > > > From: "Tzvetomir Stoyanov (VMware)" > > > > There are two approaches when changing the size of the ring buffer > > sub page: > > 1. Destroying all pages and

Re: [PATCH RERESEND 04/11] tracing: tracing_buffers_splice_read: behave as-if non-blocking I/O

2023-12-20 Thread Steven Rostedt
On Thu, 14 Dec 2023 19:45:02 +0100 Ahelenia Ziemiańska wrote: > Otherwise we risk sleeping with the pipe locked for indeterminate > lengths of time. This change log is really lacking. Why is this an issue? > Link: >

Re: [PATCH v5 04/15] ring-buffer: Set new size of the ring buffer sub page

2023-12-20 Thread Google
On Tue, 19 Dec 2023 13:54:18 -0500 Steven Rostedt wrote: > From: "Tzvetomir Stoyanov (VMware)" > > There are two approaches when changing the size of the ring buffer > sub page: > 1. Destroying all pages and allocating new pages with the new size. > 2. Allocating new pages, copying the

Re: [PATCH vhost v4 08/15] vdpa: Block vq state change in DRIVER_OK unless device supports it

2023-12-20 Thread Eugenio Perez Martin
On Tue, Dec 19, 2023 at 7:10 PM Dragos Tatulea wrote: > > Virtqueue state change during DRIVE_OK is not supported by the virtio > standard. Allow this op in DRIVER_OK only for devices that support > changing the state during DRIVER_OK if the device is suspended. > > Signed-off-by: Dragos Tatulea

Re: [PATCH vhost v4 07/15] vdpa: Block vq address change in DRIVER_OK unless device supports it

2023-12-20 Thread Eugenio Perez Martin
On Tue, Dec 19, 2023 at 7:09 PM Dragos Tatulea wrote: > > Virtqueue address change during DRIVE_OK is not supported by the virtio > standard. Allow this op in DRIVER_OK only for devices that support > changing the address during DRIVER_OK if the device is suspended. > > Signed-off-by: Dragos

Re: [PATCH v5 06/15] ring-buffer: Clear pages on error in ring_buffer_subbuf_order_set() failure

2023-12-20 Thread Steven Rostedt
On Thu, 21 Dec 2023 01:23:14 +0900 Masami Hiramatsu (Google) wrote: > On Tue, 19 Dec 2023 13:54:20 -0500 > Steven Rostedt wrote: > > > From: "Steven Rostedt (Google)" > > > > On failure to allocate ring buffer pages, the pointer to the CPU buffer > > pages is freed, but the pages that were

Re: [PATCH v5 06/15] ring-buffer: Clear pages on error in ring_buffer_subbuf_order_set() failure

2023-12-20 Thread Google
On Tue, 19 Dec 2023 13:54:20 -0500 Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > On failure to allocate ring buffer pages, the pointer to the CPU buffer > pages is freed, but the pages that were allocated previously were not. > Make sure they are freed too. > > Fixes: TBD

[PATCH] tracing / synthetic: Disable events after testing in synth_event_gen_test_init()

2023-12-20 Thread Steven Rostedt
From: "Steven Rostedt (Google)" The synth_event_gen_test module can be built in, if someone wants to run the tests at boot up and not have to load them. The synth_event_gen_test_init() function creates and enables the synthetic events and runs its tests. The synth_event_gen_test_exit()

Re: [PATCH] eventfs: Have event files and directories default to parent uid and gid

2023-12-20 Thread Steven Rostedt
On Wed, 20 Dec 2023 10:50:17 -0500 Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > Dongliang reported: > > I found that in the latest version, the nodes of tracefs have been > changed to dynamically created. > > This has caused me to encounter a problem where the gid I

Re: [PATCH vhost v4 05/15] vdpa: Accept VHOST_BACKEND_F_CHANGEABLE_VQ_STATE_IN_SUSPEND backend feature

2023-12-20 Thread Eugenio Perez Martin
On Tue, Dec 19, 2023 at 7:09 PM Dragos Tatulea wrote: > > If userland sets this feature, allow it. > > Signed-off-by: Dragos Tatulea > Suggested-by: Eugenio Pérez Acked-by: Eugenio Pérez > --- > drivers/vhost/vdpa.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH vhost v4 04/15] vdpa: Accept VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND backend feature

2023-12-20 Thread Eugenio Perez Martin
On Tue, Dec 19, 2023 at 7:09 PM Dragos Tatulea wrote: > > If userland sets this feature, allow it. > > Signed-off-by: Dragos Tatulea > Suggested-by: Eugenio Pérez Acked-by: Eugenio Pérez > --- > drivers/vhost/vdpa.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH vhost v4 03/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_STATE_IN_SUSPEND flag

2023-12-20 Thread Eugenio Perez Martin
On Tue, Dec 19, 2023 at 7:09 PM Dragos Tatulea wrote: > > The virtio spec doesn't allow changing virtqueue state after > DRIVER_OK. Some devices do support this operation when the device is > suspended. The VHOST_BACKEND_F_CHANGEABLE_VQ_STATE_IN_SUSPEND flag > advertises this support as a backend

Re: [PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag

2023-12-20 Thread Eugenio Perez Martin
On Tue, Dec 19, 2023 at 7:09 PM Dragos Tatulea wrote: > > The virtio spec doesn't allow changing virtqueue addresses after > DRIVER_OK. Some devices do support this operation when the device is > suspended. The VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag > advertises this support as a

Re: [PATCH v8 0/2] Introducing trace buffer mapping by user-space

2023-12-20 Thread Steven Rostedt
On Wed, 20 Dec 2023 13:49:30 + Vincent Donnefort wrote: > I meant, to only do in rb_wake_up_waiters() > > if (rbwork->is_cpu_buffer) > rb_update_meta_page(cpu_buffer) > > And skip the meta-page update for the !is_cpu_buffer case? Ah yeah, that works. -- Steve

[PATCH] eventfs: Have event files and directories default to parent uid and gid

2023-12-20 Thread Steven Rostedt
From: "Steven Rostedt (Google)" Dongliang reported: I found that in the latest version, the nodes of tracefs have been changed to dynamically created. This has caused me to encounter a problem where the gid I specified in the mounting parameters cannot apply to all files, as in the

Re: [RESEND PATCH v3 1/2] remoteproc: Make rproc_get_by_phandle() work for clusters

2023-12-20 Thread Tanmay Shah
On 11/14/23 10:23 AM, Mathieu Poirier wrote: > On Tue, 14 Nov 2023 at 08:22, Bjorn Andersson wrote: > > > > On Sat, Oct 14, 2023 at 04:15:47PM -0700, Tanmay Shah wrote: > > > From: Mathieu Poirier > > > > > > Multi-cluster remoteproc designs typically have the following DT > > > declaration: >

Re: [PATCH v8 2/3] dts: zynqmp: add properties for TCM in remoteproc

2023-12-20 Thread Tanmay Shah
On 12/20/23 7:14 AM, Michal Simek wrote: > > On 12/16/23 00:57, Tanmay Shah wrote: > > Add properties as per new bindings in zynqmp remoteproc node > > to represent TCM address and size. > > > > This patch also adds alternative remoteproc node to represent > > remoteproc cluster in split mode.

Re: [PATCH v5 03/15] ring-buffer: Add interface for configuring trace sub buffer size

2023-12-20 Thread Steven Rostedt
On Wed, 20 Dec 2023 23:26:19 +0900 Masami Hiramatsu (Google) wrote: > On Tue, 19 Dec 2023 13:54:17 -0500 > Steven Rostedt wrote: > > > +/** > > + * ring_buffer_subbuf_order_set - set the size of ring buffer sub page. > > + * @buffer: The ring_buffer to set the new page size. > > + * @order:

Re: [PATCH] modules: wait do_free_init correctly

2023-12-20 Thread Luis Chamberlain
On Wed, Dec 20, 2023 at 01:27:51PM +0800, Changbin Du wrote: > On Tue, Dec 19, 2023 at 01:52:03PM -0800, Luis Chamberlain wrote: > > On Tue, Dec 19, 2023 at 12:51:51PM -0800, Andrew Morton wrote: > > > On Tue, 19 Dec 2023 22:12:31 +0800 Changbin Du > > > wrote: > > > > > > > The commit

Re: [PATCH] ring-buffer: Remove stale comment from ring_buffer_size()

2023-12-20 Thread Google
On Wed, 20 Dec 2023 08:10:28 -0500 Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > It's been 11 years since the ring_buffer_size() function was updated to > use the nr_pages from the buffer->buffers[cpu] structure instead of using > the buffer->nr_pages that no longer exists. > >

Re: [PATCH v5 03/15] ring-buffer: Add interface for configuring trace sub buffer size

2023-12-20 Thread Google
On Tue, 19 Dec 2023 13:54:17 -0500 Steven Rostedt wrote: > +/** > + * ring_buffer_subbuf_order_set - set the size of ring buffer sub page. > + * @buffer: The ring_buffer to set the new page size. > + * @order: Order of the system pages in one sub buffer page > + * > + * By default, one ring

Re: [PATCH 2/3] usb: typec: ucsi: Add qcm6490-pmic-glink as needing PDOS quirk

2023-12-20 Thread Dmitry Baryshkov
On Wed, 20 Dec 2023 at 12:04, Luca Weiss wrote: > > The QCM6490 Linux Android firmware needs this workaround as well. Add it > to the list. > > Signed-off-by: Luca Weiss > --- > drivers/usb/typec/ucsi/ucsi_glink.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Dmitry Baryshkov -- With

Re: [PATCH 2/3] usb: typec: ucsi: Add qcm6490-pmic-glink as needing PDOS quirk

2023-12-20 Thread Heikki Krogerus
On Wed, Dec 20, 2023 at 11:02:57AM +0100, Luca Weiss wrote: > The QCM6490 Linux Android firmware needs this workaround as well. Add it > to the list. > > Signed-off-by: Luca Weiss Acked-by: Heikki Krogerus > --- > drivers/usb/typec/ucsi/ucsi_glink.c | 1 + > 1 file changed, 1 insertion(+) >

Re: [PATCH v8 0/2] Introducing trace buffer mapping by user-space

2023-12-20 Thread Vincent Donnefort
On Wed, Dec 20, 2023 at 08:29:32AM -0500, Steven Rostedt wrote: > On Wed, 20 Dec 2023 13:06:06 + > Vincent Donnefort wrote: > > > > @@ -771,10 +772,20 @@ static void rb_update_meta_page(struct > > > ring_buffer_per_cpu *cpu_buffer) > > > static void rb_wake_up_waiters(struct irq_work

Re: [PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag

2023-12-20 Thread Eugenio Perez Martin
On Wed, Dec 20, 2023 at 5:06 AM Jason Wang wrote: > > On Wed, Dec 20, 2023 at 11:46 AM Jason Wang wrote: > > > > On Wed, Dec 20, 2023 at 2:09 AM Dragos Tatulea wrote: > > > > > > The virtio spec doesn't allow changing virtqueue addresses after > > > DRIVER_OK. Some devices do support this

Re: [PATCH]eventfs: Apply the gid in the mounting parameters to all files

2023-12-20 Thread Steven Rostedt
On Wed, 20 Dec 2023 17:15:06 +0800 Dongliang Cui wrote: > I found that in the latest version, the nodes of > tracefs have been changed to dynamically created. > > This has caused me to encounter a problem where > the gid I specified in the mounting parameters > cannot apply to all files, as

Re: [PATCH v8 0/2] Introducing trace buffer mapping by user-space

2023-12-20 Thread Steven Rostedt
On Wed, 20 Dec 2023 13:06:06 + Vincent Donnefort wrote: > > @@ -771,10 +772,20 @@ static void rb_update_meta_page(struct > > ring_buffer_per_cpu *cpu_buffer) > > static void rb_wake_up_waiters(struct irq_work *work) > > { > > struct rb_irq_work *rbwork = container_of(work, struct

Re: [PATCH v8 2/3] dts: zynqmp: add properties for TCM in remoteproc

2023-12-20 Thread Michal Simek
On 12/16/23 00:57, Tanmay Shah wrote: Add properties as per new bindings in zynqmp remoteproc node to represent TCM address and size. This patch also adds alternative remoteproc node to represent remoteproc cluster in split mode. By default lockstep mode is enabled and users should disable

[PATCH] ring-buffer: Remove stale comment from ring_buffer_size()

2023-12-20 Thread Steven Rostedt
From: "Steven Rostedt (Google)" It's been 11 years since the ring_buffer_size() function was updated to use the nr_pages from the buffer->buffers[cpu] structure instead of using the buffer->nr_pages that no longer exists. The comment in the code is more of what a change log should have and is

Re: [PATCH v8 0/2] Introducing trace buffer mapping by user-space

2023-12-20 Thread Vincent Donnefort
On Tue, Dec 19, 2023 at 03:39:24PM -0500, Steven Rostedt wrote: > On Tue, 19 Dec 2023 18:45:54 + > Vincent Donnefort wrote: > > > The tracing ring-buffers can be stored on disk or sent to network > > without any copy via splice. However the later doesn't allow real time > > processing of the

Re: [PATCH v5 02/15] ring-buffer: Page size per ring buffer

2023-12-20 Thread Steven Rostedt
On Wed, 20 Dec 2023 08:48:02 + David Laight wrote: > From: Steven Rostedt > > Sent: 19 December 2023 18:54 > > From: "Tzvetomir Stoyanov (VMware)" > > > > Currently the size of one sub buffer page is global for all buffers and > > it is hard coded to one system page. In order to introduce

Re: [PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag

2023-12-20 Thread Dragos Tatulea
On Wed, 2023-12-20 at 12:05 +0800, Jason Wang wrote: > On Wed, Dec 20, 2023 at 11:46 AM Jason Wang wrote: > > > > On Wed, Dec 20, 2023 at 2:09 AM Dragos Tatulea wrote: > > > > > > The virtio spec doesn't allow changing virtqueue addresses after > > > DRIVER_OK. Some devices do support this

[ANNOUNCE] 4.19.302-rt131

2023-12-20 Thread Daniel Wagner
Hello RT-list! I'm pleased to announce the 4.19.302-rt131 stable release. This is just an update to the v4.19.302 stable release. No RT specific changes. You can get this release via the git tree at: git://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt.git branch: v4.19-rt

Re: [PATCH vhost v4 06/15] vdpa: Track device suspended state

2023-12-20 Thread Dragos Tatulea
On Wed, 2023-12-20 at 11:46 +0800, Jason Wang wrote: > On Wed, Dec 20, 2023 at 2:09 AM Dragos Tatulea wrote: > > > > Set vdpa device suspended state on successful suspend. Clear it on > > successful resume and reset. > > > > The state will be locked by the vhost_vdpa mutex. The mutex is taken >

Re: [PATCH v5 01/15] ring-buffer: Refactor ring buffer implementation

2023-12-20 Thread Steven Rostedt
On Wed, 20 Dec 2023 18:48:43 +0900 Masami Hiramatsu (Google) wrote: > > From: "Tzvetomir Stoyanov (VMware)" > > > > In order to introduce sub-buffer size per ring buffer, some internal > > refactoring is needed. As ring_buffer_print_page_header() will depend on > > the trace_buffer structure,

Re: [PATCH net-next 6/6] tools: virtio: introduce vhost_net_test

2023-12-20 Thread Yunsheng Lin
On 2023/12/12 12:35, Jason Wang wrote: +done: + backend.fd = tun_alloc(); + assert(backend.fd >= 0); + vdev_info_init(, features); + vq_info_add(, 256); + run_test(, [0], delayed, batch, reset, nbufs); >>> >>> I'd expect we are testing

Re: [PATCH 0/3] Fairphone 5 PMIC-GLINK support (USB-C, charger, fuel gauge)

2023-12-20 Thread Konrad Dybcio
On 20.12.2023 11:02, Luca Weiss wrote: > This series adds all the necessary bits to enable USB-C role switching, > charger and fuel gauge (all via pmic-glink) on Fairphone 5. > > One thing that could be made different is the pmic-glink compatible. > I've chosen to use qcm6490 compatible for it

Re: [PATCH] tracing/synthetic: fix kernel-doc warnings

2023-12-20 Thread Google
On Tue, 19 Dec 2023 22:12:26 -0800 Randy Dunlap wrote: > scripts/kernel-doc warns about using @args: for variadic arguments to > functions. Documentation/doc-guide/kernel-doc.rst says that this should > be written as @...: instead, so update the source code to match that, > preventing the

Re: [PATCH v3 33/34] s390: Implement the architecture-specific kmsan functions

2023-12-20 Thread Alexander Potapenko
On Thu, Dec 14, 2023 at 12:37 AM Ilya Leoshkevich wrote: > > arch_kmsan_get_meta_or_null() finds the lowcore shadow by querying the > prefix and calling kmsan_get_metadata() again. > > kmsan_virt_addr_valid() delegates to virt_addr_valid(). > > Signed-off-by: Ilya Leoshkevich Reviewed-by:

Re: [PATCH v3 24/34] s390/cpumf: Unpoison STCCTM output buffer

2023-12-20 Thread Alexander Potapenko
On Thu, Dec 14, 2023 at 12:37 AM Ilya Leoshkevich wrote: > > stcctm() uses the "Q" constraint for dest, therefore KMSAN does not > understand that it fills multiple doublewords pointed to by dest, not > just one. This results in false positives. > > Unpoison the whole dest manually with

[PATCH 3/3] arm64: dts: qcom: qcm6490-fairphone-fp5: Add PMIC GLINK

2023-12-20 Thread Luca Weiss
Via the PMIC GLINK driver we can get info about fuel gauge, charger and USB connector events. Add the node to the dts and configure USB so that role switching works. Signed-off-by: Luca Weiss --- arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 46 +-

[PATCH 2/3] usb: typec: ucsi: Add qcm6490-pmic-glink as needing PDOS quirk

2023-12-20 Thread Luca Weiss
The QCM6490 Linux Android firmware needs this workaround as well. Add it to the list. Signed-off-by: Luca Weiss --- drivers/usb/typec/ucsi/ucsi_glink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/typec/ucsi/ucsi_glink.c b/drivers/usb/typec/ucsi/ucsi_glink.c index

[PATCH 1/3] dt-bindings: soc: qcom: qcom,pmic-glink: document QCM6490 compatible

2023-12-20 Thread Luca Weiss
Document the QCM6490 compatible used to describe the pmic glink on this platform. Signed-off-by: Luca Weiss --- Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml

[PATCH 0/3] Fairphone 5 PMIC-GLINK support (USB-C, charger, fuel gauge)

2023-12-20 Thread Luca Weiss
+- arch/arm64/boot/dts/qcom/sc7280.dtsi | 19 + drivers/usb/typec/ucsi/ucsi_glink.c| 1 + 4 files changed, 66 insertions(+), 1 deletion(-) --- base-commit: 76fbb7732259f4c970998d6978d72177658a783a change-id: 20231220-fp5-pmic-glink-b01d4fa1c7ea Best

Re: [PATCH v5 01/15] ring-buffer: Refactor ring buffer implementation

2023-12-20 Thread Google
On Tue, 19 Dec 2023 13:54:15 -0500 Steven Rostedt wrote: > From: "Tzvetomir Stoyanov (VMware)" > > In order to introduce sub-buffer size per ring buffer, some internal > refactoring is needed. As ring_buffer_print_page_header() will depend on > the trace_buffer structure, it is moved after the

Re: BUG: unable to handle kernel paging request in bpf_probe_read_compat_str

2023-12-20 Thread Hou Tao
Hi, On 12/14/2023 11:40 AM, xingwei lee wrote: > Hello I found a bug in net/bpf in the lastest upstream linux and > comfired in the lastest net tree and lastest net bpf titled BUG: > unable to handle kernel paging request in bpf_probe_read_compat_str > > If you fix this issue, please add the

[PATCH]eventfs: Apply the gid in the mounting parameters to all files

2023-12-20 Thread Dongliang Cui
I found that in the latest version, the nodes of tracefs have been changed to dynamically created. This has caused me to encounter a problem where the gid I specified in the mounting parameters cannot apply to all files, as in the following situation: /data/tmp/events # mount | grep tracefs

RE: [PATCH v5 02/15] ring-buffer: Page size per ring buffer

2023-12-20 Thread David Laight
From: Steven Rostedt > Sent: 19 December 2023 18:54 > From: "Tzvetomir Stoyanov (VMware)" > > Currently the size of one sub buffer page is global for all buffers and > it is hard coded to one system page. In order to introduce configurable > ring buffer sub page size, the internal logic should

Re: [PATCH] [v2] nvdimm-btt: fix several memleaks

2023-12-20 Thread dinghao . liu
> dinghao.liu@ wrote: > > > Ira Weiny wrote: > > > > Dinghao Liu wrote: [snip] > > > > > > > > This does not quite work. > > > > > > > > free_arenas() is used in the error paths of create_arenas() and > > > > discover_arenas(). In those cases devm_kfree() is probably a better way > > > > to

Re: [RESEND PATCH] leds: ledtrig-pattern: Use last_repeat when applying hw pattern

2023-12-20 Thread Johan Hovold
On Tue, Jul 19, 2022 at 11:30:33PM +0200, Marijn Suijten wrote: > `last_repeat` holds the actual value requested by the user whereas > `repeat` is a software iteration variable that is unused in hardware > patterns. > > Furthermore `last_repeat` is the field returned to the user when reading >

Re: [PATCH v4 2/2] leds: qcom-lpg: Add PM660L configuration and compatible

2023-12-20 Thread Johan Hovold
On Tue, Dec 19, 2023 at 11:06:08AM +0100, Marijn Suijten wrote: > On 2023-12-19 10:33:25, Johan Hovold wrote: > > On Tue, Dec 19, 2023 at 10:17:16AM +0100, Marijn Suijten wrote: > > > > > Note that I have one more unmerged leds patch around, that hasn't been > > > looked > > > at either. Would