[PATCH net-next v7] virtio_net: Support RX hash XDP hint

2024-04-12 Thread Liang Chen
The RSS hash report is a feature that's part of the virtio specification. Currently, virtio backends like qemu, vdpa (mlx5), and potentially vhost (still a work in progress as per [1]) support this feature. While the capability to obtain the RSS hash has been enabled in the normal path, it's

Re: [PATCH net-next v6] virtio_net: Support RX hash XDP hint

2024-04-12 Thread Liang Chen
On Sat, Apr 13, 2024 at 10:11 AM Jakub Kicinski wrote: > > On Thu, 11 Apr 2024 16:52:16 +0800 Liang Chen wrote: > > + switch (__le16_to_cpu(hdr_hash->hash_report)) { > > + case VIRTIO_NET_HASH_REPORT_TCPv4: > > Please indent things according to the kernel coding style. > Sure.

Re: [PATCH net-next v6] virtio_net: Support RX hash XDP hint

2024-04-12 Thread Jakub Kicinski
On Thu, 11 Apr 2024 16:52:16 +0800 Liang Chen wrote: > + switch (__le16_to_cpu(hdr_hash->hash_report)) { > + case VIRTIO_NET_HASH_REPORT_TCPv4: Please indent things according to the kernel coding style. Checkpatch finds 2 problems in this change. -- pw-bot: cr

Re: [PATCH v3 5/7] KVM: x86: Participate in bitmap-based PTE aging

2024-04-12 Thread David Matlack
On 2024-04-01 11:29 PM, James Houghton wrote: > Only handle the TDP MMU case for now. In other cases, if a bitmap was > not provided, fallback to the slowpath that takes mmu_lock, or, if a > bitmap was provided, inform the caller that the bitmap is unreliable. I think this patch will trigger a

Re: [PATCH v3 3/7] KVM: Add basic bitmap support into kvm_mmu_notifier_test/clear_young

2024-04-12 Thread David Matlack
On 2024-04-01 11:29 PM, James Houghton wrote: > Add kvm_arch_prepare_bitmap_age() for architectures to indiciate that > they support bitmap-based aging in kvm_mmu_notifier_test_clear_young() > and that they do not need KVM to grab the MMU lock for writing. This > function allows architectures to

Re: [PATCH 1/4] KVM: delete .change_pte MMU notifier callback

2024-04-12 Thread David Hildenbrand
On 11.04.24 18:55, Paolo Bonzini wrote: On Mon, Apr 8, 2024 at 3:56 PM Peter Xu wrote: Paolo, I may miss a bunch of details here (as I still remember some change_pte patches previously on the list..), however not sure whether we considered enable it? Asked because I remember Andrea used to

Re: [PATCH v3 1/7] mm: Add a bitmap into mmu_notifier_{clear,test}_young

2024-04-12 Thread David Matlack
On 2024-04-01 11:29 PM, James Houghton wrote: > The bitmap is provided for secondary MMUs to use if they support it. For > test_young(), after it returns, the bitmap represents the pages that > were young in the interval [start, end). For clear_young, it represents > the pages that we wish the

Re: [PATCH v3 0/7] mm/kvm: Improve parallelism for access bit harvesting

2024-04-12 Thread David Matlack
On 2024-04-01 11:29 PM, James Houghton wrote: > This patchset adds a fast path in KVM to test and clear access bits on > sptes without taking the mmu_lock. It also adds support for using a > bitmap to (1) test the access bits for many sptes in a single call to > mmu_notifier_test_young, and to (2)

[PATCH v15 4/4] remoteproc: zynqmp: parse TCM from device tree

2024-04-12 Thread Tanmay Shah
ZynqMP TCM information was fixed in driver. Now ZynqMP TCM information is available in device-tree. Parse TCM information in driver as per new bindings. Signed-off-by: Tanmay Shah --- Changes in v15: - Use hardcode TCM addresses as fallback method if "reg" unavailable - Remove Versal and

[PATCH v15 2/4] dt-bindings: remoteproc: add Tightly Coupled Memory (TCM) bindings

2024-04-12 Thread Tanmay Shah
From: Radhey Shyam Pandey Introduce bindings for TCM memory address space on AMD-xilinx Zynq UltraScale+ platform. It will help in defining TCM in device-tree and make it's access platform agnostic and data-driven. Tightly-coupled memories(TCMs) are low-latency memory that provides predictable

[PATCH v15 1/4] remoteproc: zynqmp: fix lockstep mode memory region

2024-04-12 Thread Tanmay Shah
In lockstep mode, r5 core0 uses TCM of R5 core1. Following is lockstep mode memory region as per hardware reference manual. | *TCM* | *R5 View* | *Linux view* | | R5_0 ATCM (128 KB) | 0x_ | 0xFFE0_ | | R5_0 BTCM (128 KB) | 0x0002_ | 0xFFE2_ |

[PATCH v15 3/4] dts: zynqmp: add properties for TCM in remoteproc

2024-04-12 Thread Tanmay Shah
Add properties as per new bindings in zynqmp remoteproc node to represent TCM address and size. This patch also adds alternative remoteproc node to represent remoteproc cluster in split mode. By default lockstep mode is enabled and users should disable it before using split mode dts. Both

[PATCH v15 0/4] add zynqmp TCM bindings

2024-04-12 Thread Tanmay Shah
Tightly-Coupled Memories(TCMs) are low-latency memory that provides predictable instruction execution and predictable data load/store timing. Each Cortex-R5F processor contains exclusive two 64 KB memory banks on the ATCM and BTCM ports, for a total of 128 KB of memory. In lockstep mode, both

Re: [RFC PATCH 0/4] perf: Correlating user process data to samples

2024-04-12 Thread Mathieu Desnoyers
On 2024-04-12 12:28, Beau Belgrave wrote: On Thu, Apr 11, 2024 at 09:52:22PM -0700, Ian Rogers wrote: On Thu, Apr 11, 2024 at 5:17 PM Beau Belgrave wrote: In the Open Telemetry profiling SIG [1], we are trying to find a way to grab a tracing association quickly on a per-sample basis. The

Re: [RFC PATCH 0/4] perf: Correlating user process data to samples

2024-04-12 Thread Beau Belgrave
On Fri, Apr 12, 2024 at 09:12:45AM +0200, Peter Zijlstra wrote: > > On Fri, Apr 12, 2024 at 12:17:28AM +, Beau Belgrave wrote: > > > An idea flow would look like this: > > User Task Profile > > do_work(); sample() -> IP + No activity > > ... > > set_activity(123); > > ...

Re: [RFC PATCH 0/4] perf: Correlating user process data to samples

2024-04-12 Thread Beau Belgrave
On Thu, Apr 11, 2024 at 09:52:22PM -0700, Ian Rogers wrote: > On Thu, Apr 11, 2024 at 5:17 PM Beau Belgrave > wrote: > > > > In the Open Telemetry profiling SIG [1], we are trying to find a way to > > grab a tracing association quickly on a per-sample basis. The team at > > Elastic has a bespoke

Re: [PATCH v2] dt-bindings: mfd: qcom,spmi-pmic: Add pbs to SPMI device types

2024-04-12 Thread Krzysztof Kozlowski
On 12/04/2024 16:22, Luca Weiss wrote: > Add the PBS (Programmable Boot Sequencer) to the list of devices. > > Reviewed-by: Bjorn Andersson > Signed-off-by: Luca Weiss > --- > Changes in v2: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/4] KVM: delete .change_pte MMU notifier callback

2024-04-12 Thread Sean Christopherson
On Fri, Apr 12, 2024, Marc Zyngier wrote: > On Fri, 12 Apr 2024 11:44:09 +0100, Will Deacon wrote: > > On Fri, Apr 05, 2024 at 07:58:12AM -0400, Paolo Bonzini wrote: > > Also, if you're in the business of hacking the MMU notifier code, it > > would be really great to change the

Re: [PATCH v2 01/11] ring-buffer: Allow mapped field to be set without mapping

2024-04-12 Thread Vincent Donnefort
On Wed, Apr 10, 2024 at 09:25:42PM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > In preparation for having the ring buffer mapped to a dedicated location, > which will have the same restrictions as user space memory mapped buffers, > allow it to use the "mapped" field of the

Re: Re: [PATCH 2/3] kernel/pid: Remove default pid_max value

2024-04-12 Thread Michal Koutný
On Thu, Apr 11, 2024 at 03:03:31PM -0700, Andrew Morton wrote: > A large increase in the maximum number of processes. The change from (some) default to effective infinity is the crux of the change. Because that is only a number. (Thus I don't find the number's 12700% increase alone a big

Re: [PATCH] Bluetooth: Add more Bluetooth version defines

2024-04-12 Thread Luca Weiss
On Fri Feb 16, 2024 at 2:22 PM CET, Luca Weiss wrote: > Add the various Bluetooth version identifiers found in the "Assigned > Numbers" document[0] from the Bluetooth SIG. > > [0] https://www.bluetooth.com/specifications/assigned-numbers/ Hi all, Is there any interest in this patch? Would be

[PATCH v2] dt-bindings: mfd: qcom,spmi-pmic: Add pbs to SPMI device types

2024-04-12 Thread Luca Weiss
Add the PBS (Programmable Boot Sequencer) to the list of devices. Reviewed-by: Bjorn Andersson Signed-off-by: Luca Weiss --- Changes in v2: - Pick up tags - Rebase on linux-next, drop merged patches - Link to v1: https://lore.kernel.org/r/20240205-pmi632-ppg-v1-0-e236c95a2...@fairphone.com ---

[PATCH v2] media: dt-bindings: qcom,sc7280-venus: Allow one IOMMU entry

2024-04-12 Thread Luca Weiss
Some SC7280-based boards crash when providing the "secure_non_pixel" context bank, so allow only one iommu in the bindings also. Acked-by: Krzysztof Kozlowski Signed-off-by: Luca Weiss --- Reference:

[PATCH v5 5/5] Documentation: Add reconnect process for VDUSE

2024-04-12 Thread Cindy Lu
Add a document explaining the reconnect process, including what the Userspace App needs to do and how it works with the kernel. Signed-off-by: Cindy Lu --- Documentation/userspace-api/vduse.rst | 41 +++ 1 file changed, 41 insertions(+) diff --git

[PATCH v5 4/5] vduse: Add file operation for mmap

2024-04-12 Thread Cindy Lu
Add the operation for mmap, This function will be used by the user space application to map the pages to the user space. Signed-off-by: Cindy Lu --- drivers/vdpa/vdpa_user/vduse_dev.c | 57 ++ 1 file changed, 57 insertions(+) diff --git

[PATCH v5 3/5] vduse: Add function to get/free the pages for reconnection

2024-04-12 Thread Cindy Lu
Add the function vduse_alloc_reconnnect_info_mem and vduse_alloc_reconnnect_info_mem These functions allow vduse to allocate and free memory for reconnection information. The amount of memory allocated is vq_num pages. Each VQS will map its own page where the reconnection information will be saved

[PATCH v5 2/5] vduse: Add new ioctl VDUSE_DEV_GET_STATUS

2024-04-12 Thread Cindy Lu
The ioctl VDUSE_DEV_GET_STATUS is used by the Userspace App to get the device status Signed-off-by: Cindy Lu --- drivers/vdpa/vdpa_user/vduse_dev.c | 7 +++ include/uapi/linux/vduse.h | 2 ++ 2 files changed, 9 insertions(+) diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c

[PATCH v5 1/5] vduse: Add new ioctl VDUSE_DEV_GET_CONFIG

2024-04-12 Thread Cindy Lu
The ioctl VDUSE_DEV_GET_CONFIG is used by the Userspace App to get the device configuration space. Signed-off-by: Cindy Lu --- drivers/vdpa/vdpa_user/vduse_dev.c | 21 + include/uapi/linux/vduse.h | 3 +++ 2 files changed, 24 insertions(+) diff --git

[PATCH v5 0/5] vduse: Add support for reconnection

2024-04-12 Thread Cindy Lu
Here is the reconnect support in vduse Kernel will allocate pages for reconnection. Userspace needs to use mmap to map the memory to userspace and use these pages to save the reconnect information. test passd in vduse+dpdk-testpmd change in V2 1. Address the comments from v1 2. Add the

Re: [PATCH v2] bootconfig: use memblock_free_late to free xbc memory to buddy

2024-04-12 Thread Google
On Fri, 12 Apr 2024 18:49:41 +0800 qiang4.zh...@linux.intel.com wrote: > From: Qiang Zhang > > On the time to free xbc memory in xbc_exit(), memblock may has handed > over memory to buddy allocator. So it doesn't make sense to free memory > back to memblock. memblock_free() called by xbc_exit()

Re: [PATCH 1/4] KVM: delete .change_pte MMU notifier callback

2024-04-12 Thread Marc Zyngier
On Fri, 12 Apr 2024 11:44:09 +0100, Will Deacon wrote: > > On Fri, Apr 05, 2024 at 07:58:12AM -0400, Paolo Bonzini wrote: > > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > > index dc04bc767865..ff17849be9f4 100644 > > --- a/arch/arm64/kvm/mmu.c > > +++ b/arch/arm64/kvm/mmu.c > > @@

Re: [PATCH 0/4] KVM, mm: remove the .change_pte() MMU notifier and set_pte_at_notify()

2024-04-12 Thread Marc Zyngier
On Fri, 05 Apr 2024 12:58:11 +0100, Paolo Bonzini wrote: > > The .change_pte() MMU notifier callback was intended as an optimization > and for this reason it was initially called without a surrounding > mmu_notifier_invalidate_range_{start,end}() pair. It was only ever > implemented by KVM

Re: [PATCH 2/2] remoteproc: mediatek: Support MT8188 SCP core 1

2024-04-12 Thread 温倩苓
Hi AngeloGioacchino, Thanks for the reviews. On Thu, 2024-04-11 at 09:33 +0200, AngeloGioacchino Del Regno wrote: > Il 11/04/24 05:37, olivia.wen ha scritto: > > To Support MT8188 SCP core 1 for ISP driver. > > The SCP on different chips will require different code sizes > > and IPI buffer

Re: [PATCH 2/2] remoteproc: mediatek: Support MT8188 SCP core 1

2024-04-12 Thread 温倩苓
Hi Krzysztof, On Thu, 2024-04-11 at 08:07 +0200, Krzysztof Kozlowski wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On 11/04/2024 05:37, olivia.wen wrote: > > +}; > > + > > static const struct of_device_id

Re: [PATCH 1/2] dt-bindings: remoteproc: mediatek: Support MT8188 dual-core SCP

2024-04-12 Thread 温倩苓
Hi AngeloGioacchino, On Thu, 2024-04-11 at 09:39 +0200, AngeloGioacchino Del Regno wrote: > Il 11/04/24 09:34, AngeloGioacchino Del Regno ha scritto: > > Il 11/04/24 05:37, olivia.wen ha scritto: > > > Under different applications, the MT8188 SCP can be used as > > > single-core > > > or

Re: [PATCH 1/2] dt-bindings: remoteproc: mediatek: Support MT8188 dual-core SCP

2024-04-12 Thread 温倩苓
Hi Krzysztof, Thanks for the reviews. On Thu, 2024-04-11 at 08:06 +0200, Krzysztof Kozlowski wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On 11/04/2024 05:37, olivia.wen wrote: > > Under different

[PATCH v2] bootconfig: use memblock_free_late to free xbc memory to buddy

2024-04-12 Thread qiang4 . zhang
From: Qiang Zhang On the time to free xbc memory in xbc_exit(), memblock may has handed over memory to buddy allocator. So it doesn't make sense to free memory back to memblock. memblock_free() called by xbc_exit() even causes UAF bugs on architectures with CONFIG_ARCH_KEEP_MEMBLOCK disabled

Re: [PATCH 2/2] remoteproc: mediatek: Support MT8188 SCP core 1

2024-04-12 Thread 温倩苓
Hi AngeloGioacchino, Thanks for the reviews. On Thu, 2024-04-11 at 09:33 +0200, AngeloGioacchino Del Regno wrote: > Il 11/04/24 05:37, olivia.wen ha scritto: > > To Support MT8188 SCP core 1 for ISP driver. > > The SCP on different chips will require different code sizes > > and IPI buffer

Re: [PATCH 1/4] KVM: delete .change_pte MMU notifier callback

2024-04-12 Thread Will Deacon
On Fri, Apr 05, 2024 at 07:58:12AM -0400, Paolo Bonzini wrote: > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > index dc04bc767865..ff17849be9f4 100644 > --- a/arch/arm64/kvm/mmu.c > +++ b/arch/arm64/kvm/mmu.c > @@ -1768,40 +1768,6 @@ bool kvm_unmap_gfn_range(struct kvm *kvm, struct >

Re: [PATCH 1/2] dt-bindings: remoteproc: mediatek: Support MT8188 dual-core SCP

2024-04-12 Thread 温倩苓
Hi AngeloGioacchino, On Thu, 2024-04-11 at 09:39 +0200, AngeloGioacchino Del Regno wrote: > Il 11/04/24 09:34, AngeloGioacchino Del Regno ha scritto: > > Il 11/04/24 05:37, olivia.wen ha scritto: > > > Under different applications, the MT8188 SCP can be used as > > > single-core > > > or

Re: [PATCH RESEND] bootconfig: use memblock_free_late to free xbc memory to buddy

2024-04-12 Thread Qiang Zhang
On Fri, Apr 12, 2024 at 04:34:48PM +0900, Masami Hiramatsu wrote: >On Fri, 12 Apr 2024 10:41:04 +0800 >qiang4.zh...@linux.intel.com wrote: > >> From: Qiang Zhang >> >> On the time to free xbc memory, memblock has handed over memory to buddy >> allocator. So it doesn't make sense to free memory

Re: [PATCH v4 05/15] mm: introduce execmem_alloc() and execmem_free()

2024-04-12 Thread Ingo Molnar
* Mike Rapoport wrote: > +/** > + * enum execmem_type - types of executable memory ranges > + * > + * There are several subsystems that allocate executable memory. > + * Architectures define different restrictions on placement, > + * permissions, alignment and other parameters for memory that

Re: [RFC PATCH 5/7] x86/module: perpare module loading for ROX allocations of text

2024-04-12 Thread Ingo Molnar
* Mike Rapoport wrote: > for (s = start; s < end; s++) { > void *addr = (void *)s + *s; > + void *wr_addr = addr + module_writable_offset(mod, addr); So instead of repeating this pattern in a dozen of places, why not use a simpler method: void

Re: [PATCH v2 1/2] dt-bindings: pinctrl: qcom,pmic-gpio: Allow gpio-hog nodes

2024-04-12 Thread Linus Walleij
On Tue, Apr 9, 2024 at 8:36 PM Luca Weiss wrote: > Allow specifying a GPIO hog, as already used on > qcom-msm8974-lge-nexus5-hammerhead.dts. > > Signed-off-by: Luca Weiss This patch applied to the pinctrl tree! Yours, Linus Walleij

Re: [PATCH RESEND] bootconfig: use memblock_free_late to free xbc memory to buddy

2024-04-12 Thread Google
On Fri, 12 Apr 2024 10:41:04 +0800 qiang4.zh...@linux.intel.com wrote: > From: Qiang Zhang > > On the time to free xbc memory, memblock has handed over memory to buddy > allocator. So it doesn't make sense to free memory back to memblock. > memblock_free() called by xbc_exit() even causes UAF

Re: [RFC PATCH 0/4] perf: Correlating user process data to samples

2024-04-12 Thread Peter Zijlstra
On Fri, Apr 12, 2024 at 12:17:28AM +, Beau Belgrave wrote: > An idea flow would look like this: > User Task Profile > do_work();sample() -> IP + No activity > ... > set_activity(123); > ... > do_work();sample() -> IP + activity (123) > ... >

Re: [RFC PATCH 2/7] mm: vmalloc: don't account for number of nodes for HUGE_VMAP allocations

2024-04-12 Thread Christophe Leroy
Le 11/04/2024 à 18:05, Mike Rapoport a écrit : > From: "Mike Rapoport (IBM)" > > vmalloc allocations with VM_ALLOW_HUGE_VMAP that do not explictly > specify node ID will use huge pages only if size_per_node is larger than > PMD_SIZE. > Still the actual allocated memory is not distributed