Re: [PATCH] lib: test_objpool: add missing MODULE_DESCRIPTION() macro

2024-06-02 Thread wuqiang.matt
On 2024/6/1 08:31, Jeff Johnson wrote: make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_objpool.o Add the missing invocation of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson --- lib/test_objpool.c | 3 ++- 1 file changed, 2

Re: [PATCH v2 24/27] function_graph: Use static_call and branch to optimize entry function

2024-06-02 Thread Google
On Sat, 01 Jun 2024 23:38:08 -0400 Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > In most cases function graph is used by a single user. Instead of calling > a loop to call function graph callbacks in this case, call the function > entry callback directly. > > Add a static_key

Re: [PATCH v2 10/27] ftrace: Add subops logic to allow one ops to manage many

2024-06-02 Thread Google
On Sun, 2 Jun 2024 22:06:13 -0400 Steven Rostedt wrote: > > > +/* Make @ops trace evenything except what all its subops do not trace */ > > > +static struct ftrace_hash *intersect_hashes(struct ftrace_ops *ops) > > > +{ > > > + struct ftrace_hash *new_hash = NULL; > > > + struct ftrace_ops

Re: [PATCH v2 11/27] ftrace: Allow subops filtering to be modified

2024-06-02 Thread Google
On Sat, 01 Jun 2024 23:37:55 -0400 Steven Rostedt wrote: [...] > > +static int ftrace_hash_move_and_update_subops(struct ftrace_ops *subops, > + struct ftrace_hash **orig_subhash, > + struct ftrace_hash *hash,

Re: [PATCH v2 10/27] ftrace: Add subops logic to allow one ops to manage many

2024-06-02 Thread Steven Rostedt
On Mon, 3 Jun 2024 10:33:16 +0900 Masami Hiramatsu (Google) wrote: > Hi Steve, > > On Sat, 01 Jun 2024 23:37:54 -0400 > Steven Rostedt wrote: > > > From: "Steven Rostedt (VMware)" > > I think this is a new patch, correct? I'm a bit confused. Ah, good catch! I originally started writing

Re: [PATCH v2 10/27] ftrace: Add subops logic to allow one ops to manage many

2024-06-02 Thread Google
Hi Steve, On Sat, 01 Jun 2024 23:37:54 -0400 Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" I think this is a new patch, correct? I'm a bit confused. And I have some comments below; [..] > @@ -3164,6 +3166,392 @@ int ftrace_shutdown(struct ftrace_ops *ops, int > command) >

Re: [PATCH RFC 0/4] static key support for error injection functions

2024-06-02 Thread Vlastimil Babka
On 6/2/24 10:47 PM, David Rientjes wrote: > On Fri, 31 May 2024, Vlastimil Babka wrote: > >> Patches 3 and 4 implement the static keys for the two mm fault injection >> sites in slab and page allocators. For a quick demonstration I've run a >> VM and the simple test from [1] that stresses the

Re: [syzbot] Monthly trace report (May 2024)

2024-06-02 Thread Jiri Olsa
On Sun, Jun 02, 2024 at 10:52:43PM +0200, Jiri Olsa wrote: > On Sun, Jun 02, 2024 at 12:09:50PM +0900, Masami Hiramatsu wrote: > > On Thu, 30 May 2024 23:50:32 -0700 > > syzbot wrote: > > > > > Hello trace maintainers/developers, > > > > > > This is a 31-day syzbot report for the trace

Re: [syzbot] Monthly trace report (May 2024)

2024-06-02 Thread Jiri Olsa
On Sun, Jun 02, 2024 at 12:09:50PM +0900, Masami Hiramatsu wrote: > On Thu, 30 May 2024 23:50:32 -0700 > syzbot wrote: > > > Hello trace maintainers/developers, > > > > This is a 31-day syzbot report for the trace subsystem. > > All related reports/information can be found at: > >

Re: [PATCH RFC 0/4] static key support for error injection functions

2024-06-02 Thread David Rientjes
On Fri, 31 May 2024, Vlastimil Babka wrote: > Patches 3 and 4 implement the static keys for the two mm fault injection > sites in slab and page allocators. For a quick demonstration I've run a > VM and the simple test from [1] that stresses the slab allocator and got > this time before the

[PATCH] virtio: add missing MODULE_DESCRIPTION() macro

2024-06-02 Thread Jeff Johnson
T_SYMBOL(virtio_dma_buf_get_uuid); +MODULE_DESCRIPTION("dma-bufs for virtio exported objects"); MODULE_LICENSE("GPL"); MODULE_IMPORT_NS(DMA_BUF); --- base-commit: 83814698cf48ce3aadc5d88a3f577f04482ff92a change-id: 20240602-md-virtio_dma_buf-b3552ca6c5d5

Re: [PATCH v5 21/25] dt-bindings: media: imx258: Add binding for powerdown-gpio

2024-06-02 Thread Luis Garcia
On 5/20/24 06:50, Sakari Ailus wrote: > On Fri, May 17, 2024 at 08:31:35AM +, Sakari Ailus wrote: >> Hi Luis, >> >> On Wed, May 01, 2024 at 09:24:38AM -0600, g...@luigi311.com wrote: >>> From: Ondrej Jirman >>> >>> Add powerdown-gpio binding as it is required for some boards. >> >> I thought

Re: [PATCH RFC 3/4] mm, slab: add static key for should_failslab()

2024-06-02 Thread Alexei Starovoitov
On Sat, Jun 1, 2024 at 1:57 PM Vlastimil Babka wrote: > > On 5/31/24 6:43 PM, Alexei Starovoitov wrote: > > On Fri, May 31, 2024 at 2:33 AM Vlastimil Babka wrote: > >> might_alloc(flags); > >> > >> - if (unlikely(should_failslab(s, flags))) > >> - return NULL; > >> +

Re: [PATCH RFC 2/4] error-injection: support static keys around injectable functions

2024-06-02 Thread Google
On Fri, 31 May 2024 11:33:33 +0200 Vlastimil Babka wrote: > Error injectable functions cannot be inlined and since some are called > from hot paths, this incurrs overhead even if no error injection is > enabled for them. > > To remove this overhead when disabled, allow the callsites of error >

Re: [PATCH RFC 0/4] static key support for error injection functions

2024-06-02 Thread Wei Yang
On Fri, May 31, 2024 at 11:33:31AM +0200, Vlastimil Babka wrote: >Incomplete, help needed from ftrace/kprobe and bpf folks. > >As previously mentioned by myself [1] and others [2] the functions >designed for error injection can bring visible overhead in fastpaths >such as slab or page allocation,