Re: Current status and possible improvements in CONFIG_MODULE_FORCE_UNLOAD

2024-06-14 Thread Aditya Garg
Thanks for the reply Lucas. It makes sense now! > On 15 Jun 2024, at 12:18 AM, Lucas De Marchi wrote: > > On Thu, Jun 06, 2024 at 06:49:59AM GMT, Aditya Garg wrote: >> Hi >> >> I am Aditya Garg. I often require using out of tree drivers to support >> various hardwares on Linux. Sometimes the

Re: [PATCH] ARM: dts: qcom: motorola-falcon: add accelerometer, magnetometer

2024-06-14 Thread Bjorn Andersson
On Sun, 09 Jun 2024 13:05:43 +0200, Stanislav Jakubek wrote: > Add the accelerometer and magnetometer that are present on the Motorola > Moto G (2013) device. > > Applied, thanks! [1/1] ARM: dts: qcom: motorola-falcon: add accelerometer, magnetometer commit:

Re: [PATCH v2 0/2] Support mailbox interface in qcom,smsm driver

2024-06-14 Thread Bjorn Andersson
On Thu, 06 Jun 2024 21:18:31 +0200, Luca Weiss wrote: > Take a shot at converting the last driver that requires direct > "qcom,ipc*" syscon references in devicetree by allowing the smsm driver > to use the mailbox interface to achieve the same effect. > > Still not sure if the devicetree

Re: [PATCH] arm64: dts: qcom: qcm6490-fairphone-fp5: Use .mbn firmware for IPA

2024-06-14 Thread Bjorn Andersson
On Thu, 06 Jun 2024 11:09:06 +0200, Luca Weiss wrote: > Specify the file name for the squashed/non-split firmware with the .mbn > extension instead of the split .mdt. The kernel can load both but the > squashed version is preferred in dts nowadays. > > Applied, thanks! [1/1] arm64: dts:

[PATCH] virtio_net: Eliminate OOO packets during switching

2024-06-14 Thread Abhinav Jain
Disable the network device & turn off carrier before modifying the number of queue pairs. Process all the in-flight packets and then turn on carrier, followed by waking up all the queues on the network device. Signed-off-by: Abhinav Jain --- drivers/net/virtio_net.c | 17 +++-- 1

Re: [PATCHv8 bpf-next 3/9] uprobe: Add uretprobe syscall to speed up return probe

2024-06-14 Thread Nathan Chancellor
On Fri, Jun 14, 2024 at 09:26:59PM +0200, Jiri Olsa wrote: > On Fri, Jun 14, 2024 at 10:48:22AM -0700, Nathan Chancellor wrote: > > Hi Jiri, > > > > On Tue, Jun 11, 2024 at 01:21:52PM +0200, Jiri Olsa wrote: > > > Adding uretprobe syscall instead of trap to speed up return probe. > > ... > > >

Re: [PATCH v4 net-next 1/7] net: add rx_sk to trace_kfree_skb

2024-06-14 Thread Yan Zhai
On Fri, Jun 14, 2024 at 5:15 AM Paolo Abeni wrote: > > On Wed, 2024-06-12 at 09:59 +0200, Jesper Dangaard Brouer wrote: > > > > On 11/06/2024 22.11, Yan Zhai wrote: > > > skb does not include enough information to find out receiving > > > sockets/services and netns/containers on packet drops. In

Re: [PATCHv8 bpf-next 3/9] uprobe: Add uretprobe syscall to speed up return probe

2024-06-14 Thread Jiri Olsa
On Fri, Jun 14, 2024 at 10:48:22AM -0700, Nathan Chancellor wrote: > Hi Jiri, > > On Tue, Jun 11, 2024 at 01:21:52PM +0200, Jiri Olsa wrote: > > Adding uretprobe syscall instead of trap to speed up return probe. > ... > > diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c > > index

Re: [PATCH v4 2/3] kbuild, kconfig: generate offset range data for builtin modules

2024-06-14 Thread Kris Van Hees
My apologies (esp. to Masahiro Yamada)... this patch was supposed to resolve the outstanding issue of needing to add gawk to the dependencies in the documentation and that part of the patch still didn't make it in. I've added it on my end for v5, and will absolutely ensure that it will be in the

Re: [PATCH] lib/test_kmod: add missing MODULE_DESCRIPTION() macro

2024-06-14 Thread Lucas De Marchi
On Fri, May 31, 2024 at 05:23:09PM GMT, Jeff Johnson wrote: make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_kmod.o Add the missing invocation of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson Reviewed-by: Lucas De Marchi

Re: Current status and possible improvements in CONFIG_MODULE_FORCE_UNLOAD

2024-06-14 Thread Lucas De Marchi
On Thu, Jun 06, 2024 at 06:49:59AM GMT, Aditya Garg wrote: Hi I am Aditya Garg. I often require using out of tree drivers to support various hardwares on Linux. Sometimes the provider doesn't write good drivers, and often they have to be force unloaded. It's a common thing in proprietary

Re: [PATCH v4 1/3] kbuild: add mod(name,file)_flags to assembler flags for module objects

2024-06-14 Thread Steven Rostedt
On Fri, 14 Jun 2024 14:10:58 -0400 Kris Van Hees wrote: > On Fri, Jun 14, 2024 at 01:46:51PM -0400, Steven Rostedt wrote: > > On Fri, 14 Jun 2024 13:14:26 -0400 > > Kris Van Hees wrote: > > > > > Module objects compiled from C source can be identified by the presence > > > of

Re: [PATCH v4 1/3] kbuild: add mod(name,file)_flags to assembler flags for module objects

2024-06-14 Thread Kris Van Hees
On Fri, Jun 14, 2024 at 01:46:51PM -0400, Steven Rostedt wrote: > On Fri, 14 Jun 2024 13:14:26 -0400 > Kris Van Hees wrote: > > > Module objects compiled from C source can be identified by the presence > > of -DKBUILD_MODFILE and -DKBUILD_MODNAME on their compile command lines. > > However,

Re: [PATCHv8 bpf-next 3/9] uprobe: Add uretprobe syscall to speed up return probe

2024-06-14 Thread Nathan Chancellor
Hi Jiri, On Tue, Jun 11, 2024 at 01:21:52PM +0200, Jiri Olsa wrote: > Adding uretprobe syscall instead of trap to speed up return probe. ... > diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c > index 2c83ba776fc7..2816e65729ac 100644 > --- a/kernel/events/uprobes.c > +++

Re: [PATCH v4 1/3] kbuild: add mod(name,file)_flags to assembler flags for module objects

2024-06-14 Thread Steven Rostedt
On Fri, 14 Jun 2024 13:14:26 -0400 Kris Van Hees wrote: > Module objects compiled from C source can be identified by the presence > of -DKBUILD_MODFILE and -DKBUILD_MODNAME on their compile command lines. > However, module objects from assembler source do not have this defines. > > Add

[PATCH v4 3/3] module: add install target for modules.builtin.ranges

2024-06-14 Thread Kris Van Hees
When CONFIG_BUILTIN_MODULE_RANGES is enabled, the modules.builtin.ranges file should be installed in the module install location. Signed-off-by: Kris Van Hees Reviewed-by: Nick Alcock --- Changes since v3: - Only install modules.builtin.ranges if CONFIG_BUILTIN_MODULE_RANGES=y ---

[PATCH v4 2/3] kbuild, kconfig: generate offset range data for builtin modules

2024-06-14 Thread Kris Van Hees
The offset range data for builtin modules is generated using: - modules.builtin: associates object files with module names - vmlinux.map: provides load order of sections and offset of first member per section - vmlinux.o.map: provides offset of object file content per section - .*.cmd:

[PATCH v4 1/3] kbuild: add mod(name,file)_flags to assembler flags for module objects

2024-06-14 Thread Kris Van Hees
Module objects compiled from C source can be identified by the presence of -DKBUILD_MODFILE and -DKBUILD_MODNAME on their compile command lines. However, module objects from assembler source do not have this defines. Add $(modfile_flags) to modkern_aflags (similar to modkern_cflahs), and add

[PATCH v4 0/3] Generate address range data for built-in modules

2024-06-14 Thread Kris Van Hees
Especially for tracing applications, it is convenient to be able to refer to a symbol using a pair and to be able to translate an address into a pair. But that does not work if the module is built into the kernel because the object files that comprise the built-in module implementation are

Re: [PATCH v6 0/7] DAMON based tiered memory management for CXL memory

2024-06-14 Thread SeongJae Park
On Fri, 14 Jun 2024 12:00:02 +0900 Honggyu Kim wrote: > There was an RFC IDEA "DAMOS-based Tiered-Memory Management" previously > posted at [1]. > > It says there is no implementation of the demote/promote DAMOS action > are made. This patch series is about its implementation for physical >

Re: [PATCH v6 7/7] Docs/damon: document damos_migrate_{hot,cold}

2024-06-14 Thread SeongJae Park
On Fri, 14 Jun 2024 12:00:09 +0900 Honggyu Kim wrote: > This patch adds damon description for "migrate_hot" and "migrate_cold" > actions for both usage and design documents as long as a new > "target_nid" knob to set the migration target node. > > Signed-off-by: Honggyu Kim Reviewed-by:

Re: [PATCH V2] net: qrtr: ns: Ignore ENODEV failures in ns

2024-06-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (main) by Paolo Abeni : On Wed, 12 Jun 2024 12:01:56 +0530 you wrote: > From: Chris Lew > > Ignore the ENODEV failures returned by kernel_sendmsg(). These errors > indicate that either the local port has been closed or the remote has > gone

[PATCH v2] net: missing check virtio

2024-06-14 Thread Denis Arefev
Yeah, I was thinking of adding Fixes: But this code is new, it complements what is done. 1. check (!(ret && (hdr->gso_size > needed) && ((remainder > needed) || (remainder == 0 complements comit 0f6925b3e8da0 2. The setting of the SKBFL_SHARED_FRAG flag can be associated

Re: [PATCH v4 net-next 1/7] net: add rx_sk to trace_kfree_skb

2024-06-14 Thread Paolo Abeni
On Wed, 2024-06-12 at 09:59 +0200, Jesper Dangaard Brouer wrote: > > On 11/06/2024 22.11, Yan Zhai wrote: > > skb does not include enough information to find out receiving > > sockets/services and netns/containers on packet drops. In theory > > skb->dev tells about netns, but it can get

[PATCH] bpf/selftests: Fix __NR_uretprobe in uprobe_syscall test

2024-06-14 Thread Jiri Olsa
Fixing the __NR_uretprobe number in uprobe_syscall test, because it changed due to merge conflict. Signed-off-by: Jiri Olsa --- tools/testing/selftests/bpf/prog_tests/uprobe_syscall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] module: Add log information for loading module failures

2024-06-14 Thread Yusong Gao
Add log information in kernel-space when loading module failures. Try to load the unsigned module and the module with bad signature when set 1 to /sys/module/module/parameters/sig_enforce. Unsigned module case: (linux) insmod unsigned.ko [ 18.714661] Loading of unsigned module is rejected

[PATCH v5 4/4] net: drop_monitor: use drop_reason_lookup()

2024-06-14 Thread Johannes Berg
From: Johannes Berg Now that we have drop_reason_lookup(), we can just use it for drop_monitor as well, rather than exporting the list itself. Signed-off-by: Johannes Berg --- v3: - look up SKB_DROP_REASON_NOT_SPECIFIED if initial lookup returns NULL, to preserve previous behaviour ---

[PATCH v5 3/4] net: dropreason: use new __print_sym() in tracing

2024-06-14 Thread Johannes Berg
From: Johannes Berg The __print_symbolic() could only ever print the core drop reasons, since that's the way the infrastructure works. Now that we have __print_sym() with all the advantages mentioned in that commit, convert to that and get all the drop reasons from all subsystems. As we already

[PATCH v5 1/4] tracing: add __print_sym() to replace __print_symbolic()

2024-06-14 Thread Johannes Berg
From: Johannes Berg The way __print_symbolic() works is limited and inefficient in multiple ways: - you can only use it with a static list of symbols, but e.g. the SKB dropreasons are now a dynamic list - it builds the list in memory _three_ times, so it takes a lot of memory: - The

[PATCH v5 2/4] tracing/timer: use __print_sym()

2024-06-14 Thread Johannes Berg
From: Johannes Berg Use the new __print_sym() in the timer tracing, just to show how to convert something. This adds ~80 bytes of .text for a saving of ~1.5K of data in my builds. Note the format changes from print fmt: "success=%d dependency=%s", REC->success,

[PATCH v5 0/4] tracing: improve symbolic printing

2024-06-14 Thread Johannes Berg
v2 was: - rebased on 6.9-rc1 - always search for __print_sym() and get rid of the DYNPRINT flag and associated code; I think ideally we'll just remove the older __print_symbolic() entirely - use ':' as the separator instead of "//" since that makes searching for it much easier and it's

Re: [PATCH v2 00/13] OMAP mailbox FIFO removal

2024-06-14 Thread Dominic Rath
On 13.06.2024 14:22, Andrew Davis wrote: We looked into this some time ago, and noticed that the IRQ approach caused problems in the virtio/rpmsg code. I'd like to understand if your change was for the same reason, or something else we missed before. It is most likely the same reason. Seems

Re: [PATCH] linux++: delete some forward declarations

2024-06-14 Thread Alexey Dobriyan
On Thu, Jun 13, 2024 at 04:10:12PM -0400, Steven Rostedt wrote: > On Thu, 13 Jun 2024 13:04:20 -0700 > Andrew Morton wrote: > > > On Thu, 13 Jun 2024 15:34:02 -0400 Steven Rostedt > > wrote: > > > > > On Thu, 13 Jun 2024 22:22:18 +0300 > > > Alexey Dobriyan wrote: > > > > > > > g++