Re: [PATCH v3] x86/paravirt: Disable virt spinlock on bare metal

2024-06-25 Thread Nikolay Borisov
On 25.06.24 г. 15:54 ч., Chen Yu wrote: The kernel can change spinlock behavior when running as a guest. But this guest-friendly behavior causes performance problems on bare metal. So there's a 'virt_spin_lock_key' static key to switch between the two modes. The static key is always enabled

Re: [PATCH v2 0/3] ARM: dts: qcom: msm8926-motorola-peregrine: Update device tree of Motorola Moto G 4G (2013)

2024-06-25 Thread Bjorn Andersson
On Mon, 17 Jun 2024 23:22:26 +0200, André Apitzsch wrote: > Add accelerometer, magnetometer, regulator and temperature sensor alert > interrupt and update framebuffer supplies. > > Applied, thanks! [1/3] ARM: dts: qcom: msm8926-motorola-peregrine: Add accelerometer, magnetometer, regulator

RE: [PATCH v3] x86/paravirt: Disable virt spinlock on bare metal

2024-06-25 Thread Zhuo, Qiuxu
> From: Nikolay Borisov > [...] > >> Actually now shouldn't the CONFIG_PARAVIRT_SPINLOCKS check be > retained? > >> Otherwise we'll have the virtspinlock enabled even if we are a guest > >> but CONFIG_PARAVIRT_SPINLOCKS is disabled, no ? > >> > > > > It seems to be the expected behavior? If

Re: [PATCH V2 3/3] virtio-net: synchronize operstate with admin state on up/down

2024-06-25 Thread Jason Wang
On Tue, Jun 25, 2024 at 4:32 PM Michael S. Tsirkin wrote: > > On Tue, Jun 25, 2024 at 04:11:05PM +0800, Jason Wang wrote: > > On Tue, Jun 25, 2024 at 3:57 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Jun 25, 2024 at 03:46:44PM +0800, Jason Wang wrote: > > > > Workqueue is used to serialize

Re: [PATCH] virtio-pci: PCI extended capabilities for virtio

2024-06-25 Thread Jason Wang
On Wed, Jun 26, 2024 at 6:50 AM Michael S. Tsirkin wrote: > > On Tue, Jun 25, 2024 at 02:39:37PM -0400, sahanlb wrote: > > PCI legacy configuration space does not have sufficient space for a device > > that supports all kinds of virtio structures via PCI capabilities. This is > > especially true

Re: [PATCH v2 4/7] bpf: support error injection static keys for multi_link attached progs

2024-06-25 Thread Alexei Starovoitov
On Wed, Jun 19, 2024 at 3:49 PM Vlastimil Babka wrote: > > Functions marked for error injection can have an associated static key > that guards the callsite(s) to avoid overhead of calling an empty > function when no error injection is in progress. > > Outside of the error injection framework

Re: [PATCH] virtio-pci: PCI extended capabilities for virtio

2024-06-25 Thread Michael S. Tsirkin
On Tue, Jun 25, 2024 at 02:39:37PM -0400, sahanlb wrote: > PCI legacy configuration space does not have sufficient space for a device > that supports all kinds of virtio structures via PCI capabilities. This is > especially true if one were to use virtio drivers with physical devices. > Link:

Re: [PATCH] qdisc: fix NULL pointer dereference in perf_trace_qdisc_reset()

2024-06-25 Thread Steven Rostedt
On Fri, 21 Jun 2024 20:45:49 +0900 ysk...@gmail.com wrote: > diff --git a/include/trace/events/qdisc.h b/include/trace/events/qdisc.h > index f1b5e816e7e5..170b51fbe47a 100644 > --- a/include/trace/events/qdisc.h > +++ b/include/trace/events/qdisc.h > @@ -81,7 +81,7 @@ TRACE_EVENT(qdisc_reset, >

Re: [RFC PATCH v2] ptp: Add vDSO-style vmclock support

2024-06-25 Thread John Stultz
On Tue, Jun 25, 2024 at 2:48 PM David Woodhouse wrote: > On Tue, 2024-06-25 at 23:34 +0200, Thomas Gleixner wrote: > > On Tue, Jun 25 2024 at 20:01, David Woodhouse wrote: > > > From: David Woodhouse > > > > > > The vmclock "device" provides a shared memory region with precision clock > > >

Re: [RFC PATCH v2] ptp: Add vDSO-style vmclock support

2024-06-25 Thread David Woodhouse
On Tue, 2024-06-25 at 23:34 +0200, Thomas Gleixner wrote: > On Tue, Jun 25 2024 at 20:01, David Woodhouse wrote: > > From: David Woodhouse > > > > The vmclock "device" provides a shared memory region with precision clock > > information. By using shared memory, it is safe across Live Migration.

Re: [RFC PATCH v2] ptp: Add vDSO-style vmclock support

2024-06-25 Thread Thomas Gleixner
On Tue, Jun 25 2024 at 20:01, David Woodhouse wrote: > From: David Woodhouse > > The vmclock "device" provides a shared memory region with precision clock > information. By using shared memory, it is safe across Live Migration. > > Like the KVM PTP clock, this can convert TSC-based cross

Re: [PATCH v3 3/4] remoteproc: qcom_q6v5_pas: Add support to attach a DSP

2024-06-25 Thread Bjorn Andersson
On Thu, Jun 20, 2024 at 05:31:42PM GMT, Komal Bajaj wrote: > From: Melody Olvera > > Some chipsets will have DSPs which will have begun running prior > to linux booting, so add support to late attach these DSPs by > adding support for: > - run-time checking of an offline or running DSP via rmb

[PATCH v2 4/4] EDAC/mce_amd: Add support for FRU Text in MCA

2024-06-25 Thread Avadhut Naik
From: Yazen Ghannam A new "FRU Text in MCA" feature is defined where the Field Replaceable Unit (FRU) Text for a device is represented by a string in the new MCA_SYND1 and MCA_SYND2 registers. This feature is supported per MCA bank, and it is advertised by the McaFruTextInMca bit

[PATCH v2 3/4] x86/mce/apei: Handle variable register array size

2024-06-25 Thread Avadhut Naik
From: Yazen Ghannam ACPI Boot Error Record Table (BERT) is being used by the kernel to report errors that occurred in a previous boot. On some modern AMD systems, these very errors within the BERT are reported through the x86 Common Platform Error Record (CPER) format which consists of one or

[PATCH v2 2/4] x86/mce, EDAC/mce_amd: Add support for new MCA_SYND{1,2} registers

2024-06-25 Thread Avadhut Naik
AMD's Scalable MCA systems viz. Genoa will include two new registers: MCA_SYND1 and MCA_SYND2. These registers will include supplemental error information in addition to the existing MCA_SYND register. The data within the registers is considered valid if MCA_STATUS[SyndV] is set. Add fields for

[PATCH v2 1/4] x86/mce: Add wrapper for struct mce to export vendor specific info

2024-06-25 Thread Avadhut Naik
Currently, exporting new additional machine check error information involves adding new fields for the same at the end of the struct mce. This additional information can then be consumed through mcelog or tracepoint. However, as new MSRs are being added (and will be added in the future) by CPU

[PATCH v2 0/4] MCE wrapper and support for new SMCA syndrome MSRs

2024-06-25 Thread Avadhut Naik
This patchset adds a new wrapper for struct mce to prevent its bloating and export vendor specific error information. Additionally, support is also introduced for two new "syndrome" MSRs used in newer AMD Scalable MCA (SMCA) systems. Also, a new "FRU Text in MCA" feature that uses these new

Re: [PATCH 02/12] uprobes: grab write mmap lock in unapply_uprobe()

2024-06-25 Thread Oleg Nesterov
On 06/25, Andrii Nakryiko wrote: > > On Tue, Jun 25, 2024 at 7:51 AM Oleg Nesterov wrote: > > > > Why? > > > > So far I don't understand this change. Quite possibly I missed something, > > but in this case the changelog should explain the problem more clearly. > > > > I just went off of "Called

[RFC PATCH v2] ptp: Add vDSO-style vmclock support

2024-06-25 Thread David Woodhouse
From: David Woodhouse The vmclock "device" provides a shared memory region with precision clock information. By using shared memory, it is safe across Live Migration. Like the KVM PTP clock, this can convert TSC-based cross timestamps into KVM clock values. Unlike the KVM PTP clock, it does so

[PATCH] virtio-pci: PCI extended capabilities for virtio

2024-06-25 Thread sahanlb
PCI legacy configuration space does not have sufficient space for a device that supports all kinds of virtio structures via PCI capabilities. This is especially true if one were to use virtio drivers with physical devices. Link: https://par.nsf.gov/servlets/purl/10463939 A physical device may

Re: [PATCH v3 2/2] rust: add tracepoint support

2024-06-25 Thread Boqun Feng
On Fri, Jun 21, 2024 at 02:52:10PM +0200, Alice Ryhl wrote: [...] > > Hmm, I tried using the support where I have both events and hooks: > > #define CREATE_TRACE_POINTS > #define CREATE_RUST_TRACE_POINTS > #include > #include > > But it's not really working. Initially I thought that it's

Re: [PATCH v2 6/7] mm, slab: add static key for should_failslab()

2024-06-25 Thread Vlastimil Babka
On 6/25/24 7:12 PM, Alexei Starovoitov wrote: > On Tue, Jun 25, 2024 at 7:24 AM Vlastimil Babka wrote: >> >> On 6/20/24 12:49 AM, Vlastimil Babka wrote: >> > --- a/mm/slub.c >> > +++ b/mm/slub.c >> > @@ -3874,13 +3874,37 @@ static __always_inline void >> > maybe_wipe_obj_freeptr(struct

Re: [PATCH 02/12] uprobes: grab write mmap lock in unapply_uprobe()

2024-06-25 Thread Andrii Nakryiko
On Tue, Jun 25, 2024 at 7:51 AM Oleg Nesterov wrote: > > On 06/25, Masami Hiramatsu wrote: > > > > On Mon, 24 Jun 2024 17:21:34 -0700 > > Andrii Nakryiko wrote: > > > > > Given unapply_uprobe() can call remove_breakpoint() which eventually > > > calls uprobe_write_opcode(), which can modify a

Re: [PATCH 04/12] uprobes: revamp uprobe refcounting and lifetime management

2024-06-25 Thread Andrii Nakryiko
On Tue, Jun 25, 2024 at 7:45 AM Oleg Nesterov wrote: > > Again, I'll try to read (at least this) patch later this week, > just one cosmetic nit for now... Thanks, and yep, please take your time. I understand that this is not a trivial change to a code base that has been sitting untouched for

Re: [PATCH v2 6/7] mm, slab: add static key for should_failslab()

2024-06-25 Thread Alexei Starovoitov
On Tue, Jun 25, 2024 at 7:24 AM Vlastimil Babka wrote: > > On 6/20/24 12:49 AM, Vlastimil Babka wrote: > > --- a/mm/slub.c > > +++ b/mm/slub.c > > @@ -3874,13 +3874,37 @@ static __always_inline void > > maybe_wipe_obj_freeptr(struct kmem_cache *s, > > 0, sizeof(void *)); >

Re: (subset) [PATCH v9 0/5] soc: qcom: add in-kernel pd-mapper implementation

2024-06-25 Thread Bjorn Andersson
On Sat, 22 Jun 2024 01:03:39 +0300, Dmitry Baryshkov wrote: > Protection domain mapper is a QMI service providing mapping between > 'protection domains' and services supported / allowed in these domains. > For example such mapping is required for loading of the WiFi firmware or > for properly

Re: [PATCH v3 1/2] rust: add static_key_false

2024-06-25 Thread Boqun Feng
Hi Alice, On Fri, Jun 21, 2024 at 10:35:26AM +, Alice Ryhl wrote: > Add just enough support for static key so that we can use it from > tracepoints. Tracepoints rely on `static_key_false` even though it is > deprecated, so we add the same functionality to Rust. > > It is not possible to use

Re: [PATCH 1/8] riscv: stacktrace: convert arch_stack_walk() to noinstr

2024-06-25 Thread Palmer Dabbelt
On Tue, 18 Jun 2024 02:55:32 PDT (-0700), a...@ghiti.fr wrote: Hi Andy, On 13/06/2024 09:11, Andy Chiu wrote: arch_stack_walk() is called intensively in function_graph when the kernel is compiled with CONFIG_TRACE_IRQFLAGS. As a result, the kernel logs a lot of arch_stack_walk and its

Re: [PATCH v3] x86/paravirt: Disable virt spinlock on bare metal

2024-06-25 Thread Nikolay Borisov
On 25.06.24 г. 17:50 ч., Chen Yu wrote: On 2024-06-25 at 16:42:11 +0300, Nikolay Borisov wrote: On 25.06.24 г. 15:54 ч., Chen Yu wrote: The kernel can change spinlock behavior when running as a guest. But this guest-friendly behavior causes performance problems on bare metal. So there's a

Re: [PATCH] x86/vmware: fix panic in vmware_hypercall_slow()

2024-06-25 Thread Alexey Makhalov
On 6/25/24 7:51 AM, Borislav Petkov wrote: On Tue, Jun 25, 2024 at 07:45:50AM -0700, Alexey Makhalov wrote: My test environment was screwed up during the last version of the patchset. I was using a kernel which was built previously and didn't pay attention to commit hash suffix in `uname

Re: [PATCH] x86/vmware: fix panic in vmware_hypercall_slow()

2024-06-25 Thread Borislav Petkov
On Tue, Jun 25, 2024 at 07:45:50AM -0700, Alexey Makhalov wrote: > My test environment was screwed up during the last version of the patchset. > I was using a kernel which was built previously and didn't pay attention to > commit hash suffix in `uname -r`. > Human mistake, apologize for that. Ok,

Re: [PATCH 02/12] uprobes: grab write mmap lock in unapply_uprobe()

2024-06-25 Thread Oleg Nesterov
On 06/25, Masami Hiramatsu wrote: > > On Mon, 24 Jun 2024 17:21:34 -0700 > Andrii Nakryiko wrote: > > > Given unapply_uprobe() can call remove_breakpoint() which eventually > > calls uprobe_write_opcode(), which can modify a set of memory pages and > > expects mm->mmap_lock held for write, it

Re: [PATCH v3] x86/paravirt: Disable virt spinlock on bare metal

2024-06-25 Thread Chen Yu
On 2024-06-25 at 16:42:11 +0300, Nikolay Borisov wrote: > > > On 25.06.24 г. 15:54 ч., Chen Yu wrote: > > The kernel can change spinlock behavior when running as a guest. But > > this guest-friendly behavior causes performance problems on bare metal. > > So there's a 'virt_spin_lock_key' static

Re: [PATCH 04/12] uprobes: revamp uprobe refcounting and lifetime management

2024-06-25 Thread Oleg Nesterov
Again, I'll try to read (at least this) patch later this week, just one cosmetic nit for now... On 06/24, Andrii Nakryiko wrote: > > + * UPROBE_REFCNT_GET constant is chosen such that it will *increment both* > + * epoch and refcnt parts atomically with one atomic_add(). > + * UPROBE_REFCNT_PUT

Re: [PATCH] x86/vmware: fix panic in vmware_hypercall_slow()

2024-06-25 Thread Alexey Makhalov
My test environment was screwed up during the last version of the patchset. I was using a kernel which was built previously and didn't pay attention to commit hash suffix in `uname -r`. Human mistake, apologize for that. Alex found it while doing TDX testing on x86/vmware on tip. Do you want

Re: [PATCH v2 2/7] error-injection: support static keys around injectable functions

2024-06-25 Thread Steven Rostedt
On Thu, 20 Jun 2024 00:48:56 +0200 Vlastimil Babka wrote: > @@ -86,6 +104,7 @@ static void populate_error_injection_list(struct > error_injection_entry *start, > ent->start_addr = entry; > ent->end_addr = entry + size; > ent->etype = iter->etype; > +

Re: [PATCH v2 6/7] mm, slab: add static key for should_failslab()

2024-06-25 Thread Vlastimil Babka
On 6/20/24 12:49 AM, Vlastimil Babka wrote: > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -3874,13 +3874,37 @@ static __always_inline void > maybe_wipe_obj_freeptr(struct kmem_cache *s, > 0, sizeof(void *)); > } > > -noinline int should_failslab(struct kmem_cache *s, gfp_t

Re: [PATCH v2 1/7] fault-inject: add support for static keys around fault injection sites

2024-06-25 Thread Steven Rostedt
On Thu, 20 Jun 2024 00:48:55 +0200 Vlastimil Babka wrote: > +static int debugfs_prob_set(void *data, u64 val) > +{ > + struct fault_attr *attr = data; > + > + mutex_lock(_mutex); > + > + if (attr->active) { > + if (attr->probability != 0 && val == 0) { > +

Re: [RFC PATCH v1 1/2] virtio/vsock: rework deferred credit update logic

2024-06-25 Thread Arseniy Krasnov
On 25.06.2024 16:46, Stefano Garzarella wrote: > On Fri, Jun 21, 2024 at 10:25:40PM GMT, Arseniy Krasnov wrote: >> Previous calculation of 'free_space' was wrong (but worked as expected >> in most cases, see below), because it didn't account number of bytes in >> rx queue. Let's rework

[PATCH net-next v9 05/13] mm: page_frag: avoid caller accessing 'page_frag_cache' directly

2024-06-25 Thread Yunsheng Lin
Use appropriate frag_page API instead of caller accessing 'page_frag_cache' directly. CC: Alexander Duyck Signed-off-by: Yunsheng Lin --- drivers/vhost/net.c | 2 +- include/linux/page_frag_cache.h | 10 ++ mm/page_frag_test.c | 2 +- net/core/skbuff.c

[PATCH net-next v9 04/13] mm: page_frag: add '_va' suffix to page_frag API

2024-06-25 Thread Yunsheng Lin
Currently the page_frag API is returning 'virtual address' or 'va' when allocing and expecting 'virtual address' or 'va' as input when freeing. As we are about to support new use cases that the caller need to deal with 'struct page' or need to deal with both 'va' and 'struct page'. In order to

Re: [RFC PATCH v1 1/2] virtio/vsock: rework deferred credit update logic

2024-06-25 Thread Stefano Garzarella
On Fri, Jun 21, 2024 at 10:25:40PM GMT, Arseniy Krasnov wrote: Previous calculation of 'free_space' was wrong (but worked as expected in most cases, see below), because it didn't account number of bytes in rx queue. Let's rework 'free_space' calculation in the following way: as this value is

Re: [PATCH v3] x86/paravirt: Disable virt spinlock on bare metal

2024-06-25 Thread Nikolay Borisov
On 25.06.24 г. 15:54 ч., Chen Yu wrote: The kernel can change spinlock behavior when running as a guest. But this guest-friendly behavior causes performance problems on bare metal. So there's a 'virt_spin_lock_key' static key to switch between the two modes. The static key is always enabled

[PATCH v3] x86/paravirt: Disable virt spinlock on bare metal

2024-06-25 Thread Chen Yu
The kernel can change spinlock behavior when running as a guest. But this guest-friendly behavior causes performance problems on bare metal. So there's a 'virt_spin_lock_key' static key to switch between the two modes. The static key is always enabled by default (run in guest mode) and should be

Re: [PATCH 02/12] uprobes: grab write mmap lock in unapply_uprobe()

2024-06-25 Thread Oleg Nesterov
I don't think I can review, I forgot everything, but I'll try to read this series when I have time to (try to) understand what it does... On 06/24, Andrii Nakryiko wrote: > > Given unapply_uprobe() can call remove_breakpoint() which eventually > calls uprobe_write_opcode(), which can modify a set

Re: [PATCH] x86/vmware: fix panic in vmware_hypercall_slow()

2024-06-25 Thread Borislav Petkov
On Tue, Jun 25, 2024 at 01:33:48AM -0700, Alexey Makhalov wrote: > Caller of vmware_hypercall_slow() can pass NULL into *out1, > *out2,... *out5. It will lead to a NULL pointer dereference. > > Check a pointer for NULL before assigning a value. I queue your patches and *now* you find this?! How

[PATCH] x86/vmware: fix panic in vmware_hypercall_slow()

2024-06-25 Thread Alexey Makhalov
Caller of vmware_hypercall_slow() can pass NULL into *out1, *out2,... *out5. It will lead to a NULL pointer dereference. Check a pointer for NULL before assigning a value. Fixes: 666cbb562d05d ("x86/vmware: Introduce VMware hypercall API") Co-developed-by: Alex James Signed-off-by: Alex James

Re: [PATCH V2 3/3] virtio-net: synchronize operstate with admin state on up/down

2024-06-25 Thread Michael S. Tsirkin
On Tue, Jun 25, 2024 at 04:11:05PM +0800, Jason Wang wrote: > On Tue, Jun 25, 2024 at 3:57 PM Michael S. Tsirkin wrote: > > > > On Tue, Jun 25, 2024 at 03:46:44PM +0800, Jason Wang wrote: > > > Workqueue is used to serialize those so we won't lose any change. > > > > So we don't need to re-read

Re: [PATCH V2 1/3] virtio: allow nested disabling of the configure interrupt

2024-06-25 Thread Michael S. Tsirkin
On Tue, Jun 25, 2024 at 04:18:00PM +0800, Jason Wang wrote: > > > > > > > > > > > > > > > > But in conclusion ;) if you don't like my suggestion do something else > > > > but make the APIs make sense, > > > > > > I don't say I don't like it:) > > > > > > Limiting it to virtio-net seems to be the

Re: [PATCH V2 1/3] virtio: allow nested disabling of the configure interrupt

2024-06-25 Thread Jason Wang
On Tue, Jun 25, 2024 at 4:04 PM Michael S. Tsirkin wrote: > > On Tue, Jun 25, 2024 at 03:50:30PM +0800, Jason Wang wrote: > > On Tue, Jun 25, 2024 at 3:11 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Jun 25, 2024 at 09:27:04AM +0800, Jason Wang wrote: > > > > On Mon, Jun 24, 2024 at 5:59 PM

Re: [PATCH V2 3/3] virtio-net: synchronize operstate with admin state on up/down

2024-06-25 Thread Jason Wang
On Tue, Jun 25, 2024 at 3:57 PM Michael S. Tsirkin wrote: > > On Tue, Jun 25, 2024 at 03:46:44PM +0800, Jason Wang wrote: > > Workqueue is used to serialize those so we won't lose any change. > > So we don't need to re-read then? > We might have to re-read but I don't get why it is a problem for

Re: [PATCH] vfs: Add AT_EMPTY_PATH_NOCHECK as unchecked AT_EMPTY_PATH

2024-06-25 Thread Christian Brauner
On Sat, Jun 22, 2024 at 03:41:19PM GMT, Linus Torvalds wrote: > On Sat, 22 Jun 2024 at 14:25, Mateusz Guzik wrote: > > > > +cc Linus > > Thanks. > > > To sum up the problem: stat and statx met with "" + AT_EMPTY_PATH have > > more work to do than fstat and its hypotethical statx counterpart: >

Re: [PATCH V2 1/3] virtio: allow nested disabling of the configure interrupt

2024-06-25 Thread Michael S. Tsirkin
On Tue, Jun 25, 2024 at 03:50:30PM +0800, Jason Wang wrote: > On Tue, Jun 25, 2024 at 3:11 PM Michael S. Tsirkin wrote: > > > > On Tue, Jun 25, 2024 at 09:27:04AM +0800, Jason Wang wrote: > > > On Mon, Jun 24, 2024 at 5:59 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Mon, Jun 24, 2024

Re: [PATCH V2 3/3] virtio-net: synchronize operstate with admin state on up/down

2024-06-25 Thread Michael S. Tsirkin
On Tue, Jun 25, 2024 at 03:46:44PM +0800, Jason Wang wrote: > Workqueue is used to serialize those so we won't lose any change. So we don't need to re-read then?

Re: [PATCH V2 1/3] virtio: allow nested disabling of the configure interrupt

2024-06-25 Thread Jason Wang
On Tue, Jun 25, 2024 at 3:11 PM Michael S. Tsirkin wrote: > > On Tue, Jun 25, 2024 at 09:27:04AM +0800, Jason Wang wrote: > > On Mon, Jun 24, 2024 at 5:59 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Jun 24, 2024 at 10:45:21AM +0800, Jason Wang wrote: > > > > Somtime driver may want to

Re: [PATCH V2 3/3] virtio-net: synchronize operstate with admin state on up/down

2024-06-25 Thread Jason Wang
On Tue, Jun 25, 2024 at 3:16 PM Michael S. Tsirkin wrote: > > On Tue, Jun 25, 2024 at 09:27:38AM +0800, Jason Wang wrote: > > On Mon, Jun 24, 2024 at 6:07 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Jun 24, 2024 at 10:45:23AM +0800, Jason Wang wrote: > > > > This patch synchronize operstate

Re: [PATCH V2 3/3] virtio-net: synchronize operstate with admin state on up/down

2024-06-25 Thread Michael S. Tsirkin
On Tue, Jun 25, 2024 at 09:27:38AM +0800, Jason Wang wrote: > On Mon, Jun 24, 2024 at 6:07 PM Michael S. Tsirkin wrote: > > > > On Mon, Jun 24, 2024 at 10:45:23AM +0800, Jason Wang wrote: > > > This patch synchronize operstate with admin state per RFC2863. > > > > > > This is done by trying to

Re: [PATCH v9 4/8] remoteproc: qcom: Add ssr subdevice identifier

2024-06-25 Thread Dmitry Baryshkov
On Tue, Jun 25, 2024 at 09:04:17AM GMT, Krzysztof Kozlowski wrote: > On 25/06/2024 08:28, Gokul Sriram P wrote: > > > > On 6/21/2024 8:40 PM, Krzysztof Kozlowski wrote: > >> On 21/06/2024 13:46, Gokul Sriram Palanisamy wrote: > >>> Add name for ssr subdevice on IPQ8074 SoC. > >> Why? > >   Oops!

Re: [PATCH V2 1/3] virtio: allow nested disabling of the configure interrupt

2024-06-25 Thread Michael S. Tsirkin
On Tue, Jun 25, 2024 at 09:27:04AM +0800, Jason Wang wrote: > On Mon, Jun 24, 2024 at 5:59 PM Michael S. Tsirkin wrote: > > > > On Mon, Jun 24, 2024 at 10:45:21AM +0800, Jason Wang wrote: > > > Somtime driver may want to enable or disable the config callback. This > > > requires a synchronization

Re: [PATCH v9 4/8] remoteproc: qcom: Add ssr subdevice identifier

2024-06-25 Thread Krzysztof Kozlowski
On 25/06/2024 08:28, Gokul Sriram P wrote: > > On 6/21/2024 8:40 PM, Krzysztof Kozlowski wrote: >> On 21/06/2024 13:46, Gokul Sriram Palanisamy wrote: >>> Add name for ssr subdevice on IPQ8074 SoC. >> Why? >   Oops! Missed the change. Will add and update. >>> Signed-off-by: Nikhil Prakash V >>>