Re: [PATCH 0/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-14 Thread Uwe Kleine-König
Hello Werner, On Fri, Nov 15, 2024 at 07:09:49AM +0100, Werner Sembach wrote: > Am 15.11.24 um 05:43 schrieb Greg KH: > > On Thu, Nov 14, 2024 at 11:49:04AM +0100, Werner Sembach wrote: > > > Am 14.11.24 um 11:31 schrieb Uwe Kleine-König: > > > > the kernel modules provided by Tuxedo on > > > > ht

Re: [PATCH 1/2] module: Put known GPL offenders in an array

2024-11-14 Thread Greg KH
On Thu, Nov 14, 2024 at 11:31:33AM +0100, Uwe Kleine-König wrote: > Instead of repeating the add_taint_module() call for each offender, create > an array and loop over that one. This simplifies adding new entries > considerably. > > Signed-off-by: Uwe Kleine-König > --- > kernel/module/main.c |

Re: [PATCH 0/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-14 Thread Greg KH
On Fri, Nov 15, 2024 at 07:09:49AM +0100, Werner Sembach wrote: > Hi, > > Am 15.11.24 um 05:43 schrieb Greg KH: > > On Thu, Nov 14, 2024 at 11:49:04AM +0100, Werner Sembach wrote: > > > Hello, > > > > > > Am 14.11.24 um 11:31 schrieb Uwe Kleine-König: > > > > Hello, > > > > > > > > the kernel mo

Re: [PATCH 0/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-14 Thread Werner Sembach
Hi, Am 15.11.24 um 05:43 schrieb Greg KH: On Thu, Nov 14, 2024 at 11:49:04AM +0100, Werner Sembach wrote: Hello, Am 14.11.24 um 11:31 schrieb Uwe Kleine-König: Hello, the kernel modules provided by Tuxedo on https://gitlab.com/tuxedocomputers/development/packages/tuxedo-drivers are licensed

Re: [PATCH v4 0/8] Basic SEV-SNP Selftests

2024-11-14 Thread Aithal, Srikanth
On 11/15/2024 5:10 AM, Pratik R. Sampat wrote: This patch series extends the sev_init2 and the sev_smoke test to exercise the SEV-SNP VM launch workflow. Primarily, it introduces the architectural defines, its support in the SEV library and extends the tests to interact with the SEV-SNP ioctl()

Re: [PATCH 0/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-14 Thread Greg KH
On Thu, Nov 14, 2024 at 11:49:04AM +0100, Werner Sembach wrote: > Hello, > > Am 14.11.24 um 11:31 schrieb Uwe Kleine-König: > > Hello, > > > > the kernel modules provided by Tuxedo on > > https://gitlab.com/tuxedocomputers/development/packages/tuxedo-drivers > > are licensed under GPLv3 or later.

Re: [PATCH 2/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-14 Thread Greg KH
On Thu, Nov 14, 2024 at 11:31:34AM +0100, Uwe Kleine-König wrote: > Tuxedo licenses the modules used on their hardware under GPLv3+, to > "keep control of the upstream pacing" – and want to re-license the code > while upstreaming. > > They were asked to then at least not use MODULE_LICENSE("GPL")

Re: [PATCH 2/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-14 Thread Greg KH
On Thu, Nov 14, 2024 at 12:56:20PM +0100, Daniel Gomez wrote: > On Thu Nov 14, 2024 at 11:31 AM CET, Uwe Kleine-König wrote: > > Tuxedo licenses the modules used on their hardware under GPLv3+, to > > "keep control of the upstream pacing" – and want to re-license the code > > while upstreaming. > >

[PATCH net-next v4 2/3] selftests: nic_link_layer: Add selftest case for speed and duplex states

2024-11-14 Thread Mohan Prasad J
Add selftest case for testing the speed and duplex state of local NIC driver and the partner based on the supported link modes obtained from the ethtool. Speed and duplex states are varied and verified using ethtool. Signed-off-by: Mohan Prasad J --- .../drivers/net/hw/nic_link_layer.py

[PATCH net-next v4 3/3] selftests: nic_performance: Add selftest for performance of NIC driver

2024-11-14 Thread Mohan Prasad J
Add selftest case to check the send and receive throughput. Supported link modes between local NIC driver and partner are varied. Then send and receive throughput is captured and verified. Test uses iperf3 tool. Add iperf3 server/client function in GenerateTraffic class. Signed-off-by: Mohan Prasa

[PATCH net-next v4 1/3] selftests: nic_link_layer: Add link layer selftest for NIC driver

2024-11-14 Thread Mohan Prasad J
Add selftest file for the link layer tests of a NIC driver. Test for auto-negotiation is added. Add LinkConfig class for changing link layer configs. Selftest makes use of ksft modules and ethtool. Include selftest file in the Makefile. Signed-off-by: Mohan Prasad J --- .../testing/selftests/dri

[PATCH net-next v4 0/3] selftests: Add selftest for link layer and performance testing

2024-11-14 Thread Mohan Prasad J
The series of patches are for doing basic tests of NIC driver. Test comprises checks for auto-negotiation, speed, duplex state and throughput between local NIC and partner. Tools such as ethtool, iperf3 are used. Signed-off-by: Mohan Prasad J --- Changes in v4: - Type hints are added for argument

[PATCH v4 4/8] KVM: selftests: Introduce SEV VM type check

2024-11-14 Thread Pratik R. Sampat
In preparation for SNP, declutter the vm type check by introducing a SEV-SNP VM type check as well a transitive set of helper functions. The SNP VM type is the subset of SEV-ES. Similarly, the SEV-ES and SNP types are subset of the SEV VM type check. Signed-off-by: Pratik R. Sampat --- .../test

[PATCH v4 0/8] Basic SEV-SNP Selftests

2024-11-14 Thread Pratik R. Sampat
This patch series extends the sev_init2 and the sev_smoke test to exercise the SEV-SNP VM launch workflow. Primarily, it introduces the architectural defines, its support in the SEV library and extends the tests to interact with the SEV-SNP ioctl() wrappers. Patch 1 - Do not advertize SNP on inco

[PATCH v4 2/8] KVM: selftests: SEV-SNP test for KVM_SEV_INIT2

2024-11-14 Thread Pratik R. Sampat
Add the X86_FEATURE_SNP CPU feature to the architectural definition for the SEV-SNP VM type to exercise the KVM_SEV_INIT2 call. Ensure that the SNP test is skipped in scenarios where CPUID supports it but KVM does not, so that a failure is not reported in such cases. Signed-off-by: Pratik R. Sampa

[PATCH v4 5/8] KVM: selftests: Add library support for interacting with SNP

2024-11-14 Thread Pratik R. Sampat
Extend the SEV library to include support for SNP ioctl() wrappers, which aid in launching and interacting with a SEV-SNP guest. Signed-off-by: Pratik R. Sampat --- .../selftests/kvm/include/x86_64/sev.h| 49 ++- tools/testing/selftests/kvm/lib/x86_64/sev.c | 81

[PATCH v4 1/8] KVM: SEV: Disable SEV-SNP on FW validation failure

2024-11-14 Thread Pratik R. Sampat
On incompatible firmware versions, SEV-SNP support is pulled and the setup is not performed. However, the platform and subsequently the KVM capability may continue to advertize support for it. Disable support for SEV-SNP if the FW version validation fails. Fixes: 1dfe571c12cf ("KVM: SEV: Add initi

[PATCH v4 8/8] KVM: selftests: Add a basic SEV-SNP smoke test

2024-11-14 Thread Pratik R. Sampat
Extend sev_smoke_test to also run a minimal SEV-SNP smoke test that initializes and sets up private memory regions required to run a simple SEV-SNP guest. Similar to its SEV-ES smoke test counterpart, this also does not support GHCB and ucall yet and uses the GHCB MSR protocol to trigger an exit o

[PATCH v4 7/8] KVM: selftests: Abstractions for SEV to decouple policy from type

2024-11-14 Thread Pratik R. Sampat
In preparation for SNP, cleanup the smoke test to decouple deriving type from policy. Introduce, wrappers for SEV and SEV-ES types to abstract the parametrized launch tests calls and reduce verbosity. No functional change intended. Signed-off-by: Pratik R. Sampat --- .../selftests/kvm/x86_64/se

[PATCH v4 6/8] KVM: selftests: Force GUEST_MEMFD flag for SNP VM type

2024-11-14 Thread Pratik R. Sampat
Force the SEV-SNP VM type to set the KVM_MEM_GUEST_MEMFD flag for the creation of private memslots. Signed-off-by: Pratik R. Sampat --- tools/testing/selftests/kvm/lib/kvm_util.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c

[PATCH v4 3/8] KVM: selftests: Add VMGEXIT helper

2024-11-14 Thread Pratik R. Sampat
Abstract rep vmmcall coded into the VMGEXIT helper for the sev library. No functional change intended. Signed-off-by: Pratik R. Sampat --- tools/testing/selftests/kvm/include/x86_64/sev.h| 2 ++ tools/testing/selftests/kvm/x86_64/sev_smoke_test.c | 2 +- 2 files changed, 3 insertions(+), 1

Re: [PATCH 2/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-14 Thread Al Viro
On Thu, Nov 14, 2024 at 01:21:41PM -0600, Aaron Rainbolt wrote: > binary you get after compiling and linking. It looks to me like this > patch will prevent users from compiling Tuxedo's modules for personal > use on their own systems though. I personally dislike that for ethical > reasons - I shou

Re: [PATCH RESEND v13 01/12] clk: mmp: Switch to use struct u32_fract instead of custom one

2024-11-14 Thread Stephen Boyd
Quoting Duje Mihanović via B4 Relay (2024-11-04 08:37:03) > From: Andy Shevchenko > > The struct mmp_clk_factor_tbl repeats the generic struct u32_fract. > Kill the custom one and use the generic one instead. > > Signed-off-by: Andy Shevchenko > Tested-by: Duje Mihanović > Reviewed-by: Linus W

Re: [PATCH net-next v11 04/23] ovpn: add basic interface creation/destruction/management routines

2024-11-14 Thread Sergey Ryazanov
On 14.11.2024 10:07, Antonio Quartulli wrote: On 12/11/2024 17:47, Sabrina Dubroca wrote: 2024-11-09, 03:01:21 +0200, Sergey Ryazanov wrote: On 29.10.2024 12:47, Antonio Quartulli wrote: +/* When the OpenVPN protocol is ran in AEAD mode, use + * the OpenVPN packet ID as the AEAD nonce: + * + *

[PATCH] arm64: dts: qcom: msm8916-samsung-serranove: Add display panel

2024-11-14 Thread Jakob Hauser
From: Stephan Gerhold Add the Samsung S6E88A0-AMS427AP24 panel to the device tree for the Samsung Galaxy S4 Mini Value Edition. By default the panel displays everything horizontally flipped, so add "flip-horizontal" to the panel node to correct that. Signed-off-by: Stephan Gerhold Co-developed-

Re: [PATCH RESEND v13 08/12] clk: mmp: Add Marvell PXA1908 MPMU driver

2024-11-14 Thread Stephen Boyd
Quoting Duje Mihanović via B4 Relay (2024-11-04 08:37:10) > From: Duje Mihanović > > Add driver for the MPMU controller block on Marvell's PXA1908 SoC. The > driver is incomplete, currently only supporting the fixed PLL1; dynamic > PLLs 2-4 and CPU/DDR/AXI clock support is missing. > > Signed-of

Re: [PATCH RESEND v13 07/12] clk: mmp: Add Marvell PXA1908 APMU driver

2024-11-14 Thread Stephen Boyd
Quoting Duje Mihanović via B4 Relay (2024-11-04 08:37:09) > From: Duje Mihanović > > Add driver for the APMU controller block found on Marvell's PXA1908 SoC. > This driver is incomplete, lacking support for (at least) GPU, VPU, DSI > and CCIC (camera related) clocks. > > Signed-off-by: Duje Miha

Re: [PATCH RESEND v13 06/12] clk: mmp: Add Marvell PXA1908 APBCP driver

2024-11-14 Thread Stephen Boyd
Quoting Duje Mihanović via B4 Relay (2024-11-04 08:37:08) > From: Duje Mihanović > > Add driver for the APBCP controller block found on Marvell's PXA1908 > SoC. > > Signed-off-by: Duje Mihanović > --- Applied to clk-next

Re: [PATCH RESEND v13 05/12] clk: mmp: Add Marvell PXA1908 APBC driver

2024-11-14 Thread Stephen Boyd
Quoting Duje Mihanović via B4 Relay (2024-11-04 08:37:07) > From: Duje Mihanović > > Add driver for the APBC controller block found on Marvell's PXA1908 SoC. > > Signed-off-by: Duje Mihanović > --- Applied to clk-next

Re: [PATCH RESEND v13 04/12] dt-bindings: clock: Add Marvell PXA1908 clock bindings

2024-11-14 Thread Stephen Boyd
Quoting Duje Mihanović via B4 Relay (2024-11-04 08:37:06) > From: Duje Mihanović > > Add dt bindings and documentation for the Marvell PXA1908 clock > controller. > > Reviewed-by: Conor Dooley > Reviewed-by: Stephen Boyd > Signed-off-by: Duje Mihanović > --- Applied to clk-next

[PATCH bpf-next v2 08/13] selftests/bpf: Enable generic tc actions in selftests config

2024-11-14 Thread eBPF Foundation
Enable CONFIG_NET_ACT_GACT to allow adding simple actions with tc filters. This is for example needed to migrate test_flow_dissector into the automated testing performed in CI. Acked-by: Stanislav Fomichev Signed-off-by: Alexis Lothoré (eBPF Foundation) --- Changes in v2: - fetch Acked-by tag --

[PATCH bpf-next v2 12/13] selftests/bpf: migrate bpf flow dissectors tests to test_progs

2024-11-14 Thread eBPF Foundation
test_flow_dissector.sh loads flow_dissector program and subprograms, creates and configured relevant tunnels and interfaces, and ensure that the bpf dissection is actually performed correctly. Similar tests exist in test_progs (thanks to flow_dissector.c) and run the same programs, but those are on

Re: [PATCH net-next v11 00/23] Introducing OpenVPN Data Channel Offload

2024-11-14 Thread Sergey Ryazanov
On 14.11.2024 17:33, Antonio Quartulli wrote: On 06/11/2024 02:18, Sergey Ryazanov wrote: Regarding "big" topics I have only two concerns: link creation using RTNL and a switch statement usage. In the corresponding thread, I asked Jiri to clarify that "should" regarding .newlink implementation.

[PATCH bpf-next v2 02/13] selftests/bpf: use ASSERT_MEMEQ to compare bpf flow keys

2024-11-14 Thread eBPF Foundation
The flow_dissector program currently compares flow keys returned by bpf program with the expected one thanks to a custom macro using memcmp. Use the new ASSERT_MEMEQ macro to perform this comparision. This update also allows to get rid of the unused bpf_test_run_opts variable in run_tests_skb_less

[PATCH bpf-next v2 03/13] selftests/bpf: replace CHECK calls with ASSERT macros in flow_dissector test

2024-11-14 Thread eBPF Foundation
The flow dissector test currently relies on generic CHECK macros to perform tests. Update those to newer, more-specific ASSERT macros. This update allows to get rid of the global duration variable, which was needed by the CHECK macros Acked-by: Stanislav Fomichev Signed-off-by: Alexis Lothoré (e

[PATCH bpf-next v2 06/13] selftests/bpf: add gre packets testing to flow_dissector

2024-11-14 Thread eBPF Foundation
The bpf_flow program is able to handle GRE headers in IP packets. Add a few test data input simulating those GRE packets, with 2 different cases: - parse GRE and the encapsulated packet - parse GRE only Acked-by: Stanislav Fomichev Signed-off-by: Alexis Lothoré (eBPF Foundation) --- Changes in v

[PATCH bpf-next v2 13/13] selftests/bpf: remove test_flow_dissector.sh

2024-11-14 Thread eBPF Foundation
Now that test_flow_dissector.sh has been converted to test_progs, remove the legacy test. Acked-by: Stanislav Fomichev Signed-off-by: Alexis Lothoré (eBPF Foundation) --- Changes in v2: - fetch Acked-by tag --- tools/testing/selftests/bpf/.gitignore | 1 - tools/testing/selftests/

[PATCH bpf-next v2 11/13] selftests/bpf: add network helpers to generate udp checksums

2024-11-14 Thread eBPF Foundation
network_helpers.c provides some helpers to generate ip checksums or ip pseudo-header checksums, but not for upper layers (eg: udp checksums) Add helpers for udp checksum to allow manually building udp packets. Signed-off-by: Alexis Lothoré (eBPF Foundation) --- Changes in v2: - new patch --- to

[PATCH bpf-next v2 10/13] selftests/bpf: rename pseudo headers checksum computation

2024-11-14 Thread eBPF Foundation
network_helpers.h provides helpers to compute checksum for pseudo headers but no helpers to compute the global checksums. Before adding those, rename the pseudo header checksum helper to clarify their role. Signed-off-by: Alexis Lothoré (eBPF Foundation) --- Changes in v2: - new patch --- tools

[PATCH bpf-next v2 09/13] selftests/bpf: move ip checksum helper to network helpers

2024-11-14 Thread eBPF Foundation
xdp_metadata test has a small helper computing ipv checksums to allow manually building packets. Move this helper to network_helpers to share it with other tests. Signed-off-by: Alexis Lothoré (eBPF Foundation) --- Changes in v2: - new patch --- tools/testing/selftests/bpf/network_helpers.h

[PATCH bpf-next v2 07/13] selftests/bpf: migrate flow_dissector namespace exclusivity test

2024-11-14 Thread eBPF Foundation
Commit a11c397c43d5 ("bpf/flow_dissector: add mode to enforce global BPF flow dissector") is currently tested in test_flow_dissector.sh, which is not part of test_progs. Add the corresponding test to flow_dissector.c, which is part of test_progs. The new test reproduces the behavior implemented in

[PATCH bpf-next v2 05/13] selftests/bpf: expose all subtests from flow_dissector

2024-11-14 Thread eBPF Foundation
The flow_dissector test integrated in test_progs actually runs a wide matrix of tests over different packets types and bpf programs modes, but exposes only 3 main tests, preventing tests users from running specific subtests with a specific input only. Expose all subtests executed by flow_dissector

[PATCH bpf-next v2 04/13] selftests/bpf: re-split main function into dedicated tests

2024-11-14 Thread eBPF Foundation
The flow_dissector runs plenty of tests over diffent kind of packets, grouped into three categories: skb mode, non-skb mode with direct attach, and non-skb with indirect attach. Re-split the main function into dedicated tests. Each test now must have its own setup/teardown, but for the advantage o

[PATCH bpf-next v2 01/13] selftests/bpf: add a macro to compare raw memory

2024-11-14 Thread eBPF Foundation
We sometimes need to compare whole structures in an assert. It is possible to use the existing macros on each field, but when the whole structure has to be checked, it is more convenient to simply compare the whole structure memory Add a dedicated assert macro, ASSERT_MEMEQ, to allow bare memory c

[PATCH bpf-next v2 00/13] selftests/bpf: migrate test_flow_dissector.sh to test_progs

2024-11-14 Thread eBPF Foundation
Hello, this new series aims to migrate test_flow_dissector.sh into test_progs. There are 2 "main" parts in test_flow_dissector.sh: - a set of tests checking flow_dissector programs attachment to either root namespace or non-root namespace - dissection test The first set is integrated in flow_dis

Re: [PATCH v13 4/7] remoteproc: Introduce release_fw optional operation

2024-11-14 Thread Mathieu Poirier
On Mon, Nov 04, 2024 at 02:35:12PM +0100, Arnaud Pouliquen wrote: > This patch updates the rproc_ops struct to include an optional > release_fw function. > > The release_fw ops is responsible for releasing the remote processor > firmware image. The ops is called in the following cases: > > - An

Re: [PATCH 2/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-14 Thread Aaron Rainbolt
On Thu, 14 Nov 2024 08:09:17 -0800 Christoph Hellwig wrote: > Thanks for doing this! > > Reviewed-by: Christoph Hellwig (Just as a heads-up, I have no affiliation with Tuxedo. Also, I've tried to tone down my email a bit, but I am pretty upset after looking at this, and really, *really* do not

Re: [PATCH 2/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-14 Thread Daniel Gomez
On Thu Nov 14, 2024 at 11:31 AM CET, Uwe Kleine-König wrote: > Tuxedo licenses the modules used on their hardware under GPLv3+, to > "keep control of the upstream pacing" – and want to re-license the code > while upstreaming. > > They were asked to then at least not use MODULE_LICENSE("GPL") which

Re: [PATCH v13 2/7] remoteproc: Add TEE support

2024-11-14 Thread Mathieu Poirier
On Mon, Nov 04, 2024 at 02:35:10PM +0100, Arnaud Pouliquen wrote: > Add a remoteproc TEE (Trusted Execution Environment) driver > that will be probed by the TEE bus. If the associated Trusted > application is supported on secure part this driver offers a client > interface to load a firmware by the

Re: [PATCH] selftests: lsm: Refactor `flags_overset_lsm_set_self_attr` test

2024-11-14 Thread Shuah Khan
On 11/14/24 09:55, Casey Schaufler wrote: On 11/14/2024 8:25 AM, Shuah Khan wrote: On 11/12/24 11:28, Amit Vadhavana wrote: - Remove unnecessary `tctx` variable, use `ctx` directly. - Simplified code with no functional changes. I would rephrase the short to simply say Remove unused variable

Re: [PATCH] selftests: lsm: Refactor `flags_overset_lsm_set_self_attr` test

2024-11-14 Thread Shuah Khan
On 11/12/24 11:28, Amit Vadhavana wrote: - Remove unnecessary `tctx` variable, use `ctx` directly. - Simplified code with no functional changes. I would rephrase the short to simply say Remove unused variable, as refactor implies more extensive changes than what this patch is actually doing.

Re: [PATCH RFC 2/6] mm/slub: add sheaf support for batching kfree_rcu() operations

2024-11-14 Thread Uladzislau Rezki
On Tue, Nov 12, 2024 at 05:38:46PM +0100, Vlastimil Babka wrote: > Extend the sheaf infrastructure for more efficient kfree_rcu() handling. > For caches where sheafs are initialized, on each cpu maintain a rcu_free > sheaf in addition to main and spare sheaves. > > kfree_rcu() operations will try

Re: [PATCH] selftests: lsm: Refactor `flags_overset_lsm_set_self_attr` test

2024-11-14 Thread Casey Schaufler
On 11/14/2024 8:25 AM, Shuah Khan wrote: > On 11/12/24 11:28, Amit Vadhavana wrote: >> - Remove unnecessary `tctx` variable, use `ctx` directly. >> - Simplified code with no functional changes. >> > > I would rephrase the short to simply say Remove unused variable, > as refactor implies more exte

[PATCH] kunit: debugfs: Use IS_ERR() for alloc_string_stream() error check

2024-11-14 Thread Kuan-Wei Chiu
The alloc_string_stream() function only returns ERR_PTR(-ENOMEM) on failure and never returns NULL. Therefore, switching the error check in the caller from IS_ERR_OR_NULL to IS_ERR improves clarity, indicating that this function will return an error pointer (not NULL) when an error occurs. This cha

Re: [PATCH 1/2] module: Put known GPL offenders in an array

2024-11-14 Thread Christoph Hellwig
On Thu, Nov 14, 2024 at 11:31:33AM +0100, Uwe Kleine-König wrote: > Instead of repeating the add_taint_module() call for each offender, create > an array and loop over that one. This simplifies adding new entries > considerably. > > Signed-off-by: Uwe Kleine-König Looks good: Reviewed-by: Chris

Re: [PATCH 2/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-14 Thread Christoph Hellwig
Thanks for doing this! Reviewed-by: Christoph Hellwig

Re: [PATCH net-next v23 1/7] mm: page_frag: add a test module for page_frag

2024-11-14 Thread Mark Brown
e menuconfig" or "make xconfig"). *** Makefile:810: include/config/auto.conf.cmd: No such file or directory (see https://storage.kernelci.org/next/master/next-20241114/x86_64/x86_64_defconfig%2Bkselftest/gcc-12/logs/kselftest.log) and I've seen: ERROR: Kernel configuration is inva

Re: [PATCH v3] acpi: nfit: vmalloc-out-of-bounds Read in acpi_nfit_ctl

2024-11-14 Thread Dave Jiang
On 11/14/24 2:19 AM, Suraj Sonawane wrote: > On 13/11/24 22:32, Dave Jiang wrote: >> >> >> On 11/13/24 5:51 AM, Suraj Sonawane wrote: >>> Fix an issue detected by syzbot with KASAN: >>> >>> BUG: KASAN: vmalloc-out-of-bounds in cmd_to_func drivers/acpi/nfit/ >>> core.c:416 [inline] >>> BUG: KASAN

Re: [PATCH net-next v11 00/23] Introducing OpenVPN Data Channel Offload

2024-11-14 Thread Antonio Quartulli
On 06/11/2024 02:18, Sergey Ryazanov wrote: Hi Antonio, On 29.10.2024 12:47, Antonio Quartulli wrote: Notable changes from v10: * extended commit message of 23/23 with brief description of the output * Link to v10: https://lore.kernel.org/r/20241025-b4-ovpn-v10-0- b87530777...@openvpn.net Pl

Re: [PATCH net-next v11 08/23] ovpn: implement basic TX path (UDP)

2024-11-14 Thread Antonio Quartulli
On 10/11/2024 23:32, Sergey Ryazanov wrote: [...] +/* send skb to connected peer, if any */ +static void ovpn_send(struct ovpn_struct *ovpn, struct sk_buff *skb, +  struct ovpn_peer *peer) +{ +    struct sk_buff *curr, *next; + +    if (likely(!peer)) +    /* retrieve peer serving

Re: [PATCH net 2/2] selftests/rtnetlink.sh: add mngtempaddr test

2024-11-14 Thread Jakub Kicinski
On Thu, 14 Nov 2024 08:19:31 + Hangbin Liu wrote: > > > Is this tested with patched kernel or unpatched kernel. On my local side > > > I got > > > > > > # ./rtnetlink.sh -t kci_test_mngtmpaddr > > > PASS: mngtmpaddr add/remove correctly > > > > I believe you that you run the test before se

Re: [PATCH net-next v11 06/23] ovpn: introduce the ovpn_peer object

2024-11-14 Thread Antonio Quartulli
On 10/11/2024 20:52, Sergey Ryazanov wrote: On 29.10.2024 12:47, Antonio Quartulli wrote: [...] +static void ovpn_peer_release(struct ovpn_peer *peer) +{ +    ovpn_bind_reset(peer, NULL); + nit: this empty line after ovpn_bind_reset() is removed in the 'implement basic TX path (UDP)' patch.

[PATCH net-next v1 08/10] mm: page_frag: add testing for the newly added API

2024-11-14 Thread Yunsheng Lin
Add testing for the newly added prepare API, for both aligned and non-aligned API, also probe API is also tested along with prepare API. CC: Alexander Duyck CC: Andrew Morton CC: Linux-MM Signed-off-by: Yunsheng Lin --- .../selftests/mm/page_frag/page_frag_test.c | 76 +-- t

Re: [PATCH 0/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-14 Thread Werner Sembach
Hello, Am 14.11.24 um 12:14 schrieb Uwe Kleine-König: Hello, On 11/14/24 11:49, Werner Sembach wrote: Am 14.11.24 um 11:31 schrieb Uwe Kleine-König: the kernel modules provided by Tuxedo on https://gitlab.com/tuxedocomputers/development/packages/tuxedo-drivers are licensed under GPLv3 or late

Re: [PATCH 0/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-14 Thread Daniel Gomez
On Thu Nov 14, 2024 at 11:31 AM CET, Uwe Kleine-König wrote: > Hello, > > the kernel modules provided by Tuxedo on > https://protect2.fireeye.com/v1/url?k=2f239e82-70bfb7a8-2f2215cd-000babe598f7-32952349600b722d&q=1&e=9535a8fa-5a9d-4d94-a12d-ff39b9d3b9cf&u=https%3A%2F%2Fgitlab.com%2Ftuxedocomputers

Re: [PATCH 0/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-14 Thread Uwe Kleine-König
Hello, On 11/14/24 11:49, Werner Sembach wrote: Am 14.11.24 um 11:31 schrieb Uwe Kleine-König: the kernel modules provided by Tuxedo on https://gitlab.com/tuxedocomputers/development/packages/tuxedo-drivers are licensed under GPLv3 or later. This is incompatible with the kernel's license and so

Re: [PATCH 0/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-14 Thread Werner Sembach
Hello, Am 14.11.24 um 11:31 schrieb Uwe Kleine-König: Hello, the kernel modules provided by Tuxedo on https://gitlab.com/tuxedocomputers/development/packages/tuxedo-drivers are licensed under GPLv3 or later. This is incompatible with the kernel's license and so makes it impossible for distribut

Re: [PATCH net-next v11 18/23] ovpn: implement peer add/get/dump/delete via netlink

2024-11-14 Thread Antonio Quartulli
On 13/11/2024 12:05, Sabrina Dubroca wrote: 2024-11-12, 15:26:59 +0100, Antonio Quartulli wrote: On 11/11/2024 16:41, Sabrina Dubroca wrote: 2024-10-29, 11:47:31 +0100, Antonio Quartulli wrote: +void ovpn_peer_hash_vpn_ip(struct ovpn_peer *peer) + __must_hold(&peer->ovpn->peers->lock)

[PATCH 2/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-14 Thread Uwe Kleine-König
Tuxedo licenses the modules used on their hardware under GPLv3+, to "keep control of the upstream pacing" – and want to re-license the code while upstreaming. They were asked to then at least not use MODULE_LICENSE("GPL") which declares compatibility to the kernel's GPLv2. They accepted the pull r

Re: [PATCH net-next v11 20/23] ovpn: kill key and notify userspace in case of IV exhaustion

2024-11-14 Thread Antonio Quartulli
On 13/11/2024 15:28, Sabrina Dubroca wrote: 2024-11-12, 16:44:09 +0100, Antonio Quartulli wrote: On 05/11/2024 11:33, Sabrina Dubroca wrote: 2024-10-29, 11:47:33 +0100, Antonio Quartulli wrote: +int ovpn_nl_key_swap_notify(struct ovpn_peer *peer, u8 key_id) +{ [...] + + nla_nest_end(ms

Re: [PATCH v6 3/3] vsock/test: verify socket options after setting them

2024-11-14 Thread Stefano Garzarella
On Wed, Nov 13, 2024 at 08:35:57AM -0600, Konstantin Shkolnyy wrote: Replace setsockopt() calls with calls to functions that follow setsockopt() with getsockopt() and check that the returned value and its size are the same as have been set. (Except in vsock_perf.) Signed-off-by: Konstantin Shkol

[PATCH 1/2] module: Put known GPL offenders in an array

2024-11-14 Thread Uwe Kleine-König
Instead of repeating the add_taint_module() call for each offender, create an array and loop over that one. This simplifies adding new entries considerably. Signed-off-by: Uwe Kleine-König --- kernel/module/main.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) di

[PATCH 0/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-14 Thread Uwe Kleine-König
Hello, the kernel modules provided by Tuxedo on https://gitlab.com/tuxedocomputers/development/packages/tuxedo-drivers are licensed under GPLv3 or later. This is incompatible with the kernel's license and so makes it impossible for distributions and other third parties to support these at least in

[PATCH v2] net/unix: pass pidfd flags via SCM_PIDFD cmsg

2024-11-14 Thread Stas Sergeev
Currently SCM_PIDFD cmsg cannot be sent via unix socket (returns -EINVAL) and SO_PASSPIDFD doesn't support flags. The created pidfd always has flags set to 0. This patch implements SCM_PIDFD cmsg in AF_UNIX socket, which can be used to send flags to SO_PASSPIDFD-enabled recipient. Self-test is ad

Re: [PATCH] net/unix: pass pidfd flags via SCM_PIDFD cmsg

2024-11-14 Thread stsp
14.11.2024 05:50, Kuniyuki Iwashima пишет: From: Stas Sergeev Date: Thu, 14 Nov 2024 00:02:05 +0300 @@ -154,7 +157,12 @@ static __inline__ void scm_pidfd_recv(struct msghdr *msg, struct scm_cookie *scm if (!scm->pid) return; - pidfd = pidfd_prepare(scm->pid, 0, &pidf

Re: [PATCH v3] dt-bindings: remoteproc: qcom,sa8775p-pas: Document QCS8300 remoteproc

2024-11-14 Thread Jingyi Wang
Hi Maintainers, On 9/25/2024 3:21 PM, Jingyi Wang wrote: > Document the components used to boot the ADSP, CDSP and GPDSP on the > Qualcomm QCS8300 SoC. Use fallback to indicate the compatibility of the > remoteproc on the QCS8300 with that on the SA8775P. > > Co-developed-by: Xin Liu > Signed-

Re: [PATCH net-next v11 18/23] ovpn: implement peer add/get/dump/delete via netlink

2024-11-14 Thread Antonio Quartulli
On 13/11/2024 17:56, Sabrina Dubroca wrote: 2024-11-12, 15:19:50 +0100, Antonio Quartulli wrote: On 04/11/2024 16:14, Sabrina Dubroca wrote: 2024-10-29, 11:47:31 +0100, Antonio Quartulli wrote: +static int ovpn_nl_peer_precheck(struct ovpn_struct *ovpn, +struct

Re: [PATCH v3] acpi: nfit: vmalloc-out-of-bounds Read in acpi_nfit_ctl

2024-11-14 Thread Suraj Sonawane
On 13/11/24 22:32, Dave Jiang wrote: On 11/13/24 5:51 AM, Suraj Sonawane wrote: Fix an issue detected by syzbot with KASAN: BUG: KASAN: vmalloc-out-of-bounds in cmd_to_func drivers/acpi/nfit/ core.c:416 [inline] BUG: KASAN: vmalloc-out-of-bounds in acpi_nfit_ctl+0x20e8/0x24a0 drivers/acpi/nfi

Re: [PATCH net-next v11 15/23] ovpn: implement keepalive mechanism

2024-11-14 Thread Sabrina Dubroca
2024-11-14, 09:12:01 +0100, Antonio Quartulli wrote: > On 13/11/2024 11:36, Sabrina Dubroca wrote: > > 2024-11-12, 14:20:45 +0100, Antonio Quartulli wrote: > > > On 05/11/2024 19:10, Sabrina Dubroca wrote: > > > > 2024-10-29, 11:47:28 +0100, Antonio Quartulli wrote: > > > > > + /* check for pee

Re: [PATCH net 2/2] selftests/rtnetlink.sh: add mngtempaddr test

2024-11-14 Thread Hangbin Liu
Hi Sam, On Wed, Nov 13, 2024 at 12:43:00PM -0800, Sam Edwards wrote: > > +# If the mngtmpaddr or tempaddr missing, return 0 and stop waiting > > +check_tempaddr_exists() > > +{ > > + local start=${1-"1"} > > + addr_list=$(ip -j -n $testns addr show dev ${devdummy}) > > + for i in

Re: [PATCH net 2/2] selftests/rtnetlink.sh: add mngtempaddr test

2024-11-14 Thread Hangbin Liu
On Wed, Nov 13, 2024 at 06:43:12PM -0800, Jakub Kicinski wrote: > On Thu, 14 Nov 2024 02:00:01 + Hangbin Liu wrote: > > > # [+300.25] tempaddr not deleted for 2001:db8::1 > > > # [+0.16] tempaddr not deleted for 2003:db8::1 > > > # [+0.07] FAIL: mngtmpaddr add/remove incorrect > > > not ok 1 se

Re: [PATCH net-next v11 17/23] ovpn: add support for peer floating

2024-11-14 Thread Antonio Quartulli
On 13/11/2024 12:25, Sabrina Dubroca wrote: 2024-11-12, 15:03:00 +0100, Antonio Quartulli wrote: On 12/11/2024 11:56, Sabrina Dubroca wrote: 2024-10-29, 11:47:30 +0100, Antonio Quartulli wrote: diff --git a/drivers/net/ovpn/io.c b/drivers/net/ovpn/io.c index 63c140138bf98e5d1df79a2565b666d865

Re: [PATCH bpf-next 07/10] selftests/bpf: migrate flow_dissector namespace exclusivity test

2024-11-14 Thread Alexis Lothoré
On 11/13/24 18:50, Stanislav Fomichev wrote: > On 11/13, Alexis Lothoré wrote: >> On 11/13/24 14:53, Alexis Lothoré (eBPF Foundation) wrote: >> >> [...] >> >>> + ns = open_netns(TEST_NS); >>> + bpf_prog_detach2(prog_fd, 0, BPF_FLOW_DISSECTOR); >>> + close_netns(ns); >> >> I would like to ment

Re: [PATCH net-next v11 15/23] ovpn: implement keepalive mechanism

2024-11-14 Thread Antonio Quartulli
On 13/11/2024 11:36, Sabrina Dubroca wrote: 2024-11-12, 14:20:45 +0100, Antonio Quartulli wrote: On 05/11/2024 19:10, Sabrina Dubroca wrote: 2024-10-29, 11:47:28 +0100, Antonio Quartulli wrote: @@ -105,6 +132,9 @@ void ovpn_decrypt_post(void *data, int ret) goto drop; }

Re: [PATCH net-next v11 04/23] ovpn: add basic interface creation/destruction/management routines

2024-11-14 Thread Antonio Quartulli
On 12/11/2024 17:47, Sabrina Dubroca wrote: 2024-11-09, 03:01:21 +0200, Sergey Ryazanov wrote: On 29.10.2024 12:47, Antonio Quartulli wrote: +/* When the OpenVPN protocol is ran in AEAD mode, use + * the OpenVPN packet ID as the AEAD nonce: + * + *0005 521c3b01 4308c041 + *[seq # ]

Re: [PATCH bpf-next 09/10] selftests/bpf: migrate bpf flow dissectors tests to test_progs

2024-11-14 Thread Alexis Lothoré
On 11/13/24 18:58, Stanislav Fomichev wrote: > On 11/13, Alexis Lothoré (eBPF Foundation) wrote: >> test_flow_dissector.sh loads flow_dissector program and subprograms, >> creates and configured relevant tunnels and interfaces, and ensure that >> the bpf dissection is actually performed correctly.