Re: [PATCH] kunit: qemu_configs: sparc: use Zilog console

2025-02-14 Thread David Gow
x27;', >qemu_arch='sparc', >kernel_path='arch/sparc/boot/zImage', >kernel_command_line='console=ttyS0 mem=256M', > > --- > base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b > change-id: 20250214-kunit-qemu-sparc-console-73ece282d867 > > Best regards, > -- > Thomas Weißschuh > smime.p7s Description: S/MIME Cryptographic Signature

Re: [PATCH v2] rcu/cpu_stall_cputime: fix the hardirq count for x86 architecture

2025-02-14 Thread Neeraj Upadhyay
On 1/9/2025 8:16 AM, Yongliang Gao wrote: > From: Yongliang Gao > > When counting the number of hardirqs in the x86 architecture, > it is essential to add arch_irq_stat_cpu to ensure accuracy. > > For example, a CPU loop within the rcu_read_lock function. > > Before: > [ 70.910184] rcu: INFO:

Re: [PATCH net-next v5 8/8] net: pktgen: use defines for the various dec/hex number parsing digits lengths

2025-02-14 Thread Jakub Kicinski
On Thu, 13 Feb 2025 12:00:25 +0100 Peter Seiderer wrote: > Use defines for the various dec/hex number parsing digits lengths > (hex32_arg/num_arg calls). I don't understand the value of this patch, TBH. Example: +#define HEX_2_DIGITS 2 - len = hex32_arg(&user_buffer[i], 2, &tmp_va

Re: [Patch net v3] vsock/virtio: fix variables initialization during resuming

2025-02-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Fri, 14 Feb 2025 09:22:00 +0800 you wrote: > When executing suspend to ram twice in a row, > the `rx_buf_nr` and `rx_buf_max_nr` increase to three times vq->num_free. > Then after virtqueue_get_buf and `rx_buf_nr` decre

Re: [PATCH v7 2/8] mm/huge_memory: add two new (not yet used) functions for folio_split()

2025-02-14 Thread Zi Yan
On 11 Feb 2025, at 10:50, Zi Yan wrote: > This is a preparation patch, both added functions are not used yet. > > The added __split_unmapped_folio() is able to split a folio with > its mapping removed in two manners: 1) uniform split (the existing way), > and 2) buddy allocator like split. > > The

Re: [PATCH 0/8] unwind, arm64: add sframe unwinder for kernel

2025-02-14 Thread Josh Poimboeuf
On Fri, Feb 14, 2025 at 02:04:17PM -0800, Song Liu wrote: > Hi Josh, > > On Fri, Feb 14, 2025 at 11:34 AM Josh Poimboeuf wrote: > > > > On Fri, Feb 14, 2025 at 09:51:41AM -0800, Song Liu wrote: > > > > Ignorant arm64 question: is the module's text further away from slab > > > > memory than vmlinu

Re: (subset) [PATCH v3 0/3] Add missing SDCC resets for SDM630/660

2025-02-14 Thread Bjorn Andersson
On Mon, 03 Feb 2025 09:34:23 +0300, Alexey Minnekhanov wrote: > These resets are part of GCC space and were missed during initial > porting of the platform. > > Changelog: > > v3: > * dropped fixes tags, picked r-b > > [...] Applied, thanks! [2/3] clk: qcom: gcc-sdm660: Add missing SDCC blo

Re: [PATCH 0/8] unwind, arm64: add sframe unwinder for kernel

2025-02-14 Thread Josh Poimboeuf
On Fri, Feb 14, 2025 at 02:04:17PM -0800, Song Liu wrote: > Hi Josh, > > On Fri, Feb 14, 2025 at 11:34 AM Josh Poimboeuf wrote: > > > > On Fri, Feb 14, 2025 at 09:51:41AM -0800, Song Liu wrote: > > > > Ignorant arm64 question: is the module's text further away from slab > > > > memory than vmlinu

Re: [PATCH v7 2/8] mm/huge_memory: add two new (not yet used) functions for folio_split()

2025-02-14 Thread Zi Yan
On 14 Feb 2025, at 17:06, David Hildenbrand wrote: > On 14.02.25 23:03, Zi Yan wrote: >> On 14 Feb 2025, at 16:59, David Hildenbrand wrote: >> >>> On 11.02.25 16:50, Zi Yan wrote: This is a preparation patch, both added functions are not used yet. The added __split_unmapped_folio()

Re: [PATCH v7 2/8] mm/huge_memory: add two new (not yet used) functions for folio_split()

2025-02-14 Thread David Hildenbrand
On 11.02.25 16:50, Zi Yan wrote: This is a preparation patch, both added functions are not used yet. The added __split_unmapped_folio() is able to split a folio with its mapping removed in two manners: 1) uniform split (the existing way), and 2) buddy allocator like split. The added __split_fol

Re: [PATCH v7 2/8] mm/huge_memory: add two new (not yet used) functions for folio_split()

2025-02-14 Thread David Hildenbrand
On 14.02.25 23:03, Zi Yan wrote: On 14 Feb 2025, at 16:59, David Hildenbrand wrote: On 11.02.25 16:50, Zi Yan wrote: This is a preparation patch, both added functions are not used yet. The added __split_unmapped_folio() is able to split a folio with its mapping removed in two manners: 1) unif

Re: [PATCH 0/8] unwind, arm64: add sframe unwinder for kernel

2025-02-14 Thread Song Liu
Hi Josh, On Fri, Feb 14, 2025 at 11:34 AM Josh Poimboeuf wrote: > > On Fri, Feb 14, 2025 at 09:51:41AM -0800, Song Liu wrote: > > > Ignorant arm64 question: is the module's text further away from slab > > > memory than vmlinux text, thus requiring a different instruction (or > > > GOT/TOC) to acc

Re: [PATCH v7 2/8] mm/huge_memory: add two new (not yet used) functions for folio_split()

2025-02-14 Thread Zi Yan
On 14 Feb 2025, at 16:59, David Hildenbrand wrote: > On 11.02.25 16:50, Zi Yan wrote: >> This is a preparation patch, both added functions are not used yet. >> >> The added __split_unmapped_folio() is able to split a folio with >> its mapping removed in two manners: 1) uniform split (the existing

[PATCH net-next v8 3/3] selftests: drv-net: Test queue xsk attribute

2025-02-14 Thread Joe Damato
Test that queues which are used for AF_XDP have the xsk nest attribute. The attribute is currently empty, but its existence means the AF_XDP is being used for the queue. Enable CONFIG_XDP_SOCKETS for selftests/drivers/net tests, as well. Signed-off-by: Joe Damato Suggested-by: Jakub Kicinski ---

[PATCH net-next v8 0/3] netdev-genl: Add an xsk attribute to queues

2025-02-14 Thread Joe Damato
Greetings: Welcome to v8. Minor change, see changelog below. Re-tested on my mlx5 system both with and without CONFIG_XDP_SOCKETS enabled and both with and without NETIF set. This is an attempt to followup on something Jakub asked me about [1], adding an xsk attribute to queues and more clearly d

Re: [PATCH v6 0/3] rust: kunit: Support KUnit tests with a user-space like syntax

2025-02-14 Thread Miguel Ojeda
On Fri, Feb 14, 2025 at 8:41 AM David Gow wrote: > > After much delay, v6 of the KUnit/Rust integration patchset is here. > This change incorporates most of Miguels suggestions from v5 (save for > some of the copyright headers I wasn't comfortable unilaterally > changing). This means the documenta

Re: [PATCH 0/8] unwind, arm64: add sframe unwinder for kernel

2025-02-14 Thread Josh Poimboeuf
On Fri, Feb 14, 2025 at 11:38:22AM -0800, Josh Poimboeuf wrote: > On Fri, Feb 14, 2025 at 06:58:01PM +, Puranjay Mohan wrote: > > and the linker script has this line: > > > > .sframe : AT(ADDR(.sframe) - 0) { __start_sframe_header = .; > > KEEP(*(.sframe)) __stop_sframe_header = .; } > > > >

Re: [PATCH 0/8] unwind, arm64: add sframe unwinder for kernel

2025-02-14 Thread Josh Poimboeuf
On Fri, Feb 14, 2025 at 06:58:01PM +, Puranjay Mohan wrote: > and the linker script has this line: > > .sframe : AT(ADDR(.sframe) - 0) { __start_sframe_header = .; KEEP(*(.sframe)) > __stop_sframe_header = .; } > > So, do can you suggest the best way to fix these warnings? Just add *(.init.

Re: [PATCH 0/8] unwind, arm64: add sframe unwinder for kernel

2025-02-14 Thread Josh Poimboeuf
On Fri, Feb 14, 2025 at 09:51:41AM -0800, Song Liu wrote: > > Ignorant arm64 question: is the module's text further away from slab > > memory than vmlinux text, thus requiring a different instruction (or > > GOT/TOC) to access memory further away in the address space? > > It appears to me the modu

Re: [PATCH 0/8] unwind, arm64: add sframe unwinder for kernel

2025-02-14 Thread Puranjay Mohan
Indu Bhagat writes: > On 2/14/25 9:39 AM, Indu Bhagat wrote: >> On 2/13/25 11:57 PM, Puranjay Mohan wrote: >>> Indu Bhagat writes: >>> On 2/12/25 11:25 PM, Song Liu wrote: > On Wed, Feb 12, 2025 at 6:45 PM Josh Poimboeuf > wrote: >> >> On Wed, Feb 12, 2025 at 06:36:04PM -0

Re: [PATCH v6 2/3] rust: macros: add macro to easily run KUnit tests

2025-02-14 Thread Tamir Duberstein
On Fri, Feb 14, 2025 at 1:38 PM Miguel Ojeda wrote: > > On Fri, Feb 14, 2025 at 3:41 PM Tamir Duberstein wrote: > > > > This is a really helpful comment. It got me wondering: can we have > > host-side unit tests for our proc macros? Code is better than > > comments, of course. > > That makes sens

Re: [PATCH 0/8] unwind, arm64: add sframe unwinder for kernel

2025-02-14 Thread Indu Bhagat
On 2/14/25 9:39 AM, Indu Bhagat wrote: On 2/13/25 11:57 PM, Puranjay Mohan wrote: Indu Bhagat writes: On 2/12/25 11:25 PM, Song Liu wrote: On Wed, Feb 12, 2025 at 6:45 PM Josh Poimboeuf wrote: On Wed, Feb 12, 2025 at 06:36:04PM -0800, Song Liu wrote: [   81.261748]  copy_process+0xfdc/0xf

Re: [PATCH v6 2/3] rust: macros: add macro to easily run KUnit tests

2025-02-14 Thread Miguel Ojeda
On Fri, Feb 14, 2025 at 3:41 PM Tamir Duberstein wrote: > > This is a really helpful comment. It got me wondering: can we have > host-side unit tests for our proc macros? Code is better than > comments, of course. That makes sense (in fact, e.g. Benno wanted them for pinned-init), but I will defe

Re: [PATCH RFC v2 00/10] SLUB percpu sheaves

2025-02-14 Thread Christoph Lameter (Ampere)
On Fri, 14 Feb 2025, Vlastimil Babka wrote: > - Cheaper fast paths. For allocations, instead of local double cmpxchg, > after Patch 5 it's preempt_disable() and no atomic operations. Same for > freeing, which is normally a local double cmpxchg only for a short > term allocations (so the same

Re: [PATCH 0/8] unwind, arm64: add sframe unwinder for kernel

2025-02-14 Thread Josh Poimboeuf
On Fri, Feb 14, 2025 at 08:56:45AM +, Puranjay Mohan wrote: > I did this test and found the same issue as you (gdb assembly broken), > but I can see this issue even without the inlining. I think GDB tried to > load the debuginfo and that is somehow broken therefore it fails to > disassemblt pro

Re: [PATCH 0/8] unwind, arm64: add sframe unwinder for kernel

2025-02-14 Thread Song Liu
Hi Puranjay, Thanks for running the tests. On Fri, Feb 14, 2025 at 12:56 AM Puranjay Mohan wrote: [...] > > > > I am really curious whether you have the same problem in your > > setup. > > Hi Song, > > I did this test and found the same issue as you (gdb assembly broken), > but I can see this is

Re: [PATCH] virtio: console: Prepare for making REMOTEPROC modular

2025-02-14 Thread Uwe Kleine-König
On Fri, Feb 14, 2025 at 05:55:41PM +0100, Amit Shah wrote: > On Fri, 2025-02-14 at 17:52 +0100, Uwe Kleine-König wrote: > > Hello Amit, > > > > On Fri, Feb 14, 2025 at 05:37:52PM +0100, Amit Shah wrote: > > > I'm thinking of the two combinations of interest: REMOTEPROC=m, > > > VIRTIO_CONSOLE can

Re: [PATCH 0/8] unwind, arm64: add sframe unwinder for kernel

2025-02-14 Thread Indu Bhagat
On 2/13/25 11:57 PM, Puranjay Mohan wrote: Indu Bhagat writes: On 2/12/25 11:25 PM, Song Liu wrote: On Wed, Feb 12, 2025 at 6:45 PM Josh Poimboeuf wrote: On Wed, Feb 12, 2025 at 06:36:04PM -0800, Song Liu wrote: [ 81.261748] copy_process+0xfdc/0xfd58 [livepatch_special_static] Does t

Re: [PATCH] virtio: console: Prepare for making REMOTEPROC modular

2025-02-14 Thread Amit Shah
On Fri, 2025-02-14 at 17:52 +0100, Uwe Kleine-König wrote: > Hello Amit, > > On Fri, Feb 14, 2025 at 05:37:52PM +0100, Amit Shah wrote: > > I'm thinking of the two combinations of interest: REMOTEPROC=m, > > VIRTIO_CONSOLE can be y or m.  Say virtcons_probe() happens when > > the > > remoteproc mo

Re: [PATCH] virtio: console: Prepare for making REMOTEPROC modular

2025-02-14 Thread Uwe Kleine-König
Hello Amit, On Fri, Feb 14, 2025 at 05:37:52PM +0100, Amit Shah wrote: > I'm thinking of the two combinations of interest: REMOTEPROC=m, > VIRTIO_CONSOLE can be y or m. Say virtcons_probe() happens when the > remoteproc module isn't yet loaded. Even after later loading > remoteproc, virtio conso

Re: [PATCH] virtio: console: Prepare for making REMOTEPROC modular

2025-02-14 Thread Amit Shah
On Fri, 2025-02-14 at 17:13 +0100, Uwe Kleine-König wrote: > Hello Amit, > > On Fri, Feb 14, 2025 at 02:32:16PM +0100, Amit Shah wrote: > > On Fri, 2025-02-14 at 12:14 +0100, Uwe Kleine-König wrote: > > > On Fri, Feb 14, 2025 at 11:58:44AM +0100, Amit Shah wrote: > > > > On Thu, 2025-02-13 at 12:5

[PATCH RFC v2 10/10] maple_tree: use percpu sheaves for maple_node_cache

2025-02-14 Thread Vlastimil Babka
Setup the maple_node_cache with percpu sheaves of size 32 to hopefully improve its performance. Change the single node rcu freeing in ma_free_rcu() to use kfree_rcu() instead of the custom callback, which allows the rcu_free sheaf batching to be used. Note there are other users of mt_free_rcu() whe

[PATCH RFC v2 08/10] tools: Add testing support for changes to rcu and slab for sheaves

2025-02-14 Thread Vlastimil Babka
From: "Liam R. Howlett" Make testing work for the slab and rcu changes that have come in with the sheaves work. This only works with one kmem_cache, and only the first one used. Subsequent setting of keme_cache will not update the active kmem_cache and will be silently dropped because there are

[PATCH RFC v2 01/10] slab: add opt-in caching layer of percpu sheaves

2025-02-14 Thread Vlastimil Babka
Specifying a non-zero value for a new struct kmem_cache_args field sheaf_capacity will setup a caching layer of percpu arrays called sheaves of given capacity for the created cache. Allocations from the cache will allocate via the percpu sheaves (main or spare) as long as they have no NUMA node pr

[PATCH RFC v2 09/10] tools: Add sheafs support to testing infrastructure

2025-02-14 Thread Vlastimil Babka
From: "Liam R. Howlett" Allocate a sheaf and fill it to the count amount. Does not fill to the sheaf limit to detect incorrect allocation requests. Signed-off-by: Liam R. Howlett --- tools/include/linux/slab.h | 24 + tools/testing/shared/linux.c | 84 +++

[PATCH RFC v2 04/10] locking/local_lock: add localtry_trylock()

2025-02-14 Thread Vlastimil Babka
Add a localtry_trylock() variant without _irqsave that will be used in slab sheaves implementation. Thanks to only disabling preemption and not irqs, it has a lower overhead. It's not necessary to disable irqs to avoid a deadlock if the irq context uses trylock and can handle failures. Also make t

[PATCH RFC v2 07/10] slab: determine barn status racily outside of lock

2025-02-14 Thread Vlastimil Babka
The possibility of many barn operations is determined by the current number of full or empty sheaves. Taking the barn->lock just to find out that e.g. there are no empty sheaves results in unnecessary overhead and lock contention. Thus perform these checks outside of the lock with a data_race() ann

[PATCH RFC v2 03/10] locking/local_lock: Introduce localtry_lock_t

2025-02-14 Thread Vlastimil Babka
From: Sebastian Andrzej Siewior In !PREEMPT_RT local_lock_irqsave() disables interrupts to protect critical section, but it doesn't prevent NMI, so the fully reentrant code cannot use local_lock_irqsave() for exclusive access. Introduce localtry_lock_t and localtry_lock_irqsave() that disables i

[PATCH RFC v2 06/10] slab: sheaf prefilling for guaranteed allocations

2025-02-14 Thread Vlastimil Babka
Add functions for efficient guaranteed allocations e.g. in a critical section that cannot sleep, when the exact number of allocations is not known beforehand, but an upper limit can be calculated. kmem_cache_prefill_sheaf() returns a sheaf containing at least given number of objects. kmem_cache_a

[PATCH RFC v2 05/10] slab: switch percpu sheaves locking to localtry_lock

2025-02-14 Thread Vlastimil Babka
Instead of local_lock_irqsave(), use localtry_trylock() when potential callers include irq context, and localtry_lock() otherwise (such as when we already know the gfp flags allow blocking). This should reduce the locking (due to irq disabling/enabling) overhead. Failing to use percpu sheaves in a

[PATCH RFC v2 02/10] slab: add sheaf support for batching kfree_rcu() operations

2025-02-14 Thread Vlastimil Babka
Extend the sheaf infrastructure for more efficient kfree_rcu() handling. For caches with sheaves, on each cpu maintain a rcu_free sheaf in addition to main and spare sheaves. kfree_rcu() operations will try to put objects on this sheaf. Once full, the sheaf is detached and submitted to call_rcu()

[PATCH RFC v2 00/10] SLUB percpu sheaves

2025-02-14 Thread Vlastimil Babka
Hi, This is the v2 RFC to add an opt-in percpu array-based caching layer to SLUB. The name "sheaf" was invented by Matthew so we don't call it magazine like the original Bonwick paper. The per-NUMA-node cache of sheaves is thus called "barn". This may seem similar to the arrays in SLAB, but the m

[PATCH v8 4/4] scanf: break kunit into test cases

2025-02-14 Thread Tamir Duberstein
Use `suite_init` and move some tests into `scanf_test_cases`. This gives us nicer output in the event of a failure. Reviewed-by: David Gow Signed-off-by: Tamir Duberstein --- lib/tests/scanf_kunit.c | 95 ++--- 1 file changed, 51 insertions(+), 44 del

[PATCH v8 3/4] scanf: convert self-test to KUnit

2025-02-14 Thread Tamir Duberstein
Convert the scanf() self-test to a KUnit test. In the interest of keeping the patch reasonably-sized this doesn't refactor the tests into proper parameterized tests - it's all one big test case. Reviewed-by: David Gow Signed-off-by: Tamir Duberstein --- MAINTAINERS

[PATCH v8 1/4] scanf: implicate test line in failure messages

2025-02-14 Thread Tamir Duberstein
This improves the failure output by pointing to the failing line at the top level of the test. Signed-off-by: Tamir Duberstein --- lib/test_scanf.c | 66 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/lib/test_scanf.c b/li

[PATCH v8 2/4] scanf: remove redundant debug logs

2025-02-14 Thread Tamir Duberstein
Remove `pr_debug` calls which emit information already contained in `pr_warn` calls that occur on test failure. This reduces unhelpful test verbosity. Note that a `pr_debug` removed from `_check_numbers_template` appears to have been the only guard against silent false positives, but in fact this

[PATCH v8 0/4] scanf: convert self-test to KUnit

2025-02-14 Thread Tamir Duberstein
This is one of just 3 remaining "Test Module" kselftests (the others being bitmap and printf), the rest having been converted to KUnit. In addition to the enclosed patch, please consider this an RFC on the removal of the "Test Module" kselftest machinery. I tested this using: $ tools/testing/kuni

Re: [PATCH] virtio: console: Prepare for making REMOTEPROC modular

2025-02-14 Thread Uwe Kleine-König
Hello Amit, On Fri, Feb 14, 2025 at 02:32:16PM +0100, Amit Shah wrote: > On Fri, 2025-02-14 at 12:14 +0100, Uwe Kleine-König wrote: > > On Fri, Feb 14, 2025 at 11:58:44AM +0100, Amit Shah wrote: > > > On Thu, 2025-02-13 at 12:55 +0100, Uwe Kleine-König wrote: > > > > virtio_console.c can make use

Re: [PATCH v7 0/3] scanf: convert self-test to KUnit

2025-02-14 Thread Tamir Duberstein
On Fri, Feb 14, 2025 at 8:33 AM Petr Mladek wrote: > > On Wed 2025-02-12 11:54:52, Tamir Duberstein wrote: > > On Tue, Feb 11, 2025 at 12:26 PM Tamir Duberstein wrote: > > > > > > > Is it me who cut something or the above missing this information (total > > > > tests)? > > > > If the latter, how

Re: [PATCH][next] KVM: selftests: Fix spelling mistake "Unabled" -> "Unable"

2025-02-14 Thread Sean Christopherson
On Fri, Feb 14, 2025, Colin Ian King wrote: > There is a spelling mistake in a TEST_FAIL message. Fix it. Gah, as usual, your spell checker is superior to mine. Squashed the fix with offending commit. Thanks!

Re: [PATCH v6 2/3] rust: macros: add macro to easily run KUnit tests

2025-02-14 Thread Tamir Duberstein
On Fri, Feb 14, 2025 at 2:41 AM David Gow wrote: > > From: José Expósito > > Add a new procedural macro (`#[kunit_tests(kunit_test_suit_name)]`) to > run KUnit tests using a user-space like syntax. > > The macro, that should be used on modules, transforms every `#[test]` > in a `kunit_case!` and

Re: [PATCH v6 3/3] rust: kunit: allow to know if we are in a test

2025-02-14 Thread Tamir Duberstein
On Fri, Feb 14, 2025 at 2:42 AM David Gow wrote: > > From: José Expósito > > In some cases, we need to call test-only code from outside the test > case, for example, to mock a function or a module. > > In order to check whether we are in a test or not, we need to test if > `CONFIG_KUNIT` is set.

Re: [PATCH v6 1/3] rust: kunit: add KUnit case and suite macros

2025-02-14 Thread Tamir Duberstein
Very excited to see this progress. On Fri, Feb 14, 2025 at 2:41 AM David Gow wrote: > > From: José Expósito > > Add a couple of Rust const functions and macros to allow to develop > KUnit tests without relying on generated C code: > > - The `kunit_unsafe_test_suite!` Rust macro is similar to th

Re: [PATCH net-next v19 00/26] Introducing OpenVPN Data Channel Offload

2025-02-14 Thread Antonio Quartulli
On 14/02/2025 14:54, Antonio Quartulli wrote: For example in wireguard/device.c the socket is released in pernet_operations.pre_exit(). But pre_exit() is invoked in cleanup_net(), which is invoked ONLY if the net refcount has reached 0...but how can it be zero before the sockets have been rel

Re: [PATCH net-next v19 00/26] Introducing OpenVPN Data Channel Offload

2025-02-14 Thread Antonio Quartulli
On 13/02/2025 20:40, Antonio Quartulli wrote: On 13/02/2025 16:46, Sabrina Dubroca wrote: 2025-02-13, 12:46:34 +0100, Antonio Quartulli wrote: On 13/02/2025 00:34, Sabrina Dubroca wrote: Hello, 2025-02-11, 01:39:53 +0100, Antonio Quartulli wrote: All minor and major reported problems have be

Re: [Patch net v3] vsock/virtio: fix variables initialization during resuming

2025-02-14 Thread Stefano Garzarella
On Fri, Feb 14, 2025 at 09:22:00AM +0800, Junnan Wu wrote: When executing suspend to ram twice in a row, the `rx_buf_nr` and `rx_buf_max_nr` increase to three times vq->num_free. Then after virtqueue_get_buf and `rx_buf_nr` decreased in function virtio_transport_rx_work, the condition to fill rx

Re: [PATCH v7 0/3] scanf: convert self-test to KUnit

2025-02-14 Thread Petr Mladek
On Wed 2025-02-12 11:54:52, Tamir Duberstein wrote: > On Tue, Feb 11, 2025 at 12:26 PM Tamir Duberstein wrote: > > > > > Is it me who cut something or the above missing this information (total > > > tests)? > > > If the latter, how are we supposed to answer to the question if the > > > failed te

Re: [PATCH] virtio: console: Prepare for making REMOTEPROC modular

2025-02-14 Thread Amit Shah
On Fri, 2025-02-14 at 12:14 +0100, Uwe Kleine-König wrote: > Hello Amit, > > On Fri, Feb 14, 2025 at 11:58:44AM +0100, Amit Shah wrote: > > On Thu, 2025-02-13 at 12:55 +0100, Uwe Kleine-König wrote: > > > virtio_console.c can make use of REMOTEPROC. Therefore it has > > > several > > > tests evalu

[PATCH] kunit: qemu_configs: sparc: use Zilog console

2025-02-14 Thread Thomas Weißschuh
#x27;, qemu_arch='sparc', kernel_path='arch/sparc/boot/zImage', kernel_command_line='console=ttyS0 mem=256M', --- base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b change-id: 20250214-kunit-qemu-sparc-console-73ece282d867 Best regards, -- Thomas Weißschuh

Re: [PATCH net 4/4] selftest/bpf: Add vsock test for sockmap rejecting unconnected

2025-02-14 Thread Michal Luczaj
On 2/13/25 12:58, Michal Luczaj wrote: > ... > This does not test datagram vsocks. Even though it hardly matters. VMCI is > the only transport that features VSOCK_TRANSPORT_F_DGRAM, but it has an > unimplemented vsock_transport::readskb() callback, making it unsupported by

Re: [PATCH net 1/4] sockmap, vsock: For connectible sockets allow only connected

2025-02-14 Thread Michal Luczaj
> ... > Another design detail is that listening vsocks are not supposed to have any > transport assigned at all. Which implies they are not supported by the > sockmap. But this is complicated by the fact that a socket, before > switching to TCP_LISTEN, may have had some transport assigned during a

[PATCH][next] KVM: selftests: Fix spelling mistake "Unabled" -> "Unable"

2025-02-14 Thread Colin Ian King
There is a spelling mistake in a TEST_FAIL message. Fix it. Signed-off-by: Colin Ian King --- tools/testing/selftests/kvm/lib/kvm_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c in

Re: [PATCH v2] ww_mutex: convert self-test to KUnit

2025-02-14 Thread Tamir Duberstein
On Fri, Feb 14, 2025 at 4:48 AM Peter Zijlstra wrote: > > On Thu, Feb 13, 2025 at 10:42:24AM -0500, Tamir Duberstein wrote: > > On Thu, Feb 13, 2025 at 6:59 AM Peter Zijlstra wrote: > > > > > > On Thu, Feb 13, 2025 at 06:40:20AM -0500, Tamir Duberstein wrote: > > > > Convert this unit test to a K

Re: [Patch net v3] vsock/virtio: fix variables initialization during resuming

2025-02-14 Thread Michael S. Tsirkin
On Fri, Feb 14, 2025 at 09:22:00AM +0800, Junnan Wu wrote: > When executing suspend to ram twice in a row, > the `rx_buf_nr` and `rx_buf_max_nr` increase to three times vq->num_free. > Then after virtqueue_get_buf and `rx_buf_nr` decreased > in function virtio_transport_rx_work, > the condition to

Re: [PATCH] virtio: Remove virtio devices on device_shutdown()

2025-02-14 Thread Michael S. Tsirkin
On Fri, Feb 14, 2025 at 08:56:56AM +0100, Eric Auger wrote: > Hi, > > On 2/14/25 8:21 AM, Ning, Hongyu wrote: > > > > > > On 2025/2/6 16:59, Eric Auger wrote: > >> Hi, > >> > >> On 2/4/25 12:46 PM, Eric Auger wrote: > >>> Hi, > >>> > >>> On 2/3/25 3:48 PM, Michael S. Tsirkin wrote: > On Fri

Re: [PATCH] virtio_snd.h: clarify that `controls` depends on VIRTIO_SND_F_CTLS

2025-02-14 Thread Takashi Iwai
On Thu, 13 Feb 2025 17:18:25 +0100, Stefano Garzarella wrote: > > As defined in the specification, the `controls` field in the configuration > space is only valid/present if VIRTIO_SND_F_CTLS is negotiated. > > From https://docs.oasis-open.org/virtio/virtio/v1.3/virtio-v1.3.html: > > 5.14.4

Re: [PATCH 3/3] rcu/exp: Remove needless CPU up quiescent state report

2025-02-14 Thread Frederic Weisbecker
Le Fri, Feb 14, 2025 at 01:01:56AM -0800, Paul E. McKenney a écrit : > On Fri, Feb 14, 2025 at 12:25:59AM +0100, Frederic Weisbecker wrote: > > A CPU coming online checks for an ongoing grace period and reports > > a quiescent state accordingly if needed. This special treatment that > > shortcuts t

Re: [PATCH] virtio: console: Prepare for making REMOTEPROC modular

2025-02-14 Thread Uwe Kleine-König
Hello Amit, On Fri, Feb 14, 2025 at 11:58:44AM +0100, Amit Shah wrote: > On Thu, 2025-02-13 at 12:55 +0100, Uwe Kleine-König wrote: > > virtio_console.c can make use of REMOTEPROC. Therefore it has several > > tests evaluating > > > > IS_ENABLED(CONFIG_REMOTEPROC) > > > > . This currently on

Re: [PATCH] virtio: console: Prepare for making REMOTEPROC modular

2025-02-14 Thread Amit Shah
On Thu, 2025-02-13 at 12:55 +0100, Uwe Kleine-König wrote: > virtio_console.c can make use of REMOTEPROC. Therefore it has several > tests evaluating > > IS_ENABLED(CONFIG_REMOTEPROC) > > . This currently only does the right thing because CONFIG_REMOTEPROC > cannot be modular. Otherwise the

Re: [PATCH v2] ww_mutex: convert self-test to KUnit

2025-02-14 Thread Peter Zijlstra
On Thu, Feb 13, 2025 at 10:42:24AM -0500, Tamir Duberstein wrote: > On Thu, Feb 13, 2025 at 6:59 AM Peter Zijlstra wrote: > > > > On Thu, Feb 13, 2025 at 06:40:20AM -0500, Tamir Duberstein wrote: > > > Convert this unit test to a KUnit test. This allows the test to benefit > > > from the KUnit too

Re: [PATCH] module: don't annotate ROX memory as kmemleak_not_leak()

2025-02-14 Thread Peter Zijlstra
On Fri, Feb 14, 2025 at 10:45:31AM +0200, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > The ROX memory allocations are part of a larger vmalloc allocation and > annotating them with kmemleak_not_leak() confuses kmemleak. > > Skip kmemleak_not_leak() annotations for the ROX areas.

Re: [Patch net v3] vsock/virtio: fix variables initialization during resuming

2025-02-14 Thread Luigi Leonardi
On Fri, Feb 14, 2025 at 09:22:00AM +0800, Junnan Wu wrote: When executing suspend to ram twice in a row, the `rx_buf_nr` and `rx_buf_max_nr` increase to three times vq->num_free. Then after virtqueue_get_buf and `rx_buf_nr` decreased in function virtio_transport_rx_work, the condition to fill rx

Re: [PATCH 1/3] rcu/exp: Protect against early QS report

2025-02-14 Thread Paul E. McKenney
On Fri, Feb 14, 2025 at 12:25:57AM +0100, Frederic Weisbecker wrote: > When a grace period is started, the ->expmask of each node is set up > from sync_exp_reset_tree(). Then later on each leaf node also initialize > its ->exp_tasks pointer. > > This means that the initialization of the quiescent

Re: [PATCH 3/3] rcu/exp: Remove needless CPU up quiescent state report

2025-02-14 Thread Paul E. McKenney
On Fri, Feb 14, 2025 at 12:25:59AM +0100, Frederic Weisbecker wrote: > A CPU coming online checks for an ongoing grace period and reports > a quiescent state accordingly if needed. This special treatment that > shortcuts the expedited IPI finds its origin as an optimization purpose > on the followi

Re: [PATCH 0/8] unwind, arm64: add sframe unwinder for kernel

2025-02-14 Thread Puranjay Mohan
Song Liu writes: > On Thu, Feb 13, 2025 at 2:22 PM Puranjay Mohan wrote: >> >> Song Liu writes: >> >> > On Thu, Feb 13, 2025 at 12:38 AM Puranjay Mohan >> > wrote: >> > [...] >> >> >> >> P.S. - The livepatch doesn't have copy_process() but only copy_signal(), >> >> yours had copy_process() so

[PATCH] module: don't annotate ROX memory as kmemleak_not_leak()

2025-02-14 Thread Mike Rapoport
From: "Mike Rapoport (Microsoft)" The ROX memory allocations are part of a larger vmalloc allocation and annotating them with kmemleak_not_leak() confuses kmemleak. Skip kmemleak_not_leak() annotations for the ROX areas. Fixes: c287c0723329 ("module: switch to execmem API for remapping as RW an

Re: [PATCH] virtio_snd.h: clarify that `controls` depends on VIRTIO_SND_F_CTLS

2025-02-14 Thread Eugenio Perez Martin
On Thu, Feb 13, 2025 at 5:18 PM Stefano Garzarella wrote: > > As defined in the specification, the `controls` field in the configuration > space is only valid/present if VIRTIO_SND_F_CTLS is negotiated. > > From https://docs.oasis-open.org/virtio/virtio/v1.3/virtio-v1.3.html: > > 5.14.4 Device

Re: [PATCH 0/8] unwind, arm64: add sframe unwinder for kernel

2025-02-14 Thread Josh Poimboeuf
On Thu, Feb 13, 2025 at 11:40:43AM -0800, Song Liu wrote: > Yeah, objdump does show the same disassembly. However, if > I open the file with gdb, and do "disassemble copy_process", > the one in livepatch-special-static.o looks very weird. The symbol table looks ok. I'm not sure why gdb is getting