On Fri, 11 Apr 2025 at 20:36, Richard Fitzgerald
wrote:
>
> This series fixes the KConfig for cs_dsp and cs-amp-lib tests so that
> CONFIG_KUNIT_ALL_TESTS doesn't cause them to add modules to the build.
>
> Patch 1 adds the ASoC CS35L56 driver to KUnit all_tests.config so that
> cs_dsp and
On Mon, 7 Apr 2025 at 16:17, Thomas Weißschuh
wrote:
>
> Add a basic config to run kunit tests on riscv32.
>
> Signed-off-by: Thomas Weißschuh
> ---
Thanks very much: this is working well here (even if qemu for riscv32
is _slow_ on my machine)!
Reviewed-by: David Gow
Cheers,
-- David
> too
On Fri, 11 Apr 2025 at 17:59, Richard Fitzgerald
wrote:
>
> Enable CONFIG_INIT_STACK_ALL_PATTERN in all_tests.config. This helps
> to detect use of uninitialized local variables.
>
> This option found an uninitialized data bug in the cs_dsp test.
>
> Signed-off-by: Richard Fitzgerald
> ---
Hmm..
Add the first version of the virtio-media driver.
This driver acts roughly as a V4L2 relay between user-space and the
virtio virtual device on the host, so it is relatively simple, yet
unconventional. It doesn't use VB2 or other frameworks typically used in
a V4L2 driver, and most of its complexit
On Fri, 11 Apr 2025 17:08:33 -0400 Waiman Long wrote:
> > - * A/B/F memory.current = 0
> > + * A/B/C memory.current ~= 29M, memory.events:low > 0
> > + * A/B/D memory.current ~= 21M, memory.events:low > 0
> > + * A/B/E memory.current ~= 0, memory.events:low not specified (==0
> > w/out me
On Fri, 11 Apr 2025 15:50:49 +0200 Sabrina Dubroca wrote:
> > My understanding is that this is the standard approach to:
> > 1) hook in the middle of registration/deregistration;
> > 2) handle events generated by other components/routines.
> >
> > I see in /drivers/net/ almost every driver registe
On 4/11/25 1:22 PM, Michal Koutný wrote:
On Mon, Apr 07, 2025 at 12:23:16PM -0400, Waiman Long
wrote:
Child Actual usageExpected usage%err
- --
1 16990208 22020096 -12.9%
1 17252352 22020096
On 4/11/25 1:11 PM, Michal Koutný wrote:
Hello.
On Mon, Apr 07, 2025 at 12:23:15PM -0400, Waiman Long
wrote:
--- a/mm/memcontrol-v1.h
+++ b/mm/memcontrol-v1.h
@@ -22,8 +22,6 @@
iter != NULL; \
iter = mem_cgroup_iter(NULL, iter, NULL))
On 4/7/25 11:25 AM, Michal Koutný wrote:
Hi Waiman.
On Sun, Apr 06, 2025 at 09:41:58PM -0400, Waiman Long
wrote:
...
diff --git a/tools/testing/selftests/cgroup/test_memcontrol.c
b/tools/testing/selftests/cgroup/test_memcontrol.c
index 16f5d74ae762..bab826b6b7b0 100644
--- a/tools/testing/
From: Xu Kuohai
Currently ARM64 bpf trampoline supports up to 8 function arguments.
According to the statistics from commit
473e3150e30a ("bpf, x86: allow function arguments up to 12 for TRACING"),
there are about 200 functions accept 9 to 12 arguments, so adding support
for up to 12 function arg
When dealing with large types (>8 bytes), ARM64 trampolines need to take
extra care about the arguments alignment to respect the calling
convention set by AAPCS64.
Add two tests ensuring that the BPF trampoline arranges arguments with
the relevant layout. The two new tests involve almost the same
In order to properly JIT the trampolines needed to attach BPF programs
to functions, some architectures like ARM64 need to know about the
alignment needed for the function arguments. Such alignment can
generally be deduced from the argument size, but that's not completely
true for composite types.
The fentry_many_args, fexit_many_args and struct_many_args tests were
disabled on ARM64 due to the lack of many args support.
With the previous commits bringing in this missing support, drop the
last denied tests.
Signed-off-by: Alexis Lothoré (eBPF Foundation)
---
tools/testing/selftests/bpf/D
Hello,
this series is a revival of Xu Kuhoai's work to enable larger arguments
count for BPF programs on ARM64 ([1]). His initial series received some
positive feedback, but lacked some specific case handling around
arguments alignment (see AAPCS64 C.14 rule in section 6.8.2, [2]). There
as been a
On 4/11/25 1:37 PM, Jagadeesh Kona wrote:
>
>
> On 4/11/2025 2:42 PM, Konrad Dybcio wrote:
>> On 4/11/25 9:15 AM, Jagadeesh Kona wrote:
>>>
>>>
>>> On 4/1/2025 10:03 PM, Konrad Dybcio wrote:
On 3/24/25 9:41 AM, Luca Weiss wrote:
> Add a node for the videocc found on the SM6350 SoC.
>
On Fri, Apr 11, 2025 at 05:36:32AM -, Joel Fernandes wrote:
> Hello, Paul,
>
> On Fri, 11 Apr 2025 05:33:16 GMT, "Paul E. McKenney" wrote:
> > On Thu, Apr 10, 2025 at 11:54:13AM -0700, Paul E. McKenney wrote:
> > > On Thu, Apr 10, 2025 at 11:29:03AM -0700, Paul E. McKenney wrote:
> > > > On Th
On Mon, Apr 07, 2025 at 03:50:54PM -0400, Frank Li wrote:
> Document the use of (msi|iommu)-map for PCI Endpoint (EP) controllers,
> which can use MSI as a doorbell mechanism. Each EP controller can support
> up to 8 physical functions and 65,536 virtual functions.
>
> Define how to construct devi
This patch suggests the replacement of strncpy with strscpy
as per Documentation/process/deprecated.
The strncpy() fails to guarantee NULL termination,
The function adds zero pads which isn't really convenient for short strings
as it may cause performance issues.
strscpy() is a preferred replaceme
On Mon, Apr 07, 2025 at 12:23:16PM -0400, Waiman Long
wrote:
> Child Actual usageExpected usage%err
> - --
> 1 16990208 22020096 -12.9%
> 1 17252352 22020096 -12.1%
> 0 37699584
Hello.
On Mon, Apr 07, 2025 at 12:23:15PM -0400, Waiman Long
wrote:
> --- a/mm/memcontrol-v1.h
> +++ b/mm/memcontrol-v1.h
> @@ -22,8 +22,6 @@
>iter != NULL; \
>iter = mem_cgroup_iter(NULL, iter, NULL))
>
> -unsigned long mem_cgroup_usage(str
Hi Matt,
On Fri, 2025-04-11 at 13:04 +0200, Matthieu Baerts (NGI0) wrote:
> From: Geliang Tang
Please update my email as "Geliang Tang " here
and in patch 7, otherwise, CI will complain that the email address
after "From: " is different from that after "Signed-off-by: ".
Thanks,
-Geliang
>
>
On 11-04-2025 20:39, Nam Cao wrote:
/* Step 4: Make sure all stack pointer values are non-zero */
+ line = NULL;
such case it should initialize at declaration time.
better to move up char *test_dir, *line = NULL;
for (i = 0; -1 != getline(&line, &line_length, file); +
The buffer pointer "line" is not initialized. This pointer is passed to
getline().
It can still work if the stack is zero-initialized, because getline() can
work with a NULL pointer as buffer.
But this is obviously broken. This bug shows up while running the test on a
riscv64 machine.
Fix it by
The test waits for coredump to finish by busy-waiting for the stack_values
file to be created. The maximum wait time is 10 seconds.
This doesn't work for slow machine (qemu-system-riscv64), because coredump
takes longer.
Fix it by waiting for the crashing child process to finish first.
Fixes: 15
The test's runtime (nearly 20s) is dangerously close to the limit (30s) on
qemu-system-riscv64:
$ time ./stackdump_test > /dev/null
real0m19.210s
user0m0.077s
sys 0m0.359s
There could be machines slower than qemu-system-riscv64. Therefore raise
the test timeout to 2 minutes to be safe
Hi,
While trying the coredump test on qemu-system-riscv64, I observed test
failures for various reasons.
This series makes the test works on qemu-system-riscv64.
Best regards,
Nam
v1->v2 https://lore.kernel.org/lkml/cover.1743438749.git.nam...@linutronix.de/
- use getline() more precisely [Jo
On Fri, Apr 11, 2025 at 6:39 AM Richard Fitzgerald
wrote:
>
> On 08/04/2025 10:25 am, Richard Fitzgerald wrote:
> > On 19/03/2025 11:05 pm, Nico Pache wrote:
> >> FW_CS_DSP gets enabled if KUNIT is enabled. The test should rather
> >> depend on if the feature is enabled. Fix this by moving FW_CS_D
On 08/04/2025 10:25 am, Richard Fitzgerald wrote:
On 19/03/2025 11:05 pm, Nico Pache wrote:
FW_CS_DSP gets enabled if KUNIT is enabled. The test should rather
depend on if the feature is enabled. Fix this by moving FW_CS_DSP to the
depends on clause, and set CONFIG_FW_CS_DSP=y in the kunit tooli
Hi Geliang,
On 11/04/2025 15:57, Geliang Tang wrote:
> Hi Matt,
>
> On Fri, 2025-04-11 at 13:04 +0200, Matthieu Baerts (NGI0) wrote:
>> From: Geliang Tang
>
> Please update my email as "Geliang Tang " here
> and in patch 7, otherwise, CI will complain that the email address
> after "From: " is
> didn't lift off and DAX ended up being kind of niche, I think the effort
> to maintain DAX in ext2 is not justified and we should just drop it (and
> direct existing users to use ext4 driver instead for the cases where they
> need it). I'll have a look into it.
+1
On Mon, Apr 07, 2025 at 08:41:43PM +0200, Michal Luczaj wrote:
Change the behaviour of a lingering close(): instead of waiting for all
data to be consumed, block until data is considered sent, i.e. until worker
picks the packets and decrements virtio_vsock_sock::bytes_unsent down to 0.
Do linger
2025-04-11, 10:04:10 +0200, Antonio Quartulli wrote:
> Hi Jakub,
>
> thanks for taking the time to go through my patchset :)
>
> On 11/04/2025 04:54, Jakub Kicinski wrote:
> > On Mon, 07 Apr 2025 21:46:09 +0200 Antonio Quartulli wrote:
> > > +static int ovpn_netdev_notifier_call(struct notifier_b
On 11.04.25 14:42, Heiko Carstens wrote:
On Fri, Apr 11, 2025 at 01:11:55PM +0200, Christian Borntraeger wrote:
Am 10.04.25 um 20:44 schrieb David Hildenbrand:
[...]
---
So, given that
(a) people are actively running into this
(b) we'll have to backport this quite a lot
(c) the spec issue is
Hello wpan maintainers/developers,
This is a 31-day syzbot report for the wpan subsystem.
All related reports/information can be found at:
https://syzkaller.appspot.com/upstream/s/wpan
During the period, 0 new issues were detected and 0 were fixed.
In total, 5 issues are still open and 26 have al
Am 11.04.25 um 14:42 schrieb Heiko Carstens:
On Fri, Apr 11, 2025 at 01:11:55PM +0200, Christian Borntraeger wrote:
Am 10.04.25 um 20:44 schrieb David Hildenbrand:
[...]
---
So, given that
(a) people are actively running into this
(b) we'll have to backport this quite a lot
(c) the spec is
On Fri, Apr 11, 2025 at 01:11:55PM +0200, Christian Borntraeger wrote:
> Am 10.04.25 um 20:44 schrieb David Hildenbrand:
> [...]
> > > ---
> >
> > So, given that
> >
> > (a) people are actively running into this
> > (b) we'll have to backport this quite a lot
> > (c) the spec issue is not a s390x
On Wed, Apr 09, 2025 at 10:26:56AM -0700, Kees Cook wrote:
> On Fri, Mar 21, 2025 at 01:47:24PM +0100, Joel Granados wrote:
> > If the test added in commit b5ffbd139688 ("sysctl: move the extra1/2
> > boundary check of u8 to sysctl_check_table_array") is run as a module, a
> > lingering reference t
From: Nico Pache
FW_CS_DSP gets enabled if KUNIT is enabled. The test should rather
depend on if the feature is enabled. Fix this by moving FW_CS_DSP to the
depends on clause.
Fixes: dd0b6b1f29b9 ("firmware: cs_dsp: Add KUnit testing of bin file download")
Signed-off-by: Nico Pache
Signed-off-b
Add CONFIG_I2C and CONFIG_SND_SOC_CS35L56_I2C to all_tests.config
so that Cirrus Logic modules with KUnit tests will be built.
The CS35L56 driver doesn't currently have any KUnit tests itself,
but it enables two other libraries that have KUnit tests:
cs_dsp and cs-amp-lib.
Signed-off-by: Richard
Depend on SND_SOC_CS_AMP_LIB instead of selecting it.
KUNIT_ALL_TESTS should only build tests for components that are
already being built, it should not cause other stuff to be added
to the build.
Fixes: 177862317a98 ("ASoC: cs-amp-lib: Add KUnit test for calibration helpers")
Signed-off-by: Rich
This series fixes the KConfig for cs_dsp and cs-amp-lib tests so that
CONFIG_KUNIT_ALL_TESTS doesn't cause them to add modules to the build.
Patch 1 adds the ASoC CS35L56 driver to KUnit all_tests.config so that
cs_dsp and cs-amp-lib will be included in the test build.
Patch 2 and 3 fixup
changes and enable some parts of the API by accient.
>
> Just a suggestion. This will be a nice improvement to the test coverage
> even without the negative tests.
> ...
So this took me for a bit of a journey (sorry for delay), but after
tweaking some things here and there, here'
On 4/11/2025 2:42 PM, Konrad Dybcio wrote:
> On 4/11/25 9:15 AM, Jagadeesh Kona wrote:
>>
>>
>> On 4/1/2025 10:03 PM, Konrad Dybcio wrote:
>>> On 3/24/25 9:41 AM, Luca Weiss wrote:
Add a node for the videocc found on the SM6350 SoC.
Signed-off-by: Luca Weiss
---
arch/a
Am 10.04.25 um 20:44 schrieb David Hildenbrand:
[...]
---
So, given that
(a) people are actively running into this
(b) we'll have to backport this quite a lot
(c) the spec issue is not a s390x-only issue
(d) it's still unclear how to best deal with the spec issue
I suggest getting this fix he
subflow_hmac_valid() needs to access the MPTCP socket and the subflow
request, but not the request sock that is passed in argument.
Instead, the subflow request can be directly passed to avoid getting it
via an additional cast.
Reviewed-by: Geliang Tang
Signed-off-by: Matthieu Baerts (NGI0)
---
This is a follow-up of commit b68b106b0f15 ("mptcp: sched: reduce size
for unused data"), now removing the mptcp_sched_data structure.
Now is a good time to do that, because the previously mentioned WIP work
has been updated, no longer depending on this structure.
Signed-off-by: Matthieu Baerts (
From: zhenwei pi
mptcp_connect.c is a startup tutorial of MPTCP programming, however
there is a lack of ai_protocol(IPPROTO_MPTCP) usage. Add comment for
getaddrinfo MPTCP support.
This patch first uses IPPROTO_MPTCP to get addrinfo, and if glibc
version is too old, it falls back to using IPPROT
From: Geliang Tang
It's strange that 'nlh' variable is set to NULL in get_mptcpinfo() and then
this NULL pointer is passed to recv_nlmsg(). In fact, this variable should
be defined in recv_nlmsg(), not get_mptcpinfo().
So this patch drops this useless 'nlh' parameter of recv_nlmsg() and define
'
The parent commit adds this new counter, incremented when receiving a
connection request, if the PM didn't allow the creation of new subflows.
Most of the time, it is then kept at 0, except when the PM limits cause
the receiver side to reject new MPJoin connections. This is the case in
the followi
This counter is useful to understand why some paths are rejected, and
not created as expected.
It is incremented when receiving a connection request, if the PM didn't
allow the creation of new subflows.
Reviewed-by: Geliang Tang
Signed-off-by: Matthieu Baerts (NGI0)
---
net/mptcp/mib.c |
From: Geliang Tang
A new interface .validate has been added in struct bpf_struct_ops
recently. This patch prepares a future struct_ops support by
implementing it as a new helper mptcp_validate_scheduler() for struct
mptcp_sched_ops.
In this helper, check whether the required ops "get_subflow" of
From: Thorsten Blum
Commit e4c28e3d5c090 ("mptcp: pm: move generic PM helpers to pm.c")
removed an unnecessary if-check, which resulted in returning a freed
pointer.
This still works due to the implicit boolean conversion when returning
the freed pointer from mptcp_remove_anno_list_by_saddr(), b
/mptcp_connect.c | 21 +++---
tools/testing/selftests/net/mptcp/mptcp_diag.c| 7 ++---
tools/testing/selftests/net/mptcp/mptcp_join.sh | 26 +
11 files changed, 80 insertions(+), 46 deletions(-)
---
base-commit: 61499764e5cc5918c9f63026d3b7a34c8668d4b8
change-id: 20250411-net
From: Winston Wen
On x86_64 with gcc version 13.3.0, I compile
drivers/vfio/pci/virtio/legacy_io.c with:
make defconfig
./scripts/kconfig/merge_config.sh .config <(
echo CONFIG_VFIO=m
echo CONFIG_VIRTIO_PCI=y
echo CONFIG_VIRTIO_PCI_LIB_LEGACY=y
echo CONFIG_VIRTIO_VFIO_PCI=m
On Thu, Apr 10, 2025 at 12:51:48PM +0200, Paolo Abeni wrote:
On 4/7/25 8:41 PM, Michal Luczaj wrote:
Change the behaviour of a lingering close(): instead of waiting for all
data to be consumed, block until data is considered sent, i.e. until worker
picks the packets and decrements virtio_vsock_s
Enable CONFIG_INIT_STACK_ALL_PATTERN in all_tests.config. This helps
to detect use of uninitialized local variables.
This option found an uninitialized data bug in the cs_dsp test.
Signed-off-by: Richard Fitzgerald
---
tools/testing/kunit/configs/all_tests.config | 1 +
1 file changed, 1 insert
setpgrp() is defined to be identical to setpgid(0, 0).
Signed-off-by: Thomas Weißschuh
Acked-by: Willy Tarreau
---
tools/include/nolibc/sys.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/tools/include/nolibc/sys.h b/tools/include/nolibc/sys.h
index
f52e1953020945fb2902d47ad5
dprintf() and vdprintf() are printf() variants printing directly into a
filedescriptor. As FILE in nolibc is based directly on filedescriptors,
the implementation is trivial.
Signed-off-by: Thomas Weißschuh
Acked-by: Willy Tarreau
---
tools/include/nolibc/stdio.h | 24
be932d3f726fe5602cf8d50d1
> > 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> > +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> > @@ -632,10 +632,7 @@ &sound {
> > "RX_BIAS", "MCLK",
> > "AMIC2", "MIC BIAS2",
> > "SpkrLeft IN", "SPK1 OUT",
> > - "SpkrRight IN", "SPK2 OUT",
> > - "MM_DL1", "MultiMedia1 Playback",
> > - "MM_DL3", "MultiMedia3 Playback",
> > - "MultiMedia2 Capture", "MM_UL2";
> > + "SpkrRight IN", "SPK2 OUT";
> >
> > mm1-dai-link {
> > link-name = "MultiMedia1";
> > diff --git a/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts
> > b/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts
> > index
> > 26217836c2707ba2f7b0030c9801d7de3a797315..d6d4e7184c5603864668057de79c7497ad361ab3
> > 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts
> > +++ b/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts
> > @@ -445,10 +445,7 @@ &sound {
> > "RX_BIAS", "MCLK",
> > "AMIC2", "MIC BIAS2",
> > "SpkrLeft IN", "SPK1 OUT",
> > - "SpkrRight IN", "SPK2 OUT",
> > - "MM_DL1", "MultiMedia1 Playback",
> > - "MM_DL3", "MultiMedia3 Playback",
> > - "MultiMedia2 Capture", "MM_UL2";
> > + "SpkrRight IN", "SPK2 OUT";
> >
> > mm1-dai-link {
> > link-name = "MultiMedia1";
> >
> > ---
> > base-commit: 01c6df60d5d4ae00cd5c1648818744838bba7763
> > change-id: 20250411-cleanup-mm-routes-7b9e92962553
> >
> > Best regards,
> > --
> > Luca Weiss
> >
With the addition of snprintf() and its usage in nolibc-test, the name of
the "vfprintf" test suite is not accurate anymore.
Rename the suite to be more generic.
Signed-off-by: Thomas Weißschuh
Acked-by: Willy Tarreau
---
tools/testing/selftests/nolibc/nolibc-test.c | 4 ++--
1 file changed, 2
On 4/11/25 9:15 AM, Jagadeesh Kona wrote:
>
>
> On 4/1/2025 10:03 PM, Konrad Dybcio wrote:
>> On 3/24/25 9:41 AM, Luca Weiss wrote:
>>> Add a node for the videocc found on the SM6350 SoC.
>>>
>>> Signed-off-by: Luca Weiss
>>> ---
>>> arch/arm64/boot/dts/qcom/sm6350.dtsi | 14 ++
>>>
Show how to use the kselftest harness together with nolibc.
This just runs the existing harness selftest by crudely replacing the
regular nolibc-test.c with the harness-selftest.c to get that wired up easily.
To use it:
$ cd tools/testing/selftests/nolibc/
$ ./run-tests -m user
In
With -Wmissing-prototypes the compiler will warn about non-static
functions which don't have a prototype defined.
As they are not used from a different compilation unit they don't need to
be defined globally.
Avoid the issue by marking the functions static.
Signed-off-by: Thomas Weißschuh
---
t
Introduce a getopt() implementation based on the one from musl.
The only deviations are adaption to the kernel coding style and nolibc
infrastructure and removal of multi-byte support.
Signed-off-by: Thomas Weißschuh
Acked-by: Willy Tarreau
---
tools/include/nolibc/Makefile | 1 +
tools/inclu
Add more of the printf() functions.
Signed-off-by: Thomas Weißschuh
Acked-by: Willy Tarreau
---
tools/include/nolibc/stdio.h | 55
1 file changed, 55 insertions(+)
diff --git a/tools/include/nolibc/stdio.h b/tools/include/nolibc/stdio.h
index
b17b4
printf can pad each argument to a certain width.
Implement this for compatibility with the kselftest harness.
Currently only padding with spaces is supported.
Signed-off-by: Thomas Weißschuh
Acked-by: Willy Tarreau
---
tools/include/nolibc/stdio.h | 17 -
tools/t
snprintf() allows limiting the output buffer, while still returning the
number of all bytes that would have been written.
Implement the limitation logic in preparation for snprintf().
Signed-off-by: Thomas Weißschuh
Acked-by: Willy Tarreau
---
tools/include/nolibc/stdio.h | 16 ++--
Now that we have a proper snprintf() implementation,
make sure truncation is handled properly.
Signed-off-by: Thomas Weißschuh
Acked-by: Willy Tarreau
---
tools/testing/selftests/nolibc/nolibc-test.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/
With a proper snprintf() implementation in place, the ugly pipe usage is
not necessary anymore.
Signed-off-by: Thomas Weißschuh
Acked-by: Willy Tarreau
---
tools/testing/selftests/nolibc/nolibc-test.c | 30 +++-
1 file changed, 3 insertions(+), 27 deletions(-)
diff --gi
Decouple the formatting logic from the writing logic to later enable
writing straight to a buffer in sprintf().
Signed-off-by: Thomas Weißschuh
Acked-by: Willy Tarreau
---
tools/include/nolibc/stdio.h | 21 +
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/too
riscv32 does not have any of the older poll systemcalls.
Use ppoll_time64 instead.
Signed-off-by: Thomas Weißschuh
Acked-by: Willy Tarreau
---
tools/include/nolibc/sys.h | 8
1 file changed, 8 insertions(+)
diff --git a/tools/include/nolibc/sys.h b/tools/include/nolibc/sys.h
index
a5
nolibc's waitpid() now uses the waitid() syscall internally.
This removes the original reasoning for the reverted commit as
waitpid() is now available on all platforms and has an easier interface.
Switch back to waitpid().
This reverts commit a0bc8947ac731ff95a56e0c1737e69e8c56d5b78.
Signed-off-
The old wait4() syscall used by waitpid() before is not available everywhere.
Switch to the waitid() syscall which is the new replacement.
Signed-off-by: Thomas Weißschuh
Acked-by: Willy Tarreau
---
tools/include/nolibc/sys.h | 71 ++
1 file changed,
The kselftest harness uses these functions.
Signed-off-by: Thomas Weißschuh
Acked-by: Willy Tarreau
---
tools/include/nolibc/string.h| 17 +
tools/testing/selftests/nolibc/nolibc-test.c | 5 +
2 files changed, 22 insertions(+)
diff --git a/tools/include/nol
The printf format checking in the compiler uses the intmax types from
the compiler, not libc. This can lead to compiler errors.
Instead use the types already provided by the compiler.
Example issue with clang 19 for arm64:
nolibc-test.c:30:2: error: format specifies type 'uintmax_t' (aka 'unsign
_exit() is the faster variant of exit(), skipping all cleanup actions.
As nolibc does not perform any cleanup anyways, the implementation is
trivial.
Signed-off-by: Thomas Weißschuh
Acked-by: Willy Tarreau
---
tools/include/nolibc/sys.h | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(
riscv32 does not have any of the older select systemcalls.
Use pselect6_time64 instead.
poll() is also used to implement sleep().
Signed-off-by: Thomas Weißschuh
Acked-by: Willy Tarreau
---
tools/include/nolibc/sys.h | 8
1 file changed, 8 insertions(+)
diff --git a/tools/include/noli
In nolibc intmax_t and uintmax_t are always the same as
(unsigned) long long/uint64_t as 128bit numbers are not supported.
Even libcs that do support 128bit numbers often fix intmax_t to 64bit
as it is used in ABIs and any change would break those.
Signed-off-by: Thomas Weißschuh
Acked-by: Willy
Nolibc doesn't provide all normal header files.
Don't try to include these non-existent header files, as the symbols are
available unconditionally anyways.
Signed-off-by: Thomas Weißschuh
---
tools/testing/selftests/kselftest_harness.h | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-
Usage of longjmp() was added to ensure that teardown is always run in
commit 63e6b2a42342 ("selftests/harness: Run TEARDOWN for ASSERT failures")
However instead of calling longjmp() to the teardown handler it is easier to
just call the teardown handler directly from __bail().
Any potential duplica
To get rid of setjmp()/longjmp(), the teardown logic needs to be usable
from __bail(). Introduce a new callback for it.
Signed-off-by: Thomas Weißschuh
---
tools/testing/selftests/kselftest_harness.h | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/tools/t
Make the kselftest harness compatible with nolibc which does not implement
signals by replacing the signal logic with pidfds.
The code also becomes simpler.
Signed-off-by: Thomas Weißschuh
---
tools/testing/selftests/kselftest_harness.h | 72 ++---
1 file changed, 25 inse
To get rid of setjmp()/longjmp(), the teardown logic needs to be usable
from __bail(). To access the atomic teardown conditional from there,
move it into the test metadata.
This also allows the removal of "setup_completed".
Signed-off-by: Thomas Weißschuh
---
tools/testing/selftests/kselftest_ha
Some upcoming changes to the assertion macros need those two symbols
also to be available for tests without fixtures.
Provide them with a NULL value.
Signed-off-by: Thomas Weißschuh
---
tools/testing/selftests/kselftest_harness.h | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
dif
__sync_bool_compare_and_swap() is deprecated and requires libatomic on
GCC. Compiler toolchains don't necessarily have libatomic available, so
avoid this requirement by using atomics that don't need libatomic.
Signed-off-by: Thomas Weißschuh
---
tools/testing/selftests/kselftest_harness.h | 4 ++
This field is unused and has no meaning for tests without fixtures.
Don't set it for them.
Signed-off-by: Thomas Weißschuh
---
tools/testing/selftests/kselftest_harness.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/kselftest_harness.h
b/tools/testing/selftests/kse
The pointers to the wrappers are stored in function pointers,
preventing them from actually being inlined.
Remove the inline qualifier, aligning these wrappers with the other
functions defined through macros.
Signed-off-by: Thomas Weißschuh
---
tools/testing/selftests/kselftest_harness.h | 4 ++-
All comments in this file use C89 comment style.
Except for this one. Change it to get one step closer to C89
compatibility.
Signed-off-by: Thomas Weißschuh
---
tools/testing/selftests/kselftest_harness.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests
Add a selftest for the kselftest harness itself so any changes can be
validated.
Signed-off-by: Thomas Weißschuh
---
MAINTAINERS| 1 +
tools/testing/selftests/Makefile | 1 +
.../testing/selftests/kselftest_harness/.gitignore | 2 +
For tests without fixtures the variant argument is unused.
This is intentional, prevent to compiler from complaining.
Example warning:
harness-selftest.c: In function 'wrapper_standalone_pass':
../kselftest_harness.h:181:52: error: unused parameter 'variant'
[-Werror=unused-parameter]
Nolibc is useful for selftests as the test programs can be very small,
and compiled with just a kernel crosscompiler, without userspace support.
Currently nolibc is only usable with kselftest.h, not the more
convenient to use kselftest_harness.h
This series provides this compatibility by adding new
On 11/04/2025 05:07, Jakub Kicinski wrote:
On Mon, 07 Apr 2025 21:46:15 +0200 Antonio Quartulli wrote:
diff --git a/drivers/net/ovpn/socket.c b/drivers/net/ovpn/socket.c
index
97f6a249b09fe26cc6d078d80abc955f8d35e821..200036757fcd0a7f2ae554a1e3a3c03915c0e32f
100644
--- a/drivers/net/ovpn/socke
Hi Alok,
On 10/04/2025 19:51, ALOK TIWARI wrote:
On 08-04-2025 01:16, Antonio Quartulli wrote:
Although it wasn't easy to convince the community, `ovpn` implements
only a limited number of the data-channel features supported by the
userspace program.
Each feature that made it to `ovpn` was a
"SpkrLeft IN", "SPK1 OUT",
> - "SpkrRight IN", "SPK2 OUT",
> - "MM_DL1", "MultiMedia1 Playback",
> - "MM_DL3", "MultiMedia3 Playback",
> - "MultiMedia2 Capture", "MM_UL2";
> + "SpkrRight IN", "SPK2 OUT";
>
> mm1-dai-link {
> link-name = "MultiMedia1";
> diff --git a/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts
> b/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts
> index
> 26217836c2707ba2f7b0030c9801d7de3a797315..d6d4e7184c5603864668057de79c7497ad361ab3
> 100644
> --- a/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts
> @@ -445,10 +445,7 @@ &sound {
> "RX_BIAS", "MCLK",
> "AMIC2", "MIC BIAS2",
> "SpkrLeft IN", "SPK1 OUT",
> - "SpkrRight IN", "SPK2 OUT",
> - "MM_DL1", "MultiMedia1 Playback",
> - "MM_DL3", "MultiMedia3 Playback",
> - "MultiMedia2 Capture", "MM_UL2";
> + "SpkrRight IN", "SPK2 OUT";
>
> mm1-dai-link {
> link-name = "MultiMedia1";
>
> ---
> base-commit: 01c6df60d5d4ae00cd5c1648818744838bba7763
> change-id: 20250411-cleanup-mm-routes-7b9e92962553
>
> Best regards,
> --
> Luca Weiss
>
On 11/04/2025 05:03, Jakub Kicinski wrote:
On Mon, 07 Apr 2025 21:46:12 +0200 Antonio Quartulli wrote:
+ /* carrier for P2P interfaces is switched on and off when
+* the peer is added or deleted.
+*
+* in case of P2MP interfaces we just keep the carrier always on
+
(adding CC list again, because I assume it was dropped by accident)
diff --git a/fs/dax.c b/fs/dax.c
index af5045b0f476e..676303419e9e8 100644
--- a/fs/dax.c
+++ b/fs/dax.c
@@ -396,6 +396,7 @@ static inline unsigned long dax_folio_put(struct folio
*folio)
order = folio_order(folio);
On 10.04.25 23:54, Matthew Wilcox wrote:
On Thu, Apr 10, 2025 at 01:46:06PM -0700, Dan Williams wrote:
Matthew Wilcox wrote:
On Thu, Apr 10, 2025 at 01:15:07PM -0700, Dan Williams wrote:
For consistency and clarity what about this incremental change, to make
the __split_folio_to_order() path r
OUT",
- "MM_DL1", "MultiMedia1 Playback",
- "MM_DL3", "MultiMedia3 Playback",
- "MultiMedia2 Capture", "MM_UL2";
+ "SpkrRight IN", "SPK2 OUT";
mm1-dai-
On Thu, Apr 10, 2025 at 06:07:59PM -0700, Bobby Eshleman wrote:
This commit introduces a new vmtest.sh runner for vsock.
It uses virtme-ng/qemu to run tests in a VM. The tests are designed to
validate both G2H and H2G paths. The testing tools from tools from
tools/testing/vsock/ are reused. Curr
On 11/04/2025 04:58, Jakub Kicinski wrote:
On Mon, 07 Apr 2025 21:46:10 +0200 Antonio Quartulli wrote:
+checks:
+ exact-len: nonce-tail-size
some of the checks look slightly mis-indented (needs one more space)
ACK. Will fix those.
Regards,
--
Antonio Quartulli
OpenVPN Inc.
1 - 100 of 102 matches
Mail list logo
