Re: [PATCH v2 1/8] dt-bindings: interconnect: qcom: Add Qualcomm MSM8976 NoC

2024-07-05 Thread Krzysztof Kozlowski
On 04/07/2024 22:02, Adam Skladowski wrote: > Add bindings for Qualcomm MSM8976 Network-On-Chip interconnect devices. > > Signed-off-by: Adam Skladowski > --- > .../bindings/interconnect/qcom,msm8976.yaml | 63 > .../dt-bindings/interconnect/qcom,msm8976.h | 97

Re: [PATCH v2 0/8] msm8937/msm8976/qcs404 icc patches

2024-07-05 Thread Krzysztof Kozlowski
On 04/07/2024 22:02, Adam Skladowski wrote: > This series introduce new ICC drivers for some legacy socs > while at it also updates a bit of qcs404 driver which seems > to not receive much attention lately. > Please take in consideration i do not own any qcs404 board > so i cannot test anything

Re: [PATCH v2 1/2] hugetlbfs: support tracepoint

2024-07-05 Thread Hongbo Li
On 2024/7/5 7:34, Dave Chinner wrote: On Thu, Jul 04, 2024 at 10:13:22AM -0400, Steven Rostedt wrote: On Thu, 4 Jul 2024 22:56:29 +1000 Dave Chinner wrote: Having to do this is additional work when writing use-once scripts that get thrown away when the tracepoint output analysis is done

[PATCH v2] init: staging: Fix missing warning/taint on builtin code

2024-07-04 Thread Ágatha Isabelle Chris Moreira Guedes
Fix the absence of warning message and kernel tainting when initializing drivers from the `drivers/staging` subtree from initcalls (when configured as built-in). When such a driver is built as module and the module is loaded, the `load_module()` function taints the kernel to signal code of

Re: [PATCH v2 1/2] hugetlbfs: support tracepoint

2024-07-04 Thread Dave Chinner
On Thu, Jul 04, 2024 at 10:13:22AM -0400, Steven Rostedt wrote: > On Thu, 4 Jul 2024 22:56:29 +1000 > Dave Chinner wrote: > > > Having to do this is additional work when writing use-once scripts > > that get thrown away when the tracepoint output analysis is done > > is painful, and it's

Re: [syzbot] [mm?] possible deadlock in __mmap_lock_do_trace_released

2024-07-04 Thread Jesper Dangaard Brouer
On 02/07/2024 20.54, syzbot wrote: Hello, syzbot found the following issue on: HEAD commit:a12978712d90 selftests/bpf: Move ARRAY_SIZE to bpf_misc.h git tree: bpf-next console+strace: https://syzkaller.appspot.com/x/log.txt?x=130457fa98 kernel config:

[PATCH v2 8/8] interconnect: qcom: msm8953: Add ab_coeff

2024-07-04 Thread Adam Skladowski
BIMC and SNOC-MM on downstream feature qcom,util-fact which translates to ab_coeff, add it. Signed-off-by: Adam Skladowski --- drivers/interconnect/qcom/msm8953.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/interconnect/qcom/msm8953.c b/drivers/interconnect/qcom/msm8953.c

[PATCH v2 7/8] dt-bindings: interconnect: qcom: msm8939: Fix example

2024-07-04 Thread Adam Skladowski
For now example list snoc_mm as children of bimc which is obviously not valid, drop snoc and snoc_mm and leave bimc alone. Signed-off-by: Adam Skladowski --- .../bindings/interconnect/qcom,msm8939.yaml | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git

[PATCH v2 6/8] interconnect: qcom: qcs404: Add regmaps and more bus descriptions

2024-07-04 Thread Adam Skladowski
Currently we are lacking descriptions of regmaps, bus clocks and types of busses, provide them. Signed-off-by: Adam Skladowski --- drivers/interconnect/qcom/qcs404.c | 42 +++--- 1 file changed, 39 insertions(+), 3 deletions(-) diff --git

[PATCH v2 5/8] interconnect: qcom: qcs404: Mark AP-owned nodes as such

2024-07-04 Thread Adam Skladowski
When driver was upstreamed it seems ap_owned nodes were not available, bring them now. Signed-off-by: Adam Skladowski --- drivers/interconnect/qcom/qcs404.c | 85 ++ 1 file changed, 85 insertions(+) diff --git a/drivers/interconnect/qcom/qcs404.c

[PATCH v2 4/8] interconnect: qcom: Add MSM8937 interconnect provider driver

2024-07-04 Thread Adam Skladowski
Add driver for interconnect busses found in MSM8937 based platforms. The topology consists of four NoCs that are partially controlled by a RPM processor. Signed-off-by: Adam Skladowski --- drivers/interconnect/qcom/Kconfig |9 + drivers/interconnect/qcom/Makefile |2 +

[PATCH v2 3/8] dt-bindings: interconnect: qcom: Add Qualcomm MSM8937 NoC

2024-07-04 Thread Adam Skladowski
Add bindings for Qualcomm MSM8937 Network-On-Chip interconnect devices. Signed-off-by: Adam Skladowski --- .../bindings/interconnect/qcom,msm8937.yaml | 63 + .../dt-bindings/interconnect/qcom,msm8937.h | 93 +++ 2 files changed, 156 insertions(+) create mode

[PATCH v2 2/8] interconnect: qcom: Add MSM8976 interconnect provider driver

2024-07-04 Thread Adam Skladowski
Add driver for interconnect busses found in MSM8976 based platforms. The topology consists of four NoCs that are partially controlled by a RPM processor. Signed-off-by: Adam Skladowski --- drivers/interconnect/qcom/Kconfig |9 + drivers/interconnect/qcom/Makefile |2 +

[PATCH v2 1/8] dt-bindings: interconnect: qcom: Add Qualcomm MSM8976 NoC

2024-07-04 Thread Adam Skladowski
Add bindings for Qualcomm MSM8976 Network-On-Chip interconnect devices. Signed-off-by: Adam Skladowski --- .../bindings/interconnect/qcom,msm8976.yaml | 63 .../dt-bindings/interconnect/qcom,msm8976.h | 97 +++ 2 files changed, 160 insertions(+) create mode

[PATCH v2 0/8] msm8937/msm8976/qcs404 icc patches

2024-07-04 Thread Adam Skladowski
This series introduce new ICC drivers for some legacy socs while at it also updates a bit of qcs404 driver which seems to not receive much attention lately. Please take in consideration i do not own any qcs404 board so i cannot test anything else than if it compiles. Changes since v1

[PATCH] tracing/kprobes: Add missing check for skipping symbol counting logic

2024-07-04 Thread Nikolay Kuratov
In commit b022f0c7e404 ("tracing/kprobes: Return EADDRNOTAVAIL when func matches several symbols") it was already done for symbol in __trace_kprobe_create(), but func in create_local_trace_kprobe() is also valid usage. Not doing so leads to ENOENT for module_name:symbol_name constructions passed

Re: [PATCH v6] remoteproc: xlnx: add attach detach support

2024-07-04 Thread Mathieu Poirier
On Thu, Jun 27, 2024 at 10:29:38AM -0700, Tanmay Shah wrote: > It is possible that remote processor is already running before > linux boot or remoteproc platform driver probe. Implement required > remoteproc framework ops to provide resource table address and > connect or disconnect with remote

Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore

2024-07-04 Thread Paul E. McKenney
On Thu, Jul 04, 2024 at 11:15:59AM +0200, Peter Zijlstra wrote: > On Wed, Jul 03, 2024 at 02:33:06PM -0700, Andrii Nakryiko wrote: > > > 2. More tactically, RCU protection seems like the best way forward. We > > got hung up on SRCU vs RCU Tasks Trace. Thanks to Paul, we also > > clarified that

Re: [PATCH v2] remoteproc: k3-dsp: Fix log levels where appropriate

2024-07-04 Thread Mathieu Poirier
On Wed, Jun 26, 2024 at 12:14:38PM -0700, Garrett Giordano wrote: > Driver was logging information as errors. Changed dev_err to dev_dbg > where appropriate. > > Signed-off-by: Garrett Giordano > --- > -v2 > - Change from dev_info to dev_dbg > - Drop k3-r5 PATCH > --- >

Re: [PATCH v8 2/5] remoteproc: Add TEE support

2024-07-04 Thread Mathieu Poirier
On Thu, Jul 04, 2024 at 10:05:24AM +0200, Arnaud POULIQUEN wrote: > > > On 7/3/24 17:14, Mathieu Poirier wrote: > > On Wed, Jul 03, 2024 at 09:19:44AM +0200, Arnaud POULIQUEN wrote: > >> Hello Mathieu > >> > >> On 7/2/24 18:44, Mathieu Poirier wrote: > >>> Good morning, > >>> > >>> On Fri, Jun

Re: [PATCH v4 2/2] rust: add tracepoint support

2024-07-04 Thread Carlos Llamas
On Fri, Jun 28, 2024 at 01:23:32PM +, Alice Ryhl wrote: > Make it possible to have Rust code call into tracepoints defined by C > code. It is still required that the tracepoint is declared in a C > header, and that this header is included in the input to bindgen. > > Signed-off-by: Alice Ryhl

Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore

2024-07-04 Thread Paul E. McKenney
On Thu, Jul 04, 2024 at 10:39:35AM +0200, Peter Zijlstra wrote: > On Wed, Jul 03, 2024 at 07:08:21AM -0700, Paul E. McKenney wrote: > > On Wed, Jul 03, 2024 at 09:50:57AM +0200, Peter Zijlstra wrote: > > > > Would it make sense to disable it for those architectures that have > > > already done

[PATCH v2] trace/pid_list: Change gfp flags in pid_list_fill_irq()

2024-07-04 Thread Levi Yun
From: "levi.yun" pid_list_fill_irq() runs via irq_work. When CONFIG_PREEMPT_RT is disabled, it would run in irq_context. so it shouldn't sleep while memory allocation. Change gfp flags from GFP_KERNEL to GFP_NOWAIT to prevent sleep in irq_work. This change wouldn't impact functionality in

Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management

2024-07-04 Thread Google
On Thu, 4 Jul 2024 10:45:24 +0200 Peter Zijlstra wrote: > On Thu, Jul 04, 2024 at 10:03:48AM +0200, Peter Zijlstra wrote: > > > diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c > > index c98e3b3386ba..4aafb4485be7 100644 > > --- a/kernel/trace/trace_uprobe.c > > +++

Re: [PATCH v2 1/2] hugetlbfs: support tracepoint

2024-07-04 Thread Steven Rostedt
On Thu, 4 Jul 2024 22:56:29 +1000 Dave Chinner wrote: > Having to do this is additional work when writing use-once scripts > that get thrown away when the tracepoint output analysis is done > is painful, and it's completely unnecessary if the tracepoint output > is completely space separated

Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore

2024-07-04 Thread Steven Rostedt
On Thu, 4 Jul 2024 11:15:59 +0200 Peter Zijlstra wrote: > > Now, RCU Tasks Trace were specifically designed for least overhead > > hotpath (reader side) performance, at the expense of slowing down much > > rarer writers. My microbenchmarking does show at least 5% difference. > > Both flavors can

Re: [PATCH 0/2] Support userspace hypercalls for TDX

2024-07-04 Thread Peter Zijlstra
On Wed, Jul 03, 2024 at 11:35:59PM +, Tim Merrifield wrote: > VMCALL and VMMCALL instructions are used by x86 guests to request services > from the host VMM. Both VMCALL and VMMCALL are not restricted to CPL 0. > This allows userspace software like open-vm-tools to communicate directly > with

Re: [PATCH v2 1/2] hugetlbfs: support tracepoint

2024-07-04 Thread Dave Chinner
On Thu, Jul 04, 2024 at 04:37:30AM +0100, Matthew Wilcox wrote: > On Thu, Jul 04, 2024 at 11:07:03AM +0800, Hongbo Li wrote: > > + TP_printk("dev = (%d,%d), ino = %lu, dir = %lu, mode = 0%o", > > + MAJOR(__entry->dev), MINOR(__entry->dev), > > + (unsigned long) __entry->ino,

Re: [PATCH] tracing/net_sched: NULL pointer dereference in perf_trace_qdisc_reset()

2024-07-04 Thread Greg Kroah-Hartman
On Thu, Jul 04, 2024 at 08:16:34PM +0900, Yunseong Kim wrote: > Hi Greg, Hi Jakub > > On 7/4/24 6:32 오후, Greg Kroah-Hartman wrote: > > On Wed, Jul 03, 2024 at 07:18:35PM -0700, Jakub Kicinski wrote: > >> On Wed, 3 Jul 2024 03:01:47 +0900 Yunseong Kim wrote: > >>> Support backports for stable

Re: [PATCH v2] dt-bindings: hwlock: sprd-hwspinlock: convert to YAML

2024-07-04 Thread Baolin Wang
On 2024/7/4 19:38, Stanislav Jakubek wrote: Convert the Spreadtrum hardware spinlock bindings to DT schema. Reviewed-by: Conor Dooley Signed-off-by: Stanislav Jakubek LGTM. Thanks. Reviewed-by: Baolin Wang --- Changes in V2: - fix double space in example - switch to

[PATCH v2] dt-bindings: hwlock: sprd-hwspinlock: convert to YAML

2024-07-04 Thread Stanislav Jakubek
Convert the Spreadtrum hardware spinlock bindings to DT schema. Reviewed-by: Conor Dooley Signed-off-by: Stanislav Jakubek --- Changes in V2: - fix double space in example - switch to #address-cells = <1> and #size-cells = <1> in example - add Conor's R-b

Re: [PATCH] tracing/net_sched: NULL pointer dereference in perf_trace_qdisc_reset()

2024-07-04 Thread Yunseong Kim
Hi Greg, Hi Jakub On 7/4/24 6:32 오후, Greg Kroah-Hartman wrote: > On Wed, Jul 03, 2024 at 07:18:35PM -0700, Jakub Kicinski wrote: >> On Wed, 3 Jul 2024 03:01:47 +0900 Yunseong Kim wrote: >>> Support backports for stable version. There are two places where null >>> deref could happen before >>>

Re: [PATCH v2] ring-buffer: Limit time with disabled interrupts in rb_check_pages()

2024-07-04 Thread Petr Pavlu
On 7/3/24 23:44, Steven Rostedt wrote: > On Wed, 3 Jul 2024 09:53:14 +0200 > Petr Pavlu wrote: > >> The function rb_check_pages() validates the integrity of a specified >> per-CPU tracing ring buffer. It does so by traversing the underlying >> linked list and checking its next and prev links.

Re: [PATCH] tracing/net_sched: NULL pointer dereference in perf_trace_qdisc_reset()

2024-07-04 Thread Greg Kroah-Hartman
On Wed, Jul 03, 2024 at 07:18:35PM -0700, Jakub Kicinski wrote: > On Wed, 3 Jul 2024 03:01:47 +0900 Yunseong Kim wrote: > > Support backports for stable version. There are two places where null > > deref could happen before > > commit 2c92ca849fcc ("tracing/treewide: Remove second parameter of >

Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore

2024-07-04 Thread Peter Zijlstra
On Wed, Jul 03, 2024 at 02:33:06PM -0700, Andrii Nakryiko wrote: > 2. More tactically, RCU protection seems like the best way forward. We > got hung up on SRCU vs RCU Tasks Trace. Thanks to Paul, we also > clarified that RCU Tasks Trace has nothing to do with Tasks Rude > flavor (whatever that

Re: [PATCH] kallsyms, livepatch: Fix livepatch with CONFIG_LTO_CLANG

2024-07-04 Thread Petr Mladek
On Wed 2024-07-03 08:30:33, Luis Chamberlain wrote: > On Tue, Jul 02, 2024 at 10:56:41PM -0700, Josh Poimboeuf wrote: > > On Mon, Jul 01, 2024 at 03:13:23PM +0200, Petr Mladek wrote: > > > So, you suggest to search the symbols by a hash. Do I get it correctly? > > I meant, that in the Rust world

Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management

2024-07-04 Thread Peter Zijlstra
On Thu, Jul 04, 2024 at 10:03:48AM +0200, Peter Zijlstra wrote: > diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c > index c98e3b3386ba..4aafb4485be7 100644 > --- a/kernel/trace/trace_uprobe.c > +++ b/kernel/trace/trace_uprobe.c > @@ -1112,7 +1112,8 @@ static void

Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore

2024-07-04 Thread Peter Zijlstra
On Wed, Jul 03, 2024 at 07:08:21AM -0700, Paul E. McKenney wrote: > On Wed, Jul 03, 2024 at 09:50:57AM +0200, Peter Zijlstra wrote: > > Would it make sense to disable it for those architectures that have > > already done this work? > > It might well. Any architectures other than x86 at this

Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management

2024-07-04 Thread Peter Zijlstra
On Wed, Jul 03, 2024 at 01:47:23PM -0700, Andrii Nakryiko wrote: > > When I cobble all that together (it really shouldn't be one patch, but > > you get the idea I hope) it looks a little something like the below. > > > > I *think* it should work, but perhaps I've missed something? > > Well, at

Re: [PATCH v8 2/5] remoteproc: Add TEE support

2024-07-04 Thread Arnaud POULIQUEN
On 7/3/24 17:14, Mathieu Poirier wrote: > On Wed, Jul 03, 2024 at 09:19:44AM +0200, Arnaud POULIQUEN wrote: >> Hello Mathieu >> >> On 7/2/24 18:44, Mathieu Poirier wrote: >>> Good morning, >>> >>> On Fri, Jun 21, 2024 at 04:37:56PM +0200, Arnaud Pouliquen wrote: Add a remoteproc TEE

Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management

2024-07-04 Thread Peter Zijlstra
On Wed, Jul 03, 2024 at 01:47:23PM -0700, Andrii Nakryiko wrote: > Your innocuous "// XXX amortize / batch" comment below is *the major > point of this patch set*. Try to appreciate that. It's not a small > todo, it took this entire patch set to allow for that. Tada! diff --git

Re: [PATCH v2 1/2] hugetlbfs: support tracepoint

2024-07-04 Thread Hongbo Li
On 2024/7/4 11:37, Matthew Wilcox wrote: On Thu, Jul 04, 2024 at 11:07:03AM +0800, Hongbo Li wrote: + TP_printk("dev = (%d,%d), ino = %lu, dir = %lu, mode = 0%o", + MAJOR(__entry->dev), MINOR(__entry->dev), + (unsigned long) __entry->ino, +

Re: [PATCH v2 1/2] hugetlbfs: support tracepoint

2024-07-03 Thread Matthew Wilcox
On Thu, Jul 04, 2024 at 11:07:03AM +0800, Hongbo Li wrote: > + TP_printk("dev = (%d,%d), ino = %lu, dir = %lu, mode = 0%o", > + MAJOR(__entry->dev), MINOR(__entry->dev), > + (unsigned long) __entry->ino, > + (unsigned long) __entry->dir, __entry->mode)

[PATCH v2 2/2] hugetlbfs: use tracepoints in hugetlbfs functions.

2024-07-03 Thread Hongbo Li
Here we use the hugetlbfs tracepoint to track the call stack. And the output in trace is as follows: ``` touch-5250[002] . 123.557640: hugetlbfs_alloc_inode: dev = (0,49), ino = 29897, dir = 24079, mode = 0100644 touch-5250[002] . 123.557650: hugetlbfs_setattr: dev = (0,49),

[PATCH v2 0/2] Introduce tracepoint for hugetlbfs

2024-07-03 Thread Hongbo Li
Here we add some basic tracepoints for debugging hugetlbfs: {alloc, free, evict}_inode, setattr and fallocate. v1 can be found at: https://lore.kernel.org/linux-mm/20240701194906.3a9b6...@gandalf.local.home/T/ Changes since v1: - Decrease the parameters for setattr tracer suggested by Steve

[PATCH v2 1/2] hugetlbfs: support tracepoint

2024-07-03 Thread Hongbo Li
Add basic tracepoints for {alloc, evict, free}_inode, setattr and fallocate. These can help users to debug hugetlbfs more conveniently. Signed-off-by: Hongbo Li --- MAINTAINERS | 1 + include/trace/events/hugetlbfs.h | 160 +++ 2 files changed,

Re: [PATCH] tracing/net_sched: NULL pointer dereference in perf_trace_qdisc_reset()

2024-07-03 Thread Jakub Kicinski
On Wed, 3 Jul 2024 03:01:47 +0900 Yunseong Kim wrote: > Support backports for stable version. There are two places where null > deref could happen before > commit 2c92ca849fcc ("tracing/treewide: Remove second parameter of > __assign_str()") > Link: >

Re: [PATCH v2 3/6] tools: Make pkg-config dependency checks usable by other tools

2024-07-03 Thread Namhyung Kim
On Wed, Jul 3, 2024 at 4:05 PM Steven Rostedt wrote: > > On Wed, 3 Jul 2024 14:33:21 -0700 > Namhyung Kim wrote: > > > On Wed, Jul 03, 2024 at 03:36:17PM -0400, Steven Rostedt wrote: > > > On Tue, 2 Jul 2024 16:40:46 -0700 > > > Namhyung Kim wrote: > > > > > > > +CC Steve and linux-trace-kernel

Re: [PATCH 0/2] Support userspace hypercalls for TDX

2024-07-03 Thread Dave Hansen
On 7/3/24 16:35, Tim Merrifield wrote: > VMCALL and VMMCALL instructions are used by x86 guests to request services > from the host VMM. Both VMCALL and VMMCALL are not restricted to CPL 0. > This allows userspace software like open-vm-tools to communicate directly > with the VMM. Could we please

[PATCH 2/2] x86/vmware: VMware support for TDX userspace hypercalls

2024-07-03 Thread Tim Merrifield
This change adds a handler for tdx_hcall in the x86_hyper_runtime type for VMware hypervisors which will ultimately invoke __tdx_hypercall. The handler (vmware_tdx_user_hcall) does not reuse the existing vmware_tdx_hypercall for a couple of reasons. First, while the few hypercalls that are

[PATCH 1/2] x86/tdx: Add prctl to allow userlevel TDX hypercalls

2024-07-03 Thread Tim Merrifield
Add a new prctl option to enable/disable user-level hypercalls when running in a confidential VM. Add support for checking this flag on VMCALL #VE for TDX and transfer control to a hypervisor vendor-specific handler. Signed-off-by: Tim Merrifield --- arch/x86/coco/tdx/tdx.c| 18

[PATCH 0/2] Support userspace hypercalls for TDX

2024-07-03 Thread Tim Merrifield
VMCALL and VMMCALL instructions are used by x86 guests to request services from the host VMM. Both VMCALL and VMMCALL are not restricted to CPL 0. This allows userspace software like open-vm-tools to communicate directly with the VMM. In the context of confidential VMs, direct communication with

Re: [PATCH v3] perf,x86: avoid missing caller address in stack traces captured in uprobe

2024-07-03 Thread Andrii Nakryiko
On Wed, Jul 3, 2024 at 3:39 PM Josh Poimboeuf wrote: > > On Tue, Jul 02, 2024 at 09:02:03PM -0700, Andrii Nakryiko wrote: > > @@ -2833,6 +2858,18 @@ perf_callchain_user32(struct pt_regs *regs, struct > > perf_callchain_entry_ctx *ent > > > > fp = compat_ptr(ss_base + regs->bp); > >

Re: [PATCH v2 3/6] tools: Make pkg-config dependency checks usable by other tools

2024-07-03 Thread Steven Rostedt
On Wed, 3 Jul 2024 14:33:21 -0700 Namhyung Kim wrote: > On Wed, Jul 03, 2024 at 03:36:17PM -0400, Steven Rostedt wrote: > > On Tue, 2 Jul 2024 16:40:46 -0700 > > Namhyung Kim wrote: > > > > > +CC Steve and linux-trace-kernel list. > > > > There doesn't seem to be a cover page, and it

Re: [PATCH v2] perf,x86: avoid missing caller address in stack traces captured in uprobe

2024-07-03 Thread Andrii Nakryiko
On Wed, Jul 3, 2024 at 3:41 PM Josh Poimboeuf wrote: > > On Wed, Jul 03, 2024 at 01:23:39PM -0700, Andrii Nakryiko wrote: > > > > [0] > > > > https://docs.google.com/presentation/d/1k10-HtK7pP5CMMa86dDCdLW55fHOut4co3Zs5akk0t4 > > > > > > I don't seem to have permission to open it. > > > > > > >

Re: [PATCH v2] perf,x86: avoid missing caller address in stack traces captured in uprobe

2024-07-03 Thread Josh Poimboeuf
On Wed, Jul 03, 2024 at 01:23:39PM -0700, Andrii Nakryiko wrote: > > > [0] > > > https://docs.google.com/presentation/d/1k10-HtK7pP5CMMa86dDCdLW55fHOut4co3Zs5akk0t4 > > > > I don't seem to have permission to open it. > > > > Argh, sorry, it's under my corporate account which doesn't allow >

Re: [PATCH v3] perf,x86: avoid missing caller address in stack traces captured in uprobe

2024-07-03 Thread Josh Poimboeuf
On Tue, Jul 02, 2024 at 09:02:03PM -0700, Andrii Nakryiko wrote: > @@ -2833,6 +2858,18 @@ perf_callchain_user32(struct pt_regs *regs, struct > perf_callchain_entry_ctx *ent > > fp = compat_ptr(ss_base + regs->bp); > pagefault_disable(); > + > +#ifdef CONFIG_UPROBES > + /* see

Re: [PATCH v23 3/5] tracing: Allow user-space mapping of the ring-buffer

2024-07-03 Thread Beau Belgrave
On Tue, Jul 02, 2024 at 12:51:26PM -0400, Steven Rostedt wrote: > On Tue, 2 Jul 2024 11:32:53 -0400 > Mathieu Desnoyers wrote: > > > If we use '*' for user events already, perhaps we'd want to consider > > using the same range for the ring buffer ioctls ? Arguably one is > > about

Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore

2024-07-03 Thread Paul E. McKenney
On Wed, Jul 03, 2024 at 05:57:54PM -0400, Steven Rostedt wrote: > On Wed, 3 Jul 2024 09:50:57 +0200 > Peter Zijlstra wrote: > > > > However, in the past, the memory-barrier and array-indexing overhead > > > of SRCU has made it a no-go for lightweight probes into fastpath code. > > > And these

Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore

2024-07-03 Thread Steven Rostedt
On Wed, 3 Jul 2024 09:50:57 +0200 Peter Zijlstra wrote: > > However, in the past, the memory-barrier and array-indexing overhead > > of SRCU has made it a no-go for lightweight probes into fastpath code. > > And these cases were what motivated RCU Tasks Trace (as opposed to RCU > > Tasks Rude).

Re: [PATCH v2 01/12] uprobes: update outdated comment

2024-07-03 Thread Andrii Nakryiko
On Wed, Jul 3, 2024 at 4:40 AM Oleg Nesterov wrote: > > Sorry for the late reply. I'll try to read this version/discussion > when I have time... yes, I have already promised this before, sorry :/ > No worries, there will be v3 next week (I'm going on short PTO starting tomorrow). So you still

Re: [PATCHv2 bpf-next 1/9] uprobe: Add support for session consumer

2024-07-03 Thread Andrii Nakryiko
On Wed, Jul 3, 2024 at 10:13 AM Jiri Olsa wrote: > > On Tue, Jul 02, 2024 at 01:51:28PM -0700, Andrii Nakryiko wrote: > > SNIP > > > > #ifdef CONFIG_UPROBES > > > @@ -80,6 +83,12 @@ struct uprobe_task { > > > unsigned intdepth; > > > }; > > > > > > +struct

Re: [PATCH v2 02/12] uprobes: correct mmap_sem locking assumptions in uprobe_write_opcode()

2024-07-03 Thread Google
On Wed, 3 Jul 2024 11:25:35 -0700 Andrii Nakryiko wrote: > On Wed, Jul 3, 2024 at 6:15 AM Masami Hiramatsu wrote: > > > > On Mon, 1 Jul 2024 15:39:25 -0700 > > Andrii Nakryiko wrote: > > > > > It seems like uprobe_write_opcode() doesn't require writer locked > > > mmap_sem, any lock (reader

Re: [PATCH v2] ring-buffer: Limit time with disabled interrupts in rb_check_pages()

2024-07-03 Thread Steven Rostedt
On Wed, 3 Jul 2024 09:53:14 +0200 Petr Pavlu wrote: > The function rb_check_pages() validates the integrity of a specified > per-CPU tracing ring buffer. It does so by traversing the underlying > linked list and checking its next and prev links. > > To guarantee that the list isn't modified

Re: [PATCHv2 bpf-next 1/9] uprobe: Add support for session consumer

2024-07-03 Thread Andrii Nakryiko
On Wed, Jul 3, 2024 at 9:09 AM Jiri Olsa wrote: > > On Tue, Jul 02, 2024 at 05:13:38PM -0700, Andrii Nakryiko wrote: > > On Tue, Jul 2, 2024 at 4:55 PM Masami Hiramatsu wrote: > > > > > > Hi Jiri, > > > > > > On Mon, 1 Jul 2024 18:41:07 +0200 > > > Jiri Olsa wrote: > > > > > > > Adding support

Re: [PATCHv2 bpf-next 1/9] uprobe: Add support for session consumer

2024-07-03 Thread Andrii Nakryiko
On Wed, Jul 3, 2024 at 8:31 AM Jiri Olsa wrote: > > On Tue, Jul 02, 2024 at 01:52:38PM -0700, Andrii Nakryiko wrote: > > On Tue, Jul 2, 2024 at 9:11 AM Jiri Olsa wrote: > > > > > > On Tue, Jul 02, 2024 at 03:04:08PM +0200, Peter Zijlstra wrote: > > > > On Mon, Jul 01, 2024 at 06:41:07PM +0200,

Re: [PATCH v2 3/6] tools: Make pkg-config dependency checks usable by other tools

2024-07-03 Thread Namhyung Kim
On Wed, Jul 03, 2024 at 03:36:17PM -0400, Steven Rostedt wrote: > On Tue, 2 Jul 2024 16:40:46 -0700 > Namhyung Kim wrote: > > > +CC Steve and linux-trace-kernel list. > > There doesn't seem to be a cover page, and it doesn't apply on > v6.10-rc6 nor on tip. Oh, sorry. You can find the whole

Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore

2024-07-03 Thread Andrii Nakryiko
On Mon, Jul 1, 2024 at 3:39 PM Andrii Nakryiko wrote: > > This patch set, ultimately, switches global uprobes_treelock from RW spinlock > to per-CPU RW semaphore, which has better performance and scales better under > contention and multiple parallel threads triggering lots of uprobes. > > To

Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore

2024-07-03 Thread Andrii Nakryiko
On Wed, Jul 3, 2024 at 1:07 AM Peter Zijlstra wrote: > > On Tue, Jul 02, 2024 at 09:47:41PM -0700, Andrii Nakryiko wrote: > > > > As you noted, that percpu-rwsem write side is quite insane. And you're > > > creating this batch complexity to mitigate that. > > > > > > Note that batch API is needed

Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management

2024-07-03 Thread Andrii Nakryiko
On Wed, Jul 3, 2024 at 6:36 AM Peter Zijlstra wrote: > > On Mon, Jul 01, 2024 at 03:39:27PM -0700, Andrii Nakryiko wrote: > > > One, attempted initially, way to solve this is through using > > atomic_inc_not_zero() approach, turning get_uprobe() into > > try_get_uprobe(), > > This is the

Re: [PATCHv2 bpf-next 1/9] uprobe: Add support for session consumer

2024-07-03 Thread Kees Cook
On Wed, Jul 03, 2024 at 11:31:11AM -0700, Andrii Nakryiko wrote: > On Wed, Jul 3, 2024 at 1:10 AM Peter Zijlstra wrote: > > > > On Tue, Jul 02, 2024 at 01:51:28PM -0700, Andrii Nakryiko wrote: > > > > +static size_t ri_size(int sessions_cnt) > > > > +{ > > > > + struct return_instance *ri

Re: [PATCH v2] perf,x86: avoid missing caller address in stack traces captured in uprobe

2024-07-03 Thread Andrii Nakryiko
On Tue, Jul 2, 2024 at 11:11 PM Josh Poimboeuf wrote: > > On Tue, Jul 02, 2024 at 08:35:08PM -0700, Andrii Nakryiko wrote: > > On Tue, Jul 2, 2024 at 6:11 PM Josh Poimboeuf wrote: > > > On Tue, Jul 02, 2024 at 05:06:14PM -0700, Andrii Nakryiko wrote: > > > > In general, even with false

Re: [PATCH v2 3/6] tools: Make pkg-config dependency checks usable by other tools

2024-07-03 Thread Steven Rostedt
On Tue, 2 Jul 2024 16:40:46 -0700 Namhyung Kim wrote: > +CC Steve and linux-trace-kernel list. There doesn't seem to be a cover page, and it doesn't apply on v6.10-rc6 nor on tip. -- Steve

Re: [PATCHv2 bpf-next 1/9] uprobe: Add support for session consumer

2024-07-03 Thread Andrii Nakryiko
On Wed, Jul 3, 2024 at 1:10 AM Peter Zijlstra wrote: > > On Tue, Jul 02, 2024 at 01:51:28PM -0700, Andrii Nakryiko wrote: > > > +static size_t ri_size(int sessions_cnt) > > > +{ > > > + struct return_instance *ri __maybe_unused; > > > + > > > + return sizeof(*ri) + sessions_cnt *

Re: [PATCH v2 02/12] uprobes: correct mmap_sem locking assumptions in uprobe_write_opcode()

2024-07-03 Thread Andrii Nakryiko
On Wed, Jul 3, 2024 at 6:15 AM Masami Hiramatsu wrote: > > On Mon, 1 Jul 2024 15:39:25 -0700 > Andrii Nakryiko wrote: > > > It seems like uprobe_write_opcode() doesn't require writer locked > > mmap_sem, any lock (reader or writer) should be sufficient. This was > > established in a discussion

Re: [PATCH v2 01/12] uprobes: update outdated comment

2024-07-03 Thread Andrii Nakryiko
On Wed, Jul 3, 2024 at 4:40 AM Oleg Nesterov wrote: > > Sorry for the late reply. I'll try to read this version/discussion > when I have time... yes, I have already promised this before, sorry :/ > > On 07/01, Andrii Nakryiko wrote: > > > > There is no task_struct passed into

Re: [PATCH v2 05/12] uprobes: move offset and ref_ctr_offset into uprobe_consumer

2024-07-03 Thread Andrii Nakryiko
On Wed, Jul 3, 2024 at 3:13 AM Masami Hiramatsu wrote: > > On Wed, 3 Jul 2024 10:13:15 +0200 > Peter Zijlstra wrote: > > > On Mon, Jul 01, 2024 at 03:39:28PM -0700, Andrii Nakryiko wrote: > > > Simplify uprobe registration/unregistration interfaces by making offset > > > and ref_ctr_offset part

Re: [PATCHv2 bpf-next 9/9] selftests/bpf: Add uprobe session consumers test

2024-07-03 Thread Jiri Olsa
On Tue, Jul 02, 2024 at 03:10:55PM -0700, Andrii Nakryiko wrote: > On Mon, Jul 1, 2024 at 9:44 AM Jiri Olsa wrote: > > > > Adding test that attached/detaches multiple consumers on > > single uprobe and verifies all were hit as expected. > > > > Signed-off-by: Jiri Olsa > > --- > >

Re: [PATCHv2 bpf-next 8/9] selftests/bpf: Add uprobe session recursive test

2024-07-03 Thread Jiri Olsa
On Tue, Jul 02, 2024 at 03:01:35PM -0700, Andrii Nakryiko wrote: > On Mon, Jul 1, 2024 at 9:43 AM Jiri Olsa wrote: > > > > Adding uprobe session test that verifies the cookie value is stored > > properly when single uprobe-ed function is executed recursively. > > > > Signed-off-by: Jiri Olsa > >

Re: [PATCHv2 bpf-next 5/9] libbpf: Add uprobe session attach type names to attach_type_name

2024-07-03 Thread Jiri Olsa
On Tue, Jul 02, 2024 at 02:56:34PM -0700, Andrii Nakryiko wrote: > On Mon, Jul 1, 2024 at 9:43 AM Jiri Olsa wrote: > > > > Adding uprobe session attach type name to attach_type_name, > > so libbpf_bpf_attach_type_str returns proper string name for > > BPF_TRACE_UPROBE_SESSION attach type. > > > >

Re: [PATCH v2] remoteproc: k3-dsp: Fix log levels where appropriate

2024-07-03 Thread Andrew Davis
On 6/26/24 2:14 PM, Garrett Giordano wrote: Driver was logging information as errors. Changed dev_err to dev_dbg where appropriate. Signed-off-by: Garrett Giordano --- Acked-by: Andrew Davis -v2 - Change from dev_info to dev_dbg - Drop k3-r5 PATCH ---

Re: [PATCHv2 bpf-next 4/9] libbpf: Add support for uprobe multi session attach

2024-07-03 Thread Jiri Olsa
On Tue, Jul 02, 2024 at 02:34:34PM -0700, Andrii Nakryiko wrote: > On Mon, Jul 1, 2024 at 9:42 AM Jiri Olsa wrote: > > > > Adding support to attach program in uprobe session mode > > with bpf_program__attach_uprobe_multi function. > > > > Adding session bool to bpf_uprobe_multi_opts struct that

Re: [PATCHv2 bpf-next 1/9] uprobe: Add support for session consumer

2024-07-03 Thread Jiri Olsa
On Tue, Jul 02, 2024 at 01:51:28PM -0700, Andrii Nakryiko wrote: SNIP > > #ifdef CONFIG_UPROBES > > @@ -80,6 +83,12 @@ struct uprobe_task { > > unsigned intdepth; > > }; > > > > +struct session_consumer { > > + __u64 cookie; > > + unsigned int

Re: [PATCH v2] net: missing check virtio

2024-07-03 Thread Michael S. Tsirkin
On Thu, Jun 13, 2024 at 12:54:48PM +0300, Denis Arefev wrote: > Two missing check in virtio_net_hdr_to_skb() allowed syzbot > to crash kernels again > > 1. After the skb_segment function the buffer may become non-linear > (nr_frags != 0), but since the SKBTX_SHARED_FRAG flag is not set anywhere >

Re: [PATCH vhost v2 19/24] vdpa/mlx5: Forward error in suspend/resume device

2024-07-03 Thread Eugenio Perez Martin
On Wed, Jun 26, 2024 at 12:28 PM Dragos Tatulea wrote: > > Start using the suspend/resume_vq() error return codes previously added. > > Reviewed-by: Cosmin Ratiu > Reviewed-by: Zhu Yanjun > Signed-off-by: Dragos Tatulea Reviewed-by: Eugenio Pérez > --- > drivers/vdpa/mlx5/net/mlx5_vnet.c |

Re: [PATCH vhost v2 16/24] vdpa/mlx5: Accept Init -> Ready VQ transition in resume_vq()

2024-07-03 Thread Eugenio Perez Martin
On Wed, Jun 26, 2024 at 12:28 PM Dragos Tatulea wrote: > > Until now resume_vq() was used only for the suspend/resume scenario. > This change also allows calling resume_vq() to bring it from Init to > Ready state (VQ initialization). > > Signed-off-by: Dragos Tatulea > Reviewed-by: Cosmin Ratiu

Re: [PATCHv2 bpf-next 1/9] uprobe: Add support for session consumer

2024-07-03 Thread Jiri Olsa
On Wed, Jul 03, 2024 at 05:31:32PM +0200, Jiri Olsa wrote: > On Tue, Jul 02, 2024 at 01:52:38PM -0700, Andrii Nakryiko wrote: > > On Tue, Jul 2, 2024 at 9:11 AM Jiri Olsa wrote: > > > > > > On Tue, Jul 02, 2024 at 03:04:08PM +0200, Peter Zijlstra wrote: > > > > On Mon, Jul 01, 2024 at 06:41:07PM

Re: [PATCH vhost v2 15/24] vdpa/mlx5: Allow creation of blank VQs

2024-07-03 Thread Eugenio Perez Martin
On Wed, Jun 26, 2024 at 12:28 PM Dragos Tatulea wrote: > > Based on the filled flag, create VQs that are filled or blank. > Blank VQs will be filled in later through VQ modify. > > Downstream patches will make use of this to pre-create blank VQs at > vdpa device creation. > s/Downstream/Later/ ?

Re: [PATCHv2 bpf-next 1/9] uprobe: Add support for session consumer

2024-07-03 Thread Jiri Olsa
On Tue, Jul 02, 2024 at 05:13:38PM -0700, Andrii Nakryiko wrote: > On Tue, Jul 2, 2024 at 4:55 PM Masami Hiramatsu wrote: > > > > Hi Jiri, > > > > On Mon, 1 Jul 2024 18:41:07 +0200 > > Jiri Olsa wrote: > > > > > Adding support for uprobe consumer to be defined as session and have > > > new

Re: [PATCH vhost 20/23] vdpa/mlx5: Pre-create hardware VQs at vdpa .dev_add time

2024-07-03 Thread Eugenio Perez Martin
On Wed, Jun 26, 2024 at 11:27 AM Dragos Tatulea wrote: > > On Wed, 2024-06-19 at 17:54 +0200, Eugenio Perez Martin wrote: > > On Mon, Jun 17, 2024 at 5:09 PM Dragos Tatulea wrote: > > > > > > Currently, hardware VQs are created right when the vdpa device gets into > > > DRIVER_OK state. That is

Re: [PATCHv2 bpf-next 1/9] uprobe: Add support for session consumer

2024-07-03 Thread Jiri Olsa
On Tue, Jul 02, 2024 at 01:52:38PM -0700, Andrii Nakryiko wrote: > On Tue, Jul 2, 2024 at 9:11 AM Jiri Olsa wrote: > > > > On Tue, Jul 02, 2024 at 03:04:08PM +0200, Peter Zijlstra wrote: > > > On Mon, Jul 01, 2024 at 06:41:07PM +0200, Jiri Olsa wrote: > > > > > > > +static void > > > >

Re: [PATCH] kallsyms, livepatch: Fix livepatch with CONFIG_LTO_CLANG

2024-07-03 Thread Luis Chamberlain
On Tue, Jul 02, 2024 at 10:56:41PM -0700, Josh Poimboeuf wrote: > On Mon, Jul 01, 2024 at 03:13:23PM +0200, Petr Mladek wrote: > > So, you suggest to search the symbols by a hash. Do I get it correctly? I meant, that in the Rust world the symbols go over the allowed limit, and so an alternative

Re: [PATCH v8 2/5] remoteproc: Add TEE support

2024-07-03 Thread Mathieu Poirier
On Fri, Jun 21, 2024 at 04:37:56PM +0200, Arnaud Pouliquen wrote: > Add a remoteproc TEE (Trusted Execution Environment) driver > that will be probed by the TEE bus. If the associated Trusted > application is supported on secure part this driver offers a client > interface to load a firmware by

Re: [PATCH v8 2/5] remoteproc: Add TEE support

2024-07-03 Thread Mathieu Poirier
On Wed, Jul 03, 2024 at 09:19:44AM +0200, Arnaud POULIQUEN wrote: > Hello Mathieu > > On 7/2/24 18:44, Mathieu Poirier wrote: > > Good morning, > > > > On Fri, Jun 21, 2024 at 04:37:56PM +0200, Arnaud Pouliquen wrote: > >> Add a remoteproc TEE (Trusted Execution Environment) driver > >> that

Re: [PATCH] dt-bindings: hwlock: sprd-hwspinlock: convert to YAML

2024-07-03 Thread Conor Dooley
On Wed, Jul 03, 2024 at 02:26:32PM +0200, Stanislav Jakubek wrote: > +examples: > + - | > +#include > + > +soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + hwlock@4050 { > +compatible = "sprd,hwspinlock-r3p0"; nit: double space here before the =

Re: [PATCH vhost v2 09/24] vdpa/mlx5: Rename init_mvqs

2024-07-03 Thread Eugenio Perez Martin
On Wed, Jun 26, 2024 at 12:27 PM Dragos Tatulea wrote: > > Function is used to set default values, so name it accordingly. > > Signed-off-by: Dragos Tatulea Reviewed-by: Eugenio Pérez > --- > drivers/vdpa/mlx5/net/mlx5_vnet.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-)

Re: [PATCH vhost v2 07/24] vdpa/mlx5: Initialize and reset device with one queue pair

2024-07-03 Thread Eugenio Perez Martin
On Wed, Jun 26, 2024 at 12:27 PM Dragos Tatulea wrote: > > The virtio spec says that a vdpa device should start off with one queue > pair. The driver is already compliant. > > This patch moves the initialization to device add and reset times. This > is done in preparation for the pre-creation of

Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore

2024-07-03 Thread Paul E. McKenney
On Wed, Jul 03, 2024 at 09:50:57AM +0200, Peter Zijlstra wrote: > On Tue, Jul 02, 2024 at 04:56:53PM -0700, Paul E. McKenney wrote: > > > > Paul, isn't this the RCU flavour you created to deal with > > > !rcu_is_watching()? The flavour that never should have been created in > > > favour of just

Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management

2024-07-03 Thread Peter Zijlstra
On Mon, Jul 01, 2024 at 03:39:27PM -0700, Andrii Nakryiko wrote: > One, attempted initially, way to solve this is through using > atomic_inc_not_zero() approach, turning get_uprobe() into > try_get_uprobe(), This is the canonical thing to do. Everybody does this. > which can fail to bump

Re: [PATCH v2 02/12] uprobes: correct mmap_sem locking assumptions in uprobe_write_opcode()

2024-07-03 Thread Google
On Mon, 1 Jul 2024 15:39:25 -0700 Andrii Nakryiko wrote: > It seems like uprobe_write_opcode() doesn't require writer locked > mmap_sem, any lock (reader or writer) should be sufficient. This was > established in a discussion in [0] and looking through existing code > seems to confirm that

<    1   2   3   4   5   6   7   8   9   10   >