[PATCH 4/3] net/bonding: Adhere to coding style: break line after the if condition

2007-11-28 Thread =?utf-8?q?Ferenc_W=C3=A1gner?=
Signed-off-by: Ferenc Wágner <[EMAIL PROTECTED]> --- Randy Dunlap <[EMAIL PROTECTED]> writes: > Wagner Ferenc wrote: >> Randy Dunlap <[EMAIL PROTECTED]> writes: >> >>> Patches 1 & 3 use >>> >>> if (res) statement; >>> >>> but the preferred form is >>> >>> if (res) >>> statement

[PATCH 3/3] net/bonding: Purely cosmetic: rename a local variable.

2007-11-27 Thread =?utf-8?q?Ferenc_W=C3=A1gner?=
Code for rendering multivalue sysfs files occurs three times in this module. Rename 'buffer' to 'buf' in the first, for the sake of consistency. Signed-off-by: Ferenc Wágner <[EMAIL PROTECTED]> --- drivers/net/bonding/bond_sysfs.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-

[PATCH 2/3] net/bonding: Return nothing for not applicable values

2007-11-27 Thread =?utf-8?q?Ferenc_W=C3=A1gner?=
The previous code returned '\n' (that is, a single empty line) from most files, with one exception (xmit_hash_policy), where it returned 'NA\n'. This patch consolidates each file to return nothing at all if not applicable, not even a '\n'. I find this behaviour more usual, more useful, more effic

[PATCH 1/3] Remove trailing NULs from network bonding sysfs interface.

2007-11-27 Thread =?utf-8?q?Ferenc_W=C3=A1gner?=
Also remove trailing spaces from multivalued files. This fixes output like for example: $ od -c /sys/class/net/bond0/bonding/slaves 000 e t h - l e f t e t h - r i g 020 h t \n \0 025 It mostly entails deleting '+1'-s after sprintf() calls: