Re: [PATCH] w1: matrox: use DEFINE_PCI_DEVICE_TABLE macro

Hi 28.11.2013, 08:40, "Jingoo Han" : > "Yeah, and it's a horrid macro that deserves to be removed, please don't > use it in more places. > > Actually, if you could just remove it, that would be best, sorry, I'm > not going to take these patches." > > So, I will send the patch to remove 'DEFINE_PC

Re: [PATCH] drivers: w1: make w1_slave::flags long to avoid casts

Hi 02.11.2013, 20:59, "Michal Nazarewicz" : >>  Argh, why would we just don't do that? Its in-memory field, it can be >>  anything, I wouldn't be surprised if it even can be non-atomic because >>  of proper locks already being held > > If the driver does not require an atomic set_bit operation for

Re: [PATCH] drivers: w1: make w1_slave::flags long to avoid casts

Hi 01.11.2013, 23:30, "Andrew Morton" : > set_bit() operates on longs.  So if we do > > struct foo { > u32 a; > u32 b; > } f; > > ... > set_bit(0, (long *)&f.a); > ... > > then we'll scribble on f.b on a big-endian 64-bit machine. Argh, why would we just d

Re: [PATCH] w1: ds1wm: remove deprecated IRQF_DISABLED

Hi 13.10.2013, 11:23, "Michael Opdenacker" : > This patch proposes to remove the use of the IRQF_DISABLED flag > > It's a NOOP since 2.6.35 and it will be removed one day. > > Signed-off-by: Michael Opdenacker Both patches look good, thank you Greg, please pull them into your tree Acked-by: Evg

Re: [PATCH 01/11] w1: add attribute groups to struct w1_family_ops

Hi 22.08.2013, 02:45, "Greg Kroah-Hartman" : > This lets w1 slave drivers declare an attribute group, and not have to > create/destroy sysfs files directly.  All w1 slave drivers will be fixed > to use this field up in follow-on patches to this one. Sounds reasonble, saves fair amount of code in

Re: [PATCH] w1: replace strict_strtol() with kstrtol()

27.07.2013, 03:16, "GregKH" : > On Tue, Jul 23, 2013 at 12:00:44AM +0400, Evgeniy Polyakov wrote: > >>  Hi everyone >> >>  19.07.2013, 11:16, "Jingoo Han" : >>>  The usage of strict_strtol() is not preferred, because >>>  strict_strtol() is obsolete. Thus, kstrtol() should be >>>  used. >>  Looks