Re: Re: [PATCH] vhost/scsi: Fix improper cleanup in vhost_scsi_set_endpoint()

2025-01-19 Thread
On 2025-01-18 01:11:01, Mike Christie wrote: > I can't tell if being able to call VHOST_SCSI_SET_ENDPOINT multiple > times without calling VHOST_SCSI_CLEAR_ENDPOINT between calls is an > actual feature that the code was trying to support or that is the > root bug. It's so buggy I feel like it was n

Re: Re: [PATCH] vhost/scsi: Fix improper cleanup in vhost_scsi_set_endpoint()

2025-01-18 Thread
On 2025-01-18 00:50:04, Mike Christie wrote: > Yeah, I'm not sure if being able to call vhost_scsi_set_endpoint multiple > times and pick up new tpgs is actually a feature or not. There's so many > bugs and it also doesn't support tpg removal. It seems vhost_scsi_clear_endpoint() is attempting to

Re: Re: [PATCH] vhost/scsi: Fix improper cleanup in vhost_scsi_set_endpoint()

2025-01-14 Thread
Yes, and it also protects the kernel from the PoC, as I've tested. On 2025-01-14 10:17:50 Lei Yang wrote: > I tested this patch with virtio-net regression tests, everything works fine. > > Tested-by: Lei Yang > > > On Mon, Jan 13, 2025 at 5:20 AM Mike Christie > wrote: > > > > On 1/12/25 11:3

Re: Re: [PATCH] vhost/scsi: Fix improper cleanup in vhost_scsi_set_endpoint()

2025-01-13 Thread
On 2025-01-13 01:35:20, Michael Christie wrote: > > On 1/10/25 9:34 PM, Haoran Zhang wrote: > > Since commit 3f8ca2e115e55 ("vhost scsi: alloc cmds per vq instead of > > session"), a bug can be triggered when the host sends a duplicate > > VHOST_SCSI_SET_ENDPOINT ioctl command. > > I don't thi

Re: Re: [PATCH] vhost/scsi: Fix improper cleanup in vhost_scsi_set_endpoint()

2025-01-11 Thread
Hi Kuan-Wei, On Sat, Jan 11, 2025 at 13:45:50 +0800, Kuan-Wei Chiu wrote: > Hi Haoran, > > On Sat, Jan 11, 2025 at 11:34:18AM +0800, Haoran Zhang wrote: > > Since commit 3f8ca2e115e55 ("vhost scsi: alloc cmds per vq instead of > > session"), a bug can be triggered when the host sends a duplicate