Re: [PATCH] media: mtk-vcodec: Always signal source change event on format change

2018-01-09 Thread
Reviewed-by: Wu-Cheng Li On Tue, Jan 9, 2018 at 4:42 PM, Tomasz Figa wrote: > Currently the driver signals the source change event only in case of > a midstream resolution change, however the initial format detection > is also defined as a source change by the V4L2 codec API specification. > Fix

Re: [PATCH] [media] mtk-mdp: Fix g_/s_selection capture/compose logic

2017-04-12 Thread
Reviewed-by: Wu-Cheng Li On Thu, Apr 13, 2017 at 12:18 PM, Minghsiu Tsai wrote: > From: Daniel Kurtz > > Experiments show that the: > (1) mtk-mdp uses the _MPLANE form of CAPTURE/OUTPUT > (2) CAPTURE types use CROP targets, and OUTPUT types use COMPOSE targets > > Signed-off-by: Daniel Kurtz

Re: [PATCH] media: mtk-jpeg: fix continuous log "Context is NULL"

2017-03-14 Thread
On Tue, Mar 14, 2017 at 10:21 PM, Minghsiu Tsai wrote: > The symptom is continuous log "mtk-jpeg 18004000.jpegdec: Context is NULL" > in kernel log. It is becauese the error handling in irq doesn't clear > interrupt. > > The calling flow like as below when issue happen > mtk_jpeg_device_run() > mt

Re: [PATCH 1/1] mtk-vcodec: check the vp9 decoder buffer index from VPU.

2017-03-07 Thread
On Tue, Mar 7, 2017 at 3:59 PM, Tiffany Lin wrote: > On Tue, 2017-03-07 at 14:03 +0800, Wu-Cheng Li wrote: >> From: Wu-Cheng Li >> >> VPU firmware has a bug and may return invalid buffer index for >> some vp9 videos. Check the buffer indexes before accessing the >> buffer. >> >> Signed-off-by: Wu

Re: [PATCH v3 3/9] DocBook/v4l: Add compressed video formats used on MT8173 codec driver

2016-07-12 Thread
On Wed, Jul 13, 2016 at 3:14 AM, Nicolas Dufresne wrote: > Le mardi 12 juillet 2016 à 15:08 -0400, Nicolas Dufresne a écrit : >> Le mardi 12 juillet 2016 à 16:16 +0800, Wu-Cheng Li (李務誠) a écrit : >> > Decoder hardware produces MT21 (compressed). Image processor can >>

Re: [PATCH v3 3/9] DocBook/v4l: Add compressed video formats used on MT8173 codec driver

2016-07-12 Thread
On Mon, Jul 11, 2016 at 10:56 AM, tiffany lin wrote: > Hi Hans, > > On Fri, 2016-07-08 at 12:23 +0200, Hans Verkuil wrote: >> On 05/30/2016 02:29 PM, Tiffany Lin wrote: >> > Add V4L2_PIX_FMT_MT21 documentation >> > >> > Signed-off-by: Tiffany Lin >> > --- >> > Documentation/DocBook/media/v4l/pix

Re: [PATCH v3 0/9] Add MT8173 Video Decoder Driver

2016-07-01 Thread
+Andrew. Last I heard the license was ready and Andrew was preparing the VPU firmware. Andrew. Is the firmware ready to submit? On Fri, Jul 1, 2016 at 6:11 PM, Hans Verkuil wrote: > On 06/16/2016 12:54 PM, Mauro Carvalho Chehab wrote: >> Em Tue, 14 Jun 2016 19:08:08 +0800 >> tiffany lin escreveu

Re: [PATCH v3 0/9] Add MT8173 Video Decoder Driver

2016-06-14 Thread
On Wed, Jun 8, 2016 at 6:13 AM, Hans Verkuil wrote: > > > On 06/07/2016 11:22 PM, Mauro Carvalho Chehab wrote: >> >> Em Mon, 30 May 2016 20:29:14 +0800 >> Tiffany Lin escreveu: >> >>> == >>> Introduction >>> == >>> >>> The purpose of this series is to add the driver for

Re: [PATCH v7 5/8] [media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

2016-04-24 Thread
> > > > ... > > > > > +static int fops_vcodec_open(struct file *file) > > > +{ > > > + struct video_device *vfd = video_devdata(file); > > > + struct mtk_vcodec_dev *dev = video_drvdata(file); > > > + struct mtk_vcodec_ctx *ctx = NULL; > > > + int ret = 0; > > > + > > > + if (dev->instanc

Re: [PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

2016-02-22 Thread
On Thu, Feb 4, 2016 at 7:35 PM, Tiffany Lin wrote: > From: Andrew-CT Chen > > Add v4l2 layer encoder driver for MT8173 > > Signed-off-by: Tiffany Lin > --- > drivers/media/platform/Kconfig | 11 + > drivers/media/platform/Makefile|2 + > drivers/med

Re: [PATCH v4 2/8] [media] VPU: mediatek: support Mediatek VPU

2016-02-15 Thread
On Thu, Feb 4, 2016 at 7:34 PM, Tiffany Lin wrote: > The VPU driver for hw video codec embedded in Mediatek's MT8173 SOCs. > It is able to handle video decoding/encoding of in a range of formats. > The driver provides with VPU firmware download, memory management and > the communication interface

Re: [PATCH v4 0/2] new control V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME

2016-01-24 Thread
Hi Hans, Can you look at the patch again? I've changed the name from V4L2_CID_MPEG_VIDEO_FORCE_I_FRAME to V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME. Thanks. Wu-Cheng On Tue, Jan 19, 2016 at 3:07 PM, Wu-Cheng Li wrote: > v4 changes: > - Change the name to V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME. > - Add co